Almir Vuk [Thu, 10 Jan 2019 16:21:29 +0000 (17:21 +0100)]
[Enhancement] Entry: Read-only Entry and Editor (#1972)
- fixes #1678
- fixes #4834
* InputView BindableProperty IsReadOnly
* Android Editor and Entry setup
* MacOS Editor and Entry setup
* Tizen Editor and Entry setup
* UAP Editor and Entry setup
* WPF Editor and Entry setup
* iOS Editor and Entry setup
* Issue1678 - TestContentPage added
* Tests added
* Tizen Editor and Entry fix
* UI Test fix
* Android fix for Entry and Editor.
* Unit Tests fix.
* Android Renderer first try.
* MacOS Entry renderer small fix.
* UpdateEditable fix.
* Android Entry and Editor reduced number of calls to BP.
* fix TestAttributes conflicts
* Remove keyboard
* [macOS] relinquish first responder
* [Android] remove call to UpdateCursorSelection
* [UWP] fix tabs
Joris Vergeer [Thu, 10 Jan 2019 16:01:18 +0000 (17:01 +0100)]
[Android] Fix for ListViewRenderer causing ObjectDisposedException (#4931)
* [Android] Fix for ListViewRenderer causing ObjectDisposedException
* Probably cleaner to use _refresh for IsDisposed check
E.Z. Hart [Thu, 10 Jan 2019 11:42:40 +0000 (04:42 -0700)]
Only post DisableTimer to the queue if it's not on the UI thread (#4866)
Artem Utin [Tue, 8 Jan 2019 01:17:28 +0000 (11:17 +1000)]
added case in GTK listviewrendered for change of SelectedItem property (#4757)
Stephane Delcroix [Mon, 7 Jan 2019 09:03:47 +0000 (10:03 +0100)]
Merge branch '3.5.0'
E.Z. Hart [Mon, 7 Jan 2019 00:37:42 +0000 (17:37 -0700)]
Add missing preserve attribute for UI test 1267
E.Z. Hart [Sat, 5 Jan 2019 23:42:09 +0000 (16:42 -0700)]
Fix test 852
E.Z. Hart [Fri, 4 Jan 2019 23:39:44 +0000 (16:39 -0700)]
Merge branch '3.5.0' of github.com:xamarin/Xamarin.Forms into 3.5.0
E.Z. Hart [Fri, 4 Jan 2019 21:11:33 +0000 (14:11 -0700)]
Automate UI test 1267
E.Z. Hart [Fri, 4 Jan 2019 20:12:51 +0000 (13:12 -0700)]
Automate UI test 1236
E.Z. Hart [Fri, 4 Jan 2019 19:55:50 +0000 (12:55 -0700)]
Automate UI test 1219
E.Z. Hart [Fri, 4 Jan 2019 19:34:15 +0000 (12:34 -0700)]
Add manual test instructions for 1075, match button text with actual color
E.Z. Hart [Fri, 4 Jan 2019 19:08:48 +0000 (12:08 -0700)]
Automate UI test 1028
E.Z. Hart [Fri, 4 Jan 2019 18:34:07 +0000 (11:34 -0700)]
Add manual instructions to UI test 1026
E.Z. Hart [Fri, 4 Jan 2019 18:21:24 +0000 (11:21 -0700)]
Add manual test run instructions for UI test 1025
E.Z. Hart [Thu, 3 Jan 2019 22:56:42 +0000 (15:56 -0700)]
Clean up old comments
E.Z. Hart [Thu, 3 Jan 2019 22:37:36 +0000 (15:37 -0700)]
Add instructions for test 764; remove automated test that did nothing;
kingces95 [Thu, 3 Jan 2019 17:46:40 +0000 (07:46 -1000)]
Min viable FontImageSource (#4747)
* min viable fontImageSource
* [UWP] Min viable FontImageSource (#4817)
* [UWP] font image source
* address comment
* [UWP] performance optimization of the rendering of icons font
- the minimum Dpi of the icon is 300
* char -> string; CR feedback
E.Z. Hart [Thu, 3 Jan 2019 17:01:57 +0000 (10:01 -0700)]
Make test button visible on UWP
E.Z. Hart [Thu, 3 Jan 2019 16:57:30 +0000 (09:57 -0700)]
Remove nonsensical comments
E.Z. Hart [Thu, 3 Jan 2019 01:40:48 +0000 (18:40 -0700)]
Add instructions to manual UI test
E.Z. Hart [Thu, 27 Dec 2018 02:16:36 +0000 (19:16 -0700)]
Implement Android single selection in CollectionView (#4651)
* Implement Android single selection
* Fix naming conflicts with SelectionChangedEventArgs
* Split files by class; make SelectionChangedEventArgs constructors internal;
Optimizations for SelectionChangedEventArgs;
Fire selection changed event/command from property changed handler;
* Update Xamarin.Forms.Core/Items/SelectableItemsView.cs
Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
* Set default value for SelectedItemProperty
* Remove unnecessary null check
* Fix order of OnElementChanged and Setup/Teardown Element
* Fix project file weirdness
Akihiko Odaki [Sat, 22 Dec 2018 16:58:06 +0000 (01:58 +0900)]
[XamlC] Test generic parameters to evaluate equality of types (#4062)
E.Z. Hart [Sat, 22 Dec 2018 13:54:18 +0000 (06:54 -0700)]
Make ListView CachingStrategy property visible to Intellisense (#4846)
adrianknight89 [Fri, 21 Dec 2018 15:28:06 +0000 (09:28 -0600)]
[iOS] Added RowAnimationsEnabled platform specific to control row animations (#4709)
* added platform specific
* changed method signatures
* addressed changes
Stephane Delcroix [Fri, 21 Dec 2018 15:27:13 +0000 (16:27 +0100)]
[Shell] fix queryParam navigation (#4843)
when navigating to pages, not shell-section, handle the queryParams
- fixes #4837
Kangho Hur [Fri, 21 Dec 2018 09:04:30 +0000 (01:04 -0800)]
[Tizen] Supports Picker.TitleColor, FontSize, FontFamily and FontAttributes (#4839)
Stephane Delcroix [Fri, 21 Dec 2018 08:23:41 +0000 (09:23 +0100)]
[Flex] fix Padding on the FlexLayout (#4823)
As the flex engine doesn't handle x,y offset on the root layout,
handle that at the XF.FlexLayout level.
- fixes #2663
Stephane Delcroix [Fri, 21 Dec 2018 08:06:52 +0000 (09:06 +0100)]
[*] Drop MenuItem.IsEnabledPropertyName (#4659)
* [*] Drop MenuItem.IsEnabledPropertyName
While doing one of the big refactoring of 2006, we missed an
opportunity to use a propertyKey for IsEnabled, ending up in some
less-than-optimal design choices, like IMenuController.IsEnabledPropertyName.
Properly using a public r-o BP removes the need for IsEnabledPropertyName.
* other plats
* use the key
E.Z. Hart [Thu, 20 Dec 2018 21:58:22 +0000 (14:58 -0700)]
Remove unnecessary OK button check that won't pass on older Android versions
Stephane Delcroix [Thu, 20 Dec 2018 12:16:46 +0000 (13:16 +0100)]
XmlnsPrefix d: (#4781)
be ready for when we'll merge #4743
Stephane Delcroix [Thu, 20 Dec 2018 12:16:40 +0000 (13:16 +0100)]
[X] Design time properties (#4743)
An alternate xaml resource file provider can request the XamlLoader to
_not_ ignore normally ignored properties in prebuilt XF design xmlns, as
in the following snippet:
```xaml
<ContentPage
xmlns="http://xamarin.com/schemas/2014/forms""
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml""
xmlns:d="http://xamarin.com/schemas/2014/forms/design""
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006""
mc:Ignorable="d"">
<Label d:Text="Bar" Text="Foo" x:Name="label" />
</ContentPage>
```
The `d:` should be the prefix used by default for this, but any other
prefix will do too.
The `d:Text` property maps to the exact same property as `Text`, as the
XmllnsDefinitionAttributes are identical (that's convenient from a Intelisense
point of view), but, when (and only when) instructed by a provided Xaml resource
loader, the `d:Text` will override the `Text` property.
This works with virtually all properties defined on built-in Xamarin.Forms
controls, but it doesn't mean it's a sane idea to try to assign design value
to all existing properties.
The APi ofr setting the ResourceLoader had to change, and instead of taking
pre-defined arguments, it accepts and returns query and response types. This
is slightly less convenient to invoke through reflection, but way more easy
to extend in the future.
Shane Neuville [Thu, 20 Dec 2018 08:27:01 +0000 (01:27 -0700)]
[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4819)
Stephane Delcroix [Wed, 19 Dec 2018 15:14:21 +0000 (16:14 +0100)]
[Xaml] require escaping curly braces (#4723)
This is a breaking change as we weren't throwing errors on that before.
- fixes #2756
Stephane Delcroix [Wed, 19 Dec 2018 14:10:08 +0000 (15:10 +0100)]
[XamlC] instantiate generic parameter on base types (#4776)
* [XamlC] Instantiate generic parameters in base type generic arguments
* Add unit test for #4047
- fixes #4760
- closes #4047
Stephane Delcroix [Wed, 19 Dec 2018 13:23:44 +0000 (14:23 +0100)]
[C] WeakEventManager minor changes (#4774)
As pointed in https://github.com/xamarin/Xamarin.Forms/issues/4750#issuecomment-
447673540,
internal WeakEventManager usage can be simplified.
This also updates the code to ValueTuple, throw expressions, ...
Shane Neuville [Wed, 19 Dec 2018 01:22:12 +0000 (18:22 -0700)]
[Android] Check if Drawable is null in Draw override (#4783)
- fixes #4782
Stephane Delcroix [Tue, 18 Dec 2018 23:54:45 +0000 (00:54 +0100)]
[X] throw XPE on missing element .ctor (#4786)
* [X] throw XPE on missing element .ctor
In case of runtime parse, wrap the MissingMethodException in a
XamlParseException, to get lineInfo. In case of XamlC, detect missing
constructor and fail early.
- fixes #4751
* fix for ns1.0
Akihiko Odaki [Tue, 18 Dec 2018 19:21:53 +0000 (04:21 +0900)]
[XamlC] Always enable implicit casting, boxing and unboxing (#4238)
Rui Marinho [Tue, 18 Dec 2018 14:19:27 +0000 (14:19 +0000)]
Merge branch '3.5.0'
Rui Marinho [Tue, 18 Dec 2018 14:18:26 +0000 (14:18 +0000)]
Merge branch '3.4.0' into 3.5.0
Rui Marinho [Tue, 18 Dec 2018 13:03:25 +0000 (13:03 +0000)]
[Controls] Remove default timeout test #2482
Samantha Houts [Tue, 18 Dec 2018 13:01:48 +0000 (05:01 -0800)]
[Android] Avoid acting on a disposed reference (#4780)
Kangho Hur [Tue, 18 Dec 2018 12:58:58 +0000 (04:58 -0800)]
[Tizen] Supports SwitchCell.OnColor (#4785)
Gerald Versluis [Tue, 18 Dec 2018 12:12:30 +0000 (13:12 +0100)]
[C, iOS, AND, UWP] Color for Picker.Title (#4701)
* Implemented Core, iOS and Android
* Implemented UWP
* Processed code review feedback
* More code review feedback
And implemented reset scenarios for all platforms
* Also apply color to popup dialog on Android
- fixes #4669
Akihiko Odaki [Tue, 18 Dec 2018 11:07:49 +0000 (20:07 +0900)]
[XamlC] Resolve generic parameters of a method with generic return type (#4244)
Stephane Delcroix [Mon, 17 Dec 2018 19:10:18 +0000 (20:10 +0100)]
Revert "Properly detect SDK style projects (#4699)"
This reverts commit
36b5345596180a62c732836b7ff20484b76861af.
Rui Marinho [Mon, 17 Dec 2018 10:43:17 +0000 (10:43 +0000)]
[IOS] Add launch storyboard (#4724)
* [IOS} Add launch storyboard
* [Mac] Fix csproj
* [Controls] Update MinimumOSVersion iOS
* [Controls] Remove missing file reference
* Update Xamarin.Forms.ControlGallery.MacOS.csproj
Rui Marinho [Mon, 17 Dec 2018 09:55:23 +0000 (09:55 +0000)]
[UItests] Fix UITest 41424 (#4745)
* [UITests] Delay for showing picker
* [UITests] Another try to wait for picker opened
Samantha Houts [Fri, 14 Dec 2018 19:00:28 +0000 (11:00 -0800)]
Merge branch '3.5.0'
Samantha Houts [Fri, 14 Dec 2018 00:17:21 +0000 (16:17 -0800)]
Merge branch '3.4.0' into 3.5.0
E.Z. Hart [Thu, 13 Dec 2018 23:52:32 +0000 (16:52 -0700)]
[iOS] Update cell size estimates after empty data source (#4688) fixes #4600
* Create gallery to test issue
* Prevent DetermineCellSize loop; allow autolayout to size first cell after
initially empty data source; update estimates after initially empty data source;
fixes #4600
* Automated test
* Fix typo in comments
* Using Ignore to avoid running test because UI tests seems to ignore Explicit
* Change `_previousCount` to `bool _wasEmpty`
Shane Neuville [Thu, 13 Dec 2018 23:46:29 +0000 (16:46 -0700)]
update to preview9 and uncomment no longer broken interface (#4727)
Pavel Yakovlev [Thu, 13 Dec 2018 23:44:53 +0000 (02:44 +0300)]
[Android] fixes pop-up dialog in Pickers when you call Focus() (#4725)
* [Android] fixes pop-up dialog in Pickers when you call Focus()
* [Android] Extract the popup-on-focus logic
- the will be useful when other, non-EditText triggers are used
- this can be extended later if more features are needed
- no specific types in base types
Shane Neuville [Thu, 13 Dec 2018 23:41:05 +0000 (16:41 -0700)]
Add NUnitTestAdapter to xamarin ui test projects so VSIX isn't required for running UI Tests (#4719)
* add NUnitTestAdapter to xamarin ui test projects
* NUnitTestAdapter not needed on ios project
* NUnitTestAdapter not needed on macOS project
Shane Neuville [Thu, 13 Dec 2018 19:15:39 +0000 (12:15 -0700)]
delay ui test a bit so elements can vanish first (#4726)
Shane Neuville [Thu, 13 Dec 2018 16:48:18 +0000 (09:48 -0700)]
remove armeabi and set HttpClient Implementation on iOS to NSUrlSession (#4717)
* remove armeabi and set Http Client Implementation to NSUrlSession
* remove armeabi
Stephane Delcroix [Wed, 12 Dec 2018 15:50:30 +0000 (16:50 +0100)]
[Xaml] throw on unexpected empty elements (#4582)
new exception being thrown:
>Xamarin.Forms.Xaml.XamlParseException : Position 7:4. Unexpected empty element '<Grid.ColumnDefinitions/>'
also reduce the number of places we resolve lineInfo for exceptions
purposes
- fixes #4553
Daniel Cazzulino [Wed, 12 Dec 2018 09:33:08 +0000 (06:33 -0300)]
Properly detect SDK style projects (#4699)
The `$(MSBuildSDKsPath)` is actually *always* set whenever there are MSBuild SDKs
*installed*, not necessarily when the current project is an SDK-style project itself.
This means that we're potentially adding duplicate items and otherwise disrupting
normal operation of the non-SDK style projects with this import.
So use the well-known properties that are set by the .NET [Sdk.props](https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L22-L27) file instead,
which is the first imported target even before nuget-provided .props files.
E.Z. Hart [Tue, 11 Dec 2018 18:41:30 +0000 (11:41 -0700)]
[Android] ItemContentView should use all available space (#4569) fixes #4406
* [Android] ItemContentView should use all available space; fixes #4406
Fix inconsistent/inaccurate class naming for cells/views.
* Update Xamarin.Forms.Platform.Android/CollectionView/SizedItemContentView.cs
Add missing space.
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Make ReuseId values match class names
E.Z. Hart [Mon, 10 Dec 2018 20:36:36 +0000 (13:36 -0700)]
Merge branch '3.5.0'
E.Z. Hart [Mon, 10 Dec 2018 20:35:09 +0000 (13:35 -0700)]
Root the XFBuildTasksLocation path
Stephane Delcroix [Mon, 10 Dec 2018 07:55:42 +0000 (08:55 +0100)]
Merge branch '3.5.0'
Stephane Delcroix [Mon, 10 Dec 2018 07:55:03 +0000 (08:55 +0100)]
revert package downgrade
DavidRoqueni [Sun, 9 Dec 2018 08:49:10 +0000 (01:49 -0700)]
Updated README to reflect correct name (#4687)
Corrected typo to reflect the correct Android name.
Stephane Delcroix [Sun, 9 Dec 2018 08:33:09 +0000 (09:33 +0100)]
Merge branch '3.5.0'
Stephane Delcroix [Sun, 9 Dec 2018 08:32:34 +0000 (09:32 +0100)]
fix merge mistake
Rui Marinho [Sun, 9 Dec 2018 01:16:23 +0000 (01:16 +0000)]
Merge branch '3.5.0'
Rui Marinho [Sun, 9 Dec 2018 00:51:34 +0000 (00:51 +0000)]
Merge 3.4.0 to 3.5.0
Stephane Delcroix [Sun, 9 Dec 2018 00:31:53 +0000 (01:31 +0100)]
[build] add a Directory.Build.props (#4672)
Copying <PropertyGroup>s on (almost) every .csproj, and get the
relative paths just right is tedious. Starting msbuild 15 (vs2017)
we can use a Directory.Build.props (and Directory.Build.targets)
so I see no reason why we shouldn't.
see https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2017
Stephane Delcroix [Sat, 8 Dec 2018 09:03:34 +0000 (10:03 +0100)]
[tasks] Build.Tasks targets net46 (#4670)
* [tasks] Build.Tasks targets net46
Build tasks in VS MUST target net46 and no higher
- fixes #4667
* fix nuspec
Stephane Delcroix [Sat, 8 Dec 2018 08:53:07 +0000 (09:53 +0100)]
[XamlC] Compile the {DataTemplate} markup (#4641)
* [XamlC] Compile the {DataTemplate} markup
- fixes #4592
* [C] throw XPE on missing mandatory member
TypeName for {Type} and {DataTemplate} markup extensions is mandatory.
Throw a XamlParseException, with context, when that happens.
* fix style
* (ab)use of nameof
Samantha Houts [Fri, 7 Dec 2018 18:01:33 +0000 (10:01 -0800)]
Update issue templates
jcmanke [Fri, 7 Dec 2018 13:31:56 +0000 (07:31 -0600)]
Change SearchBar base class to InputView (#3248) fixes #2902
* Changed SearchView base class from View to InputView
* Minor code cleanup
Andrei [Fri, 7 Dec 2018 13:30:40 +0000 (16:30 +0300)]
[iOS] Change default background color of Cell to UIColor.Clear (#4002) fixes #3450
* fix https://github.com/xamarin/Xamarin.Forms/issues/3450
* Added possibility to configure cell background color for iOS
* Update Xamarin.Forms.Platform.iOS/Cells/CellRenderer.cs
* Fixed merge suggestion issue
* Update Xamarin.Forms.Core/PlatformConfiguration/iOSSpecific/Cell.cs
Co-Authored-By: AndreiMisiukevich <andrei.misiukevich@gmail.com>
* Update Xamarin.Forms.Core/PlatformConfiguration/iOSSpecific/Cell.cs
Co-Authored-By: AndreiMisiukevich <andrei.misiukevich@gmail.com>
* Update Xamarin.Forms.Core/PlatformConfiguration/iOSSpecific/Cell.cs
Co-Authored-By: AndreiMisiukevich <andrei.misiukevich@gmail.com>
Rui Marinho [Fri, 7 Dec 2018 11:31:41 +0000 (11:31 +0000)]
[Build] Don't build Tizen and Design projects on iPhone of iPhoneSimulator (#4646)
* [Build] Don't build Tizen and Design projects on iPhone of iPhoneSimulator
* [Build] Update build
Stephane Delcroix [Fri, 7 Dec 2018 10:16:04 +0000 (11:16 +0100)]
bump gitinfo
kingces95 [Fri, 7 Dec 2018 00:56:29 +0000 (14:56 -1000)]
GH 4444; Fix local nuget build script (#4668)
Matthew Leibowitz [Fri, 7 Dec 2018 00:55:31 +0000 (02:55 +0200)]
Added the style from .NET Foundation plus variances (#4575)
Pavel Yakovlev [Fri, 7 Dec 2018 00:54:44 +0000 (03:54 +0300)]
[Android] fixes crash when switching Bottom Navigation Tabs too fast or click on More menu (#4617) fixes #4382
Stephane Delcroix [Fri, 7 Dec 2018 00:53:50 +0000 (01:53 +0100)]
[Shell] expose CurrentShell (#4626) fixes #4625
* [Shell] expose CurrentShell
- fixes #4625
* Update Xamarin.Forms.Core/Shell/Shell.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
Stephane Delcroix [Thu, 6 Dec 2018 11:02:49 +0000 (12:02 +0100)]
[test] add passing test for #4572 (#4656)
- closes #4572
Stephane Delcroix [Thu, 6 Dec 2018 08:24:12 +0000 (09:24 +0100)]
Update issue templates
Shane Neuville [Wed, 5 Dec 2018 00:55:00 +0000 (17:55 -0700)]
[Android] Fix ImageSource being set to null and fix ImageCell so it loads images (#4601) fixes #4597 fixes #4584
* [Android] fix imageCell and null ImageSource
* [iOS] fixed ui tests for iOS
* [Android] fix FR UI Tests
* suggested formatting fixes
Pavel Yakovlev [Wed, 5 Dec 2018 00:54:00 +0000 (03:54 +0300)]
[Android] fixes Picker list showing up incorrectly when focus is set on other controls (#4344) fixes #4318 fixes #4187 fixes #4494
* [Android] fixes Picker list shows up, when focus is set on other controls
* - fixes Picker outside the cell, when you tap on the adjacent EditBox
- address comments
* [Android] added automated UItest
* [Android] added automated test in the carousel
* correct namespace UITest
* fix uitest
* fix uitest #2
* [Controls] Add test for #4494
* minor formating
Rui Marinho [Tue, 4 Dec 2018 23:04:14 +0000 (23:04 +0000)]
Merge branch '3.5.0'
Rui Marinho [Tue, 4 Dec 2018 23:03:31 +0000 (23:03 +0000)]
Merge branch '3.4.0' into 3.5.0
Shane Neuville [Tue, 4 Dec 2018 22:27:07 +0000 (15:27 -0700)]
remove nupkgs (#4633)
* remove nupkgs
* add nupkg to gitignore
* add pdb to gitignore
Paul Datsiuk [Tue, 4 Dec 2018 19:49:07 +0000 (21:49 +0200)]
[Android] Java.Lang.RuntimeException: Animators may only be run on Lo… (#4177)
* [Android] Java.Lang.RuntimeException: Animators may only be run on Looper threads on Battery Saver Mode
https://github.com/xamarin/Xamarin.Forms/issues/4176
* rewrite code to BeginInvokeOnMainThread
- fixes #4176
Matthew Richardson [Tue, 4 Dec 2018 19:08:13 +0000 (19:08 +0000)]
[Enhancement] Add drag started and completed events/commands to Slider (#4423) fixes #1450
* Implement DragStarted and DragCompleted events/commands in Slider.
* Add Tizen support.
* Use explicit interface implementation.
* Fix unit tests.
* Update Xamarin.Forms.Core/ISliderController.cs
Co-Authored-By: velocitysystems <matthew@velocitysystems.co.nz>
* Fix whitespace.
* Add missing namespace import
Stephane Delcroix [Tue, 4 Dec 2018 18:36:29 +0000 (19:36 +0100)]
[Xaml] expose XmlnsPrefixAttribute (#4562)
Expose the XmlnsPrefixAttribute, that can be used by external tools to
support object tree serialixation to Xaml.
- fixes #3191
Andrei [Tue, 4 Dec 2018 18:35:23 +0000 (21:35 +0300)]
[Android] Crash at Dependency service call possible fix (#4157)
* https://github.com/xamarin/Xamarin.Forms/issues/4097 possible fix
* renamed lock object
* updated DS and sample
* merge fix
- fixes #4097
kingces95 [Tue, 4 Dec 2018 18:28:35 +0000 (08:28 -1000)]
Ignore context change to null on UAP listview (#4412) fixes #4373
Stephane Delcroix [Tue, 4 Dec 2018 18:21:36 +0000 (19:21 +0100)]
[XamlC] test for null in Binding paths (#4521) fixes #4102
* [XamlC] test for null in Binding paths
Instead of relying on a NRE behing thrown while trying to evaluate a
compiled binding getter, detect the null value and fail faster, without
throwing. This require changing the type of the getter so they return a
(TProperty, bool) value tuple indicating the success.
- fixes #4102
* depend on ValueTuple for ns1.0
Pavel Yakovlev [Tue, 4 Dec 2018 18:20:56 +0000 (21:20 +0300)]
[UWP] Fixes throws NullReferenceException on empty NavigationPage (#3325) fixes #2102
Stephane Delcroix [Tue, 4 Dec 2018 18:20:00 +0000 (19:20 +0100)]
[Shell][iOS] do not try to smartly unblend bgcolor (#4593)
Unblending bg color was a smart idea. But only works in a controlled
subset of cases. To avoid unexpected blends, we will do the dumb stuff,
as we always do.
Stephane Delcroix [Tue, 4 Dec 2018 18:17:54 +0000 (19:17 +0100)]
[tasks] avoid passing dupe assemblies to Cecil (#4624) fixes #4620
* [tasks] avoid passing dupe assemblies to Cecil
avoid feeding Mono.Cecil with dupes. Removes a negligeable handful
of milliseconds (100ms on average, hard to measure) from XamlC. Even
less from XamlG.
- fixes #4620
* add extra check
Andrei [Tue, 4 Dec 2018 18:17:02 +0000 (21:17 +0300)]
[Enhancement] Added GroupHeaderStyle property for iOS specific ListView class (#4616)
* Added group header style property for ios specific list view class
* removed redundant test line
Stephane Delcroix [Tue, 4 Dec 2018 13:13:08 +0000 (14:13 +0100)]
[build] do not fail on multiple core rebuild (#4621) fixes #4619
- fixes #4619
Stephane Delcroix [Tue, 4 Dec 2018 10:34:20 +0000 (11:34 +0100)]
remove whitespaces, makes git happier