sung-su.kim [Mon, 5 Aug 2019 21:19:25 +0000 (06:19 +0900)]
[Tizen] Update ListViewRenderer for header and footer (#6984)
kingces95 [Sat, 3 Aug 2019 21:04:01 +0000 (11:04 -1000)]
Cache Droid SDK ver (#6983)
* cache droid SDK ver
* remove lock
Samantha Houts [Thu, 1 Aug 2019 20:34:34 +0000 (13:34 -0700)]
Merge branch '4.2.0'
Samantha Houts [Thu, 1 Aug 2019 20:32:14 +0000 (13:32 -0700)]
Merge branch '4.1.0' into 4.2.0
Gerald Versluis [Thu, 1 Aug 2019 12:53:53 +0000 (14:53 +0200)]
Cleaned up build.props and fixed applinks csproj debugtype (#7039)
Gerald Versluis [Thu, 1 Aug 2019 11:28:29 +0000 (13:28 +0200)]
[UWP] The SelectedItem in a ListView is not highlighted when set while constructing a page (#6973)
* Enable selection of an item from constructor
* Update ListViewRenderer.cs
* Update ListViewRenderer.cs
* Update ListViewRenderer.cs
E.Z. Hart [Thu, 1 Aug 2019 10:30:27 +0000 (04:30 -0600)]
Use Xamarin.Forms.Size instead of Android.Util.Size to work with API < 21 (#7033) fixes #6815
Fixes #6815
Gerald Versluis [Thu, 1 Aug 2019 10:07:38 +0000 (12:07 +0200)]
Enable SourceLink for Xamarin.Forms (#6886) fixes #2165
* Added sourcelink config to Directory.Build.props
* Only enable SourceLink for release builds
* Added debugtypes to mac projects
* pdb in nupkg files
* Revert "Added debugtypes to mac projects"
This reverts commit
7235bebdc42abdd9b747cd983357c7d832f91b39.
* Update Directory.Build.props
* Update Directory.Build.props
* Revert "Update Directory.Build.props"
This reverts commit
1c5b66c6e93fe55b66a028237a8b7f3b3629a804.
* Added DebugType portable to csprojs
* Removed all redundant csproj debugtype tags
Gerald Versluis [Thu, 1 Aug 2019 09:55:29 +0000 (11:55 +0200)]
Prevent DisplayEnd for cell on bounce (#7028)
ShaneN [Wed, 31 Jul 2019 17:44:31 +0000 (11:44 -0600)]
Merge branch 4.2.0
Shane Neuville [Wed, 31 Jul 2019 15:59:30 +0000 (09:59 -0600)]
Modify UI Test 6286 to await push and pop (#7022)
* Modify 6286 test to await push and pop
* convert over to use Tasks
Shane Neuville [Wed, 31 Jul 2019 10:08:17 +0000 (04:08 -0600)]
Revert "[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)" (#7021)
This reverts commit
fbebbfc516ee473a9a2ca36914505ab92baadd9e.
E.Z. Hart [Tue, 30 Jul 2019 18:54:43 +0000 (12:54 -0600)]
Android CollectionView Header/Footer (non-sticky) (#6948)
Stephane Delcroix [Tue, 30 Jul 2019 14:32:14 +0000 (16:32 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Tue, 30 Jul 2019 14:31:31 +0000 (16:31 +0200)]
Merge branch '4.0.0' into 4.1.0
E.Z. Hart [Tue, 30 Jul 2019 10:27:36 +0000 (04:27 -0600)]
Make it easier to create custom renderers for alternate CV layouts on Android (#6990)
Demo of StaggeredGridLayoutManager on Android
Rui Marinho [Tue, 30 Jul 2019 09:15:54 +0000 (10:15 +0100)]
[iOS] Fix usage conflict of Title and AttributedTitle on ButtonRenderer (#6944)
* [iOS] Fix usage conflict of Title and AttributedTitle on ButtonRenderer
* if CharacterSpacing isn't set then don't set it
* remove comments
* check for null
Stephane Delcroix [Tue, 30 Jul 2019 07:45:11 +0000 (09:45 +0200)]
[UWP] Register the Xaml assembly (#7004)
the Xaml asssembly need to be scanned for DependecyServices. The
code in place intended it, but was referring to the wrong type...
- fixes #6974
Gerald Versluis [Tue, 30 Jul 2019 06:25:59 +0000 (08:25 +0200)]
[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView (#6910)
* Fix and UI test
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
* Apply suggestions from code review
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Last typo fix
E.Z. Hart [Mon, 29 Jul 2019 23:50:11 +0000 (17:50 -0600)]
UWP CollectionView cleanup (#6928)
* Move files to CollectionView folder for consistency with other platforms
Move SelectableItemsViewRenderer to Setup/Teardown pattern
Fix event handler naming
Use Is method for property changed check
* Rebase cleanup
Pavel Yakovlev [Mon, 29 Jul 2019 23:49:18 +0000 (02:49 +0300)]
[UWP] Fixes default button padding (#6455)
fixes #6450
Pavel Yakovlev [Mon, 29 Jul 2019 21:11:38 +0000 (00:11 +0300)]
fixes .create-nuget script (#6913)
Stephane Delcroix [Mon, 29 Jul 2019 21:09:26 +0000 (23:09 +0200)]
[X] Allow tracking the assignment of StaticResource (#6868)
This allows advanced tracking of SR for debugging purposes. It doesn't affects
apps running without the debugger.
See also https://docs.microsoft.com/en-us/dotnet/api/system.windows.diagnostics.resourcedictionarydiagnostics
Andrei Nitescu [Mon, 29 Jul 2019 17:37:52 +0000 (20:37 +0300)]
CollectionView Android - Fix adapter update (#6840)
* CollectionView Android - Fix adapter update #6840
* Fix missing end tag
* Added APP compiler directive
* Update Issue6644.xaml.cs
fixes #6644
fixes #6839
E.Z. Hart [Mon, 29 Jul 2019 17:10:20 +0000 (11:10 -0600)]
Implement DataTemplateSelector support for CollectionView on UWP (#6918)
fixes #6898
Rui Marinho [Mon, 29 Jul 2019 09:26:00 +0000 (10:26 +0100)]
Merge branch '4.2.0'
Rui Marinho [Mon, 29 Jul 2019 09:23:54 +0000 (10:23 +0100)]
Merge branch '4.1.0' into 4.2.0
Rui Marinho [Mon, 29 Jul 2019 09:22:33 +0000 (10:22 +0100)]
Merge branch '4.0.0' into 4.1.0
Samantha Houts [Mon, 29 Jul 2019 09:01:24 +0000 (02:01 -0700)]
iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926
* Added test case for showing crash for issue 6926.
* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.
Shane Neuville [Mon, 29 Jul 2019 03:12:22 +0000 (21:12 -0600)]
remove sandbox (#6993)
Shane Neuville [Fri, 26 Jul 2019 10:51:29 +0000 (04:51 -0600)]
[iOS] Reset anchor point before reapplying transforms (#6951) fixes #6945 fixes #5610
* [iOS] Reset anchor point when reapplying transforms
- fix #6945
* Fix automation ids
Andrei [Fri, 26 Jul 2019 10:48:52 +0000 (13:48 +0300)]
fixes #5575 (#6981)
Shane Neuville [Fri, 26 Jul 2019 07:54:10 +0000 (01:54 -0600)]
[Android] add check for double dispose scrollview/page/platform (#6923)
Chris King [Fri, 26 Jul 2019 01:30:36 +0000 (15:30 -1000)]
update dot files
Gerald Versluis [Thu, 25 Jul 2019 20:24:31 +0000 (22:24 +0200)]
Added UpdateScreenSize call at instantiation (#6912)
Gerald Versluis [Thu, 25 Jul 2019 16:40:56 +0000 (18:40 +0200)]
Added iOS version check for crashing code (#6862) fixes #6847
Pavel Yakovlev [Thu, 25 Jul 2019 16:39:08 +0000 (19:39 +0300)]
[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108
* [Android] fixes previewer exceptions with SearchBar
* added comment
adrianknight89 [Thu, 25 Jul 2019 13:07:28 +0000 (08:07 -0500)]
[Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView (#5754)
* infinite scroll capability
* remove added line
* scroll event implementation
* add offset calculation for GridLayoutManager
* removed custom layout managers
* renamed variables
* changed comment
* implement CenterItemIndex
* fixed pageSize
* removed artifact
* handle the case when the layout manager is not linear
* fix comment
* call base dispose
* code review changes
* remove unused references
* indentation fix
* fix compilation issues
* revert cleanup
* fix
* fix crash
* fix test
* fix index issue
* removed unused method
* fix
* moved private variables into app scope
* Added back UI test
* Name to AutomationID
* added command parameter and addressed minor suggestions
kingces95 [Thu, 25 Jul 2019 09:52:36 +0000 (23:52 -1000)]
Fixes #6539 (#6969)
Rui Marinho [Thu, 25 Jul 2019 09:26:34 +0000 (10:26 +0100)]
[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)
* [UITests]Update to Xamarin.UITest 3.0
* [Tests] Move tests to Xamarin.UITests and NUnit 3.0
* [UITests] Use OneTimeSetUp
* suppress CS0436
Chris King [Thu, 25 Jul 2019 00:39:11 +0000 (14:39 -1000)]
update .create-stubs.bat for iOS
Stephane Delcroix [Wed, 24 Jul 2019 08:46:30 +0000 (10:46 +0200)]
[C] Obsolete Device.OpenUri (#6844)
* [C] Obsolete Device.OpenUri
also fix identation to use tabs
* fix CS618
* Update Xamarin.Forms.Core/Device.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Chris King [Tue, 23 Jul 2019 23:30:57 +0000 (13:30 -1000)]
update partial slns
Stephane Delcroix [Tue, 23 Jul 2019 16:12:59 +0000 (18:12 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Tue, 23 Jul 2019 16:12:34 +0000 (18:12 +0200)]
Merge branch '4.1.0' into 4.2.0
Pavel Yakovlev [Mon, 22 Jul 2019 16:53:28 +0000 (19:53 +0300)]
[Android] Fix previewer exceptions with TabbedPage (#6897)
* [Android] Fix previewer exceptions with TabbedPage
* - consolidated code
Rui Marinho [Sun, 21 Jul 2019 19:57:29 +0000 (20:57 +0100)]
Merge branch '4.2.0'
Rui Marinho [Sun, 21 Jul 2019 19:56:23 +0000 (20:56 +0100)]
Merge branch '4.1.0' into 4.2.0
Alan Grgic [Fri, 19 Jul 2019 10:58:59 +0000 (05:58 -0500)]
[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
* add reproduction
* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh
Kevin Petit [Fri, 19 Jul 2019 10:50:02 +0000 (12:50 +0200)]
Fix - Prevent race condition between activity create and dispose. (#6596)
Daniel Luberda [Fri, 19 Jul 2019 10:43:39 +0000 (12:43 +0200)]
MacOS: Allow third party libs to display animated images correctly (#6302)
* Mac Animated NSImage support
Andrei Nitescu [Thu, 18 Jul 2019 18:59:06 +0000 (21:59 +0300)]
ITextAlignmentElement VerticalTextAlignment (Entry, SearchBar, EntryCell) (#6463)
Rui Marinho [Thu, 18 Jul 2019 14:35:32 +0000 (15:35 +0100)]
[Build] Update GitInfo
kingces95 [Thu, 18 Jul 2019 12:43:26 +0000 (02:43 -1000)]
opt-in init (#6149)
ksemenenko [Thu, 18 Jul 2019 12:28:23 +0000 (15:28 +0300)]
[Enhancement] Implements CharacterSpacing (#5167)
- fixes #4855
* TextElement.LetterSpacingProperty
ButtonRenderer
DatePickerRenderer
EditorRenderer
EntryRenderer.cs
LabelRenderer
PickerRenderer
SearchBarRenderer
TimePickerRenderer
fix renderers
LetterSpacingElement
Extensions ToEm
* iOS
Picker
* UWP
* removal of an unnecessary condition
* Remove ILetterSpacingElement.OnLetterSpacingChanged
Fix for PickerRenderer for Android
* Move LetterSpacing to TextElement
* UWP
* Span
* Span and LetterSpacing
* Tests
* fixes for renderers
* Renderers
* LetterSpacingGallery
* Android fixes
* Extensions
* delete macos code
* iOS and UWP Renderers
* Renderers for iOS
* Picker.Items
* UWP
* fix merge
* Renderers
* iOS renderers
* PickerRenderer.cs
* Material
* Material Renderer
* Picker placeholder
* InvalidateMeasure
* Update Xamarin.Forms.Core/Span.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/ITextElement.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* remove LetterSpacing tests
* style
* Rename LetterSpacing to CharacterSpacing
* Update Xamarin.Forms.Controls/GalleryPages/CharacterSpacingGallery.xaml
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialPickerRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* SearchHandler
* UAP CharacterSpacing
* Update Xamarin.Forms.Core/Shell/SearchHandler.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
Gerald Versluis [Thu, 18 Jul 2019 11:43:27 +0000 (13:43 +0200)]
Added UITest for #2577 (#6728)
* Added UITest for issue 2577
* Added Wait statements
* Apply suggestions from code review
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* AutomationId to const
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* All strings to const
Samantha Houts [Thu, 18 Jul 2019 03:06:02 +0000 (20:06 -0700)]
Merge branch '4.2.0'
Samantha Houts [Thu, 18 Jul 2019 03:03:30 +0000 (20:03 -0700)]
Merge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 18 Jul 2019 02:58:30 +0000 (19:58 -0700)]
Merge branch '4.0.0' into 4.1.0
Gerald Versluis [Thu, 18 Jul 2019 02:49:21 +0000 (04:49 +0200)]
[Bug][iOS] listview / observable collection throwing native error on load (#6576)
* Added reproduction and commented out the misbehaving code
* Fixed merge conflicts
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
* Implemented UI test
* Somehow merged in a non-existing UI test
* Removed DetermineEstimatedRowHeight in WillDisplay
* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"
This reverts commit
431178d923c3bf642aae83331a5dc5b57c4436de.
* Removed WillDisplay with DetermineEstimatedRowHeight
* Reinstate projitems
* Added some more test scenarios
* Removed commented code
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472
Pavel Yakovlev [Thu, 18 Jul 2019 01:29:08 +0000 (04:29 +0300)]
[Android] refactoring fixes layouts (#6390)
* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)
* issue3000 and ToolbarItem tests should be passes
* MaybeRequestLayout extension method
* added automated UITest 5766
* fix 5766
* fix 6297
* merge 6297 into 5766 uitest
* rename test
E.Z. Hart [Tue, 16 Jul 2019 17:40:26 +0000 (11:40 -0600)]
Implement ItemsUpdatingScrollMode on Android and iOS (#6879)
shmin [Tue, 16 Jul 2019 16:07:36 +0000 (01:07 +0900)]
[Tizen] Fix slider thumb color issue (#6785)
Andrei Nitescu [Tue, 16 Jul 2019 16:06:01 +0000 (19:06 +0300)]
Label padding (#6299)
* Label padding
* Probably the biggest dilemma in the world
fixes #4784
Stephane Delcroix [Tue, 16 Jul 2019 10:26:33 +0000 (12:26 +0200)]
try to fix the build
Keith Dahlby [Tue, 16 Jul 2019 07:20:10 +0000 (02:20 -0500)]
[Core] Missing await in Device.InvokeOnMainThreadAsync(Func<Task>) (#6718)
* [Core] Use local functions
* [Core] Extract DeviceUnitTests
* [Core] Ensure actually called from main thread
* [Core] Add InvokeOnMainThread tests
WithAsyncTask is expected to fail.
* [Core] Rename local wrapper functions
* [Core] Avoid ambiguous call
CS0121: The call is ambiguous between the following methods or
properties: 'Device.InvokeOnMainThreadAsync(Action)' and
'Device.InvokeOnMainThreadAsync(Func<Task>)'
https://github.com/dotnet/roslyn/issues/14885
https://github.com/dotnet/csharplang/issues/98
Samantha Houts [Tue, 16 Jul 2019 02:17:48 +0000 (19:17 -0700)]
[Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)
* Add repro for #6286 (doesn't crash, though)
* [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose
fixes #6286
Rui Marinho [Mon, 15 Jul 2019 18:32:00 +0000 (19:32 +0100)]
[iOS] ItemsViewLayout needs strategy on the ctor (#6690)
Rui Marinho [Mon, 15 Jul 2019 18:23:27 +0000 (19:23 +0100)]
Update GitInfo.txt
Pavel Yakovlev [Mon, 15 Jul 2019 17:39:21 +0000 (20:39 +0300)]
[iOS] fixes material checkbox color (#6820) fixes #6816
Stephane Delcroix [Mon, 15 Jul 2019 12:00:46 +0000 (14:00 +0200)]
[X] allow x:Type markup as x:DataType value (#6843)
see discussion on #6492 and related issues
Andrei Nitescu [Mon, 15 Jul 2019 11:34:54 +0000 (14:34 +0300)]
Fixes binding to nullable types (#6860)
-fixes #6280
Stephane Delcroix [Mon, 15 Jul 2019 10:02:13 +0000 (12:02 +0200)]
[X] do not compile binding set as property values (#6837)
binding passed as properties don't have a valid datatype, so do not compile those.
- fixes #5240
adrianknight89 [Mon, 15 Jul 2019 08:30:26 +0000 (03:30 -0500)]
[Core] Add ability to show modal prompts (#6714)
* display prompts
* added keyboard
* moved null arguments to Page
* added test
* changed property name
* fix default literal issues
* fixes
Stephane Delcroix [Fri, 12 Jul 2019 14:23:52 +0000 (16:23 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Fri, 12 Jul 2019 14:22:56 +0000 (16:22 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Fri, 12 Jul 2019 13:40:16 +0000 (15:40 +0200)]
[HR] properly reload merged rds
E.Z. Hart [Fri, 12 Jul 2019 11:07:57 +0000 (05:07 -0600)]
Don't force binding expression applications to queue (#6857)
* Don't force binding expression applications to queue; fixes #6609
* Make PropertyChangeBindingsOccurThroughMainThread test what it claims to test
Ravinder Jangra [Thu, 11 Jul 2019 23:03:12 +0000 (04:33 +0530)]
Add Scrollbar Visibility option to the CollectionView (#6602)
* Add Horizontal and Vertical Scrollbar Visibility option to the CollectionView
* bump gitinfo
* make requested changes
* Add Android implementation
* use ScrollBarVisibility.Default instead of 0 and other requested changes
fixes #6053
Samantha Houts [Thu, 11 Jul 2019 22:45:25 +0000 (15:45 -0700)]
Merge branch '4.2.0'
Samantha Houts [Thu, 11 Jul 2019 22:44:58 +0000 (15:44 -0700)]
Merge branch '4.1.0' into 4.2.0
Mike Schwörer [Thu, 11 Jul 2019 08:52:18 +0000 (10:52 +0200)]
Fixed: Button CornerRadius doesn't work in explicit style (#6753)
- fixes #5046
* Fixed #5046 - Button CornerRadius doesn't work in explicit style
* Added Unit Test
* Requested changes from PR
* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests
* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Do not add ButtonCornerRadius in csproj
* removed dangling changes in ButtonUnitTest.cs
Geoffrey Huntley [Thu, 11 Jul 2019 01:38:41 +0000 (11:38 +1000)]
cleanup: moved closing brace to new line (#6793)
Andrei Nitescu [Thu, 11 Jul 2019 01:35:25 +0000 (04:35 +0300)]
Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
fixes #6747
Kevin Petit [Thu, 11 Jul 2019 01:34:26 +0000 (03:34 +0200)]
[Android] Uniformize handler name (CollectionView) (#6720)
* CollectionView - Uniformize handler name.
* Address naming feedback.
* Revert BOM.
Joe Manke [Wed, 10 Jul 2019 17:18:42 +0000 (13:18 -0400)]
Auto-focus next view from Entry with ReturnType.Next (#6706)
* Automatically focus the next view after hitting the Return key on an Entry with ReturnType.Next
* UWP implementation
Stephane Delcroix [Wed, 10 Jul 2019 12:24:32 +0000 (14:24 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Wed, 10 Jul 2019 10:18:17 +0000 (12:18 +0200)]
[X] hide TypedBinding from Intelisense
Andrei Nitescu [Wed, 10 Jul 2019 02:03:16 +0000 (05:03 +0300)]
Fix Page implicit and inherited style with ControlTemplate #6657 (#6661)
* Fix Page implicit and inherited style with ControlTemplate #6657
* Update StyleTests.cs
fixes #6657
Alan Grgic [Wed, 10 Jul 2019 00:24:10 +0000 (19:24 -0500)]
[Android] Fix KeyNotFoundException during Shell Navigation (#6740)
* fix android shell nav crash
* add reproduction test
* add automation and address feedback
* move fragmet creation of stack items to after switch statement
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs
Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* [iOS] fix shell section disposals so multiple page renderers don't get assigned
Gerald Versluis [Tue, 9 Jul 2019 21:46:35 +0000 (23:46 +0200)]
Implemented Padding on WPF Button (#6791)
* Implemented Padding on WPF Button
* Update Padding when BorderWidth is updated
* Implemented Padding for ImageButton
* Apply suggestions from code review
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6790
Geoffrey Huntley [Tue, 9 Jul 2019 20:18:59 +0000 (06:18 +1000)]
cleanup: corrected spelling mistake (#6794)
Samantha Houts [Tue, 9 Jul 2019 17:50:41 +0000 (10:50 -0700)]
Merge branch '4.1.0' into 4.2.0
Peter Moore [Tue, 9 Jul 2019 10:10:13 +0000 (05:10 -0500)]
RelativeSource Binding (#4375)
RelativeSource Binding
- fixes #3847
Implement RelativeSource binding modes for Self, TemplatedParent, and FindAncestor. Add unit tests. Pare down TemplateBinding class to use RelativeSource binding mechanism.
* Include RelativeSource member in Binding.Clone
* Fix issue of unit tests being tricked by async in Binding.Apply; permit "Source={RelativeSource...}" in addition to "RelativeSource={RelativeSource..."; allow FindAncestor relative binding source mode to be based on BindingContext type or control type
* Fix unit test wasn't actually testing "Source={RelativeSource...}" syntax.
* Address @StephaneDelcroix's comments. Make FindAncestor relative source binding work even when the ancestor changes.
* Much better mechanism for detecting when a parent changes for relativesource
* Cleanup
* more cleanup
* more cleanup
* Remove async/await for identifying templated parent and ancestor type binding source
* Remove unused code; fix linting
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Ensure TemplateBinding works correctly when reparenting. Cleanup.
* Finish addressing comments; linting cleanup
* Remove private modifier where unneeded
Samantha Houts [Tue, 9 Jul 2019 01:55:31 +0000 (18:55 -0700)]
Merge branch '4.2.0'
Andrei Nitescu [Mon, 8 Jul 2019 23:51:37 +0000 (02:51 +0300)]
Fix for Switch on Android losing shadow #6798 (#6798)
Joe Manke [Mon, 8 Jul 2019 23:17:05 +0000 (19:17 -0400)]
Reimplement ITabStop to return the EditText on Android Material renderers that use TextInputLayout as the native Control (#6732)
fixes #5102
Stephane Delcroix [Mon, 8 Jul 2019 23:03:32 +0000 (01:03 +0200)]
[X] Allow x:Null for x:DataType (#6822)
- fixes #6648
Shane Neuville [Sun, 7 Jul 2019 22:08:31 +0000 (16:08 -0600)]
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
* [ios] fix safeareas and use marging to offset flyout
* android fixes for margin
* [iOS] frame size and inset fixes
* android fix header offset
* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* top offset fixes
* add mask back in for scrolling header
* fix NRE when FlyoutHeader is null
* tweak Bugzilla26993Test
ShaneN [Sat, 6 Jul 2019 19:59:12 +0000 (13:59 -0600)]
Merge branch '4.2.0'