profile/ivi/webkit-efl.git
12 years ago[Qt] Unreviewed gardening, unksip a now passing test.
ossy@webkit.org [Thu, 17 May 2012 12:24:29 +0000 (12:24 +0000)]
[Qt] Unreviewed gardening, unksip a now passing test.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow FileSystem API implementation to pass snapshot metadata at File creation time
kinuko@chromium.org [Thu, 17 May 2012 12:07:55 +0000 (12:07 +0000)]
Allow FileSystem API implementation to pass snapshot metadata at File creation time
https://bugs.webkit.org/show_bug.cgi?id=78879

Reviewed by Jian Li.

Source/WebCore:

We query File metadata (e.g. size and modifiedTime) when File.size,
lastModifiedTime or webkitSlice() is accessed / called, but in some
platform-specific filesystems it may not be feasible since synchronous
metadata query could take very long time.

This patch adds new File constructor which takes metadata argument
to allow each FileSystem API implementation to pass snapshot metadata
so that File object could cache the given metadata not to make
synchronous query.

We only call this constructor if the filesystem type is neither
Temporary nor Persistent, therefore this patch should not affect
existing code behavior.

Test: fast/filesystem/file-read-after-write.html

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile):
* Modules/filesystem/DOMFileSystemSync.cpp:
* fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice): Updated implementation.
* fileapi/Blob.h:
* fileapi/File.cpp:
(WebCore::File::File): Added new constructor.
(WebCore::File::lastModifiedDate): Updated implementation.
(WebCore::File::size): Updated implementation.
(WebCore::File::captureSnapshot): Updated implementation.
* fileapi/File.h:
(WebCore::File::createForFileSystemFile): Added.
* platform/AsyncFileSystem.h:
(AsyncFileSystem): Updated comment.

LayoutTests:

Added tests for making sure metadata is not cached in the regular
temporary filesystem.

* fast/filesystem/file-metadata-after-write-expected.txt: Added.
* fast/filesystem/file-metadata-after-write.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, updating chrome test expectations.
kinuko@chromium.org [Thu, 17 May 2012 11:55:42 +0000 (11:55 +0000)]
Unreviewed, updating chrome test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Performance test] Add a micro benchmark for div.firstChild getter
haraken@chromium.org [Thu, 17 May 2012 11:37:28 +0000 (11:37 +0000)]
[Performance test] Add a micro benchmark for div.firstChild getter
https://bugs.webkit.org/show_bug.cgi?id=86582

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter.
This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and
'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes
that return a Node object.

Multiple test results in my Linux desktop:

RESULT Bindings: first-child= 798.157160346 runs/s
median= 798.004987531 runs/s, stdev= 1.52006063407 runs/s, min= 796.019900498 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 797.603608554 runs/s
median= 797.872340426 runs/s, stdev= 2.2522621261 runs/s, min= 791.556728232 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 798.656295468 runs/s
median= 798.004987531 runs/s, stdev= 1.79367478063 runs/s, min= 797.01120797 runs/s, max= 803.011292346 runs/s
RESULT Bindings: first-child= 797.812784267 runs/s
median= 798.004987531 runs/s, stdev= 2.31766523191 runs/s, min= 791.100123609 runs/s, max= 802.005012531 runs/s
RESULT Bindings: first-child= 797.963311597 runs/s
median= 798.004987531 runs/s, stdev= 2.53014907337 runs/s, min= 789.14919852 runs/s, max= 801.001251564 runs/s

* Bindings/first-child.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Test expectation update.
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 11:35:58 +0000 (11:35 +0000)]
[Qt] Unreviewed gardening. Test expectation update.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17

* platform/qt/fast/block/float/overhanging-tall-block-expected.png:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:After 117310.
* platform/qt/fast/repaint/float-overflow-expected.png:
* platform/qt/fast/repaint/float-overflow-expected.txt: After r117339.
* platform/qt/fast/repaint/float-overflow-right-expected.png:
* platform/qt/fast/repaint/float-overflow-right-expected.txt: After r117339.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoConvert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
gyuyoung.kim@samsung.com [Thu, 17 May 2012 11:14:27 +0000 (11:14 +0000)]
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
https://bugs.webkit.org/show_bug.cgi?id=86704

Reviewed by Eric Seidel.

.:

* Source/autotools/symbols.filter: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Source/WebCore:

Add setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way by means of the InternalSettings interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

* testing/InternalSettings.cpp:
(WebCore):
(WebCore::InternalSettings::setDomainRelaxationForbiddenForURLScheme):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit/gtk:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* WebKit.order:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:

Source/WebKit/qt:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
* WebView.h:
(WebView):

Source/WebKit2:

* win/WebKit2.def: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Tools:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Invoke setDomainRelaxationForbiddenForURLScheme functions from internalSettings, because it is able to work in the
cross-port way via the InternalSettings interface.

* http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Skip failing reftests.
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 11:09:07 +0000 (11:09 +0000)]
[Qt] Unreviewed gardening. Skip failing reftests.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCal...
commit-queue@webkit.org [Thu, 17 May 2012 11:06:21 +0000 (11:06 +0000)]
[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=84835

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp: Call appropriate callbacks for editing actions.
(WebCore::EditorClientEfl::shouldDeleteRange):
(WebCore::EditorClientEfl::shouldBeginEditing):
(WebCore::EditorClientEfl::shouldEndEditing):
(WebCore::EditorClientEfl::shouldInsertText):
(WebCore::EditorClientEfl::shouldChangeSelectedRange):
(WebCore::EditorClientEfl::shouldApplyStyle):
(WebCore::EditorClientEfl::didBeginEditing):
(WebCore::EditorClientEfl::didEndEditing):
(WebCore::EditorClientEfl::shouldInsertNode):
* WebCoreSupport/EditorClientEfl.h: Add structures needed by editing callbacks.
(Ewk_Should_Insert_Node_Event):
(Ewk_Should_Insert_Text_Event):
(Ewk_Should_Change_Selected_Range_Event):
(Ewk_Should_Apply_Style_Event):

Tools:

Added editing callbacks implementation.

* DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
(DumpRenderTreeChrome::createView):
* DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
(dumpPath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):
* DumpRenderTree/efl/EditingCallbacks.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
gyuyoung.kim@samsung.com [Thu, 17 May 2012 11:03:42 +0000 (11:03 +0000)]
Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed attempt to fix a Windows build breakage.
morrita@google.com [Thu, 17 May 2012 10:16:49 +0000 (10:16 +0000)]
Unreviewed attempt to fix a Windows build breakage.

* public/WebIntent.h:
(WebIntent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Performance test] In perftest.py, do not include 'description' in 'results'
haraken@chromium.org [Thu, 17 May 2012 10:09:59 +0000 (10:09 +0000)]
[Performance test] In perftest.py, do not include 'description' in 'results'
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Csaba Osztrogoná.

'results' in perftest.py should not include any data that is not expected
by the perf bot server. We do not need to send 'description' to the perf bot
server since 'description' is always the same.

Thus this patch just removes 'description' from 'results'.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShadowRoot.selection should be ShadowRoot.getSelection()
shinyak@chromium.org [Thu, 17 May 2012 09:55:59 +0000 (09:55 +0000)]
ShadowRoot.selection should be ShadowRoot.getSelection()
https://bugs.webkit.org/show_bug.cgi?id=86598

Reviewed by Hajime Morita.

Source/WebCore:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the implementation.

* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:

LayoutTests:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the tests.

* editing/shadow/selection-of-orphan-shadowroot.html:
* editing/shadow/selection-of-shadowroot.html: Removed unnecessary code to
call ShadowRoot.selection by using ShadowRoot.getSelection(). Now ShadowRoot.getSelection()
can be called directly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Refactoring] Remove TreeScopeAdjuster
shinyak@chromium.org [Thu, 17 May 2012 09:30:51 +0000 (09:30 +0000)]
[Refactoring] Remove TreeScopeAdjuster
https://bugs.webkit.org/show_bug.cgi?id=86599

Reviewed by Hajime Morita.

It seems the right place of the method of TreeScopeAdjuster are in VisibleSelection
and TreeScope. So we can remove TreeScopeAdjuster.

No new tests, no change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/TreeScope.cpp:
(WebCore::TreeScope::ancestorInThisScope):
(WebCore):
* dom/TreeScope.h:
(TreeScope):
* dom/TreeScopeAdjuster.cpp: Removed.
* dom/TreeScopeAdjuster.h: Removed.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustPositionBefore):
(WebCore):
(WebCore::VisibleSelection::adjustPositionAfter):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
* editing/VisibleSelection.h:
(VisibleSelection):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::shadowAdjustedNode):
(WebCore::DOMSelection::shadowAdjustedOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNEON intrinsic should be used with arithmetic mode of composite filter
zherczeg@webkit.org [Thu, 17 May 2012 09:12:54 +0000 (09:12 +0000)]
NEON intrinsic should be used with arithmetic mode of composite filter
https://bugs.webkit.org/show_bug.cgi?id=86622

Reviewed by Nikolas Zimmermann.

Rewrite hand written assembly code to increase portability and readibility
of the code. Remove the unnecessary FECompositeArithmeticNEON.cpp from the
project

Existing tests cover this issue.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FEComposite.cpp:
(WebCore):
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Removed.
* platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoshowNodePath will be useful for debugging purpose.
commit-queue@webkit.org [Thu, 17 May 2012 09:03:20 +0000 (09:03 +0000)]
showNodePath will be useful for debugging purpose.
https://bugs.webkit.org/show_bug.cgi?id=86450

This patch implements showNodePath, which outputs node information in
a xpath-like format, e.g. /HTML/BODY/DIV[@id="test" and position()=0]/P[0]

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-17
Reviewed by Hajime Morita.

No new tests, just adding debugging interface.

* dom/Node.cpp:
(WebCore::Node::showNodePathForThis):
(WebCore):
(showNodePath):
* dom/Node.h:
(Node):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking tests which need rebaselining after r117412.
morrita@google.com [Thu, 17 May 2012 08:58:10 +0000 (08:58 +0000)]
Unreviewed, marking tests which need rebaselining after r117412.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking acid3-test-77.html as fail.
morrita@google.com [Thu, 17 May 2012 08:48:44 +0000 (08:48 +0000)]
Unreviewed, marking acid3-test-77.html as fail.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Do not check NULL pointer allocated by new.
g.czajkowski@samsung.com [Thu, 17 May 2012 08:21:51 +0000 (08:21 +0000)]
[EFL] Do not check NULL pointer allocated by new.
https://bugs.webkit.org/show_bug.cgi?id=86610

Reviewed by Ryosuke Niwa.

WebKit-Efl doesn't check pointers that are initialized by new.
Those checks are not needed because new operator doesn't return NULL.
Only an overloaded version of new returns NULL pointer.

* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_entry_new):
* ewk/ewk_view.cpp:
(_ewk_view_core_frame_new):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)
commit-queue@webkit.org [Thu, 17 May 2012 08:18:59 +0000 (08:18 +0000)]
REGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)
https://bugs.webkit.org/show_bug.cgi?id=85991

Source/WebCore:

Fix for regression failures on deprecated flex box test cases.

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

Test: fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
Fix to use intrinsic width when the fixed width:0 , for deprecated flex boxes.

LayoutTests:

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

* fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt: Added.
* fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCSS3 Multicolumn: Content in normal flow extending into column gaps should be clipped...
commit-queue@webkit.org [Thu, 17 May 2012 08:14:33 +0000 (08:14 +0000)]
CSS3 Multicolumn: Content in normal flow extending into column gaps should be clipped at middle of column-gap
https://bugs.webkit.org/show_bug.cgi?id=86441

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebCore:

Content in the normal flow that extends into column gaps (e.g., long words or images)
is clipped in the middle of the column gap.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

Test: fast/multicol/overflow-into-columngap.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):

LayoutTests:

Test for content in normal flow that extends into column gaps.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

* fast/multicol/overflow-into-columngap-expected.html: Added.
* fast/multicol/overflow-into-columngap.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Worker] Web Worker lacks test to check the name attribute of SharedWorker
commit-queue@webkit.org [Thu, 17 May 2012 08:06:38 +0000 (08:06 +0000)]
[Worker] Web Worker lacks test to check the name attribute of SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=86714

Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kentaro Hara.

Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope
The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
but it doesn't cover this.

* fast/workers/resources/shared-worker-common.js:
(handleMessage):
* fast/workers/resources/shared-worker-name.js:
(test11.worker.port.onmessage):
(test11):
* fast/workers/shared-worker-name-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Performance test] Always fill results['description'] in perftest.py
haraken@chromium.org [Thu, 17 May 2012 07:46:04 +0000 (07:46 +0000)]
[Performance test] Always fill results['description'] in perftest.py
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills results['description'] always.

* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
commit-queue@webkit.org [Thu, 17 May 2012 07:30:03 +0000 (07:30 +0000)]
[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=85879

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-17
Reviewed by Noam Rosenthal.

Source/WebKit/efl:

_ewk_frame_smart_del() is considering now that the frame can be present in cache.
loader()->detachFromParent() is only applied for the main frame.
loader()->cancelAndClear() is not used anymore.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del):

LayoutTests:

* platform/efl/test_expectations.txt: Removed fast/frames/frame-crash-with-page-cache.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking input-appearance-range.html as fail.
morrita@google.com [Thu, 17 May 2012 07:27:40 +0000 (07:27 +0000)]
Unreviewed, marking input-appearance-range.html as fail.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking backgr_position-table.html and some others as fail.
morrita@google.com [Thu, 17 May 2012 07:10:28 +0000 (07:10 +0000)]
Unreviewed, marking backgr_position-table.html and some others as fail.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r117339.
ossy@webkit.org [Thu, 17 May 2012 07:07:23 +0000 (07:07 +0000)]
[Qt] Unreviewed gardening after r117339.
https://bugs.webkit.org/show_bug.cgi?id=84167

* platform/qt/Skipped:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/qt/editing/selection/iframe-expected.png:
* platform/qt/editing/selection/iframe-expected.txt:
* platform/qt/editing/selection/inline-table-expected.png:
* platform/qt/editing/selection/inline-table-expected.txt:
* platform/qt/editing/selection/table-caret-3-expected.png:
* platform/qt/editing/selection/table-caret-3-expected.txt:
* platform/qt/fast/css-generated-content/inline-display-types-expected.png:
* platform/qt/fast/css-generated-content/inline-display-types-expected.txt:
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/qt/fast/inline-block/001-expected.png:
* platform/qt/fast/inline-block/001-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Web process hangs while waiting for plugin process connection during layouttests
ossy@webkit.org [Thu, 17 May 2012 06:54:35 +0000 (06:54 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

* platform/qt/Skipped: Skip failing tests after r117288.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r117372.
commit-queue@webkit.org [Thu, 17 May 2012 06:53:07 +0000 (06:53 +0000)]
Unreviewed, rolling out r117372.
http://trac.webkit.org/changeset/117372
https://bugs.webkit.org/show_bug.cgi?id=86710

"triggerring crashes" (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

Source/WebCore:

* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::context):
(WebCore::AudioParam::hasSampleAccurateValues):
(WebCore::AudioParam::AudioParam):
(AudioParam):

LayoutTests:

* webaudio/audioparam-connect-audioratesignal.html:
* webaudio/audioparam-summingjunction-expected.txt: Removed.
* webaudio/audioparam-summingjunction.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK gardening after r117373.
zandobersek@gmail.com [Thu, 17 May 2012 06:40:13 +0000 (06:40 +0000)]
Unreviewed GTK gardening after r117373.

* platform/gtk/fast/forms/input-align-image-expected.txt:
* platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r117396.
commit-queue@webkit.org [Thu, 17 May 2012 06:36:29 +0000 (06:36 +0000)]
Unreviewed, rolling out r117396.
http://trac.webkit.org/changeset/117396
https://bugs.webkit.org/show_bug.cgi?id=86709

"breaks chromium tree" (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

* WebKit.gyp:
* public/WebTextInputInfo.h: Removed.
* public/WebTextInputType.h:
* public/WebWidget.h:
(WebKit::WebWidget::textInputType):
* src/WebTextInputInfo.cpp: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Web process hangs while waiting for plugin process connection during layouttests
ossy@webkit.org [Thu, 17 May 2012 06:22:13 +0000 (06:22 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

* platform/qt/Skipped: Skip failing tests after r117288.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed expectations update.
morrita@google.com [Thu, 17 May 2012 06:20:43 +0000 (06:20 +0000)]
Unreviewed expectations update.

* fast/repaint/float-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.png.
* fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
* fast/repaint/float-overflow-right-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.png.
* fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-mac/fast/repaint/float-overflow-expected.png: Added.
* platform/chromium-mac/fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-expected.txt.
* platform/chromium-mac/fast/repaint/float-overflow-right-expected.png: Added.
* platform/chromium-mac/fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-right-expected.txt.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/repaint/float-overflow-expected.png: Removed.
* platform/gtk/fast/repaint/float-overflow-right-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Restore accidentally changed copyrights.
commit-queue@webkit.org [Thu, 17 May 2012 06:17:07 +0000 (06:17 +0000)]
[EFL] Restore accidentally changed copyrights.
https://bugs.webkit.org/show_bug.cgi?id=86471

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-16
Reviewed by Antonio Gomes.

Restore accidentally changed copyrights.

* ewk/ewk_js_private.h:
* ewk/ewk_security_origin_private.h:
* ewk/ewk_view_private.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Get text direction at the start and end of selection.
commit-queue@webkit.org [Thu, 17 May 2012 05:18:28 +0000 (05:18 +0000)]
[chromium] Get text direction at the start and end of selection.
https://bugs.webkit.org/show_bug.cgi?id=86573

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-16
Reviewed by Adam Barth.

Add an interface to get text direction at the start and end of
selection for Android, as on Android different selection delimiters
are needed for RTL text. Unlike other platforms, the start and end
delimiters of selection are different, so we need determine the shape
of delimiter based on text direction.

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::selectionTextDirection):
* src/WebViewImpl.cpp:
(WebKit):
(WebKit::WebViewImpl::selectionTextDirection):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner...
haraken@chromium.org [Thu, 17 May 2012 05:16:14 +0000 (05:16 +0000)]
[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

We want to add some description for each PerfTestRunner.run and
PerfTestRunner.runPerSecond, so that people can know what each
run is testing.

Output example:

$ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
Running Bindings/first-child.html (1 of 1)
DESCRIPTION: Benchmark for DOM attributes that return a Node object.
RESULT Bindings: first-child= 788.359076534 runs/s
median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s

PerformanceTests:

* resources/runner.js:
(PerfTestRunner.logStatistics):
(PerfTestRunner.printStatistics):
(PerfTestRunner.runPerSecond):

Tools:

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Implement WebViewImpl::textInputInfo() for Android
abarth@webkit.org [Thu, 17 May 2012 05:03:57 +0000 (05:03 +0000)]
[Chromium] Implement WebViewImpl::textInputInfo() for Android
https://bugs.webkit.org/show_bug.cgi?id=86440

Reviewed by Darin Fisher.

This patch adds WebView::textInputInfo(), which describes the text
input that currently has focus.  Android is planning to use this to
determine what sort of keyboard or text entry UI to show.  This API
subsumes the textInputType() API, which will be removed once the
clients have been updated.

* WebKit.gyp:
* public/WebTextInputInfo.h: Added.
(WebKit):
(WebTextInputInfo):
(WebKit::WebTextInputInfo::WebTextInputInfo):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebTextInputType.h:
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::textInputInfo):
(WebKit::WebWidget::textInputType):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit):
(WebKit::WebViewImpl::textInputType):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Fix bug number for video-controls-drag.html in the test_expectation.txt
commit-queue@webkit.org [Thu, 17 May 2012 04:53:32 +0000 (04:53 +0000)]
[EFL] Fix bug number for video-controls-drag.html in the test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86607

Unreviewed EFL gardening.

Change BUGWK number to point to right patch.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement a Shadow DOM spec's section 6 'Events'.
hayato@chromium.org [Thu, 17 May 2012 04:37:46 +0000 (04:37 +0000)]
Implement a Shadow DOM spec's section 6 'Events'.
https://bugs.webkit.org/show_bug.cgi?id=78586

Reviewed by Dimitri Glazkov.

Source/WebCore:

This implements a Shadow DOM spec's section 6 'Events', introducing a new
algorithm so that event dispatching use a composed shadow DOM tree,
instead of normal DOM tree, in dispatching events to each node.

The spec is here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events

Summary of changes:
- Attaching shadow DOM does not affect an event dispatching
behavior of enclosing DOM tree. This applies even if some nodes
are distributed to insertion points. We keep a compatibility of
existing event dispatching mechanism so that we won't break Web.
- Event ancestors, which are used in dispatching events in capture (or
bubble) phase, are now the result of traversing ancestors in composed
shadow DOM tree order, instead of normal DOM tree order.
- Event's target and related-target are correctly adjusted so that
we don't leak any node which is inaccessible from the event's
current-target node. We enforce both upper and lower boundary
encapsulation of Shadow DOM in event dispatching

Here is an example of event dispatching. Suppose we have the following DOM tree, which
includes some nested shadow hosts and insertion points
A
`--B-----[SR-B]
   |-C     `--G--------------[SR-G]
   | `-D      |-<H select=C>    |--J---------------[SR-J]
   `-E        `-<I select=E>    |  `-<K select=H>    `-<N select=K>
     `-F                        |
                                `--L---------------[SR-L]
                                   `-<M select=I>    `-<O select=M>

  Notation: [SR-X]: Shadow Root
            <X select=Y>: Insertion Point, called X, which selects Y.

If a mouse moves from node '#F' to node '#D', the following
'mouseover' events are dispatched in each ancestor node:

[currentTarget] [target] [related-target]
  #D             #D       #F
  #C             #D       #F
  #H             #H       #I
  #K             #K       #M
  #N             #N       #M
  #SR-J          #N       #M
  #J             #K       #M
  #SR-G          #K       #M
  #G             #H       #I
  #SR-B          #H       #I
  #B             #D       #F
  #A             #D       #F

Details are:
- Insertion points, such as <content> or <shadow>, are resolved correctly
in calculating event ancestors. That means if a node is distributed to
an insertion point, the insertion point is now an ancestor of the node in
bubbling (or capturing) events.
- Both insertion points and shadow roots now can receive events. We can add
event listeners to insertion points and shadow roots.
- Dispatched event's target is now adjusted correctly using the re-targeting
algorithm. The algorithm is now fully aware of insertion points.
- Dispatched event's related-target can now differ in each tree scope of
event ancestors. We choose the most appropriate related-target using the
related target resolution algorithm for each node.

Performance consideration:
This patch can achieve the competitive performance. The results of
./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html for
before/after this patch are:

Before applying this patch:
    Running DOM/Events.html (1 of 1)
    RESULT DOM: Events= 270.310714286 ms
    median= 269.75 ms, stdev= 2.0042397663 ms, min= 267.357142857 ms, max= 276.5 ms

After applying this patch:
    Running DOM/Events.html (1 of 1)
    RESULT DOM: Events= 268.108333333 ms
    median= 267.5 ms, stdev= 2.41883157195 ms, min= 263.625 ms, max= 273.142857143 ms

I've also conducted a micro benchmark using both
Shadow-Free-DOM-Tree and DOM-Tree-With-Shadow-Host.
See https://bugs.webkit.org/show_bug.cgi?id=78586#c40 for the results.
It seems that the new implementation has more capabilities, but
doesn't sacrifice a performance of event dispatching in either cases.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
* dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
(WebCore::EventContext::handleLocalEvents):
* dom/EventContext.h:
(EventContext):
(WebCore::EventContext::relatedTarget):
(WebCore):
(WebCore::EventContext::setRelatedTarget):
* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::EventRelatedTargetAdjuster):
(WebCore):
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::determineDispatchBehavior):
* dom/EventDispatcher.h:
(WebCore):
(EventRelatedTargetAdjuster):
(EventDispatcher):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(WebCore::toMouseEvent):
(WebCore):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Added.
* fast/dom/shadow/shadow-dom-event-dispatching.html: Added.
* platform/efl/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMoving caret up or down skips lines when there's a non-editable line
rniwa@webkit.org [Thu, 17 May 2012 04:09:47 +0000 (04:09 +0000)]
Moving caret up or down skips lines when there's a non-editable line
https://bugs.webkit.org/show_bug.cgi?id=81490

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition
skipping leaf nodes that constitute a new line and belong to the same editable region because block elements
that separate lines are not editable so it looked as if all editable lines belong to a single line as far as
those two functions are concerned.

Fixed the bug by using the first leaf node that belongs to the same editable region but does not belong in
the same as the start node.

This patch is based on a patch authored by Yi Shen (Nokia).

Test: editing/selection/move-between-lines-of-different-editabilities.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):

LayoutTests:

Added a regression test.

* editing/selection/move-between-lines-of-different-editabilities.html: Added.
* editing/selection/move-by-word-visually-mac-expected.txt: Rebaselined a test case. It failed
before this change and still fails after this change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed attempt to fix Mac SL build.
morrita@google.com [Thu, 17 May 2012 03:58:23 +0000 (03:58 +0000)]
Unreviewed attempt to fix Mac SL build.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd tests for CSS Variables.
macpherson@chromium.org [Thu, 17 May 2012 03:55:41 +0000 (03:55 +0000)]
Add tests for CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=86575

Reviewed by Dimitri Glazkov.

* fast/css/variables/colors-test-expected.html: Added.
* fast/css/variables/colors-test.html: Added.
* fast/css/variables/complex-cycle-expected.html: Added.
* fast/css/variables/complex-cycle.html: Added.
* fast/css/variables/computed-style-expected.html: Added.
* fast/css/variables/computed-style.html: Added.
* fast/css/variables/inherited-values-expected.html: Added.
* fast/css/variables/inherited-values.html: Added.
* fast/css/variables/inline-styles-expected.html: Added.
* fast/css/variables/inline-styles.html: Added.
* fast/css/variables/invalid-shorthand-expected.html: Added.
* fast/css/variables/invalid-shorthand.html: Added.
* fast/css/variables/invalid-variable-value-expected.html: Added.
* fast/css/variables/invalid-variable-value.html: Added.
* fast/css/variables/multi-level-cycle-expected.html: Added.
* fast/css/variables/multi-level-cycle.html: Added.
* fast/css/variables/redefinition-expected.html: Added.
* fast/css/variables/redefinition.html: Added.
* fast/css/variables/shorthand-expected.html: Added.
* fast/css/variables/shorthand.html: Added.
* fast/css/variables/simple-cycle-expected.html: Added.
* fast/css/variables/simple-cycle.html: Added.
* fast/css/variables/undefined-expected.html: Added.
* fast/css/variables/undefined.html: Added.
* fast/css/variables/use-before-defined-expected.html: Added.
* fast/css/variables/use-before-defined.html: Added.
* fast/css/variables/var-inside-shorthand-expected.html: Added.
* fast/css/variables/var-inside-shorthand.html: Added.
* fast/css/variables/variable-chain-expected.html: Added.
* fast/css/variables/variable-chain.html: Added.
* platform/chromium/test_expectations.txt: Skip tests until variables implementation lands.
* platform/efl/test_expectations.txt: Skip tests until variables implementation lands.
* platform/gtk/test_expectations.txt: Skip tests until variables implementation lands.
* platform/mac/test_expectations.txt: Skip tests until variables implementation lands.
* platform/qt/test_expectations.txt: Skip tests until variables implementation lands.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking failing test.
morrita@google.com [Thu, 17 May 2012 03:52:17 +0000 (03:52 +0000)]
Unreviewed, marking failing test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse pixelSnappedLogicalHeight for TableSection layout
leviw@chromium.org [Thu, 17 May 2012 03:37:21 +0000 (03:37 +0000)]
Use pixelSnappedLogicalHeight for TableSection layout
https://bugs.webkit.org/show_bug.cgi?id=86665

Reviewed by Eric Seidel.

We do table layout using integers to ensure we follow the spec (see
https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
flooring the logical height used in layoutRows. This caused us to mis-
calculate the intrinsic padding and grow cells beyond their proper height.

No new tests. Fully covered by existing tests with sub-pixel enabled.

* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
methods.
(WebCore::RenderBox::pixelSnappedLogicalWidth):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking failing test.
morrita@google.com [Thu, 17 May 2012 03:35:39 +0000 (03:35 +0000)]
Unreviewed, marking failing test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, marking cross-fade-background-image.html as failing.
morrita@google.com [Thu, 17 May 2012 03:24:40 +0000 (03:24 +0000)]
Unreviewed, marking cross-fade-background-image.html as failing.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorename display:-webkit-flexbox to display:-webkit-flex
tony@chromium.org [Thu, 17 May 2012 03:19:31 +0000 (03:19 +0000)]
rename display:-webkit-flexbox to display:-webkit-flex
https://bugs.webkit.org/show_bug.cgi?id=86529

Reviewed by Eric Seidel.

Source/WebCore:

Also renames -webkit-inline-flexbox to -webkit-inline-flex.

No new tests. Covered by existing tests.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in: Update keyword values.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderObject.h:
(RenderObject):
* rendering/style/RenderStyleConstants.h: Rename const values.

LayoutTests:

* css3/flexbox/anonymous-block-merge-crash.html:
* css3/flexbox/anonymous-block.html:
* css3/flexbox/auto-height-dynamic.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/columns-auto-size.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/display-flexbox-set-get-expected.txt:
* css3/flexbox/display-flexbox-set-get.html:
* css3/flexbox/flex-algorithm-min-max.html:
* css3/flexbox/flex-algorithm-with-margins.html:
* css3/flexbox/flex-algorithm.html:
* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-end.html:
* css3/flexbox/flex-align-max.html:
* css3/flexbox/flex-align-percent-height.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/flex-flow-border.html:
* css3/flexbox/flex-flow-margins-auto-size.html:
* css3/flexbox/flex-flow-margins.html:
* css3/flexbox/flex-flow-orientations.html:
* css3/flexbox/flex-flow-overflow.html:
* css3/flexbox/flex-flow-padding.html:
* css3/flexbox/flex-flow.html:
* css3/flexbox/flex-item-child-overflow.html:
* css3/flexbox/flex-no-flex.html:
* css3/flexbox/flex-order.html:
* css3/flexbox/flex-pack.html:
* css3/flexbox/flexbox-overflow-auto-expected.html:
* css3/flexbox/flexbox-overflow-auto.html:
* css3/flexbox/floated-flexbox.html:
* css3/flexbox/insert-text-crash.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-column-auto.html:
* css3/flexbox/multiline-line-pack-horizontal-column.html:
* css3/flexbox/multiline-line-pack.html:
* css3/flexbox/multiline-pack.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/multiline-reverse-wrap-overflow.html:
* css3/flexbox/multiline-shrink-to-fit.html:
* css3/flexbox/multiline.html:
* css3/flexbox/nested-stretch.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/preferred-widths-orthogonal.html:
* css3/flexbox/preferred-widths.html:
* css3/flexbox/repaint-rtl-column.html:
* css3/flexbox/repaint.html:
* css3/flexbox/true-centering.html:
* css3/flexbox/writing-modes.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIDL and implementation for Web Intents delivery
commit-queue@webkit.org [Thu, 17 May 2012 03:17:02 +0000 (03:17 +0000)]
IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634

Patch by Greg Billock <gbillock@google.com> on 2012-05-16
Reviewed by Adam Barth.

Source/WebCore:

The delivered intent has some extra fields and methods (extras,
postResult, postFailure) from the invocation intent. It is implemented
as a subclass. Responses from the service JS are passed to an embedder
client object provided when the intent is delivered.
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
Test: webintents/web-intents-delivery.html

* Modules/intents/DOMWindowIntents.cpp: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(WebCore::DOMWindowIntents::DOMWindowIntents):
(WebCore::DOMWindowIntents::~DOMWindowIntents):
(WebCore::DOMWindowIntents::from):
(WebCore::DOMWindowIntents::webkitIntent):
(WebCore::DOMWindowIntents::deliver):
* Modules/intents/DOMWindowIntents.h: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(DOMWindowIntents):
* Modules/intents/DOMWindowIntents.idl:
* Modules/intents/DeliveredIntent.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::DeliveredIntent::create):
(WebCore::DeliveredIntent::DeliveredIntent):
(WebCore::DeliveredIntent::ports):
(WebCore::DeliveredIntent::getExtra):
(WebCore::DeliveredIntent::postResult):
(WebCore::DeliveredIntent::postFailure):
* Modules/intents/DeliveredIntent.h: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(DeliveredIntent):
(WebCore::DeliveredIntent::~DeliveredIntent):
* Modules/intents/DeliveredIntent.idl: Copied from Source/WebCore/Modules/intents/Intent.h.
* Modules/intents/Intent.h:
(WebCore::Intent::~Intent):
(Intent):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/v8/custom/V8DeliveredIntentCustom.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::V8DeliveredIntent::portsAccessorGetter):

Source/WebKit/chromium:

The embedder will implement the WebDeliveredIntentClient interface, which
will get notifications of postResult/postFailure from the service page.

* public/WebDeliveredIntentClient.h:
* public/WebFrame.h:
(WebKit):
(WebFrame):
* src/WebDeliveredIntentClient.cpp:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::deliverIntent):
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8][Refactoring] Replace throwError("message", XXXError)
haraken@chromium.org [Thu, 17 May 2012 03:14:09 +0000 (03:14 +0000)]
[V8][Refactoring] Replace throwError("message", XXXError)
with throwError(XXXError, "message")
https://bugs.webkit.org/show_bug.cgi?id=86579

Reviewed by Adam Barth.

This is one of a series of refactoring commented in
https://bugs.webkit.org/show_bug.cgi?id=84074#c5

Currently there are two equivalent throwError()s; i.e. throwError("message", XXXError)
and throwError(XXXError, "message"). In this bug we replace
throwError("message", XXXError) with throwError(XXXError, "message")
(except for the case where XXXError == TypeError. This is because
throwError("message", TypeError) will be replaced with throwTypeError("message")
in a follow-up patch).

No tests. No change in behavior.

* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] appcache tests are flaky
commit-queue@webkit.org [Thu, 17 May 2012 02:59:02 +0000 (02:59 +0000)]
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Pass Isolate to remaining toV8()
haraken@chromium.org [Thu, 17 May 2012 02:21:10 +0000 (02:21 +0000)]
[V8] Pass Isolate to remaining toV8()
https://bugs.webkit.org/show_bug.cgi?id=86570

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().

No tests. No change in behavior.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new build slave for EFL port.
gyuyoung.kim@samsung.com [Thu, 17 May 2012 02:18:46 +0000 (02:18 +0000)]
Add new build slave for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=86567

Reviewed by Ryosuke Niwa.

Add a build slave for EFL 32-bit linux build.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGraphicsContext3D interface should not be aware of CanvasRenderingContext
jamesr@google.com [Thu, 17 May 2012 02:18:41 +0000 (02:18 +0000)]
GraphicsContext3D interface should not be aware of CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=86550

Reviewed by Darin Adler.

Source/WebCore:

GraphicsContext3D is a WebCore/platform API construct. CanvasRenderingContext is a WebCore/html concept. Thus,
the former shouldn't depend on the latter.  In turns out that all everyone ever wants from a
CanvasRenderingContext in GraphicsContext3D is its underlying ImageBuffer, which is a WebCore/platform concept,
so this just updates the APIs and implementations to use that instead.

Refactor only, no new tests.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Updates chromium implementation of GraphicsContext3D for API change and removes a bunch of unnecessary
#includes.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Support for Battery Status API on the WebKit-Efl
commit-queue@webkit.org [Thu, 17 May 2012 02:09:16 +0000 (02:09 +0000)]
[EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
Reviewed by Chang Shu.

.:

Add dependency check for e_ukit package which is in the e_dbus library.

* Source/cmake/FindEFL.cmake:

Source/WebKit:

Add e_ukit library and include directory to get battery status of device.

* PlatformEfl.cmake:

Source/WebKit/efl:

The set of e_dbus libraries, e_ukit library in particular, enables to support all types of battery status events (e.g., charging, chargingTime, dischargingTime, level).

* WebCoreSupport/BatteryClientEfl.cpp:
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
* WebCoreSupport/BatteryClientEfl.h:
(WebCore::BatteryClientEfl::batteryStatus):
(BatteryClientEfl):

Tools:

Add e_dbus libraries to jhbuild's modules list.

* efl/jhbuild.modules:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSerializedScriptValue: lazy initialization of static nullValue not threadsafe
jsbell@chromium.org [Thu, 17 May 2012 01:36:11 +0000 (01:36 +0000)]
SerializedScriptValue: lazy initialization of static nullValue not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=70833

Reviewed by Kentaro Hara.

Remove unsafe lazy initialization of static |null| SSV. None of the callers
appeared to be in performance-critical areas - most were preparing an event to
be dispatched to script - so no per-call-site caching was added.

No new tests - no functional changes.

* bindings/js/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
* bindings/js/SerializedScriptValue.h: Return via PassRefPtr.
* bindings/v8/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
* bindings/v8/SerializedScriptValue.h: Return via PassRefPtr.
(SerializedScriptValue):
* dom/Document.cpp:
(WebCore::Document::statePopped): Change to PassRefPtr to maintain refcount.
* dom/Document.h:
(Document):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCachedImage does not clear the ImageObserver pointer when dropping its Image ref
jamesr@google.com [Thu, 17 May 2012 01:31:14 +0000 (01:31 +0000)]
CachedImage does not clear the ImageObserver pointer when dropping its Image ref
https://bugs.webkit.org/show_bug.cgi?id=86689

Reviewed by Eric Seidel.

Image instances keep a weak pointer to their ImageObserver, which may be null. CachedImage is an ImageObserver
and holds a RefPtr<Image> m_image. When CachedImage initializes its m_image to either an SVGImage or BitmapImage,
it sets itself as that Image's ImageObserver. However, CachedImage never clears the ImageObserver pointer, even
when dropping its reference to the Image. This means if other code holds a RefPtr<Image> there is no promise
that calls on that Image will be valid. This patch clears the CachedImage::m_image's ImageObserver pointer
whenever the CachedImage drops its reference. Image already has null checks for its m_imageObserver so this is
always a safe operation.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::~CachedImage):
(WebCore::CachedImage::clear):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Fix a broken copyright of V8SVGElementCustom.cpp
haraken@chromium.org [Thu, 17 May 2012 01:28:22 +0000 (01:28 +0000)]
[V8] Fix a broken copyright of V8SVGElementCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=86569

Reviewed by Nate Chapin.

This patch just fixes a broken copyright of V8SVGElementCustom.cpp.

Blame changeset: r54153

No tests. No change in behavior.

* bindings/v8/custom/V8SVGElementCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Pass Isolate to convertEventTargetToV8Object()
haraken@chromium.org [Thu, 17 May 2012 01:19:31 +0000 (01:19 +0000)]
[V8] Pass Isolate to convertEventTargetToV8Object()
https://bugs.webkit.org/show_bug.cgi?id=86566

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to convertEventTargetToV8Object().
I made the 'isolate' argument optional, since
convertEventTargetToV8Object() can be called from the WebCore context.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrectly display malformed GIFs which specify bogus extension block
pkasting@chromium.org [Thu, 17 May 2012 01:17:46 +0000 (01:17 +0000)]
Correctly display malformed GIFs which specify bogus extension block
sizes.
https://bugs.webkit.org/show_bug.cgi?id=86531

Reviewed by James Robinson.

This was broken by r117333, which was an attempt to avoid memory errors
on GIFs that were malformed in a similar way.  It turns out some GIFs
in the wild (i.e. "our LayoutTests directory") relied on some of the
effects of the old code.  This refixes in a way that doesn't break
these.

No new tests, covered by existing tests.

* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAudioParam must support fan-in (multiple audio connections)
crogers@google.com [Thu, 17 May 2012 01:14:23 +0000 (01:14 +0000)]
AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/audioparam-summingjunction.html

* Modules/webaudio/AudioParam.cpp:
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.

(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.

(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.

(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.

LayoutTests:

* webaudio/audioparam-connect-audioratesignal.html:
* webaudio/audioparam-summingjunction-expected.txt: Added.
* webaudio/audioparam-summingjunction.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper()
haraken@chromium.org [Thu, 17 May 2012 00:46:10 +0000 (00:46 +0000)]
[V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper()
https://bugs.webkit.org/show_bug.cgi?id=86558

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to createV8HTMLWrapper() and createV8SVGWrapper().

Basically 'isolate' has been implemented as the last argument
but before 'forceNewObject' argument, because 'forceNewObject' is an optional
argument and omitted in most cases. Due to the convention,
this patch puts 'isolate' before 'forceNewObject'.

No tests. No change in behavior.

* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove showStyle from CSSStyleDeclaration to StylePropertySet
rniwa@webkit.org [Thu, 17 May 2012 00:30:35 +0000 (00:30 +0000)]
Move showStyle from CSSStyleDeclaration to StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=86675

Reviewed by Andreas Kling.

Moved the function. Also deleted CSSStyleDeclaration.cpp since it's no longer needed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/CSSStyleDeclaration.cpp:
(WebCore):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
* css/StylePropertySet.cpp:
(WebCore):
(WebCore::StylePropertySet::showStyle):
* css/StylePropertySet.h:
(StylePropertySet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the indexed database build for GTK+.
mrobinson@webkit.org [Thu, 17 May 2012 00:28:28 +0000 (00:28 +0000)]
Fix the indexed database build for GTK+.

* GNUmakefile.list.am: Add missing files to the build.
* bindings/gobject/GNUmakefile.am: Be smarter about filtering out deactivating indexed database.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Always skip attributes that return indexed database types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening after r117339 (table baseline computation change).
jchaffraix@webkit.org [Thu, 17 May 2012 00:19:13 +0000 (00:19 +0000)]
Unreviewed gardening after r117339 (table baseline computation change).

* fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/iframe-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
* platform/chromium-mac/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/inline-table-001-expected.txt: Added.
* platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-mac/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/inline-table-003-expected.txt: Added.
* platform/chromium-mac/editing/selection/iframe-expected.png:
* platform/chromium-mac/editing/selection/iframe-expected.txt: Added.
* platform/chromium-mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/chromium-win-vista/editing/selection: Removed.
* platform/chromium-win-vista/fast/css-generated-content: Added.
* platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-vista/fast/inline-block: Added.
* platform/chromium-win-vista/fast/inline-block/001-expected.png: Added.
* platform/chromium-win-xp/fast/css-generated-content: Added.
* platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-xp/fast/inline-block: Added.
* platform/chromium-win-xp/fast/inline-block/001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/inline-table-001-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-win/css2.1/20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-win/css2.1/20110323/inline-table-003-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-win/editing/selection/iframe-expected.png:
* platform/chromium-win/editing/selection/inline-table-expected.png:
* platform/chromium-win/editing/selection/table-caret-3-expected.png:
* platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/chromium-win/fast/inline-block/001-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnimated GIFs in page cache get updated
jonlee@apple.com [Thu, 17 May 2012 00:09:07 +0000 (00:09 +0000)]
Animated GIFs in page cache get updated
https://bugs.webkit.org/show_bug.cgi?id=86668
<rdar://problem/11395549>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/loader/image-in-page-cache.html

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): When we are notified by the CachedImage that the image has
changed, we check to see if the document is in the page cache. If so, we should not be updating,
so we bail out early.

LayoutTests:

This test loads pages with subframes that display the same animated gif. When one of
the pages goes into the page cache, we want to make sure that we do not crash as a
side effect of the page's images getting updated.

* fast/loader/image-in-page-cache-expected.txt: Added.
* fast/loader/image-in-page-cache.html: Added.
* fast/loader/resources/animated-image-subframe.html: Added.
* fast/loader/resources/animated-image.html: Added.
* fast/loader/resources/animated-image2.html: Added.
* fast/loader/resources/animated-image3.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash if SVG gradient stop has display: none set
timothy_horton@apple.com [Thu, 17 May 2012 00:07:16 +0000 (00:07 +0000)]
Crash if SVG gradient stop has display: none set
https://bugs.webkit.org/show_bug.cgi?id=86686
<rdar://problem/10751905>

Reviewed by Dean Jackson.

Source/WebCore:

Create a renderer for SVGStopElement regardless of the "display" property.
This matches the behavior of Opera and the SVG specification.

Test: svg/custom/gradient-stop-display-none-crash.svg

* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::rendererIsNeeded):
(WebCore):
* svg/SVGStopElement.h:
(SVGStopElement):

LayoutTests:

Add a test that ensures that we don't crash if "display: none" is set on an SVGStopElement.

* svg/custom/gradient-stop-display-none-crash-expected.txt: Added.
* svg/custom/gradient-stop-display-none-crash.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline after r116069 and r117339.
philn@webkit.org [Wed, 16 May 2012 23:42:57 +0000 (23:42 +0000)]
Unreviewed, GTK rebaseline after r116069 and r117339.

* platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/gtk/editing/selection/iframe-expected.txt:
* platform/gtk/editing/selection/inline-table-expected.txt:
* platform/gtk/editing/selection/table-caret-3-expected.txt:
* platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
* platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/gtk/fast/forms/input-align-image-expected.txt:
* platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/gtk/fast/inline-block/001-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid...
danakj@chromium.org [Wed, 16 May 2012 23:35:15 +0000 (23:35 +0000)]
[chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid assert in WebPrivateOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86654

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::~WebFilterOperations):
(WebFilterOperations):

Source/WebCore:

* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::reset):
(WebKit::WebFilterOperations::destroy):
(WebKit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
rniwa@webkit.org [Wed, 16 May 2012 23:30:16 +0000 (23:30 +0000)]
REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

* editing/EditingStyle.cpp:
(WebCore::getPropertiesNotIn):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Mark a test as failing.
pkasting@chromium.org [Wed, 16 May 2012 23:29:56 +0000 (23:29 +0000)]
[chromium] Mark a test as failing.
https://bugs.webkit.org/show_bug.cgi?id=86683

Unreviewed, expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMerge nextRootInlineBox with nextLinePosition
rniwa@webkit.org [Wed, 16 May 2012 23:24:34 +0000 (23:24 +0000)]
Merge nextRootInlineBox with nextLinePosition
https://bugs.webkit.org/show_bug.cgi?id=81593

Reviewed by Enrica Casucci.

Call previousRootInlineBox and nextRootInlineBox in previousLinePosition and nextLinePosition respectively
to share the code. Moved out the nullity check of startBox and extracted the renderer's node from the former
two, and added editableType to their argument lists to match the interface in both use cases.

Also moved out the code to extract root inline box using RenderedPosition from those two functions and
expanded in call sites since previousLinePosition and nextLinePosition need to return the candidate position
even when the root inline box doesn't exist. To this end, renamed previousRootInlineBox and nextRootInlineBox
to previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition respectively.

In addition, got rid of one version of nextLeafWithSameEditability that adjusted node with respect to offset
This variant did:

Node* child = node->childNode(offset);
node = child ? child->nextLeafNode() : node->lastDescendant()->nextLeafNode();

instead of:

node = node->nextLeafNode();

at the beginning of the function. Observe that the former code is logically equivalent to:

Node* child = node->childNode(offset);
node = child ? child : node->lastDescendant();
node = node->nextLeafNode();

Thus, the first two lines of this logically equivalent code is added in nextLinePosition wherein we used to
call the removed variant.

This refactoring with no behavioral change would help us resolving the bug 81490.

* editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition): Renamed from previousRootInlineBox.
(WebCore::nextRootInlineBoxCandidatePosition): Renamed from nextRootInlineBox.
(WebCore::logicallyPreviousBox): Checks the nullity of startBox's renderer and node. Also extracts the root
inline box out of the position per the interface change.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Calls previousRootInlineBoxCandidatePosition.
(WebCore::nextLinePosition): Calls nextRootInlineBoxCandidatePosition.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK gardening.
philn@webkit.org [Wed, 16 May 2012 22:56:29 +0000 (22:56 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/test_expectations.txt: Unflag tests needing
rebaseline. I'll pull them from the bot ASAP.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
noel.gordon@gmail.com [Wed, 16 May 2012 22:37:39 +0000 (22:37 +0000)]
[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
https://bugs.webkit.org/show_bug.cgi?id=86346

Reviewed by Adam Barth.

ImageDecoderCG.cpp was added for use in the Chromium port in r70846. Remove the
implementation now that Chromium uses Skia on Mac OSX by default.

No new tests. No change in behavior.

* WebCore.gypi: Remove ImageDecoderCG.cpp from the gyp project.
* platform/graphics/ImageSource.h: Revert the r70846 changes.
* platform/image-decoders/ImageDecoder.cpp: Remove copyReferenceToBitmapData().
(WebCore::ImageFrame::operator=): Return to using copyBitmapData() (as it was)
given the removal of copyReferenceToBitmapData() above.
* platform/image-decoders/ImageDecoder.h:
(ImageFrame): Remove copyReferenceToBitmapData() declaration.
* platform/image-decoders/cg/ImageDecoderCG.cpp: Removed, and it was the only
decoder with a port-specific implementation of copyReferenceToBitmapData().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimplify AudioNode ref-counting by removing RefTypeDisabled
commit-queue@webkit.org [Wed, 16 May 2012 22:27:08 +0000 (22:27 +0000)]
Simplify AudioNode ref-counting by removing RefTypeDisabled
https://bugs.webkit.org/show_bug.cgi?id=85681

Patch by Raymond Toy <rtoy@google.com> on 2012-05-16
Reviewed by Chris Rogers.

Existing tests should cover these changes.

* Modules/webaudio/AudioNode.cpp: Remove RefTypeDiabled and m_disabledRefCount.
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::enableOutputsIfNecessary): New
(WebCore::AudioNode::ref):
(WebCore::AudioNode::disableOutputsIfNecessary): New
(WebCore::AudioNode::finishDeref):
* Modules/webaudio/AudioNode.h: Remove RefTypeDisabled and m_disabledRefCount.
* Modules/webaudio/AudioNodeInput.cpp: Removed uses of RefTypeDisbled.
(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix perf regression from r116487
ojan@chromium.org [Wed, 16 May 2012 22:25:10 +0000 (22:25 +0000)]
Fix perf regression from r116487
https://bugs.webkit.org/show_bug.cgi?id=86680

Reviewed by Ryosuke Niwa.

http://trac.webkit.org/changeset/116487 caused a 6% regression on
Dromaeo's dom-attr test. The issue is that we invalidated NodeList
caches whenever an id/checked/type attribute changed.

First, we don't need to invalidate on checked/type since that only
affects the values return by NodeList items, not the list of items.
Second, we only need to invalidate NodeList caches when an id attribute
changes on a FormControlElement.

Incidentally, we also don't need to invalidate caches for changes
to attributes that don't have an ownerElement.

No new tests. This is strictly a performance improvement.

* dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
* dom/Node.h:
(Node):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] The FCC shows up on an empty input field
commit-queue@webkit.org [Wed, 16 May 2012 22:16:13 +0000 (22:16 +0000)]
[BlackBerry] The FCC shows up on an empty input field
https://bugs.webkit.org/show_bug.cgi?id=86657

Patch by Yongxin Dai <yodai@rim.com> on 2012-05-16
Reviewed by Antonio Gomes.

Turn off the caret by sending a caret changed notification with empty caret.
PR #120620

Reviewed Internally by Mike Fenton.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r117332.
commit-queue@webkit.org [Wed, 16 May 2012 22:10:17 +0000 (22:10 +0000)]
Unreviewed, rolling out r117332.
http://trac.webkit.org/changeset/117332
https://bugs.webkit.org/show_bug.cgi?id=86679

It makes the Qt Linux bot very unhappy (Requested by darktears
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake window-property-shadowing-name.html fail faster
arv@chromium.org [Wed, 16 May 2012 21:58:03 +0000 (21:58 +0000)]
Make window-property-shadowing-name.html fail faster
https://bugs.webkit.org/show_bug.cgi?id=86664

Reviewed by Ojan Vafai.

This makes test sync instead of async by checking the return value of window.open.

* fast/dom/Window/window-property-shadowing-name.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Mark test as flakily timing out.
pkasting@chromium.org [Wed, 16 May 2012 21:55:35 +0000 (21:55 +0000)]
[chromium] Mark test as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=82698

Unreviewed, expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed chromium rebaseline for change in r117310.
eae@chromium.org [Wed, 16 May 2012 21:31:06 +0000 (21:31 +0000)]
Unreviewed chromium rebaseline for change in r117310.

* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png:
* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Removed.
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGC in the middle of JSObject::allocatePropertyStorage can cause badness
mhahnenberg@apple.com [Wed, 16 May 2012 21:21:44 +0000 (21:21 +0000)]
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by Geoff Garen.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
* runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
* runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bad expectation added in r117249.
pkasting@chromium.org [Wed, 16 May 2012 21:18:20 +0000 (21:18 +0000)]
Fix bad expectation added in r117249.
https://bugs.webkit.org/show_bug.cgi?id=82698

Unreviewed, test expectation fix.

* editing/shadow/selection-of-orphan-shadowroot-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
jsbell@chromium.org [Wed, 16 May 2012 21:14:39 +0000 (21:14 +0000)]
[Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
https://bugs.webkit.org/show_bug.cgi?id=86661

Reviewed by Dimitri Glazkov.

* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::autoIncrement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGC is not thread-safe when moving values between C stacks
ggaren@apple.com [Wed, 16 May 2012 21:06:53 +0000 (21:06 +0000)]
GC is not thread-safe when moving values between C stacks
https://bugs.webkit.org/show_bug.cgi?id=86672

Reviewed by Phil Pizlo.

GC pauses thread A while marking thread A, and then B while marking B,
which isn't safe against A and B moving values between each others'
stacks.

This is a theoretical bug -- I haven't been able to reproduce it
in the wild.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots): Pause all C stacks for the
duration of stack marking, to avoid missing values that might be moving
between C stacks.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCSS 2.1 failure: inline-table-001 fails
robert@webkit.org [Wed, 16 May 2012 21:06:10 +0000 (21:06 +0000)]
CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167

Reviewed by Julien Chaffraix.

Source/WebCore:

Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.

Tests:
        css2.1/20110323/inline-table-001.htm
        css2.1/20110323/inline-table-002a.htm
        css2.1/20110323/inline-table-003.htm
        fast/css/empty-cell-baseline.html

* rendering/RenderTable.cpp:
(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):
* rendering/RenderTable.h:
(RenderTable):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a
  baseline. Tested by fast/css/empty-cell-baseline.html

LayoutTests:

* css2.1/20110323/inline-table-001.htm: Added.
* css2.1/20110323/inline-table-002a.htm: Added.
* css2.1/20110323/inline-table-003.htm: Added.
  From the CSS 2.1 test suite.

* fast/css/empty-cell-baseline-expected.html: Added.
* fast/css/empty-cell-baseline.html: Added.
  This ensures we don't take a baseline from an empty cell.

* fast/inline-block/001.html: Modified to make expected results clearer.

* platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.

* platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:
    Progression, the baseline of the text in each cell has moved up to where it should be.
* platform/chromium-linux/editing/selection/iframe-expected.png:
    Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
* platform/chromium-linux/editing/selection/inline-table-expected.png:
    Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
* platform/chromium-linux/editing/selection/table-caret-3-expected.png:
    Progression, 'foo' and 'baz' line up with the first row of the inline table.
* platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:
    Progression, 'Test' and 'content' now line up.
* platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
    Progression, the two boxes now line up.
* platform/chromium-linux/fast/inline-block/001-expected.png:
    Progression, the boxes now line up in the same way as FF and Opera.
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
    Progression, the baseline of the text in each cell has moved up to where it should be.

* platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/chromium-win/editing/selection/iframe-expected.txt:
* platform/chromium-win/editing/selection/inline-table-expected.txt:
* platform/chromium-win/editing/selection/table-caret-3-expected.txt:
* platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
* platform/chromium-win/fast/inline-block/001-expected.txt:
* platform/chromium-win/fast/repaint/float-overflow-expected.txt:
* platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:
    Text rebaselines.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Rename valid/finished methods to isValid/isFinished to match coding standard
jsbell@chromium.org [Wed, 16 May 2012 21:02:21 +0000 (21:02 +0000)]
IndexedDB: Rename valid/finished methods to isValid/isFinished to match coding standard
https://bugs.webkit.org/show_bug.cgi?id=86655

Reviewed by Tony Chang.

No new tests - no functional changes.

* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::isValid): valid() => isValid()
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::transactionFinished):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::isFinished): finished() => isFinished()
* Modules/indexeddb/IDBTransaction.h:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
commit-queue@webkit.org [Wed, 16 May 2012 20:57:22 +0000 (20:57 +0000)]
[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Brady Eidson.

Unskip the related test from mac-kw2 and gtk-wk2 as support has been added.

* platform/gtk-wk2/Skipped:
* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImageLoader can still dispatch beforeload events for ImageDocuments
jpfau@apple.com [Wed, 16 May 2012 20:56:50 +0000 (20:56 +0000)]
ImageLoader can still dispatch beforeload events for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=86658
<rdar://problem/11465863>

Reviewed by Brady Eidson.

Prevent flags regarding sending beforeload events from being set on ImageDocuments.

No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agolayerX/layerY warning should be removed
jchaffraix@webkit.org [Wed, 16 May 2012 20:50:53 +0000 (20:50 +0000)]
layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264

Reviewed by James Robinson.

Source/WebCore:

Covered by: fast/dom/Window/window-xy-properties.html
            fast/events/init-events.html
            fast/events/mouse-relative-position.html
            fast/events/mouseclick-target-and-positioning.html
            fast/events/simulated-click-coords.html
            jquery/event.html

This change just removes the warning pending proper investigation.

Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
* dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
* dom/UIEvent.h:
Removed warnDeprecatedLayerXYUsage and all the associated calls.

LayoutTests:

Removed console message about layerX/layerY deprecation.

* fast/dom/Window/window-xy-properties-expected.txt:
* fast/events/init-events-expected.txt:
* fast/events/mouse-relative-position-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/events/simulated-click-coords-expected.txt:
* jquery/event-expected.txt:
* platform/qt/fast/events/mouse-relative-position-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Use accessors for backing store / database id in store/index backends
jsbell@chromium.org [Wed, 16 May 2012 20:41:26 +0000 (20:41 +0000)]
IndexedDB: Use accessors for backing store / database id in store/index backends
https://bugs.webkit.org/show_bug.cgi?id=86652

Reviewed by Tony Chang.

Hide the private members m_backingStore and m_databaseId of IDBObjectStoreBackendImpl
and IDBIndexBackendImpl behind accessors. This is preparation for removing these
members and only holding references to the IDBDatabaseBackendImpl: webkit.org/b/83074

No new tests - no functional changes.

* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::backingStore): Added.
(WebCore::IDBIndexBackendImpl::databaseId): Added.
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::backingStore): Added.
(WebCore::IDBObjectStoreBackendImpl::databaseId): Added.
(IDBObjectStoreBackendImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMalformed GIF can cause decoder to read off end of heap buffer
pkasting@chromium.org [Wed, 16 May 2012 20:36:40 +0000 (20:36 +0000)]
Malformed GIF can cause decoder to read off end of heap buffer
https://bugs.webkit.org/show_bug.cgi?id=86531

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/images/read-past-end-of-buffer.html
This test is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.

* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):

LayoutTests:

The test here is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.

* fast/images/read-past-end-of-buffer-expected.txt: Added.
* fast/images/read-past-end-of-buffer.html: Added.
* fast/images/resources/wrong-block-length.gif: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] REGRESSION?(62951): media tests fail
alexis.menard@openbossa.org [Wed, 16 May 2012 20:31:17 +0000 (20:31 +0000)]
[Qt] REGRESSION?(62951): media tests fail
https://bugs.webkit.org/show_bug.cgi?id=42094

Reviewed by Noam Rosenthal.

Enable some media layout tests so that our coverage is more than inexistant.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Don't reset the default font families in WebSettings
efidler@rim.com [Wed, 16 May 2012 20:20:10 +0000 (20:20 +0000)]
[BlackBerry] Don't reset the default font families in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86660

Reviewed by Rob Buis.

PR 152467
The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp

* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add WebKit API to access inner text value of input element
beidson@apple.com [Wed, 16 May 2012 20:15:27 +0000 (20:15 +0000)]
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353

Patch by Keishi Hattori <keishi@webkit.org> on 2012-05-16
Reviewed by Kent Tamura.

* Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed GTK gardening, rebaselining after r117310.
zandobersek@gmail.com [Wed, 16 May 2012 20:07:33 +0000 (20:07 +0000)]
Unreviewed GTK gardening, rebaselining after r117310.

* platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
commit-queue@webkit.org [Wed, 16 May 2012 20:04:36 +0000 (20:04 +0000)]
[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236

Patch by Varun Jain <varunjain@google.com> on 2012-05-16
Reviewed by Tony Chang.

.:

* ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.

Source/WebCore:

ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html

* page/DragController.cpp:
(WebCore::createMouseEvent):
* platform/DragData.cpp:
(WebCore):
(WebCore::DragData::modifierKeyState):
* platform/DragData.h:
(DragData):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::modifierKeyState):
(WebCore::ChromiumDataObject::setModifierKeyState):
(ChromiumDataObject):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::webInputEventKeyStateToPlatformEventKeyState):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<video> elements with no video tracks report false for webkitSupportsFullscreen.
jer.noble@apple.com [Wed, 16 May 2012 19:55:05 +0000 (19:55 +0000)]
<video> elements with no video tracks report false for webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated media/media-fullscreen-inline.html.

With the new Full Screen API, the restriction that only video elements with
video tracks can enter full screen seems arbitrary. Some media types will
occasionally determine they have video tracks long after loadedmetadata, which
breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
supported so as to no longer require hasVideo().

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):

LayoutTests:

Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
Fix the media-fullscreen-inline.html test and unskip on Lion.

* media/media-fullscreen-inline-expected.txt:
* media/media-fullscreen-inline.html:
* media/media-fullscreen.js:
(fullscreenchange):
(loadedmetadata):
(addEventListeners):
* platform/mac-lion/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
commit-queue@webkit.org [Wed, 16 May 2012 19:48:12 +0000 (19:48 +0000)]
[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

Removed test from skipped list, since it now passes on mac.

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-16
Reviewed by Alexis Menard.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WinCairo] Unreviewed build change after exported symbol
bfulgham@webkit.org [Wed, 16 May 2012 19:40:52 +0000 (19:40 +0000)]
[WinCairo] Unreviewed build change after exported symbol
updates (r114790) and expansion of CG routines in WebPage
PDF output (r114476).

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToPDF): Exclude CG use on WinCairo.
(WebKit::WebPage::drawPagesToPDF): Exclude CG use on WinCairo.
* win/WebKit2CFLite.def: Don't claim to export symbols we don't
provide (e.g., full screen API calls).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAvoid reparsing the style attribute when cloning elements.
kling@webkit.org [Wed, 16 May 2012 19:31:40 +0000 (19:31 +0000)]
Avoid reparsing the style attribute when cloning elements.
<http://webkit.org/b/86574>

Reviewed by Antti Koivisto.

Refactor cloning of attributes a bit to dodge the styleAttr reparse previously
caused by ElementAttributeData::setAttributes().

Introduced Element::cloneDataFromElement() which takes care of cloning the
ElementAttributeData as well as "non-attribute properties" (which is currently
specific to HTMLInputElement.)

Also includes some additional dodging of attribute vector traversal to find
old/new 'id' and 'name' attributes.

I'm seeing a ~10% improvement on PerformanceTests/DOM/CloneNodes locally.

* dom/Document.cpp:
(WebCore::Document::importNode):
* dom/Element.cpp:
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::cloneDataFromElement):
* dom/Element.h:
(WebCore::Element::copyNonAttributePropertiesFromElement):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/Node.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::parseAttribute):
* dom/StyledElement.h:
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* html/HTMLElement.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
* html/HTMLInputElement.h:
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WinCairo] Unreviewed build change after r115385. Several Cairo
bfulgham@webkit.org [Wed, 16 May 2012 19:25:25 +0000 (19:25 +0000)]
[WinCairo] Unreviewed build change after r115385.  Several Cairo
image routines were modified to use new wrapper classes, but the
relevant WinCairo sources were not updated to match.

* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117322 268f45cc-cd09-0410-ab3c-d52691b4dbfc