platform/core/csapi/xsf.git
4 years ago[C] force update size on View updated (#6936)
Stephane Delcroix [Thu, 15 Aug 2019 22:41:06 +0000 (00:41 +0200)]
[C] force update size on View updated (#6936)

4 years agofix merge (#7164)
Stephane Delcroix [Thu, 15 Aug 2019 06:30:07 +0000 (08:30 +0200)]
fix merge (#7164)

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 14 Aug 2019 18:41:24 +0000 (20:41 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Wed, 14 Aug 2019 18:38:33 +0000 (20:38 +0200)]
Merge branch '4.0.0' into 4.1.0

4 years agoRemove NestedScrollView from the default shell layout (#7032)
Shane Neuville [Wed, 14 Aug 2019 16:06:54 +0000 (10:06 -0600)]
Remove NestedScrollView from the default shell layout (#7032)

* Remove NestedScrollView from the default shell layout

* only set NestedScrollingEnabled if parent is NestedScrollView

* Automate UI Tests

* - remove C#  7.1 feature and fix UI tests for iOS

* -additional c# 7.1 fixes

* -change ui tests to use gestures for scrolling

4 years agoFixes issue #7109 in XF 4.0 branch (#7151)
Jonathan Goldberger [Wed, 14 Aug 2019 14:59:50 +0000 (04:59 -1000)]
Fixes issue #7109 in XF 4.0 branch (#7151)

4 years agoUse NSIndexPath.Item instead of .Row in CollectionView (#7107)
E.Z. Hart [Wed, 14 Aug 2019 14:10:45 +0000 (08:10 -0600)]
Use NSIndexPath.Item instead of .Row in CollectionView (#7107)

* Use NSIndexPath.Item in CollectionView (instead of .Row)
Fixes #6737

* Missed a couple of .Row usages

4 years agoAdded missing NamedSizes for WPF (#7116)
Gerald Versluis [Tue, 13 Aug 2019 09:59:37 +0000 (11:59 +0200)]
Added missing NamedSizes for WPF (#7116)

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

4 years agoadd wait before WaitForNoElement (#7132)
Shane Neuville [Tue, 13 Aug 2019 09:31:43 +0000 (03:31 -0600)]
add wait before WaitForNoElement (#7132)

4 years ago[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread funct...
Pavel Yakovlev [Tue, 13 Aug 2019 06:32:08 +0000 (09:32 +0300)]
[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread function (#7044)

4 years ago[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)
thisisthekap [Mon, 12 Aug 2019 21:08:16 +0000 (23:08 +0200)]
[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)

* disable AndroidTicker if AnimatorDurationScale is equal or below 0

* made IsAnimatorEnabled null safe

* changed defautl behavior of IsAnimatorEnabled to disable animations if android context or context resolver are null

4 years ago[UITest] Fix 2951 and moved extension method to be more visible (#7108)
Shane Neuville [Fri, 9 Aug 2019 17:56:00 +0000 (11:56 -0600)]
[UITest] Fix 2951 and moved extension method to be more visible (#7108)

* [UITest] Fix 2951 and moved extension method to be more visible

* fix spacing

* tabs

5 years ago[Bug] NullReferenceException Closing Window During Animation (#7067)
Gerald Versluis [Fri, 9 Aug 2019 00:51:06 +0000 (02:51 +0200)]
[Bug] NullReferenceException Closing Window During Animation (#7067)

* Added null check to current application for WPF

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
fixes #7061

5 years agoUpdate Issue2577.cs (#7088)
Gerald Versluis [Thu, 8 Aug 2019 16:49:21 +0000 (18:49 +0200)]
Update Issue2577.cs (#7088)

5 years agoUpdate Issue2499.cs (#7086)
Gerald Versluis [Thu, 8 Aug 2019 16:47:13 +0000 (18:47 +0200)]
Update Issue2499.cs (#7086)

5 years agoUpdate Issue4187.cs (#7087)
Gerald Versluis [Thu, 8 Aug 2019 10:49:36 +0000 (12:49 +0200)]
Update Issue4187.cs (#7087)

5 years ago[XamlC] throw XPE on missing resource key (#7073)
Stephane Delcroix [Thu, 8 Aug 2019 08:46:17 +0000 (10:46 +0200)]
[XamlC] throw XPE on missing resource key (#7073)

When a resource was missing a key (non-implicit resource), XamlC was throwing
an AssemblyResolutionException instead of a proper XamlParseException when the
type of the resource was in a different xmlns than the default Forms one.

All the other cases are fine (default xmlns, or non-compiled Xaml)

- fixes AB#946693

5 years ago[C] Dispose the Disposable (#7020)
Stephane Delcroix [Thu, 8 Aug 2019 08:44:22 +0000 (10:44 +0200)]
[C] Dispose the Disposable (#7020)

Dispose the disposable readers while parsing StyleSheets

- fixes #6986

5 years ago[iOS] CollectionView Header/Footer (#7094)
Shane Neuville [Thu, 8 Aug 2019 07:07:16 +0000 (01:07 -0600)]
[iOS] CollectionView Header/Footer (#7094)

* [iOS] CollectionView Header/Footer

* - add iOS tests

* - fix comments

5 years ago[Android] Click on the center of the down stepper button (#7080)
Shane Neuville [Wed, 7 Aug 2019 17:16:03 +0000 (11:16 -0600)]
[Android] Click on the center of the down stepper button (#7080)

* Locate the actual stepper button for clicking

* Leave iOS test alone

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/InputTransparentTests.cs

5 years agoFix bug where wrong buttons were acted on (#6961)
Gerald Versluis [Tue, 6 Aug 2019 09:13:36 +0000 (11:13 +0200)]
Fix bug where wrong buttons were acted on (#6961)

5 years agodisable gestures on shell View Pager (#7030)
Shane Neuville [Tue, 6 Aug 2019 01:48:17 +0000 (19:48 -0600)]
disable gestures on shell View Pager (#7030)

fixes #6310
fixes #6060

5 years ago[XamlC] don't reset the NameScope if it exists (#7040)
Stephane Delcroix [Tue, 6 Aug 2019 01:24:29 +0000 (03:24 +0200)]
[XamlC] don't reset the NameScope if it exists (#7040)

if the object creation already creates a namescope (because it's created from xaml), do not override the namescope

- fixes #6192
- fixes #AB957727
- fixes #6902

5 years ago[UITest] Change Query to WaitForElement on 45125 and change GetResult to await for...
Shane Neuville [Mon, 5 Aug 2019 20:26:34 +0000 (14:26 -0600)]
[UITest] Change Query to WaitForElement on 45125 and change GetResult to await for Performance Gallery testing (#7057)

* change query to waitforelement and use async over GetResult

* - ConfigureAwait(false)

5 years agoEnsure FlowDirection propagates to EmptyView when not using a template (#6998)
E.Z. Hart [Mon, 5 Aug 2019 20:05:30 +0000 (14:05 -0600)]
Ensure FlowDirection propagates to EmptyView when not using a template (#6998)

* Make sure FlowDirection propagates to EmptyView when not using a template

* Resolve rebase issues

* Fix stuck EmptyView

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 1 Aug 2019 20:32:14 +0000 (13:32 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years ago[UWP] The SelectedItem in a ListView is not highlighted when set while constructing...
Gerald Versluis [Thu, 1 Aug 2019 11:28:29 +0000 (13:28 +0200)]
[UWP] The SelectedItem in a ListView is not highlighted when set while constructing a page (#6973)

* Enable selection of an item from constructor

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

5 years agoUse Xamarin.Forms.Size instead of Android.Util.Size to work with API < 21 (#7033...
E.Z. Hart [Thu, 1 Aug 2019 10:30:27 +0000 (04:30 -0600)]
Use Xamarin.Forms.Size instead of Android.Util.Size to work with API < 21 (#7033) fixes #6815

Fixes #6815

5 years agoPrevent DisplayEnd for cell on bounce (#7028)
Gerald Versluis [Thu, 1 Aug 2019 09:55:29 +0000 (11:55 +0200)]
Prevent DisplayEnd for cell on bounce (#7028)

5 years agoModify UI Test 6286 to await push and pop (#7022)
Shane Neuville [Wed, 31 Jul 2019 15:59:30 +0000 (09:59 -0600)]
Modify UI Test 6286 to await push and pop (#7022)

* Modify 6286 test to await push and pop

* convert over to use Tasks

5 years agoAndroid CollectionView Header/Footer (non-sticky) (#6948)
E.Z. Hart [Tue, 30 Jul 2019 18:54:43 +0000 (12:54 -0600)]
Android CollectionView Header/Footer (non-sticky) (#6948)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Tue, 30 Jul 2019 14:32:14 +0000 (16:32 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Tue, 30 Jul 2019 14:31:31 +0000 (16:31 +0200)]
Merge branch '4.0.0' into 4.1.0

5 years agoMake it easier to create custom renderers for alternate CV layouts on Android (#6990)
E.Z. Hart [Tue, 30 Jul 2019 10:27:36 +0000 (04:27 -0600)]
Make it easier to create custom renderers for alternate CV layouts on Android (#6990)

Demo of StaggeredGridLayoutManager on Android

5 years ago[UWP] Register the Xaml assembly (#7004)
Stephane Delcroix [Tue, 30 Jul 2019 07:45:11 +0000 (09:45 +0200)]
[UWP] Register the Xaml assembly (#7004)

the Xaml asssembly need to be scanned for DependecyServices. The
code in place intended it, but was referring to the wrong type...

 - fixes #6974

5 years ago[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView ...
Gerald Versluis [Tue, 30 Jul 2019 06:25:59 +0000 (08:25 +0200)]
[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView (#6910)

* Fix and UI test

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Last typo fix

5 years agoUWP CollectionView cleanup (#6928)
E.Z. Hart [Mon, 29 Jul 2019 23:50:11 +0000 (17:50 -0600)]
UWP CollectionView cleanup (#6928)

* Move files to CollectionView folder for consistency with other platforms
Move SelectableItemsViewRenderer to Setup/Teardown pattern
Fix event handler naming
Use Is method for property changed check

* Rebase cleanup

5 years ago[UWP] Fixes default button padding (#6455)
Pavel Yakovlev [Mon, 29 Jul 2019 23:49:18 +0000 (02:49 +0300)]
[UWP] Fixes default button padding (#6455)

fixes #6450

5 years agofixes .create-nuget script (#6913)
Pavel Yakovlev [Mon, 29 Jul 2019 21:11:38 +0000 (00:11 +0300)]
fixes .create-nuget script (#6913)

5 years agoCollectionView Android - Fix adapter update (#6840)
Andrei Nitescu [Mon, 29 Jul 2019 17:37:52 +0000 (20:37 +0300)]
CollectionView Android - Fix adapter update (#6840)

* CollectionView Android - Fix adapter update #6840

* Fix missing end tag

* Added APP compiler directive

* Update Issue6644.xaml.cs

fixes #6644
fixes #6839

5 years agoImplement DataTemplateSelector support for CollectionView on UWP (#6918)
E.Z. Hart [Mon, 29 Jul 2019 17:10:20 +0000 (11:10 -0600)]
Implement DataTemplateSelector support for CollectionView on UWP (#6918)

fixes #6898

5 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Mon, 29 Jul 2019 09:23:54 +0000 (10:23 +0100)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Mon, 29 Jul 2019 09:22:33 +0000 (10:22 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoiOS - Test and fix for VoiceOver crash on a ContentPage not having any Content define...
Samantha Houts [Mon, 29 Jul 2019 09:01:24 +0000 (02:01 -0700)]
iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926

* Added test case for showing crash for issue 6926.

* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.

5 years ago[Android] add check for double dispose scrollview/page/platform (#6923)
Shane Neuville [Fri, 26 Jul 2019 07:54:10 +0000 (01:54 -0600)]
[Android] add check for double dispose scrollview/page/platform (#6923)

5 years agoAdded UpdateScreenSize call at instantiation (#6912)
Gerald Versluis [Thu, 25 Jul 2019 20:24:31 +0000 (22:24 +0200)]
Added UpdateScreenSize call at instantiation (#6912)

5 years ago[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108
Pavel Yakovlev [Thu, 25 Jul 2019 16:39:08 +0000 (19:39 +0300)]
[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108

* [Android] fixes previewer exceptions with SearchBar

* added comment

5 years ago[Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView...
adrianknight89 [Thu, 25 Jul 2019 13:07:28 +0000 (08:07 -0500)]
[Android/iOS] RemainingItemsThreshold and Scrolled implementation for CollectionView (#5754)

* infinite scroll capability

* remove added line

* scroll event implementation

* add offset calculation for GridLayoutManager

* removed custom layout managers

* renamed variables

* changed comment

* implement CenterItemIndex

* fixed pageSize

* removed artifact

* handle the case when the layout manager is not linear

* fix comment

* call base dispose

* code review changes

* remove unused references

* indentation fix

* fix compilation issues

* revert cleanup

* fix

* fix crash

* fix test

* fix index issue

* removed unused method

* fix

* moved private variables into app scope

* Added back UI test

* Name to AutomationID

* added command parameter and addressed minor suggestions

5 years agoFixes #6539 (#6969)
kingces95 [Thu, 25 Jul 2019 09:52:36 +0000 (23:52 -1000)]
Fixes #6539 (#6969)

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Tue, 23 Jul 2019 16:12:34 +0000 (18:12 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years ago[Android] Fix previewer exceptions with TabbedPage (#6897)
Pavel Yakovlev [Mon, 22 Jul 2019 16:53:28 +0000 (19:53 +0300)]
[Android] Fix previewer exceptions with TabbedPage (#6897)

* [Android] Fix previewer exceptions with TabbedPage

* - consolidated code

5 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Sun, 21 Jul 2019 19:56:23 +0000 (20:56 +0100)]
Merge branch '4.1.0' into 4.2.0

5 years ago[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
Alan Grgic [Fri, 19 Jul 2019 10:58:59 +0000 (05:58 -0500)]
[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728

* add reproduction

* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh

5 years agoFix - Prevent race condition between activity create and dispose. (#6596)
Kevin Petit [Fri, 19 Jul 2019 10:50:02 +0000 (12:50 +0200)]
Fix - Prevent race condition between activity create and dispose. (#6596)

5 years agoMacOS: Allow third party libs to display animated images correctly (#6302)
Daniel Luberda [Fri, 19 Jul 2019 10:43:39 +0000 (12:43 +0200)]
MacOS: Allow third party libs to display animated images correctly (#6302)

* Mac Animated NSImage support

5 years agoAdded UITest for #2577 (#6728)
Gerald Versluis [Thu, 18 Jul 2019 11:43:27 +0000 (13:43 +0200)]
Added UITest for #2577 (#6728)

* Added UITest for issue 2577

* Added Wait statements

* Apply suggestions from code review

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* AutomationId to const

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* All strings to const

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 18 Jul 2019 03:03:30 +0000 (20:03 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 18 Jul 2019 02:58:30 +0000 (19:58 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years ago[Bug][iOS] listview / observable collection throwing native error on load (#6576)
Gerald Versluis [Thu, 18 Jul 2019 02:49:21 +0000 (04:49 +0200)]
[Bug][iOS] listview / observable collection throwing native error on load (#6576)

* Added reproduction and commented out the misbehaving code

* Fixed merge conflicts

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Implemented UI test

* Somehow merged in a non-existing UI test

* Removed DetermineEstimatedRowHeight in WillDisplay

* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"

This reverts commit 431178d923c3bf642aae83331a5dc5b57c4436de.

* Removed WillDisplay with DetermineEstimatedRowHeight

* Reinstate projitems

* Added some more test scenarios

* Removed commented code

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472

5 years ago[Android] refactoring fixes layouts (#6390)
Pavel Yakovlev [Thu, 18 Jul 2019 01:29:08 +0000 (04:29 +0300)]
[Android] refactoring fixes layouts (#6390)

* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)

* issue3000 and ToolbarItem tests should be passes

* MaybeRequestLayout extension method

* added automated UITest 5766

* fix 5766

* fix 6297

* merge 6297 into 5766 uitest

* rename test

5 years agoImplement ItemsUpdatingScrollMode on Android and iOS (#6879)
E.Z. Hart [Tue, 16 Jul 2019 17:40:26 +0000 (11:40 -0600)]
Implement ItemsUpdatingScrollMode on Android and iOS (#6879)

5 years agotry to fix the build
Stephane Delcroix [Tue, 16 Jul 2019 10:26:33 +0000 (12:26 +0200)]
try to fix the build

5 years ago[Core] Missing await in Device.InvokeOnMainThreadAsync(Func<Task>) (#6718)
Keith Dahlby [Tue, 16 Jul 2019 07:20:10 +0000 (02:20 -0500)]
[Core] Missing await in Device.InvokeOnMainThreadAsync(Func<Task>) (#6718)

* [Core] Use local functions

* [Core] Extract DeviceUnitTests

* [Core] Ensure actually called from main thread

* [Core] Add InvokeOnMainThread tests

WithAsyncTask is expected to fail.

* [Core] Rename local wrapper functions

* [Core] Avoid ambiguous call

CS0121: The call is ambiguous between the following methods or
properties: 'Device.InvokeOnMainThreadAsync(Action)' and
'Device.InvokeOnMainThreadAsync(Func<Task>)'

https://github.com/dotnet/roslyn/issues/14885
https://github.com/dotnet/csharplang/issues/98

5 years ago [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)
Samantha Houts [Tue, 16 Jul 2019 02:17:48 +0000 (19:17 -0700)]
 [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)

* Add repro for #6286 (doesn't crash, though)

* [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose
fixes #6286

5 years ago[iOS] ItemsViewLayout needs strategy on the ctor (#6690)
Rui Marinho [Mon, 15 Jul 2019 18:32:00 +0000 (19:32 +0100)]
[iOS] ItemsViewLayout needs strategy on the ctor (#6690)

5 years agoUpdate GitInfo.txt
Rui Marinho [Mon, 15 Jul 2019 18:23:27 +0000 (19:23 +0100)]
Update GitInfo.txt

5 years ago[iOS] fixes material checkbox color (#6820) fixes #6816
Pavel Yakovlev [Mon, 15 Jul 2019 17:39:21 +0000 (20:39 +0300)]
[iOS] fixes material checkbox color (#6820) fixes #6816

5 years agoFixes binding to nullable types (#6860)
Andrei Nitescu [Mon, 15 Jul 2019 11:34:54 +0000 (14:34 +0300)]
Fixes binding to nullable types  (#6860)

-fixes #6280

5 years ago[X] do not compile binding set as property values (#6837)
Stephane Delcroix [Mon, 15 Jul 2019 10:02:13 +0000 (12:02 +0200)]
[X] do not compile binding set as property values (#6837)

binding passed as properties don't have a valid datatype, so do not compile those.

- fixes #5240

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Fri, 12 Jul 2019 14:22:56 +0000 (16:22 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years ago[HR] properly reload merged rds
Stephane Delcroix [Fri, 12 Jul 2019 13:40:16 +0000 (15:40 +0200)]
[HR] properly reload merged rds

5 years agoDon't force binding expression applications to queue (#6857)
E.Z. Hart [Fri, 12 Jul 2019 11:07:57 +0000 (05:07 -0600)]
Don't force binding expression applications to queue (#6857)

* Don't force binding expression applications to queue; fixes #6609

* Make PropertyChangeBindingsOccurThroughMainThread test what it claims to test

5 years agoAdd Scrollbar Visibility option to the CollectionView (#6602)
Ravinder Jangra [Thu, 11 Jul 2019 23:03:12 +0000 (04:33 +0530)]
Add Scrollbar Visibility option to the CollectionView (#6602)

* Add Horizontal and Vertical Scrollbar Visibility option to the CollectionView

* bump gitinfo

* make requested changes

* Add Android implementation

* use ScrollBarVisibility.Default instead of 0 and other requested changes
fixes #6053

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 11 Jul 2019 22:44:58 +0000 (15:44 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoFixed: Button CornerRadius doesn't work in explicit style (#6753)
Mike Schwörer [Thu, 11 Jul 2019 08:52:18 +0000 (10:52 +0200)]
Fixed: Button CornerRadius doesn't work in explicit style (#6753)

- fixes #5046

* Fixed #5046 - Button CornerRadius doesn't work in explicit style

* Added Unit Test

* Requested changes from PR

* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests

* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Do not add ButtonCornerRadius in csproj

* removed dangling changes in ButtonUnitTest.cs

5 years agoAdd protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
Andrei Nitescu [Thu, 11 Jul 2019 01:35:25 +0000 (04:35 +0300)]
Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)

fixes #6747

5 years ago[Android] Uniformize handler name (CollectionView) (#6720)
Kevin Petit [Thu, 11 Jul 2019 01:34:26 +0000 (03:34 +0200)]
[Android] Uniformize handler name (CollectionView) (#6720)

* CollectionView - Uniformize handler name.

* Address naming feedback.

* Revert BOM.

5 years agoAuto-focus next view from Entry with ReturnType.Next (#6706)
Joe Manke [Wed, 10 Jul 2019 17:18:42 +0000 (13:18 -0400)]
Auto-focus next view from Entry with ReturnType.Next (#6706)

* Automatically focus the next view after hitting the Return key on an Entry with ReturnType.Next

* UWP implementation

5 years ago[X] hide TypedBinding from Intelisense
Stephane Delcroix [Wed, 10 Jul 2019 10:18:17 +0000 (12:18 +0200)]
[X] hide TypedBinding from Intelisense

5 years agoFix Page implicit and inherited style with ControlTemplate #6657 (#6661)
Andrei Nitescu [Wed, 10 Jul 2019 02:03:16 +0000 (05:03 +0300)]
Fix Page implicit and inherited style with ControlTemplate #6657 (#6661)

* Fix Page implicit and inherited style with ControlTemplate #6657

* Update StyleTests.cs
fixes #6657

5 years ago[Android] Fix KeyNotFoundException during Shell Navigation (#6740)
Alan Grgic [Wed, 10 Jul 2019 00:24:10 +0000 (19:24 -0500)]
[Android] Fix KeyNotFoundException during Shell Navigation (#6740)

* fix android shell nav crash

* add reproduction test

* add automation and address feedback

* move fragmet creation of stack items to after switch statement

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* [iOS] fix shell section disposals so multiple page renderers don't get assigned

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Tue, 9 Jul 2019 17:50:41 +0000 (10:50 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years agoFix for Switch on Android losing shadow #6798 (#6798)
Andrei Nitescu [Mon, 8 Jul 2019 23:51:37 +0000 (02:51 +0300)]
Fix for Switch on Android losing shadow #6798 (#6798)

5 years agoReimplement ITabStop to return the EditText on Android Material renderers that use...
Joe Manke [Mon, 8 Jul 2019 23:17:05 +0000 (19:17 -0400)]
Reimplement ITabStop to return the EditText on Android Material renderers that use TextInputLayout as the native Control (#6732)

fixes #5102

5 years ago[X] Allow x:Null for x:DataType (#6822)
Stephane Delcroix [Mon, 8 Jul 2019 23:03:32 +0000 (01:03 +0200)]
[X] Allow x:Null for x:DataType (#6822)

- fixes #6648

5 years ago[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
Shane Neuville [Sun, 7 Jul 2019 22:08:31 +0000 (16:08 -0600)]
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)

* [ios] fix safeareas and use marging to offset flyout

* android fixes for margin

* [iOS] frame size and inset fixes

* android fix header offset

* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* top offset fixes

* add mask back in for scrolling header

* fix NRE when FlyoutHeader is null

* tweak Bugzilla26993Test

5 years agoClear global routes on unit tests and process global routes in the right place (...
Shane Neuville [Sat, 6 Jul 2019 19:56:10 +0000 (13:56 -0600)]
Clear global routes on unit tests and process global routes in the right place (#6781)

* Clear global routes on unit tests and process global routes in the right place

* - route with current item in case shellSection is null

* inset ui test fix

* Fix ColorFilter for API 19

* add missing file

5 years agoFix for #6444: Propagate binding context for children of shell sections (#6730)
Christopher Dresel [Fri, 5 Jul 2019 18:29:42 +0000 (20:29 +0200)]
Fix for #6444: Propagate binding context for children of shell sections (#6730)

* Propagate binding context for children of shell sections

* Added a few more BindingContext Propagation tests

5 years agoCreate UI test template for XAML pages (#5853)
adrianknight89 [Thu, 4 Jul 2019 04:09:02 +0000 (23:09 -0500)]
Create UI test template for XAML pages (#5853)

* create template for XAML pages

* update existing template

* added BindingContext

* removed whitespace

* move BindingContext

* change class name to Issue

* fixed absolute path

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 4 Jul 2019 03:49:49 +0000 (20:49 -0700)]
Merge branch '4.1.0'

5 years agoFix Map Gallery page (#6603)
Andrei Nitescu [Thu, 4 Jul 2019 00:31:27 +0000 (03:31 +0300)]
Fix Map Gallery page (#6603)

5 years agoMerge branch '4.1.0'
Samantha Houts [Thu, 4 Jul 2019 00:16:32 +0000 (17:16 -0700)]
Merge branch '4.1.0'

5 years agoAdd Color.ToHex() (#6272)
David Roqueni [Thu, 4 Jul 2019 00:13:01 +0000 (17:13 -0700)]
Add Color.ToHex() (#6272)

* Updated Color to have ToHex() method. Created Unit tests to ensure method is working as expected.

* Updated ToHex() use uint values. Updated unit tests for ToHex.
fixes #6003

5 years agoSwitch ThumbColor (#6312)
Andrei Nitescu [Thu, 4 Jul 2019 00:08:56 +0000 (03:08 +0300)]
Switch ThumbColor (#6312)

fixes #5415

5 years agoAdd constructor in WkWebViewRenderer to use custom configuration (#6578)
Ravinder Jangra [Thu, 4 Jul 2019 00:05:55 +0000 (05:35 +0530)]
Add constructor in WkWebViewRenderer to use custom configuration (#6578)

5 years agoMap MoveToLastRegionOnLayoutChange Property (#6601)
Andrei Nitescu [Thu, 4 Jul 2019 00:05:17 +0000 (03:05 +0300)]
Map MoveToLastRegionOnLayoutChange Property (#6601)

fixes #6222

5 years ago[UWP] fixes crash after reset corner radius (#6744)
Pavel Yakovlev [Thu, 4 Jul 2019 00:03:13 +0000 (03:03 +0300)]
[UWP] fixes crash after reset corner radius (#6744)

5 years ago[Shell] Apply Query string parameters even if they aren't present and correctly apply...
Shane Neuville [Wed, 3 Jul 2019 23:57:46 +0000 (17:57 -0600)]
[Shell] Apply Query string parameters even if they aren't present and correctly apply them to nested pages (#6695)

* apply query string parameters if they aren't there
- apply query string parameters correctly to nested pages

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
fixes #6543

5 years agoShell lifecycle (#6527)
Shane Neuville [Wed, 3 Jul 2019 23:53:45 +0000 (17:53 -0600)]
Shell lifecycle (#6527)

* shell appearing and disappearing events

* life cycle UI tests and fixes

* - fix appearing on shell content to only fire when page gets created
- fix navigated to only fire after shell content is appearing

* OnNavigatedOnlyFiresOnce
fixes #6486

5 years agoUnhook Page from embedded Application on disposal (#6735)
E.Z. Hart [Wed, 3 Jul 2019 23:46:47 +0000 (17:46 -0600)]
Unhook Page from embedded Application on disposal (#6735)

* Unhook Page from embedded Application on disposal

* Update Xamarin.Forms.Core/Application.cs

fixes #4671