Viktor Hofer [Thu, 25 Jul 2019 02:03:09 +0000 (04:03 +0200)]
Enable xunit2007 analyzer (dotnet/corefx#39740)
Commit migrated from https://github.com/dotnet/corefx/commit/
619f140e2f0e722a17f3797d532b21ace774ec2e
Stephen Toub [Thu, 25 Jul 2019 01:58:45 +0000 (21:58 -0400)]
Re-enable xUnit2008 (Assert.True with regex) (dotnet/corefx#39739)
Commit migrated from https://github.com/dotnet/corefx/commit/
e091ee920b211b28a9d8a7928ca3b15294789d82
Stephen Toub [Thu, 25 Jul 2019 00:46:54 +0000 (20:46 -0400)]
Re-enable xUnit1016 (public MemberDatas) (dotnet/corefx#39738)
Commit migrated from https://github.com/dotnet/corefx/commit/
306fe9d60cc6db02a69d8ea6b88dde2b98fe8a7c
Anirudh Agnihotry [Thu, 25 Jul 2019 00:46:40 +0000 (17:46 -0700)]
Only removing logs which throw invalid parameters exception from eventLogs (dotnet/corefx#39705)
* only removing logs which throw invalid parametert exception from eventlogs
* using ordinalIgnoreCase, const name and improving comment
Commit migrated from https://github.com/dotnet/corefx/commit/
70aeda2b5b7110ead0ea69dc83f3f47e5728db06
Anirudh Agnihotry [Thu, 25 Jul 2019 00:45:38 +0000 (17:45 -0700)]
parameter name corrected (dotnet/corefx#39744)
Commit migrated from https://github.com/dotnet/corefx/commit/
32d791286263d58e84a587b4a8be0d7d1e667f05
William Godbe [Wed, 24 Jul 2019 23:22:54 +0000 (16:22 -0700)]
Mark System.Numerics.Tensors package as nonshipping (dotnet/corefx#39743)
* Mark System.Numerics.Tensors package as nonshipping
* Consolidate ItemGroup definition
Commit migrated from https://github.com/dotnet/corefx/commit/
a5026415f84efec9c4a51efb6a654be1c4a86070
Stephen Toub [Wed, 24 Jul 2019 17:14:01 +0000 (13:14 -0400)]
Re-emable CA1507 (use nameof) (dotnet/corefx#39731)
Commit migrated from https://github.com/dotnet/corefx/commit/
c265373119bc0449d347862862b43de35a95b186
Viktor Hofer [Wed, 24 Jul 2019 16:20:57 +0000 (18:20 +0200)]
Enable xunit2012 analyzer (dotnet/corefx#39730)
Commit migrated from https://github.com/dotnet/corefx/commit/
722ab9b7303ef14db74a1d09d464d180f18f512b
Stephen Toub [Wed, 24 Jul 2019 14:50:31 +0000 (10:50 -0400)]
Add comment descriptions to remaining xunit analyzer suppressions (dotnet/corefx#39725)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1dae31100118f358ac8bf8707a9017c17576356
Stephen Toub [Wed, 24 Jul 2019 14:42:39 +0000 (10:42 -0400)]
Re-enable CA1825 (zero-length array allocations) (dotnet/corefx#39708)
Commit migrated from https://github.com/dotnet/corefx/commit/
d0fc0a2b193d11645acc0fe72bbf1b97678a5161
Stephen Toub [Wed, 24 Jul 2019 11:33:20 +0000 (07:33 -0400)]
Re-enable CA2200 (rethrowing exceptions in catch blocks) (dotnet/corefx#39700)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b142543ce066ba684303837c2e9723b9e140d39
Viktor Hofer [Wed, 24 Jul 2019 11:25:58 +0000 (13:25 +0200)]
Enable xunit2015 analyzer (dotnet/corefx#39714)
Commit migrated from https://github.com/dotnet/corefx/commit/
a7fa4b58be0b266d8fe680de34f9b1a3dab8523a
Geoff Kizer [Wed, 24 Jul 2019 09:28:18 +0000 (02:28 -0700)]
Merge pull request dotnet/corefx#39638 from geoffkizer/streamshutdownfixes4
HTTP2: Rework shutdown handling
Commit migrated from https://github.com/dotnet/corefx/commit/
ca3fe6738ae6afc56e1f8fb5477a57a8dc2e183c
Geoff Kizer [Wed, 24 Jul 2019 07:47:35 +0000 (00:47 -0700)]
address review feedback and fix test issue
Commit migrated from https://github.com/dotnet/corefx/commit/
d6e6f52c928f56b424b08fcf6e08ea84a74748ab
Stephen Toub [Wed, 24 Jul 2019 07:45:28 +0000 (03:45 -0400)]
Re-enable CA1401 (public P/Invoke methods) (dotnet/corefx#39710)
Commit migrated from https://github.com/dotnet/corefx/commit/
28e0be5f236b57027b66395fcef87d3c58e31424
Stephen Toub [Wed, 24 Jul 2019 07:44:54 +0000 (03:44 -0400)]
Re-enable CA2008 (tasks without a TaskScheduler) (dotnet/corefx#39707)
Commit migrated from https://github.com/dotnet/corefx/commit/
9958740c24865cad40dd84bcd8c416cea927e3cc
Stephen Toub [Wed, 24 Jul 2019 07:42:36 +0000 (03:42 -0400)]
Re-enable CA1821 (remove empty finalizers) (dotnet/corefx#39709)
Commit migrated from https://github.com/dotnet/corefx/commit/
4cdbbd9430a3e080eb0926f612c89ffe74ed6e7e
Ahson Khan [Wed, 24 Jul 2019 06:28:07 +0000 (23:28 -0700)]
Update dummy fields within the ref by auto-generating them from the source assembly. (dotnet/corefx#39687)
* Update dummy fields within the ref by auto-generating them from the
source assembly.
* Address feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
c50b758727a041aec2dc959ee5ca2df5614a3c16
Stephen Toub [Wed, 24 Jul 2019 03:10:17 +0000 (23:10 -0400)]
Upgrade Roslyn analyzers (dotnet/corefx#39703)
* Upgrade analyzer versions
We were years behind.
* Fix nameof warnings in System.ComponentModel.Annotations
* Disable all rules with failures
* Enable CA2007 (ConfigureAwait)
* Enable CA5373, 5379, 5384, and 5385 (weak crypto)
* Remove stale nuget analyzer packages consumed into main package
* Enable CA2002
Commit migrated from https://github.com/dotnet/corefx/commit/
0f1fa092672a344b92c4bc440f3ab6232614a7f4
Santiago Fernandez Madero [Fri, 19 Jul 2019 22:48:01 +0000 (15:48 -0700)]
Update package testing to test for 5.0 and use the SDK targeting pack for 3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
e733500d11ae73f5ddba17b75127f1b3033c470c
Stephen Toub [Tue, 23 Jul 2019 21:05:15 +0000 (17:05 -0400)]
Re-enable xunit warning 2004 (dotnet/corefx#39698)
* Replace "Assert.Equal(true, " with "Assert.True("
* Replace "Assert.Equal(false, " with "Assert.False("
And fix a few Assert.Equal(true cases that deal with objects and thus need to be reverted.
* Replace "Assert.StrictEqual(true, " with "Assert.True("
* Revert a few changes where true/false was being compared to object
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
1296bc8386a7283e319ddf723282f16651f9ea5f
Geoff Kizer [Tue, 23 Jul 2019 20:18:56 +0000 (13:18 -0700)]
fix race in request body completion
Commit migrated from https://github.com/dotnet/corefx/commit/
29328b71b65abe3a199f0daf62f6ee71ca916e78
Geoff Kizer [Tue, 23 Jul 2019 08:10:16 +0000 (01:10 -0700)]
fix race with _requestBodyCancellationSource creation
Commit migrated from https://github.com/dotnet/corefx/commit/
7394185c0fc8a52bebf384b933b07c1eb1fba360
Geoff Kizer [Tue, 23 Jul 2019 05:15:05 +0000 (22:15 -0700)]
rework SendHeadersAsync to address various issues
Commit migrated from https://github.com/dotnet/corefx/commit/
2d5a9555d4888c82c653a9d7ad8368bc94adfdf2
Geoff Kizer [Tue, 23 Jul 2019 03:25:59 +0000 (20:25 -0700)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
752c1c8d8a01d22d52b1a320f9ed082049494045
Geoff Kizer [Sat, 20 Jul 2019 17:02:45 +0000 (10:02 -0700)]
combine into single Cancel method on stream, and ensure Dispose cancels properly when response is not read to end
Commit migrated from https://github.com/dotnet/corefx/commit/
5973d1ee6f3b616d2af2bc80527bdf8fe76ee210
Geoff Kizer [Fri, 12 Jul 2019 11:41:05 +0000 (04:41 -0700)]
rework shutdown handling
Commit migrated from https://github.com/dotnet/corefx/commit/
0cd73b77e1f31d48037b56deb0206f4e56b4232e
Stephen Toub [Tue, 23 Jul 2019 19:49:33 +0000 (15:49 -0400)]
Re-enable xunit warning 2003 (dotnet/corefx#39696)
* Replace "Assert.Equal(null, " with "Assert.Null("
* Replace "Assert.NotEqual(null, " with "Assert.NotNull("
* Replace "Assert.Same(null, " with "Assert.Null("
* Replace "Assert.StrictEqual(null, " with "Assert.Null("
Commit migrated from https://github.com/dotnet/corefx/commit/
6de660a02e335eefebfcc3c81ecb0013e2a8148e
Eirik Tsarpalis [Tue, 23 Jul 2019 17:43:46 +0000 (18:43 +0100)]
Merge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore
Add .dockerignore file to the root of the repo
Commit migrated from https://github.com/dotnet/corefx/commit/
e6a5951fb68a09598f1fc1826a94de212385c649
Egor Bogatov [Tue, 23 Jul 2019 14:25:37 +0000 (17:25 +0300)]
Make AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)
Commit migrated from https://github.com/dotnet/corefx/commit/
794bde4b8eb26047b6495af09a428e03e81e7e81
Stephen Toub [Tue, 23 Jul 2019 13:09:51 +0000 (09:09 -0400)]
Disable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet/corefx#39692)
Commit migrated from https://github.com/dotnet/corefx/commit/
687f36489c19072cd5a19d48c099f53bbc871c4d
Stephen Toub [Tue, 23 Jul 2019 06:39:47 +0000 (02:39 -0400)]
Re-enable xunit warning 1006 (dotnet/corefx#39685)
Regex search and replace for [InlineData()] with [Theory].
Commit migrated from https://github.com/dotnet/corefx/commit/
b58a866ba8709d66eed52bb8ecb13966b7436a1d
Stephen Toub [Mon, 22 Jul 2019 20:56:01 +0000 (16:56 -0400)]
Re-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)
* Re-enable all DisableXUnitAnalyzer test projects
* Remove TODO comment
Commit migrated from https://github.com/dotnet/corefx/commit/
16f3eef83d6df4c9dbc0e2992dafbc9553db363d
Stephen Toub [Mon, 22 Jul 2019 20:45:03 +0000 (16:45 -0400)]
Re-enable ~20 xunit analyzers (dotnet/corefx#39671)
* Re-enable ~20 xunit analyzers
All but one of these had no associated warnings firing. I fixed one warning to be able to re-enable another analyzer.
* Fix netfx build failures
Commit migrated from https://github.com/dotnet/corefx/commit/
c60b8172cfcd1e7f0d8104872f279781fd288b68
buyaa-n [Mon, 22 Jul 2019 18:43:03 +0000 (11:43 -0700)]
Custom converter contravariant test coverage (dotnet/corefx#39558)
* Custom converter contravariant test coverage
Commit migrated from https://github.com/dotnet/corefx/commit/
27228368037aeaa27fc5220d7d12c0550a2ef9c3
Stephen Toub [Mon, 22 Jul 2019 18:06:56 +0000 (14:06 -0400)]
Update breaking changes doc with a few clarifications (dotnet/corefx#39665)
Commit migrated from https://github.com/dotnet/corefx/commit/
f25b89e05594b0e56e1bea7080c935908142e960
Stephen Toub [Mon, 22 Jul 2019 16:32:21 +0000 (12:32 -0400)]
Add missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)
Without these, we can end up with corrupt encoder/decoder state due to uninitialized fields.
Commit migrated from https://github.com/dotnet/corefx/commit/
3c3b9ceee6e1416db6f1ddbc1ab0d0ffb67c16fa
Stephen Toub [Mon, 22 Jul 2019 16:30:03 +0000 (12:30 -0400)]
Remove unnecessary empty try { } blocks (dotnet/corefx#39664)
Unnecessary in .NET Core code. I didn't modify additional instances in libraries that target netstandard/netfx.
Commit migrated from https://github.com/dotnet/corefx/commit/
ca795a928d210c78c6bbd3fa10eb35f4c093a5a4
Stephen Toub [Sun, 21 Jul 2019 01:45:58 +0000 (21:45 -0400)]
Disable DefaultPageSettings_Null_ReturnsExpected test (dotnet/corefx#39647)
Commit migrated from https://github.com/dotnet/corefx/commit/
9bb93a61365db848aaf914b5dfb8d6684df3335e
Hugh Bellamy [Sun, 21 Jul 2019 00:59:51 +0000 (01:59 +0100)]
Fix NullReferenceExceptions in IndentedTextWriter without writer (dotnet/corefx#39584)
Commit migrated from https://github.com/dotnet/corefx/commit/
52f0a9192d1fcf624252c79e1fe5aa057f1db719
Omair Majid [Sun, 21 Jul 2019 00:54:49 +0000 (20:54 -0400)]
Fix up cgroup2fs in Interop.MountPoints.FormatInfo (dotnet/corefx#39633)
`stat -fc %T /sys/fs/cgroup` calls this file system `cgroup2fs`
Add the cgroup2fs file system magic number. Available from:
- https://www.kernel.org/doc/Documentation/cgroup-v2.txt
- man 2 statfs
Move cgroup2fs next to cgroupfs in the drive type list, since it is also
DriveType.Ram.
Commit migrated from https://github.com/dotnet/corefx/commit/
11416bd48af2c695dde9ef0057659249be10f12d
Stephen Toub [Sun, 21 Jul 2019 00:47:17 +0000 (20:47 -0400)]
Pass CancellationToken from Http2Connection.SendHeadersAsync to StartWriteAsync (dotnet/corefx#39635)
Commit migrated from https://github.com/dotnet/corefx/commit/
9597dadcea747960aba304253370a17a2218208d
Stephen Toub [Sat, 20 Jul 2019 12:47:08 +0000 (08:47 -0400)]
Disable nullable warnings for netstandard and netfx (dotnet/corefx#39636)
Commit migrated from https://github.com/dotnet/corefx/commit/
e64cac6dcacf996f98f0b3f75fb7ad0c12f588f7
Edison Henrique Andreassy [Sat, 20 Jul 2019 04:04:33 +0000 (01:04 -0300)]
Port some methods of the VB Interaction module (dotnet/corefx#39574)
Commit migrated from https://github.com/dotnet/corefx/commit/
45851336efa3b754f427d00cef3d388357aed308
Stephen Toub [Sat, 20 Jul 2019 01:09:49 +0000 (21:09 -0400)]
Remove unnecessary use of volatile in PartitionerStatic (dotnet/corefx#39591)
`SharedInt`, which is just an object wrapper around a `volatile int` was being used even though a) the objects weren't actually being shared, and b) the stored `int` was sometimes being passed by `ref` and thus losing its voliatility in some cases anyway.
(It's not entirely clear why an object is being used, regardless, but from the comments it appears to be due to concerns around false sharing. Presumably cases were found where the enumerators were all allocated up-front resulting in these ints stored as part of the enumerator objects ending up on the same cache line, so they were moved to objects allocated on discrete threads during MoveNext to minimize that possibility.)
Commit migrated from https://github.com/dotnet/corefx/commit/
7f21952eed6c421d6854bcce3c0a8f76f2d5de9b
Justin Kotalik [Fri, 19 Jul 2019 19:53:12 +0000 (12:53 -0700)]
Don't dispose StreamPipeWriter CancellationToken until after Flush (dotnet/corefx#39610) (dotnet/corefx#39620)
Commit migrated from https://github.com/dotnet/corefx/commit/
7431e4938c461f6e24cf3122c0b9ca4eb27e4dde
Stephen Toub [Fri, 19 Jul 2019 14:08:42 +0000 (10:08 -0400)]
Re-enable unicode host name test (dotnet/corefx#39606)
Site appears to be back up.
Commit migrated from https://github.com/dotnet/corefx/commit/
1303d28179b4369cbfac43affd723fa6e0bc9554
Stephen Toub [Fri, 19 Jul 2019 14:07:15 +0000 (10:07 -0400)]
Avoid "async void" tests (dotnet/corefx#39613)
Most of these are just because "async void" tests are rare and require special handling in xunit we needn't use. But a few of these are plain wrong and were resulting in our not actually testing what we hoped to test.
Commit migrated from https://github.com/dotnet/corefx/commit/
50d8c71bb6139f3c06dd820d6d757a095a9fe994
Viktor Hofer [Fri, 19 Jul 2019 13:43:31 +0000 (15:43 +0200)]
Add telemetry marker for tests (dotnet/corefx#39619)
Commit migrated from https://github.com/dotnet/corefx/commit/
cce2f2e92b75a42d07da123e091ac96fb47f44c5
Cheena Malhotra [Thu, 18 Jul 2019 22:45:54 +0000 (15:45 -0700)]
Fix in System.Data.Common namespace, use correct WriteAttributeString API (dotnet/corefx#39543)
Commit migrated from https://github.com/dotnet/corefx/commit/
182bed51dec709b3b1b56a4f435e0727e5dea110
Stephen Toub [Thu, 18 Jul 2019 18:23:46 +0000 (14:23 -0400)]
Remove dead ifdef'd code from Microsoft.CSharp/VisualBasic (dotnet/corefx#39587)
Commit migrated from https://github.com/dotnet/corefx/commit/
9c2682f5899f280e3ca2e52569f84eaecb255647
Stephen Toub [Thu, 18 Jul 2019 18:21:49 +0000 (14:21 -0400)]
Move ConnectAsync_AddCustomHeaders_Success ClientWebSocket test to loopback (dotnet/corefx#39589)
Commit migrated from https://github.com/dotnet/corefx/commit/
83954bb1404c5bdfb56130c5a4994e5e05403beb
Stephen Toub [Thu, 18 Jul 2019 18:21:08 +0000 (14:21 -0400)]
Fix ordering of visibility and abstract/virtual/override (dotnet/corefx#39590)
To conform to expected style across corefx.
Commit migrated from https://github.com/dotnet/corefx/commit/
b95ad3c0f9066fa426754bd6e3379fbaca24834e
dotnet-maestro[bot] [Thu, 18 Jul 2019 18:20:31 +0000 (11:20 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#39567)
* Update dependencies from https://github.com/dotnet/coreclr build
20190716.2
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19366.2
* Ignore System.Private.Corelib in netcoreapp3.0 package testing
Commit migrated from https://github.com/dotnet/corefx/commit/
167bb417724b2338df492b417bdfea89d458e473
buyaa-n [Thu, 18 Jul 2019 17:59:35 +0000 (10:59 -0700)]
Code coverage for JsonWriterHelper JsonWriter (dotnet/corefx#39407)
* Code coverage for JsonWriterHelper JsonWriter
* Applying feedback
* Some updates was not saved for previous commit
* Remove not needed row, formatting
* Removing tests not needed anymore
* Applying feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
4cbad86c4e6aeaa135b9a569dbde9151180c40f5
Koundinya Veluri [Thu, 18 Jul 2019 17:48:31 +0000 (10:48 -0700)]
Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test (dotnet/corefx#39050)
Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test
- There are a large number of tests in CoreCLR with a lot of redundancy, timing issues, and which take unnecessarily long to run
- Folded a bunch of them into the existing parameterized test and improved it to cover more cases to replace the tests in CoreCLR that will be removed
- Coverage is not 100% equivalent, but I belive this sufficiently covers the necessary aspects of the tests in CoreCLR that will be removed
Commit migrated from https://github.com/dotnet/corefx/commit/
fa722debec4c18a444a207171b686e40d7c0fc1a
Santiago Fernandez Madero [Thu, 18 Jul 2019 03:07:03 +0000 (20:07 -0700)]
Make all events nullable (dotnet/corefx#39578)
Commit migrated from https://github.com/dotnet/corefx/commit/
ba2d62a24ea8574f40c43cd27cc384f079958a0c
Stephen Toub [Wed, 17 Jul 2019 21:53:30 +0000 (17:53 -0400)]
Change HttpStress app to highlight in red unchanged totals (dotnet/corefx#39576)
When no additional operations have completed since the last time status was output, highlight that in red.
Commit migrated from https://github.com/dotnet/corefx/commit/
53dc908890102d3a888ba603a06266b85d3f4a9b
David Cantu [Wed, 17 Jul 2019 20:39:10 +0000 (13:39 -0700)]
Include file SafeHandleTest.cs into the project. (dotnet/corefx#39573)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a29c851b33d904b5706e90c4f5309f2f8f1fece
Günther Foidl [Wed, 17 Jul 2019 18:06:17 +0000 (20:06 +0200)]
Spanify Cryptography.Base64Transform
So it can be non-allocating byte[] -> byte[], instead of allocating (temp. buffer) and copying with byte[] -> char[] -> byte[].
Commit migrated from https://github.com/dotnet/corefx/commit/
d4a935c526f5f84d6136066bd554f619ed0b7476
Filip Navara [Wed, 17 Jul 2019 18:05:00 +0000 (20:05 +0200)]
Move ASN.1 decoding/encoding out of PkcsPal
Both the Windows version and the AnyOS version will use the managed ASN.1/BER/DER code via PkcsHelpers.
Commit migrated from https://github.com/dotnet/corefx/commit/
ccad56758140def8084943e5a8f2acabbf81d454
Tom Deseyn [Wed, 17 Jul 2019 15:48:33 +0000 (17:48 +0200)]
Socket: improve cross-platform behavior on Dispose (dotnet/corefx#38804)
* Add tests
* Don't skip SyncSendFileGetsCanceledByDispose on .NET Framework
* Implement using code from previous PR
* Update SocketErrors when CleanedUp for APM APIs
* Cleanup SO_TYPE socket length handling (Fixes https://github.com/dotnet/corefx/issues/38750)
* SyncSendFileGetsCanceledByDispose: remove SkipTargetFramework NetFramework
* PR feedback
* Fix comment typo
* Also wait for async operations, and wait longer on each retry
* clear sockaddr using memset
* Fix build
* Only perform CLOEXEC check for non-abortive close
Commit migrated from https://github.com/dotnet/corefx/commit/
9b2f7a834691a3bbad2949181eec707dd4b5a13b
v-jizho2 [Wed, 17 Jul 2019 03:37:31 +0000 (20:37 -0700)]
Increase connect timeout for Functional Tests (dotnet/corefx#39559)
Commit migrated from https://github.com/dotnet/corefx/commit/
da3d086edde315db03ff9b04c2926ab22940d50c
Stephen Toub [Tue, 16 Jul 2019 23:31:47 +0000 (19:31 -0400)]
Enable HttpStress to target http.sys in addition to Kestrel (dotnet/corefx#39553)
Commit migrated from https://github.com/dotnet/corefx/commit/
d34317fbfb4963e7d42b96c36c314e2af829c3c7
Ahson Khan [Tue, 16 Jul 2019 23:18:22 +0000 (16:18 -0700)]
Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder. (dotnet/corefx#39550)
* Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder.
* Remove duplicate test case and fix test name.
* Fix formatting nits and move the new class to a separate file.
* No need to special case single quote, and fix more formatting.
* Update the remarks section to call out the difference between Default
and Relaxed.
Commit migrated from https://github.com/dotnet/corefx/commit/
30ece647dae7d9ddff8a24cdd615119fde259927
William Godbe [Tue, 16 Jul 2019 22:47:57 +0000 (15:47 -0700)]
Update branding in master to 5.0 (dotnet/corefx#39503)
* Update branding in master to 5.0
* Revert to old AssemblyVersions
* Update to correct package versions
* Update Prerelease to alpha1
* Remove redundant PackageVersions
* Disable index check
* Update packageIndex
* Update PackageIndex again
* Revert incorrect packageIndex versions
Commit migrated from https://github.com/dotnet/corefx/commit/
1acaa2017cfc64ef1aabcf3b19d0e097af692616
Geoff Kizer [Tue, 16 Jul 2019 22:09:58 +0000 (15:09 -0700)]
Merge pull request dotnet/corefx#39343 from geoffkizer/enableremotetestsforhttp2
ensure remote server HTTP2 tests are actually using HTTP2
Commit migrated from https://github.com/dotnet/corefx/commit/
6ec67c15c3f213206e9cf66a2d69d274d3836e6b
Layomi Akinrinade [Tue, 16 Jul 2019 21:48:53 +0000 (17:48 -0400)]
Clean up date helper (dotnet/corefx#39548)
Commit migrated from https://github.com/dotnet/corefx/commit/
9711b084829db7b8f69b3d3eb9effa3d2bdc0699
Santiago Fernandez Madero [Tue, 16 Jul 2019 21:15:10 +0000 (14:15 -0700)]
Fix Utf8JsonWriter xml docs (dotnet/corefx#39092)
* Fix Utf8JsonWriter xml docs
* PR Feedback
* PR Feedback
* PR Feedback put back remarks for ROS/string overrides
* Remove duplicate remarks
* PR Feedback
* PR Feedback, i.e. -> that is
Commit migrated from https://github.com/dotnet/corefx/commit/
7b90f41828abea1d9db6d55403a849c2613d996d
Martin Björkström [Tue, 16 Jul 2019 21:01:13 +0000 (00:01 +0300)]
Specify DateTimeKind.Utc in JSON tests to avoid ArgumentOutOfRangeException (dotnet/corefx#39547)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cd505d9aaabe656707766dee22e9aec0404568f
Geoff Kizer [Tue, 16 Jul 2019 19:16:58 +0000 (12:16 -0700)]
disable two slow tests that time out in CI
Commit migrated from https://github.com/dotnet/corefx/commit/
3bf02562f062bdf0faf787f7cfe1d67539363ed5
Layomi Akinrinade [Tue, 16 Jul 2019 18:59:27 +0000 (14:59 -0400)]
Fix datetime bug (dotnet/corefx#39541)
Commit migrated from https://github.com/dotnet/corefx/commit/
05c0f516cf20cd6ae108ba034984b0cdc740732e
Ahson Khan [Tue, 16 Jul 2019 18:56:21 +0000 (11:56 -0700)]
Do not over-escape writing Base64 strings within JSON using the writer. (dotnet/corefx#39522)
Commit migrated from https://github.com/dotnet/corefx/commit/
063e38c7bc66e076fdcc7521e4c69650baae9427
Omair Majid [Tue, 16 Jul 2019 18:44:51 +0000 (14:44 -0400)]
Add arm64 runtime ids for Fedora and RHEL 8
Both Fedora and RHEL 8 have arm64 (aka aarch64) among the primary/main
architectures they support.
Fedora includes aarch64 as a "Primary Architecture":
https://fedoraproject.org/wiki/Architectures#Primary_Architectures
RHEL 8 lists aarch64 right next to x86_64 in the developer download site:
https://developers.redhat.com/products/rhel/download
Commit migrated from https://github.com/dotnet/corefx/commit/
ec18a81e92f531343ea754d355c6d2665d36c2ef
David Fowler [Tue, 16 Jul 2019 17:35:33 +0000 (10:35 -0700)]
Change callbacks to virtual from being abstract (dotnet/corefx#39526)
- Obsolete the callbacks as well
Commit migrated from https://github.com/dotnet/corefx/commit/
51cd78434953683040f93e69ed2a889e476f5cac
Stephen Toub [Tue, 16 Jul 2019 17:04:40 +0000 (13:04 -0400)]
Fix HttpStress GET Parameters operation to respect Kestrel max line length (dotnet/corefx#39535)
* Fix HttpStress GET Parameters operation to respect Kestrel max line length
* Address PR feedback
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
bb0516a4f8d0c4d84eff2ba2a3ad0a4764ece9d2
Jeremy Barton [Tue, 16 Jul 2019 16:49:08 +0000 (09:49 -0700)]
Add negative tests for ValidateNumber
With this change ValidateNumber gets to 100% block coverage.
Commit migrated from https://github.com/dotnet/corefx/commit/
7fe5f15813aedc2144b348baa2f26e7289618a05
Steve Harter [Tue, 16 Jul 2019 16:29:20 +0000 (09:29 -0700)]
Add Encoder option to writer and serializer (dotnet/corefx#39524)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc10b53838bc84ac2b626e16eee1338183ee55c8
Stephen Toub [Tue, 16 Jul 2019 15:10:12 +0000 (11:10 -0400)]
Remove a few unnecessary !s (dotnet/corefx#39531)
Commit migrated from https://github.com/dotnet/corefx/commit/
2b6f38911bb45548c8d1db015526518276e6c888
Eirik Tsarpalis [Tue, 16 Jul 2019 14:58:47 +0000 (15:58 +0100)]
Merge pull request dotnet/corefx#39485 from eiriktsarpalis/httpstress-randomize-cancellation
HttpStress: Randomize cancellation of requests
Commit migrated from https://github.com/dotnet/corefx/commit/
e15d8dcb334ebd896cd2b23359d95c2ca679fdd9
Levi Broderick [Tue, 16 Jul 2019 14:35:32 +0000 (07:35 -0700)]
JavaScriptEncoder should allow U+002F SOLIDUS by default (dotnet/corefx#39494)
Commit migrated from https://github.com/dotnet/corefx/commit/
1b2b8e1262da221bf7c83c01b14df00618d5e4f1
Eirik Tsarpalis [Tue, 16 Jul 2019 14:02:44 +0000 (15:02 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
ac239fc682f296c7eeb953f9ee26dd8a0351b6e4
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:34 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
6b2ddf6b59d62ea0a6720b731678f61fbbae7634
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:22 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
35dec8a0cd2850ab9e0d5a97cfac4f458a3550a9
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:12 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
ae4dc79e57514eb9dfe4a8c0480691bd80731969
Eirik Tsarpalis [Tue, 16 Jul 2019 13:58:32 +0000 (14:58 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
bee6f7fa2f76f5793a89027132b3ece7af82e30c
Layomi Akinrinade [Tue, 16 Jul 2019 12:53:06 +0000 (08:53 -0400)]
Add support for immutable array (dotnet/corefx#39493)
* Add support for ImmutableArray
* Refactor immutable materializer strategies to use creator helper
* Clean up + re-add tests
* Check for immutable array
* Correct immutable array check
* Fix whitespace
Commit migrated from https://github.com/dotnet/corefx/commit/
2811879c01bf6f3b95aa4ee9b8994cfb62038610
Stephen Toub [Tue, 16 Jul 2019 11:07:22 +0000 (07:07 -0400)]
Propagate abort exceptions from CreditManager.Dispose (dotnet/corefx#39520)
Currently, if an abort occurs, it disposes of credit managers, and if there's a waiter on that credit manager, that waiter propagates an ObjectDisposedException. It should instead propagate whatever exception resulted from the abort.
Commit migrated from https://github.com/dotnet/corefx/commit/
3c71b23c676c3538b33f4ae653cf6f85de77e44d
Eirik Tsarpalis [Tue, 16 Jul 2019 08:47:43 +0000 (09:47 +0100)]
remove unused cli param
Commit migrated from https://github.com/dotnet/corefx/commit/
7e595109699e301f31e3ffd3dda4aca9755c5c8a
Dan Moseley [Tue, 16 Jul 2019 06:57:31 +0000 (23:57 -0700)]
More Win7 EventLog retries (dotnet/corefx#39521)
Commit migrated from https://github.com/dotnet/corefx/commit/
4b348cc28f0ec996322d4d1a62cfae300f77604e
Jeremy Kuhne [Tue, 16 Jul 2019 04:21:10 +0000 (21:21 -0700)]
Remove hooking of system color changes (dotnet/corefx#39468)
* Remove hooking of system color changes
Hooking user preference changes to update system colors is expensive, particularly as it is hooked via reflection. Getting the current color from the OS is extremely cheap. Removing this layer of caching avoids creating a watcher window and thread and a significant number of startup allocations.
In starting up a blank WinForms app this cuts 200 allocations.
Note that Pens and Brushes in System.Drawing start their own user preference watcher so that they can update GDI+ when backed by system colors.
* Address feedback
* Remove newly dead files
Commit migrated from https://github.com/dotnet/corefx/commit/
97c736e09f2e119d6ec3d3ebebb7234dee48145d
Dan Moseley [Tue, 16 Jul 2019 02:00:50 +0000 (19:00 -0700)]
Add Win7 retries around Count (dotnet/corefx#39517)
Commit migrated from https://github.com/dotnet/corefx/commit/
8973a72af9e3a2837d18e73041e2c8090d6871d1
Maryam Ariyan [Tue, 16 Jul 2019 00:23:05 +0000 (17:23 -0700)]
Update README.md
Commit migrated from https://github.com/dotnet/corefx/commit/
efee78fd498620fccd49810e63e0a1236083b6d3
Maryam Ariyan [Tue, 16 Jul 2019 00:18:28 +0000 (17:18 -0700)]
Adding readme for MEF (dotnet/corefx#39506)
Commit migrated from https://github.com/dotnet/corefx/commit/
3b26bd7e11d7b1fdc8162c6ce753074935ef9f10
Stephen Toub [Tue, 16 Jul 2019 00:14:02 +0000 (20:14 -0400)]
Remove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504)
The ctor is already `protected`, so it can already be accessed by any derived type. The only benefit adding `internal` would provide is so that it could be called directly by something else in the assembly, but the type is `abstract`, so that doesn't make sense for a ctor.
Commit migrated from https://github.com/dotnet/corefx/commit/
902294e7933e84601aa4543fc3afe0dcf85c2d99
Krzysztof Wicher [Tue, 16 Jul 2019 00:00:19 +0000 (17:00 -0700)]
Request-in-flight GOAWAY test (dotnet/corefx#39501)
* request-in-flight GOAWAY test
* apply feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3eabd4c7f1cc439233e0f8bae3ba37a8d73b7e8d
Stephen Toub [Mon, 15 Jul 2019 23:32:58 +0000 (19:32 -0400)]
Add a retry to an EventLog test on Win7 (dotnet/corefx#39508)
Commit migrated from https://github.com/dotnet/corefx/commit/
c953201a9918a5b699e6d23cd48c863975b9b14e
Eirik Tsarpalis [Mon, 15 Jul 2019 22:38:16 +0000 (23:38 +0100)]
force cancellations to only trigger after request has been sent
Commit migrated from https://github.com/dotnet/corefx/commit/
524af177fd3e39de47dae3394b516f8a02a6446d
Eirik Tsarpalis [Mon, 15 Jul 2019 18:36:01 +0000 (19:36 +0100)]
dispose CancellationTokenSources
Commit migrated from https://github.com/dotnet/corefx/commit/
58c85e29cfaa4b6bd8002a5c90c5262ca0cb29cf
Eirik Tsarpalis [Mon, 15 Jul 2019 16:40:50 +0000 (17:40 +0100)]
HttpStress: Randomize cancellation of requests
Commit migrated from https://github.com/dotnet/corefx/commit/
c4167ed11e1444433a33cc5d44a4aa33e0ffd651