Denis Kenzior [Mon, 5 Apr 2010 21:14:39 +0000 (16:14 -0500)]
Refactor: Move packet_ops to a static look-up
No need to allocate space for this, as it is always the same for all
instances.
Denis Kenzior [Mon, 5 Apr 2010 19:32:11 +0000 (14:32 -0500)]
Refactor: Make option_scan more type safe
Denis Kenzior [Mon, 5 Apr 2010 19:25:14 +0000 (14:25 -0500)]
Refactor: Make option_process more typesafe
option_process was declared with two gpointer arguments for the sole
reason of being used as a GFunc. Casting to a GFunc or re-writing the
foreach as a loop is preferable.
Denis Kenzior [Mon, 5 Apr 2010 19:16:00 +0000 (14:16 -0500)]
Refactor: Add pppcp_set_data & pppcp_get_data
Using these functions makes the code much cleaner than trying to pass
the priv pointer everywhere
Marcel Holtmann [Mon, 5 Apr 2010 18:12:43 +0000 (11:12 -0700)]
Make pppcp_code enum a private structure
Marcel Holtmann [Mon, 5 Apr 2010 18:05:08 +0000 (11:05 -0700)]
Make pppcp_event_type enum a private structure
Denis Kenzior [Mon, 5 Apr 2010 17:36:43 +0000 (12:36 -0500)]
Refactor: Move to a transition state table
It is much more compact to re-implement the transition states as a table
as opposed to functions with switch/case statements. The logic is made
much easier to follow and much of the code duplication is eliminated
Denis Kenzior [Mon, 5 Apr 2010 15:13:10 +0000 (10:13 -0500)]
Refactor: Make the enum assignments explicit
They will be used for certain magic later on
Denis Kenzior [Mon, 5 Apr 2010 15:11:31 +0000 (10:11 -0500)]
Refactor: Move the state definition to ppp_cp.c
Kristen Carlson Accardi [Sat, 3 Apr 2010 05:27:00 +0000 (22:27 -0700)]
ppp: implement Max-Failure counter
put a cap on the number of Configure-Nak packets we send.
Marcel Holtmann [Sun, 4 Apr 2010 05:32:27 +0000 (22:32 -0700)]
Move PPP constants where they are used
Marcel Holtmann [Sun, 4 Apr 2010 05:25:09 +0000 (22:25 -0700)]
Make GAtPPP fields really private
Marcel Holtmann [Sat, 3 Apr 2010 04:51:19 +0000 (21:51 -0700)]
Hide internals of ring buffer structure
Marcel Holtmann [Sat, 3 Apr 2010 03:34:25 +0000 (20:34 -0700)]
Remove circular inclusion protection from ring buffer header
Marcel Holtmann [Sat, 3 Apr 2010 02:20:53 +0000 (19:20 -0700)]
Fix some cases where g_try_new should be used
Marcel Holtmann [Sat, 3 Apr 2010 02:06:31 +0000 (19:06 -0700)]
Move frame NULL checks into the unstuffing function
Marcel Holtmann [Sat, 3 Apr 2010 02:01:38 +0000 (19:01 -0700)]
Fix coding style with callback structures
Kristen Carlson Accardi [Fri, 2 Apr 2010 23:45:24 +0000 (16:45 -0700)]
ppp: implement net close
Denis Kenzior [Fri, 2 Apr 2010 20:22:23 +0000 (15:22 -0500)]
Refactor: Get rid of (now) pointless comments
Marcel Holtmann [Fri, 2 Apr 2010 20:48:44 +0000 (13:48 -0700)]
Also the default case should have a break statement
Denis Kenzior [Fri, 2 Apr 2010 20:13:25 +0000 (15:13 -0500)]
Remove the PPP option from gsmdial
Pointless since we should always connect using PPP
Denis Kenzior [Fri, 2 Apr 2010 20:10:29 +0000 (15:10 -0500)]
Refactor: Get rid of packet handler registrations
There are only about 4 protocols that the current ppp code handles and
it is doubtful that it will grow much more. There's no point in having
an extensive packet handler registration framework.
Marcel Holtmann [Fri, 2 Apr 2010 20:34:10 +0000 (13:34 -0700)]
Fix tabs vs. whitespace coding style violation
Marcel Holtmann [Fri, 2 Apr 2010 20:33:35 +0000 (13:33 -0700)]
Add more missing break statements
Kristen Carlson Accardi [Fri, 2 Apr 2010 20:16:35 +0000 (13:16 -0700)]
ppp: fix missing breaks in switch statements
Marcel Holtmann [Fri, 2 Apr 2010 19:40:45 +0000 (12:40 -0700)]
Add missing break or fall through comments to switch statements
Marcel Holtmann [Fri, 2 Apr 2010 18:43:20 +0000 (11:43 -0700)]
Always reset option_rval for every option
Marcel Holtmann [Fri, 2 Apr 2010 18:42:42 +0000 (11:42 -0700)]
Add missing arpa/inet.h includes
Kristen Carlson Accardi [Fri, 2 Apr 2010 18:13:20 +0000 (11:13 -0700)]
ppp: use queue to transmit
Since we are using non buffered I/O, use a queue to transmit when buffer
space is available.
Denis Kenzior [Fri, 2 Apr 2010 17:42:04 +0000 (12:42 -0500)]
Split out ipcp protocol into ppp_ipcp.c
Kristen Carlson Accardi [Fri, 2 Apr 2010 17:28:18 +0000 (10:28 -0700)]
ppp: fix event generation on close
Prevents too early transition to PPP_DEAD
Denis Kenzior [Fri, 2 Apr 2010 16:28:02 +0000 (11:28 -0500)]
Fix: Make the C-APDU logic more readable
Denis Kenzior [Fri, 2 Apr 2010 16:20:44 +0000 (11:20 -0500)]
Style: Multiline comments
Denis Kenzior [Fri, 2 Apr 2010 16:19:03 +0000 (11:19 -0500)]
Fix: Tweak the language parser
Denis Kenzior [Fri, 2 Apr 2010 16:11:53 +0000 (11:11 -0500)]
Fix: Remove erroneous comment
Denis Kenzior [Fri, 2 Apr 2010 16:11:13 +0000 (11:11 -0500)]
Fix: AT Commands are probably just text
Denis Kenzior [Fri, 2 Apr 2010 16:08:41 +0000 (11:08 -0500)]
Fix: Trivial indentation issues
Yang Gu [Fri, 2 Apr 2010 06:20:40 +0000 (14:20 +0800)]
Add parser for browser identity objects
Yang Gu [Fri, 2 Apr 2010 06:20:39 +0000 (14:20 +0800)]
Add parser for language objects
Yang Gu [Fri, 2 Apr 2010 06:20:38 +0000 (14:20 +0800)]
Add parser for dtmf string objects
Yang Gu [Fri, 2 Apr 2010 06:20:37 +0000 (14:20 +0800)]
Add parser for bc repeat indicator objects
Yang Gu [Fri, 2 Apr 2010 06:20:36 +0000 (14:20 +0800)]
Add parser for at response objects
Yang Gu [Fri, 2 Apr 2010 06:20:35 +0000 (14:20 +0800)]
Add parser for at command objects
Yang Gu [Fri, 2 Apr 2010 06:20:34 +0000 (14:20 +0800)]
Add parser for date-time and time zone objects
Yang Gu [Fri, 2 Apr 2010 06:20:33 +0000 (14:20 +0800)]
Make function decode_scts public
Yang Gu [Fri, 2 Apr 2010 06:20:32 +0000 (14:20 +0800)]
Add parser for timer value objects
Yang Gu [Fri, 2 Apr 2010 06:20:31 +0000 (14:20 +0800)]
Refactor: Break out semi-octet decoder
Refactor decode_scts to use this function
Yang Gu [Fri, 2 Apr 2010 06:20:30 +0000 (14:20 +0800)]
Add parser for timer identifier objects
Yang Gu [Fri, 2 Apr 2010 06:20:29 +0000 (14:20 +0800)]
Add parser for r-apdu objects
Yang Gu [Fri, 2 Apr 2010 06:20:28 +0000 (14:20 +0800)]
Add parser for c-apdu objects
Yang Gu [Fri, 2 Apr 2010 06:20:27 +0000 (14:20 +0800)]
Add parser for card atr objects
Yang Gu [Fri, 2 Apr 2010 06:20:26 +0000 (14:20 +0800)]
Add parser for card reader status objects
Denis Kenzior [Fri, 2 Apr 2010 14:17:34 +0000 (09:17 -0500)]
Fix: Regression in PIN validity checking
Marcel Holtmann [Fri, 2 Apr 2010 04:41:59 +0000 (21:41 -0700)]
Remove PPP CP event_queue handling and process events directly
Denis Kenzior [Fri, 2 Apr 2010 03:29:30 +0000 (22:29 -0500)]
Fix: Stop infinite attempts to register
Sometimes if the modem firmware is particularly nutty we will see
frequent cell-reselections at startup, resulting in us attempting to
register multiple times. Try to stop this behavior by keeping track of
what state we're in and hoping the hardware is at least somewhat sane.
Denis Kenzior [Fri, 2 Apr 2010 02:20:02 +0000 (21:20 -0500)]
Add support for Option iCon 452
Marcel Holtmann [Fri, 2 Apr 2010 03:40:39 +0000 (20:40 -0700)]
Remove obfuscation for some of the event handling
Marcel Holtmann [Fri, 2 Apr 2010 03:33:03 +0000 (20:33 -0700)]
Move functions from ppp.c into gatppp.c
Marcel Holtmann [Fri, 2 Apr 2010 03:26:24 +0000 (20:26 -0700)]
Remove PPP event_queue handling and process events directly
Marcel Holtmann [Fri, 2 Apr 2010 03:18:49 +0000 (20:18 -0700)]
Check FCS while unstuffing the byte stream
Marcel Holtmann [Fri, 2 Apr 2010 03:11:43 +0000 (20:11 -0700)]
Remove PPP recv_queue handling and process frames directly
Marcel Holtmann [Fri, 2 Apr 2010 03:06:31 +0000 (20:06 -0700)]
Remove usage of AT+CGACT for now
Marcel Holtmann [Thu, 1 Apr 2010 21:31:19 +0000 (14:31 -0700)]
Fix order of PPP frame recording and processing
Marcel Holtmann [Thu, 1 Apr 2010 20:47:25 +0000 (13:47 -0700)]
Add support for recording PPP sessions in pppdump format
Marcel Holtmann [Thu, 1 Apr 2010 20:11:11 +0000 (13:11 -0700)]
Implement g_at_ppp_set_debug support
Marcel Holtmann [Thu, 1 Apr 2010 16:56:18 +0000 (09:56 -0700)]
Add some debugging information to PPP authentication handling
Marcel Holtmann [Thu, 1 Apr 2010 16:13:44 +0000 (09:13 -0700)]
Remove useless pppcp_protocol_data structure
Marcel Holtmann [Thu, 1 Apr 2010 07:17:10 +0000 (00:17 -0700)]
Remove forward declarations in PPP network handling
Marcel Holtmann [Thu, 1 Apr 2010 07:07:40 +0000 (00:07 -0700)]
Add debugging for PPP LCP and IPCP options
Marcel Holtmann [Thu, 1 Apr 2010 05:29:43 +0000 (22:29 -0700)]
Use ppp%d as PPP interface name instead of tun%d
Denis Kenzior [Wed, 31 Mar 2010 23:49:39 +0000 (18:49 -0500)]
Initial implementation of the PPP gprs context
Denis Kenzior [Wed, 31 Mar 2010 23:48:52 +0000 (18:48 -0500)]
Fix: Introduce PPP data state
Some modems send PPP data introspersed along with the CONNECT final
response. Fixup the parser so we can still detect the final response.
Denis Kenzior [Wed, 31 Mar 2010 23:48:30 +0000 (18:48 -0500)]
Fix: Update gsm dial to the new GAtPPP API
Denis Kenzior [Wed, 31 Mar 2010 23:47:30 +0000 (18:47 -0500)]
Refactor: Use GAtDisconnectFunc for ppp disconnect
The ppp argument to the current disconnect callback is useless as the
ppp structure is most likely stored in user data anyway.
Denis Kenzior [Wed, 31 Mar 2010 23:45:17 +0000 (18:45 -0500)]
Refactor: GAtPPP connect callback
The connect callback was not giving enough information and the
information it was providing was not in a convenient form.
- Provide the ppp interface name (e.g. tun0)
- Provide ip, dns1 & dns2 as strings
- Do not send the ppp structure in the callback, it is most likely
present in the user data anyway
Denis Kenzior [Wed, 31 Mar 2010 23:36:21 +0000 (18:36 -0500)]
Update mbm to use two ports
The second port might be used for a second active context via ppp
Denis Kenzior [Wed, 31 Mar 2010 23:34:32 +0000 (18:34 -0500)]
Fix: MD300 uses two ACM ports, so set one to data
Denis Kenzior [Wed, 31 Mar 2010 19:11:41 +0000 (14:11 -0500)]
Style: Whitespace damage due to spaces, not tabs
Also use proper indentation style
Andrzej Zaborowski [Wed, 31 Mar 2010 04:57:07 +0000 (06:57 +0200)]
Refactor: Return a string from USSD Respond method
Return network's USSD reponses from the Respond method instead of
signaling over D-Bus. This should make the UI writer's job a little
easier.
Andrzej Zaborowski [Wed, 31 Mar 2010 04:57:33 +0000 (06:57 +0200)]
Fix ampersand commands check
Also remove a trailing tab.
Andrzej Zaborowski [Wed, 31 Mar 2010 04:57:21 +0000 (06:57 +0200)]
doc: Explain VoicemailMessageCount value zero.
Andrzej Zaborowski [Wed, 31 Mar 2010 04:56:57 +0000 (06:56 +0200)]
Use stkutil named constants in sim.c
Andrzej Zaborowski [Wed, 31 Mar 2010 04:56:45 +0000 (06:56 +0200)]
Update property name in test-ussd
Denis Kenzior [Wed, 31 Mar 2010 18:04:57 +0000 (13:04 -0500)]
Style: remove unneeded blank line
Marcel Holtmann [Wed, 31 Mar 2010 17:30:54 +0000 (10:30 -0700)]
Fix whitespace damage in PPP implementation
Denis Kenzior [Wed, 31 Mar 2010 17:22:57 +0000 (12:22 -0500)]
Fix: Be more consistent with other boundary checks
Denis Kenzior [Wed, 31 Mar 2010 17:20:02 +0000 (12:20 -0500)]
Style: indentation fixes
Yang Gu [Wed, 31 Mar 2010 09:17:03 +0000 (17:17 +0800)]
Fix: Increate iterator when parsing fails
If the comprehension TLV tag matches the expected handler, and the
handler fails to parse the tag, then increase the iterator.
Yang Gu [Wed, 31 Mar 2010 09:17:02 +0000 (17:17 +0800)]
Rename stk_icon_identifier to stk_icon_id
Yang Gu [Wed, 31 Mar 2010 09:17:01 +0000 (17:17 +0800)]
Add parser for item icon identifier list objects
Yang Gu [Wed, 31 Mar 2010 09:17:00 +0000 (17:17 +0800)]
Add enum for icon qualifier
Yang Gu [Wed, 31 Mar 2010 09:16:59 +0000 (17:16 +0800)]
Add parser for call control requested action objects
Yang Gu [Wed, 31 Mar 2010 09:16:58 +0000 (17:16 +0800)]
Add parser for transaction identifier objects
Yang Gu [Wed, 31 Mar 2010 09:16:57 +0000 (17:16 +0800)]
Add parser for location status objects
Yang Gu [Wed, 31 Mar 2010 09:16:56 +0000 (17:16 +0800)]
Add parser for cause objects
Yang Gu [Wed, 31 Mar 2010 09:16:55 +0000 (17:16 +0800)]
Add parser for event list objects
Yang Gu [Wed, 31 Mar 2010 09:16:54 +0000 (17:16 +0800)]
Add parser for items next action indicator objects
Yang Gu [Wed, 31 Mar 2010 09:16:53 +0000 (17:16 +0800)]
Reorder the declarations of stk data objects
Zhenhua Zhang [Wed, 31 Mar 2010 09:50:40 +0000 (17:50 +0800)]
Add test implementation for CPBS
Zhenhua Zhang [Wed, 31 Mar 2010 09:50:39 +0000 (17:50 +0800)]
Add test implementation to support SMS