Piotr Kosko [Thu, 25 Apr 2019 08:33:23 +0000 (08:33 +0000)]
Merge "[MediaController] Adding, updating and sending item." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:17 +0000 (08:33 +0000)]
Merge "[Mediacontroller] Add playlist methods" into tizen
Michal Michalski [Wed, 24 Apr 2019 08:08:05 +0000 (10:08 +0200)]
[filesystem] Fix invalid errno usage.
http://suprem.sec.samsung.net/jira/browse/TFDF-1624
Fix for failing cordova filesystem tests.
Issue occured because errno value was not tested
right away after readdir() system function call
and other library functions were overriding errno.
[Verification] Cordova file tests pass.
Change-Id: If84de57e994b5255b1d51006803254f4fe90811b
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Dawid Juszczak [Wed, 17 Apr 2019 15:09:15 +0000 (17:09 +0200)]
[fix][content] Deprecate filtering attributes
fixed error with printing deprecation warning
[verification]
builded succesfully
tested on mobile device - everything looks fine
Change-Id: If6bc3cab368696d1a74e35805b78b35572669c2b
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.43
Change-Id: I25d5811f20d31f4034841ed106ab43c249fb0c59
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Wed, 17 Apr 2019 11:53:50 +0000 (11:53 +0000)]
Merge "[Content] Some attributes are readonly since 5.5" into tizen
[Content] Some attributes are readonly since 5.5
[Feature] name, description, rating, geolocation and orientation attributes are
readonly since 5.5.
For backward compatibility, the attributes are allowed for modifications for
apps with required version lower than 5.5
modified editableAttributes member also to remove readonly attributes from this array.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-203
[Verification]
TCT passrate 100% when running with 5.0 TCT - backward compatibility.
14 fails on latest TCT, TCT passrate 100% with TCT fixed by TCT team.
Change-Id: I8382372c51105fb7e11c3037d5994e2de76d59fa
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Wed, 17 Apr 2019 05:38:44 +0000 (07:38 +0200)]
[MediaController] Adding, updating and sending item.
Add methods
- addItem
- updatePlaybackItem
- sendPlaybackItem
Add callback
- onplaybackitemrequest
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Change-Id: Iffeec9bc0473f9a9df54d3fbd5a57dfc3ca21913
Dawid Juszczak [Fri, 5 Apr 2019 11:16:45 +0000 (13:16 +0200)]
[Content] Deprecate filtering attribute
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-210
Change-Id: Ib0ebdee662d7dbb57ad29e98d2b7e427911f9182
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Lukasz Bardeli [Fri, 12 Apr 2019 07:59:39 +0000 (09:59 +0200)]
[Mediacontroller] Add playlist methods
Add methods
- CreatePlaylist
- SavePlaylist
- DeletePlaylist
Define interfaces
- MediaControllerPlaylist
- MediaControllerPlaylistItem
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Icf9b043c00b23a29c0e3d13d0c3a3dbcba8c0762
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Michalski [Fri, 12 Apr 2019 07:15:48 +0000 (09:15 +0200)]
[mediacontroller] Fix pointer-related bug.
[Verification] Code builds and testted sendCommand function in chrome console.
Change-Id: I3045684b11e85a756854f999ed42c74721bb0ae5
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Wed, 10 Apr 2019 12:10:02 +0000 (12:10 +0000)]
Merge "[mediacontroller] Get/set content age rating API implementation." into tizen
Merge branch 'tizen_5.0' into tizen
Change-Id: Iff948d1e34e86ebd21401e59a12f5d805e4eb2ac
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I42897295af557b4844c1b9c4a16a687e96045cc5
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
[version] 2.41
Change-Id: Ib06ff3c123c7763b5b0234827ef8a8f74cc052d7
Dawid Juszczak [Mon, 8 Apr 2019 09:06:05 +0000 (11:06 +0200)]
[Content][fix] related to change in db
changed play_order to value compatible with database.
related to: http://suprem.sec.samsung.net/jira/browse/TFDF-1354
[verification] tct-content-tizen-tests - 100% PASS
Change-Id: I910bddd25ad5654c19565b136f29dea2a5e1dc1f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Wed, 3 Apr 2019 10:52:21 +0000 (12:52 +0200)]
[messageport][common] Move BundleJsonIterator to common.
It will be used in mediacontroller search API.
[Verification]
tct-messageport-tizen-tests 100% pass rate.
Change-Id: I1ef945697c16cc21801cb53e2bb13a389f777e9a
Michal Michalski [Thu, 7 Mar 2019 11:04:36 +0000 (12:04 +0100)]
[mediacontroller] Get/set content age rating API implementation.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-207
[Verification] Manual testing.
Change-Id: I8ecea29c13f4cf97c08edfe2d6fd3a07799459d9
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
[version] 2.40
Change-Id: I00ae696384378c21bb1e384ac1604b90e6ef81f0
Piotr Kosko [Wed, 27 Mar 2019 10:14:38 +0000 (10:14 +0000)]
Merge "[messaging] fixed bug with foldersupdate callback" into tizen
Dawid Juszczak [Tue, 26 Mar 2019 15:22:21 +0000 (16:22 +0100)]
[bluetooth] fixed bug with BluetoothProfileHandler
Refactored implementation of BluetoothProfileHandler constructor.
[Verification] (automated) tct-bluetooth-tizen-tests passed 100%
Change-Id: Iff1d3117f7a893da31ce4e6068e7886c4a21ff78
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Fri, 22 Mar 2019 11:30:24 +0000 (11:30 +0000)]
Merge "[mediacontroller] Use request_id for listener matching in SendCommand." into tizen
Piotr Kosko [Fri, 22 Mar 2019 08:25:46 +0000 (08:25 +0000)]
Merge "[MediaController] Change InvalidState to UnknownError." into tizen
Piotr Kosko [Fri, 22 Mar 2019 08:16:29 +0000 (08:16 +0000)]
Merge "[KeyManager] Add possibility to check whether alias is password protected" into tizen
Michal Michalski [Wed, 20 Mar 2019 17:19:15 +0000 (18:19 +0100)]
[mediacontroller] Use request_id for listener matching in SendCommand.
SendCommand method was using watchId to identify CommandReply callback which
should be called. It was passed in bundle object to mc_client_send_custom_cmd
function. Now instead of passing watchId we use already available request_id
to perform the same matching for command reply listeners.
[Verification]
Manual test.
tct-mediacontroller-tizen-tests - pass 100%
Change-Id: I57e90dbe36d7726f2e2f66866b11910d5d1d5d0d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Tue, 19 Mar 2019 15:30:43 +0000 (16:30 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201807/
Change-Id: I1389ab8e2ba4bcddada69fead783071626eda12d
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 13:55:22 +0000 (14:55 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201891/
Change-Id: Ia5efe12e79b7f388c2a967a7f118c33edc34d06f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Fri, 15 Mar 2019 11:42:35 +0000 (12:42 +0100)]
[widgetservice][utils] Fix CommonListenerManager implementation.
CommonListenerManager implementation used native.getResultObject
on listener input before passing it to the callback. This behavior
is widgetservice specific and so it was moved outside
CommonListenerManager implementation.
[Verification]
Manual tests.
Change-Id: Ied82281a660562c2697f4f6c298ec11a2e2d5549
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
[version] 2.39
Change-Id: Iace319e63260810fe4d26f5d166c3bdbb629ce21
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Fri, 15 Mar 2019 07:50:06 +0000 (07:50 +0000)]
Revert "[messaging] Refactor commonly used functions"
This reverts commit
b3b63e72ae9d1b4d909e5c213830427e8ecc6ed6.
Reason for revert: <INSERT REASONING HERE>
Change-Id: Ief8acc66b387fc8783978e8ce8b2f0474a8511fa
Lukasz Bardeli [Fri, 15 Mar 2019 08:29:14 +0000 (08:29 +0000)]
Merge "Revert "[messaging] Refactor functions used to get email converations from DB"" into tizen
Lukasz Bardeli [Fri, 15 Mar 2019 07:49:48 +0000 (07:49 +0000)]
Revert "[messaging] Refactor functions used to get email converations from DB"
This reverts commit
452dfff3c3eecd63e38295ad0455b961d400d1cb.
Reason for revert: <INSERT REASONING HERE>
Change-Id: I2373c1fc684ff879af16e08ba9f92d26c4ca77da
Piotr Kosko [Thu, 14 Mar 2019 06:16:11 +0000 (06:16 +0000)]
Merge "[Content] Adding comments in code and adding deprecation log" into tizen
Lukasz Bardeli [Tue, 12 Mar 2019 12:43:18 +0000 (13:43 +0100)]
[MediaController] Change InvalidState to UnknownError.
[Verification] Code compiles without error.
Change-Id: Ibda8a419257caf071c7ed8e08e5b496b5c0efe2e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Wed, 13 Mar 2019 06:59:04 +0000 (06:59 +0000)]
Merge "[Mediacontroller] Added new methods, enums, events" into tizen
Pawel Wasowski [Sat, 9 Feb 2019 14:30:47 +0000 (15:30 +0100)]
[messaging] Refactor functions used to get email converations from DB
Implementation of the functions has been simplified.
[Verification] tct-messaging-email-tests pass rate did not
change after the change was applied
Change-Id: Id1e28b4c94b502d801dc5674a3fa7cf5f2844e16
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Pawel Wasowski [Sat, 9 Feb 2019 09:01:20 +0000 (10:01 +0100)]
[messaging] Refactor commonly used functions
Functions for sorting and filtering are now more general.
Dedicated function for making SQL clause, comprising
only offset and limit was made to replace addFilters usage.
[Verification] tct-messaging-email-tests pass rate did not
change after the change was applied
Change-Id: Id73331631ff2e8cd17723cb7acd882c19f0be5be
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Rafal Walczyna [Wed, 8 Aug 2018 11:45:24 +0000 (13:45 +0200)]
[KeyManager] Add possibility to check whether alias is password protected
[ACR] TWDAPI-194
[Verification] TCT KeyManager tests on 5.5 TM1 - 100% pass
New features was tested manually in Chrome Dev Tools
Change-Id: I7ace3984746b56d186dd05d99f836d65116a741a
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 6 Mar 2019 07:32:16 +0000 (07:32 +0000)]
Merge "[Bluetooth] Marking classes as deprecated." into tizen
Szymon Jastrzebski [Wed, 23 Jan 2019 14:06:31 +0000 (15:06 +0100)]
[Content] Adding comments in code and adding deprecation log
http://suprem.sec.samsung.net/jira/browse/ACR-1249
[Verification] Content TCT 100%
Change-Id: Ie3c2450e46c343b2db350475b0ec679d485e2d70
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Pawel Wasowski [Wed, 6 Feb 2019 11:01:11 +0000 (12:01 +0100)]
[messaging] Enable more filter types
This commit:
- enables filtering by not yet supported Message, MessageConversation,
MessageFolder attributes.
For detailed info, please consult ACR: TWDAPI-205
- replaces the use of enum tizen::FilterMatchFlag, specific to Messaging, to
enum common::AttributeMatchFlag, used among all Web API modules
[Verification] Code compiles. findConversations (E-Mail) tested in
Chrome DevTools console works properly
Change-Id: I3f6d604b68c7c8889374ae77611dc96f7f48ee6f
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Arkadiusz Pietraszek [Mon, 14 Jan 2019 11:56:41 +0000 (12:56 +0100)]
[Bluetooth] Marking classes as deprecated.
BluetoothHealthProfileHandler and BluetoothHealthChannel will be deprecated since tizen 5.5
[Verification] TCT Pass rate: 100%
ACR: TWDAPI-196
Change-Id: I965e910a8d5fb71a5c98bdb62a3a757eb98777e0
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Szymon Jastrzebski [Thu, 3 Jan 2019 13:47:11 +0000 (14:47 +0100)]
[Mediacontroller] Added new methods, enums, events
+ Added support for value MC_REPEAT_MODE_ONE_MEDIA of mc_repeat_mode_e
enum.
+ Added clientName parameter in
MediaControllerChangeRequestPlaybackInfoCallback listeners.
[Verification] Code compiles without error. Tested in chrome console.
ACR: TWDAPI-204
Change-Id: I2f5a61607b5c9bd467aa21a0fc843d0c63034411
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Merge branch 'tizen_5.0' into tizen
Change-Id: If22b0877f7802232c7c783cf9107f7be4cf31b43
[version] 2.38
Change-Id: If39fca0d841550a2b4d36489374276686adcf14d
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Mon, 7 Jan 2019 10:24:28 +0000 (11:24 +0100)]
[Common] Fix preventing crash in argument validator
If to method which takes object as parameter, array with one element
of this object will be passed them applicaiton will crash. This fix prevent
such situations and will throw TypeMissmatch
[Verification] Code compiles without error. Tested in chrome console and
execute automatic TCT (modules which have methods taking platform object as parameter -
account, alarm, application, bluetooth, bookmark, calendar, callhistory, contact,
content, download, exif, filesystem, iotcon, mediacontroller, messageport,
messaging, nfc, notification, push, time)
100% passrate
Change-Id: Idfd9ad6f1acc0a6d5fd140dfd655d1cab7d2291a
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
(cherry picked from commit
faaf457e2aa1307f0c3406208374d71d5c98827b)
Piotr Kosko [Wed, 30 Jan 2019 11:37:44 +0000 (11:37 +0000)]
Merge "[Common] Fix preventing crash in argument validator" into tizen
DongHun Kwak [Fri, 25 Jan 2019 01:08:07 +0000 (10:08 +0900)]
Fix build break for icu 63.1
Added U_USING_ICU_NAMESPACE macro for adding
use namespace icu;
Change-Id: Ib80c463401b998c9c773208e638f236005347023
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Lukasz Bardeli [Thu, 24 Jan 2019 09:40:40 +0000 (10:40 +0100)]
[Messaging] Adding Log to get information about open error
[Verification] Code compiles properly.
Change-Id: I41dcf32e20eea77e1c7f37a7bc3d981baaa2cc32
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Merge branch 'tizen_5.0' into tizen
Change-Id: Icba20c6c0c55df7efb306719e4c4c9bcdca11f3c
Piotr Kosko [Wed, 16 Jan 2019 11:06:36 +0000 (11:06 +0000)]
Merge "[Common][Utils] Adding functions to unify deprecation warnings." into tizen
Arkadiusz Pietraszek [Tue, 15 Jan 2019 11:26:38 +0000 (12:26 +0100)]
[Common][Utils] Adding functions to unify deprecation warnings.
[Verification] Code compiles successfully.
Change-Id: Id81aa801f3858ead071ef8899cb9cfc4136ad589
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 16 Jan 2019 09:51:59 +0000 (09:51 +0000)]
Merge "[application] Change static methods to free functions." into tizen
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Icf1b978d0b5a6dea865fe10426e51ed79fe0d7ae
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I7bdf58474ccd556f444f93dee7856566a65373b6
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_5.0' into tizen
Change-Id: Ia5eb801400de6751e75cc14c50cd90284a64fd37
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I95d2ae95dbf4f9688dcd3c4beb3fecb0aac52206
Piotr Kosko [Wed, 9 Jan 2019 10:54:02 +0000 (10:54 +0000)]
Merge "[widgetservice][utils] Common implementation for ListenerManager." into tizen
[Content] Code refactored not to use deprecated native API
[Feature]
- use internal native API in place of removed public API (added include *internal.h)
int image_meta_set_orientation(image_meta_h, media_content_orientation_e)
int image_meta_update_to_db(image_meta_h)
int media_info_set_description(media_info_h, const char*)
int media_info_set_display_name(media_info_h, const char*)
int media_info_set_latitude(media_info_h, double)
int media_info_set_longitude(media_info_h, double)
int media_info_set_rating(media_info_h, int)
- use stat instead of media_folder_get_modified_time()
- removed usage of not documented enum MEDIA_CONTENT_STORAGE_CLOUD
[Related ACR] http://suprem.sec.samsung.net/jira/browse/ACR-1308
[Verification] tct-content - 100%
Change-Id: I37932c59549295e4d7154888406275168c49ab47
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifadc8944744fa1fe4e944670a51c184f1c36c228
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Michal Michalski [Mon, 7 Jan 2019 10:24:20 +0000 (11:24 +0100)]
[application] Change static methods to free functions.
ApplicationUtils class had only static methods and no state.
All those methods could as well be standalone functions, and
this is the preferred option due to simpler code.
[Verification]
TCT pass:
tct-appcontrol-tizen-tests
tct-application-tizen-tests
Change-Id: Ib1004a7bd8e01615d6802ef3152d6e5df8e0edea
Szymon Jastrzebski [Tue, 8 Jan 2019 09:46:38 +0000 (10:46 +0100)]
[Content] Replacing deprecated function
+ Function media_info_create_thumbnail has been deprecated since 5.0,
media_info_generate_thumbnail is used instead.
[Verification] TCT Content 100%
Change-Id: Ic79400e6ed2f8c18aa803e1d3f9953d9c82a78c7
Lukasz Bardeli [Mon, 7 Jan 2019 10:24:28 +0000 (11:24 +0100)]
[Common] Fix preventing crash in argument validator
If to method which takes object as parameter, array with one element
of this object will be passed them applicaiton will crash. This fix prevent
such situations and will throw TypeMissmatch
[Verification] Code compiles without error. Tested in chrome console and
execute automatic TCT (modules which have methods taking platform object as parameter -
account, alarm, application, bluetooth, bookmark, calendar, callhistory, contact,
content, download, exif, filesystem, iotcon, mediacontroller, messageport,
messaging, nfc, notification, push, time)
100% passrate
Change-Id: Idfd9ad6f1acc0a6d5fd140dfd655d1cab7d2291a
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Szymon Jastrzebski [Fri, 4 Jan 2019 14:30:25 +0000 (15:30 +0100)]
[Sound] Replacing deprecated function
[Verification] TCT Sound 100%
Change-Id: I6ad5e1142bc64a731244608a7b5629831570fef3
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Michal Michalski [Fri, 21 Dec 2018 19:35:17 +0000 (20:35 +0100)]
[widgetservice][utils] Common implementation for ListenerManager.
I extracted broken ListenerManager implementation from widgetservice module
fixed it, and placed it inside utils_api.js module as CommonListenerManager.
This implementation has customizable behavior if removeListener cannot find
listener for given id, so you can throw exception, do nothing, or return
error object.
[Verification]
Test usage of this CommonListenerManager implementation is provided in this
commit using widgetservice widgetStateChangeListener which I replaced.
Manual tests were performed to verify that the implementation behaves as
expected.
Change-Id: I0e18e091b9ad8cacc685663c65f3358cc022188d
Piotr Kosko [Wed, 2 Jan 2019 10:15:00 +0000 (10:15 +0000)]
Merge "[Bluetooth] Add new error value (AUTHORIZATION_REJECTED)" into tizen
Piotr Kosko [Fri, 28 Dec 2018 13:05:10 +0000 (13:05 +0000)]
Merge "[Bookmark] Refactoring module" into tizen
Piotr Kosko [Fri, 28 Dec 2018 11:47:29 +0000 (11:47 +0000)]
Merge "[filesystem] Silence undocumented exception." into tizen
Pawel Wasowski [Fri, 21 Dec 2018 13:16:04 +0000 (14:16 +0100)]
Fix ApplicationControlData creation
Verification: 100% TCT pass rate
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Change-Id: I3dc0a7eba685a0ec7e1e111350f9a68ae3f3296d
Michal Michalski [Fri, 21 Dec 2018 14:07:21 +0000 (15:07 +0100)]
[filesystem] Silence undocumented exception.
Filesystem function removeStorageStateChangeListener was throwing
NotFoundError exception if watchID argument did not correspond to
a registered listener. This commit removes this exception to match
documentation.
[Verification]
Exception is no longer thrown.
One TCT test case failed after this change, i removed it and commited
the change to tct repository. Review for TCT is available here:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/196106/
Change-Id: I8cb7d99b5dda3f66f36c406c86330fb5d089287f
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Mon, 17 Dec 2018 14:25:20 +0000 (15:25 +0100)]
[bluetooth] Ignoring undocumented exceptions in removeValueChangeListener.
Calling removeValueChangeListener was throwing undocumented errors.
This commit supresses those exceptions to match the documentation.
[Verification] Exception is not thrown (verified by modified TCT test).
Change-Id: I4df3b810d27d48da7a0194473984e59d1beb067b
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Szymon Jastrzebski [Wed, 19 Dec 2018 07:58:40 +0000 (08:58 +0100)]
[Bookmark] Refactoring module
[Verification] TCT 100%
Change-Id: I9f6f9ac1236c0e5ea049a1820e3de30ed332cdd6
Rafal Walczyna [Tue, 11 Dec 2018 14:44:25 +0000 (15:44 +0100)]
[Bluetooth] Add new error value (AUTHORIZATION_REJECTED)
New enum error value has been added to native API.
Supporting this value will deliver better error description to developers.
[verification] 100% TCT passrate on TM1
Change-Id: I8b2c2af6d4ff91e31d93ff60fd9dfac9a13e2152
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Thu, 6 Dec 2018 13:50:43 +0000 (13:50 +0000)]
Merge "[Filesystem] Moving execution of FSManager's methods into TaskQueue" into tizen_5.0
Piotr Kosko [Thu, 6 Dec 2018 13:31:29 +0000 (13:31 +0000)]
Merge "[MessagePort] Fixed issue with removeMessagePortListener without any added earlier" into tizen_5.0
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Szymon Jastrzebski [Fri, 24 Aug 2018 10:15:08 +0000 (12:15 +0200)]
Changing scheduling jobs to the main loop/worker
+ Creating stand-alone threads should be only exceptional, thus the
occurrences have been replaced by calling TaskQueue::Async.
[Verification] Callhistory, NBS, Preference, SE, SS, Widget
TCT 100% pass rate
Change-Id: Ibf7493d04c2cd48221d4a4f9f708722e61ee1459
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Thu, 28 Jun 2018 06:35:46 +0000 (08:35 +0200)]
[Common] Adding guard to protect container of Instances*
[Verification] TCT Application, Systeminfo, Filesystem 100%
Change-Id: Ife71f69fc031d14c6bcb1ec694cd2be102ed7f75
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 22 Jun 2018 11:38:55 +0000 (13:38 +0200)]
[Common] Implementation for parallel Worker
Change-Id: I93a0494cf5c943d2ead9e55957c25468764aebf8
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 22 Jun 2018 09:24:08 +0000 (11:24 +0200)]
[Common] Moving Filesystem Worker's implementation to common
Change-Id: I0119cee796112d46bbb5e7eb8ebf9fa7042fc9ff
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 3 Dec 2018 08:00:33 +0000 (09:00 +0100)]
[Filesystem] Moving execution of FSManager's methods into TaskQueue
Change-Id: I97c136014e57ba9d677ce6d8e7633531348bf1c6
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Lukasz Bardeli [Mon, 26 Nov 2018 11:19:29 +0000 (12:19 +0100)]
Merge branch 'tizen_5.0' into tizen
Change-Id: I7c84d15458fb0b79f5379924c0745dc69e963e9c
Lukasz Bardeli [Mon, 26 Nov 2018 10:18:42 +0000 (11:18 +0100)]
[version] 2.35
Change-Id: Ia943de0b76d2e6721838e7dfb8291ed8c99d2446
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
Lukasz Bardeli [Mon, 26 Nov 2018 09:53:30 +0000 (09:53 +0000)]
Merge "[Archive] Fix for preventing errno overwriting" into tizen_5.0
Lukasz Bardeli [Mon, 26 Nov 2018 09:49:53 +0000 (10:49 +0100)]
[Archive] Fix for preventing errno overwriting
Sometimes errno was overwritten and in switch return different values that was
assigned in lstat. This caused issue in throwing errors (IO instead Not Found)
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I79fc23cdd4c9113cab56d42cee6b5df82ed632a1
Signed-off-by: Lukasz Bardeli <l.bardeli@AMDC967.digital.local>
[Filesystem] Fixing return behaviour for FileHandle object
[Bug] When returning the asynchronous error while doing an operation on
FileHandle, the processing was not interrupted. Missing return statement
in those cases was added.
[Verification] Code compiles without errors.
TCT passrate for Filesystem - 100%
Change-Id: Ie8ba77922fa74c0263c40e55a157c2979b893cff
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Fri, 23 Nov 2018 13:11:06 +0000 (13:11 +0000)]
Merge "[Mediacontroller] Removed usage of removed native API" into tizen
Piotr Kosko [Fri, 23 Nov 2018 13:10:24 +0000 (13:10 +0000)]
Merge "Changing scheduling jobs to the main loop/worker" into tizen