Daniel Juyung Seo [Sat, 17 May 2014 11:20:52 +0000 (20:20 +0900)]
focus: apply the focus API change during the development phase.
This fixes the commit
422b8717 which was pushed to master without
considering the API change.
Daniel Juyung Seo [Sat, 17 May 2014 10:43:44 +0000 (19:43 +0900)]
Revert "Revert "focus: Fixed the animation issue related to bring_in.""
This reverts commit
e4ae67535672d04eec9eb368b71c72932cc0f757.
This will be fixed in a next commit.
Carsten Haitzler (Rasterman) [Fri, 16 May 2014 10:04:37 +0000 (19:04 +0900)]
cursor test - make button expand to test window edges with cursor
Carsten Haitzler (Rasterman) [Thu, 15 May 2014 08:43:56 +0000 (17:43 +0900)]
fix visiblity of entry cursor when selections exist
this fixes T1229 - the other part about cursor visibility. @fix
SangHyeon Lee [Thu, 15 May 2014 03:13:23 +0000 (12:13 +0900)]
[Gengrid] Fix gengrid item position update bug, when item is reordered or deleted.
Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
This Patch update item's position when item is placed. if middle of item deleted,
every item after the deleted one, will re-postion on _item_place function, so they
will be update there position well.
Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
they print there position and it works fine both horizontal and vertical.
Reviewers: bluezery, seoz, raster
Reviewed By: raster
CC: Hermet, chinmaya061
Differential Revision: https://phab.enlightenment.org/D855
Amitesh Singh [Thu, 15 May 2014 03:09:33 +0000 (12:09 +0900)]
hoversel: Icon parent set to button.
Summary: This is an optimization over parent set to hoversel object.
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D853
zmike [Wed, 14 May 2014 20:03:33 +0000 (16:03 -0400)]
fix mouse events on elm frame parts
zmike [Wed, 14 May 2014 18:30:09 +0000 (14:30 -0400)]
fix horizontal theme text sizing after @jpeg vertical fixes
Amitesh Singh [Wed, 14 May 2014 12:50:31 +0000 (21:50 +0900)]
hoversel: item-loop should happen on UP/DOWN Key in case of vertical hoversel and on LEFT/RIGHT Key in case of horizontal hoversel.
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix
Test Plan: elementary_test -to "Hoversel Focus"
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz, chinmaya061
Differential Revision: https://phab.enlightenment.org/D858
Youngbok Shin [Wed, 14 May 2014 12:26:33 +0000 (13:26 +0100)]
entry: Enable context menu with mosue down even if the entry is not editable in some case.
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix
Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.
Note: You can test it in Desktop profile.
Reviewers: tasn, woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D848
nirajkr [Wed, 14 May 2014 11:50:11 +0000 (20:50 +0900)]
gengrid : Fix the issue to skip disable item in item select
Summary:
Fix to skip the item which is disabled and select the next item to the
disabled item
@fix
Reviewers: seoz, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D700
Carsten Haitzler (Rasterman) [Wed, 14 May 2014 05:39:49 +0000 (14:39 +0900)]
update po files
Jean-Philippe Andre [Wed, 14 May 2014 06:29:02 +0000 (15:29 +0900)]
edc: Fix multibuttonentry alignments
Following the edc padding behaviour change
Jean-Philippe Andre [Tue, 13 May 2014 08:54:03 +0000 (17:54 +0900)]
edc: Also fix frame and button offsets
Since SHADOW adds one pixel padding, the whole object size
was calculated with one extra pixel. Let's add it back
to keep the overall visual balance of buttons.
A few other widgets might visually change after the edje
padding fix:
- Check (looks better)
- Naviframe (smaller height)
- E date widget
- ...
But I did not see anything "weird" that needs fixing.
Jean-Philippe Andre [Tue, 13 May 2014 07:12:22 +0000 (16:12 +0900)]
edc: Fix E titlebars after text padding changes
See EFL
5bf1f0c9187525cf40782b26d7fa49d2676f91bb:
edje_calc: Don't add padding twice to text objects
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
Jaehyun Cho [Wed, 14 May 2014 03:27:27 +0000 (12:27 +0900)]
elm_map: Fix to show and bring in a correct region after zooming
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D851
Lukasz Stanislawski [Wed, 14 May 2014 03:02:10 +0000 (12:02 +0900)]
layout: remove sizing_eval call when layout is already destructed. @fix
Summary:
Layout's sub_object_del function calls sizing_eval even if layout's smart_del
function has already been called (Due to widget_smart_del impl).
This patch adds 'destructed_is' flag to Elm_Layout_Smart_Data and prevents unneeded
sizing_eval calls when object is already destructed.
Patch also fixes SIGSEGV in layout derived entry widget caused by calling
sizing_eval after entry_smart_del destructor.
Added entry test to avoid regression for SIGSEGV bug.
Test Plan: run tests/elm_test_entry
Reviewers: raster, seoz, tasn, cedric
Differential Revision: https://phab.enlightenment.org/D823
Mike Blumenkrantz [Tue, 13 May 2014 20:14:29 +0000 (16:14 -0400)]
more ellipsis fixes
Mike Blumenkrantz [Tue, 13 May 2014 19:45:30 +0000 (15:45 -0400)]
add ellipsis to elm theme where necessary
Youngbok Shin [Tue, 13 May 2014 06:50:05 +0000 (15:50 +0900)]
entry: Fix a test case for editable, non-editable entry.
Summary:
elm_entry_context_menu_disabled_set API is called to wrong entry.
It should be called to "en2" that added for testing the API.
@fix
Test Plan: 1. elementary -to entry7
Reviewers: woohyun, seoz, tasn
Reviewed By: seoz
CC: herdsman
Differential Revision: https://phab.enlightenment.org/D852
Carsten Haitzler (Rasterman) [Tue, 13 May 2014 02:32:00 +0000 (11:32 +0900)]
Revert "focus: Fixed the animation issue related to bring_in."
This reverts commit
422b8717660853ff099359dc3cd926e56f1b1665.
Anand [Tue, 13 May 2014 02:24:19 +0000 (11:24 +0900)]
focus: Fixed the animation issue related to bring_in.
Summary:
Calculating the coordinate of the object to retain the focus with in view port.
Earlier focus was moving out of view port.
Test Plan:
elementary_test-> "Focus 3". Enable the Focus Auto scroll bring in and use
keys to move focused item.
Reviewers: raster, seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D822
Stefan Schmidt [Mon, 12 May 2014 12:55:13 +0000 (14:55 +0200)]
release: v1.10.0 beta2
Jean-Philippe Andre [Mon, 12 May 2014 09:52:24 +0000 (18:52 +0900)]
test_dnd: Fix build for windows
There is no strndup (with our compilation flags).
Jean-Philippe Andre [Mon, 12 May 2014 06:44:18 +0000 (15:44 +0900)]
elm_map: Fix compilation warning/error
ELM_WIDGET_DATA_GET_OR_RETURN can take a VA_ARGS if the function
should return something.
Jean-Philippe Andre [Mon, 12 May 2014 06:09:03 +0000 (15:09 +0900)]
Compilation: Align EDJ, EOLIAN and EPB to CC
Jaehyun Cho [Mon, 12 May 2014 04:44:03 +0000 (13:44 +0900)]
elm_map: Fix to support customized style for elm_map
Summary: Load a map theme with a style to support customized style
@fix
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D845
Mike Blumenkrantz [Sun, 11 May 2014 18:22:06 +0000 (14:22 -0400)]
okay, I'll be a nice guy and leave music-control theme compat
Mike Blumenkrantz [Sun, 11 May 2014 18:05:30 +0000 (14:05 -0400)]
fix music-control theme namespacing
Mike Blumenkrantz [Sun, 11 May 2014 17:57:37 +0000 (13:57 -0400)]
rename pager16 theme groups pager2 -> pager16
Mike Blumenkrantz [Sun, 11 May 2014 17:48:09 +0000 (13:48 -0400)]
remove deskmirror theme ifdef
Daniel Juyung Seo [Sun, 11 May 2014 16:04:25 +0000 (01:04 +0900)]
focus: update the focus in_theme status on each item's focus set.
As widget and widget item can have different in_theme value (since
30cada369), we need to update in_theme value whenever the widget or
widget item get the focus.
Applied this logic to genlist, gengrid, toolbar first.
List focus is not working well at the moment.
This fixes small focus highlight on the left top corner of genlist
when the genlist scroller is clicked before the genlist is focused.
Special thanks to zmike for the report.
davemds [Sun, 11 May 2014 14:13:39 +0000 (16:13 +0200)]
set expected ellipsis value for hoversel
Daniel Juyung Seo [Sun, 11 May 2014 14:06:59 +0000 (23:06 +0900)]
list: Use convenient macro ELM_RECTS_INCLUDE.
Daniel Juyung Seo [Sun, 11 May 2014 13:42:45 +0000 (22:42 +0900)]
focus: Change new API names related to focus auto scrolling.
elm_config_focus_auto_scroll_bring_in_enabled_get/set()
->
elm_config_focus_autoscroll_mode_get/set()
The main reason is that bring_in_enabled_get/set() APIs are too restricted
and thus not flexible. I got more requirements for the focus autoscrolling
such as none, wholely visible not just bring_in and show. So it is correct
to add mode_set/get() APIs for the focus auto scrolling.
Thanks god, we've found this before the release :)
@feature
Daniel Juyung Seo [Sun, 11 May 2014 08:53:00 +0000 (17:53 +0900)]
Revert "remove all scrolling changes for focused items."
This reverts commit
377179bdaf84aa1a86621cdfa64ed43613ab9d45.
The main claim of https://phab.enlightenment.org/T1205 was fixed in
the previous commit
30cada369. This code will be modifed again in the
next commit due to the api change during development life cycle.
Note: do not blindly revert this commit if you have any problem with
widget item focus. This commit is not related to any fundamental cause
of the issues. If you have a problem, please contact me first.
seojuyung2@gmail.com or SeoZ on IRC.
Thanks.
Daniel Juyung Seo [Sun, 11 May 2014 12:20:04 +0000 (21:20 +0900)]
gengrid/genlist/list/toolbar: Do not set the focus to the item on widget's first focus.
This was introduced during 1.10 development phase but this changed the
default focus behavior and got a lot of complaints. (especially from
discomfitor)
So I would like to comment this out now and make it optional on 1.11
by keeping the default behavior.
Daniel Juyung Seo [Sat, 10 May 2014 14:41:10 +0000 (23:41 +0900)]
list: added comments about an unused function.
Fixing this issue is not trivial and will bring another issues like crashing.
So it is better to fix this in a development phase by refactoring list.
To fix this issue, the following are needed:
1. it->walking concept should be adopted instead of using just sd->walking.
sd->walking was introduced in
beb418d6
2. elm_widget_item_del() should be called instead of the combination of
_elm_list_item_free() + elm_widget_item_free()
This was introduced in
f343011d
Daniel Juyung Seo [Sat, 10 May 2014 14:37:03 +0000 (23:37 +0900)]
list: initialize some internal variables on item free not item del pre.
This fixes variable initialize problems related to focus. This can be
reproduced when you enable focus highlight/animation and reuse
elm_list by clearing it.
This problem occurred because list item del pre is never been called.
This bug will be addressed in a next commit.
Daniel Juyung Seo [Sat, 10 May 2014 14:15:54 +0000 (23:15 +0900)]
elm: fixed trivial formattings.
Just found them while reading codes.
Daniel Juyung Seo [Sat, 10 May 2014 14:13:12 +0000 (23:13 +0900)]
elm: call elm_widget_item_del instead of elm_object_item_del inside elementary.
This reduces only one more function call but this makes the elm code
more consistent between widgets.
Carsten Haitzler (Rasterman) [Sun, 4 May 2014 22:41:38 +0000 (07:41 +0900)]
theme - fix e list item selecton and label
Cedric Bail [Sat, 10 May 2014 09:27:26 +0000 (11:27 +0200)]
autotools: remove dead and erroneous code.
Daniel Juyung Seo [Sat, 10 May 2014 05:07:14 +0000 (14:07 +0900)]
elm: fixed wrong internal variable name.
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
Daniel Juyung Seo [Sat, 10 May 2014 05:01:33 +0000 (14:01 +0900)]
test_naviframe: added a test for event freeze checking.
Mike Blumenkrantz [Sat, 10 May 2014 04:13:05 +0000 (00:13 -0400)]
clock theme forces visibility on date text
fix T490
Mike Blumenkrantz [Fri, 9 May 2014 19:35:50 +0000 (15:35 -0400)]
genlist theme uses scale;
Mike Blumenkrantz [Fri, 9 May 2014 19:58:03 +0000 (15:58 -0400)]
genlist theme no longer uses desc.state anywhere
Daniel Juyung Seo [Fri, 9 May 2014 16:12:20 +0000 (01:12 +0900)]
gengrid: removed build warning.
Anil Kumar Nahak [Fri, 9 May 2014 16:09:27 +0000 (01:09 +0900)]
test_gengrid: Added a checkbox for enable/disable of reorder_mode feature
Summary: reorder mode can be enable/disable by clicking "'Reorder mode enable" checkbox
Test Plan: elementary_test->"GenGrid"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D829
Anil Kumar Nahak [Fri, 9 May 2014 16:07:57 +0000 (01:07 +0900)]
genlist/gengrid: Use pan object geometry for focus highlight calculation
Summary: Genlist/gengrid object geometry was used before this patch but using the pan object geometry is more correct. This can be reproduced when the size of "elm.swallow.content" part is smaller then the size of scroller object, focus animtaion on items is jerky.
Reviewers: raster, seoz, singh.amitesh
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D818
Ryuan Choi [Wed, 7 May 2014 03:51:51 +0000 (12:51 +0900)]
ctxpopup: Fixes that remains diskselector when dismissed ctxpopup of elm_datetime.
elm_object_content_unset should return child element which is unset.
Tests: elementary_test -to datetime
ChunEon Park [Fri, 9 May 2014 06:24:18 +0000 (15:24 +0900)]
widget - use eo call.
ChunEon Park [Fri, 9 May 2014 06:18:49 +0000 (15:18 +0900)]
widgets - propagate current parent orientation to sub object.
If object is unset then set to parent again, the current orientation signals
should be emitted so as to be latest state.
@fix
Mike Blumenkrantz [Thu, 8 May 2014 19:07:45 +0000 (15:07 -0400)]
Revert "add event blocker for ibar menu"
This reverts commit
0678bdbc0655b520c3f187684afe4ad1a9091c0e.
take more naps
Mike Blumenkrantz [Thu, 8 May 2014 18:36:58 +0000 (14:36 -0400)]
add event blocker for ibar menu
having mouse clicks intercepted and going to /dev/null when clicking on items during mouseover animation was super annoying
Patryk Kaczmarek [Thu, 8 May 2014 02:14:36 +0000 (11:14 +0900)]
access: fix typo _elm_access_object_unhilight -> _elm_access_object_unhighlight
Summary: Name of that function is not proper in my opinion. Please consider that revision.
Reviewers: raster, seoz, bluezery, stanluk, jaehwan, kimcinoo
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D827
Mike Blumenkrantz [Thu, 8 May 2014 00:08:47 +0000 (20:08 -0400)]
e syscon buttons now implement focus glow
Daniel Zaoui [Wed, 7 May 2014 10:43:20 +0000 (13:43 +0300)]
Web: bring legacy from the dead.
ABI check found that during Eolian integration of Elm Web, I forgot some
deprecated function.
zmike [Wed, 7 May 2014 05:13:19 +0000 (01:13 -0400)]
Revert "Revert "focus: Removed unused parameter from an internal focus function.""
This reverts commit
b8549f3e83a8592145a50085182583adead2c74e.
this build system is bad and whoever did the eo integration should not feel pleased with themselves.
zmike [Wed, 7 May 2014 05:08:04 +0000 (01:08 -0400)]
Revert "focus: Removed unused parameter from an internal focus function."
This reverts commit
5832b692aa5f68a2924bd7886390d489eb13aefb.
broke build
zmike [Wed, 7 May 2014 04:50:12 +0000 (00:50 -0400)]
remove all scrolling changes for focused items.
this.is.BROOOOOOOOOOOOOOOKEEEEEEEEEEEEEEEEEEENNNNNNNNNNNNNNNNNNNNNNNNNNNNN.
SERIOUSLY.
you cannot go scrolling all over the place in every widget that has a scroller just because the widget gets focus. what user wants that? no user anywhere, under any circumstances, ever, in all of history.
if you dare to put this back in, I will continue to remove it for the rest of eternity until it never, ever scrolls in any unwanted case. the focused item doesn't have to always be in the viewport, and should never be moved into the viewport [[[[[[[ except to maintain an already-existing position inside the viewport ]]]]]]]
too much of my time wasted on this stupid "feature" which should have been MUCH more thoroughly tested and reviewed before it was merged.
T1205 STILL NOT FIXED
Daniel Juyung Seo [Tue, 6 May 2014 15:05:07 +0000 (00:05 +0900)]
focus: Removed unused parameter from an internal focus function.
is_next parameter is not used for
elm_widget_focus_highlight_geometry_get() function.
But this parameter was not cleaned up in the commit 5320cca.
Stefan Schmidt [Mon, 5 May 2014 14:25:04 +0000 (16:25 +0200)]
release: v1.10.0 beta1
Daniel Juyung Seo [Sat, 3 May 2014 21:18:44 +0000 (06:18 +0900)]
theme: removed unnecessary null check.
Null check is already done in the previous line so do not check null
again.
Ryuan Choi [Sat, 3 May 2014 10:36:54 +0000 (19:36 +0900)]
Fix the leak when closed alert/prompt/confirm since
1be3950fd
Spotted by seoz.
zmike [Fri, 2 May 2014 22:33:27 +0000 (18:33 -0400)]
naviframe transitions are now uniform
this looked less than sleek with the overlapping contents of the mismatched transition modes
Daniel Juyung Seo [Fri, 2 May 2014 18:51:35 +0000 (03:51 +0900)]
photocam: added @c to EINA_TRUE/FALSE doxygen.
zmike [Fri, 2 May 2014 16:04:22 +0000 (12:04 -0400)]
spinner theme text ellipsis fix
Carsten Haitzler (Rasterman) [Fri, 2 May 2014 12:24:26 +0000 (21:24 +0900)]
adjust po file line nums
Carsten Haitzler (Rasterman) [Fri, 2 May 2014 09:44:17 +0000 (18:44 +0900)]
fix new ellipsising of elm theme elements.
Mike Blumenkrantz [Thu, 1 May 2014 21:23:13 +0000 (17:23 -0400)]
genlist edc part types are now 100% defined using 1.10 edc
Daniel Juyung Seo [Thu, 1 May 2014 13:27:02 +0000 (22:27 +0900)]
focus: Fixed focus_region_show to consider bring_in_enable configuration.
focus_auto_scroll_bring_in_enable feature is new in 1.10, this would
not be backported.
Daniel Juyung Seo [Thu, 1 May 2014 12:54:24 +0000 (21:54 +0900)]
test_focus: initialize focus related check states correctly.
Fetch the current focus config status.
Daniel Juyung Seo [Thu, 1 May 2014 12:34:38 +0000 (21:34 +0900)]
config: internal code refactoring for the readability.
Gathers focus related configurations.
Daniel Juyung Seo [Thu, 1 May 2014 12:31:11 +0000 (21:31 +0900)]
config: removed unnecessary variable initialize.
It is overwritten in the following line.
Daniel Juyung Seo [Thu, 1 May 2014 12:30:13 +0000 (21:30 +0900)]
elm_config: added focus menu to elementary_config.
This helps focus debugging by changing the global configuration.
Daniel Juyung Seo [Thu, 1 May 2014 09:51:24 +0000 (18:51 +0900)]
config: apply CHECK_ADD macro to elementary_config.
Daniel Juyung Seo [Thu, 1 May 2014 09:37:58 +0000 (18:37 +0900)]
config: introduced a global CHECK_ADD macro for elementary config.
Amitesh Singh [Wed, 30 Apr 2014 08:59:40 +0000 (17:59 +0900)]
gengrid: frame variable should be used for position changes.
Summary:
Earlier pos was getting used for the item coordinates. To support other Ecore_Pos_Map variations, frame variable should be used.
@fix
Test Plan:
elementary_test-> "Gengrid Focus". Enable reorder mode and use keys to move
the focused item.
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D811
Daniel Juyung Seo [Wed, 30 Apr 2014 07:14:50 +0000 (16:14 +0900)]
test_dnd: removed dead code.
This fixes coverity CID 1210426.
Daniel Juyung Seo [Tue, 29 Apr 2014 16:21:53 +0000 (01:21 +0900)]
test_popup: Added more align usages to reveal popup align bug.
Actually the bugs are from notify.
Daniel Zaoui [Tue, 29 Apr 2014 12:59:59 +0000 (15:59 +0300)]
Entry: add the activated signal in the events section of entry.eo.
Thiep Ha [Tue, 29 Apr 2014 07:28:12 +0000 (16:28 +0900)]
test_dnd: Change sending data to be compatible with other apps
Summary:
The sending data used # character, it is not compatible with other apps, so we should change it.
Change sending data to use newline character to be compatible with other apps, able to correctly drag to other apps like EFM, chrome, ...
Reviewers: JackDanielZ, seoz, raster, woohyun
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D751
WooHyun Jung [Tue, 29 Apr 2014 06:39:41 +0000 (15:39 +0900)]
notify_test: When elm_notify is shown, set focus to it.
Daniel Zaoui [Tue, 29 Apr 2014 05:45:10 +0000 (08:45 +0300)]
Eolian: fix elm_widget.eo
part_text has to be an extra property, not a method.
zmike [Mon, 28 Apr 2014 15:00:54 +0000 (11:00 -0400)]
ctxpopup should not blindly show arrows when they are not wanted by the theme
@fix
Carsten Haitzler (Rasterman) [Mon, 28 Apr 2014 12:51:12 +0000 (21:51 +0900)]
elm win - fix ELM_DISPLAY to choose the right software enine
Stefan Schmidt [Mon, 28 Apr 2014 10:35:19 +0000 (12:35 +0200)]
release: v1.10.0 alpha1
zmike [Sun, 27 Apr 2014 17:47:05 +0000 (13:47 -0400)]
ctxpopup bg theme should block all mouse events, not just left button
@fix
Daniel Zaoui [Sun, 27 Apr 2014 13:09:01 +0000 (16:09 +0300)]
Eolian: install .eo files
Daniel Juyung Seo [Sun, 27 Apr 2014 04:43:37 +0000 (13:43 +0900)]
gengrid: Added elm_gengrid_wheel_disabled_set/get() APIs.
Summary:
The basic idea is from Abhinandan Aryadipta and I implemented this in
upstream.
Special thanks to JackDanielZ for eolian madness.
@feature
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D803
Daniel Juyung Seo [Sun, 27 Apr 2014 04:42:47 +0000 (13:42 +0900)]
gengrid: removed unnecessary return value check.
Just return the return value without checking it.
Daniel Juyung Seo [Sun, 27 Apr 2014 04:12:21 +0000 (13:12 +0900)]
test_gengrid: renamed stupid long internal variable names shorter.
Amitesh Singh [Sun, 27 Apr 2014 04:08:15 +0000 (13:08 +0900)]
gengrid: Implemented item_select_on_focus feature.
Summary:
This is based on
bb1e8afd.
@feature
Test Plan: elementary_test->"Gengrid Focus"
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D702
Daniel Juyung Seo [Sun, 27 Apr 2014 04:04:26 +0000 (13:04 +0900)]
test_genlist: renamed stupid long internal variable names shorter.
Daniel Juyung Seo [Sun, 27 Apr 2014 03:55:58 +0000 (12:55 +0900)]
genlist: refactor the internal code to make it more readable.
Amitesh Singh [Sun, 27 Apr 2014 03:38:27 +0000 (12:38 +0900)]
genlist: Implemented item_select_on_focus feature.
Summary: @feature
Test Plan: elementary_test->Genlist Focus
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D705
Daniel Juyung Seo [Sun, 27 Apr 2014 02:21:46 +0000 (11:21 +0900)]
genlist: renamed internal function according to the key binding adoption.
Amitesh Singh [Sat, 26 Apr 2014 19:15:26 +0000 (04:15 +0900)]
config: Added two APIs to enable/disable focus auto scroll bring in feature.
Summary:
Summary:
- APIs
- elm_config_focus_auto_scroll_bring_in_enabled_set
- elm_config_focus_auto_scroll_bring_in_enabled_get
- list/genlist/toolbar/gengrid: Using this feature for scrolling for focus movement.
- Added test case in "List Focus", "Genlist Focus", "Toolbar Focus" and "Gengrid Focus"
@feature
Test Plan: elementary_test->"List Focus", "Genlist Focus", "Toolbar Focus" & "Gengrid Focus".
Reviewers: raster, seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D799