platform/upstream/busybox.git
20 years agoFinish remerging busybox udhcp and udhcp. Some cleanups as well.
Russ Dill [Thu, 18 Dec 2003 22:25:38 +0000 (22:25 -0000)]
Finish remerging busybox udhcp and udhcp. Some cleanups as well.

20 years agoclean up some bad, bad formatting
Russ Dill [Tue, 16 Dec 2003 22:46:33 +0000 (22:46 -0000)]
clean up some bad, bad formatting

20 years agoinclude headers with prototypes to make sure prototypes match
Russ Dill [Tue, 16 Dec 2003 20:44:15 +0000 (20:44 -0000)]
include headers with prototypes to make sure prototypes match

20 years agoremove reference to missing header file which is breaking the build
Eric Andersen [Tue, 16 Dec 2003 12:04:01 +0000 (12:04 -0000)]
remove reference to missing header file which is breaking the build

20 years agoUsing vlock also requires libcrypt
Eric Andersen [Tue, 16 Dec 2003 07:43:20 +0000 (07:43 -0000)]
Using vlock also requires libcrypt

20 years agorevert removal of define
Russ Dill [Tue, 16 Dec 2003 02:38:09 +0000 (02:38 -0000)]
revert removal of define

20 years agoforgotten include
Russ Dill [Tue, 16 Dec 2003 02:34:28 +0000 (02:34 -0000)]
forgotten include

20 years agowhy the complication of a static string rather than a define? gcc isn't dumb
Russ Dill [Tue, 16 Dec 2003 02:30:53 +0000 (02:30 -0000)]
why the complication of a static string rather than a define? gcc isn't dumb

20 years agostart attempting to bring udhcp in busybox back to the state where it is (ideally...
Russ Dill [Tue, 16 Dec 2003 02:28:20 +0000 (02:28 -0000)]
start attempting to bring udhcp in busybox back to the state where it is (ideally) an exact copy of udhcp outside of busybox so that its easy to merge back and forth

20 years agowhen compiled standalone, udhcp needs these headers
Russ Dill [Tue, 16 Dec 2003 01:42:18 +0000 (01:42 -0000)]
when compiled standalone, udhcp needs these headers

20 years agowhoops
Russ Dill [Tue, 16 Dec 2003 01:33:38 +0000 (01:33 -0000)]
whoops

20 years agonot sure who made this change, but it certainly mucks things up (note 'fwrite(leases...
Russ Dill [Tue, 16 Dec 2003 01:29:40 +0000 (01:29 -0000)]
not sure who made this change, but it certainly mucks things up (note 'fwrite(leases, ...'), adds a bit more code, and some stack overhead. Anywho, this fixes it, and retains the spirit of what the submitter of this change was attempting to acheive (the entire lease is written at once in a struct)

20 years agomake udhcp work under uclinux, to an extent
Russ Dill [Mon, 15 Dec 2003 22:11:26 +0000 (22:11 -0000)]
make udhcp work under uclinux, to an extent

20 years agooptions is a pretty common symbol, bad idea to use as a global in udhcp when compilin...
Russ Dill [Mon, 15 Dec 2003 22:09:36 +0000 (22:09 -0000)]
options is a pretty common symbol, bad idea to use as a global in udhcp when compiling into busybox

20 years agoGet vfork_daemon_rexec working under uclinux
Russ Dill [Mon, 15 Dec 2003 21:57:44 +0000 (21:57 -0000)]
Get vfork_daemon_rexec working under uclinux

20 years agoBe certain we use a correct entity when performing the
Eric Andersen [Fri, 12 Dec 2003 19:05:15 +0000 (19:05 -0000)]
Be certain we use a correct entity when performing the
BLKGETSIZE64 ioctl -- don't just assume 8,

20 years agoDoh! I broke automatic filesystem type guessing. Fix mount so
Eric Andersen [Fri, 12 Dec 2003 07:01:14 +0000 (07:01 -0000)]
Doh!  I broke automatic filesystem type guessing.  Fix mount so
it will properly fall back to /proc/mounts when /etc/filesystems
is missing, allowing mount to guess the correct fs type when a
fs type is not explicitly specified.
 -Erik

20 years agoFix compile when CONFIG_FEATURE_HDPARM_GET_IDENTITY is disabled
Eric Andersen [Fri, 12 Dec 2003 00:08:57 +0000 (00:08 -0000)]
Fix compile when CONFIG_FEATURE_HDPARM_GET_IDENTITY is disabled

20 years agoIt appears the Netgear WG602 distributes source
Eric Andersen [Thu, 11 Dec 2003 18:03:15 +0000 (18:03 -0000)]
It appears the Netgear WG602 distributes source

20 years agoFixup some html bugs
Eric Andersen [Thu, 11 Dec 2003 08:04:49 +0000 (08:04 -0000)]
Fixup some html bugs

20 years agosome minor website cleanups
Eric Andersen [Thu, 11 Dec 2003 07:13:15 +0000 (07:13 -0000)]
some minor website cleanups

20 years agoprepare for release 1_00_pre4
Eric Andersen [Thu, 11 Dec 2003 02:48:15 +0000 (02:48 -0000)]
prepare for release

20 years agoUpdate modutils with 2.6 module support
Eric Andersen [Thu, 11 Dec 2003 01:42:13 +0000 (01:42 -0000)]
Update modutils with 2.6 module support

20 years agogo directly to current cvs
Eric Andersen [Thu, 11 Dec 2003 01:29:46 +0000 (01:29 -0000)]
go directly to current cvs

20 years agoremove some spaces that mess up autodocifier.pl
Eric Andersen [Thu, 11 Dec 2003 01:18:07 +0000 (01:18 -0000)]
remove some spaces that mess up autodocifier.pl

20 years agoadd missing copyright text
Eric Andersen [Wed, 10 Dec 2003 20:50:14 +0000 (20:50 -0000)]
add missing copyright text

20 years agosome minor updates
Eric Andersen [Wed, 10 Dec 2003 20:41:48 +0000 (20:41 -0000)]
some minor updates

20 years agoupdate website
Eric Andersen [Wed, 10 Dec 2003 12:08:20 +0000 (12:08 -0000)]
update website

20 years agoFix indenting.
Eric Andersen [Tue, 9 Dec 2003 23:50:24 +0000 (23:50 -0000)]
Fix indenting.

Fix a bug noticed by Pete Flugstad.  Make certain we close what we open, and
don't try to close invalid files when /etc/filesystems exists and is used.

20 years agoBump version number
Eric Andersen [Tue, 9 Dec 2003 17:31:48 +0000 (17:31 -0000)]
Bump version number

20 years agoSplitting statements with #define's can cause trouble for cross
Glenn L McGrath [Mon, 8 Dec 2003 20:31:25 +0000 (20:31 -0000)]
Splitting statements with #define's can cause trouble for cross
compilers (and it looks a bit messy)

20 years agoStop sending data to the client after the first failure.
Glenn L McGrath [Mon, 8 Dec 2003 20:21:53 +0000 (20:21 -0000)]
Stop sending data to the client after the first failure.
Patch by Joe.C

20 years agoBring usage upto date, patch by Steven Scholz
Glenn L McGrath [Mon, 8 Dec 2003 20:11:55 +0000 (20:11 -0000)]
Bring usage upto date, patch by Steven Scholz

20 years agoFix a compile error when only using ar, patch by Paul van Gool
Glenn L McGrath [Fri, 5 Dec 2003 02:51:21 +0000 (02:51 -0000)]
Fix a compile error when only using ar, patch by Paul van Gool

20 years agoAdd (untested) support for cris, based on the (old) busybox insmod
Manuel Novoa III [Thu, 4 Dec 2003 15:02:57 +0000 (15:02 -0000)]
Add (untested) support for cris, based on the (old) busybox insmod
that axis distributes.

20 years agoPatch from Steven Scholz, make usage more consistent with actual
Glenn L McGrath [Thu, 4 Dec 2003 13:06:44 +0000 (13:06 -0000)]
Patch from Steven Scholz, make usage more consistent with actual
behaviour.

20 years agoDo not use the _syscall5 macro -- use syscall(2) instead
Eric Andersen [Thu, 4 Dec 2003 07:07:14 +0000 (07:07 -0000)]
Do not use the _syscall5 macro -- use syscall(2) instead

20 years agoPatch from Tito, size optimisation, cleanup noise when in debugging
Glenn L McGrath [Sun, 30 Nov 2003 23:46:06 +0000 (23:46 -0000)]
Patch from Tito, size optimisation, cleanup noise when in debugging
mode, adds support for MODLOAD keyword in devfsd.conf, provides a
cleaned up version of example/devfsd.conf

20 years agoCorrect Matteo's email address
Glenn L McGrath [Fri, 28 Nov 2003 22:55:03 +0000 (22:55 -0000)]
Correct Matteo's email address

20 years agoPatch from Ian Campbell, fix or'ed dependencies and handle virtual
Glenn L McGrath [Fri, 28 Nov 2003 22:38:14 +0000 (22:38 -0000)]
Patch from Ian Campbell, fix or'ed dependencies and handle virtual
dependencies.

20 years agoFix a bug, ignore the source path when installing to a directory.
Glenn L McGrath [Thu, 27 Nov 2003 22:40:08 +0000 (22:40 -0000)]
Fix a bug, ignore the source path when installing to a directory.
We may be installing symlinks, so use lstat/lchown.
Make use of bb_getopt_ulflags and cp_mv_stat2, save 100 bytes.

20 years agoFix tar hard links
Glenn L McGrath [Thu, 27 Nov 2003 00:01:43 +0000 (00:01 -0000)]
Fix tar hard links

20 years agoImportant bugfixes from Ian Campbell.
Glenn L McGrath [Wed, 26 Nov 2003 21:53:37 +0000 (21:53 -0000)]
Important bugfixes from Ian Campbell.
init_archive_deb_data()
        We want to filter for data.tar.* in the AR file not the TAR
        file, else we get nothing.

all_control_list()
        Make the 'extensions' array of control file names a global so it
        can be used in unpack_package as well. Name the global
        all_control_files. Don't hard code the length of
        all_control_files but instead used sizeof.

unpack_package()
        Only unpack the control files we are interested in (from
        all_control_files). Extract the data.tar.gz into / rather than
        the current directory.

dpkg_main()
        Configure packages in a second pass so all the packages being
        installed are unpacked before configuring.

Some purely cosmetic changes:

header
        update list of differences since two of them are no longer true.
        The .control file is no longer stored as a result of this patch
        -- it was redundant since the info is in status. New packages
        appear to be added to the end of the status file now rather than
        the start.

remove_package()
        Make message printing optional, so we can avoid a redundant
        message when replacing/upgrading a package. When we do print
        stuff then include the version number.

purge_package()
        Print "Purging xxx (yyy) ..." message like the other actions.

configure_package()
        Add "..." to "Setting up" message to be consistent with other
        actions.

20 years agoFix for "Broken pipe" issue, vodz last_patch116_3
Glenn L McGrath [Tue, 25 Nov 2003 20:45:38 +0000 (20:45 -0000)]
Fix for "Broken pipe" issue, vodz last_patch116_3

20 years agoWhen a size of 0 is passed to copyfd_size, dont do anything, it was
Glenn L McGrath [Mon, 24 Nov 2003 23:50:07 +0000 (23:50 -0000)]
When a size of 0 is passed to copyfd_size, dont do anything, it was
reading untill eof which breaks tar

20 years agoFix warning
Glenn L McGrath [Sat, 22 Nov 2003 02:13:41 +0000 (02:13 -0000)]
Fix warning

20 years agoAs we no longer use function pointers for read in common archiving code
Glenn L McGrath [Fri, 21 Nov 2003 22:24:57 +0000 (22:24 -0000)]
As we no longer use function pointers for read in common archiving code
archive_xread can be replaced with bb_full_read, and archive_copy_file
with bb_copyfd*
bb_copyfd is split into two functions bb_copyfd_size and bb_copyfd_eof,
they share a common backend.

20 years agoUse safe read
Glenn L McGrath [Fri, 21 Nov 2003 22:17:28 +0000 (22:17 -0000)]
Use safe read

20 years agoFix warning
Glenn L McGrath [Fri, 21 Nov 2003 21:54:07 +0000 (21:54 -0000)]
Fix warning

20 years agoMake use of libbb functions bb_xopen, bb_full_read, used #define's
Glenn L McGrath [Fri, 21 Nov 2003 09:27:02 +0000 (09:27 -0000)]
Make use of libbb functions bb_xopen, bb_full_read, used #define's
instead of static consts, avoid xmalloc.

20 years agoRemove unused function
Glenn L McGrath [Thu, 20 Nov 2003 22:36:57 +0000 (22:36 -0000)]
Remove unused function

20 years agoDont over-read fd, use function pointer for hash function.
Glenn L McGrath [Thu, 20 Nov 2003 21:30:58 +0000 (21:30 -0000)]
Dont over-read fd, use function pointer for hash function.

20 years agoFix tar-handles-nested-exclude testcase
Glenn L McGrath [Thu, 20 Nov 2003 10:47:06 +0000 (10:47 -0000)]
Fix tar-handles-nested-exclude testcase

20 years agoUpdate status of tests which should pass
Glenn L McGrath [Thu, 20 Nov 2003 09:57:44 +0000 (09:57 -0000)]
Update status of tests which should pass

20 years agoremove controversial tests
Glenn L McGrath [Thu, 20 Nov 2003 09:56:34 +0000 (09:56 -0000)]
remove controversial tests

20 years agoCheck at least one context is specified
Glenn L McGrath [Thu, 20 Nov 2003 09:53:31 +0000 (09:53 -0000)]
Check at least one context is specified

20 years agoCheck there are files to add the archive before removing a specified
Glenn L McGrath [Thu, 20 Nov 2003 09:06:10 +0000 (09:06 -0000)]
Check there are files to add the archive before removing a specified
tar file.

20 years agoDont attempt to unlink directories
Glenn L McGrath [Thu, 20 Nov 2003 08:00:38 +0000 (08:00 -0000)]
Dont attempt to unlink directories

20 years agoSuperficial changes
Glenn L McGrath [Thu, 20 Nov 2003 06:27:33 +0000 (06:27 -0000)]
Superficial changes

20 years agoFix up the -s option, and make usage consitent with behaviour,
Glenn L McGrath [Thu, 20 Nov 2003 05:58:26 +0000 (05:58 -0000)]
Fix up the -s option, and make usage consitent with behaviour,
patch by Steven Scholz

20 years agoInclude stdint.h
Glenn L McGrath [Thu, 20 Nov 2003 05:26:38 +0000 (05:26 -0000)]
Include stdint.h

20 years agowoops, we needed that function
Glenn L McGrath [Tue, 18 Nov 2003 23:56:41 +0000 (23:56 -0000)]
woops, we needed that function

20 years agoCOMPRESS, not UNCOMPRESS
Glenn L McGrath [Tue, 18 Nov 2003 23:27:49 +0000 (23:27 -0000)]
COMPRESS, not UNCOMPRESS

20 years agoUpdate usage for tar -Z
Glenn L McGrath [Tue, 18 Nov 2003 21:49:23 +0000 (21:49 -0000)]
Update usage for tar -Z

20 years agoUpdate md5sum, sha1sum options, patch by Steven Scholz
Glenn L McGrath [Tue, 18 Nov 2003 21:40:30 +0000 (21:40 -0000)]
Update md5sum, sha1sum options, patch by Steven Scholz

20 years agotar -Z, uncompress support
Glenn L McGrath [Tue, 18 Nov 2003 21:37:52 +0000 (21:37 -0000)]
tar -Z, uncompress support

20 years agoDont close original file handle, we may need it later.
Glenn L McGrath [Tue, 18 Nov 2003 21:31:19 +0000 (21:31 -0000)]
Dont close original file handle, we may need it later.

20 years agoMake unlink old files default behaviour and add a new option -k to
Glenn L McGrath [Tue, 18 Nov 2003 20:23:04 +0000 (20:23 -0000)]
Make unlink old files default behaviour and add a new option -k to
prevent overwritting existing files

20 years agoOnly use getopt and associated flags if checking is enabled
Glenn L McGrath [Tue, 18 Nov 2003 19:35:06 +0000 (19:35 -0000)]
Only use getopt and associated flags if checking is enabled

20 years agoReplaced by md5_sha1_sum.c
Glenn L McGrath [Tue, 18 Nov 2003 19:33:13 +0000 (19:33 -0000)]
Replaced by md5_sha1_sum.c

20 years agoReplaced by md5_sha1_sum.c
Glenn L McGrath [Tue, 18 Nov 2003 18:56:25 +0000 (18:56 -0000)]
Replaced by md5_sha1_sum.c

20 years agoDont free filename, its needed in the extracted files list.
Glenn L McGrath [Mon, 17 Nov 2003 21:58:00 +0000 (21:58 -0000)]
Dont free filename, its needed in the extracted files list.

20 years agoThis was made obsolete by config-udeb-linux-i386
Glenn L McGrath [Mon, 17 Nov 2003 10:46:36 +0000 (10:46 -0000)]
This was made obsolete by config-udeb-linux-i386

20 years agoRemove net-udeb flavour, we dotn use it
Glenn L McGrath [Mon, 17 Nov 2003 10:43:08 +0000 (10:43 -0000)]
Remove net-udeb flavour, we dotn use it

20 years agoUse the PROG variable instead of 'busybox' in the release target
Glenn L McGrath [Mon, 17 Nov 2003 10:26:43 +0000 (10:26 -0000)]
Use the PROG variable instead of 'busybox' in the release target

20 years agoFix a bug where cpio wouldnt work unless -u was specified
Glenn L McGrath [Sat, 15 Nov 2003 23:44:31 +0000 (23:44 -0000)]
Fix a bug where cpio wouldnt work unless -u was specified

20 years agoMove from read_gz to the pipe()+fork() method.
Glenn L McGrath [Sat, 15 Nov 2003 23:19:05 +0000 (23:19 -0000)]
Move from read_gz to the pipe()+fork() method.
open_transformer(), common code for pipe+fork.
Function pointer for read() no longer needed.
Allow inflate to be initialised with a specified buffer size to avoid
over-reading.
Reset static variables in inflate_get_next_window to fix a bug where
only the first file in a .zip would be be extracted.

20 years agoFix memory leaks
Glenn L McGrath [Sat, 15 Nov 2003 00:24:43 +0000 (00:24 -0000)]
Fix memory leaks

20 years agoFix a "broken pipe" problem. vodz, last_patch_116-2
Glenn L McGrath [Fri, 14 Nov 2003 21:01:26 +0000 (21:01 -0000)]
Fix a "broken pipe" problem. vodz, last_patch_116-2

20 years agoKeep trying to find a good header, if we exit it will cause .tar.gz
Glenn L McGrath [Fri, 14 Nov 2003 12:57:14 +0000 (12:57 -0000)]
Keep trying to find a good header, if we exit it will cause .tar.gz
files to compute incorrect crc and length for gzip

20 years agoCatch unsupported features
Glenn L McGrath [Fri, 14 Nov 2003 12:53:42 +0000 (12:53 -0000)]
Catch unsupported features

20 years agoNEW APPLET: pipe_progress, used by debian installer
Glenn L McGrath [Fri, 14 Nov 2003 10:04:33 +0000 (10:04 -0000)]
NEW APPLET: pipe_progress, used by debian installer

20 years agoFix build error with tar -j
Glenn L McGrath [Fri, 14 Nov 2003 09:22:24 +0000 (09:22 -0000)]
Fix build error with tar -j

20 years agoRemove some tar_gz stuff that get dragged in
Glenn L McGrath [Fri, 14 Nov 2003 09:21:27 +0000 (09:21 -0000)]
Remove some tar_gz stuff that get dragged in

20 years agoRemove debugging noise.
Glenn L McGrath [Fri, 14 Nov 2003 08:30:46 +0000 (08:30 -0000)]
Remove debugging noise.

20 years agoRead in blocks rather than one char at a time, greatly improves speed
Glenn L McGrath [Fri, 14 Nov 2003 08:26:25 +0000 (08:26 -0000)]
Read in blocks rather than one char at a time, greatly improves speed

20 years agoOskar Liljeblad writes:
Eric Andersen [Fri, 14 Nov 2003 03:11:29 +0000 (03:11 -0000)]
Oskar Liljeblad writes:

Here's a fix for the hard-coded device name in fbset.

20 years agoMichael Smith writes:
Eric Andersen [Fri, 14 Nov 2003 03:04:08 +0000 (03:04 -0000)]
Michael Smith writes:

I noticed a problem with ifconfig in busybox 0.60.5. The matching code
seems to exist in busybox CVS as well, so I'll paste in the patch that
fixed it.

I was running:
 # ifconfig wan0 1.2.3.4 pointopoint 1.2.3.5 netmask 255.255.255.255

I was seeing the inet addr and P-t-P addr both being set to 1.2.3.5
(the pointopoint address).

wan0      Link encap:Point-Point Protocol
          inet addr:1.2.3.5  P-t-P:1.2.3.5  Mask:255.255.255.255
          UP POINTOPOINT RUNNING NOARP  MTU:1500  Metric:1
          ...

The patch below seems to fix it.

20 years agoUlrich Marx writes:
Eric Andersen [Fri, 14 Nov 2003 03:00:04 +0000 (03:00 -0000)]
Ulrich Marx writes:

hello

i had some trouble with the filedescriptor in udhcp.
Two things happened on my device:
1.) broken or not connected cable (no dhcp-server)
2.) daemonizing (starting with option -b)

i got a filedescriptor fd=0 from function raw_socket,
after daemonizing (daemon call) the fd is closed.
Client can't recieve data's anymore.

i fixed this problem (like pidfile handling):

20 years agoSteven Seeger writes:
Eric Andersen [Fri, 14 Nov 2003 02:49:19 +0000 (02:49 -0000)]
Steven Seeger writes:

Hey guys. I've found a bug in modprobe where it generates bad strings and
makes sytem calls with them. The following patch seems to have fixed the
problem. It is rather inherited elsewhere, as there seems to be incorrect
entries in the list which results in more dependencies than really exist for
a given call to mod_process. But, this patch prevents the bad text from
going to the screen. You will notice there are cases where lcmd goes
unmodified before calling system.

Please consider the following patch.

Thanks.

-Steve

20 years agoVladimir N. Oleynik (vodz) writes:
Eric Andersen [Fri, 14 Nov 2003 02:44:28 +0000 (02:44 -0000)]
Vladimir N. Oleynik (vodz) writes:

Hi Glenn.

I analysed BSS size gzip applet and found may be mistake:
updcrc() checking  if (crc_table_empty) but not resetted this var.
This do make slow gzip applet ;-)

--w
vodz

20 years agoMarc Kleine-Budde noticed a missing semicolon
Eric Andersen [Fri, 14 Nov 2003 02:40:08 +0000 (02:40 -0000)]
Marc Kleine-Budde noticed a missing semicolon

20 years agoMerge common parts of sha1sum and md5sum, which is everything except the
Glenn L McGrath [Mon, 10 Nov 2003 04:33:55 +0000 (04:33 -0000)]
Merge common parts of sha1sum and md5sum, which is everything except the
algorithms.
Move algorithms to hash_fd and make them available via a common
function.

20 years agoAdd some basic cvs usage info
Eric Andersen [Sat, 8 Nov 2003 00:33:02 +0000 (00:33 -0000)]
Add some basic cvs usage info

20 years agoRob Landley writes:
Eric Andersen [Sat, 8 Nov 2003 00:23:23 +0000 (00:23 -0000)]
Rob Landley writes:

Remove three entries in defconfig that config no longer has.

Rob

20 years agoPatch from Steven Scholz to send the output from 'time'
Eric Andersen [Fri, 7 Nov 2003 21:39:14 +0000 (21:39 -0000)]
Patch from Steven Scholz to send the output from 'time'
to stderr, rather than stdout, so that things like

~ # time bunzip2 -c /tmp/test.bz2 > /dev/null
real    0m 29.44s
user    0m 29.30s
sys     0m 0.12s

operate as expected.

20 years agoThis appears to be the correct fix to make CONFIG_FEATURE_DEB_TAR_BZ2
Eric Andersen [Fri, 7 Nov 2003 21:31:58 +0000 (21:31 -0000)]
This appears to be the correct fix to make CONFIG_FEATURE_DEB_TAR_BZ2
support compile.  Glenn, you may want to verify this.
 -Erik

20 years agofix comment
Eric Andersen [Fri, 7 Nov 2003 21:22:09 +0000 (21:22 -0000)]
fix comment

20 years agowrap bb help output if CONFIG_FEATURE_AUTOWIDTH
Tim Riker [Fri, 7 Nov 2003 19:37:20 +0000 (19:37 -0000)]
wrap bb help output if CONFIG_FEATURE_AUTOWIDTH

20 years agoAs vodz pointed out, setting unset_env to NULL is sufficient
Eric Andersen [Fri, 7 Nov 2003 11:20:21 +0000 (11:20 -0000)]
As vodz pointed out, setting unset_env to NULL is sufficient