Daniel Stone [Wed, 14 Mar 2012 17:05:09 +0000 (17:05 +0000)]
Add xkb_get_syms_by_level
Which allows you to pass in a group and a level rather than a
fully-formed state.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Wed, 14 Mar 2012 17:04:36 +0000 (17:04 +0000)]
Fix leak in xkbcomp.c
Accidentally regressed this one briefly, oops.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Wed, 14 Mar 2012 11:59:52 +0000 (11:59 +0000)]
Remove component listing code
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Wed, 14 Mar 2012 11:58:24 +0000 (11:58 +0000)]
Remove unused control members
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Wed, 14 Mar 2012 11:56:59 +0000 (11:56 +0000)]
Add a tiny bit of documentation to xkbcommon.h
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Tue, 13 Mar 2012 19:06:05 +0000 (19:06 +0000)]
Add xkb_key_get_syms API
(And a slight cosmetic header reformatting.)
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Tue, 13 Mar 2012 12:46:37 +0000 (12:46 +0000)]
Revert "Use XKB_COMMON_* modifier defines in ExprResolveModMask"
Because indices and masks are not at all the same thing.
This reverts commit
645275406f47369c9a67d02173aedf89e9d2a33c.
Daniel Stone [Sat, 10 Mar 2012 14:42:30 +0000 (14:42 +0000)]
Use XKB_COMMON_* modifier defines in ExprResolveModMask
Rather than the ones from XKB.h.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 10 Mar 2012 14:36:30 +0000 (14:36 +0000)]
Remove overlay support as well
Right now we just silently ignore overlay controls, which is probably
bad, but it's not the easiest to fix.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 10 Mar 2012 14:27:06 +0000 (14:27 +0000)]
Remove half-implemented radio groups
It looks like this could never have worked anyway, what with num_rg
always being 0 everywhere. Remove it.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 10 Mar 2012 14:08:43 +0000 (14:08 +0000)]
Remove indirect XkbCM* and XkbSM* macros
The XkbKey* macros used to work through XkbCM* and XkbSM* variants, for
the xkb_map and xkb_server_map respectively; the latter versions weren't
used by anyone at all, so just bin them and make the macros work
directly.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 10 Mar 2012 13:54:03 +0000 (13:54 +0000)]
Handle XkbFiles without a name
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 10 Mar 2012 13:48:13 +0000 (13:48 +0000)]
Move allocation of xkb_desc into CompileKeymap
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 20:01:33 +0000 (20:01 +0000)]
Clean up xkb_keysym_to_string message
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 19:29:29 +0000 (19:29 +0000)]
Remove geometry even harder
Not the most elegant fix, but will do for now.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 19:09:25 +0000 (19:09 +0000)]
Introduce xkb_atom_t type
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 19:03:59 +0000 (19:03 +0000)]
Introduce xkb_keysym_t type
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 18:57:14 +0000 (18:57 +0000)]
Remove atom functions from public API
They're no longer needed since we don't expose any atoms in the
published API anymore. As a result, we don't need to support external
atom implementations either. Result!
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 18:53:47 +0000 (18:53 +0000)]
Stringify public name types
Ensure that all names under xkb_desc are strings, rather than atoms.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 18:46:46 +0000 (18:46 +0000)]
Ensure we always have a complete keymap
Refuse to compile without keycodes + compat + types + symbols.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:57:09 +0000 (16:57 +0000)]
filecomp: Fix xkbcomp warning
Ironically, the test for named.xkb included a call that relied on the
default keymap, without the file naming an explicit default. Go figure.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:55:37 +0000 (16:55 +0000)]
Convert CompileKeymap to early-return style
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:54:47 +0000 (16:54 +0000)]
Use compile_keymap in xkb_compile_keymap_from_components
We already had this exact function sitting right next to us, so use it
rather than open-coding.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:32:45 +0000 (16:32 +0000)]
Add explicit braces
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:31:48 +0000 (16:31 +0000)]
xkbcomp: Turn an array into an anonymous struct
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:26:34 +0000 (16:26 +0000)]
Remove geometry support, again
It still parses geometry, but happily throws it away.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Fri, 9 Mar 2012 16:04:00 +0000 (16:04 +0000)]
Remove KcCGST names from the map
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 5 Mar 2012 15:07:28 +0000 (15:07 +0000)]
Merge remote-tracking branch 'ran/fixes-cont'
Conflicts:
src/xkbcomp/expr.c
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 5 Mar 2012 15:00:39 +0000 (15:00 +0000)]
Merge remote-tracking branch 'ran/fixes'
Ran Benita [Sat, 3 Mar 2012 21:42:44 +0000 (23:42 +0200)]
Fix "Could not resolve keysym" errors
On many layouts, the following error appears:
Internal error: Could not resolve keysym 10005b0
(Which is like the trademark of libxkbcommon now, and makes
unicode-heavy symbol files pretty useless).
This occurs when a keysym string (in this case, 10005b0) is passed to
xkb_string_to_keysym, but cannot be resolved.
This in turn happens because the parser passes on hexadecimal keysym
strings without the leading "0x", thus leaving the resolving function
without a way to disambiguate it as a number.
Therefore, make sure to pass on the "0x". The file symbols.c in xkbcomp
project does the same; it probably got lost in translation.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 3 Mar 2012 20:43:50 +0000 (22:43 +0200)]
Refactor XkbFindFileInPath
Also fixes a bug, where the check (typeLen < 1) should have been
(pathLen < 1).
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 18:41:34 +0000 (20:41 +0200)]
Free all atoms along with keymap
The code to do this is taken from xserver, dix/atom.c.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 19:03:37 +0000 (21:03 +0200)]
Free IncludePath when no longer needed
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 19:03:13 +0000 (21:03 +0200)]
Free scanFile when no longer needed
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 23:17:21 +0000 (01:17 +0200)]
Fix other misc leaks
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 18:44:42 +0000 (20:44 +0200)]
Don't leak the scanner's buffer
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 17:45:37 +0000 (19:45 +0200)]
Don't leak DoodadInfo's from GeometryInfo
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 17:25:37 +0000 (19:25 +0200)]
Don't leak ActionInfo's
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 22:10:37 +0000 (00:10 +0200)]
Don't leak KeyNamesInfo
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 19:57:15 +0000 (21:57 +0200)]
Don't leak the "minimum"/"maximum" string
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 19:26:25 +0000 (21:26 +0200)]
Don't leak the various *Info's names when overriding them
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 12:49:36 +0000 (14:49 +0200)]
Free XkbFile's when no longer needed
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 19:20:45 +0000 (21:20 +0200)]
Add function to free XkbFile's
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 08:46:41 +0000 (10:46 +0200)]
Don't cache loaded rules files
This needlessly occupies memory for the lifetime of the library, and
does not make a noticeable difference otherwise.
This rules file won't be loaded more than once in most cases anyway, so
just load it again when it happens.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 07:59:25 +0000 (09:59 +0200)]
Don't cache parsed files
This needlessly occupies memory for the lifetime of the library, and
does not make a noticeable difference otherwise.
Instead, just parse the same file again when it happens.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 13:56:03 +0000 (15:56 +0200)]
Remove unneeded freeing mechanisms
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 20:36:32 +0000 (22:36 +0200)]
Make the sections array local to the keymap compiling function
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 20:34:14 +0000 (22:34 +0200)]
Remove unused global type tokens
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 15:25:58 +0000 (17:25 +0200)]
Use global tables for action string handling
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 20:31:29 +0000 (22:31 +0200)]
Constify some more text functions
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 15:40:19 +0000 (17:40 +0200)]
Constify global tables
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 14:12:18 +0000 (16:12 +0200)]
Use limits.h to find min/max short value
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 19:26:28 +0000 (21:26 +0200)]
Remove useless casts
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 2 Mar 2012 23:15:56 +0000 (01:15 +0200)]
Use strchr instead of index
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 18:50:17 +0000 (20:50 +0200)]
Use memset instead of bzero
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 1 Mar 2012 21:43:51 +0000 (23:43 +0200)]
Remove return's at the end of void functions
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 18:25:11 +0000 (20:25 +0200)]
Remove all uses of the register keyword
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 18:12:17 +0000 (20:12 +0200)]
Use strdup instead of strlen + malloc + strcpy
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Wed, 29 Feb 2012 17:56:39 +0000 (19:56 +0200)]
Don't check for NULL before free()
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Thu, 23 Feb 2012 17:26:33 +0000 (19:26 +0200)]
Use yacc-generated header instead of tokens.h
The yacc implementation can generate all the necessary token
definitions itself; there is no need to maintain a hand written
file for that.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 22:03:24 +0000 (00:03 +0200)]
makekeys: update to match the rest of libX11 makekeys
This integrates two commits from libX11:
ebd6ef0a4db0ddef0ae17ad14571518ccdeea5ba
XStringToKeysym: Special case for XF86 keysyms
Some XFree86 keysyms were in XKeysymDB as XF86_foo, despite really being
XF86foo. So, if we get to the bottom of XStringToKeysym and haven't
found our XF86_foo, try it again as XF86foo.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
00175397480b76d32bf82b0c7c94c91a2a95954e
makekeys: Scan vendor keysyms as well as core
Since we can't really live without vendor keysyms, scan them all in to
generate ks_tables.h, rather than only doing the core ones, and leaving
the vendor syms to be manually synchronised with XKeysymDB.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Notice that the xkey.sh test is changed to match libX11 behavior, i.e.
XKeysymToString(0x1008FE20) -> "XF86Ungrab" as opposed to "XF86_Ungrab".
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 21:17:47 +0000 (23:17 +0200)]
makekeys: Receive the keysym files as arguments
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 19:13:26 +0000 (21:13 +0200)]
When makekeys fails to find a good hash, print error instead of divide-by-zero
This matches commit
78a894231ae8ec4959007b6d9b8d2a15d6333a1e from
libX11:
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 19:09:28 +0000 (21:09 +0200)]
makekeys: Fix build/target word size mismatch when cross-compiling
This matches commit
24283d40b1e4314c6647dda49d2a159833341a8b from
libX11:
Since makekeys is built using build environment's compiler and
runs natively, we have to make sure that the size of the
Signature type is the same on both the native environment
and the target, otherwise we get mismatches upon running X,
and some LSB test failures (xts5).
Use an unsigned 32-bit integer on all platforms.
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 14:10:06 +0000 (16:10 +0200)]
Fix remaining warnings
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 09:53:01 +0000 (11:53 +0200)]
Fix warnings in scanner and parser
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 14:08:55 +0000 (16:08 +0200)]
Fix an incorrect sizeof
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 14:07:17 +0000 (16:07 +0200)]
Fix all constness warnings
These are all trivial/obvious fixes which clear a bunch of warnings.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 14:03:44 +0000 (16:03 +0200)]
Fix possible null dereferences
Fix all reported null dereferences from clang-analyzer.
There seems to be one false negative (in file indicators.c), but it is
fixed anyway.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 14:00:10 +0000 (16:00 +0200)]
Remove unneeded assignments and variables
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 13:55:45 +0000 (15:55 +0200)]
makekeys: clear const and shadow warnings
The name 'index' is used by the standard library, so use 'ndx' like some
other files.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 13:53:08 +0000 (15:53 +0200)]
makekeys: make buf local to main()
All the functions already accept it as a parameter. This clears -Wshadow
warnings.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 13:51:31 +0000 (15:51 +0200)]
Remove ancient compatibility check
Other headers include malloc just fine.
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Sat, 25 Feb 2012 09:46:12 +0000 (11:46 +0200)]
Remove unused includes of "tokens.h"
Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita [Fri, 24 Feb 2012 08:04:16 +0000 (10:04 +0200)]
Remove unused debug #defines
Signed-off-by: Ran Benita <ran234@gmail.com>
Daniel Stone [Mon, 20 Feb 2012 18:07:29 +0000 (18:07 +0000)]
Perform bounds checking in ExprResolveLevel
Both callers perform the same bounds check, so move it into
ExprResolveLevel itself.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:47:46 +0000 (17:47 +0000)]
Fix typo in ExprResolveKeyCode
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:33:39 +0000 (17:33 +0000)]
Perform bounds checking in ExprResolveGroup
Every caller did the exact same check on the group bounds after calling
ExprResolveGroup, so might as well do it inside.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:14:04 +0000 (17:14 +0000)]
Switch expression resolution priv from char to void
Avoids a lot of really lame casts.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:09:06 +0000 (17:09 +0000)]
Remove chaining support from LookupModMask
Turns out we never use it, so.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:07:48 +0000 (17:07 +0000)]
Invert LookupModMask/LookupVModMask order
We never want to solely lookup a virtual modifier without also looking
up core modifiers. So, rather than chaining the vmod lookup inside the
core modifier lookup, invert the ordering.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 17:00:51 +0000 (17:00 +0000)]
Remove unused LookupPriv::priv
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 16:59:51 +0000 (16:59 +0000)]
Move some definitions from expr.h to expr.c
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 16:54:54 +0000 (16:54 +0000)]
Remove field reference lookup support
None of the lookup functions anyone ever used supported field
references, so don't pretend we do in the API.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 16:35:39 +0000 (16:35 +0000)]
Move groupNames mask definition to its user
groupNames was declared in compat.c as a global to anything which
included compat.h (for which groupNames was its sole reason to exist),
but only ever used in indicators.c.
Which is kind of fortunate, given that
e314931e removed identical
definitions of groupNames (as integers, not masks) from both action.c
and symbols.c.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 16:24:02 +0000 (16:24 +0000)]
Turn ExprResolveInteger into a simple wrapper
Move the bulk of ExprResolveInteger into an internal function called
ExprResolveIntegerLookup, and introduce ExprResolveInteger as a simple
wrapper which doesn't take priv/lookup arguments.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 16:04:37 +0000 (16:04 +0000)]
Open-code a radio group SimpleLookup
Because, joke's on you, it wasn't actually looking up radio groups.
Just checking to see if it was a string that was "none", or an integer.
Lord give me strength.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 15:47:57 +0000 (15:47 +0000)]
Add ExprResolveGroup helper
Just a dumb wrapper around ExprResolveInteger.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 15:47:38 +0000 (15:47 +0000)]
Add ExprResolveButton helper
Just a dumb wrapper around ExprResolveInteger.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 15:37:53 +0000 (15:37 +0000)]
Introduce ExprResolveLevel helper
Which returns an integer representing the level number represented by
the given expression.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 15:33:40 +0000 (15:33 +0000)]
Introduce ExprResolveRadioGroup helper
Just a tiny special-cased version of ExprResolveInteger.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 14:15:08 +0000 (14:15 +0000)]
Remove priv arguments from ExprResolveString
They've never been used.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 14:10:41 +0000 (14:10 +0000)]
Remove priv arguments from ExprResolveKeySym
They've never been used by its one caller.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 14:08:55 +0000 (14:08 +0000)]
Remove priv arguments from ExprResolveKeyName
They've never been used.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 13:44:27 +0000 (13:44 +0000)]
Remove priv arguments from ExprResolveBoolean
They've never been used.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 13:40:34 +0000 (13:40 +0000)]
Remove priv arguments from ExprResolveFloat
They've never been used.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 13:34:36 +0000 (13:34 +0000)]
Remove priv arguments from ExprResolveModMask
What with them now being unused and all.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Mon, 20 Feb 2012 13:32:09 +0000 (13:32 +0000)]
Introduce ExprResolveVModMask
Which is just a slightly more typesafe wrapper around the chained
ExprResolveModMask everyone was using earlier.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Thu, 16 Feb 2012 11:18:49 +0000 (11:18 +0000)]
Respect explicit minimum/maximum keycodes
Make sure we carry over an explicit minimum/maximum keycode setting,
rather than just using the computed minimum/maximum; this got broken
while changing the keycode range to be unsigned.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Reported-by: Pekka Paalanen <ppaalanen@gmail.com>
Daniel Stone [Thu, 16 Feb 2012 00:22:11 +0000 (00:22 +0000)]
Still more memory leak fixes
Signed-off-by: Daniel Stone <daniel@fooishbar.org>