twiz@google.com [Thu, 19 Jul 2012 22:09:19 +0000 (22:09 +0000)]
Addition of new-lines at end of files to correct Chromium builds.
Review URL: https://codereview.appspot.com/6423061
git-svn-id: http://skia.googlecode.com/svn/trunk@4683
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 19 Jul 2012 21:00:07 +0000 (21:00 +0000)]
Fixing heap corruption issue in deferred canvas when using SkGPipe.
Swapping the declaration order of fPipeController and fPipeWriter to
make sure that the writer is destroyed first before the controller.
Review URL: https://codereview.appspot.com/6427054
git-svn-id: http://skia.googlecode.com/svn/trunk@4682
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 19 Jul 2012 20:51:32 +0000 (20:51 +0000)]
Rebaseline after enabling bilinear filtering for gpu linear gradients.
git-svn-id: http://skia.googlecode.com/svn/trunk@4681
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 19 Jul 2012 19:42:10 +0000 (19:42 +0000)]
Make GPU linear gradients do bilinear filtering.
This will require GM (and webkit) rebaselines.
Review URL: https://codereview.appspot.com/6431048
git-svn-id: http://skia.googlecode.com/svn/trunk@4680
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 19 Jul 2012 18:01:07 +0000 (18:01 +0000)]
Create GL implementation for GrSingleTextureEffect, use it instead of GrPaint::setTexture()
or GrDrawState::setTexture() in GrContext.cpp
http://codereview.appspot.com/6399053/
git-svn-id: http://skia.googlecode.com/svn/trunk@4677
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 19 Jul 2012 17:35:04 +0000 (17:35 +0000)]
skdiff output: indicate which result types would cause failure
Review URL: https://codereview.appspot.com/6419053
git-svn-id: http://skia.googlecode.com/svn/trunk@4676
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 19 Jul 2012 17:31:34 +0000 (17:31 +0000)]
Rebaseline for slight changes in linear gradient behavior.
git-svn-id: http://skia.googlecode.com/svn/trunk@4675
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 19 Jul 2012 15:16:19 +0000 (15:16 +0000)]
New subclasses for both Gr and GrGL gradient effect classes.
This replaces GrSingleTextureEffect as the base for gradient effects (so we'll be able to do gradient effects without textures), and adds a base class to the GL gradient custom stage implementations (which will soon handle generating the appropriate code to pass colors in and lerp instead of using a cached texture for simpler gradient cases).
Also added a custom stage for linear gradients.
Review URL: https://codereview.appspot.com/6426049
git-svn-id: http://skia.googlecode.com/svn/trunk@4674
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 19 Jul 2012 14:57:19 +0000 (14:57 +0000)]
Rebaseline Xoom
Review URL: https://codereview.appspot.com/6416048
git-svn-id: http://skia.googlecode.com/svn/trunk@4672
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 19 Jul 2012 14:12:24 +0000 (14:12 +0000)]
Temporarily remove giantbitmap gpu GM baselines on Xoom
These are drawing black boxes.
Review URL: https://codereview.appspot.com/6423055
git-svn-id: http://skia.googlecode.com/svn/trunk@4671
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 19 Jul 2012 14:10:17 +0000 (14:10 +0000)]
Rebaseline Nexus S images
These haven't been updated in a long time.
Review URL: https://codereview.appspot.com/6428051
git-svn-id: http://skia.googlecode.com/svn/trunk@4670
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 19 Jul 2012 13:48:14 +0000 (13:48 +0000)]
Fixed glaring typo in SkDebuggerGUI.cpp, unreviewed.
BUG=
TEST=
Review URL: https://codereview.appspot.com/6423052
git-svn-id: http://skia.googlecode.com/svn/trunk@4669
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 19 Jul 2012 13:41:27 +0000 (13:41 +0000)]
Quick bug fix that was rendering debugger unusable.
Review URL: https://codereview.appspot.com/6422050
git-svn-id: http://skia.googlecode.com/svn/trunk@4668
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 19 Jul 2012 13:25:27 +0000 (13:25 +0000)]
Temporarily remove giantbitmap gpu GMs on Nexus S
These are just drawing a black box.
Review URL: https://codereview.appspot.com/6419051
git-svn-id: http://skia.googlecode.com/svn/trunk@4667
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 19 Jul 2012 13:08:33 +0000 (13:08 +0000)]
Temporarily remove GMs failing on Nexus S
These are failing as of r4663
Review URL: https://codereview.appspot.com/6428049
git-svn-id: http://skia.googlecode.com/svn/trunk@4666
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 18 Jul 2012 21:50:26 +0000 (21:50 +0000)]
Improving CanvasTest to verify that the destination canvas of an SkDeferredCanvas has the same state as a plain SkCanvas that received the same draw commands.
This new test code shows that the SkGPipe port of SkDeferredCanvas solves problems we were having with SkPicture.
Review URL: https://codereview.appspot.com/6425048
git-svn-id: http://skia.googlecode.com/svn/trunk@4665
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Wed, 18 Jul 2012 21:47:40 +0000 (21:47 +0000)]
Move texture lock/unlock functions from SkGpuDevice into SkGr as global functions, also removed inconsistent "SkGr" class.
Review URL: https://codereview.appspot.com/6420048
git-svn-id: http://skia.googlecode.com/svn/trunk@4664
2bbb7eff-a529-9590-31e7-
b0007b416f81
twiz@google.com [Wed, 18 Jul 2012 21:41:50 +0000 (21:41 +0000)]
This CL implements the Ganesh path for the SkTable_ColorFilter color transformation.
A new texture stage dedicated to color transforms has been added, along with the new custom stage implementing the LUT.
Review URL: https://codereview.appspot.com/6351081
git-svn-id: http://skia.googlecode.com/svn/trunk@4663
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 18 Jul 2012 21:23:40 +0000 (21:23 +0000)]
Update download_baselines.py
No longer using *-fixed
Added Android
Review URL: https://codereview.appspot.com/6428047
git-svn-id: http://skia.googlecode.com/svn/trunk@4662
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 18 Jul 2012 20:22:52 +0000 (20:22 +0000)]
Adding virtual overload of isDrawingToLayer() to SkGPipe
This change is to make The SkGPipe port of SkDeferredCanvas pass the CanvasTest unit test
Review URL: https://codereview.appspot.com/6426046
git-svn-id: http://skia.googlecode.com/svn/trunk@4661
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 18 Jul 2012 19:52:53 +0000 (19:52 +0000)]
Clean up the use of AutoScratchTexture in the gaussian blur and morphology
filters. Instead of passing in AutoScratchTextures for temporaries, we allocate
them inside the function and detach() after rendering. Since the functions now
return a ref()'ed texture, we no longer ref() the result in filter_texture().
Also, the imageblur gm was passing a paint with an image filter both to
saveLayer()/restore(), and to every text draw call. Back when only restore()
was applying filters, this was fine, but since we're now applying filters on all
draw calls, this means we're double-blurring in this GM.
I've reverted the Mac baselines for the imageblur GM to their previous versions;
hopefully this will be correct.
git-svn-id: http://skia.googlecode.com/svn/trunk@4659
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 18 Jul 2012 18:53:28 +0000 (18:53 +0000)]
Add SK_API for SkData. Needed for https://bugs.webkit.org/show_bug.cgi?id=91171
Review URL: https://codereview.appspot.com/6420047
git-svn-id: http://skia.googlecode.com/svn/trunk@4658
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 18 Jul 2012 18:25:07 +0000 (18:25 +0000)]
Fix grdrawstate == test when left side has disabled stage and right side does not
Review URL: http://codereview.appspot.com/6427044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4657
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 18 Jul 2012 17:54:45 +0000 (17:54 +0000)]
Refactoring SkDeferredCanvas to use SkGPipe.
Keeping the refactor hidden behind a config macro for now.
TEST=covered by existing skia gm tests
BUG=https://code.google.com/p/chromium/issues/detail?id=133432
Review URL: https://codereview.appspot.com/6405054
git-svn-id: http://skia.googlecode.com/svn/trunk@4656
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 18 Jul 2012 15:13:30 +0000 (15:13 +0000)]
whitespace change to trigger Skia buildbots after master update/restart
git-svn-id: http://skia.googlecode.com/svn/trunk@4654
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 18 Jul 2012 14:59:54 +0000 (14:59 +0000)]
Enable Compile Option to Build Android Executables
Since we can't debug APKs on 4.1, we sometimes need to
build Skia the old way for Android. This CL enables
a switch to do so.
Review URL: https://codereview.appspot.com/6408053
git-svn-id: http://skia.googlecode.com/svn/trunk@4653
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 18 Jul 2012 13:45:58 +0000 (13:45 +0000)]
Need to apply matrix to advance in generateAdvance (as we already were in generateMetrics)
Fixes b/6833339
Expand existing unittest to detect this (we needed to set both scale and skew on the paint)
git-svn-id: http://skia.googlecode.com/svn/trunk@4647
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 18 Jul 2012 13:20:29 +0000 (13:20 +0000)]
Factory method for creating GrGLProgram
Review URL: http://codereview.appspot.com/6407049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4646
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 18 Jul 2012 12:06:15 +0000 (12:06 +0000)]
Add skipToLast method to SkClipStack
http://codereview.appspot.com/6411043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4644
2bbb7eff-a529-9590-31e7-
b0007b416f81
alokp@chromium.org [Tue, 17 Jul 2012 19:10:36 +0000 (19:10 +0000)]
Exported SkFILEWStream class so that it can be used in Chrome.
Review URL: https://codereview.appspot.com/6409052
git-svn-id: http://skia.googlecode.com/svn/trunk@4643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 17 Jul 2012 19:07:35 +0000 (19:07 +0000)]
Fix build breakage in r4641.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@4642
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 17 Jul 2012 18:43:21 +0000 (18:43 +0000)]
Move texture domains onto a GrCustomStage, off of GrSamplerState.
This will require gyp changes to roll into Chrome.
http://codereview.appspot.com/6405050/
git-svn-id: http://skia.googlecode.com/svn/trunk@4641
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 17 Jul 2012 18:27:03 +0000 (18:27 +0000)]
Update docs and trunk dirs if they exist overriding any local merge conflicts.
Created to fix bug http://code.google.com/p/skia/issues/detail?id=710 :
housekeeping buildbot: conflict in UpdateDoxygen step.
git-svn-id: http://skia.googlecode.com/svn/trunk@4640
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 17 Jul 2012 16:49:40 +0000 (16:49 +0000)]
Use SkFlatDictionary in SkGPipe to take advantage of its new features.
Add a controller class to perform the allocation/unallocation for the dictionary and to provide an entry to be replaced, if replacements are allowed.
TODO:
Use LRU caching in my custom controller so replacements will be done less often.
More refactoring on SkFlatDictionary so picture recording's use of the dictionary does not require going through the path to replace.
Review URL: https://codereview.appspot.com/6345102
git-svn-id: http://skia.googlecode.com/svn/trunk@4639
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 17 Jul 2012 16:10:34 +0000 (16:10 +0000)]
Purge bitmaps from SkGPipe's shared heap.
BitmapInfo:
Now in SkGPipePriv so it can be accessed by SkGPipeRead.
Add the ability to essentially ref count BitmapInfos so that they can
be purged to make room in the shared heap for a new one.
SkGPipeWrite:
Purge the least recently used bitmap if it has already been drawn by
all readers.
SkGPipeRead:
Read the BitmapInfo (instead of the SkBitmap) and decrement its count
after drawing.
SkGPipeController:
Added a method to tell how many readers will be used, so that when
purging bitmaps each reader can be accounted for.
Review URL: https://codereview.appspot.com/6374065
git-svn-id: http://skia.googlecode.com/svn/trunk@4638
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Tue, 17 Jul 2012 15:40:51 +0000 (15:40 +0000)]
Added more features to deletes and breakpoints
Review URL: https://codereview.appspot.com/6406050
git-svn-id: http://skia.googlecode.com/svn/trunk@4637
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 17 Jul 2012 15:37:15 +0000 (15:37 +0000)]
Fixed simpleaaclip gm - it wasn't showing xor case
http://codereview.appspot.com/6402055/
This CL will require image rebaselining
git-svn-id: http://skia.googlecode.com/svn/trunk@4636
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 17 Jul 2012 12:13:56 +0000 (12:13 +0000)]
remove Symbian (not needed) flag, and assume all CPUs *except* thumb have fast
conditional instructions.
git-svn-id: http://skia.googlecode.com/svn/trunk@4635
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Jul 2012 21:20:03 +0000 (21:20 +0000)]
Fixed two sub-optimal iterator uses
http://codereview.appspot.com/6409048/
git-svn-id: http://skia.googlecode.com/svn/trunk@4633
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Mon, 16 Jul 2012 19:20:14 +0000 (19:20 +0000)]
bench_pictures now has an option for benchmarking record time.
Review URL: https://codereview.appspot.com/6350102
git-svn-id: http://skia.googlecode.com/svn/trunk@4632
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Jul 2012 18:52:29 +0000 (18:52 +0000)]
Extended SkDeque's reverse iteration capability to SkClipStack
http://codereview.appspot.com/6409046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4631
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Mon, 16 Jul 2012 18:35:23 +0000 (18:35 +0000)]
Cleaned up icons, added keyboard shortcuts to everything
Keyboard Shortcuts and Menu reordering
Review URL: https://codereview.appspot.com/6400051
git-svn-id: http://skia.googlecode.com/svn/trunk@4630
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 16 Jul 2012 18:01:06 +0000 (18:01 +0000)]
skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of return value
Review URL: https://codereview.appspot.com/6409045
git-svn-id: http://skia.googlecode.com/svn/trunk@4629
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Jul 2012 17:54:26 +0000 (17:54 +0000)]
Fix test break in r4627.
git-svn-id: http://skia.googlecode.com/svn/trunk@4628
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Jul 2012 17:36:28 +0000 (17:36 +0000)]
Remove GrGLProgram::CachedData, make GrGLProgram represent the program
Review URL: http://codereview.appspot.com/6409043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4627
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Mon, 16 Jul 2012 17:29:16 +0000 (17:29 +0000)]
Added pipe as a rendering option for render_pictures.
I will add tiling as a rendering option and then figure out a way to not have the code duplicated between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6392066
git-svn-id: http://skia.googlecode.com/svn/trunk@4626
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Jul 2012 17:19:21 +0000 (17:19 +0000)]
fix for non-Windows-specific compiler error in r4624
git-svn-id: http://skia.googlecode.com/svn/trunk@4625
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 16 Jul 2012 16:58:49 +0000 (16:58 +0000)]
Refactor SkDeque's iterator and allocation method
http://codereview.appspot.com/6353098/
git-svn-id: http://skia.googlecode.com/svn/trunk@4624
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 16 Jul 2012 16:51:28 +0000 (16:51 +0000)]
Add a skia method to perform an atomic add.
Complements sk_atomic_inc for when you want to increase by more than one.
This time, use the correct atomic add function on Windows.
Reviewed at https://codereview.appspot.com/6399050/
Review URL: https://codereview.appspot.com/6407048
git-svn-id: http://skia.googlecode.com/svn/trunk@4623
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 16 Jul 2012 16:07:42 +0000 (16:07 +0000)]
land http://codereview.appspot.com/6325044/ by Lei
git-svn-id: http://skia.googlecode.com/svn/trunk@4622
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 16 Jul 2012 14:56:37 +0000 (14:56 +0000)]
Delete 5 stale gm expected images
- complexclip_gpu.png is no longer being generated
- aaclip_pdf.pdf and clamped_gradients_pdf.pdf have not been exercised and need rebaselining
Review URL: https://codereview.appspot.com/6405048
git-svn-id: http://skia.googlecode.com/svn/trunk@4620
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Jul 2012 14:16:22 +0000 (14:16 +0000)]
Fix bad allocator access in r4616
git-svn-id: http://skia.googlecode.com/svn/trunk@4619
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 16 Jul 2012 14:04:59 +0000 (14:04 +0000)]
Adding bracketing save/restore calls to SkPicture at record time and
preparing tests for enforcing save/restore balancing constraints on SkPicture
Review URL: http://codereview.appspot.com/6354105/
git-svn-id: http://skia.googlecode.com/svn/trunk@4618
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Jul 2012 13:46:39 +0000 (13:46 +0000)]
Fix fs param name in conical gradient due to r4616.
git-svn-id: http://skia.googlecode.com/svn/trunk@4617
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 16 Jul 2012 13:36:18 +0000 (13:36 +0000)]
Remove uniform var pointers from custom effects
Review URL: http://codereview.appspot.com/6374067/
git-svn-id: http://skia.googlecode.com/svn/trunk@4616
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 16 Jul 2012 13:22:56 +0000 (13:22 +0000)]
Revert "Add a method to atomic add."
This reverts commit
eb539cf92f487daf9567ffbbba6b6653406d43ae.
BUG=
TEST=
Review URL: https://codereview.appspot.com/6395051
git-svn-id: http://skia.googlecode.com/svn/trunk@4615
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 16 Jul 2012 13:13:29 +0000 (13:13 +0000)]
Add a skia method to perform an atomic add.
Complements sk_atomic_inc for when you want to increase by more than one.
Review URL: https://codereview.appspot.com/6350106
git-svn-id: http://skia.googlecode.com/svn/trunk@4614
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 16 Jul 2012 12:23:32 +0000 (12:23 +0000)]
Having updated the documentation of GrCustomStage to argue that all custom stages must be
immutable, this CL makes that true for ConvolutionEffect.
http://codereview.appspot.com/6398043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4613
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Jul 2012 21:22:02 +0000 (21:22 +0000)]
skdiff: replace --failonmismatches with repeatable --failonresult option
Review URL: https://codereview.appspot.com/6392064
git-svn-id: http://skia.googlecode.com/svn/trunk@4611
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 13 Jul 2012 21:07:52 +0000 (21:07 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4610
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 13 Jul 2012 20:06:02 +0000 (20:06 +0000)]
[PDF] Add link annotations.
Review URL: https://codereview.appspot.com/6346100
git-svn-id: http://skia.googlecode.com/svn/trunk@4609
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Fri, 13 Jul 2012 19:54:19 +0000 (19:54 +0000)]
Start removing calls to GrDrawState::setTexture() (and GrPaint::setTexture()?) when there's
a GrSingleTextureEffect involved holding the texture.
http://codereview.appspot.com/6353094/
git-svn-id: http://skia.googlecode.com/svn/trunk@4608
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 13 Jul 2012 18:55:53 +0000 (18:55 +0000)]
Mac build fix for Keyar. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@4607
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Fri, 13 Jul 2012 18:43:39 +0000 (18:43 +0000)]
Updated make_filepath test to reflect changes in picture_utils. TBR
Review URL: https://codereview.appspot.com/6350105
git-svn-id: http://skia.googlecode.com/svn/trunk@4606
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 13 Jul 2012 18:25:06 +0000 (18:25 +0000)]
There were three different problems with lighting filters:
1) Texture offsets (fImageIncrement) have to be signed depending on
whether the texture is "right way up" (texture upload) or "upside down"
(render target), so the surface normals were coming out upside down.
2) Light normals have to y-negated on upload
These two bugs were cancelling each other out in SampleApp, (where we
were testing w/textures) but not in Chrome (where we were testing
w/render targets).
3) The extract-the-height-from-the-view-matrix hack I was using to
compare light positions vs. gl_FragCoord doesn't work in Chrome where we
compile with GR_STATIC_RECT_VB, and the view matrix contains more than
the viewport transform (to accomodate the canonical vertex buffer).
Fixed by passing the destination render target to
GrGLProgramStage::setData(), so it can flip the light positions in Y on
the CPU.
Review URL: http://codereview.appspot.com/6343109/
git-svn-id: http://skia.googlecode.com/svn/trunk@4605
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Jul 2012 18:24:16 +0000 (18:24 +0000)]
add baselines for new gm
git-svn-id: http://skia.googlecode.com/svn/trunk@4604
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Fri, 13 Jul 2012 18:22:59 +0000 (18:22 +0000)]
Preparations for adding options and different render types to render_pictures.
Review URL: https://codereview.appspot.com/6345107
git-svn-id: http://skia.googlecode.com/svn/trunk@4603
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Fri, 13 Jul 2012 18:15:04 +0000 (18:15 +0000)]
Benchmark tiling now better reflects how it is done in Chrome.
Namely, the tile backing stores are all the same size.
Review URL: https://codereview.appspot.com/6352099
git-svn-id: http://skia.googlecode.com/svn/trunk@4602
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Jul 2012 17:45:17 +0000 (17:45 +0000)]
Fixed over-length lines in GrGLCreateDebugInterface.cpp
http://codereview.appspot.com/6346104/
git-svn-id: http://skia.googlecode.com/svn/trunk@4601
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Jul 2012 15:55:15 +0000 (15:55 +0000)]
don't add circles on chopped cubics
git-svn-id: http://skia.googlecode.com/svn/trunk@4600
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 13 Jul 2012 15:52:14 +0000 (15:52 +0000)]
rebaseline after gpu change
git-svn-id: http://skia.googlecode.com/svn/trunk@4599
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Jul 2012 15:36:15 +0000 (15:36 +0000)]
Added SkDevice onAttachToCanvas & onDetachFromCanvas methods
http://codereview.appspot.com/6348100/
git-svn-id: http://skia.googlecode.com/svn/trunk@4598
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Jul 2012 15:17:53 +0000 (15:17 +0000)]
Fixed calling SkIntToScalar on a float error
git-svn-id: http://skia.googlecode.com/svn/trunk@4597
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 13 Jul 2012 14:55:25 +0000 (14:55 +0000)]
Improved clarity of complexclip GM
http://codereview.appspot.com/6344108/
git-svn-id: http://skia.googlecode.com/svn/trunk@4596
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 13 Jul 2012 14:53:18 +0000 (14:53 +0000)]
Add SkTDArray.contains(), which is just a wrapper around find()
Review URL: https://codereview.appspot.com/6349103
git-svn-id: http://skia.googlecode.com/svn/trunk@4595
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 13 Jul 2012 14:39:51 +0000 (14:39 +0000)]
Fix SkMatrix.h line endings (LF) [change 4592 fixed the cpp]
git-svn-id: http://skia.googlecode.com/svn/trunk@4594
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 13 Jul 2012 13:36:38 +0000 (13:36 +0000)]
Fix SkMatrix line endings (LF)
git-svn-id: http://skia.googlecode.com/svn/trunk@4592
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 13 Jul 2012 11:57:28 +0000 (11:57 +0000)]
shape ops work in progress
Review URL: https://codereview.appspot.com/6392058
git-svn-id: http://skia.googlecode.com/svn/trunk@4591
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Jul 2012 23:35:28 +0000 (23:35 +0000)]
update-doxygen.sh: update local copy of workspace rather than checking it out fresh every time
Review URL: https://codereview.appspot.com/6346099
git-svn-id: http://skia.googlecode.com/svn/trunk@4590
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 12 Jul 2012 21:58:14 +0000 (21:58 +0000)]
Feature, HitBox selects current command
Review URL: https://codereview.appspot.com/6345091
git-svn-id: http://skia.googlecode.com/svn/trunk@4588
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Thu, 12 Jul 2012 21:16:49 +0000 (21:16 +0000)]
Changed cmsecs to msecs to be consistent with bench.
We are using wall time and not cpu time and so the proper name for this
should probably be outputted.
Review URL: https://codereview.appspot.com/6345104
git-svn-id: http://skia.googlecode.com/svn/trunk@4587
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 12 Jul 2012 21:05:13 +0000 (21:05 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4586
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Thu, 12 Jul 2012 20:22:04 +0000 (20:22 +0000)]
Fix setFileOffset type to remove warnings.
Review URL: https://codereview.appspot.com/6334050
git-svn-id: http://skia.googlecode.com/svn/trunk@4585
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 12 Jul 2012 19:48:42 +0000 (19:48 +0000)]
Disable WritePixelsTest on Android
This fails on Xoom. Re-enable when #634 is fixed.
Review URL: https://codereview.appspot.com/6354099
git-svn-id: http://skia.googlecode.com/svn/trunk@4584
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 12 Jul 2012 19:29:45 +0000 (19:29 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4583
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Thu, 12 Jul 2012 19:19:55 +0000 (19:19 +0000)]
Added a benchmark for measuring picture unflattening time.
Review URL: https://codereview.appspot.com/6354097
git-svn-id: http://skia.googlecode.com/svn/trunk@4582
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Jul 2012 18:37:55 +0000 (18:37 +0000)]
rename NO_ERROR to kNoError, because Windows defines a NO_ERROR macro elsewhere
TBR=rmistry
Review URL: https://codereview.appspot.com/6355100
git-svn-id: http://skia.googlecode.com/svn/trunk@4581
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 12 Jul 2012 18:16:02 +0000 (18:16 +0000)]
skdiff: add --failonmismatches and --listfilename options, plus cleanup
These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too.
Review URL: https://codereview.appspot.com/6392054
git-svn-id: http://skia.googlecode.com/svn/trunk@4579
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 12 Jul 2012 17:47:34 +0000 (17:47 +0000)]
Cleanup restore offsets at end of SkPicture recording
Review URL: http://codereview.appspot.com/6355099/
TEST=skia unit test CanvasTest, test step TwoClipOps
BUG=https://code.google.com/p/chromium/issues/detail?id=133432
git-svn-id: http://skia.googlecode.com/svn/trunk@4577
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 12 Jul 2012 17:23:52 +0000 (17:23 +0000)]
Introduces new SingleTextureEffect base class for GrCustomStage objects.
This class tracks the texture that the object uses. A future commit will get rid of the
GrTexture pointer currenty stored in the GrDrawState, allowing us to have CustomStages
*without* textures.
Requires gyp change on next roll.
http://codereview.appspot.com/6306097/
git-svn-id: http://skia.googlecode.com/svn/trunk@4576
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 12 Jul 2012 16:40:03 +0000 (16:40 +0000)]
Refactor how precision is handled with GrGLShaderVar
Review URL: http://codereview.appspot.com/6392049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4575
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Jul 2012 15:59:09 +0000 (15:59 +0000)]
rebaseline macpro for convexpaths (test was changed)
git-svn-id: http://skia.googlecode.com/svn/trunk@4574
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 12 Jul 2012 15:42:37 +0000 (15:42 +0000)]
Added annotation for gm's -wp flag
Review URL: https://codereview.appspot.com/6345098
git-svn-id: http://skia.googlecode.com/svn/trunk@4573
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 12 Jul 2012 15:27:54 +0000 (15:27 +0000)]
check a hashtable before using a bsearch
Review URL: https://codereview.appspot.com/6345097
git-svn-id: http://skia.googlecode.com/svn/trunk@4572
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 12 Jul 2012 14:44:52 +0000 (14:44 +0000)]
Fixing bad assertion test that was trippin-up debug buildbots
TBR=http://codereview.appspot.com/6344109
git-svn-id: http://skia.googlecode.com/svn/trunk@4569
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 12 Jul 2012 14:39:07 +0000 (14:39 +0000)]
Fix the lighting filters unit test and re-enable it.
Review URL: http://codereview.appspot.com/6355098/
git-svn-id: http://skia.googlecode.com/svn/trunk@4568
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 12 Jul 2012 14:38:49 +0000 (14:38 +0000)]
Bug Fix: Delete redraws correctly when redraw command execution is paused
Review URL: https://codereview.appspot.com/6392053
git-svn-id: http://skia.googlecode.com/svn/trunk@4567
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 12 Jul 2012 14:31:25 +0000 (14:31 +0000)]
SkHitBox added.
SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.
Review URL: https://codereview.appspot.com/6350098
git-svn-id: http://skia.googlecode.com/svn/trunk@4565
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Thu, 12 Jul 2012 14:15:54 +0000 (14:15 +0000)]
Seperated Space for displaying breakpoint and deletion icons
Review URL: https://codereview.appspot.com/6356094
git-svn-id: http://skia.googlecode.com/svn/trunk@4563
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 12 Jul 2012 14:01:32 +0000 (14:01 +0000)]
Fixing type mask computation in SkMatrix to make it faster and make it so that matrices have the same type masks as their inverses.
This patch also add bench tests that call invert() followed by mapRect() on various types of matrices. Performance of these tests was greatly affected by typemask computation
Review URL: http://codereview.appspot.com/6380043/
BUG=https://code.google.com/p/chromium/issues/detail?id=135259
git-svn-id: http://skia.googlecode.com/svn/trunk@4562
2bbb7eff-a529-9590-31e7-
b0007b416f81