Kenny Levinsen [Thu, 25 Jul 2019 11:53:44 +0000 (13:53 +0200)]
uwac: Do not unconditionally set pendingBuffer on configure
If pendingBuffer is set when it was otherwise NULL, then
UwacWindowSubmitBuffer will forever bail early, waiting for a frame
callback that will never come.
Kenny Levinsen [Mon, 22 Jul 2019 22:00:47 +0000 (00:00 +0200)]
uwac: Acknowledge xdg_surface configure messages
This is necessary for the surface to have its role configured.
Martin Fleisz [Mon, 29 Jul 2019 14:37:06 +0000 (16:37 +0200)]
common: Fix parsing of devicestoredirect setting in rdp files
If devicestoredirect was found in an rdp file we incorrectly enabled
drive redirection (which has nothing to do with device redirection).
Bernhard Miklautz [Mon, 29 Jul 2019 08:07:13 +0000 (10:07 +0200)]
Merge pull request #5498 from ligurio/patch-1
Typo: neigter -> neither
Bernhard Miklautz [Fri, 26 Jul 2019 08:36:34 +0000 (10:36 +0200)]
Merge pull request #5478 from kubistika/proxy/refactor
Proxy/refactor
Bernhard Miklautz [Fri, 26 Jul 2019 08:31:32 +0000 (10:31 +0200)]
Merge pull request #5501 from ligurio/typo
Fixed typo: RAW_VERSTION_STRING -> RAW_VERSION_STRING
Sergey Bronnikov [Thu, 25 Jul 2019 13:07:40 +0000 (16:07 +0300)]
Fixed typo: RAW_VERSTION_STRING -> RAW_VERSION_STRING
Sergey Bronnikov [Wed, 24 Jul 2019 07:22:05 +0000 (10:22 +0300)]
Typo: neigter -> neither
Martin Fleisz [Thu, 18 Jul 2019 10:20:28 +0000 (12:20 +0200)]
Merge pull request #5480 from akallabeth/xfreerdp_clip_fix
Fix broken clipboard after file copy
Martin Fleisz [Thu, 18 Jul 2019 08:59:59 +0000 (10:59 +0200)]
Fix rdp file writer
The RDP file writer was based on previously parsed lines from an
existing rdp file. If you created a new rdpFile, populated it from
settings and tried to write it to a file you just got an error. This PR
fixes this issue by creating the data from the rdpFile properties rather
than the parsed lines.
Martin Fleisz [Wed, 17 Jul 2019 13:48:26 +0000 (15:48 +0200)]
Reformatting
Martin Fleisz [Thu, 18 Jul 2019 08:59:20 +0000 (10:59 +0200)]
Merge pull request #5484 from akallabeth/alternate_full_address
Added alternate full address to rdp file parser.
Armin Novak [Thu, 18 Jul 2019 07:29:06 +0000 (09:29 +0200)]
Added alternate full address to rdp file parser.
kubistika [Wed, 17 Jul 2019 12:51:11 +0000 (15:51 +0300)]
libfreerdp: core: fix const correctness of freerdp_settings_clone
Armin Novak [Wed, 17 Jul 2019 08:10:04 +0000 (10:10 +0200)]
Fix broken clipboard after file copy
Martin Fleisz [Wed, 17 Jul 2019 13:06:28 +0000 (15:06 +0200)]
Merge pull request #5481 from akallabeth/pem_intermediate_fix
Extract whole certificate chain to PEM format.
Armin Novak [Wed, 17 Jul 2019 12:00:29 +0000 (14:00 +0200)]
Extract whole certificate chain to PEM format.
kubistika [Tue, 16 Jul 2019 13:19:15 +0000 (16:19 +0300)]
server: proxy: Add logs, call client->Close to send disconnection ultimatum
kubistika [Tue, 16 Jul 2019 13:18:26 +0000 (16:18 +0300)]
server: proxy: remove unnecessary function handle_client_disconnection
kubistika [Tue, 16 Jul 2019 13:14:38 +0000 (16:14 +0300)]
server: proxy: adjust log levels
kubistika [Tue, 16 Jul 2019 13:14:06 +0000 (16:14 +0300)]
server: proxy: set nla fallback flag flag only if NLASecurity is enabled
kubistika [Tue, 16 Jul 2019 13:13:12 +0000 (16:13 +0300)]
server: proxy: naming refactor
kubistika [Tue, 16 Jul 2019 13:08:45 +0000 (16:08 +0300)]
server: proxy: remove unnecessary files
kubistika [Tue, 16 Jul 2019 10:28:14 +0000 (13:28 +0300)]
server: proxy: use freerdp_settings_copy
kubistika [Tue, 16 Jul 2019 10:27:39 +0000 (13:27 +0300)]
libfreerdp: settings: Fix formatting in freerdp_settings_copy
kubistika [Tue, 16 Jul 2019 10:27:11 +0000 (13:27 +0300)]
libfreerdp: settings: call key_clone in freerdp_settings_copy
kubistika [Tue, 16 Jul 2019 10:26:26 +0000 (13:26 +0300)]
libfreerdp: certificate: Add key_clone
Armin Novak [Tue, 16 Jul 2019 07:54:31 +0000 (09:54 +0200)]
Added freerdp_settings_copy
Martin Fleisz [Tue, 16 Jul 2019 09:22:14 +0000 (11:22 +0200)]
Merge pull request #5475 from akallabeth/tls_fail_status
Pass on cert validation failure, set freerdp error in all use cases.
Armin Novak [Mon, 15 Jul 2019 13:51:46 +0000 (15:51 +0200)]
Pass on cert validation failure, set freerdp error in all use cases.
Martin Fleisz [Mon, 15 Jul 2019 11:09:28 +0000 (13:09 +0200)]
Merge pull request #5472 from akallabeth/rdp_parser_fixes
Rdp parser fixes
Armin Novak [Mon, 15 Jul 2019 09:08:02 +0000 (11:08 +0200)]
Fixed freerdp_client_rdp_file_set_integer standard flag set.
Armin Novak [Mon, 15 Jul 2019 08:46:52 +0000 (10:46 +0200)]
Fixed rdp file parser tests.
Armin Novak [Mon, 15 Jul 2019 08:30:16 +0000 (10:30 +0200)]
Implemented rdp file parser functions with a callback for custom settings.
Armin Novak [Mon, 15 Jul 2019 08:08:39 +0000 (10:08 +0200)]
Added PromptForCredentials setting.
kubistika [Mon, 15 Jul 2019 07:55:57 +0000 (10:55 +0300)]
server: proxy: implement NLA fallback
kubistika [Thu, 11 Jul 2019 19:13:19 +0000 (22:13 +0300)]
winpr: ObjectPool_Return: fix error handling
kubistika [Thu, 11 Jul 2019 19:12:50 +0000 (22:12 +0300)]
winpr: ObjectPool_Return: fix wrong type for new_cap
Norbert Federa [Thu, 11 Jul 2019 10:50:47 +0000 (12:50 +0200)]
Merge pull request #5469 from akallabeth/access_denied
Don't set ACCESS_DENIED on first HTTP gateway response.
Armin Novak [Thu, 11 Jul 2019 09:44:18 +0000 (11:44 +0200)]
Don't set ACCESS_DENIED on first HTTP gateway response.
The first response is alwasy ACCESS_DENIED to initiate authentication.
Only the second response must not have that status.
Norbert Federa [Thu, 11 Jul 2019 08:57:24 +0000 (10:57 +0200)]
Merge pull request #5468 from akallabeth/gw_status_denied
Set freerdp last error on gateway access denied.
Armin Novak [Thu, 11 Jul 2019 08:38:15 +0000 (10:38 +0200)]
Set freerdp last error on gateway access denied.
Martin Fleisz [Tue, 9 Jul 2019 14:17:29 +0000 (16:17 +0200)]
Merge pull request #5396 from widgetii/master
Artur Zaprzala's rdp2tcp channel driver
Martin Fleisz [Tue, 9 Jul 2019 13:52:53 +0000 (15:52 +0200)]
Merge pull request #5458 from kubistika/bugfix/proxy-multimon
Declare support for multimon in proxy server.
Martin Fleisz [Tue, 9 Jul 2019 13:02:49 +0000 (15:02 +0200)]
client: populate settings didn't update NetworkAutoDetect
Martin Fleisz [Mon, 8 Jul 2019 09:47:51 +0000 (11:47 +0200)]
rail: Fixes incorrect setting of TS_RAIL_EXEC_FLAG_FILE
The TS_RAIL_EXEC_FLAG should only be set if ExeOrFile refers to a file
path. If we don't supply a published app name (using ||) but the name of
an application (i.e. notepad.exe) this flag was incorrectly set causing
an remote app execution error (error 5 - file not found).
kubistika [Mon, 8 Jul 2019 08:09:29 +0000 (11:09 +0300)]
Declare support for multimon in proxy server.
It was broken in the DISP PR.
Martin Fleisz [Tue, 2 Jul 2019 12:12:58 +0000 (14:12 +0200)]
Merge pull request #5453 from akallabeth/load_balance_info_checks
Only try to set nego token if load balance info length is >0
Armin Novak [Tue, 2 Jul 2019 09:53:14 +0000 (11:53 +0200)]
Only try to set nego token if load balance info length is >0
Martin Fleisz [Mon, 1 Jul 2019 06:50:15 +0000 (08:50 +0200)]
Merge pull request #5447 from akallabeth/mac_bundle
Fix plugin paths when building for a mac bundle.
kubistika [Thu, 13 Jun 2019 13:56:21 +0000 (16:56 +0300)]
server/proxy: Add check after calling p_client_context_create
kubistika [Thu, 13 Jun 2019 13:55:56 +0000 (16:55 +0300)]
server/proxy: Logging and comments improvements
kubistika [Tue, 11 Jun 2019 16:01:49 +0000 (19:01 +0300)]
server/proxy: pf_update: Update ps->settings in DesktopResize
kubistika [Tue, 11 Jun 2019 15:54:10 +0000 (18:54 +0300)]
server/proxy: set ps->thread to NULL on disconnect
freerdp_abort_connect calls the proxy's client stop function,
that closes the thread handle. if it already closed by the server,
a segfault will occur because CloseHandle will try to access free()'ed
memory.
kubistika [Tue, 11 Jun 2019 15:51:21 +0000 (18:51 +0300)]
server/proxy: Refactor pdata_set_connection_info
Connection info must be set after the proxy's client connection
established, because if the client didn't provide credentials in .rdp
file, we don't know its username yet.
kubistika [Tue, 11 Jun 2019 15:48:47 +0000 (18:48 +0300)]
server/proxy: pf_filters: Update filter_free to accept NULL
kubistika [Thu, 30 May 2019 08:22:50 +0000 (11:22 +0300)]
server/proxy: Fix race-condition
The client's `ClientStop` callback wasn't set, therefore calling
freerdp_client_stop wasn't really blocking until it has stopped, and a
race condition occured. Fixed by registring to `ClientStop` callback and
waiting for the client thread to finish.
kubistika [Tue, 28 May 2019 13:10:04 +0000 (16:10 +0300)]
server/proxy: Fix rdpgfx and events leak
kubistika [Tue, 28 May 2019 13:09:49 +0000 (16:09 +0300)]
server/proxy: Fix double-call to disconnect
Armin Novak [Wed, 26 Jun 2019 07:56:16 +0000 (09:56 +0200)]
Fix plugin paths when building for a mac bundle.
David Fort [Tue, 25 Jun 2019 09:23:00 +0000 (11:23 +0200)]
Merge pull request #5445 from akallabeth/some_small_patches
Fix various small issues
Dmitry Ilyin [Tue, 25 Jun 2019 08:52:22 +0000 (11:52 +0300)]
PR fixes
Armin Novak [Tue, 25 Jun 2019 08:39:34 +0000 (10:39 +0200)]
Fixed type mismatch.
Armin Novak [Tue, 25 Jun 2019 08:36:19 +0000 (10:36 +0200)]
Fix #5427: Dispatch updates to main thread.
thank you @Harrywang55666
Armin Novak [Tue, 25 Jun 2019 08:31:17 +0000 (10:31 +0200)]
Fixed #5406: Ensure mouse wheel rotation step is never zero
thank you @victorking528
Armin Novak [Tue, 25 Jun 2019 08:25:31 +0000 (10:25 +0200)]
Fixed #5441, thank you @ekse
David Fort [Tue, 18 Jun 2019 15:35:27 +0000 (17:35 +0200)]
Merge pull request #5438 from akallabeth/tsmf_patch
Patch from #5436: fix input handling with gstreamer and vaapisink
Armin Novak [Tue, 18 Jun 2019 11:43:44 +0000 (13:43 +0200)]
Patch from #5436: fix input handling with gstreamer and vaapisink
David Fort [Thu, 13 Jun 2019 09:35:15 +0000 (11:35 +0200)]
Merge pull request #5424 from kubistika/rdpgfx
rdpgfx: CacheImportOffer implementation
Martin Fleisz [Thu, 13 Jun 2019 07:19:42 +0000 (09:19 +0200)]
codec: Set alpha channel to FF if not used (#5431)
* Formatting
* codec: Set alpha channel to FF if not used
This PR initializes the alpha channel to FF. Before the alpha channel
contained uninitialized memory potentially causing problems when the
image data was used by an alpha channel aware frontend.
David Fort [Wed, 12 Jun 2019 19:15:59 +0000 (21:15 +0200)]
Merge pull request #5423 from kubistika/feat/bitmap-auto-flag-calculate
rdpUpdate: add autoBitmapDataCalculate
Kobi [Tue, 11 Jun 2019 14:13:42 +0000 (07:13 -0700)]
RDPEDISP server side implementation (#5414)
* libfreerdp: Add RDPEDISP server implementation
* server/proxy: Add RDPEDISP support
kubistika [Thu, 6 Jun 2019 07:24:27 +0000 (10:24 +0300)]
rdpgfx/client: Update gfx->UnacknowlegedFrame correctly
kubistika [Wed, 5 Jun 2019 13:19:28 +0000 (16:19 +0300)]
server/proxy: Proxy CacheImportOffer & QoeFrameAck
kubistika [Wed, 5 Jun 2019 13:18:42 +0000 (16:18 +0300)]
rdpgfx/server: Fix formatting: rdpgfx_recv_cache_import_offer_pdu
kubistika [Wed, 5 Jun 2019 13:18:00 +0000 (16:18 +0300)]
rdpgfx/client: Expose QoeFrameAck
kubistika [Wed, 5 Jun 2019 13:13:49 +0000 (16:13 +0300)]
rdpgfx/client: Implement CacheImportOffer PDU
kubistika [Tue, 4 Jun 2019 14:33:48 +0000 (17:33 +0300)]
server/proxy: Fix bitmap update crash when target is win7
kubistika [Tue, 4 Jun 2019 14:33:18 +0000 (17:33 +0300)]
rdpUpdate: add autoCalculateBitmapData flag
David Fort [Tue, 4 Jun 2019 11:51:46 +0000 (13:51 +0200)]
Merge pull request #5422 from kubistika/feat/ifdef-rdpgfx-dbg
rdpgfx: Add WITH_DEBUG_RDPGFX cmake option
kubistika [Tue, 4 Jun 2019 07:28:03 +0000 (10:28 +0300)]
rdpgfx: Add WITH_DEBUG_RDPGFX option
Martin Fleisz [Tue, 4 Jun 2019 07:14:59 +0000 (09:14 +0200)]
Merge pull request #5415 from akallabeth/dump_append_fix
Fixed format security issues.
David Fort [Mon, 3 Jun 2019 13:45:24 +0000 (15:45 +0200)]
Merge pull request #5405 from m4ntis/proxy/filters-api
Proxy: Filters API
David Fort [Mon, 3 Jun 2019 13:20:14 +0000 (15:20 +0200)]
Merge pull request #5416 from m4ntis/proxy/multimon
Add multimon support to proxy server
kubistika [Mon, 20 May 2019 11:09:12 +0000 (14:09 +0300)]
server/proxy: Add multimon support
kubistika [Mon, 20 May 2019 11:05:32 +0000 (14:05 +0300)]
libfreerdp/core: Export monitor layout PDU
* Move update notification related functions to new display.c: Not
related to `rdp.c`.
* Rename `rdp_write_monitor_layout_pdu` to `display_write_monitor_layout_pdu`.
* Add internal `display_convert_rdp_monitor_to_monitor_def` instead of
doing the conversion inside `display_write_monitor_layout_pdu`.
David Fort [Mon, 3 Jun 2019 11:09:05 +0000 (13:09 +0200)]
Merge pull request #5418 from kubistika/feat/proxy/cursor
server/proxy: Proxy pointer updates
Idan Freiberg [Mon, 3 Jun 2019 07:47:35 +0000 (10:47 +0300)]
channels: ssh-agnet: cmake: turn off server side channel by default in `ChannelsOptions.cmake` (#5420)
CMake v3.5.1 throws the following error if this is not set:
```
CMake Error at channels/CMakeLists.txt:48 (if):
if given arguments:
"OFF" "OR"
Unknown arguments specified
Call Stack (most recent call first):
channels/sshagent/ChannelOptions.cmake:6 (define_channel_options)
channels/CMakeLists.txt:273 (include)
```
Martin Fleisz [Mon, 3 Jun 2019 07:05:43 +0000 (09:05 +0200)]
RAIL: Fix parsing of WINDOW_ORDER_FIELD_ICON_OVERLAY_NULL (#5421)
kubistika [Wed, 29 May 2019 07:00:52 +0000 (10:00 +0300)]
server/proxy: Proxy pointer updates
* Moved update callbacks of client to pf_update.h
kubistika [Mon, 27 May 2019 09:06:59 +0000 (12:06 +0300)]
fix vs2010 errors
kubistika [Sun, 26 May 2019 12:33:28 +0000 (15:33 +0300)]
server/proxy: Code refactor
kubistika [Sun, 26 May 2019 12:29:41 +0000 (15:29 +0300)]
server/proxy: Use winpr library in proxy/filters
kubistika [Mon, 13 May 2019 08:11:24 +0000 (11:11 +0300)]
server/proxy: Fix free invalid memory when pf_server_parse_target_from_routing_token fails
kubistika [Sun, 19 May 2019 12:04:38 +0000 (15:04 +0300)]
server/proxy: Fix mem leak in pf_server_parse_target_from_routing_token
kubistika [Sun, 12 May 2019 18:25:36 +0000 (21:25 +0300)]
server/proxy: Remove unnecessary wrap for connection info
kubistika [Sun, 12 May 2019 18:25:00 +0000 (21:25 +0300)]
server/proxy: Add docs in filters_api.h
kubistika [Sun, 12 May 2019 18:24:35 +0000 (21:24 +0300)]
server/proxy: Add return statement in demo_filter.c
kubistika [Sun, 12 May 2019 12:04:44 +0000 (15:04 +0300)]
Add README for filters API
kubistika [Sun, 12 May 2019 11:02:50 +0000 (14:02 +0300)]
bugfix: segfault when calling an event which is not implemented by filter