YeongJong Lee [Mon, 4 Jun 2018 11:12:50 +0000 (20:12 +0900)]
elm_label: remove needless variable
Reviewers: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6238
YeongJong Lee [Mon, 4 Jun 2018 08:48:06 +0000 (17:48 +0900)]
elementary: fix wrong signal emission
Summary:
When _icon_signal_emit is called, "icon" part always exist. so, it only make
"visible" signal.
this fixes that issue
Test Plan:
elm_object_content_unset(button);
elm_object_content_unset(radio);
elm_object_content_unset(check);
elm_object_content_unset(progressbar);
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6241
Jihoon Kim [Mon, 4 Jun 2018 01:47:55 +0000 (10:47 +0900)]
ecore_imf: turn off autocapital mode in password layout
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
YeongJong Lee [Thu, 31 May 2018 12:04:55 +0000 (12:04 +0000)]
elm_table/grid: remove non-widgets from focus elements.
ref
5a3ee984a1229c069c84e71a109a7d39437d5cc0
Differential Revision: https://phab.enlightenment.org/D6236
YeongJong Lee [Fri, 1 Jun 2018 14:13:14 +0000 (09:13 -0500)]
ee_wayland: remove needless variable
Reviewers: ManMower, zmike
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6239
YeongJong Lee [Fri, 1 Jun 2018 02:36:01 +0000 (11:36 +0900)]
elm_hoversel: inherit elm_button
Summary:
elm_hoversel is legacy widget. it should inherit legacy Elm_Button instead of
Efl.Ui.Button.
this patch also fixes icon signal emit bug.
fixes T6971
Test Plan:
1. elementary_test -to hoversel
2. check that ther is icon (sky) on "Icon + Lebel" hoversel
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, JackDanielZ, zmike
Tags: #efl
Maniphest Tasks: T6971
Differential Revision: https://phab.enlightenment.org/D6240
Wonki Kim [Tue, 5 Jun 2018 03:36:07 +0000 (12:36 +0900)]
migration: modify elementary-tizen code to match with upstream code
Change-Id: Ide74c1e2eeff990bf2a1899febcb2db56ebccab0
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Mon, 4 Jun 2018 08:06:05 +0000 (17:06 +0900)]
Revert "migration: turn off tizen only elementary"
This reverts commit
43802272a9da1632cae7b0002e1d09eac1f10083.
Change-Id: I729ef9f285fb10c60287494046a51702fee4e8b1
Wonki Kim [Mon, 4 Jun 2018 08:23:20 +0000 (17:23 +0900)]
migration: update elementary-tizen automake script
Change-Id: Ic85a4477b6e90cc249d93067aa29646e17b62715
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Mon, 4 Jun 2018 07:24:24 +0000 (16:24 +0900)]
ecore_input_device: Modify efl_add by efl_add_ref
@tizen_fix
Change-Id: I8ae012abe9101c99a3c8a7adf83a1028406ede35
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Mike Blumenkrantz [Thu, 31 May 2018 18:11:09 +0000 (13:11 -0500)]
gl_common: fix invalid memory access
Summary:
code was added which ignores the comment explicitly warning not to
do what was done here
ref
9e01cf2698d5b24f440d696fd57d469cdc5a6b5f
ref T6970
==4829== Invalid read of size 1
==4829== at 0x246D8F06: evas_gl_common_image_update (evas_gl_image.c:907)
==4829== by 0x246DAA7B: evas_gl_common_image_draw (evas_gl_image.c:1417)
==4829== by 0x246A2AB6: eng_image_draw (evas_engine.c:1240)
==4829== by 0x6A87842: _draw_image (evas_object_image.c:1403)
==4829== by 0x6A8A1BF: _evas_image_render (evas_object_image.c:2171)
==4829== by 0x6A890C1: evas_object_image_render (evas_object_image.c:1868)
==4829== by 0x6B09C82: evas_render_mapped (evas_render.c:2292)
==4829== by 0x6B0CE90: evas_render_updates_internal_loop (evas_render.c:3079)
==4829== by 0x6B0EACA: evas_render_updates_internal (evas_render.c:3522)
==4829== by 0x6B1087C: evas_render_updates_internal_wait (evas_render.c:3946)
==4829== by 0x6B10A4D: _evas_canvas_render_updates (evas_render.c:3971)
==4829== by 0x6A7A234: evas_canvas_render_updates (evas_canvas.eo.c:212)
==4829== by 0x6A7BBD4: evas_render_updates (evas_canvas.eo.c:758)
==4829== by 0x808A7D8: ecore_evas_render (ecore_evas.c:177)
==4829== by 0x808AA58: _ecore_evas_idle_enter (ecore_evas.c:284)
==4829== by 0x5CC1E46: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CC1EAE: _ecore_factorized_idle_process (ecore_idler.c:35)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CC661B: _ecore_main_loop_iterate_internal (ecore_main.c:2352)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
==4829== Address 0x2bfc30f8 is 328 bytes inside a block of size 560 free'd
==4829== at 0x4C30D18: free (vg_replace_malloc.c:530)
==4829== by 0x540AE91: _eina_freeq_free_do (eina_freeq.c:118)
==4829== by 0x540B7B0: eina_freeq_ptr_add (eina_freeq.c:372)
==4829== by 0x6BCD23C: _evas_common_rgba_image_delete (evas_image_main.c:555)
==4829== by 0x6B41538: _evas_cache_image_entry_delete (evas_cache_image.c:205)
==4829== by 0x6B43503: evas_cache_image_drop (evas_cache_image.c:945)
==4829== by 0x6B43F4F: evas_cache_image_size_set (evas_cache_image.c:1166)
==4829== by 0x246D6548: evas_gl_common_image_alloc_ensure (evas_gl_image.c:17)
==4829== by 0x246D8EA8: evas_gl_common_image_update (evas_gl_image.c:869)
==4829== by 0x246DAA7B: evas_gl_common_image_draw (evas_gl_image.c:1417)
==4829== by 0x246A2AB6: eng_image_draw (evas_engine.c:1240)
==4829== by 0x6A87842: _draw_image (evas_object_image.c:1403)
==4829== by 0x6A8A1BF: _evas_image_render (evas_object_image.c:2171)
==4829== by 0x6A890C1: evas_object_image_render (evas_object_image.c:1868)
==4829== by 0x6B09C82: evas_render_mapped (evas_render.c:2292)
==4829== by 0x6B0CE90: evas_render_updates_internal_loop (evas_render.c:3079)
==4829== by 0x6B0EACA: evas_render_updates_internal (evas_render.c:3522)
==4829== by 0x6B1087C: evas_render_updates_internal_wait (evas_render.c:3946)
==4829== by 0x6B10A4D: _evas_canvas_render_updates (evas_render.c:3971)
==4829== by 0x6A7A234: evas_canvas_render_updates (evas_canvas.eo.c:212)
==4829== by 0x6A7BBD4: evas_render_updates (evas_canvas.eo.c:758)
==4829== by 0x808A7D8: ecore_evas_render (ecore_evas.c:177)
==4829== by 0x808AA58: _ecore_evas_idle_enter (ecore_evas.c:284)
==4829== by 0x5CC1E46: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CC1EAE: _ecore_factorized_idle_process (ecore_idler.c:35)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CC661B: _ecore_main_loop_iterate_internal (ecore_main.c:2352)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
==4829== Block was alloc'd at
==4829== at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
==4829== by 0x6BCCF2F: _evas_common_rgba_image_new (evas_image_main.c:509)
==4829== by 0x6B41588: _evas_cache_image_entry_new (evas_cache_image.c:261)
==4829== by 0x6B44861: evas_cache_image_empty (evas_cache_image.c:1447)
==4829== by 0x246D845B: evas_gl_common_image_native_disable (evas_gl_image.c:624)
==4829== by 0x253F3C09: eng_image_native_set (evas_engine.c:1234)
==4829== by 0x6A86204: _evas_image_native_surface_set (evas_object_image.c:1021)
==4829== by 0x6A7E110: evas_object_image_native_surface_set (evas_image_legacy.c:509)
==4829== by 0x6A8609A: _on_image_native_surface_del (evas_object_image.c:998)
==4829== by 0x6A55190: _eo_evas_object_cb (evas_callbacks.c:184)
==4829== by 0xBFA4EB7: _event_callback_call (eo_base_class.c:1686)
==4829== by 0xBFA51F8: _efl_object_event_callback_legacy_call (eo_base_class.c:1759)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A968ED: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1229)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A55C3D: evas_object_event_callback_call (evas_callbacks.c:413)
==4829== by 0x6A96D3E: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1279)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x2C9D519F: _bar_icon_preview_del (bar.c:762)
==4829== by 0x6A55190: _eo_evas_object_cb (evas_callbacks.c:184)
==4829== by 0xBFA4EB7: _event_callback_call (eo_base_class.c:1686)
==4829== by 0xBFA51F8: _efl_object_event_callback_legacy_call (eo_base_class.c:1759)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A968ED: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1229)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A55C3D: evas_object_event_callback_call (evas_callbacks.c:413)
==4829== by 0x6A96D3E: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1279)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0x7BE9326: _efl_access_object_efl_object_invalidate (efl_access_object.c:634)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x7CD5F2C: _efl_ui_widget_efl_canvas_group_group_del (efl_ui_widget.c:855)
==4829== by 0x6AAD303: efl_canvas_group_del (evas_object_smart.c:1862)
==4829== by 0x7AFF104: _elm_box_efl_canvas_group_group_del (elm_box.c:362)
==4829== by 0x6AAD303: efl_canvas_group_del (evas_object_smart.c:1862)
==4829== by 0x6AABB79: evas_object_smart_del (evas_object_smart.c:1288)
==4829== by 0x6A97179: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1336)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0x7BE9326: _efl_access_object_efl_object_invalidate (efl_access_object.c:634)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x2C9D41DA: _bar_icon_preview_hide (bar.c:450)
==4829== by 0x5CFE14C: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CFE5C4: _ecore_timer_legacy_tick (ecore_timer.c:160)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CFF880: _efl_loop_timer_expired_call (ecore_timer.c:634)
==4829== by 0x5CFF6AF: _efl_loop_timer_expired_timers_call (ecore_timer.c:587)
==4829== by 0x5CC6522: _ecore_main_loop_iterate_internal (ecore_main.c:2317)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6234
YeongJong Lee [Thu, 31 May 2018 13:46:12 +0000 (09:46 -0400)]
elm_tooltip: use window as parent instead of NULL for elm_theme_object_set
Summary:
see
421217b15019966a093ed49a34837f9535e00827
If parent is NULL, is_legacy in _elm_theme_set is always true. and it will use
"efl/xxx" for mmap_set. this patch avoid this case.
fixes T6921
Test Plan:
1. elementary_test -to tooltip
2. check that "Hello", "Big Icon Tooltip", "Insanel Big Icon Tooltip" is working
Reviewers: zmike
Subscribers: cedric, ManMower, #committers
Tags: #efl
Maniphest Tasks: T6921
Differential Revision: https://phab.enlightenment.org/D6232
YeongJong Lee [Thu, 31 May 2018 12:39:34 +0000 (21:39 +0900)]
elm_win: fix widget type name for backward compatibility
Summary:
It should use legacy class in elm_win_add.
this patch fixes T6898, T6899
Test Plan: make check
Reviewers: zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6899, T6898
Differential Revision: https://phab.enlightenment.org/D6233
Xavi Artigas [Wed, 30 May 2018 11:33:01 +0000 (07:33 -0400)]
Do not consider the Evas_Vg API as BETA anymore
Summary:
It has been widely used for quite some time now.
Fixes T6889
Test Plan:
Manually built the evas-vg-simple.c and evas-vg-batman.c examples after
removing the manual define of EFL_BETA_API_SUPPORT and EFL_EO_API_SUPPORT
that they have at the top.
Reviewers: ajwillia.ms, zmike
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6889
Differential Revision: https://phab.enlightenment.org/D6230
Change-Id: I6ade2d86773f14a6a48ccee7e9d3f9d3a3e6eba3
Hermet Park [Wed, 30 May 2018 04:44:34 +0000 (13:44 +0900)]
elementary genlist: optimize data.
Hermet Park [Wed, 30 May 2018 04:41:21 +0000 (13:41 +0900)]
evas canvas: remove unused goto tag.
Hermet Park [Wed, 30 May 2018 04:37:35 +0000 (13:37 +0900)]
elementary: packing data properly.
Marcel Hollerbach [Tue, 29 May 2018 16:24:55 +0000 (12:24 -0400)]
evas_object_box: adjust to recent EFL_EVENT_DEL changes
Summary:
the same change as the one for evas table, just for box.
Depends on D6228
Reviewers: cedric, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6229
Marcel Hollerbach [Tue, 29 May 2018 16:24:53 +0000 (12:24 -0400)]
evas_focus: adjust to recent EFL_EVENT_DEL changes
Summary:
when focus events have been emitted the smart parent was persistent, now
its not anymore, lets restore this behaviour
Depends on D6227
Reviewers: cedric, zmike, stefan_schmidt
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6228
Marcel Hollerbach [Tue, 29 May 2018 16:24:44 +0000 (12:24 -0400)]
evas_clip: fix current EFL_EVENT_DEL event changes
Summary:
Before the parent was persistent when the intersept function and events
for clipper changes have been called. Lets get back to this behaviour.
Depends on D6226
Reviewers: cedric, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6227
Marcel Hollerbach [Tue, 29 May 2018 16:24:36 +0000 (12:24 -0400)]
evas: be less error prone
Summary:
Dont spin infinitly when the refcount accidently is already < 0.
Depends on D6225
Reviewers: zmike, cedric, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6226
Marcel Hollerbach [Tue, 29 May 2018 16:24:31 +0000 (12:24 -0400)]
evas_object_table: adjust to recent EFL_EVENT_DEL changes
Summary:
EFL_EVENT_DEL is wrong here, as the callback uses a parent, which is
gone at the time of EFL_EVENT_DEL.
Reviewers: zmike, cedric, stefan_schmidt
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6225
Mike Blumenkrantz [Tue, 29 May 2018 11:25:32 +0000 (13:25 +0200)]
tests: make statically-defined eldbus bus names unique
Summary:
if not unique, these bus names will collide if run from separate
connections resulting in test failure
fix T6848
Depends on D6203
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6204
Mike Blumenkrantz [Tue, 29 May 2018 11:25:26 +0000 (13:25 +0200)]
tests: use eldbus in dbus test naming instead of enlightenment
Summary:
these tests are for eldbus; enlightenment has its own dbus namespace and
should not be mentioned here to avoid confusion
Depends on D6202
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6203
Mike Blumenkrantz [Tue, 29 May 2018 11:25:06 +0000 (13:25 +0200)]
tests: print dbus errors on fail in eldbus_test_eldbus_message
Summary: Depends on D6200
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6201
Mike Blumenkrantz [Tue, 29 May 2018 11:24:44 +0000 (13:24 +0200)]
tests: print error messages when eldbus tests fail to acquire requested name
Summary: Depends on D6199
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6200
Mike Blumenkrantz [Tue, 29 May 2018 11:24:35 +0000 (13:24 +0200)]
tests: reduce duration of all timers in eldbus tests
Summary:
these values seem to assume that network latency or some other form
of delay exists in dbus communications. dbus is a local socket protocol,
so such lengthy timers do nothing but waste runtime
ref T6952
Depends on D6198
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6199
Mike Blumenkrantz [Tue, 29 May 2018 11:24:27 +0000 (13:24 +0200)]
tests: always use session bus for eldbus tests
Summary:
1eeb3cbdf7369686980135707c953e766a67d16c causes all tests to run
inside a dbus session, so use this bus to avoid possible issues with
security policies
ref T6838
Depends on D6197
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6838
Differential Revision: https://phab.enlightenment.org/D6198
Mike Blumenkrantz [Tue, 29 May 2018 11:24:15 +0000 (13:24 +0200)]
tests: fix eldbus_test_eldbus_name_owner_changed test
Summary:
this is supposed to check an fdo dbus spec implementation, so the test
should exit with success after verifying it instead of waiting for a timeout
ref T6952
Depends on D6196
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6197
Mike Blumenkrantz [Tue, 29 May 2018 11:23:27 +0000 (13:23 +0200)]
tests: remove eldbus_test_eldbus_main_loop
Summary:
this test has no relation to eldbus
ref T6952
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6196
Hermet Park [Tue, 29 May 2018 07:25:54 +0000 (16:25 +0900)]
evas render: remove compile warnings.
Some bunch of code is unused when RENDCACHE is disabled.
Migrated them into RENDCACHE scope. No logical changes actually.
Marcel Hollerbach [Tue, 29 May 2018 04:39:15 +0000 (21:39 -0700)]
edje: a new testcase for what was happening before
Summary:
this checks explicitly that the lifecycle is alive.
Depends on D6223
Reviewers: cedric, zmike, JackDanielZ
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6224
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Marcel Hollerbach [Tue, 29 May 2018 04:38:51 +0000 (21:38 -0700)]
eo: do not return efl_invalidated true when its not true
Summary:
the object is invalidated AFTER the parent is lost, (thats what the doc
says). Returning invalidated as true when the parent is still present is
thus not correctly.
Depends on D6222
Reviewers: cedric, zmike, JackDanielZ
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6223
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Marcel Hollerbach [Tue, 29 May 2018 04:38:40 +0000 (21:38 -0700)]
edje: fix lifecycle of swallowed children
Summary:
a swallowed child is per doc not deleted when the edje is deleted.
After the call to invalidate is finished all children will loose theire
parents and also be invalidated. However, in the efl_invalidate call,
the event EVAS_CALLBACK_DEL is issued, so this is the right spot. As in
legacy the swallows are in place when the EVAS_CALLBACK_DEL event is
issued.
Reviewers: cedric, raster, JackDanielZ, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6222
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Hermet Park [Tue, 29 May 2018 02:21:15 +0000 (11:21 +0900)]
evas gl: update example code for better user understanding.
Wonki Kim [Mon, 28 May 2018 12:32:12 +0000 (21:32 +0900)]
elementary: Modify key action logic for image.zoomable
Summary:
1. remove prior/next action
prior/next key action doesn't look suitable for image.zooamble.
It is not able to support bi-directional interaction.
2. remove logic that refers to step_size the logic has been removed
by applying this commit because api related with step_size has been removed
since the new scrollable interface introduced.
another patch may follow after discussing on community
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6221
YeongJong Lee [Mon, 28 May 2018 08:32:46 +0000 (17:32 +0900)]
efl_part: remove unnecessary default_xxx_part_get
Summary:
They can call default_xxx_part_get of layout.
ref
6e49db0739c38a378c48c6c880f5b41c986ee1e9
Test Plan:
elementary_test -to button
elementary_test -to 'efl.ui.button'
elementary_test -to 'efl.ui.popup'
elementary_test -to 'progressbar'
elementary_test -to 'slider'
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, herb, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6218
Stefan Schmidt [Mon, 28 May 2018 07:36:46 +0000 (09:36 +0200)]
build: make sure new eo header is distributed in tarball
In commit
8a513a522e90253ce7ec85e92c7bc58dfb22a2bc thsi new header was
added, but never made sure it lands into the distribution tarball.
Hermet Park [Mon, 28 May 2018 06:37:57 +0000 (15:37 +0900)]
elementary textpath: use job for deferred drawing task.
textpath performed drawing task multiple times unnecesarily.
It should be performed only one time after all setting up.
Hermet Park [Mon, 28 May 2018 06:21:22 +0000 (15:21 +0900)]
elementary ui_textpath: remove autofit api.
Toggling this option is unlikely happened by user because with autofit=false,
it doesn't gurantee readable visual text.
We don't need this stupid api yet. So remove it.
Youngbok Shin [Mon, 28 May 2018 05:48:41 +0000 (14:48 +0900)]
elementary textpath: update Evas map when text is updated
Summary:
Evas map was not updated when text was updated.
@fix
Test Plan:
1. Run the following test case.
elementary_test -to "efl.ui.textpath"
2. Toggle short text.
3. See a long line from the end of text which is wrong.
If you change angle, Evas map will be updated properly.
But, it should be updated when text is updated.
Reviewers: raster, cedric, thiepha, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6216
YeongJong Lee [Mon, 28 May 2018 03:57:00 +0000 (12:57 +0900)]
efl_ui_popup: use "elm.swallow.content" name instead of "default" for scroller
Summary:
efl_part don't support legacy aliases.
ref
495edbd9958ff077e44a62bf83f1a9032875f423
Test Plan:
1. elementary_test -to 'efl.ui.popup.alert.text'
2. elementary_test -to 'efl.ui.popup.alert.scroll'
Reviewers: Jaehyun_Cho, herb
Reviewed By: Jaehyun_Cho
Subscribers: stefan_schmidt, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6192
Carsten Haitzler (Rasterman) [Sun, 27 May 2018 10:48:48 +0000 (19:48 +0900)]
efl ui win - fix legacy theme support correctly
this fixes T6918. during development legacy theme support was b roken.
473e657120ffd9626b6ee8832c75f2f66c9a5351 broke it.
Carsten Haitzler (Rasterman) [Sun, 27 May 2018 08:10:19 +0000 (17:10 +0900)]
eet - check for null edd's and don't decode junk data
in the process of fixing a bug in elm config i found the eet will
decode junk data with a null edd. check for these where it was missing
and return null so it's easier to see a problem. not really a fix as
it's invalid use of the api, but it's nicer to debug...
Carsten Haitzler (Rasterman) [Sun, 27 May 2018 08:00:09 +0000 (17:00 +0900)]
elm config - fix derived save crash
derived shutdown nuked the edd's and eet still decoded something...
that was junk. oddly. this fixes T6879.
Carsten Haitzler (Rasterman) [Sat, 26 May 2018 19:52:03 +0000 (04:52 +0900)]
Revert "ecore-evas-x: set draw_block until the window receives a configure event"
This reverts commit
7b80038fa7b54cff27b463382283211727aaf104.
JackDanielz asked nicely, but this hasn't been reverted. As this
totally breaks enlightenment (it's black) and this happens on
everythng I've tested (1 laptop, desktop and Xephyr) I'm calling this
patch a dud.
Now... what kind of review is going on here? This hasn't been tested.
What kind of review doesn't build + run things?
for the reasons of poor review and massive horribler fully complete
desktop like breakage ... this gets reverted as master should not be
broken like this.
Cedric BAIL [Fri, 25 May 2018 17:40:56 +0000 (10:40 -0700)]
ecore_con: efl_net_socket_ssl_adopted_get is EFL_NET_SOCKET_SSL_PROTECTED.
Woochan Lee [Fri, 25 May 2018 17:28:39 +0000 (10:28 -0700)]
elm_spinner: Spinner value adjust when round enabled.
Summary:
The round value was not being applied when input the value as an internal entry.
@fix
Test Plan: elementary_test -> spinner sample.
Reviewers: cedric, woohyun, Jaehyun_Cho
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5843
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 25 May 2018 17:28:29 +0000 (10:28 -0700)]
ecore-evas-x: set draw_block until the window receives a configure event
Summary:
drawing a non-override window before receiving a configure event results
in an unsized window, breaking spec. it also prevents ecore-evas resize
callbacks from triggering, yielding undefined returns from functions which
attempt to get the geometry of the ecore-evas
fix T6907
Reviewers: cedric, raster
Reviewed By: cedric
Subscribers: #committers, vtorri
Tags: #efl
Maniphest Tasks: T6907
Differential Revision: https://phab.enlightenment.org/D6019
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Bryce Harrington [Fri, 25 May 2018 17:19:20 +0000 (10:19 -0700)]
eina: Improve eina_array function documentation
Summary:
Define return values when errors occur. Eliminate use of the term
'vector' to avoid confusion with eina_vector. Cleanup grammar
throughout.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6043
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 25 May 2018 17:14:36 +0000 (10:14 -0700)]
Revert "efl_ui_win: simplify checking theme version when adding frame"
Summary:
This reverts commit
f37b96a1de80c6f65306c96c6ebcdc69bafdbfa1.
as pointed out in D5957, this would break use of theme_set during the
efl_add constructor once this is implemented in the future
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6146
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 25 May 2018 17:09:46 +0000 (10:09 -0700)]
elm_notify: remove allow_events_set call in destructor
Summary:
4976f1fc5276835940610b72ca4fa48776fc9410 erroneously flipped the
bool flag on this call, accidentally creating another object during
deletion which is illegal now as the notify object is now unparented
at this point which will result in a CRI error
this call was never required in the first place as the corresponding
layout object would have been deleted automatically due to widget parenting
@fix
Reviewers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6147
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Fri, 25 May 2018 17:09:13 +0000 (10:09 -0700)]
edje: don't give a wrong Edje data when an Edje object has group parts
Summary:
_edje_part_fetch() function gets an Edje which has the requested Edje_Real_Part.
Basically, it gets main Edje of the given object.
But, if a requested part is in a GROUP part, it gets the Edje of GROUP part.
It shouldn't be passed to _edje_efl_text_text_get() function directly.
@fix
Test Plan: N/A
Reviewers: herdsman, raster, cedric, woohyun
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6149
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Fri, 25 May 2018 17:08:21 +0000 (10:08 -0700)]
elementary widget: Do super's efl_gfx_color_set to apply color to widget itself
Summary:
The efl_gfx_color interface was not applied properly.
The implementation code of evas_object_smart_color_set was moved
to efl_gfx_color_set implementation code. But, these two functions are not same.
In efl_gfx_color_set impl, it has to call super's color set to apply
the given color values to widget object itself.
This bug caused color_set/get test failure and the following bug.
1. elm_image_add
2. evas_object_color_set
3. elm_image_file_set
4. show. See the given color is not applied. It was applied in the past.
Test Plan: color_set/get to elm_image object is included in test suite.
Reviewers: raster, cedric, herdsman, woohyun
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6163
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
JunsuChoi [Fri, 25 May 2018 17:07:02 +0000 (10:07 -0700)]
ecore_con : Fix class check to check inner_socket class
Summary:
cl->socket is a Efl.Net.Socket_Simple. it is not inherit the Efl.Loop.fd class.
and The target of the class check have to be the inner_socket.
But inner_socket is Efl.Net.Socket_Ssl. Efl.Net.Socket_Ssl class is not inherit FD class.
Efl.Net.Socket_Tcp is inherit Efl.Loop.fd class. So, Need to add Efl.Net.Socket_Tcp to inheritance.
(The server side is a similar hierarchy. (ssl -> tcp -> ip -> fd))
Test Plan: N/A
Reviewers: cedric, jypark, myoungwoon, zmike, barbieri
Reviewed By: cedric
Subscribers: #committers, bowonryu, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6168
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Fri, 25 May 2018 17:04:49 +0000 (10:04 -0700)]
elm_interface_scrollable: change return value for post events.
Summary:
1. Scroller in scroller case, callback process should continue.
If child scroller does not scroll, parent scroller should be checked whether scroll or not.
So returning EINA_TRUE is necessary.
2. down.dragged flag is always EINA_FALSE, so scroll is never unlocked.
@fix
Test Plan:
precondition
elementary_config -> scrolling -> Set Scroll Smooth Amount to 0
elementary_test -> pagescroller
Reviewers: woohyun, zmike, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6187
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Lauro Moura [Fri, 25 May 2018 17:01:06 +0000 (10:01 -0700)]
efl_mono: Fix efl_add_internal_end call.
Summary:
It was missing setting the 'is_ref' parameter to 1 to mirror the
internal_start call.
Test Plan: make check
Reviewers: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6193
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Lauro Moura [Fri, 25 May 2018 17:00:40 +0000 (10:00 -0700)]
eo_cxx: Fix do_eo_add after lifecycle branch.
Summary:
Also changed the previously failing tests to use ck_assert_int_eqinstead
of fail_if for better reporting.
Test Plan: make check
Reviewers: cedric, felipealmeida
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6194
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Fri, 25 May 2018 16:59:01 +0000 (09:59 -0700)]
elementary textpath: improves text rendering quality of curved text
Summary:
There was wrong logic for calculating # of slices, dt, dist of each segment.
It caused bad rendering quality by putting too much slices on small text.
In addition, textpath didn't care about smoothness of curve's slope changing.
The patch fixes to check differences of previous points and next points for Evas Map.
So, textpath can show more smoothly curved text.
Also, it fixes "autofit" bug when text is much huge than given circle's size.
@tix
Test Plan:
- I'll attach screenshots for comparing rendering quality.
- To see "autofit" bug.
1. Run the following command.
ELM_ACCEL=gl ELM_SCALE=2.0 elementary_test -to "efl.ui.textpath"
2. Toggle "autofit" check box.
3. See the bug case. Textpath can't show all text properly.
Reviewers: raster, cedric, thiepha
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6195
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 25 May 2018 15:33:50 +0000 (08:33 -0700)]
elementary: fetch the model explicitely.
T6939
WooHyun Jung [Fri, 25 May 2018 07:42:52 +0000 (16:42 +0900)]
efl_ui_win: fix wrong comparison in icon_object_set
@fix
Cedric BAIL [Thu, 24 May 2018 22:54:00 +0000 (15:54 -0700)]
elementary: prevent model from being invalidated when their parent model get destroyed.
Cedric BAIL [Thu, 24 May 2018 21:48:03 +0000 (14:48 -0700)]
elementary: ctxpopup is using legacy Elm.List which use legacy Elm.Object.Item, fix accordingly.
Cedric BAIL [Thu, 24 May 2018 06:37:09 +0000 (23:37 -0700)]
elementary: fix elm_list items lifecycle.
Elm.List.Item lifecycle where an exception in Efl. They were trying to prevent the death of
there parent, to avoid dealing with safely walking on items list. This has been on the todo
list for years and is now fixed by this patch.
Cedric BAIL [Thu, 24 May 2018 06:12:02 +0000 (23:12 -0700)]
evas: make smart object deletion more robust to bad child behavior.
Cedric BAIL [Thu, 24 May 2018 03:24:21 +0000 (20:24 -0700)]
elementary: refactor filesector target cleanup to not leave function handler behind.
Cedric BAIL [Thu, 24 May 2018 03:23:48 +0000 (20:23 -0700)]
elementary: make sure to use the model that generated the event to fetch information from.
Cedric BAIL [Thu, 24 May 2018 03:19:31 +0000 (20:19 -0700)]
elementary: make sure fileselector button model has a parent and self destruct properly.
Cedric BAIL [Thu, 24 May 2018 03:18:18 +0000 (20:18 -0700)]
eio: enforce eio model to have a parent that provide main loop access.
Cedric BAIL [Thu, 24 May 2018 02:37:20 +0000 (19:37 -0700)]
ecore: during shutdown their is no need to delay anything.
Cedric BAIL [Thu, 24 May 2018 02:35:03 +0000 (19:35 -0700)]
eo: an object is invalidated if it is invalidated or if any parent is invalidated.
Cedric BAIL [Thu, 24 May 2018 01:03:56 +0000 (18:03 -0700)]
ecore_con: disconnect from the server as soon as it request it.
Ecore_Event can still be in flight while the client get freed by the server.
We are protected agaist that and keep the client partially alive until the event
are processed, but we need to disconnect from the server as soon as possible
as we might outlive the server.
Cedric BAIL [Wed, 23 May 2018 19:15:26 +0000 (12:15 -0700)]
evas: disable del hook when pushed inside the hash.
This is necessary in case of cycling init/shutdown as the hash will
destroy the Event, but the hook will instantly reinsert it.
Cedric BAIL [Tue, 22 May 2018 23:15:28 +0000 (16:15 -0700)]
eo: match raise of error level in tests.
Cedric BAIL [Tue, 22 May 2018 23:15:02 +0000 (16:15 -0700)]
eo: we are actually testing internal function too here.
Cedric BAIL [Tue, 22 May 2018 23:14:20 +0000 (16:14 -0700)]
eo: add infrastructure to test critical Eina Error.
Cedric BAIL [Tue, 22 May 2018 23:13:53 +0000 (16:13 -0700)]
eo: improve tests suite debugging by always displaying the error message before abort.
Cedric BAIL [Tue, 22 May 2018 21:10:48 +0000 (14:10 -0700)]
eo: move wref set to NULL to append after last event.
Making wref disapear before the last event require additional work to use
them during the FREE event. As I think we should introduce a wref that
disapear after the invalidate state, it makes sense to move that to a later
stage. Especially because their is no specific event related to them
being set to NULL.
Cedric Bail [Tue, 22 May 2018 05:35:19 +0000 (22:35 -0700)]
evas: improve test to actually test something meaningful.
Cedric BAIL [Mon, 21 May 2018 23:59:51 +0000 (16:59 -0700)]
elementary: fix configuration destruction by actually calling the proper way of destruction.
Cedric Bail [Thu, 17 May 2018 21:48:26 +0000 (14:48 -0700)]
evas: actually we expect gradient to live as long as the part that is using them.
Cedric Bail [Thu, 17 May 2018 21:08:05 +0000 (14:08 -0700)]
ecore_con: allow for NULL to do nothing.
Cedric Bail [Thu, 17 May 2018 21:07:46 +0000 (14:07 -0700)]
elementary: the config subsystem expect a stringshare.
Cedric Bail [Thu, 17 May 2018 20:44:29 +0000 (13:44 -0700)]
evas: multiple call to evas_object_del are allowed even after the first one succeeded.
Cedric Bail [Thu, 17 May 2018 19:06:44 +0000 (12:06 -0700)]
eo: allow efl_part during object invalidate.
Cedric BAIL [Tue, 15 May 2018 22:37:11 +0000 (15:37 -0700)]
eo: remove parent_sink as this hack should not be necessary anymore.
Cedric BAIL [Tue, 15 May 2018 22:35:48 +0000 (15:35 -0700)]
eo: try to make efl_add and efl_add_ref refcounting sane in all case.
Cedric BAIL [Tue, 15 May 2018 22:34:58 +0000 (15:34 -0700)]
ecore_file: on shutdown properly set to NULL to avoid confusion when cycling init/shutdown.
Cedric BAIL [Tue, 15 May 2018 22:32:14 +0000 (15:32 -0700)]
ecore: allow for NULL file handler request.
Cedric BAIL [Tue, 15 May 2018 22:29:15 +0000 (15:29 -0700)]
elementary: destroy timer as they could tick during shutdown.
Cedric BAIL [Tue, 15 May 2018 21:57:15 +0000 (14:57 -0700)]
elementary: properly destroy block events object during destruction.
Cedric BAIL [Tue, 15 May 2018 21:53:13 +0000 (14:53 -0700)]
evas: do not crash if constructor fail and invalidate is run on a partial object.
Cedric BAIL [Tue, 15 May 2018 20:27:23 +0000 (13:27 -0700)]
eo: improve error reporting to display object pointer (without accessing it).
Cedric BAIL [Tue, 15 May 2018 17:52:12 +0000 (10:52 -0700)]
elementary: cleanup genlist destructor to order content destruction correctly.
Cedric BAIL [Mon, 14 May 2018 23:15:48 +0000 (16:15 -0700)]
evas: make evas_object_free work in case of lost reference to Eo object.
This is clearly a workaround to a bad situation, but there is no case
that I can find that solely lead to object being NULL nor is there any
code that should do that, but still it does in some case...
Cedric BAIL [Mon, 14 May 2018 23:15:05 +0000 (16:15 -0700)]
evas: detect incoherency in object content and report problem.
Cedric BAIL [Mon, 14 May 2018 23:14:30 +0000 (16:14 -0700)]
evas: handle Evas_Object constructor failure case better.
Cedric BAIL [Mon, 14 May 2018 21:54:45 +0000 (14:54 -0700)]
edje: simplify part handling as we are now guaranteed that a part as no parent when reaching the del intercept.
Cedric BAIL [Mon, 14 May 2018 21:47:39 +0000 (14:47 -0700)]
eo: make sure that reporting object refcount during efl_noref, doesn't lead to recursive loop.
Cedric BAIL [Mon, 14 May 2018 21:47:07 +0000 (14:47 -0700)]
eo: add warning in case of a terrible situation happen.