[flang] Operator overloads for expression construction.

Original-commit: flang-compiler/f18@a4d3a736cf3d0c90fd5e26fb25b3adbc4530179a
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] clean up clang warnings from master

Original-commit: flang-compiler/f18@1c9aa95f8ddb2bd2b8366f84bd4cf7144de4c279
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] More refinement, use const on subexpressions.

Original-commit: flang-compiler/f18@f484325c61fd5d7d4aec1fdbbf24fb54a97be907
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Simplification

Original-commit: flang-compiler/f18@a50ce6e499f484deeb1296dbb1139a9b8ca91b4a
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] fix builds, all now clear

Original-commit: flang-compiler/f18@7c32a531a0cfe6a766fe0c2faa2b7e26ee957a14
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Dump complex expressions

Original-commit: flang-compiler/f18@da25b870d32bebc2b3055ede771efaf6701e8a3f
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] More dumping code

Original-commit: flang-compiler/f18@43d147144a843956ab37ae4714902795c652e347
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Use unique_ptr for operands.  Refactor comparisons.

Original-commit: flang-compiler/f18@92e154e76eeac6ea91c62cdc0081fb35258f8c78
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Expression formatting

Original-commit: flang-compiler/f18@3d0977a57e32460ac0cf808a7e4b5bcbdb3d30ba
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Change memcpy to memmove for overlap case.

Original-commit: flang-compiler/f18@cb400284e48a486922ee4420f02448eb68966fcf
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Numeric constant formatting and tests.

Original-commit: flang-compiler/f18@ade64420201c45d8082c65ba21e6e7d161605300
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Character LEN, operator overloadings

Original-commit: flang-compiler/f18@08c32de24cae7ea9091f665337c1c2386ec87a32
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Finish first cut at expression.h.

Original-commit: flang-compiler/f18@07142e7fad2b8c672df7549caec8be0d1c0d3856
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Expression work

Original-commit: flang-compiler/f18@b60c84fff491d19402f95f825b4be42f239ac2a9
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] reformat c++

Original-commit: flang-compiler/f18@6c5c9b316542b558d1d4e3883c92e172f374e230
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] first cut at expressions

Original-commit: flang-compiler/f18@b06c5486e4d80e017a9c697c79ac588a88498547
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] begin expression representation

Original-commit: flang-compiler/f18@627c057d5c8392914eb186e8f6dacab40b5a6666
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Documentation

Original-commit: flang-compiler/f18@27f6927053fa685b9366647fa02b595ffd830441
Reviewed-on: https://github.com/flang-compiler/f18/pull/111
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#110 from ThePortlandGroup/tsk1

Fix problems in PR 109 when compiling with clang.

Original-commit: flang-compiler/f18@f21c334589e580c1c32aa3b8abad000636283e8f
Reviewed-on: https://github.com/flang-compiler/f18/pull/110

[flang] Fix problems in PR 109 when compiling with clang.

This gets the code base back to compiling cleanly with clang after
pull request 109.

There were two overloadings of `Post(const parser::DeclarationTypeSpec::Type &)`.
The one in DeclarationVisitor needed to call the one in DeclTypeSpecVisitor.
This was fixed by introducing a new function, SetDerivedDeclTypeSpec, to do
the equivalent thing.

Original-commit: flang-compiler/f18@81e447bf4ec076f8fa823c0c61c9dd72e1f62fe4
Reviewed-on: https://github.com/flang-compiler/f18/pull/110

[flang] Merge pull request flang-compiler/f18#109 from ThePortlandGroup/tsk5

Name resolution for derived types.

Original-commit: flang-compiler/f18@5317d4f30ae926ee4f839d3afab68363d1d9c5c9
Reviewed-on: https://github.com/flang-compiler/f18/pull/109

[flang] Name resolution for derived types.

This consists of:
- a new kind of symbols to represent them with DerivedTypeDetails
- creating symbols for derived types when they are declared
- creating a new kind of scope for the type to hold component symbols
- resolving entity declarations of objects of derived type
- resolving references to objects of derived type and to components
- handling derived types with same name as generic

Type parameters are not yet implemented.

Refactor DeclTypeSpec to be a value class wrapping an IntrinsicTypeSpec
or a DerivedTypeSpec (or neither in the TypeStar and ClassStar cases).
Store DerivedTypeSpec objects in a new structure the current scope
MakeDerivedTypeSpec so that DeclTypeSpec can just contain a pointer to
them, as it currently does for intrinsic types.

In GenericDetails, add derivedType field to handle case where generic
and derived type have the same name. The generic is in the scope and the
derived type is referenced from the generic, similar to the case where a
generic and specific have the same name. When one of these names is
mis-recognized, we sometimes have to fix up the 'occurrences' lists
of the symbols.

Assign implicit types as soon as an entity is encountered that requires
one. Otherwise implicit derived types won't work. When we see 'x%y' we
have to know the type of x in order to resolve y. Add an Implicit flag
to mark symbols that were implicitly typed

For symbols that introduce a new scope, include a pointer back to that
scope.

Add CurrNonTypeScope() for the times when we want the current scope but
ignoring derived type scopes. For example, that happens when looking for
types or parameters, or creating implicit symbols.

Original-commit: flang-compiler/f18@9bd16da020b64b78ed3928e0244765cd2e2d8068
Reviewed-on: https://github.com/flang-compiler/f18/pull/109

[flang] Refactor DeclTypeSpec and DerivedTypeSpec classes.

Make DerivedTypeSpec a simple wrapper around the name of the type.
Leave out type parameter values until we are ready to resolve them
as well.

Change DeclTypeSpec to be an old-fashioned union with an enum to
indicate what is in it. std::variant doesn't work well here because
we wanted the enum visible in the class' API and there is not a
1-to-1 mapping between enumerators and data stored.

Original-commit: flang-compiler/f18@03bdeef790375ea7dbac6abf1118ec743c55a1b6
Reviewed-on: https://github.com/flang-compiler/f18/pull/109
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#107 from ThePortlandGroup/tsk2

Change how memory for Symbol instances is managed.

Original-commit: flang-compiler/f18@ccf6aeac622038c5d2a3151d4566aa2536e9aea2
Reviewed-on: https://github.com/flang-compiler/f18/pull/107

[flang] Change how memory for Symbol instances is managed.

With this change, all instances Symbol are stored in class Symbols.
Scope.symbols_, which used to own the symbol memory, now maps names to
Symbol* instead. This causes a bunch of reference-to-pointer changes
because of the change in type of key-value pairs. It also requires a
default constructor for Symbol, which means owner_ can't be a reference.

Symbols manages Symbol instances by allocating a block of them at a time
and returning the next one when needed. They are never freed.

The reason for the change is that there are a few cases where we need
to have a two symbols with the same name, so they can't both live in
the map in Scope. Those are:
1. When there is an erroneous redeclaration of a name we may delete the
   first symbol and replace it with a new one. If we have saved a pointer
   to the first one it is now dangling. This can be seen by running
   `f18 -fdebug-dump-symbols -fparse-only test/semantics/resolve19.f90`
   under valgrind. Subroutine s is declared twice: each results in a
   scope that contains a pointer back to the symbol for the subroutine.
   After the second symbol for s is created the first is gone so the
   pointer in the scope is invalid.
2. A generic and one of its specifics can have the same name. We currently
   handle that by moving the symbol for the specific into a unique_ptr
   in the generic. So in that case the symbol is owned by another symbol
   instead of by the scope. It is simpler if we only have to deal with
   moving the raw pointer around.
3. A generic and a derived type can have the same name. This case isn't
   handled yet, but it can be done like flang-compiler/f18#2 above. It's more complicated
   because the derived type and the generic can be declared in either
   order.

Original-commit: flang-compiler/f18@55a68cf0235c8a3ac855de7dc0e2b08690866be0
Reviewed-on: https://github.com/flang-compiler/f18/pull/107

[flang] Fix bug in adding symbols to parse tree.

We were collecting symbols in a map of SourceName to Symbol*.
This is wrong because sometimes different occurrences of a name
map to different symbols (e.g. in different scopes).
SourceName::begin() is unique for each occurrence so use that
as the map key instead.

The problem can be reproduced by running:
`f18 -fdebug-resolve-names -fparse-only -fdebug-dump-parse-tree`
on the following source. The two symbols 'i' should have different
types and they were both coming out as INTEGER because they both
pointed to the first symbol for 'i'.

```
module m
  integer :: i
contains
  subroutine s
    real :: i
  end
end
```

Original-commit: flang-compiler/f18@a165c717ff20d3ccca334b91fa538f54b54071cf
Reviewed-on: https://github.com/flang-compiler/f18/pull/107
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#106 from ThePortlandGroup/pmk-value

Rearrange some facilities into a new lib/common.

Original-commit: flang-compiler/f18@12477c3c3090b6cd2db0fa247aab073808a94511
Reviewed-on: https://github.com/flang-compiler/f18/pull/106

[flang] Rearrange some facilities into a new lib/common.

Original-commit: flang-compiler/f18@279af1e817b1266dd57689e462272f8e29496798
Reviewed-on: https://github.com/flang-compiler/f18/pull/106

[flang] Merge pull request flang-compiler/f18#105 from ThePortlandGroup/tsk2

Add name resolution tests

Original-commit: flang-compiler/f18@edf182d458cb5a362369fb0b71a3e98282439559
Reviewed-on: https://github.com/flang-compiler/f18/pull/105

[flang] Add name resolution tests

The Fortran source files in test/semantics all contain expected
errors in comments. The script test_errors.sh compiles a file with
'f18 -fdebug-resolve-names -fparse-only' and compares the actual
errors produced against the expected ones.

The change to resolve15.f90 is necessary because test_errors.sh can't
handle two expected errors for the same source line.

A useful command to run these is 'ctest -R f90 --output-on-failure'.
-R means only run tests with f90 in the name
--output-on-failure prints the output of test_errors.sh when a test
fails, showing the expected and actual messages that differ.

Original-commit: flang-compiler/f18@df18ee7bc95628503b37648d98c5ae25bc74b227
Reviewed-on: https://github.com/flang-compiler/f18/pull/105

[flang] Merge pull request flang-compiler/f18#101 from ThePortlandGroup/pmk-evaluate

Basic operation evaluation framework

Original-commit: flang-compiler/f18@e91fac085d347639d1ddc5e6baf8d9b6fc41f3f3
Reviewed-on: https://github.com/flang-compiler/f18/pull/101

[flang] Test 64-bit reals too.

Original-commit: flang-compiler/f18@67fd5514417b2c920be85e0919bf06b06a399e3c
Reviewed-on: https://github.com/flang-compiler/f18/pull/101

[flang] Address review comments

Original-commit: flang-compiler/f18@d96917c70130b12462d28189ded5e6243e8c854e
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More rearrangement, and debug an edge case with Underflow flag.

Original-commit: flang-compiler/f18@57ef08433ebc1b174551dfaca0c57ba97a1d7806
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Move member functions complex.h -> complex.cc

Original-commit: flang-compiler/f18@445333b13e212816f42b38c940b89e6a90708414
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Remove work-around in resolve-names.cc.

Original-commit: flang-compiler/f18@5dc0e037f59f6e58d45d7f65ec52e7cd5525b78c
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Cleaning up Real<> for review.

Original-commit: flang-compiler/f18@a87f324a7fd9f5f2e6dcc80b537c90ff3eb49484
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Prepare for review.

Original-commit: flang-compiler/f18@266d25f630b459d1e20aa4dc9074732ad1fd07b5
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Less exhaustive REAL testing by default.

Original-commit: flang-compiler/f18@d61ac7da9bf719fdda81821aab8fb2b7503f5367
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] COMPLEX

Original-commit: flang-compiler/f18@452d602fbb5931e29f4e8450660705297c2672c5
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] LOGICAL

Original-commit: flang-compiler/f18@6ec49f6edc3fc2bc4475bd08b4d3f2769b6fc441
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Revamp type.h, add LOGICAL

Original-commit: flang-compiler/f18@f7d77887a2a3f6bf9991181abb09911dd75d8e20
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] All operations now work and match x86, all modes and flags.

Original-commit: flang-compiler/f18@c69eef6524c086403e3f29c4a983514a9f2244bc
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More real work.  All ops, rounding modes, and flags good except for division.

Original-commit: flang-compiler/f18@ea697295db84b64b1c13144e3b5eaef9a879e319
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Check flag bits.

Original-commit: flang-compiler/f18@b63e39aae7c4c1de2fbdca24aa096d594039e934
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Multiplication, more tests.

Original-commit: flang-compiler/f18@e7ef16d2166cc946d59dd072754f8a347290e00a
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Refactor rounding code.

Original-commit: flang-compiler/f18@8ef2418791e62d8a90802a2e6754975a52412479
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Get real add/subtract working and tested.

Original-commit: flang-compiler/f18@c1b4389638d83cf9be712afc43cddc5d57e4dd48
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] start negative number tests

Original-commit: flang-compiler/f18@1b52ec8d3bc01640a46b2561918c5bb608d64d80
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Get back to passing all tests.

Original-commit: flang-compiler/f18@d08dc86ede2a6a3c2b14b03f1cc8be9e924c0aff
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Use EnumSet<> for real flags

Original-commit: flang-compiler/f18@a61f193036e6ea33e5e28bc23ceeb2c13ee14ff2
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] some real debugging

Original-commit: flang-compiler/f18@9653814ed3623f2abf592242b6d914bddc8766c7
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] begin testing reals

Original-commit: flang-compiler/f18@9d261b594bbf2a6dcec833239635599b28007e4d
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Convert REAL code to use IEEE encodings.

Original-commit: flang-compiler/f18@b36e50f46566cbb6975fc8c9325a003ef6abfcd9
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] real work

Original-commit: flang-compiler/f18@030347a906eda6384fd4d69dfe7d8e638aee9a2d
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More work on reals.

Original-commit: flang-compiler/f18@3ba634a2140f413f1e7ecb1ac570aa6fc73f0cd7
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] more work on reals

Original-commit: flang-compiler/f18@3afe85bf153e39e20fd2562c605167caf48e7cff
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] begin real.h

Original-commit: flang-compiler/f18@b0f0cd896161d769efc3f499cd3ae1359c82953a
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] bugfixing from clang build

Original-commit: flang-compiler/f18@a05e108288065ebea3976922fb511e8c1851bd76
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Reading numbers from strings.

Original-commit: flang-compiler/f18@8cbadfe7778a400756bc34dcbb5fe39334a742f8
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Template specializations and more automatic configuration

Original-commit: flang-compiler/f18@a230a539076bd57f64f1d2fd63852941453c4cda
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Rename fixed-point to integer.

Original-commit: flang-compiler/f18@3fe9c505a58df5fcd1e2966451cba82c295200bd
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More tests; full build and test cycle.

Original-commit: flang-compiler/f18@ac363643042cbb3c39234196f2a8c815af359199
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More tests

Original-commit: flang-compiler/f18@e4371fca37a16c5dd9eea5a846248ce19c9cdb6b
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] More intrinsics

Original-commit: flang-compiler/f18@55f974be59e2a691439159c99bef0f3250eb8fb3
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Add pop count and parity code and tests.

Original-commit: flang-compiler/f18@a77f2831833551407f2a29e019b61f0da7bc66ec
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Complete conversion to value semantics

Original-commit: flang-compiler/f18@e98206ca97530e4d5532a6174582ed3897533a8e
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Converted multiplication

Original-commit: flang-compiler/f18@7d4c3182105d4736ffc4e678b647b1013f7f33be
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Converted shift intrinsics.

Original-commit: flang-compiler/f18@2e9be8ad66e6af9e7ccff2807645212311805974
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Continue conversion to value semantics

Original-commit: flang-compiler/f18@03fe2666110ce464da49190e83c703031edee932
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Begin conversion to value semantics.

Original-commit: flang-compiler/f18@9ea9dae7e7ccb2d73297bb4a1e4e073e8dda30cb
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Reformat

Original-commit: flang-compiler/f18@104ca5f4c6c462ba74b500a00badc916605e4f66
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Testing framework, debugging of fixed-point code.

Original-commit: flang-compiler/f18@a8fb2d75a50fb958079fa81fc7a37a2a08e8e78c
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] unit testing for LZBC

Original-commit: flang-compiler/f18@c8541fb8fbdd0ee35afe53ed1fb685573712b950
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] add fixed-point.h

Original-commit: flang-compiler/f18@21c85a5c21aa15ad2a29ea9f2af2bf5357d2f3c6
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] begin work

Original-commit: flang-compiler/f18@82e434bf5966afa6e86a24a4de69d1ab537eb607
Reviewed-on: https://github.com/flang-compiler/f18/pull/101
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#103 from ThePortlandGroup/pmk-issue98

Issue 98, better error recovery for specification-part

Original-commit: flang-compiler/f18@0239a080e0a387aeb0a45e750c82c230d6a1b7c1
Reviewed-on: https://github.com/flang-compiler/f18/pull/103

[flang] Issue 98, better error recovery for specification-part

Original-commit: flang-compiler/f18@0b0812a82b15decf430de2c3ca991623cf53e5e2
Reviewed-on: https://github.com/flang-compiler/f18/pull/103

[flang] Merge pull request flang-compiler/f18#102 from ThePortlandGroup/pmk-omp-fix

Allow tab in fixed form compiler directives.  Reformat C++.

Original-commit: flang-compiler/f18@1b7519b5a8209a1cb0504fbfcd3d3b124aa2be3a
Reviewed-on: https://github.com/flang-compiler/f18/pull/102

[flang] Allow tab in fixed form compiler directives.  Reformat C++.

Original-commit: flang-compiler/f18@59ba17cb2478bd0b0f4ed6084c424677c7b46371
Reviewed-on: https://github.com/flang-compiler/f18/pull/102

[flang] Merge pull request flang-compiler/f18#100 from ThePortlandGroup/tsk5

Remove extraneous Pre/Post for ProcedureDeclarationStmt

Original-commit: flang-compiler/f18@c7cf8c09b91da4bbea14092a3107fc5904312e1c
Reviewed-on: https://github.com/flang-compiler/f18/pull/100

[flang] Remove extraneous Pre/Post for ProcedureDeclarationStmt

clang give a compilation error on resolve-names.cc because there are
two overloadings of Pre(ProcedureDeclarationStmt) available in
ResolveNamesVisitor. One is defined in DeclTypeSpecVisitor and the other
in DeclarationVisitor. They are both brought in to ResolveNamesVisitor
via `using` statements.

The one in DeclarationVisitor is the one that is supposed to be called.
The other should have been removed when this one was added. This is the
one that gcc chooses to call, so this doesn't change any behavior.

The same applies to the Post method as well.

Original-commit: flang-compiler/f18@872f8faf96164a01f18100fc1942f68523be6d76
Reviewed-on: https://github.com/flang-compiler/f18/pull/100

[flang] Merge pull request flang-compiler/f18#99 from ThePortlandGroup/tsk7

Add Dump() routines for debugging.

Original-commit: flang-compiler/f18@cf7d2785aa5064708b0f67e897a850df26f927e8
Reviewed-on: https://github.com/flang-compiler/f18/pull/99

[flang] Add Dump() routines for debugging.

Add Dump() routines based on operator<< for the type so that they are
easy to call from the debugger. Overload for both pointer and reference
types and for dumping to std::cerr or a specific ostream.

Original-commit: flang-compiler/f18@ec6676eff04a0b231f7f5f3e1e2486f2c93e2810
Reviewed-on: https://github.com/flang-compiler/f18/pull/99

[flang] Merge pull request flang-compiler/f18#97 from ThePortlandGroup/tsk5

Process procedure declarations and derived types.

Original-commit: flang-compiler/f18@d356b3b7c46ffd89c02761241a7d5589acd2b0cd
Reviewed-on: https://github.com/flang-compiler/f18/pull/97

[flang] Address review comments.

Replace operator=(Symbol) and operator=(DeclTypeSpec) with set_symbol()
and set_type() to make it clearer. Eliminate the move constructor as it
is not needed. Make all but the accessor functions out-of-line.

Change HasExplicitType() to NeedsExplicitType(), reversing its sense.
HasExplicitType() returned true for symbols that didn't have or need an
explicit type, which was confusing.

Original-commit: flang-compiler/f18@ada13ac6a32145fe260d78cb0e736998e5eabd15
Reviewed-on: https://github.com/flang-compiler/f18/pull/97

[flang] Process procedure declarations and derived types.

Add ObjectEntityDetails and ProcEntityDetails to distinguish between an
entity from an object-decl and one from a proc-decl. When we don't know,
it stays as EntityDetails until it is resolved. DeclareEntity() in
DeclarationVisitor creates this kind of symbol.

Add flags to Symbol as a convenient place for boolean flags common to
many kinds of symbols. Use it to mark symbols known to be functions or
subroutines so that we can report errors when they are used incorrectly.
Improve handling of EXTERNAL statement.

Handle ProcDecl nodes and add symbols for them.

Partial processing of derived types. Data component declarations are
processed and added to the derived type. Define TypeBoundProc and
TypeBoundGeneric in type.h. Procedure components, type-bound procedures,
etc. are not handled yet and nothing is done with the derived type once
it is created. Eliminate DerivedTypeDefBuilder in favor of just setting
fields in derivedTypeData_.

Add GetDeclTypeSpec to go with BeginDeclTypeSpec and EndDeclTypeSpec, to
avoid directly access the private variable.

Add tests in resolve20.f90 for errors related to procedure declarations.
Add missing copyrights to other tests.

Original-commit: flang-compiler/f18@40e65c14656a1c60eae5a8fdfbdcab062ad6f1d2
Reviewed-on: https://github.com/flang-compiler/f18/pull/97
Tree-same-pre-rewrite: false

[flang] Add MessageHandler::Say2.

This handles the common case of an error message referring to
a name, and an attached message referring to another name.
For example, reporting an error where a name is already declared
and mentioning the previous declaration.

Original-commit: flang-compiler/f18@901b50dcf2860c5fcd5f94f0198981fe871d6716
Reviewed-on: https://github.com/flang-compiler/f18/pull/97
Tree-same-pre-rewrite: false

[flang] Extract DeclarationVisitor from ResolveNamesVisitor

The is a refactoring to move all handling of declarations from
ResolveNamesVisitor to a new class. No function change.

Original-commit: flang-compiler/f18@2a5589ab969421b1723c63105fe6922941ec1096
Reviewed-on: https://github.com/flang-compiler/f18/pull/97
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#96 from ThePortlandGroup/omppar

Omppar

Original-commit: flang-compiler/f18@8c259b93004558b74ae9c771e319c18ab86ea409
Reviewed-on: https://github.com/flang-compiler/f18/pull/96

[flang] Fix comment in openmp-grammar.h.  Fix unparse of reduction operator.

Original-commit: flang-compiler/f18@f6a7a03492525bcdf31e61f3a71e28cbe5818e95
Reviewed-on: https://github.com/flang-compiler/f18/pull/96

[flang] Remove unintended change.

Original-commit: flang-compiler/f18@a545cd5de4f16accf7862df0f9c895cede7b432f
Reviewed-on: https://github.com/flang-compiler/f18/pull/96
Tree-same-pre-rewrite: false

[flang] Fix space in issue unparse.cc  between directive and its first clause.

Original-commit: flang-compiler/f18@d9478c1a59050e59b14bf57d5e62c88c71bbe58a
Reviewed-on: https://github.com/flang-compiler/f18/pull/96
Tree-same-pre-rewrite: false

[flang] update unparsing openmp directives and clauses.

Original-commit: flang-compiler/f18@76121cda6c29404c232453f7302ac39eb0f9dbce
Reviewed-on: https://github.com/flang-compiler/f18/pull/96
Tree-same-pre-rewrite: false

[flang] Update unparse.cc and move declarative directives for now.

Original-commit: flang-compiler/f18@d79503f98ffc1f1975533e0a9ec94f0cbeb5b9fd
Reviewed-on: https://github.com/flang-compiler/f18/pull/96
Tree-same-pre-rewrite: false

[flang] add more clauses, declarative directives, standalone directives, and directives enclosing do loop.

Original-commit: flang-compiler/f18@483a54b0c890a550165e985f1ae10c4ab9c5ac79
Reviewed-on: https://github.com/flang-compiler/f18/pull/96
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#95 from ThePortlandGroup/tsk3

Improvements to generics.

Original-commit: flang-compiler/f18@4d1664206f76c4f7f749113e09a0173fe4eb64f9
Reviewed-on: https://github.com/flang-compiler/f18/pull/95

[flang] Improvements to generics.

When a generic or specific procedure is use-associated, make a copy of
it in the current scope (replacing the symbol that has UseDetails) so
that we can make changes to it. This permits a generic to be defined in
one module and extended with more specific procedures in another.

When a specific procedure has the same name as its generic, it can't be
stored directly in the scope because that is indexed by name and the
generic is already there. So instead we store the specific in the
GenericDetails of the generic symbol.

Enforce the rule that a generic and a procedure can only have the same
name if the procedure is one of the specifics of the generic.

Refactorings done is support of this change:
- Add FindSymbol() and EraseSymbol() as helpers to find or erase a
  symbol in the current scope. Make use of FindSymbol() where appropriate.
- Add SayAlreadyDeclared() to report a common error.

Original-commit: flang-compiler/f18@be479b988772c942a473cb0453b906ed51cea498
Reviewed-on: https://github.com/flang-compiler/f18/pull/95

[flang] Create LICENSE

We expect to adopt the llvm.org license in the near future.

Original-commit: flang-compiler/f18@a1a01e949b389db784127f9ccbddaad460335c3a

[flang] Update build instructions (flang-compiler/f18#94)

* Update build instructions

Add an overview and update the build instructions for f18.

Original-commit: flang-compiler/f18@a60060cfe110cbb32705408b42755d03f69e3302
Reviewed-on: https://github.com/flang-compiler/f18/pull/94