Yaowu Xu [Tue, 1 May 2012 19:25:56 +0000 (12:25 -0700)]
Added usage info on command line options
This commit added usage information that was missed in usage output.
Change-Id: If1a85bcc20131314f5d047c6db4e76a40d945e66
Ronald S. Bultje [Mon, 30 Apr 2012 23:32:12 +0000 (16:32 -0700)]
Fix inversion of probability and value in calls to vp8_cost_bit().
Change-Id: I9f1686249ac812f7b9b872eabe3970d1dfb25e56
Deb Mukherjee [Mon, 30 Apr 2012 19:24:22 +0000 (12:24 -0700)]
Turning off filter search for now to improve encode speed.
Change-Id: I87291fb40c745f34c36b067f47abdf69774a812f
Deb Mukherjee [Mon, 30 Apr 2012 18:03:24 +0000 (11:03 -0700)]
Minor cleanup in tokenize.h
Removes a set of spurious declarations that were inadvertently checked
in.
Change-Id: I2f80b6b66d2ec9ea667c810eaf1a6e7d52478c67
Adrian Grange [Fri, 27 Apr 2012 22:09:57 +0000 (22:09 +0000)]
Merge "Removed MV costing from ARNR filtering" into experimental
Adrian Grange [Thu, 26 Apr 2012 17:37:52 +0000 (10:37 -0700)]
Removed MV costing from ARNR filtering
The ARNR filter uses a motion compensated temporal filter,
but the motion estimation implementation accounts for the
cost of the mv in its decision making process. The ARNR
filter uses a dummy cost table initialized to 0 as a way
to ignore the mv costs (which are irrelevant to the filter).
This CL modifies the ARNR filter implementation to so that
the mv costing is ignored without the requirement for
dummy tables.
Change-Id: I0dd9620c3b70682f938b2a70912c11d4d7c9284c
Deb Mukherjee [Mon, 16 Apr 2012 21:53:37 +0000 (14:53 -0700)]
Adds search option for best interpolation filter.
Adds a speed feature to conduct a brute force search among a set of
available interpolation filters for the best one in an RD sense.
There is a gain of 0.4% on derf, 1.0% on Std-HD.
Patch 2: A macro added to determine if the encoder state is reset
for each new filter tried.
Patch 3: rebase, also fixes a bug (decodframe.c) introduced by a
couple of missing function pointer assignements.
Patch 4: rebase.
Change-Id: Ic9ccca9d8c35c6af557449ae867391a2f996cc29
Yaowu Xu [Wed, 25 Apr 2012 15:47:33 +0000 (08:47 -0700)]
Merge QIMODE experiment
This commit merge the QI mode experiment. As the experiment affects
the encoding of intra coding modes on key frame only, the overall
effect of the experiment on encoding tests is insignificant.
Change-Id: I9e4e3933adface88867ad429cee3986e529c511d
Yaowu Xu [Wed, 25 Apr 2012 15:33:30 +0000 (08:33 -0700)]
Merge UVINTRA experiment
The commit merges the UVINTRA experiment and removed the related
macros. The overall effect of the experiment is a small gain (.1%
on derf)
Change-Id: Ia34b3312fb9b5b34c9ba111bf0fa78c6f78ac80b
Deb Mukherjee [Tue, 24 Apr 2012 23:07:18 +0000 (23:07 +0000)]
Merge "Differential encoding of probability updates" into experimental
Ronald S. Bultje [Tue, 24 Apr 2012 18:07:27 +0000 (11:07 -0700)]
Remove unused header files.
Change-Id: I8708358bb37edabcbe5dfc755ed18791d9e143c4
Deb Mukherjee [Thu, 12 Apr 2012 16:24:03 +0000 (09:24 -0700)]
Differential encoding of probability updates
Adds differential encoding of prob updates using a subexponential
code centered around the previous probability value.
Also searches for the most cost-effective update, and breaks
up the coefficient updates into smaller groups.
Small gain on Derf: 0.2%
Change-Id: Ie0071e3dc113e3d0d7ab95b6442bb07a89970030
Ronald S. Bultje [Fri, 20 Apr 2012 21:25:36 +0000 (14:25 -0700)]
Hide some code behind CONFIG_COMP_INTRA_PRED.
Change-Id: I7c0597dede20cc71145c053f76bd99aaf759d144
Yaowu Xu [Fri, 20 Apr 2012 16:14:26 +0000 (09:14 -0700)]
change to allow 8x8 transform always
This commit changed to enable the usage 8x8 transform for all frame
type, all resolution and all quantizer range. This has an overall
benefit .2% to .3% in term of compression, but more importantly,
the difficult clips benefits much more, up to 2% to 3% on clips
like football, harbour and so on.
We observed some weird humps on very high end on a couple of youtube
clips, but have determined the underly cause was the aggressive zbin
having an effect of lowering rate with lower quality, which have
an impact on slide show clips around 60DB.
The commit does not change the association between prediction mode
and transform size.
Change-Id: I33043bdce6207528ae00b4a4b26d8ff63cfea1f4
Yaowu Xu [Tue, 17 Apr 2012 22:14:45 +0000 (15:14 -0700)]
added reset of rate estimates for each mode
This is to prevent the evaluation of a mode from using values left
over from a mode evaluated prior in the loop.
Change-Id: Ife2c6ceb76d2f7365fd262515d3ae48229033c2d
Ronald S. Bultje [Thu, 19 Apr 2012 17:07:14 +0000 (10:07 -0700)]
Fix splitmv/compound prediction when eightpel is enabled.
Change-Id: I9d6083d54e3d478ec20dc6dc48d3f45eb5c7e16b
Ronald S. Bultje [Wed, 18 Apr 2012 20:51:58 +0000 (13:51 -0700)]
Compound prediction for splitmv macroblocks.
Change-Id: I0af3395500b1cb0ed629249eb6636a0c9322cb18
Adrian Grange [Wed, 18 Apr 2012 16:08:55 +0000 (09:08 -0700)]
Added update of mode context pointers in decoder
With the NEWENTROPY experiment enabled encoding certain clips
produced invlid bitstreams, or files that had a high degree
of artefacts.
This was the results of pointers in MACROBLOCKD not being
setup correctly (mode_info_context and prev_mode_info_context).
Change-Id: Ice13e1efa8bd122997d2f8f3f1e761c6c16e0403
Adrian Grange [Wed, 18 Apr 2012 16:21:16 +0000 (16:21 +0000)]
Merge "Added save coding context & modified MV bounds" into experimental
Yaowu Xu [Tue, 17 Apr 2012 18:37:23 +0000 (18:37 +0000)]
Merge "Added intra mode probabilites into coding_context" into experimental
Yaowu Xu [Tue, 17 Apr 2012 16:26:19 +0000 (09:26 -0700)]
Added intra mode probabilites into coding_context
These contexts need to be saved and restored for recode, otherwise
encoder/decoder mismatch happens for some clips (eg._mobcal 720p)
Change-Id: Ic65cfa0bf56ed0472ecab962ce31394d59d344bf
Deb Mukherjee [Mon, 16 Apr 2012 18:38:15 +0000 (11:38 -0700)]
Bug fix introduced from a recent refactoring of skip coding.
Change-Id: Iccd0f09a4db02a2bad644deb3c76189c5f5612a3
Adrian Grange [Fri, 13 Apr 2012 17:26:49 +0000 (10:26 -0700)]
Added save coding context & modified MV bounds
Added code to save the coding context in vp8_rd_pick_inter_mode
when the coding mode is forced to ARF(0,0).
Also, modified the MV bounds computation to comply with the
change in MV border from 32 to 64 pixels.
Change-Id: I96963a6f5f4d04ce84c807ae11e0635177c3ad6c
Deb Mukherjee [Wed, 11 Apr 2012 21:32:20 +0000 (14:32 -0700)]
Turning off interpolation filter selection
Turning off the interpolation filter selection based on edge
proportion. This heuristics has not been working as well as
expected and I have started a more rigorous investigation into
this. We can turn this off for now since it is unnecessarily
slowing things down.
Rebase.
Change-Id: Ic5958b2b3a35ec2d8eb73b6d81617ca8fbe07e74
Yaowu Xu [Wed, 4 Apr 2012 14:24:10 +0000 (07:24 -0700)]
a set of minor fixes
This commit tries to address an issue related to the oddity shown on
HD _mobcal clip, where some rather ugly blocks shown in the second
frame at low-mid bit rates if the third frame is not made a key frame
by he encoder. The fixes include: 1) made calls to sad_16x16 to be
consistent with function prototype. 2) remove the error bias to intra
and golden in mbgraph search. 3) changed the error accumulation on
inter_segment encoding to avoid potential out-of-range. 1) has no
effect on encoding results.
Encoding test show that the overall effect of the commit helps about
.2%(HD) to .3%(cif)
Change-Id: I930975a2d0c06252f01c39e0a02351529774e30b
Yaowu Xu [Wed, 4 Apr 2012 14:24:10 +0000 (07:24 -0700)]
Adjust the key frame placement condition
The commit removed a limit on key frame detection, which caused a big
drop in all metric measurements for standard HD clip such as _mobcal.
This single change helps two standard HD clips by a huge amount, which
help the overall std-hd set by 2.4% (glb psnr), 0.9% (avg_psnr), 2.1%
(vpxssim).
In the result page:
http://pafr9.prod.google.com:26163/?/cns/rc-d/home/on2-prod/sunkaras/borg-test/yaowu
2012_04_02_1649_yaowu_bugfix_std-hd
2012_04_03_1452_yaowu_hump_std-hd
represent the encoding test results and std-hd set prior and after this
commit respectively.
Change-Id: Ie4313e317c737ea0e699c3a7919c1376744baa1a
Yaowu Xu [Tue, 3 Apr 2012 16:12:10 +0000 (09:12 -0700)]
changed function prototype for macro_block_yrd
This commit has made macro_block_yrd_8x8 and macro_block_yrd_8x8 to
take same parameters. It also removed a few unnecessary shifts that
has the potential to create out-of-range distortion values.
Change-Id: I4ec5afb307c3685c2a67a07c2850f0927d214455
Paul Wilkins [Wed, 11 Apr 2012 16:14:46 +0000 (17:14 +0100)]
Delete unused function.
Deleted check_gf_quality().
Change-Id: If75fbd84accb1f6471ad6ea6ff2b65ae99976f5d
Paul Wilkins [Wed, 11 Apr 2012 14:44:14 +0000 (15:44 +0100)]
Refactoring of encode loop and bitstream packing
Some code re-factored / moved to allow the main
pack operation inside the recode loop so that the
size estimate is accurate.
Deletion of some redundant code relating to one pass.
Aproximate improvement over March 27 code base:
Derf 0.0%, YT 0.5%, YThd 0.3% Std_hd 0.25%
Change-Id: Id2d071794ab44f0b52935f6fcdb5733d09a6bb86
Paul Wilkins [Wed, 11 Apr 2012 13:37:48 +0000 (14:37 +0100)]
Changes to costing of skip.
Update the costing of skip in the recode loop and rd code.
Change-Id: I2e5ebbd7ddf201212b32441321e12626cd0423e9
Paul Wilkins [Tue, 27 Mar 2012 12:01:34 +0000 (13:01 +0100)]
T8x8 zbin and rate control changes.
Some adjustments to zbin for t8x8.
Changes to rules for sizing forced key frames.
Some extra stats output in tmp.stt.
Approximate gain on YT-hd set 0.5%
There are still issues in sizing key frames and gf/arf frames
when the image is largely static. These in part relate to
problems with cost estimates in the recode loop.
Change-Id: I6f0159dc8a8faeab4115a19c668d442491619a68
Adrian Grange [Fri, 6 Apr 2012 23:38:34 +0000 (16:38 -0700)]
Superblock encoding order
This is the first patch to add superblock (32x32) coding
order capabilities. It does not yet do any mode selection
at the SB level, that will follow in a further patch.
This patch encodes rows of SBs rather than
MBs, each SB contains 2x2 MBs.
Two intra prediction modes have been disabled since they
require reconstructed data for the above-right MB which
may not have been encoded yet (e.g. for the bottom right
MB in each SB).
Results on the one test clip I have tried (720p GIPS clip)
suggest that it is somewhere around 0.2dB worse than the
baseline version, so there may be bugs.
It has been tested with no experiments enabled and with
the following 3 experiments enabled:
--enable-enhanced_interp
--enable-high_precision_mv
--enable-sixteenth_subpel_uv
in each case the decode buffer matches the recon buffer
(using "cmp" to compare the dumped/decoded frames).
Note: Testing these experiments individually created
errors.
Some problems were found with other experiments but it
is unclear what state these experiments are in:
--enable-comp_intra_pred
--enable-newentropy
--enable-uvintra
This code has not been extensively tested yet, so there
is every likelihood that further bugs remain. I also
intend to do some code cleanup & refactoring in tandem
with the next patch that adds the 32x32 modes.
Change-Id: I1eba7f740a70b3510df58db53464535ef881b4d9
Deb Mukherjee [Wed, 28 Mar 2012 22:19:45 +0000 (15:19 -0700)]
Bug fix in probability update savings computation
Found this bug while tracking down some anomalies in my experiments.
Since vp8_cost_one and vp8_cost_zero return unsigned int, the
bit shift by 8 will be incorrect if the value is negative.
I am cautiously optimistic that this fix will make the prob
updates more correct and somewhat improve results across the board.
But the update probabilities will need to be retuned I think.
Patch 2: Adding more of the same fixes using a macro.
Change-Id: I1a168f040e74e8c67e7225103b1c2af9a611da49
Ronald S. Bultje [Thu, 22 Mar 2012 17:03:14 +0000 (10:03 -0700)]
Only enable compound prediction if multiple reference frames are present.
Change-Id: Ia52ac825400eb83ff663e3a05a3fe0b3526bac9a
Yaowu Xu [Mon, 19 Mar 2012 18:03:27 +0000 (11:03 -0700)]
enable 8x8 transform for MBs in intra frames
When ac_yquant>171, a key frame is enabled to use 8x8 transform. In
such case, MBs with DC_PRED or TM_PRED are selected to use T8x8. This
change helped the full STD-HD set by ~.1% or so, which is reasonable
considering how often key frame occurs in these encodings.
Change-Id: Id17009ef6327252177b19e6bf0d6628827febaf1
Paul Wilkins [Wed, 21 Mar 2012 18:22:33 +0000 (18:22 +0000)]
Only support improved quant
Deprecate fast quant and strict_quant code.
Small effect on quality as fast was used in first pass but the
effect is basically neutral across the derf set.
The rationale here is to reduce the number of code paths for
now to make experimentation easier. Optimized and fast code
options can be re-introduced later along with other encode
speed options.
Change-Id: Ia30c5daf3dbc52e72c83b277a1d281e3c934cdad
Paul Wilkins [Tue, 20 Mar 2012 14:20:36 +0000 (14:20 +0000)]
Merge Exact Quant
Change-Id: Id2412a7f24a7c1016ec9fc3b9b0fbd16871f374a
Deb Mukherjee [Mon, 19 Mar 2012 14:53:05 +0000 (07:53 -0700)]
Making subpel filters switchable at frame level
Various refactoring to make the subpel motion compensation
filters switchable by a frame level field.
Two types of 8-tap filters are supported in addition to the existing
bilinar and sixtap filters. One is the default 8-tap and the
other has a sharper cut-off for use with frames with substantial
edge content.
Patch 2: Added a preliminary strategy for filter selection based on
edginess detecton. Also includes some filter changes.
Change-Id: I866085bda5ae143cfdf2ec88157feaabdf7bd63a
Deb Mukherjee [Mon, 19 Mar 2012 18:02:04 +0000 (11:02 -0700)]
Adding contextual coding of mb_skip_coeff flag.
Using contextual coding of the mkb_skip_coeff flag using the
values of this flag from the left and above. There is a small
improvement of about 0.15% on Derf:
http://www.corp.google.com/~debargha/vp8_results/mbskipcontext.html
Refactored to use pred_common.c by adding a new context type.
Results on HD set (about 0.66% improvement):
http://www.corp.google.com/~debargha/vp8_results/mbskipcontext_hd.html
Incliding missing refactoring to use the pred_common utilities.
Change-Id: I95373382d429b5a59610d77f69a0fea2be628278
Yaowu Xu [Tue, 13 Mar 2012 17:26:53 +0000 (10:26 -0700)]
added clamp for 2nd motion vector
The commit added a clamp to the 2nd motion vector used in compound
prediction to insure mv within UMV borders. The clamp is similar to
that of the first motion vector except that No SPLITMV is ever used
for the 2nd motion vector.
Change-Id: I26dd63c304bd66b2e03a083749cc98c641667116
Yaowu Xu [Wed, 7 Mar 2012 20:25:50 +0000 (12:25 -0800)]
Added encode/decode recon buffer match test to vpxenc
The commit added a new command line option --test-decode to vpxenc.
The option enables encoder to decode compressed frames and test recon
buffers from the decode against those from encode for mismatch.
There are a few limitations on this option currently, one of them
being the match test is not done on a number of lagged frames at
the end of an encoding.
Change-Id: I80c29b46dcdcea9f48107a506b235743068862fe
Yaowu Xu [Thu, 15 Mar 2012 00:29:39 +0000 (17:29 -0700)]
fixed a bug of context overwritten by key frame recoding
The recoding loop save and restore frame coding context for recodes.
However in recoding of key frames, some of the coding context saved
was stale from last encoded inter frame. The save/restore sometimes
overwrites the re-inintialized coding context with saved context
from last frame, resulting in encoder/decoder mismatch
Change-Id: I354ae2f71074d142602d51d06544c05a2462caaf
Yaowu Xu [Wed, 14 Mar 2012 14:37:10 +0000 (07:37 -0700)]
Added option to skip first n frame to vpxenc
this commit added a command line option to skip first n frames from
input file to facilitate debugging and testing.
Change-Id: I4ffc5f85fa7e193ea4bdee08cb236717de8beef1
Yaowu Xu [Mon, 12 Mar 2012 21:51:54 +0000 (14:51 -0700)]
fixed .mk files to reflect add/remove of a header file
In a previous commit, the duplicate of headerfile defaultcoefcounts.h
was identified. This commit updates the .mk file to ensure configure
and make works properly for all platforms.
Change-Id: I31a39c809a734ba438ee53db700f252e9a03eddd
Yaowu Xu [Wed, 7 Mar 2012 17:05:26 +0000 (09:05 -0800)]
Changed MAX_PSNR to be consistent with internal stats
The maximum psnr has a marginal impact on the overall output in high
quality encodings, the change will make sure the psnr output to be
consistent with encoder internal stats.
Change-Id: I35cf2f85008ec127a7d91c9eb69fa7811798ae32
Yaowu Xu [Wed, 7 Mar 2012 15:16:12 +0000 (07:16 -0800)]
removed duplicate a head file
Removed the copy in encoder and changed to use the one in common
Change-Id: Ief0985a50ffd6053a269638fd4816b055ca273ec
Paul Wilkins [Tue, 6 Mar 2012 11:23:50 +0000 (11:23 +0000)]
Snapshot candidate
Pulled out super block code for the snapshot as this
is not quite ready and will need an extensive re-merge.
Change-Id: I436369b511257447a7b0ea064016cb63f5011849
Jim Bankoski [Tue, 6 Mar 2012 17:31:51 +0000 (09:31 -0800)]
Imported a change from stable branch
https://gerrit.chromium.org/gerrit/#change,17319 fixes cost estimating
to take skip_eob into account. No quality difference seen on derf set
tests, but about .4% gain on STD_HD set.
Change-Id: Ic5fe6d35ee021e664a6fcd28037b8432a0e470ca
Yaowu Xu [Tue, 6 Mar 2012 17:52:15 +0000 (09:52 -0800)]
fix a compiling error when CONFIG_COMP_INTRA_PRED not defined
Change-Id: I4159ff365953598d9c9bc3ecacfb5c5f4a315b45
Ronald S. Bultje [Fri, 2 Mar 2012 19:18:24 +0000 (11:18 -0800)]
Use per-MB compound intra prediction.
This gives a modest gain on derf overall, although at low bitrates the
cost is still too high, so this can be improved further.
Patch 2. Re-base and fix 80 column issues
Change-Id: Ida2f9fa3fe75370669f6a27b37108dc602231c63
Yaowu Xu [Wed, 22 Feb 2012 02:10:18 +0000 (18:10 -0800)]
Changed how UV r/d estimates are done for Intra Modes
The commit changed to compute UV intra RD estimates for 4x4 and 8x8
separately to be used in mode decision for MB modes associated with
the appropriate transform size respectively. Now finally after many
other changes related 8x8 quantizer zbin boost and zbin_mode_boost,
this change overall helps the HD(with 8x8) by around ~.13%.
(avg .13% glb .13% ssim .17%)
The commit also has a few changes for eliminating compiler warnings.
Change-Id: Ibab35dad44820c87e6b44799c66f8d519cc37344
Yaowu Xu [Fri, 2 Mar 2012 04:16:49 +0000 (20:16 -0800)]
Fixed zbin_mode_boost initialization
The commit added the correct Zbin_mode_boost initialization based on
Intra Mode before using rate distortion to pick UV intra mode.
Change-Id: I8e57878ff356a06672f6fa2431be860bf9b9a5c7
Yaowu Xu [Wed, 22 Feb 2012 02:10:18 +0000 (18:10 -0800)]
refactored code that checks if a macroblock is skippable
Change-Id: I4ea6d819bbbde312792c4f813ab63ea50cf0cd1d
Paul Wilkins [Fri, 2 Mar 2012 01:24:30 +0000 (01:24 +0000)]
Allow for frame overheads in min frame bandwidth.
Change-Id: I6ade229ff400fe492709010ac5bada37f8afa73e
Yaowu Xu [Wed, 29 Feb 2012 01:11:12 +0000 (17:11 -0800)]
Merge t8x8 experiments
Change-Id: I8e9b6b154e1a0d0cb42d596366380d69c00ac15f
Yaowu Xu [Thu, 1 Mar 2012 19:30:49 +0000 (11:30 -0800)]
disable usage of 8x8 for resolution below 360p
need further investigation on some odd behavior on one youtube clip
Change-Id: Iec477986a86b54ef26df2ef69d2f9484e2d1a043
Deb Mukherjee [Thu, 1 Mar 2012 11:10:21 +0000 (03:10 -0800)]
Various bug fixes related to high precision mv
Change-Id: Ie5a7c87d71bd4a541463b68704620d89cec142cf
Paul Wilkins [Thu, 1 Mar 2012 01:41:19 +0000 (01:41 +0000)]
Bug fix in vp8_estimate_entropy_savings()
Incorrect scaling of savings for t8x8.
Change-Id: If01e08f8c73faa73afc3c70e501e6acc54d7e26f
Yaowu Xu [Wed, 29 Feb 2012 01:44:19 +0000 (17:44 -0800)]
Fix compiling issue when CONFIG_HIGH_PRECISION_MV is defined
Change-Id: I3b8a230d5b119910e6a6767331a4d97768089355
Ronald S. Bultje [Wed, 29 Feb 2012 01:25:45 +0000 (17:25 -0800)]
Rename "dual" prediction to "compound" prediction.
Change-Id: Ibcd2b9b247ff9f83331dac47f91ec285e8955ff1
Ronald S. Bultje [Wed, 29 Feb 2012 01:12:08 +0000 (17:12 -0800)]
Compound intra prediction (b_pred/4x4 only, for now),
Also remove duplicate build_intra_predictors_mby/uv().
Change-Id: I78607e7304952a9b962a5b25af9bb9c48692187b
Yaowu Xu [Tue, 28 Feb 2012 22:19:38 +0000 (14:19 -0800)]
Correct zbinboost lookup for 8x8 quantizer
The commit fixed a problem where 8x8 regular quantizer was using the
4x4 zbinboost lookup table that only has 16 entries at each Q. The
commit assigned a uniform zbin boost value for all cases that there
are more than 16 consective zeros. The change only affects MBs using
8x8 transform. The fix has a slightly positive impact on quality.
Test results:
http://www.corp.google.com/~yaowu/no_crawl/hd_fixzbinb.html
(avg psnr: .26% glb psnr: .21% ssim: .28%)
Results on cif size clip are also positive even though gain is smaller
http://www.corp.google.com/~yaowu/no_crawl/derf_fixzbinb.html
Change-Id: Ibe8f6da181d1fb377fbd0d3b5feb15be0cfa2017
Paul Wilkins [Tue, 28 Feb 2012 23:28:04 +0000 (23:28 +0000)]
Merge "Merge new loop filter." into experimental
Deb Mukherjee [Mon, 27 Feb 2012 18:22:38 +0000 (10:22 -0800)]
Initial refactoring of high_precision mv code.
This is the first patch for refactoring of the code related to
high-precision mv, so that 1/4 and 1/8 pel motion vectors can
co-exist in the same bit-stream by use of a frame level flag.
The current patch works fine for only use of 1/4th and
only use of 1/8th pel mv, but there are some issues with the
mode switching in between. Subsequent patches on this change Id
will fix the remaining issues.
Patch 2: Adds fixes to make sure that multiple mv precisions can
co-exist in the bit-stream. Frame level switching has been tested
to work correctly.
Patch 3: Fixes lines exceeding 80 char
Patch 4:
http://www.corp.google.com/~debargha/vp8_results/enhinterp.html
Results on derf after ssse3 bugfix, compared to everything
enabled but the 8-tap, 1/8-subpel and 1/16-subpel uv. Overall the
gains are about 3% now. Hopefully there are no more bugs lingering.
Apparently the sse3 bug affected the quartel subpel results more than
the eighth pel ones (which is understandabale because one bad predictor
due to the bug, matters less if there are a lot more subpel options
available as in the 1/8 subpel case).
The results in the 4th column correspond to the current settings.
The first two columns correspond to two settings of adaptive switching
of the 1/4 or 1/8 subpel mode based on initial Q estimate. These
do not work as good as just using 1/8 all the time yet.
Change-Id: I3ef392ad338329f4d68a85257a49f2b14f3af472
Yaowu Xu [Tue, 28 Feb 2012 22:31:03 +0000 (22:31 +0000)]
Merge "Try to enable 8x8 tranform for smaller resolution" into experimental
Paul Wilkins [Tue, 28 Feb 2012 20:58:52 +0000 (20:58 +0000)]
Merge new loop filter.
Merge of the NEWLPF configuration experiment so it is always on.
Change-Id: I7054772b6eab28bad1ff807bfa54d98f83de9308
Yaowu Xu [Tue, 28 Feb 2012 19:49:12 +0000 (11:49 -0800)]
Try to enable 8x8 tranform for smaller resolution
The commit overall on derf test is break even to very slightly positive
comparing to all 4x4 transform.
Change-Id: I2a7c19599aa54c2d3a5b35db0dc891ba8a6a2b26
Paul Wilkins [Tue, 28 Feb 2012 17:15:31 +0000 (17:15 +0000)]
Experimental branch code clean up.
Removal of some further code relating to partitions
and error resilience.
Spelling correction.
Change-Id: I36067aae67a4a23bec359541dda3400b0bbf26d0
Paul Wilkins [Mon, 27 Feb 2012 22:23:38 +0000 (22:23 +0000)]
Code Simplification
Removal of code relating to token partitioning
Change-Id: Iaf3c88d6758639a55bd92c3be5c51e6bed407a3c
Yaowu Xu [Tue, 28 Feb 2012 02:23:15 +0000 (18:23 -0800)]
fixed a wrong intialization value
The "update" variable was used as a flag in coef_prob update dry run
that tests if a frame should encodes update at all. The wrong init
value forced the update happening always. fixing this has a minor
improvement in low bit rate situation when 8x8 transform is allowed.
Change-Id: Icb498e8d6a62fd074dcbc2065b797cba9237cb51
Paul Wilkins [Tue, 28 Feb 2012 02:07:49 +0000 (02:07 +0000)]
Merge "Corrected spelling" into experimental
Paul Wilkins [Mon, 27 Feb 2012 21:42:36 +0000 (21:42 +0000)]
Corrected spelling
Apparently the correct spelling of segement is segment !
Change-Id: I88593ee0523f251b3a96794c6166ef8c7898a029
Paul Wilkins [Mon, 27 Feb 2012 20:50:21 +0000 (20:50 +0000)]
Merge "Code Cleanup." into experimental
Paul Wilkins [Mon, 27 Feb 2012 20:50:01 +0000 (20:50 +0000)]
Merge "Removal of temporal re sampling code." into experimental
Paul Wilkins [Mon, 27 Feb 2012 17:58:57 +0000 (17:58 +0000)]
Merge "Code Simplification." into experimental
Paul Wilkins [Mon, 27 Feb 2012 17:58:12 +0000 (17:58 +0000)]
Merge "Further code simplification and clean up." into experimental
Deb Mukherjee [Sun, 26 Feb 2012 06:06:07 +0000 (06:06 +0000)]
Merge "Changing default 8-tap filter to Langrangian interpolator." into experimental
Paul Wilkins [Sun, 26 Feb 2012 01:15:47 +0000 (01:15 +0000)]
Code Cleanup.
Removal of error_resilient_mode features.
The interface has been left in place but does nothing.
Change-Id: I2407863bd0d3c98407354507423ca48d29f63b17
Paul Wilkins [Sat, 25 Feb 2012 18:13:57 +0000 (18:13 +0000)]
Removal of temporal re sampling code.
For now the interface elements have been left in place
to make sure existing parameter files work but parameters
relating to drop frame wont do anything.
Change-Id: I579ee614726387381c546845dac4bc03c74c6a07
Deb Mukherjee [Sat, 25 Feb 2012 04:24:54 +0000 (20:24 -0800)]
Bug fix in ssse3 variance computation.
Fixes a bug that was introduced in the high precision mv patch.
Change-Id: Ieadb433ebe4c3ef3e0e63944dab11528bf8bd73a
Paul Wilkins [Fri, 24 Feb 2012 23:58:24 +0000 (23:58 +0000)]
Code Simplification.
Removal of code relating to spatial re sampling
Change-Id: Iff1bc651c62cd528f960c4b27f9673b172e68835
Paul Wilkins [Fri, 24 Feb 2012 23:27:59 +0000 (23:27 +0000)]
Further code simplification and clean up.
Change-Id: Ifdb17b56090a317b2aa82cf125d57934902c5298
Deb Mukherjee [Fri, 24 Feb 2012 17:08:00 +0000 (09:08 -0800)]
Changing default 8-tap filter to Langrangian interpolator.
The Lagrangian interpolation filter is maximally flat in the
passband. There is non-trivial improvement with the hd set, while
for derf the results are virtually unchanged.
See:
http://www.corp.google.com/~debargha/vp8_results/enhinterpn.html (derf)
http://www.corp.google.com/~debargha/vp8_results/enhinterpn_hd.html (HD)
Patch 2: Updated the results for derf in the html above to use the
new baseline. There is still about 4% improvement. Will update the
hd baseline later (since it takes 9 hours to run on my machine)
Patch 3: By mistake the default filter was left at 60 - should be 0
to use the new interpolation filter.
Change-Id: If5f64444976562415d68a2aeabb94fdfa0d47890
Paul Wilkins [Thu, 23 Feb 2012 19:22:29 +0000 (19:22 +0000)]
Deleted code.
Removed redundant code for ref frame cost.
Deb Mukherjee [Thu, 23 Feb 2012 19:47:18 +0000 (11:47 -0800)]
Clean ups and minor changes in high precision mv with 8-tap interpolation
* Removes EDGE_PIXEL_FILTER for external sanpshot
* changes the default 8-tap filter based on high precision results
in http://www.corp.google.com/~debargha/vp8_results/enhinterpn.html
* changes the default prob tables for high-precision mv encoding to
favor zeros in the last bit (i.e. quarter pel). This is only important
for short clips.
Change-Id: I02bb0de8679d9eec06cdbcc8160dbf073cd847a4
Deb Mukherjee [Thu, 16 Feb 2012 17:29:54 +0000 (09:29 -0800)]
Supporting high precision 1/8-pel motion vectors
This is the initial patch for supporting 1/8th pel
motion. Currently if we configure with enable-high-precision-mv,
all motion vectors would default to 1/8 pel. Encode and
decode syncs fine with the current code. In the next phase
the code will be refactored so that we can choose the 1/8
pel mode adaptively at a frame/segment/mb level.
Derf results:
http://www.corp.google.com/~debargha/vp8_results/enhinterp_hpmv.html
(about 0.83% better than 8-tap interpoaltion)
Patch 3: Rebased. Also adding 1/16th pel interpolation for U and V
Patch 4: HD results.
http://www.corp.google.com/~debargha/vp8_results/enhinterp_hd_hpmv.html
Seems impressive (unless I am doing something wrong).
Patch 5: Added mmx/sse for bilateral filtering, as well as enforced
use of c-versions of subpel filters with 8-taps and 1/16th pel;
Also redesigned the 8-tap filters to reduce the cut-off in order to
introduce a denoising effect. There is a new configure option
sixteenth-subpel-uv which will use 1/16 th pel interpolation for
uv, if the motion vectors have 1/8 pel accuracy.
With the fixes the results are promising on the derf set. The enhanced
interpolation option with 8-taps alone gives 3% improvement over thei
derf set:
http://www.corp.google.com/~debargha/vp8_results/enhinterpn.html
Results on high precision mv and on the hd set are to follow.
Patch 6: Adding a missing condition for CONFIG_SIXTEENTH_SUBPEL_UV in
vp8/common/x86/x86_systemdependent.c
Patch 7: Cleaning up various debug messages.
Patch 8: Merge conflict
Change-Id: I5b1d844457aefd7414a9e4e0e06c6ed38fd8cc04
Yaowu Xu [Wed, 22 Feb 2012 17:13:04 +0000 (17:13 +0000)]
Merge "Fixed skippable evaluation in mode decision" into experimental
Yaowu Xu [Wed, 22 Feb 2012 17:12:52 +0000 (17:12 +0000)]
Merge "Reduced bias in picking loop filter level" into experimental
Yaowu Xu [Wed, 22 Feb 2012 15:55:53 +0000 (15:55 +0000)]
Merge "a bit code clean-up" into experimental
Yaowu Xu [Wed, 22 Feb 2012 15:55:37 +0000 (15:55 +0000)]
Merge "Reworked context conversion between 8x8 and 4x4" into experimental
Yaowu Xu [Fri, 17 Feb 2012 23:52:30 +0000 (15:52 -0800)]
Fixed skippable evaluation in mode decision
Yunqing fixed an oddity in UVIntra skippable evaluation for stable
branch, which brought up the fact that the evaluation is broken.
The issue was that for MBs with 2nd order block, the eob for 1st
order blocks is set at 1. The previous evaluation did not take that
into account. This commit intend to fix the problem. The commit also
absorbed Yunqing's fix for UVIntra skippable evalution.
Test on hd showed some good gains in combination with LPF bias fix:
http://www.corp.google.com/~yaowu/no_crawl/LPFBias_FixSkip.html
(avg psnr: .34%, glb psnr: .32%, ssim: .22%)
Change-Id: I36af11c8ef7f643e8ff46da7bf3a167b437039d4
Yaowu Xu [Fri, 17 Feb 2012 20:03:34 +0000 (12:03 -0800)]
Reduced bias in picking loop filter level
The bias in picklpf intended to bias toward less greedy in getting
best frame level psnr while maximize overall quality for a clip.
This commit reduced the bias for frames using 8x8 transform to
achieve better compression overall.
The change improve compression by ~.15% consistently on most of the
HD clips tested.
http://www.corp.google.com/~yaowu/no_crawl/LPFBias_FixSkip.html
Change-Id: Ic30932d2b8eaebd52339b0195f569edc48eed7bc
Paul Wilkins [Fri, 17 Feb 2012 16:29:03 +0000 (16:29 +0000)]
Code base simplification.
Removal of most code to do with 1 pass.
Removal of cyclic refresh code.
Change-Id: I74971082bc19dd76e795d4d2e781a0424cec5c8c
Paul Wilkins [Fri, 17 Feb 2012 11:04:32 +0000 (11:04 +0000)]
Merge "Code simplification" into experimental
Yaowu Xu [Thu, 16 Feb 2012 21:41:17 +0000 (13:41 -0800)]
a bit code clean-up
Removed some transform code that is not in use.
Change-Id: I9489af7e23d9d7fe052feb6c8bbafa62ebbda39c
Yaowu Xu [Fri, 20 Jan 2012 23:30:31 +0000 (15:30 -0800)]
Reworked context conversion between 8x8 and 4x4
The commit rationized and simplified the entropy context conversion
betwen MB using 8x8 transform and MB using 4x4 transform. The old version
had a number of weirdness in how 4x4 transform MB's context is used for
8x8 blocks other than the first 8x8 within a MB.
Test showed the change has a gain ~.1% for avg psnr, glb psnr and ssim on
the limited HD set.
Change-Id: I774536c416baa6845aa741f956d8a69fa40e5d47
Deb Mukherjee [Thu, 16 Feb 2012 18:40:39 +0000 (10:40 -0800)]
Removing a stray CONFIG_DUALPRED, and a INTERP_EXTEND fix.
Change-Id: I7549e424ca6846b07a796f2b9cd4e9d4e550ca9b
Paul Wilkins [Thu, 16 Feb 2012 17:02:17 +0000 (17:02 +0000)]
Code simplification
Removal of the pickinter.c and .h files and calls to this
code.
Removal of some code relating to real time and one pass
settings though there is more to be done in this regard.
However, vp8_set_speed_features() now
only supports modes 0 and 1 and speeds up to 3
so rd should always be set.
Change-Id: I62c0c1b6154ab499785baef310536080e87bc4d8
Deb Mukherjee [Thu, 16 Feb 2012 16:32:38 +0000 (16:32 +0000)]
Merge "Adjusting 8-tap filter + prelim edge pixel filter code." into experimental
Yaowu Xu [Fri, 20 Jan 2012 23:30:31 +0000 (15:30 -0800)]
revised the rate distortion computation for UV
this commit changed the UV r/d calculation in the mode decision process to
properly account for the rate of 8x8 transform coefficients.
Change-Id: I485f8f35f2b61db0b6539beb32e83481b1cf083b