SeungSeop Park [Tue, 18 Nov 2014 11:44:10 +0000 (20:44 +0900)]
Revert "[Tizen][Dev] built-in linker (ld) can not handle chromium-efl"
This reverts commit
72dbab00224102c43c4c6452344f39f5d283f427.
It's due to Problem in TV run:
- efl_webview and mini_browser can not open any websit today
Log prompt efl_webprocess cannot execute. When comparing the normal
and abnormal of efl_webprocess (via readelf -h efl_webprocess),
ELF Header Flags are as follows:
- before: 0x5000000, Version5 EABI
- current: 0x5000202, has entry point, Version5 EABI, <unknown>.
Change-Id: I75f548ea58e99484fade7fe3b68918497597bf70
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
zhaoze [Thu, 6 Nov 2014 22:38:21 +0000 (17:38 -0500)]
Bringup error domain in Ewk_Error
Fill out the domain value in Ewk_Error.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8592
Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: I37ae2424e32844eb7b93b39680b2d6f259690e68
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
Balazs Kelemen [Sat, 15 Nov 2014 01:11:56 +0000 (20:11 -0500)]
Replace supplement.gypi with a more reliable solution
Adapt the chromium-efl build to the new gyp_trunk.py wrapper.
Import and apply it conditionally so we can land both patches without
temporarily breaking the build. Condition can be removed later in a fixup.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6661
Reviewed by: SeungSeop Park, Viatcheslav Ostapenko
Change-Id: Ic6de4b64acf70d63060581fcd10620f1f5b0634b
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Viatcheslav Ostapenko [Sat, 15 Nov 2014 04:47:21 +0000 (23:47 -0500)]
Add --single-branch parameter to git clone in sync_repos.sh
Faster initial clone of repositories.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8173
Reviewed by: Antonio Gomes, Balazs Kelemen
Change-Id: I8553ca353d1faf9c7a5ebafa609b9d2a17215d94
Signed-off-by: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Michal Poteralski [Mon, 17 Nov 2014 09:30:47 +0000 (10:30 +0100)]
Set default strategy of not remembering certificate decision.
SSLHostStateDelegate may be left unimplemented to use a default strategy of not
remembering certificate decisions at all. As long as the default strategy is
used the GetSSLHostStateDelegate left unimplemented, thus
BrowserContextEfl::GetSSLHostStateDelegate() method should return NULL.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8884
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I3e826a8b5116abdf2f5a9a3b8bbe590526f89008
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
“kapil.kumar” [Wed, 12 Nov 2014 09:21:57 +0000 (14:51 +0530)]
[Tizen][MM][Webrtc] GetUserMedia Support
Added support require for m40 Upmerge.
-Added the extra argument for status result in callback
-Implement checkAccess callback, as we dont support extenstions
so return default as true. So it will ask user for media access everytime.
-Added device id for TV, as TV has only one primary camera.
-Move all changes under TIZEN_MULTIMEDIA_SUPPORT flag, for easy upmerging of
GetUserMedia.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7942
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ic1ff44d9ceb23b29bb41e6318821602dfe1bf25f
Signed-off-by: “kapil.kumar” <kapil.kumar@samsung.com>
Signed-off-by: kapil.kumar <kapil.kumar@samsung.com>
Dongwoo Joshua Im [Mon, 17 Nov 2014 07:01:18 +0000 (16:01 +0900)]
Remove S_TRUNK_OWNERS files which were added by mistake.
Remove S_TRUNK_OWNERS files which were added during migrating
chromium-ewk into chromium-efl on beta branch.
Reviewed by: Kangil Han, SeungSeop Park
Change-Id: I7bd887a33ccf4774073dee7c22130181f191b9b4
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Michal Poteralski [Tue, 4 Nov 2014 10:29:07 +0000 (11:29 +0100)]
[M34-Merge] Mechanism for deactivation of MessagePumpForUIEfl timers added
The patch implements a way to deactivate and delete MessagePumpForUIEfls
timers which are still active (no triggered) despite the fact that
application has been closed.
If the timers are NOT deactivated after the application close
then the timers will try call MessagePumpForUIEfl::TimerCallback
function which actually does NOT exist because MessagePumpForUIEfl has
been destructed.
Original commit: http://165.213.202.130:8080/#/c/71335/
(by Wojciech Kosowicz <w.kosowicz@samsung.com>)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8500
Reviewed by: Antonio Gomes, Balazs Kelemen, Piotr Tworek, SeungSeop Park
Change-Id: Id993b36dd15d8fe15900cf5e0b544cc36643ff30
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
SeungSeop Park [Mon, 17 Nov 2014 07:08:07 +0000 (16:08 +0900)]
fixup! [Tizen][Dev] built-in linker (ld) can not handle chromium-efl
Fixes the desktop build break.
Reviewed by: Kangil Han, SeungSeop Park
Change-Id: Ieb013fabc621a0a3afc50ab79e9775fa11b5711b
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Antonio Gomes [Thu, 13 Nov 2014 19:34:23 +0000 (11:34 -0800)]
[Tizen][Dev] built-in linker (ld) can not handle chromium-efl
Use a prebuilt linker gold binary instead of the default ld
installed by binutils-2.24-6.3.armv7l.rpm.
linux_use_bundled_gold and inux_use_bundled_binutils were explicitly
set to 0 to ensure we use our own linker.
Using 'gold' allows us to create smaller binaries for chromium-efl.so,
e.g. from 74Mb to 71Mb in my local machine.
As a result, we can link with no "Memory exhausted" error in both
release and debug builds, and not depend on using Wl,--no-keep-memory.
Patch intentionally leaves --no-keep-memory set for debug builds
because of bug [1], [TIZEN][Dev] GBD rpmbuild error with m39 build.
[1] http://107.108.218.239/bugzilla/show_bug.cgi?id=6457
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6629
Reviewed by: SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I1e1a0224bf157f10c506112b980fe4355a3e2efc
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Tomasz Czekala [Thu, 13 Nov 2014 13:25:11 +0000 (14:25 +0100)]
Back-forward list unit tests added.
This commits adds unit tests for following functions from EWK API:
1. ewk_view_back_forward_list_get
2. ewk_back_forward_list_item_url_get
3. ewk_back_forward_list_item_unref
4. ewk_back_forward_list_item_title_get
5. ewk_back_forward_list_item_ref
6. ewk_back_forward_list_item_original_url_get
7. ewk_back_forward_list_previous_item_get
8. ewk_back_forward_list_next_item_get
9. ewk_back_forward_list_n_forward_items_copy
10. ewk_back_forward_list_n_back_items_copy
11. ewk_back_forward_list_current_item_get
12. ewk_back_forward_list_count
13. ewk_back_forward_list_item_at_index_get
This patch ports following patch:
I8ecaa82514cc2129a1ac25b0ec2cd63c8ad0989f
d2c3228b8ca472595f3c00caa8dfa0c3d839352d
made by Filip Piechocki
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8237
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Iba6a1fb044ea8a7416db455b71b815b33b5dddf6
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Arnaud Renevier [Wed, 5 Nov 2014 22:03:51 +0000 (14:03 -0800)]
use ExecuteJavaScriptForTests instead of ExecuteJavaScript
Full screen test fail because the full screen opening is blocked.
Actually, a fullscreen can only be opened if triggered by a gesture.
In chromium m34, executeJavascript used to act like if the script had
been executed by a gesture. But in recent chromium, there are two
different calls: executeJavascript and executeJavascriptForTests.
Since we don't want to change ewk api, we use executeJavascriptForTests
when a script is executed. This will mimick m34 behaviour
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8558
Reviewed by: Antonio Gomes, Balazs Kelemen
Change-Id: I8e5025b826f7462aabdefa2a299f16222dba3f25
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Zhang-hoon Oh [Tue, 28 Oct 2014 09:20:40 +0000 (18:20 +0900)]
[M34-Merge] Add CSS view-mode media feature support (chromium-efl)
To achieve Web App compatibility for Blink on Tizen, CSS
"view-mode" media feature support should be resurrected.
There is a strong requirement from WRT developers.
This patch is the "chromium-efl" side of a two-sided
patch.
"s-blink" side change-id: I38ce341531cba1069f407d41ef8a5f90f3cd0c71
About M34 Patches:
* M34 patches are reorganized.
* Commits:
** http://suprem.sec.samsung.net/gerrit/#/c/1047/
** http://suprem.sec.samsung.net/gerrit/#/c/1906/
** http://suprem.sec.samsung.net/gerrit/#/c/1907/
* Original Author:
** The original author was kaka.park@samsung.com.
Spec.: http://www.w3.org/TR/view-mode/
(http://www.w3.org/TR/2012/REC-view-mode-
20120619/)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7803
Reviewed by: Balazs Kelemen, SeungSeop Park, Yi Shen
Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: Ic4fcdecd58d493f190bab4fb6c268c9b2f41f845
Signed-off-by: Zhang-hoon Oh <dennis.oh@samsung.com>
Dongjun Kim [Sun, 2 Nov 2014 09:53:00 +0000 (18:53 +0900)]
Refactor disambiguation popup
Previous implementation of disambiguation popup was buggy. It was
scaling already scaled image. It was scaling without keeping aspect
ratio. It caused lot of bugs with clicked position and rendering.
To tests the new implementation on desktop please make sure to add
--touch-events flag to efl_webview_app startup parameters.
Original patch : http://165.213.202.130:8080/#/c/70671
Original Author : Kamil Klimek <k.klimek@partner.samsung.com>
Together with : I5e0cf66df8922f8d4523b950bbcc999a7b90b402
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8405
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I1563a1cc2f722866ae9be0aa5f73440fcb8d5d25
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Tomasz Czekala [Wed, 12 Nov 2014 12:41:27 +0000 (13:41 +0100)]
Back-forward list implementation.
Following EWK API functions were implemented in this commit:
1. ewk_view_back_forward_list_get
2. ewk_back_forward_list_item_url_get
3. ewk_back_forward_list_item_unref
4. ewk_back_forward_list_item_title_get
5. ewk_back_forward_list_item_ref
6. ewk_back_forward_list_item_original_url_get
7. ewk_back_forward_list_previous_item_get
8. ewk_back_forward_list_next_item_get
9. ewk_back_forward_list_n_forward_items_copy
10. ewk_back_forward_list_n_back_items_copy
11. ewk_back_forward_list_current_item_get
12. ewk_back_forward_list_count
13. ewk_back_forward_list_item_at_index_get
These functions are a C wrappers on a C++ implementation in chromium-efl
This commit is a merge of 3 patches made by Filip Piechocki:
Ibc45f932d7bfc98837bd330fcf9c2c4f886410d2
f4fdf69e5c40b8e3b0dc78dd3cfa13bf97561aec
I2fc1871a9f34a9f5fa7038e10e666767b9a90e5c
df2b2cd674e289ebd00a5f7415e7163ae7e24eca
Ia153812ecb5ba4942be89e7f483e83704f26cbc2
50aa4c9308f63bfdde5dea042eb7b1cd98d33c3c
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8237
Reviewed by: SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I9b70d36e7bfae57c9ad4afec0434c383b3f2ecc8
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Youngsoo Choi [Wed, 12 Nov 2014 12:13:11 +0000 (21:13 +0900)]
[M40] Enabling ViewHostMsg_TextInputStateChanged
ViewHostMsg_TextInputStateChanged needs to be enabled
to update text input state.
Together with: I1dc9519a08e6c17593b961755fc33fc125bdeac7
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8818
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ia6f60691dcc316f6b064e5efcd421fded4e95e10
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Arnaud Renevier [Wed, 5 Nov 2014 23:33:08 +0000 (15:33 -0800)]
Fixes utc_blink_ewk_autofill_profile_id_get.POS_TEST
utc_blink_ewk_autofill_profile_id_get.POS_TEST fails because it tests
that ewk_autofill_profile_id_get returns 0. This test made sense when
each test file was executed in a different profile. But now that all
tests are executed in a single executable, multiple profiles may already
have been created once this test is run.
We remove totally the file because ewk_autofill_profile_id_get is
already used in some other unittests
(utc_blink_ewk_context_form_autofill_profile_utils.*)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8561
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: I15a59d4064e81fc30fd082b35ea3f479d63550be
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Michal Poteralski [Wed, 5 Nov 2014 09:46:20 +0000 (10:46 +0100)]
Add ewk_settings_default_text_encoding_name_get implementation.
ewk_settings_default_text_encoding_name_get function is NOT implemented.
This patch provides implementation of the function.
Original commit: http://165.213.202.130:8080/#/c/68831/
(by Piotr Sieduszewski <p.sieduszews@samsung.com>)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8248
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I7abb589a1cbfd8df3f6004bfdd7559d884c0b0d5
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
Balazs Kelemen [Thu, 6 Nov 2014 22:56:42 +0000 (17:56 -0500)]
Deploy scripts are not awasome enough
Some fixes to make it work out of box and restructured the script
to be more straightforward. Now it is an executable script (instead
of an environment one).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6900
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: Ia70104ed0f77e67133760c655e5c508d4dd972dc
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Arnaud Renevier [Tue, 11 Nov 2014 19:14:40 +0000 (11:14 -0800)]
Fixes: form,submit callback is not called
As of now, WillSubmitForm is not called once a form has been submitted.
This is because WillSubmitForm first argument has changed in m39. It is
now a blink::WebLocalFrame* instead of a blink::WebFrame*
So, this patch changes the argument back. And to prevent that problem from
happening in the future, it also sets the override identifier for that
function.
Reviewed by: Antonio Gomes, Balazs Kelemen
Change-Id: I485c82934748fa1a19a66ad21ef9cb29b774a817
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Sat, 25 Oct 2014 00:56:04 +0000 (17:56 -0700)]
Fixes crash in content::URLRequestContextGetterEfl::GetURLRequestContext()
The crash happens because URLRequestContextGetterEfl outlives web context.
Since ResourceContextEfl is deleted in the IO thread, it outlives the web
context. So this patch also set it's getter_ member to in ~BrowserContextEfl.
That way, the URLRequestContextGetter doesn't outlive the web context.
Additionally, DCHECK(BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
resource_context_)); is a noop in non debug build. So BrowserThread::DeleteSoon
wasn't actually called in release mode.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8063
Reviewed by: Antonio Gomes, Balazs Kelemen, Yi Shen
Change-Id: Icb35b71fb014824f4f93c3b930723e8796dbefbf
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
KANGYONG PARK [Mon, 10 Nov 2014 02:40:48 +0000 (11:40 +0900)]
Screen is upside down
After changing the screen orientation to landscape, view is upside down.
This patch fixes vertex attributes regarding orientation angle (90/270).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8608
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: Ib9dfc354d782c851ab26bb3cc1891042e4e1971d
Signed-off-by: KANGYONG PARK <kaka.park@samsung.com>
qi1988.yang [Wed, 29 Oct 2014 07:11:21 +0000 (15:11 +0800)]
[tizen][M34-Merge] Use setScrollOffset instead of setScrollPosition() API
setScrollPosition is deprecated. Modify OnSetScroll in render_view_observer_efl.cc
Relate to patch(M34):http://suprem.sec.samsung.net/gerrit/#/c/966/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8197
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I12b050445be7f383262d018a1783309bd930e814
Signed-off-by: qi1988.yang <qi1988.yang@samsung.com>
Prashant Nevase [Sat, 8 Nov 2014 14:47:34 +0000 (20:17 +0530)]
[M40] Fix black screen issue
For transport surface we were creating TextureImageTransportSurface
which used to call swap buffers. In following patch
https://codereview.chromium.org/
615503004
TextureImageTransportSurface is removed as it was deprecated. The
alternative mechanism is composite-to-mailbox.
In this patch, OnSwapCompositorFrame is implemented to support
composite-to-mailbox.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8577
Reviewed by: Kangil Han, SeungSeop Park
Change-Id: I25d2fd787044d111243ec6f630526d67f3bb00c8
Signed-off-by: Prashant Nevase <prashant.n@samsung.com>
SeungSeop Park [Mon, 3 Nov 2014 01:51:39 +0000 (10:51 +0900)]
[M40] Switch to trunk's webrtc and libjingle_source_talk repo.
Updated .gclient and sync_repo.sh to get newly added trunk repositories
instead of upstream's: s-webrtc.git and s-libjingle_source_talk.git.
In addition, to deal with any future repo additions, patch adds an
additional step to check the existing repo url in target path against
the desired repo url and remove the path if the two urls do not match.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Kangil Han, Piotr Tworek, SeungSeop Park
Change-Id: I8b9fd9499a3e1433c43bd4685e9821b60331a5d3
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Thu, 30 Oct 2014 23:59:52 +0000 (08:59 +0900)]
[M40] Chromium upversion to m40_2202 branch
* Note for M40 rebase:
- The gyp target name components.gyp:sessions in M39 is now
components.gyp:sessions_content,
- Clipboard must now have a derived class
Contributor: arno renevier (a.renevier@samsung.com)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Antonio Gomes, Kangil Han
Change-Id: I46b0dbb58903b7e421f66bee6e048af215d797cc
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 10 Nov 2014 04:52:39 +0000 (13:52 +0900)]
fixup! [M40] Force define DL_ARM_NEON_OPTIONAL to bypass mobile/tv build break in M40.
Patch fixes TV build.
Reviewed by: Antonio Gomes, Kangil Han, SeungSeop Park
Change-Id: I9fbbe47a1a3c611115f3ad06b2ea6780fdb6342c
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 10 Nov 2014 01:16:50 +0000 (10:16 +0900)]
Revert "[M34-Merge] Add CSS view-mode media feature support (chromium-efl)"
This reverts commit
0d5f6191b7e10c582dfc7fdf8a27269dda3a25ff.
Reverting the patch to unblock M40 switching because this change is
accompanied by a s-blink change which is however not yet available
in M40 branch.
TODO: Re-land this in M40.
Reviewed by: Antonio Gomes, Kangil Han, Laszlo Gombos
Change-Id: I551c8837c00ff0dd5b065f75808ed5ba2fea539e
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Zhang-hoon Oh [Tue, 28 Oct 2014 09:20:40 +0000 (18:20 +0900)]
[M34-Merge] Add CSS view-mode media feature support (chromium-efl)
To achieve Web App compatibility for Blink on Tizen, CSS
"view-mode" media feature support should be resurrected.
There is a strong requirement from WRT developers.
This patch is the "chromium-efl" side of a two-sided
patch.
"s-blink" side change-id: I814898d47f18136eed10f05857c16ed10e34cb27
About M34 Patches:
* M34 patches are reorganized.
* Commits:
** http://suprem.sec.samsung.net/gerrit/#/c/1047/
** http://suprem.sec.samsung.net/gerrit/#/c/1906/
** http://suprem.sec.samsung.net/gerrit/#/c/1907/
* Original Author:
** The original author was kaka.park@samsung.com.
Spec.: http://www.w3.org/TR/view-mode/
(http://www.w3.org/TR/2012/REC-view-mode-
20120619/)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7803
Reviewed by: Balazs Kelemen, SeungSeop Park, Yi Shen
Change-Id: I49b5333fb1e4b759fccca8c54ebc6fdd034fa155
Signed-off-by: Zhang-hoon Oh <dennis.oh@samsung.com>
Tomasz Olszak [Mon, 3 Nov 2014 09:04:58 +0000 (10:04 +0100)]
Added --reset option to sync_repo.sh
This option allows to delete local changes and ensure that e.g. daily builds
are based on clean sources. Also this allows to fix the state of repositories
inside src which where modified by some unintentional process.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8173
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ib95b6c4fcd2f58e2e1626f3ca9f9dfc6ecb71e73
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
SeungSeop Park [Wed, 5 Nov 2014 13:03:45 +0000 (22:03 +0900)]
Remove duplicated include paths in gyp step
Currently there are a lot of duplicated include paths in generated
ninja file, which may slow down the build process.
It's because during the gyp step we call pkg-config command multiple
times, one call per required package, and then concatenate the outputs
to get the final compile/link flags without removing any duplications.
Patch tries to mitigate this problem. The prepared solution is to
call a pkg-config command with multiple dependent packages at a time.
In addition, this patch removes code duplications of package name from
.gyp file, which would make less error-prone in on-going developement.
Original Patch: http://165.213.202.130:8080/#/c/71859/ (reworked for dev/)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8182
Reviewed by: Balazs Kelemen, Kangil Han
Change-Id: I02ca8c04da0903fcd2c92988656db3d265d3f631
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 3 Nov 2014 09:10:53 +0000 (18:10 +0900)]
[M40] Hot-fix link error of "undefined reference to `WebRtc_GetCPUFeaturesARM'"
Patch hot-fixes it by providing the function definition for tizen mobile&tv.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Antonio Gomes, Kangil Han, Piotr Tworek, SeungSeop Park, Tomasz Olszak
Change-Id: I55f061ca2ed063802e1caf0945a8f49b1730952e
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Mon, 3 Nov 2014 06:12:36 +0000 (15:12 +0900)]
[M40] Force define DL_ARM_NEON_OPTIONAL to bypass mobile/tv build break in M40.
In M40, mobile build failed due to undefined omxSP_FFTInv_CCSToR_F32_vfp
in src/third_party/openmax_dl/dl/sp/api/omxSP.h:2558. The seleciton of the
API is affected by compilation flag DL_ARM_NEON_OPTIONAL.
This patch defines DL_ARM_NEON_OPTIONAL by force for Tizen mobile/tv build.
Note that a commit "2cc824e fixup! Fix Android build with profiling=1"
pushed to s-chromium by the trunk merge team seems to resolve the issue
for Android, but not enough for Tizen.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Antonio Gomes, Kangil Han, Piotr Tworek, Tomasz Olszak, mohan reddy
Change-Id: If2f79782246a984b02264ffa21608040c25e695c
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
SeungSeop Park [Wed, 29 Oct 2014 11:38:55 +0000 (20:38 +0900)]
fixup! [M34-Merged] Assuring correct pointer initializations. (impl folder)
This patch does additionally in RWHV_efl.cc:
- fixes the order of member initializers to follow the order in .h
- gives default 0 for current_orientation_
- gives default true for is_hw_accelerated_ in member initialization list
- toggle local static variable scale_factor_initializer_ once initialized
Reviewed by: Antonio Gomes, Balazs Kelemen, Piotr Tworek
Change-Id: I63b6d171d87c68d0a9211e2c5a7c3f02b57e5ef3
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Michal Poteralski [Tue, 4 Nov 2014 10:57:01 +0000 (11:57 +0100)]
fixup! [Tizen] Switch chromium-efl / mobile development to GCC 4.8
Currently user is NOT in root mode during deploy_libc_to_target.sh script
execution. It cause that as long as 'sdb root on' is NOT invoked the files
copy does by script cannot be performed.
The patch provides that user will be by default in root mode during script
execution.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8503
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park, Tomasz Olszak
Change-Id: Id487d83eee337676dca2b260d4b046b416e9d892
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
Balazs Kelemen [Wed, 29 Oct 2014 19:35:45 +0000 (15:35 -0400)]
Remove unused style guide from readme file
Most of the code is already following chromium style guide as is so let's
remove this vestige from the past.
Bug: none, this is just an internal documentation change
Reviewed by: Antonio Gomes, SeungSeop Park, Zhang-hoon Oh
Change-Id: Ic79461f3f48395e8dac5025cf35dbabb8800f856
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Kamil Klimek [Mon, 3 Nov 2014 09:45:34 +0000 (10:45 +0100)]
fixup! Build ewk with gyp instead of cmake Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: I60229e13e61a68df807592f5aad56b366d91e05c
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Antonio Gomes [Sun, 2 Nov 2014 14:30:46 +0000 (06:30 -0800)]
[M40] Replace OVERRIDE by override within impl/.
In M40, base/compiler_specific.h removed OVERRIDE definition.
It means compilers that do not support 'override' can not
be used to build chromium out of the box anymore.
Patch replaces OVERRIDE by override in impl. The following
scripts were used.
$ find impl -name "*.h" -print0 | xargs -0 sed -i 's/OVERRIDE/override/g'
$ find impl -name "*.cc" -print0 | xargs -0 sed -i 's/OVERRIDE/override/g'
Based on the original work of SeungSeop Park <sns.park@samsung.com>
in http://165.213.202.130:8080/#/c/71676 .
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Kangil Han, SeungSeop Park, arno renevier, mohan reddy
Change-Id: Ieddb11caaf084aa920ad9f6691eb001fa835aaf1
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
SeungSeop Park [Mon, 3 Nov 2014 01:49:26 +0000 (10:49 +0900)]
[M40] Replace FINAL by final.
In M40, base/compiler_specific.h removed FINAL definition.
It means compilers that do not support 'final' can not
build used to build chromium out of the box anymore.
So, patch replaces FINAL with final.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8410
Reviewed by: Antonio Gomes, Kangil Han
Change-Id: I5d52196d157956a5a7ec8b7c3e5f628101afb4aa
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Taeho Kim [Wed, 29 Oct 2014 09:34:20 +0000 (18:34 +0900)]
Commonize boilerplate - ewk
This patch commonizes the boilerplate, and copyright.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7963
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I537f01bc31e309b43350b14ed2df336d4674d9de
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Taeho Kim [Wed, 29 Oct 2014 13:01:34 +0000 (22:01 +0900)]
Commonize boilerplate - impl
This patch commonizes the boilerplate, and copyright.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7963
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ib87ccaf5e1e76aefccb35dae75ff1babb3eca064
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
zhaoze [Fri, 24 Oct 2014 18:01:54 +0000 (14:01 -0400)]
fixup! [Tizen] Re-factor WebContents usage by EWK API implementation
Rename member variables in class InputPicker, to keep
the variable name consistent with chromium code
style.
Reviewed by: Antonio Gomes, Balazs Kelemen, Kamil Klimek
Change-Id: I6a2783ab69bb3b08e9afcb072519a3d9202c95d7
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
Piotr Sieduszewski [Fri, 8 Aug 2014 15:14:27 +0000 (17:14 +0200)]
Implementation "save,session,data"
This is a port of commit
86448aceabca5adb84cabceb7d77be9be6b27b4e to
dev/master branch
Issue: CBWEBVIEW-756 CBWEBVIEW-612
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7430
Reviewed by: Kamil Klimek, SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I05a775edd2a1dfe4d40c7e759cb6c03d920317ea
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Kamil Klimek [Wed, 29 Oct 2014 09:49:46 +0000 (10:49 +0100)]
Removed obsolete and uneeded testcases from repository
All removed test cases are either not ported to our TC base class
or are testing not implemented APIs.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8207
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I817652756503ed7b69a57c714550cd38d825c495
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Tomasz Czekala [Wed, 29 Oct 2014 08:24:23 +0000 (09:24 +0100)]
Refactor printf to LOG
Removed printf and added LOG in their place
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8176
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ie4197ace0dd878120ff1b83e937fdc36908dc48f
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
amulin.cao [Wed, 15 Oct 2014 06:38:49 +0000 (14:38 +0800)]
[M34-Merge]Implementation for opening url in new tab.
Patch makes it possible to open URL in new tabs with
context menu.
Issue: CBBROWSER-76, CBBROWSER-77, CBBROWSER-78
Original Gerrrit: http://suprem.sec.samsung.net/gerrit/#/c/5392/
Original author: Piotr Grad <p.grad@samsung.com>
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7452
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko, Yi Shen, arno renevier, mohan reddy
Change-Id: Ifab2af04cc788945dfc76bfe5b23f7b7dc47ac2e
Signed-off-by: amulin.cao <amulin.cao@samsung.com>
Arnaud Renevier [Fri, 24 Oct 2014 18:49:45 +0000 (11:49 -0700)]
call ewk_set_arguments in unittests
Currently, the unittest binary crashes at the very beginning of it's
execution. This is because ewk_set_arguments is not called. And then,
the browser crashes in CommandLineEfl::GetDefaultPortParams at some
point later in the initialization.
This patch calls ewk_set_arguments before ewk_init
It also makes sure that CommandLineEfl::Init is always called before
CommandLineEfl::GetDefaultPortParams.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: Idc8638de568b1921b8e0406562caf781dbc7620f
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 2 Jul 2014 13:13:55 +0000 (15:13 +0200)]
Check that NavigationEntry is not null on page load
Additionally replaced GetActiveEntry() with GetVisibleEntry() as
GetActiveEntry() is deprecated.
This patch is based on commit
652ec36ee84c707057617555353f1b0d39a7c1e0
(http://suprem.sec.samsung.net/gerrit/#/c/4803/)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7775
Reviewed by: Antonio Gomes, Balazs Kelemen, Janusz Majnert, SeungSeop Park, Yi Shen
Change-Id: I1ecc98e591bd21f90b4592be037026cd23cb3ee3
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Sun, 26 Oct 2014 03:15:39 +0000 (23:15 -0400)]
Move away from synchronous hit testing.
After [1], we have both sync and async hit test mechanisms
available in dev/. One of the current clients of the sync
approach is our text selection update routine
(SelectionControllerEfl::ShowHandleAndContextMenuIfRequiredCallback).
At debug builds, we were hitting an assert at this method
because it is not allowed to perform sync waits on the UI
thread.
For it to be fully functional, the sync approach requires
that we patch ThreadRestrictions::ScopedAllowWait located
at (base/threading/thread_restrictions.h) and remove a BRINGUP
guards (see [2]).
However, beta/ branch has moved away from it, and changed
the call site method to use the async approach. Patch follows
the idea and does the same for dev/.
In practice, it also fixes the folowing message on standard
error output followed by a crash:
"Waiting is not allowed to be used on this thread to
prevent jank and deadlock".
Steps to reproduce the crash:
0) debug build
1) load gmail.com
2) type into the passwd field.
Note that the existing selection functionality (broken or not)
remains untouched.
[1] http://165.213.202.130:8080/#/c/70137/
[2] http://165.213.202.130:8080/#/c/70907/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8073
http://107.108.218.239/bugzilla/show_bug.cgi?id=5456
Reviewed by: Balazs Kelemen, Kamil Klimek, SeungSeop Park, Viatcheslav Ostapenko, arno renevier
Change-Id: Id73891da55788fae3aa84d3916ab731955bb22a2
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Balazs Kelemen [Tue, 28 Oct 2014 22:59:51 +0000 (18:59 -0400)]
Getting rid of wayland dependency
We don't want wayland at this point and it makes the jhbuild fail
(at least for me). It should have been disabled already but the
configure flags were wrong.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8179
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: I2eddb6b87130edcfe5637ea5df5010509a5b2975
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Tomasz Olszak [Thu, 18 Sep 2014 13:04:47 +0000 (15:04 +0200)]
[M34-Merged] Change install path of package metadata from /usr/share to /opt/share
If installed in /usr/share, application is labeled as non-removable
and it is not possible to uninstall it.
Because of this, we had to use rpm command to uninstall chromium-efl
package installed by pkgcmd command.
This mismatch left some garbage data such as desktop icon
after uninstallation.
This patch fixes such defect by installing metadata to /opt/share.
[Reference]
See following url for xml manifest file structure and related code:
https://review.tizen.org/gerrit/gitweb?p=framework/appfw/slp-pkgmgr.git;a=blob;f=parser/manifest.xsd.in
https://review.tizen.org/gerrit/gitweb?p=framework/appfw/slp-pkgmgr.git;a=blob;f=parser/pkgmgr_parser.c;h=
a635883f065d393276cbaf1ffe2e079eb6ec1909;hb=HEAD#l4072
[Test]
To uninstall just invoke:
$> pkgcmd -u -n chromium-efl
Original patch(M34): http://165.213.202.130:8080/#/c/69452/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8131
Reviewed by: Kangil Han, SeungSeop Park
Change-Id: I260034207df0cfa0463e1b0096e2a2c8fcfeb8b1
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Arnaud Renevier [Fri, 24 Oct 2014 02:28:00 +0000 (19:28 -0700)]
Delete animator in SelectionMagnifierEfl::~SelectionMagnifierEfl
Right now, the animator set with ecore_animator_add is not deleted
in SelectionMagnifierEfl destructor. So, it can happen that the
animator callback is called after the magnifier has been deleted. This
results in a crash when trying to access its properties.
This patch fixes the problem by calling ecore_animator_del in
SelectionMagnifierEfl destructor.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8053
Reviewed by: Balazs Kelemen, SeungSeop Park, Yi Shen
Change-Id: I91a9d9c86de54787fd37ae135b19ffd28c2eeaf6
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Tomasz Olszak [Mon, 15 Sep 2014 08:37:40 +0000 (10:37 +0200)]
[M34-Merged] org.tizen.chromium-efl package renamed to chromium-efl
Additionally it seems that appid in aplication manifest (chromium-efl.xml)
needs to follow domain naming convention. I couldn't find any documentation
about it however org.tizen.mini-browser works chromium-efl doesn't.
Origin patch(M34): http://165.213.202.130:8080/#/c/69452
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5523
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8131
Reviewed by: SeungSeop Park
Change-Id: I8e369922156f63501795e2491ab058b72b70e64f
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Balazs Kelemen [Tue, 28 Oct 2014 23:26:46 +0000 (19:26 -0400)]
Force jhbuild rebuild if needed
We added stamp file as build time optimization but that should not stop jhbuild
if config files are changed. Also moving the stamp file to Root directory
so that clobbering jhbuild will also force rebuild.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6110
Reviewed by: Yi Shen, SeungSeop Park
Change-Id: Idc0939030c51b1941420abc250ce58ee055a5be6
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Antonio Gomes [Tue, 28 Oct 2014 05:10:45 +0000 (14:10 +0900)]
fixup! fixup! Fix WebContentsDelegateEfl because of updates in chromium WebContentsDelegate
Further disable favicon path, as it still cases problem on debug
builds.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7792
Reviewed by: Kangil Han
Change-Id: I9b63c140ddba00403e02efc8a734af01694bb0b3
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Fri, 24 Oct 2014 18:45:37 +0000 (11:45 -0700)]
Fixes erroneous TearDown overrides in ewk unittests.
In unittests, startup/cleanup routines for specific tests must happen in
PostSetup and PreTearDown methods.
Some tests erroneously override TearDown. Then, the base cleanup is
not performed and that results in crashes.
This patch fixes the issue.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: SeungSeop Park, Kangil Han
Change-Id: I20ebc5adfd6a7c847ee13a9d273d86ed2cbc439a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Fri, 24 Oct 2014 18:57:58 +0000 (11:57 -0700)]
Remove unneeded unit tests
Now that all unittests are run within a single binary, some tests don't
make sense anymore. Since ewk_init and ewk_set_arguments are called at
the start of the process, utc_blink_ewk_init_func and
utc_blink_ewk_set_arguments_func are useless.
Similarly, utc_blink_ewk_shutdown_func is not needed anymore.
This patch also temporarly disables
utc_blink_ewk_context_local_file_system_all_delete_func and
utc_blink_ewk_context_local_file_system_delete_func. Indeed, they need
--allow-file-access-from-files flag to run, but it's not possible to set
arguments after the initialization. We will enable them again later.
Lastly, it refactors utc_blink_ewk_view_add_func and
utc_blink_ewk_view_add_with_context_fun so that they don't call ewk_init
and ewk_shutdown
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: SeungSeop Park, Kangil Han
Change-Id: I535b275107680dfe5fd2261c82dfee32a3760b14
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Dongwoo Joshua Im [Wed, 29 Oct 2014 03:39:00 +0000 (12:39 +0900)]
Add sns.park in the S_TRUNK_OWNERS of the top directory
SeungSeop Park <sns.park@> has been designated
as an owner of the top directory of chromium-efl.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4540
Change-Id: I76a2db5a0cd15c139865b247b3f306c3ca4ff3fd
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Youngbok Yoon [Mon, 20 Oct 2014 06:31:07 +0000 (15:31 +0900)]
Change base platform for mobile to
20141020.002 binary
We now move to newer mobile platform PtnZ910FXX_20141020.002, where
HD Winset(ex. Context center popup) is available.
To do that, this patch updates the base repo url of gbs.conf.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8142
Reviewed by: Kangil Han, Antonio Gomes
Change-Id: I2e3d45317c8808dc67db4b818e26c130ad73cf27
Signed-off-by: Youngbok Yoon <youngbok.yoon@samsung.com>
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Tomasz Olszak [Fri, 24 Oct 2014 07:31:03 +0000 (09:31 +0200)]
Made that grep for profile parameter in build_{tv,mobile} now always succeeds.
grep returns non 0 status when it doesn't find any matching string. If someone
used set -e in parent script which invoked build_{tv,mobile} then got error and
script exited.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7957
Reviewed by: Kangil Han
Change-Id: I9dfa0c026f65a25db071f89a4d10d871290db52a
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
qi1988.yang [Mon, 20 Oct 2014 09:50:20 +0000 (17:50 +0800)]
[M34-Merged] Assuring correct pointer initializations. (impl folder)
Added missing pointer class members initializations.
Origin patch(M34): http://suprem.sec.samsung.net/gerrit/#/c/3960/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7802
Reviewed by: Antonio Gomes
Change-Id: I027b77512ac37325e6d698d2005a96e06dc4ae95
Signed-off-by: qi1988.yang <qi1988.yang@samsung.com>
zhishun.zhou [Fri, 17 Oct 2014 09:32:09 +0000 (17:32 +0800)]
[Tizen][M34-Merge] Implement WebContext::ClearCandidateData
This patch implement ClearCandidateData, which will be
used by ewk_context_form_candidate_data_clear API.
It depended on auto fill feature(TIZEN_AUTOFILL_SUPPORT).
This is code migration from m34 beta to DEV,
Original patch info: http://suprem.sec.samsung.net/gerrit/#/c/4963/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7742
Reviewed by: Antonio Gomes
Change-Id: I73795f52d094c2b6f01d7bf5c579ddd60a589f31
Signed-off-by: zhishun.zhou <zhishun.zhou@samsung.com>
Antonio Gomes [Sun, 26 Oct 2014 11:28:14 +0000 (04:28 -0700)]
fixup! [Tizen] Switch chromium-efl / mobile development to GCC 4.8
Remove experimental c++11 enabling line, now that it is not
explicitly needed.
Also remove a GCC 4.5 specific workaround, also not needed anymore.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5458
Reviewed by: Laszlo Gombos, Kangil Han
Change-Id: I89e7c320e22631a5c32587666f5480a7aead4d94
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
zhuoyu.qian [Fri, 17 Oct 2014 06:28:50 +0000 (14:28 +0800)]
[M34-Merge]Fixed creation of GURL from URL
M34 commit URL: http://suprem.sec.samsung.net/gerrit/#/c/4649/
When given URL is empty, returned GURL is an empty string "".
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7709
Reviewed by: Antonio Gomes
Change-Id: Ib0f3f2ff0494c3cd14235623188e1c739fbc2c5a
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
zhishun.zhou [Sat, 25 Oct 2014 10:10:56 +0000 (18:10 +0800)]
[Tizen]Implement ewk_view_main_frame_get
This patch implements ewk_view_main_frame_get.
This is code migration from m34 beta to DEV,
Original patch info:
http://suprem.sec.samsung.net/gerrit/#/c/5160/3
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6006
Reviewed by: Antonio Gomes, Laszlo Gombos
Change-Id: I9c50c876abee78bbf1729a627e89c66920a9840a
Signed-off-by: zhishun.zhou <zhishun.zhou@samsung.com>
SeungSeop Park [Fri, 24 Oct 2014 08:24:09 +0000 (17:24 +0900)]
fixup! Enable Tizen build on dev/m39_2171
Now the chromium version is m39_2171.
Reviewed by: Antonio Gomes, Kangil Han
Change-Id: I9f1fada89f7f17632a6411af3639b7482447e6ad
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
zhishun.zhou [Sat, 18 Oct 2014 09:46:54 +0000 (17:46 +0800)]
[Tizen] Implement EWK API for window features
This patch implements EWK API for window features.
This is code migration from m34 beta to DEV,
Origin patch patch info:
http://suprem.sec.samsung.net/gerrit/#/c/6721
and http://suprem.sec.samsung.net/gerrit/#/c/6726
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7782
Reviewed by: Antonio Gomes
Change-Id: I1b9cdcc0d4435073b32a547b95e81256c65d335f
Signed-off-by: zhishun.zhou <zhishun.zhou@samsung.com>
Arnaud Renevier [Fri, 24 Oct 2014 01:53:38 +0000 (18:53 -0700)]
Reenable (uncomment) cleanup for unittests
Uncomment cleanup code in utc_blink_ewk_base::EwkDeinit. Before it was
trigerring a crash but this was fixed by commit
19e1f0214adaea576
(http://165.213.202.130:8080/#/c/70986/).
http://107.108.218.239/bugzilla/show_bug.cgi?id=6980
Reviewed by: Balazs Kelemen, Antonio Gomes
Change-Id: I2a88eb88ffc6f1fdd57c25cddda77cab52051e63
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 22 Oct 2014 00:02:11 +0000 (17:02 -0700)]
Remove LOG(INFO) debugging
The messages currently printed with LOG(INFO) are not really useful to
have in the standard output.
This patch also removes StartMemorySampler and StopMemorySampler apis
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7938
Reviewed by: Viatcheslav Ostapenko
Change-Id: I22381f2d07f8289add85f26401ea6bc5e4fd226b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
zhaoze [Thu, 18 Sep 2014 15:29:27 +0000 (11:29 -0400)]
[Tizen] Bringup InputPicker
Currently in Tizen, InputPicker is not enabled, this patch
will bring it back.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4834
Reviewed by: Antonio Gomes
Change-Id: Iaf18becf22090ee5254040d49fec7fbbaad0db6d
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
zhaoze [Wed, 22 Oct 2014 22:02:02 +0000 (18:02 -0400)]
[Tizen] Enable use_libjpeg_turbo
Currently we disable use_libjpeg_turbo and use the use_system_libjpeg.
Using libjpeg_turbo is an important optimization for chromium.
From our image_decode_bench, we got the following result:
TotalRuntime AverageRuntime
enbale turbo 1.758999(s) 0.001759(s)
disbale turbo 3.535364(s) 0.003535(s)
Image source: http://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg
The result shows it's two times faster when decodes
the jpeg image use the libjpeg_turbo.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5197
Reviewed by: Laszlo Gombos, Antonio Gomes
Change-Id: Ibbd76d11cbc44b31fa80f60a35423623936cd2e4
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
zhuoyu.qian [Fri, 17 Oct 2014 05:00:56 +0000 (13:00 +0800)]
[M34-MERGE] Fixed calling WebContentsFromFrameID outside UI thread
Fixed calling web_contents_utils::WebContentsFromFrameID outside UI
thread in LoginDelegateEfl.
Issue manifested by test utc_blink_ewk_auth_challenge_suspend_func on desktop.
change to use the render frame not render view and check the result
when get render frame from given request
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7638
M34 commit IDs:
c733fee9ee8d98c7f508ab210b6f42d649a8e9b5 &
4cac0f18419e1396c016e316b540a344ffbf4f16
Reviewed by: Yi Shen, arno renevier, Laszlo Gombos, Antonio Gomes, Kamil Klimek
Change-Id: I28dcb00cadd731f5ebe819e3a3d4f1dd732aa972
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Arnaud Renevier [Mon, 13 Oct 2014 17:27:27 +0000 (10:27 -0700)]
Enable Tizen build on dev/m39_2171
This patch enables Tizen build on dev/m39_2171
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7040
Reviewed by: Laszlo Gombos
Change-Id: I934c9bc2db7d93a3579010d7aa02d91e7f1f80bb
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 20 Oct 2014 03:29:25 +0000 (20:29 -0700)]
fixup! Fix WebContentsDelegateEfl because of updates in chromium WebContentsDelegate
The LoadFinished callback is not called because of a typo in
6de7cadd
This patch fixes it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7792
Reviewed by: Antonio Gomes
Change-Id: Id69dd7fe3eecd9601bff05ee4cf31a13e03370c0
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Thu, 16 Oct 2014 23:19:40 +0000 (16:19 -0700)]
Fixes crash when using virtual keyboard.
For whatever reason, when typing a text, once the second character has
been entered, EWebView::UpdateHitTestData is called. It crashes during
the copy of SkBitmap.
One way to prevent the crash is to avoid the copy of the
Hit_Test_Image_Buffer (and therefore the SkBitmap) in _Ewk_Hit_Test ipc
struct. Hit_Test_Image_Buffer is not used by the renderer.
In the long term, we should probably investigate more the underlying
nature of the crash. But for the moment, this patch allows the keyboard
to work without crashing.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5456
Reviewed by: Antonio Gomes
Change-Id: I9d7061e220a17d067f2a0e2b62c0c05b0af449a1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Balazs Kelemen [Mon, 6 Oct 2014 18:52:02 +0000 (14:52 -0400)]
Enhance Tizen device development with faster deployment
Add rsync based fast push script and helpers to make deployment easy and fast.
The scripts upload libs and binaries as is (no rpm install) Envsetup script
provided for device.
This workflow has been chosen since it is suitable for both gbs and
cross-compile workflow. It is a developer-only setup, not in any sense
a replacement for rpm.
rpm based workflow can also benefit from rsync (using tizensync.sh directly).
Uploading libchromium-efl.so (stripped, release) with gbs takes ~34sec in my
environment. With this scripts it went down to ~8sec and the difference can
only be bigger when reuploading after build.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6900
Reviewed by: Viatcheslav Ostapenko, Antonio Gomes
Change-Id: I99c81a1f3b979e73a3d746cf5f4dd56b35380069
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
qi1988.yang [Tue, 21 Oct 2014 10:31:09 +0000 (18:31 +0800)]
Ewk_Frame renamed to tizen_webview::Frame
Origin patch(M34): http://suprem.sec.samsung.net/gerrit/#/c/5159/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7901
Reviewed by: Antonio Gomes, arno renevier, Laszlo Gombos, Yi Shen
Change-Id: I046381097dfb1ebc07408ebc5d37726eba6807c9
Signed-off-by: qi1988.yang <qi1988.yang@samsung.com>
Antonio Gomes [Tue, 21 Oct 2014 08:31:57 +0000 (17:31 +0900)]
[Tizen] Switch chromium-efl / mobile development to GCC 4.8
Patch allows building and running chromium-efl with GCC 4.8
on our current tizen mobile targets, and plus it makes it
sane to rebase against chromium.org, and its wave of C++11 features.
---Build---
Our latest mobile platform is based on Tizen 2.3 profile,
where libc 2.13 and as GCC 4.6 compatible binaries are
available. Logically, our development toolchain also provides
the same versions of such binaries by default.
In order to build things with a newer version of both libc and
GCC, a custom "supplement" repository [1] was introduced. GBS then
pulls in the appropriated versions of the packages.
[1] http://10.251.52.177/tizenrepo/eur-open/supplement_gcc48
PS: Thanks SeungSeop Park!
---Run---
Figuring out how to run a GCC 4.8-derived chromium-efl build
on our mobile target was particularly tricky.
The solution found was making use of custom libc installation
on target, allowing us to have multiple libc versions available.
While building chromium-efl, at link step, both "rpath" and
"dynamic-linker" linker options were set to this custom installation
directory, expanding our runtime search as per our needs.
This affects chromium-efl.so and chromium-ewk.so, as well as
efl_webprocess, mini_browser and efl_webview_app.
There were also stdc++ incompatibilities at runtime. This was
solved by making use of 'static-libstdc++' and 'static-libgcc'
linker options.
---Deployment---
Patch also adds a convenience-script that deploys the new libc
binaries at pre-defined location (/opt/usr/eglibc-2.18/lib) on
target. One just needs to execute it as below (to be done once,
upon device flash):
$ ./build/deploy_libc_to_target.sh
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5458
Reviewed by: SeungSeop Partk, Viatcheslav Ostapenko, Balazs Kelemen, Laszlo Gombos, Yi Shen, Arnaud Renevier.
Change-Id: Ibed11beba50f205b3d193b32e220a7ae165ca75c
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
zhuoyu.qian [Tue, 14 Oct 2014 08:59:44 +0000 (16:59 +0800)]
Add missing callback APIs used by com.samsung.browser.
M34 commit ID:
aea2fce3b55a003ded94ce9243df52be538ac581
Add missing callback APIs that are used by com.samsung.browser.
+ "overflow,scroll,off"
+ "overflow,scroll,on"
+ "touchmove,handled"
+ "weblogin,checkbox,clicked"
+ "weblogin,checkbox,resume"
+ "weblogin,ready"
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7456
Reviewed by: Antonio Gomes, arno renevier, Laszlo Gombos
Change-Id: I73217807b00c6e17d1706d3926f2978dd5da969b
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
zhuoyu.qian [Fri, 17 Oct 2014 08:33:38 +0000 (16:33 +0800)]
Fix WebView::SetUserAgentAppName
WebView::SetUserAgentAppName was calling incorrect API, so fix it.
M34 commit ID:
146cf4767a84c1956c624f00e0b44bbe5282d38f
Issue: http://http://suprem.sec.samsung.net/jira/browse/CBWEBVIEW-893
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7744
Unit test: utc_blink_ewk_view_app_name_user_agent_set_func.cpp
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko, arno renevier, Yi Shen
Change-Id: I8ddd5bed16991fbcb723bf33492ce0b86cb181f5
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
zhaoze [Wed, 10 Sep 2014 21:06:07 +0000 (17:06 -0400)]
[Tizen] Re-factor WebContents usage by EWK API implementation
WebContents is the main object of the content API from user
perspective. The object represents a web widget with extra
logic used to manipulate it's state (LoadUrl, go back, stop
loading page, etc). A lot of this logic maps directly to what
EWebView class is supposed to do. It's can be easily said that
EWebView is a wrapper aroud WebContents.
In the current codebase the actual ownership of WebContents is
rather strange. It's not held directly by it's main user, but by
WebContentsDelegateEfl. As a direct result we:
1. Do lot of unecessary web_contents_delegate_->web_contents()
getter calls.
2. We often pass WebContentsDelegate to objects that only need
WebContents
3. Have bunch of unnecessary WebContents NULL checks. The
classes which make them could not even be instantiated if
WebContents did not exist.
This patch moves the ownership of WebContsnts to EWebView.
It also changes, wherever possible, WebContents pointers to
references.
Original patch: http://165.213.202.130:8080/#/c/69163/3
Original author: Piotr Tworek <p.tworek@samsung.com>
Reviewed by: Antonio Gomes
Change-Id: I507f270f2fa62ca70a4d24972359c8be5b5c3175
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
SeungSeop Park [Wed, 22 Oct 2014 05:52:52 +0000 (14:52 +0900)]
fixup! Fixed return status for tv and mobile build scripts.
Previoulsy the build script build/build_mobile|tv.sh always returned 1.
This is because
- if GBS_RET is 0, [ "$GBS_RET" != "0" ] is evaluated to 1,
which in turn becomes the return value of the script.
- if GBS_RET is 1, the script exits with the value of GBS_RET.
The solution is to exit with 0 at the end of script.
Reviewed by: Antonio Gomes, mohan reddy, Kangil Han
Change-Id: I1647dfb3d63ca9b60ac2a7b77421540ef7108175
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Youngsoo Choi [Mon, 20 Oct 2014 08:40:21 +0000 (17:40 +0900)]
Fix chromium-efl installation issue on device
[Issue]
When installing chromium-efl rpm package by using pkgcmd command,
following error is coming.
> __return_cb req_id[1] pkg_type[rpm] pkgid[org.tizen.chromium-ewk]
> key[error] val[11] error message: Manifest File Not Found
[Resolve]
The 'packaging/chromium-efl.spec' includes the line below that
will be executed during package installation.
> install -m 0644 ewk/efl_webview_app/org.tizen.chromium-efl.xml
> "%{buildroot}"%{_datadir}/packages
By the way, the chromium-efl rpm package name is "org.tizen.chromium-efl".
But in the 'org.tizen.chromium-efl.xml', a pakcage name is defined as below.
> package="org.tizen.chromium-ewk"
The installation issue has been caused by miss-matched package name.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7739
Reviewed by: Antonio Gomes, Youngbok Yoon
Change-Id: Id2575e89f8d2ff1e09856928fa52ea40da499855
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Tomasz Olszak [Thu, 16 Oct 2014 14:07:01 +0000 (16:07 +0200)]
Fixed return status for tv and mobile build scripts.
Buildbot always got exit status == 0.
In case when gbs failed the exit status was overwritted by:
${SCRIPTDIR}/apply_patches.sh -r.
Change-Id: I4cc5f1afd1d5fa67d2d5a18ac7e66f445f7dc5f7
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Viatcheslav Ostapenko [Tue, 14 Oct 2014 21:00:27 +0000 (17:00 -0400)]
Remove gl_context_glx_override.cc
Not needed after switching of desktop to GLES2.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5599
Change-Id: Idba614df3c96ca5160a5e97280b37afc175f9fc9
Signed-off-by: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Youngsoo Choi [Wed, 15 Oct 2014 11:28:32 +0000 (20:28 +0900)]
[M39] Fix tv build break
1) The character '\' is missed in 'build/build_tv.sh'.
2) The sensor library-level issue on tizen v2.1 and v2.2.1.
Error log is like below.
>> /usr/include/sensor/sensor.h:76:26: fatal error:
>> sensor_accel.h: No such file or directory
The '#include <sensor_accel.h>' is defined in 'sensor.h' that is
provided by platform rpm repository, and the 'sensor_accel.h' is
located in '/usr/include/sensor/'.
To use '#include <sensor_accel.h>' in 'sensor.h' file,
the path '/usr/include/sensor' needs to be defined in following pc file.
>> ./usr/lib/pkgconfig/capi-system-sensor.pc
However, on tizen v2.1 and v2.2.1,
the header path '/usr/include/sensor' is not included in pc file like below.
>> includedir=/usr/include/system
On the other hand, on tizen v2.3, it is properly included like below.
>> includedir=/usr/include/sensor
Therefore, the header path '/usr/include/sensor' needs to be defined in gyp file
for tizen v2.1 and v2.2.1.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5676
Change-Id: Ie372f8e685eb7c829319b735ef41d4de2824b2e7
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Arnaud Renevier [Wed, 1 Oct 2014 21:21:33 +0000 (14:21 -0700)]
Fixes build failures in ewk/unittest
This patch unimplemented features with #if !defined(EWK_BRINGUP). Since
g_type_init has been deprecated since glib2.36, it also adds a version
check. And lastly, it removes some unneeded .cpp includes.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5477
Change-Id: Iefee2c3868378d644d8e8342e01563c7792fdadd
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Tomasz Olszak [Wed, 20 Aug 2014 02:01:48 +0000 (11:01 +0900)]
Added check for ccache if ccache option is used.
It will provide more developer friendly output in case ccache is not installed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4975
Change-Id: Ic128135191244c5633607f7c09e4a58cf428b15d
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Tomasz Olszak [Tue, 7 Oct 2014 13:11:32 +0000 (15:11 +0200)]
Use checked-in gbs.conf by default
Also added possibility to pass profile name parameter to build scripts.
Fixed issue with not using build/gbs.conf file by default.
README.md updated with more verbose description introduced in beta/m34 branch.
Change-Id: I60bfccafc16e94bc32a1b4b4aaf4795d754d6525
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Balazs Kelemen [Fri, 10 Oct 2014 22:44:38 +0000 (18:44 -0400)]
WebView::UrlRequestSet is crashy
Dereferencing uninitialized pointer is not fun.
This was also fixed in beta but I believe my fix is slightly better.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7257
Change-Id: Ice150d05227b5092ba1d756cfb68f035123d9932
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Viatcheslav Ostapenko [Wed, 8 Oct 2014 16:37:40 +0000 (12:37 -0400)]
Use GL ES 2 on desktop.
Switch desktop build to use OpenGL ES 2.
This will make it use common rendering path with phone and a lot of graphics
features would be easier to develop.
Requires install additional ubuntu package and rebuild of dependencies.
To make it work do:
sudo apt-get install libgles2-mesa-dev
rm -rf out.x64/Dependencies/jhbuild.stamp out.x64/Dependencies/Root
./build/build_desktop.sh --debug
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5599
Change-Id: I10b67a7c8f11f6800cffd8ed1454ecc6561fb45a
Signed-off-by: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Tomasz Olszak [Tue, 19 Aug 2014 07:54:58 +0000 (16:54 +0900)]
Added additional python accelerator packages for tv.
Currently mobile provides some x86-arm accelerator
packages which makes possible to use x86 python
in arm sysroot. Those packages were added to supplement_tv
repository and are used only for tv build in build_tv.sh.
Using them decreases gyp_chromium script run time significantly
(on HQ build server from run time went down from 30 minute
to 1 minute)
Reviewed by: SeungSeop Park, Balazs Kelemen and Antonio Gomes.
Change-Id: If13b19a75a6919d24fc6da2f9cd28a1f970e4575
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
zhaoze [Mon, 13 Oct 2014 19:54:13 +0000 (15:54 -0400)]
fixup! fixup! Add Tizen-platform implementation of Web View
Add Semicolon to fix build
Change-Id: I6e3691120f97d3e09905959a2f59c798c62602b9
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
zhaoze [Thu, 11 Sep 2014 14:44:38 +0000 (10:44 -0400)]
[Tizen] Bringup Suspend/Resume JavaScript from m34
[Issue#] CBWEBCORE-301
[Problem] JavaScript should be executing after switch to background.
[Solution] Scheduled tasks are suspend / resume during switch to
background.
This is related with: http://165.213.202.130:8080/#/c/69891/
Original Author: Michal Poteralski <m.poteralski@samsung.com>
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6109
Change-Id: I753a20dbdac8bc1604e4f00c3553e9726e331a9e
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
Conflicts:
impl/renderer/render_view_observer_efl.h
Tomasz Olszak [Wed, 3 Sep 2014 11:52:47 +0000 (13:52 +0200)]
ccache dir moved outside source directory in gbs builds.
Previously ccache directory for gbs was placed in
chromium-efl directory. It was reusable because by default all builds
were made with --incremental flag so chromium-efl repo dir
was mounted into gbs build root. Without -incremental flag
it is not possible anymore. However we can use /.ccache directory inside
gbs sysroot for that. It is not removed even when different package is
built or -C flag is passed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5263
Change-Id: Iab7481f38916f19877eeed0dde96fd11e45fb365
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
zhaoze [Wed, 8 Oct 2014 21:01:25 +0000 (17:01 -0400)]
fixup! Add Tizen-platform implementation of Web View
Change "if(..)ASSERT();" to CHECK.
Change-Id: If2222a46690fff3b5e9233257b4ec291e9a8f418
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>
Tomasz Olszak [Thu, 9 Oct 2014 11:43:08 +0000 (13:43 +0200)]
gbs.conf updated (golf and hawk tv profiles added, mobile repos url updated)
Change-Id: I66c69713263e16d4001443da9cd1be7e67a4e018
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Arnaud Renevier [Thu, 9 Oct 2014 00:08:08 +0000 (17:08 -0700)]
fixup! Merge New ewk_view_hit_test_request API proposal from M34
Fixes build error after
1600689c7066
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6388
Change-Id: I9b101712d1d165f8f47c8ebb73087442308cf4e5
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
SeungSeop Park [Mon, 6 Oct 2014 06:52:56 +0000 (15:52 +0900)]
Change base platform for TV to pre-hawk repo
Updated build/gbs.conf to have proper repo urls.
Change-Id: I8eda451c194f3ca9251b2747bc9e1eecb6a39f2a
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
zhaoze [Tue, 23 Sep 2014 21:06:00 +0000 (17:06 -0400)]
[Tizen] Bringup DidChangeContentsSize
Notify RenderView Observers when Contents Size Change
This allows EFL WebView to update it's content size.
Original author: SeungSeop Park <sns.park@samsung.com>
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4415
Change-Id: I674fdf43e65094019c596ffd3ebb139b3a4c61c4
Signed-off-by: zhaoze <zhaoze.zhou@partner.samsung.com>