commit-bot@chromium.org [Thu, 6 Mar 2014 23:08:33 +0000 (23:08 +0000)]
Whitespace change to verify that the bots are fixed
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
NOTREECHECKS=true
NOTRY=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
189253003
git-svn-id: http://skia.googlecode.com/svn/trunk@13694
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 21:48:57 +0000 (21:48 +0000)]
Whitespace change to test whether builders are fixed
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:2264
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
188633005
git-svn-id: http://skia.googlecode.com/svn/trunk@13693
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 20:53:44 +0000 (20:53 +0000)]
Add debug check of chunk size written to skp
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
182153003
git-svn-id: http://skia.googlecode.com/svn/trunk@13692
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 20:34:02 +0000 (20:34 +0000)]
Mark mixed_xfermodes_gpu on Win7 perspective bot as ignore-failure
BUG=skia:2262
NOTRY=true
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
183803034
git-svn-id: http://skia.googlecode.com/svn/trunk@13691
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:56:58 +0000 (19:56 +0000)]
Remove MCRec.fNext
No longer used.
R=reed@google.com, mtklein@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
186973004
git-svn-id: http://skia.googlecode.com/svn/trunk@13690
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:29:24 +0000 (19:29 +0000)]
Manually add baseline for typeface_565
BUG=skia:2146
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
180533011
git-svn-id: http://skia.googlecode.com/svn/trunk@13689
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:23:51 +0000 (19:23 +0000)]
Actually, we wrote only size bytes.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
188343004
git-svn-id: http://skia.googlecode.com/svn/trunk@13688
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 19:10:44 +0000 (19:10 +0000)]
Avoid recomputing two consecutive identical 1D filters.
If the arguments to the X and Y filter computation are identical,
the results will be identical; copying is much faster than recomputing.
With a change like https://codereview.chromium.org/
183763047/ applied
this speeds up BitmapScaleBench on Linux by around 10%.
BUG=skia:2236
R=humper@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
188743002
git-svn-id: http://skia.googlecode.com/svn/trunk@13687
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:47:49 +0000 (17:47 +0000)]
Make arm64 test script more efficient with old versions of gsutil.
This continues the changes indtroduced in
<https://codereview.chromium.org/
183883020>, and also simplifies the
script considerably.
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
176973010
git-svn-id: http://skia.googlecode.com/svn/trunk@13686
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:16:37 +0000 (17:16 +0000)]
Adding this call simulates seeing a *different* bitmap every time we scale, which changes the code path (places much heavier load on constructing a new filter). This better emulates the kind of environment most embedders see us in, where they try to cache a scaled bitmap rather than frequently rescaling it.
This change will cause significant regressions in microbenchmark scores.
BUG=skia:2236
R=humper@google.com, reed@google.com, scroggo@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
183763047
git-svn-id: http://skia.googlecode.com/svn/trunk@13685
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 17:16:26 +0000 (17:16 +0000)]
Add size_t bytesWritten() const to SkWStream.
BUG=skia:
R=reed@google.com, mtklein@google.com, robertphillips@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
187653003
git-svn-id: http://skia.googlecode.com/svn/trunk@13684
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 6 Mar 2014 15:37:53 +0000 (15:37 +0000)]
Revert of Manually set fFilterValues in SkConvolutionFilter1D
Revert of https://codereview.chromium.org/
184323003
Reason for revert:
Caused unexpected CompareGM failures-
http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86_64-Debug/builds/461/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Release/builds/2062/steps/CompareGMs/logs/stdio
http://108.170.217.252:10117/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/1400/steps/CompareGMs/logs/stdio
TBR=
NOTREECHECKS=True
NOTRY=True
git-svn-id: http://skia.googlecode.com/svn/trunk@13683
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 15:13:53 +0000 (15:13 +0000)]
Begin making SkPerlinNoiseShader const.
The overall goal is to make SkShader itself immutable (BUG=skia:1976).
The fields cannot yet be made constant, due to the constructor which
takes an SkReadBuffer. Other than that constructor, the fields are now
unchanged.
Remove setTileSize and initPaint. Merge initPaint with the constructor
of PaintingData, since it is only ever used on a new PaintingData.
Merge setTileSize with the SkPerlinNoiseShader constructor, its only
call site.
BUG=skia:1976
R=reed@google.com, sugoi@google.com, dominikg@chromium.org, senorblanco@google.com, senorblanco@chromium.org
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
169973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13682
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 14:57:46 +0000 (14:57 +0000)]
Manually set fFilterValues in SkConvolutionFilter1D.
Using fFilterValues.reset() or a loop of fFilterValues.push_back() is about 5x slower than calling fFilterValues.resize_back() and then looping using primitive [] and =.
This is only going to show up if you apply https://codereview.chromium.org/
183763047/, where it yields about 2.5% speedup in the bitmap resize microbenchmarks on a Linux desktop. Ceteris paribus, it should actually improve rasterization time of drawBitmapRectToRect() with a resize by about 5% in Chromium.
BUG=skia:2258
R=humper@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
184323003
git-svn-id: http://skia.googlecode.com/svn/trunk@13681
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 6 Mar 2014 13:18:07 +0000 (13:18 +0000)]
Now that the matching changes have landed in Chromium we can clean up the API on our side.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
187553003
git-svn-id: http://skia.googlecode.com/svn/trunk@13680
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 6 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13679
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 20:59:45 +0000 (20:59 +0000)]
Give PictureTest more verbose error messages.
Motivation: On an odd build system I'm testing, we're triggering these
errors. More verbose test output will help me diagnose the errors.
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
183023014
git-svn-id: http://skia.googlecode.com/svn/trunk@13678
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 20:49:59 +0000 (20:49 +0000)]
Update baselines for Win7 perspective and Nexus4
BUG=skia:2146
NOTRY=true
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
185943007
git-svn-id: http://skia.googlecode.com/svn/trunk@13677
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 19:46:17 +0000 (19:46 +0000)]
rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images
BUG=skia:2248,skia:2231
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
183893030
git-svn-id: http://skia.googlecode.com/svn/trunk@13676
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 19:41:10 +0000 (19:41 +0000)]
Fix FontMgrTest to allow for unnamed fonts.
Motivation: we are testing on a system without fonts and are falling
back on SkTypeface_Empty.
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
187933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13675
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 18:27:43 +0000 (18:27 +0000)]
Unify edge type enums across GrEffect subclasses that clip rendering to a geometry.
BUG=skia:
R=egdaniel@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
183893023
git-svn-id: http://skia.googlecode.com/svn/trunk@13674
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 18:25:20 +0000 (18:25 +0000)]
This CL is motivated by the desire to make the skpinfo tool work a bit better. The main concern is that the assumptions made w.r.t. written bytes may not be valid for all SkWStream sub-classes.
R=bungeman@gmail.com, bungeman@google.com, reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
182733008
git-svn-id: http://skia.googlecode.com/svn/trunk@13673
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 17:09:46 +0000 (17:09 +0000)]
Remove unused TimerData that generates errors
As far as I can tell all uses of TimerData::appendTimes were stripped out in https://chromiumcodereview.appspot.com/
23121002 but the surrounding code was left in, causing it to print errors when there are none.
BUG=skia:2242
R=sglez@google.com, tomhudson@chromium.org, mtklein@google.com, tomhudson@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
187643002
git-svn-id: http://skia.googlecode.com/svn/trunk@13672
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 5 Mar 2014 16:26:14 +0000 (16:26 +0000)]
Prevent SkBlockMemoryStream::skip from writing to low memory.
SkBlockMemoryStream::read was modeled on SkDynamicMemoryWStream::read.
However, SkDynamicMemoryWStream::read does not allow passing a NULL buffer
and SkBlockMemoryStream::read must correctly handle this case for skips.
In the current code, if a 'skip' crosses a block boundary, 'read' may
attempt to write to low memory.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
187683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13671
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 5 Mar 2014 15:38:21 +0000 (15:38 +0000)]
New baselines for offsetimagefilter GM.
TBR=rmistry@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
187883002
git-svn-id: http://skia.googlecode.com/svn/trunk@13670
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 15:37:11 +0000 (15:37 +0000)]
DM: read image files without an extra copy
BUG=skia:
R=halcanary@google.com, reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185263012
git-svn-id: http://skia.googlecode.com/svn/trunk@13669
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 14:16:36 +0000 (14:16 +0000)]
Make arm64 test script comaptable with old versions of gsutil.
NOTRY=true
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
183883020
git-svn-id: http://skia.googlecode.com/svn/trunk@13668
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 13:44:18 +0000 (13:44 +0000)]
Replace scaled bitmap if entry already exist in cache.
BUG=skia:2251
R=reed@google.com
Author: reveman@chromium.org
Review URL: https://codereview.chromium.org/
185263009
git-svn-id: http://skia.googlecode.com/svn/trunk@13667
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 13:43:15 +0000 (13:43 +0000)]
remove deprecated use of bitmap config from tests
BUG=skia:
R=halcanary@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
184233003
git-svn-id: http://skia.googlecode.com/svn/trunk@13666
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 5 Mar 2014 03:02:06 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13665
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 02:34:58 +0000 (02:34 +0000)]
remove SK_SUPPORT_DEEPCOPYTO_CONFIG code -- no longer used
R=reed@google.com
TBR=bsalomon@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
183763035
git-svn-id: http://skia.googlecode.com/svn/trunk@13664
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 5 Mar 2014 01:00:50 +0000 (01:00 +0000)]
Counterproposal to
182733007: Add iterator to SkTDynamicHash
BUG=skia:
R=egdaniel@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
177263005
git-svn-id: http://skia.googlecode.com/svn/trunk@13663
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 22:37:29 +0000 (22:37 +0000)]
Manual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf regression.
BUG=344020
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
187023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13662
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 22:32:49 +0000 (22:32 +0000)]
Fix error in barelinux_make build script
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
187093002
git-svn-id: http://skia.googlecode.com/svn/trunk@13661
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 20:44:32 +0000 (20:44 +0000)]
Factor out a BaseContext from JsContext.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
186783004
git-svn-id: http://skia.googlecode.com/svn/trunk@13660
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Mar 2014 19:22:43 +0000 (19:22 +0000)]
New baselines for imagefiltersclipped, imagefiltersscaled GMs.
Required after r13637.
TBR=rmistry@google.com
Review URL: https://codereview.chromium.org/
186933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13659
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 19:08:57 +0000 (19:08 +0000)]
The motivation for this CL is to de-clutter SkPicture's beginRecording method.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
186813003
git-svn-id: http://skia.googlecode.com/svn/trunk@13658
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 19:05:50 +0000 (19:05 +0000)]
Start prototyping what DisplayList support will look like.
None of the new codepaths get executed yet since DisplayList doesn't exist, but that will happening in the new few CLs.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
183883017
git-svn-id: http://skia.googlecode.com/svn/trunk@13657
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Mar 2014 19:05:25 +0000 (19:05 +0000)]
Apply the CTM to the offset in the slow SkOffsetImageFilter path.
This was being done in the fast path, but not the slow path.
Since I had to rebaseline the offsetimagefilter GM anyway (to accomodate
the new test case), I added a red border around the intersection
of the (transformed) crop rect and clip rect in each sample, beyond
which no pixels should be drawn.
Chrome bug: https://code.google.com/p/chromium/issues/detail?id=346362
BUG=skia:
R=sugoi@google.com
Review URL: https://codereview.chromium.org/
186643003
git-svn-id: http://skia.googlecode.com/svn/trunk@13656
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Mar 2014 16:52:20 +0000 (16:52 +0000)]
Make rrects.cpp compile in no-gpu mode
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
186663004
git-svn-id: http://skia.googlecode.com/svn/trunk@13655
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 16:46:22 +0000 (16:46 +0000)]
rebaseline_server: better reporting for bad URL fetch
context: https://codereview.chromium.org/
183763025/ ('vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own')
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
183833019
git-svn-id: http://skia.googlecode.com/svn/trunk@13654
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 16:25:34 +0000 (16:25 +0000)]
Add GM that directly tests GrRRectEffect and add inverse fill version of effect.
BUG=skia:
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
176843016
git-svn-id: http://skia.googlecode.com/svn/trunk@13653
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 14:41:52 +0000 (14:41 +0000)]
New baselines for perspective switch
BUG=skia:2245
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
186563004
git-svn-id: http://skia.googlecode.com/svn/trunk@13652
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 4 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13651
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 4 Mar 2014 00:58:21 +0000 (00:58 +0000)]
rebaseline_server: keep going on exception in ImagePair.__init__()
BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
184103022
git-svn-id: http://skia.googlecode.com/svn/trunk@13650
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:41 +0000 (23:25 +0000)]
This adds cull rect visualization to the debugger's "mega" visualization mode.
R=fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
177423013
git-svn-id: http://skia.googlecode.com/svn/trunk@13649
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:26 +0000 (23:25 +0000)]
Don't emit declaration of gl_FragPos unless also changing the origin.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
182003002
git-svn-id: http://skia.googlecode.com/svn/trunk@13648
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 22:50:13 +0000 (22:50 +0000)]
bench rebase after skp update.
BUG=skia:2163
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
182443005
git-svn-id: http://skia.googlecode.com/svn/trunk@13647
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 3 Mar 2014 22:13:56 +0000 (22:13 +0000)]
Cleanup patch to move all of SkImageFilterUtils into SkImageFilter.
This was a utility class that dates from before GPU code was allowed
in core. Now that it is, there's no reason not to have this
functionality in SkImageFilter.
Covered by existing tests.
R=reed@google.com
Review URL: https://codereview.chromium.org/
185973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13646
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:31:08 +0000 (19:31 +0000)]
Baselines for skia:2146
BUG=skia:2146
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
180253004
git-svn-id: http://skia.googlecode.com/svn/trunk@13645
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:23:28 +0000 (19:23 +0000)]
Rename test files to end with Test.cpp.
DM builds all of {bench,gm,test}/*.cpp. A Windows build warned us that we were
trying to link typeface.obj twice. This must have something to do with there
existing gm/typeface.cpp and tests/Typeface.cpp. To be safe, make sure tests
have a Test.cpp suffix to disambiguate.
BUG=skia:
R=rmistry@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185923002
git-svn-id: http://skia.googlecode.com/svn/trunk@13644
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 19:18:39 +0000 (19:18 +0000)]
Generating the 1M skps frequently yields truncated skps. This tool is intended to help automate weeding these out.
Please see skbug:1057
rmistry for tools, gyp
mtklein for src\core & include\core
BUG=skia:1057
R=rmistry@google.com, mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
176863004
git-svn-id: http://skia.googlecode.com/svn/trunk@13643
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 17:57:41 +0000 (17:57 +0000)]
roll_deps: Return a tuple even when returning early
This fixes the bot going red when DEPS is already up-to-date.
BUG=skia:
R=halcanary@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
185413012
git-svn-id: http://skia.googlecode.com/svn/trunk@13642
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 17:51:12 +0000 (17:51 +0000)]
Add the ability to select bbh type, and include quadtree support.
This is a breaking change to tileGridSize flag added in
184543003, as it now defaults to a sensible value but does not implicitly turn on the tile grid bbh.
BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, skyostil@chromium.org, skyostil@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
183763022
git-svn-id: http://skia.googlecode.com/svn/trunk@13641
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 16:32:17 +0000 (16:32 +0000)]
The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves).
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
185293007
git-svn-id: http://skia.googlecode.com/svn/trunk@13640
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 15:44:56 +0000 (15:44 +0000)]
DM: tweak output.
Show task name in verbose mode only, and add task runtime.
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185233004
git-svn-id: http://skia.googlecode.com/svn/trunk@13639
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 15:43:56 +0000 (15:43 +0000)]
DM: fix -w/-r problems stemming from PM/UPM conversions.
DM will now read and write a custom image format, which begins first with a
normal PNG, but also includes the bitmap's raw pixels. Most tools (file
browser, Preview, Chrome, Skia image decoder) will read the file as PNG. DM
skips the encoded PNG and reads the raw pixels instead.
This scheme allows perfect pixel comparisons that never go through PM -> UPM or
UPM -> PM conversions, as long as you compare on a machine with the same native
pixel format as the machine which generated the images. Since we've only ever
used this to do same-machine comparisons, that's more than good enough for now.
We could convert as needed to a standardized PM pixel format if we find we want
these files to be portable.
DM -w output now does increase to ~1.3G. If that turns out to be annoyingly
big, I'm sure I can come up with a simple pixelwise RLE instead of writing
uncompressed pixels.
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
185343002
git-svn-id: http://skia.googlecode.com/svn/trunk@13638
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 3 Mar 2014 14:58:09 +0000 (14:58 +0000)]
Fix CTM scaling and clipping of SkRectShaderImageFilter.
Pass the CTM as part of the local matrix passed by
SkRectShaderImageFilter. Teach SkPerlinNoiseShader to respect the local
matrix. Embiggen imagefiltersscaled GM size to accommodate the new test
cases.
Note: will require rebaselines of imagefiltersscaled and imagefiltersclipped
R=sugoi@chromium.org
BUG=skia:
Review URL: https://codereview.chromium.org/
184973007
git-svn-id: http://skia.googlecode.com/svn/trunk@13637
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 3 Mar 2014 14:30:25 +0000 (14:30 +0000)]
New approach for GPU font atlas
In the previous code, each GrTextStrike had exclusive access to one or more GrPlots in the texture atlas. This led to poor packing when only a few glyphs were used. This change allows GrTextStrikes to share GrPlots, thereby getting much better utilization of the entire texture.
BUG=skia:2224
R=robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
177463003
git-svn-id: http://skia.googlecode.com/svn/trunk@13636
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 1 Mar 2014 20:12:26 +0000 (20:12 +0000)]
Adding code to calculate Underline Thickness from Font Metrics, this will be useful when Skia is used with Blink/Chrome. Blink changes are uploaded with code change in patch https://codereview.chromium.org/
147703002/
BUG=skia:
R=reed@android.com, edisonn@google.com, reed@google.com, mtklein@google.com, mtklein@chromium.org, bungeman@google.com
Author: h.joshi@samsung.com
Review URL: https://codereview.chromium.org/
152073003
git-svn-id: http://skia.googlecode.com/svn/trunk@13635
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 1 Mar 2014 03:02:09 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13634
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 28 Feb 2014 22:21:29 +0000 (22:21 +0000)]
Rebaseline convexclip2_aa gpu on win7
Review URL: https://codereview.chromium.org/
184993004
git-svn-id: http://skia.googlecode.com/svn/trunk@13633
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 20:31:31 +0000 (20:31 +0000)]
DM: make GPU tasks multithreaded again. Big refactor.
The main meat of things is in SkThreadPool. We can now give SkThreadPool a
type for each thread to create and destroy on its local stack. It's TLS
without going through SkTLS.
I've split the DM tasks into CpuTasks that run on threads with no TLS, and
GpuTasks that run on threads with a thread local GrContextFactory.
The old CpuTask and GpuTask have been renamed to CpuGMTask and GpuGMTask.
Upshot: default run of out/Debug/dm goes from ~45 seconds to ~20 seconds.
BUG=skia:
R=bsalomon@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
179233005
git-svn-id: http://skia.googlecode.com/svn/trunk@13632
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 20:28:59 +0000 (20:28 +0000)]
DM: don't crash on Mac.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
177053005
git-svn-id: http://skia.googlecode.com/svn/trunk@13631
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 20:28:50 +0000 (20:28 +0000)]
Cleanup GrGLInterface after Chromium changes
Depends on landing https://codereview.chromium.org/
143263014
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
149533002
git-svn-id: http://skia.googlecode.com/svn/trunk@13630
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Feb 2014 20:02:20 +0000 (20:02 +0000)]
Image rebaselines for r13627 (add new onClip* methods to SkCanvas)
https://codereview.chromium.org/
179123006/
git-svn-id: http://skia.googlecode.com/svn/trunk@13629
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 19:25:11 +0000 (19:25 +0000)]
Adding flag to switch bench_record into tilegrid mode
BUG=skia:
R=tomhudson@google.com, mtklein@google.com, skyostil@google.com, skyostil@chromium.org
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
184543003
git-svn-id: http://skia.googlecode.com/svn/trunk@13628
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Feb 2014 18:19:39 +0000 (18:19 +0000)]
add new onClip* methods to SkCanvas
https://codereview.chromium.org/
183453002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13627
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 17:24:32 +0000 (17:24 +0000)]
Updates to the Android.mk writer.
Keeping up with changes made to the Android.mk file that is
currently checked in.
R=djsollen@google.com, epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
183953002
git-svn-id: http://skia.googlecode.com/svn/trunk@13626
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 28 Feb 2014 16:30:45 +0000 (16:30 +0000)]
remove SK_SUPPORT_DEEPCOPYTO_CONFIG
git-svn-id: http://skia.googlecode.com/svn/trunk@13625
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 16:07:39 +0000 (16:07 +0000)]
Updates to gyp files for building Android.mk
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
180873012
git-svn-id: http://skia.googlecode.com/svn/trunk@13624
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 28 Feb 2014 15:38:22 +0000 (15:38 +0000)]
remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed
BUG=skia:
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
180483004
git-svn-id: http://skia.googlecode.com/svn/trunk@13623
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Feb 2014 15:28:02 +0000 (15:28 +0000)]
Revert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium.org/
183453002/) due to broken Chrome Canary and failing tests.
git-svn-id: http://skia.googlecode.com/svn/trunk@13622
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Feb 2014 14:43:26 +0000 (14:43 +0000)]
Make GrConvexPolyEffect support inverse fills and non-AA rects
BUG=skia:2151
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
183833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13621
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 28 Feb 2014 14:35:45 +0000 (14:35 +0000)]
add new onClip* methods to SkCanvas
https://codereview.chromium.org/
183453002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13620
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 28 Feb 2014 03:02:05 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13619
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 20:40:31 +0000 (20:40 +0000)]
Modify how gpu.gyp includes angle.gyp.
Instead of including dependencies on angle.gyp and then removing
them if skia_angle is not true, only include angle.gyp to begin
with skia_angle is true.
This allows gyp_to_android.py to work when run in the Android tree,
where we don't have third_party/externals (since we do only a git
merge, and no gclient sync.
R=djsollen@google.com, robertphillips@google.com, bsalomon@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
178223015
git-svn-id: http://skia.googlecode.com/svn/trunk@13618
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 20:32:51 +0000 (20:32 +0000)]
add SkCanvas::NewRaster factory -- a very common use-case in chrome
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
183533004
git-svn-id: http://skia.googlecode.com/svn/trunk@13617
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 20:23:22 +0000 (20:23 +0000)]
Add GrSet class built on top of RedBlackTree
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
176903003
git-svn-id: http://skia.googlecode.com/svn/trunk@13616
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 20:20:21 +0000 (20:20 +0000)]
Rename Path to Path2D
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
177963005
git-svn-id: http://skia.googlecode.com/svn/trunk@13615
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 18:58:51 +0000 (18:58 +0000)]
Use chromium's gyp if third_party is not available.
This is for building Android.mk inside an Android tree where there
is no third_party directory.
R=djsollen@google.com, epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
177073022
git-svn-id: http://skia.googlecode.com/svn/trunk@13614
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 18:45:26 +0000 (18:45 +0000)]
replace gm_fprintf() calls with SkDebugf()
BUG=skia:1221
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
181933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13613
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 18:13:07 +0000 (18:13 +0000)]
rebaseline_server: fix "Results current as of <timestamp>" banner
(SkipBuildbotRuns)
BUG=skia:2232
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
183523002
git-svn-id: http://skia.googlecode.com/svn/trunk@13612
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 17:40:13 +0000 (17:40 +0000)]
Culling API
*** SKP format breaking change ***
Adding a couple of culling primitives: pushCull(SkRect) & popCull().
These are currently only plumbed for SKP playback quickreject.
At record time, we perform a couple of optimizations to trim down the
number of redundant culls:
* collapse empty pushCull/popCull pairs
* skip pushCull/popCull pairs nested within an identical cull rect
Things still missing/to consider:
* use an inlineable, simplified quickreject (Mike's old prototype)
* debugger visualization for cull boxes
* BBH integration: the initial prototype had some minimal BBH support,
but since the optimizations required expensive rewinds and culling
is expected to be a BBH alternative, it got dropped.
R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
138013009
git-svn-id: http://skia.googlecode.com/svn/trunk@13611
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 17:39:46 +0000 (17:39 +0000)]
Use SkTLazy to hold path in SkClipStack::Element
R=reed@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
178583002
git-svn-id: http://skia.googlecode.com/svn/trunk@13610
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 17:39:40 +0000 (17:39 +0000)]
Move SkV8Example to SkSurface
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
148523019
git-svn-id: http://skia.googlecode.com/svn/trunk@13609
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 15:24:06 +0000 (15:24 +0000)]
Whitespace change to verify build fix
R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
180843013
git-svn-id: http://skia.googlecode.com/svn/trunk@13608
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 27 Feb 2014 14:27:44 +0000 (14:27 +0000)]
try to deprecate fFlagsMask from SkLayerDrawLooper
We think we want to move around how flags/fields like linearText and strikeThru
are specified. SkPaint has helpers for nearly all of these, but LayerInfo in
the draw looper just exposes the raw bitfield.
On survey of chrome/android, it appears that no one uses those, so it may be
safe to just remove the feature entirely from the looper.
R=bungeman@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
181433009
git-svn-id: http://skia.googlecode.com/svn/trunk@13607
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 12:29:36 +0000 (12:29 +0000)]
Whitespace change to test CQ
(SkipBuildbotRuns)
TBR=
BUG=skia:
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
183073002
git-svn-id: http://skia.googlecode.com/svn/trunk@13606
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Feb 2014 11:47:36 +0000 (11:47 +0000)]
Factory methods for heap-allocated SkAnnotation objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkAnnotation non-public and instead
provides factory methods for creating these objects on the heap.
BUG=skia:2187
R=reed@google.com, mtklein@google.com, scroggo@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
181703003
git-svn-id: http://skia.googlecode.com/svn/trunk@13605
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 27 Feb 2014 03:02:34 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13604
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 23:01:57 +0000 (23:01 +0000)]
DM: also run benches once.
Also:
- make GrMemoryPoolBenches threadsafe
- some tweaks to various DM code
- rename GM::shortName() to getName() to match benches and tests
On my desktop, (289 GMs, 617 benches) x 4 configs, 227 tests takes 46s in Debug, 14s in Release. (Still minutes faster than running tests && bench && gm.) GPU singlethreading is definitely the limiting factor again; going to reexamine whether that's helpful to thread it again.
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
178473006
git-svn-id: http://skia.googlecode.com/svn/trunk@13603
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 21:40:07 +0000 (21:40 +0000)]
BlendTest: implicit casts -> explicit casts
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13595
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
181503003
git-svn-id: http://skia.googlecode.com/svn/trunk@13602
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 21:38:47 +0000 (21:38 +0000)]
Add point count to lua SkPath.
Add some scripts for classifying rrects and counting complex clip combinations.
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
181843004
git-svn-id: http://skia.googlecode.com/svn/trunk@13601
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 21:35:17 +0000 (21:35 +0000)]
Upstream changes from Android
R=scroggo@google.com, reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
176963003
git-svn-id: http://skia.googlecode.com/svn/trunk@13600
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 26 Feb 2014 20:22:32 +0000 (20:22 +0000)]
Revert "Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/
180283004/)"
This reverts commit
efded03a38d6147caaf2d951638d27fdd47eed64.
Fixes builds
Review URL: https://codereview.chromium.org/
181903002
git-svn-id: http://skia.googlecode.com/svn/trunk@13599
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 19:05:20 +0000 (19:05 +0000)]
rebaseline_server: use new intermediate JSON format as described in https://goto.google.com/ChangingRbsJson
There are still some places in the frontend (HTML+Javascript) code where
we assume we are handling expectations vs actuals, but there are just a few
and we should be able to remove them easily in a coming CL.
At that point, the frontend will work just as well for displaying any set
of image pairs.
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
178253010
git-svn-id: http://skia.googlecode.com/svn/trunk@13598
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 18:32:44 +0000 (18:32 +0000)]
Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/
180283004/)
Reason for revert:
breaking a bunch of builds
Original issue's description:
> Add getReducedClipStack to lua canvas
>
> Committed: http://code.google.com/p/skia/source/detail?r=13594
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
181653004
git-svn-id: http://skia.googlecode.com/svn/trunk@13597
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 26 Feb 2014 18:12:11 +0000 (18:12 +0000)]
Fix SampleApp build
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
181833002
git-svn-id: http://skia.googlecode.com/svn/trunk@13596
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Feb 2014 17:51:00 +0000 (17:51 +0000)]
BlendTest: implicit casts -> explicit casts
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
181503003
git-svn-id: http://skia.googlecode.com/svn/trunk@13595
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log