Behdad Esfahbod [Fri, 5 Apr 2013 21:58:25 +0000 (17:58 -0400)]
[git.mk] Ignore ar-lib
Behdad Esfahbod [Fri, 5 Apr 2013 16:38:58 +0000 (12:38 -0400)]
Add note re Hangul shaping
Behdad Esfahbod [Fri, 5 Apr 2013 03:06:54 +0000 (23:06 -0400)]
Don't compose Hangul jamo
See thread "an issue regarding discrepancy between Korean and Unicode
standards" on the mailing list for the rationale. In short: Uniscribe
doesn't, so fonts are designed to work without it.
Behdad Esfahbod [Thu, 4 Apr 2013 19:02:03 +0000 (15:02 -0400)]
Put back MemoryBarrier fallback implementation on MINGW32
This almost reverts
2761e8a632c14353f286708898be8df6ebad7407,
but only if under MINGW32, so it doesn't affect MSVC.
Behdad Esfahbod [Thu, 4 Apr 2013 18:25:36 +0000 (14:25 -0400)]
[Arabic] Zero marks by GDEF, not Unicode category
Testing shows that this is closer to what Uniscribe does.
Reported by Khaled Hosny:
"""
commit
568000274c8edb5f41bc4f876ce21fcc8bdaeed8
...
This commit is causing a regression with Amiri, the string “هَٰذ” with
Uniscribe and HarfBuzz before this commit, gives:
[uni0630.fina=3+965|uni0670.medi=0+600|uni064E=0@-256,0+0|uni0647.init=0+926]
But now it gives:
[uni0630.fina=3+965|uni0670.medi=0+0|uni064E=0@-256,0+0|uni0647.init=0+926]
i.e. uni0670.medi is zeroed though it has a base glyph GDEF class.
"""
The test case is U+0647,U+064E,U+0670,U+0630 with Amiri.
Behdad Esfahbod [Thu, 4 Apr 2013 16:06:46 +0000 (12:06 -0400)]
Bug 63107 - FTBFS on ppc64: symbols marked with 'D' on powerpc64 instead
Behdad Esfahbod [Tue, 2 Apr 2013 18:08:53 +0000 (14:08 -0400)]
[graphite2] Don't crash if language is not set
https://bugs.webkit.org/show_bug.cgi?id=113796
Behdad Esfahbod [Fri, 22 Mar 2013 01:02:16 +0000 (21:02 -0400)]
Minor
Behdad Esfahbod [Thu, 21 Mar 2013 20:26:39 +0000 (16:26 -0400)]
Remove gthread leftovers
We don't use gthread anymore, remove leftovers.
Behdad Esfahbod [Thu, 21 Mar 2013 20:25:20 +0000 (16:25 -0400)]
Minor
Behdad Esfahbod [Thu, 21 Mar 2013 17:38:06 +0000 (13:38 -0400)]
0.9.14
Behdad Esfahbod [Tue, 19 Mar 2013 10:59:40 +0000 (06:59 -0400)]
Remove Hangul filler characters from Default_Ignorable chars
See discussion on mailing list.
Behdad Esfahbod [Tue, 19 Mar 2013 09:53:26 +0000 (05:53 -0400)]
[Indic] Futher adjust ZWJ handling in Indic-like shapers
After the Ngapi hackfest work, we were assuming that fonts
won't use presentation features to choose specific forms
(eg. conjuncts). As such, we were using auto-joiner behavior
for such features. It proved to be troublesome as many fonts
used presentation forms ('pres') for example to form conjuncts,
which need to be disabled when a ZWJ is inserted.
Two examples:
U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf
U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf
What we do now is to never do magic to ZWJ during GSUB's main input
match for Indic-style shapers. Note that backtrack/lookahead are still
matched liberally, as is GPOS. This seems to be an acceptable
compromise.
As to the bug that initially started this work, that one needs to
be fixed differently:
Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not
provide same results as Windows8
https://bugs.freedesktop.org/show_bug.cgi?id=58714
New numbers:
BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%)
DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod [Tue, 19 Mar 2013 09:22:27 +0000 (05:22 -0400)]
Allow disabling ICU by using a fake icu-config script
Behdad Esfahbod [Tue, 12 Mar 2013 00:18:49 +0000 (20:18 -0400)]
[travis] Install libicu
Behdad Esfahbod [Mon, 11 Mar 2013 23:53:44 +0000 (19:53 -0400)]
Add build system fallback to icu-config
Ubuntu doesn't (or didn't until recently?) ship icu pkg-config
files. That's quite unfortunate. Work around it.
Bug 57608 - ICU Detection fallback for non-pkgconfig systems
Behdad Esfahbod [Sun, 10 Mar 2013 01:30:22 +0000 (20:30 -0500)]
[ft] Remove TODO items that I'm not going to fix
Behdad Esfahbod [Sun, 10 Mar 2013 01:27:55 +0000 (20:27 -0500)]
[ft] Remove TODO item re FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH
That flag is redundant, deprecated, and ignored since April 2011.
From FreeType git log:
commit
8c82ec5b17d0cfc9b0876a2d848acc207a62a25a
Author: Behdad Esfahbod <behdad@behdad.org>
Date: Thu Apr 21 08:21:37 2011 +0200
Always ignore global advance.
This makes FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH redundant,
deprecated, and ignored. The new behavior is what every major user
of FreeType has been requesting. Global advance is broken in many
CJK fonts. Just ignoring it by default makes most sense.
* src/truetype/ttdriver.c (tt_get_advances),
src/truetype/ttgload.c (TT_Get_HMetrics, TT_Get_VMetrics,
tt_get_metrics, compute_glyph_metrics, TT_Load_Glyph),
src/truetype/ttgload.h: Implement it.
* docs/CHANGES: Updated.
Behdad Esfahbod [Sat, 9 Mar 2013 09:34:21 +0000 (04:34 -0500)]
Add hb_auto_array_t
Behdad Esfahbod [Sat, 9 Mar 2013 06:59:30 +0000 (01:59 -0500)]
[OTLayout] Move code around
Behdad Esfahbod [Sat, 9 Mar 2013 06:55:04 +0000 (01:55 -0500)]
[OTLayout] Rename process() to dispatch()
Behdad Esfahbod [Fri, 8 Mar 2013 01:51:30 +0000 (20:51 -0500)]
[win32] Remove MemoryBarrier() fallback implementation
I added these because the older mingw32 toolchain didn't have
MemoryBarrier(). The newer mingw-w64 toolchain however has.
As reported by John Emmas this was causing build failure with
MSVC (on glib) because of inline issues. But that reminded me
that we may be taking this path even if the system implements
MemoryBarrier as a function, which is a waste. So, just remove
it.
Behdad Esfahbod [Thu, 7 Mar 2013 01:21:11 +0000 (20:21 -0500)]
[build] Port to newer automake recommended syntax
Behdad Esfahbod [Thu, 7 Mar 2013 01:20:45 +0000 (20:20 -0500)]
Move valgrind suppressions to the correct directory
Behdad Esfahbod [Thu, 7 Mar 2013 01:05:34 +0000 (20:05 -0500)]
[build] Add AM_PROG_AR
Newer automake / libtools warns otherwise.
Behdad Esfahbod [Thu, 7 Mar 2013 00:37:31 +0000 (19:37 -0500)]
[FT] Just return if glyph name not found
The fallback happens in higher level already. No need to do here.
Behdad Esfahbod [Wed, 6 Mar 2013 05:53:24 +0000 (00:53 -0500)]
[Indic] Minor
Behdad Esfahbod [Wed, 6 Mar 2013 01:08:59 +0000 (20:08 -0500)]
[Indic] Work around fonts with broken new-spec tables
See comments, and this thread:
http://lists.freedesktop.org/archives/harfbuzz/2013-March/002990.html
Originally reported here:
https://code.google.com/p/chromium/issues/detail?id=96143
Doesn't change test suite numbers.
Behdad Esfahbod [Tue, 5 Mar 2013 22:23:33 +0000 (17:23 -0500)]
[travis] Oops. Run make check, not make test!
Behdad Esfahbod [Tue, 5 Mar 2013 07:35:31 +0000 (02:35 -0500)]
Run autogen.sh, not configure, in travis-ci
Behdad Esfahbod [Tue, 5 Mar 2013 06:37:44 +0000 (01:37 -0500)]
Add .travis.yml for continuous building with travis-ci.org
Notifications sent to IRC channel and mailing list.
Behdad Esfahbod [Tue, 5 Mar 2013 02:29:38 +0000 (21:29 -0500)]
Fix distcheck
Behdad Esfahbod [Tue, 5 Mar 2013 01:56:15 +0000 (20:56 -0500)]
[git.mk] Update to commit
efc928222179576270c5910416d8055dd7a97896
Move reusable list of files into variable definitions modules can
reuse
Behdad Esfahbod [Mon, 4 Mar 2013 23:52:12 +0000 (18:52 -0500)]
Add libtool m4 macros to MAINTAINERCLEANFILES
Behdad Esfahbod [Thu, 28 Feb 2013 01:40:54 +0000 (20:40 -0500)]
[Indic] Help compiler put indic_features table in .rodata
The overridden "or" operator was preventing the flag expression from
being const, and putting the table in .data instead or .rodata.
Behdad Esfahbod [Wed, 27 Feb 2013 23:47:26 +0000 (18:47 -0500)]
[buffer] Better parse glyph names
Behdad Esfahbod [Wed, 27 Feb 2013 23:39:37 +0000 (18:39 -0500)]
[buffer] Implement buffer deserialization for format=json
Using a ragel machine.
Behdad Esfahbod [Wed, 27 Feb 2013 22:59:28 +0000 (17:59 -0500)]
[buffer] Implement buffer deserialization for format=text
Using a ragel machine.
Behdad Esfahbod [Wed, 27 Feb 2013 21:09:55 +0000 (16:09 -0500)]
[buffer] Fix serializing of buffer with invalid direction
Behdad Esfahbod [Wed, 27 Feb 2013 18:01:02 +0000 (13:01 -0500)]
[buffer] Start implementing buffer deserialization
Behdad Esfahbod [Wed, 27 Feb 2013 17:02:42 +0000 (12:02 -0500)]
[buffer] Minor
Behdad Esfahbod [Wed, 27 Feb 2013 16:06:36 +0000 (11:06 -0500)]
[buffer] Move buffer serialization code to a new file
Behdad Esfahbod [Wed, 27 Feb 2013 22:48:31 +0000 (17:48 -0500)]
Minor
Behdad Esfahbod [Wed, 27 Feb 2013 02:22:37 +0000 (21:22 -0500)]
[Indic] Sort pre-base reordering consonants with post-forms
Before, we were marking them as below-form for initial reordering.
However, there is a rule that says "post consonants should follow
below consonsnts" for base determination purposes. Malayalam has
port-form YA/VA, and RA is pre-base. As such, for a sequence like
YA,Virama,YA,Virama,RA, the correct base is at index 0. But
because the code was seeing RA as a below-base, it was stopping at
the second YA as base, instead of jumping it as a post-base.
By treating prebase-reordering consonants like post-forms, this
is fixed.
MALAYALAM went down from 351 to 265. Other numbers didn't change:
BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%)
DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1048069 out of 1048334 tests passed. 265 failed (0.0252782%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod [Wed, 27 Feb 2013 00:35:50 +0000 (19:35 -0500)]
[tests] Add Malayalam tests frim cibu
Behdad Esfahbod [Tue, 26 Feb 2013 20:01:45 +0000 (15:01 -0500)]
Update Android.mk
Behdad Esfahbod [Tue, 26 Feb 2013 04:57:51 +0000 (23:57 -0500)]
Fix "comparison between signed and unsigned" warnings
Patch from Jonathan Kew.
Behdad Esfahbod [Tue, 26 Feb 2013 00:09:57 +0000 (19:09 -0500)]
Give up sanitizing after 100 edit requests
Such fonts are *definitely* really broken. Give up.
Limits time spent in sanitize for extremely / deliberately broken
fonts. For example, two fonts with these md5sum / names:
9343f0a1b8c84b8123e7d201cae62ffd.ttf
eb8c978547f09d368fc204194fb34688.ttf
were spending over a second in sanitize! Not anymore.
Behdad Esfahbod [Tue, 26 Feb 2013 00:04:56 +0000 (19:04 -0500)]
Add HB_DEBUG_VERBOSE
Only affects the verbosity of function name printing right now.
Behdad Esfahbod [Mon, 25 Feb 2013 23:19:20 +0000 (18:19 -0500)]
0.9.13
Behdad Esfahbod [Mon, 25 Feb 2013 22:54:10 +0000 (17:54 -0500)]
Behdad Esfahbod [Mon, 25 Feb 2013 22:06:35 +0000 (17:06 -0500)]
Always create sub-blobs in MEMORY_MODE_READONLY
This fixes a design bug with sanitize and sub-blobs that can
cause crashes. Jonathan and I found and debugged this issue
when we tested a corrupt font with the md5sum / filename:
ea395483d37af0cb933f40689ff7b60a. Two hours of intense
debugging we found out that the font has overlapping GSUB/GPOS
tables, and as such, sanitizing the second table can modify
the first one, which can cause all kinds of undefined behavior.
The correct way to fix this is to make sure sub-blobs are
always created readonly, since we consider the parent blob
to be a shared resource and can't modify it, even if it *is*
writable.
This essentially makes the READONLY_MAY_MAKE_WRITABLE mode
unused... Maybe we should simply remove / deprecate it.
Behdad Esfahbod [Thu, 21 Feb 2013 20:54:05 +0000 (15:54 -0500)]
Minor
Behdad Esfahbod [Thu, 21 Feb 2013 20:39:57 +0000 (15:39 -0500)]
Port TrueType-kerning to use skippy iterator
It skips joiners and default ignorables now. Skips marks too, but only
if there is proper GDEF classes for marks.
Behdad Esfahbod [Thu, 21 Feb 2013 20:37:51 +0000 (15:37 -0500)]
Fixup previous commit
Was not decreasing num_items. Ouch!
Behdad Esfahbod [Thu, 21 Feb 2013 20:23:39 +0000 (15:23 -0500)]
Move code around
Behdad Esfahbod [Thu, 21 Feb 2013 20:07:03 +0000 (15:07 -0500)]
[OTLayout] Correctly skip Default_Ignorable when match_func not set
When a match_func was not set on the matcher_t object (ie. from GPOS),
then the Default_Ignorables (including joiners) were never skipped.
This meant that they were not skipped as they should during GPOS
matching. Fix that.
A few Indic numbers have "regressed": BENGALI and DEVANAGARI went
up from 290 and 58 respectively, but in both cases new results are
superior to Uniscribe, as they apply GPOS when we weren't (and
Uniscribe isn't) before.
BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%)
DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod [Thu, 21 Feb 2013 19:51:40 +0000 (14:51 -0500)]
Minor
Behdad Esfahbod [Tue, 19 Feb 2013 05:58:10 +0000 (00:58 -0500)]
[tests] Add Myanmar torture tests from Martin Hosken
Behdad Esfahbod [Tue, 19 Feb 2013 05:50:46 +0000 (00:50 -0500)]
Minor
Moving files around
Behdad Esfahbod [Sun, 17 Feb 2013 17:12:37 +0000 (12:12 -0500)]
[SEA] Fix order of pre-base reordering Ra and left matras
The code was confused because it was expecting left matra to have
POS_PRE_M, like we do in the Myanmar shaper, but that is not what
we were doing in this shaper. Rewrite to rely on category only.
Test case: U+AA06,U+AA34,U+AA2F
Behdad Esfahbod [Fri, 15 Feb 2013 16:47:24 +0000 (11:47 -0500)]
Minor
Behdad Esfahbod [Fri, 15 Feb 2013 16:47:09 +0000 (11:47 -0500)]
[OTLayout] Remove unused code
Behdad Esfahbod [Fri, 15 Feb 2013 14:33:10 +0000 (09:33 -0500)]
Remove TODO items that don't make sense
The spec says those features need to be disabled by default.
Behdad Esfahbod [Fri, 15 Feb 2013 14:27:02 +0000 (09:27 -0500)]
[Arabic] Fix shaping of left-joining 'Phags-Pa U+A872
This is the first character in Unicode to have Arabic left-joining
behavior. Update the machine to recognize that.
Test case: U+A840,U+A872,U+A840.
Behdad Esfahbod [Fri, 15 Feb 2013 14:26:41 +0000 (09:26 -0500)]
[tests] Add Syriac Alaph shaping test cases
Behdad Esfahbod [Fri, 15 Feb 2013 12:51:47 +0000 (07:51 -0500)]
Disable automatic segment properties guessing
Before, if one called hb_shape() without setting script, language, and
direction on the buffer, hb_shape() was calling
hb_buffer_guess_segment_properties() on the user's behalf to guess
these.
This is very dangerous, since any serious user of HarfBuzz must set
these properly (specially important is direction). So now, we don't
guess properties by default. People not setting direction will get
an abort() now. If the old behavior is desired (fragile, good for
simple testing only), users can call
hb_buffer_guess_segment_properties() on the buffer just before calling
hb_shape().
Behdad Esfahbod [Fri, 15 Feb 2013 12:46:57 +0000 (07:46 -0500)]
Add assertions for a couple programmer errors
Behdad Esfahbod [Fri, 15 Feb 2013 12:41:07 +0000 (07:41 -0500)]
Allow disabling of TrueType kerning
Responds to the same feature tag that GPOS kerning does:
'kern' for horizontal and 'vkrn' for vertical.
Behdad Esfahbod [Fri, 15 Feb 2013 12:40:10 +0000 (07:40 -0500)]
Fix partial disabling of default-on features
Surprisingly, if user ever tried to turn a default feature off partially
(say, disable liga for a range), the feature was being turned off
globally! Fixed now.
Behdad Esfahbod [Fri, 15 Feb 2013 12:02:08 +0000 (07:02 -0500)]
[OTLayout] Respect syllable boundaries for backtrack/lookahead matching
Originally we meant to match backtrack/lookahead across syllable
boundaries. But a bug in the code meant that this was NOT done for
backtrack. We "fixed" that in
2c7d0b6b80d412de3fddd443ed1a485ea1cbb03c,
but that broke Myanmar shaping.
We now believe that for Indic-like shapers (which is where syllables are
used), all basic shaping forms should be fully contained within their
syllables, so now we limit backtrack/lookahead matching to the syllable
too. Unbreaks Myanmar.
Behdad Esfahbod [Fri, 15 Feb 2013 11:22:26 +0000 (06:22 -0500)]
Minor refactoring
Behdad Esfahbod [Thu, 14 Feb 2013 15:40:12 +0000 (10:40 -0500)]
[Indic-like] Disable automatic joiner handling for basic shaping features
Not for Arabic, but for Indic-like scripts. ZWJ/ZWNJ have special
meanings in those scripts, so let font lookups take full control.
This undoes the regression caused by automatic-joiners handling
introduced two commits ago.
We only disable automatic joiner handling for the "basic shaping
features" of Indic, Myanmar, and SEAsian shapers. The "presentation
forms" and other features are still applied with automatic-joiner
handling.
This change also changes the test suite failure statistics, such that
a few scripts show more "failures". The most affected is Kannada.
However, upon inspection, we believe that in most, if not all, of the
new failures, we are producing results superior to Uniscribe. Hard to
count those!
Here's an example of what is fixed by the recent joiner-handling
changes:
https://bugs.freedesktop.org/show_bug.cgi?id=58714
New numbers, for future reference:
BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%)
DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.
00819911%)
GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.
00185457%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
Behdad Esfahbod [Thu, 14 Feb 2013 15:46:52 +0000 (10:46 -0500)]
[OTLayout] Add fine-grained control over ZWJ matching
Not used yet. Next commit...
Behdad Esfahbod [Thu, 14 Feb 2013 12:43:13 +0000 (07:43 -0500)]
[OTLayout] Ignore default-ignorables when matching GSUB/GPOS
When matching lookups, be smart about default-ignorable characters.
In particular:
Do nothing specific about ZWNJ, but for the other default-ignorables:
If the lookup in question uses the ignorable character in a sequence,
then match it as we used to do. However, if the sequence match will
fail because the default-ignorable blocked it, try skipping the
ignorable character and continue.
The most immediate thing it means is that if Lam-Alef forms a ligature,
then Lam-ZWJ-Alef will do to. Finally!
One exception: when matching for GPOS, or for backtrack/lookahead of
GSUB, we ignore ZWNJ too. That's the right thing to do.
It certainly is possible to build fonts that this feature will result
in undesirable glyphs, but it's hard to think of a real-world case
that that would happen.
This *does* break Indic shaping right now, since Indic Unicode has
specific rules for what ZWJ/ZWNJ mean, and skipping ZWJ is breaking
those rules. That will be fixed in upcoming commits.
Behdad Esfahbod [Thu, 14 Feb 2013 16:25:10 +0000 (11:25 -0500)]
Add hb_ot_map_feature_flags_t
Code cleanup. No (intended) functional change.
Behdad Esfahbod [Thu, 14 Feb 2013 16:05:56 +0000 (11:05 -0500)]
Clean-up add_bool_feature
Behdad Esfahbod [Thu, 14 Feb 2013 16:05:36 +0000 (11:05 -0500)]
Fix compile warnings for ragel-generated machines
Behdad Esfahbod [Thu, 14 Feb 2013 12:42:42 +0000 (07:42 -0500)]
[OTLayout] Remove unused function
Behdad Esfahbod [Thu, 14 Feb 2013 12:41:03 +0000 (07:41 -0500)]
[OTLayout] Port apply_lookup to skippy_iter
Behdad Esfahbod [Thu, 14 Feb 2013 12:20:52 +0000 (07:20 -0500)]
[OTLayout] Port ligate_input to skippy_iter
Behdad Esfahbod [Thu, 14 Feb 2013 11:24:30 +0000 (06:24 -0500)]
[OTLayout] Minor fix for apply_lookup()
Should NOT change behavior, since first glyph is a match.
Behdad Esfahbod [Wed, 13 Feb 2013 17:17:25 +0000 (12:17 -0500)]
[OTLayout] Make table type known to apply context
Behdad Esfahbod [Wed, 13 Feb 2013 17:10:08 +0000 (12:10 -0500)]
[OTLayou] Unbreak backtrack matching
Was introduced by
28b9d502bb69a8045818d5f6113ded9c59a56bd7.
Behdad Esfahbod [Wed, 13 Feb 2013 16:22:42 +0000 (11:22 -0500)]
[OTLayout] Minor refactoring
Behdad Esfahbod [Wed, 13 Feb 2013 16:13:06 +0000 (11:13 -0500)]
[OTLayout] Remove bogus caching of glyph property
Behdad Esfahbod [Wed, 13 Feb 2013 16:02:54 +0000 (11:02 -0500)]
Remember ZWNJ
To be used in upcoming changes.
Behdad Esfahbod [Wed, 13 Feb 2013 14:38:40 +0000 (09:38 -0500)]
Indent
Behdad Esfahbod [Wed, 13 Feb 2013 14:26:55 +0000 (09:26 -0500)]
[Indic] Improve base finding in final_reordering
Fixes 5 Malayalam failures!
MALAYALAM: 1048016 out of 1048334 tests passed. 318 failed (0.0303338%)
Behdad Esfahbod [Wed, 13 Feb 2013 13:29:21 +0000 (08:29 -0500)]
Add more dot-reph tests
Behdad Esfahbod [Wed, 13 Feb 2013 12:32:46 +0000 (07:32 -0500)]
[Indic] Track base position when reordering things
Ouch, how did things ever work without this?! The added test that has a
dot-reph as well as a pre-base reordering Ra perfectly demonstrates the
bug (tested with Nirmala font from Win8 for example). Testing suggests
that Win8 shaper has the *exact* same bug / behavior that we used to
have. Odd.
Behdad Esfahbod [Wed, 13 Feb 2013 10:59:06 +0000 (05:59 -0500)]
[SEA] Don't zero any mark advances
Keep the logic simple, easier to explain to font developers.
Behdad Esfahbod [Wed, 13 Feb 2013 10:57:24 +0000 (05:57 -0500)]
Further adjust mark advance zeroing
This is a followup to
568000274c8edb5f41bc4f876ce21fcc8bdaeed8.
Looks like in the Latin shaper, Uniscribe zeroes all Unicode NSM
advances *after* GPOS, not before. Match that.
Can be tested using DejaVu Sans Mono, since that font has GPOS
rules to zero the mark advances on its own.
Behdad Esfahbod [Tue, 12 Feb 2013 23:17:39 +0000 (18:17 -0500)]
[Indic] Fix Eyelash Ra with old Devanagari spec
Behdad Esfahbod [Tue, 12 Feb 2013 23:17:12 +0000 (18:17 -0500)]
[tests] Add tests for Devanagary Eyelash Ra
Currently broken with Sanskrit 2003 font.
Behdad Esfahbod [Tue, 12 Feb 2013 22:57:49 +0000 (17:57 -0500)]
[Indic] Apply 'blwf' before 'half'
This reverts
167b625d988b74572d6b2f646c285b666b650d49. It didn't
matter before, but that's going to change with next commit.
Behdad Esfahbod [Tue, 12 Feb 2013 23:01:21 +0000 (18:01 -0500)]
[Indic] Apply 'vatu' before 'cjct'
This essentially reverts
1d6846db9ebf84561bb30a4e48c6c43184914099,
but that commit is from way back when. We should be better
following the spec order now again.
Behdad Esfahbod [Tue, 12 Feb 2013 21:29:25 +0000 (16:29 -0500)]
Didn't mean to push this out
Ouch!
Behdad Esfahbod [Tue, 12 Feb 2013 21:13:56 +0000 (16:13 -0500)]
[Myanmar] Use master Indic table for syllable data
Behdad Esfahbod [Tue, 12 Feb 2013 20:45:59 +0000 (15:45 -0500)]
[tests] Add Cham sample