Mike Blumenkrantz [Wed, 15 Aug 2018 17:03:13 +0000 (13:03 -0400)]
eio/sentry: destroy event handlers when deleting sentry
this will crash due to invalid memory access if an event is triggered after
the sentry is destroyed
Differential Revision: https://phab.enlightenment.org/D6845
Mike Blumenkrantz [Thu, 2 Aug 2018 16:48:46 +0000 (12:48 -0400)]
ci: use manual script for distcheck build
this adds a script which reimplements the distcheck rule generated from
automake and runs that script instad of 'make distcheck'
the benefit of this is that the distcheck script can run tests multiple times
to avoid intermittent failures which could potentially cause build errors.
distcheck builds are by far the longest and most costly of all ci builds, so
it's important to reduce failure rates in these builds to the absolute minimum
in order to keep ci build times low
cibuildme
fix T7094
Differential Revision: https://phab.enlightenment.org/D6734
Mike Blumenkrantz [Wed, 15 Aug 2018 12:38:19 +0000 (08:38 -0400)]
build: remove incorrect use of DEPENDENCIES for non-library file
if this is ever evaluated then it will trigger a build failure since it
is not a rule in this makefile which can ever be run
fix T6828
Differential Revision: https://phab.enlightenment.org/D6838
Mike Blumenkrantz [Wed, 15 Aug 2018 20:16:14 +0000 (16:16 -0400)]
ci: always use same version numbering for every build
if the version number ever changes then this destroys the entire ccache
as the version is used in various places in headers which are included
throughout the tree
Differential Revision: https://phab.enlightenment.org/D6848
Mike Blumenkrantz [Fri, 17 Aug 2018 15:11:08 +0000 (11:11 -0400)]
elm/list: correctly handle ELM_LIST_COMPRESS
according to the docs, this mode means that no content size hints should
be taken into account when calculating size hints for the overall object
fix T7313
Differential Revision: https://phab.enlightenment.org/D6860
Alastair Poole [Fri, 17 Aug 2018 11:37:59 +0000 (11:37 +0000)]
elm_code: fix crash on backspace and selection delete.
FIx backspace issue and also issue involving the cursor
position and deleting/cutting/backspace of selected text.
Now that we properly move the cursor around when making a
selection, it's important that we place the cursor in a
valid position in the widget following the removal of text.
Previously the cursor always remained in a "safe" position
however now it's crucial to update this position when
necessary.
@fix T7259
Differential Revision: https://phab.enlightenment.org/D6835
Hermet Park [Fri, 17 Aug 2018 19:12:19 +0000 (15:12 -0400)]
evas vg: prevent invalid access.
Summary:
Canvas allows objects become zombies.
Even though they were deleted they could be accessed by canvas
for second frames.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6849
Mike Blumenkrantz [Fri, 17 Aug 2018 17:10:50 +0000 (18:10 +0100)]
efl_ui/format: revert some patches to fix some regressions
Summary:
it seems that the original patch in this case introduced a regression
where format strings ending with %% in progressbar would not be
displayed correctly. a followup patch attempted to resolve this, but
this second patch introduced another regression where some format strings
would always display 0%
fixing compiler warnings is always valued, but in the case where the
patch to fix the warning creates regressions then we will live with the
warnings instead
This reverts commit
b4112b9735ce75bce95974a257aa1880fa52a6bf.
This reverts commit
be770d37fb05b8486907796dd16f4635bceb4ce1.
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6863
Derek Foreman [Fri, 17 Aug 2018 16:46:39 +0000 (12:46 -0400)]
efl_wl: Send unique keymap fds to clients
Summary:
Prevent wayland clients from being able to destroy the compositor's
singleton keymap by making individual copies for each client.
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6862
Yeongjong Lee [Fri, 17 Aug 2018 16:42:35 +0000 (12:42 -0400)]
ecore_pipe: remove null check condition and fix segfualt on Windows
Summary:
This reverts commit
4917910b4911905236fa099bbc16b833b056ca07.
4917910b break backward compatibility.
Reproduction:
void pipe_handler(...);
pipe = ecore_pipe_add(pipe_handler, NULL);
ecore_pipe_write(pipe, NULL, 0);
Because of the null check condition, pipe_handler isn't called after
4917910b.
Some apps behavior which is written to expected to call pipe_handler was broken.
also, this patch fixed segfault during build on Windows
Test Plan: make on Windows
Reviewers: raster, zmike, vtorri
Reviewed By: zmike, vtorri
Subscribers: woohyun, cedric, #reviewers, #committers, zmike, vtorri
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6824
Shinwoo Kim [Fri, 17 Aug 2018 16:42:18 +0000 (12:42 -0400)]
eina_file: check copied using copied
Summary:
From (1) "the following commit" message, the changed condition in this patch
should check if the virtualized file is copied or not.
In eina_file_virtualize
head_padded = 16 * ((sizeof(Eina_File) + slen + 15) / 16);
file->global_map = ((char *)file) + head_padded;
In eina_file_dup
file->global_map != (void*)(file->filename + strlen(file->filename) + 1)
Because of this discord condition makes eina_file_dup copies always.
(1) This is "the following commit":
commit
4766316935589b6191e047ad697ab10ae2027a43
Author: Cedric Bail <cedric@osg.samsung.com>
Date: Wed Mar 8 10:13:36 2017 -0800
eina: force copy of not copied virtualized file while doing an eina_file_dup.
The other way around is pretty much impossible as you don't know who does
an eina_file_dup and for how long they keep there reference.
T5234
Reviewers: zmike, Hermet
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6857
Chris Michael [Fri, 17 Aug 2018 15:34:30 +0000 (11:34 -0400)]
Revert this patch. It was not supposed to land yet as it was awaiting
review
Revert "elementary: Check for valid focus manager before starting do loop"
This reverts commit
364ca1d2b2bb057da4d4d02dbeb2cbc2045b0ee3.
Mike Blumenkrantz [Fri, 17 Aug 2018 15:30:36 +0000 (11:30 -0400)]
elm/box_layout: rename variables
Summary:
the mnw and mnh variables were misleading in this context because they actually
refer to the max width and max height
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6859
Chris Michael [Mon, 13 Aug 2018 11:27:55 +0000 (07:27 -0400)]
elementary: Check for valid focus manager before starting do loop
Summary:
Apparently there are cases where efl_ui_focus_object_focus_manager_get
can return NULL. In order to trap for this, we can simply modify the
do loop slightly and check for a valid manager before we actually
start looping
Test Case: elementary_test -to "Panel Scrollable" and click Toggle
button
ref T7030
Depends on D6703
Reviewers: bu5hm4n, YOhoho
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl_widgets_focus
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6704
Hermet Park [Fri, 17 Aug 2018 02:27:56 +0000 (11:27 +0900)]
elementary image: updated doc.
Mike Blumenkrantz [Thu, 16 Aug 2018 19:00:41 +0000 (20:00 +0100)]
elm/code: use evas as parent for evas object creation
Summary:
evas object types require an evas as the parent. this has always been
the case, though it has only begun to (again) be treated as an error
recently
fixes unit test failures
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets_code
Differential Revision: https://phab.enlightenment.org/D6852
Mike Blumenkrantz [Thu, 16 Aug 2018 18:47:32 +0000 (19:47 +0100)]
tests/edje: fix object parenting for swallow tests
Summary:
recent safety check patches exposed issues here where tests were
incorrectly written to pass evas objects as edje object parents,
resulting in new test failures after this began to be detected and
treated as an error
Reviewers: netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6851
Derek Foreman [Thu, 16 Aug 2018 17:39:34 +0000 (12:39 -0500)]
Remove EOLIAN_TESTS_EOS_GENERATED
Summary:
commit
74b56eedd1e0f7c51500bf880b59257ecea0bd0e added these to clean,
but the variable contains some non-generated files.
Turns out these files don't have to be part of the build at all, as
the tests that use them generate them in temp dirs.
Just remove the variable entirely.
Reviewers: bu5hm4n, zmike, q66
Reviewed By: bu5hm4n, zmike, q66
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6850
Derek Foreman [Thu, 16 Aug 2018 14:17:23 +0000 (10:17 -0400)]
ecore_evas: Fix elm warnings when building without wayland support
Summary:
efl_ui_win.c only includes private ecore_evas headers when building
for wayland, but wayland canvas creation functions are called even
in non-wayland builds.
Move the "hidden" wayland APIs to the public header so they don't
mess up non-wayland builds.
Reviewers: devilhorns, zmike
Reviewed By: devilhorns, zmike
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6822
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:43 +0000 (10:16 -0400)]
tests/eio: disable efreet cache for eio tests
Summary:
having this enabled slows down test execution by a significant amount
for some reason
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6836
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:34 +0000 (10:16 -0400)]
edje/multisense: always return muted=true if multisense is disabled
Summary:
there is no sound when multisense is disabled, so this is functionally
equivalent to the audio being muted
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl_layout_engine
Differential Revision: https://phab.enlightenment.org/D6837
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:23 +0000 (10:16 -0400)]
elm/config: return false when setting audio config if multisense is disabled
Summary:
these operations cannot be completed if the support is not built in, so
return false in order to provide the correct state to the caller
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6839
Alastair Poole [Thu, 16 Aug 2018 14:12:35 +0000 (10:12 -0400)]
elm_code_line: fix potential crash.
Summary:
This can occur and thus malloc will return NULL when line->length is
0. Check for !line->length and return. Very difficult to reproduce, but
I had managed three times, and avoided a crash.
Reviewers: #committers, ajwillia.ms, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6842
Yeongjong Lee [Thu, 16 Aug 2018 14:01:47 +0000 (10:01 -0400)]
efl_ui_image: avoid a call to NULL
Summary:
Image object isn't created on constructor anymore. so that it need to check
whether image object exist.
Reviewers: Hermet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6834
Yeongjong Lee [Thu, 16 Aug 2018 14:01:37 +0000 (10:01 -0400)]
elm_image: create image object before call elm_image_object_get
Summary:
image object was created in group_add before
868e3308. if you call
elm_image_object_get before file_set, you can get NULL.
this patch avoid that.
Test Plan:
obj = elm_image_add(...);
img = elm_image_object_get(obj);
img should not be NULL.
Reviewers: Hermet, zmike
Reviewed By: zmike
Subscribers: JackDanielZ, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6828
Mike Blumenkrantz [Wed, 1 Aug 2018 17:37:50 +0000 (13:37 -0400)]
ci: disable notifications for canceled builds
canceled builds indicate that someone is actively watching a build,
likely in order to test changes. there's no point in spamming irc for
these events
Differential Revision: https://phab.enlightenment.org/D6730
Mike Blumenkrantz [Sun, 22 Jul 2018 05:22:06 +0000 (01:22 -0400)]
ci: disable unnecessary build targets
examples and install are both built by distcheck build, no need to also
build them in every other build
there's also no need to try building an app against the compiled libraries
since ci runs unit tests, requiring binaries to run after linking to the
libraries
Differential Revision: https://phab.enlightenment.org/D6663
Yeongjong Lee [Wed, 15 Aug 2018 16:48:44 +0000 (16:48 +0000)]
elm_image: add EINA_UNUSED to avoid build warning
Differential Revision: https://phab.enlightenment.org/D6844
Yeongjong Lee [Wed, 15 Aug 2018 16:44:22 +0000 (16:44 +0000)]
tests/image: remove unused variable
Differential Revision: https://phab.enlightenment.org/D6843
Mike Blumenkrantz [Mon, 6 Aug 2018 21:42:40 +0000 (17:42 -0400)]
tests: add more info on failsafe timeout
if a test is continually deadlocking then it's useful to know which
test is failing to complete
Differential Revision: https://phab.enlightenment.org/D6785
Mike Blumenkrantz [Mon, 30 Jul 2018 16:50:58 +0000 (12:50 -0400)]
tests: add failsafe timeout for tests running in fork mode
some tests manage to deadlock themselves on travis, seemingly due to some
hard to reproduce issues which are a result of the extremely low amount of
resources available on travis builds
this adds a simple 'timeout' process which does nothing but sleep(60);
and then returns. the exiting of this process will cause the main test
process to break out of the deadlock and then exit instead of timing out
a ci build
Differential Revision: https://phab.enlightenment.org/D6697
Youngbok Shin [Mon, 20 Aug 2018 11:21:53 +0000 (07:21 -0400)]
evas textblock: add/apply cursor cluster APIs based on grapheme cluster
Summary:
Add a feature for moving cursor over a grapheme cluster.
It is applied to edje_entry.c and elm_entry.c for improving
cursor handling just like other modern text editors. ex) gedit
The patch on Evas needs to update libunibreak library.
So, the patch will update libunibreak, too.
@feature
Test Plan:
1. Put "ഹലോ" in your entry.
2. Your cursor can reach at the end of text from the beginning
only in 2 right key event with this feature.
Reviewers: raster, cedric, jpeg, herdsman, zmike, devilhorns
Reviewed By: herdsman, zmike
Subscribers: #reviewers, #committers, zmike, bowonryu, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D5490
Change-Id: I6f5a817bd946ae029bf7a081343174847d8c09fb
Bowon Ryu [Tue, 21 Aug 2018 06:31:49 +0000 (15:31 +0900)]
efl_ui_tab_bar: implement select key bindings.
Summary:
by key bindings..
now we can select TAB with the Return/Space key.
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: YOhoho, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6779
Change-Id: I2f967ebf3307b8a935ce1ce3c2112d1d659953ba
Hermet Park [Fri, 17 Aug 2018 15:30:20 +0000 (11:30 -0400)]
ecore wayland: fix a regression bug of wayland_transparent_get().
Summary:
wayland transparent func was replaced with alpha's.
By this, transparent common attribute is no more valid,
ecore_evas_transparent_get() doesn't work.
This is a regression bug by
5af84afced98956198b9c316facb671e46b381c1
Reviewers: ManMower, devilhorns
Reviewed By: ManMower, devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6856
Change-Id: Iba22504fa584f4e5b537f2c3b0e6423e72012648
Yeongjong Lee [Thu, 16 Aug 2018 17:01:26 +0000 (13:01 -0400)]
evas: check evas class instead of using evas_find
Summary:
A object that is not evas class shouldn't use evas_find. it may occurs segfault.
ref
c2e8b492b18bdecc2300ad051ba1406e40ad068f
Test Plan:
Evas *evas = evas_new();
evas_free(evas);
evas_object_line_add(evas);
Check weather there is segfault.
Reviewers: Hermet, raster, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6816
Taehyub Kim [Fri, 17 Aug 2018 04:39:03 +0000 (13:39 +0900)]
elm_entry: Disable primary selection type, it is not supported yet
Change-Id: I0b97f7983a6af81a9eb04c8917fc4e71b7606b56
Bryce Harrington [Wed, 15 Aug 2018 08:54:17 +0000 (09:54 +0100)]
eina: Add doxygen in/out tags for safepointer, safety_checks, slice, etc.
Reviewers: netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6833
Mike Blumenkrantz [Wed, 15 Aug 2018 08:45:06 +0000 (09:45 +0100)]
elm/list: use while() loop to iterate item list during smart delete
Summary:
using EINA_LIST_FREE here double deletes 2 list items on every iteration
due to recursive list removals, which prevents some items from being
deleted as expected
fix T7266
Reviewers: netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7266
Differential Revision: https://phab.enlightenment.org/D6829
Mike Blumenkrantz [Mon, 6 Aug 2018 18:26:08 +0000 (14:26 -0400)]
tests/elm: remove elm_test_helper.(c|h) files
these timer functions are only used by fileselector and I'm trying to consolidate
timer usage
no functional changes
Differential Revision: https://phab.enlightenment.org/D6768
Mike Blumenkrantz [Mon, 6 Aug 2018 18:03:48 +0000 (14:03 -0400)]
tests/naviframe: add test to verify preserve_on_pop functionality
this adds a naviframe with button content and pushes/pops the stack
a couple times to see if a delete callback is called on the button
ref T7236
Differential Revision: https://phab.enlightenment.org/D6762
Mike Blumenkrantz [Tue, 14 Aug 2018 21:26:08 +0000 (17:26 -0400)]
tests/eina: suppress deprecated api warnings for eina abi test
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6810
Marcel Hollerbach [Tue, 14 Aug 2018 21:12:07 +0000 (17:12 -0400)]
evas: support wayland static engine loading
Summary: This fixes static loading of the here changes engines.
Reviewers: ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6795
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:53 +0000 (17:11 -0400)]
elm/win: skip frame updating if csd is not active
Summary:
this avoids extra recalcs and resizes when csd is not active, which has
the side benefit of not breaking the x11 engine's behavior--currently only
an issue because the ecore-evas x11 backend does not have an implementation
of ConfigureNotify event handling which is even remotely correct
these issues will be resolved in future patches
fix T7243
ref T7008
Reviewers: devilhorns, ManMower
Reviewed By: devilhorns, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Maniphest Tasks: T7243, T7008
Differential Revision: https://phab.enlightenment.org/D6794
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:31 +0000 (17:11 -0400)]
ecore-evas/x: rework draw_block unsetting from ConfigureNotify
Summary:
draw_block should only be unset if the event is triggered by the wm
or the window is an override, otherwise it prematurely begins rendering
the window at a size which may or may not be accurate
ref T7008
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Maniphest Tasks: T7008
Differential Revision: https://phab.enlightenment.org/D6793
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:32 +0000 (17:09 -0400)]
ecore/main: only update loop_time during loop iteration if the change is monotonic
Summary:
in the case where the user has called loop_time_set with a value in the future,
avoid setting the loop time to something that would potentially cause a callback
to occur with a loop_time value before a previous occurrence of that callback
@fix
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_main_loop
Differential Revision: https://phab.enlightenment.org/D6764
Marcel Hollerbach [Tue, 14 Aug 2018 21:09:22 +0000 (17:09 -0400)]
eina_vpath: specilice the eina_vpath headers
Summary: For now its beta, and the since tag is added.
Reviewers: zmike
Reviewed By: zmike
Subscribers: #reviewers, kimcinoo, Hermet, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6751
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:11 +0000 (17:09 -0400)]
build: fix evas static build of gl engines
Summary:
when gl_common is built statically, the include directories for it need
to be added to the main evas library build
@fix
Reviewers: devilhorns, vtorri, ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6681
Alastair Poole [Tue, 14 Aug 2018 19:48:27 +0000 (15:48 -0400)]
elm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN
Summary:
As with other checks in ELM return if object is not yet
finalized. This stops lots of console noise.
@fix T7265
Test Plan:
elementary_test: use panel test from console and view the noise
from EINA. Apply then do the same.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, zmike
Tags: #efl
Maniphest Tasks: T7265
Differential Revision: https://phab.enlightenment.org/D6826
Chris Michael [Tue, 14 Aug 2018 14:45:30 +0000 (15:45 +0100)]
elementary: Check for valid cursor_rect when (un)setting focus
Summary:
As the cursor_rect for elm_code_widget is not created until the code
widget gets focus, we cannot just assume it is already there when
trying to emit a focus signal. The cursor_rect does not get created
until widget_cursor_update is called.
This fixes an issue where NULL is passed to efl_layout_signal_emit.
To test this, just launch elementary_test and click the Code Editor
test. As soon as you try to click into the Code Editor, this gets
triggered.
ref T7030
Reviewers: netstar, ajwillia.ms
Reviewed By: netstar
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6701
Mike Blumenkrantz [Tue, 14 Aug 2018 14:45:13 +0000 (10:45 -0400)]
edje: unset internal _need_imf flag on shutdown
Summary:
failing to unset this causes the ecore_imf flag to go negative if edje
is ever completely shut down twice
@fix
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_layout_engine, #easy
Differential Revision: https://phab.enlightenment.org/D6763
Jaehyun Cho [Tue, 14 Aug 2018 14:19:16 +0000 (10:19 -0400)]
theme: add programs for deferred naviframe push/pop signals
Summary:
Naviframe provides deferred push/pop signals to begin transition effect and
not to emit signals frequently for transition callbacks.
To handle the deferred naviframe push/pop signals, programs which catch the
signals are added.
@fix
Test Plan: Test naviframe in elementary_test by pressing next and prev buttons.
Reviewers: zmike, Hermet
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6823
Yeongjong Lee [Thu, 9 Aug 2018 08:36:27 +0000 (08:36 +0000)]
tests/genlist: add focus test
This adds test for simulating focus state.
Differential Revision: https://phab.enlightenment.org/D6800
Marcel Hollerbach [Thu, 9 Aug 2018 08:52:55 +0000 (10:52 +0200)]
efl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL
Otherwise we might end up with focus beeing NULL.
Differential Revision: https://phab.enlightenment.org/D6803
Marcel Hollerbach [Thu, 9 Aug 2018 08:50:44 +0000 (10:50 +0200)]
efl_ui_focus_manager_calc: fix unregistering the root of a redirect
There is often a tree of elements registered in a manager that are
having all the same redirect element. Unserting the redirect property
just because the node has this redirect element is not helpfull as this
would break basically elm_tests button search. However, if it is the
container itself, then the redirect can be unset, as nothing else can
ever reach again the redirect manager.
ref D6800
Differential Revision: https://phab.enlightenment.org/D6802
Marcel Hollerbach [Thu, 9 Aug 2018 08:38:27 +0000 (10:38 +0200)]
efl_ui_focus_manager: adjust pop history pop
It now searches for a element if the focus stack is empty.
Differential Revision: https://phab.enlightenment.org/D6801
Felipe Magno de Almeida [Mon, 13 Aug 2018 15:12:44 +0000 (11:12 -0400)]
efl-cxx: Add -Wno-shadow to disable huge warnings in C++
Summary:
-Wno-shadow warnings disable a improper warning directive for C++, this is made because
it is common for people to use the same CFLAGS as CXXFLAGS, enabling, unadvertadly, the
smae warning for C and C++.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6821
chris [Mon, 13 Aug 2018 14:55:52 +0000 (10:55 -0400)]
Elementary test : add a checkbox to hide beta apis.
Reviewers: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6817
Marcel Hollerbach [Mon, 13 Aug 2018 13:57:47 +0000 (09:57 -0400)]
emotion: make intree running work
Summary:
before it would have only worked if there would have been the
architecture in the path, which was definitly not the case.
This fixes the problems.
Depends on D6795
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6819
Xavi Artigas [Mon, 13 Aug 2018 11:03:39 +0000 (07:03 -0400)]
elm: bring back elm/uiclock
Summary:
It turns out elm/uiclock (which was removed in
89675c3219) is actually used,
at least by the datetime legacy widget. Removing this widget broke the
datetime_example test.
This commit reverts
89675c3219 and fixes the elm/uiclock part names:
- Part names are prefixed with 'elm.'
- efl_ui_clock.c (which is used for both the new efl and the legacy elm widgets)
now looks for part names with 'efl.' and 'elm.' prefixes, and without any
prefix, for compatibility with older themes.
Fixes T6928
Test Plan: the Datetime elementary_test (and all other clock-related tests) now work.
Reviewers: zmike, jsuya, CHAN, devilhorns, Jaehyun_Cho
Reviewed By: zmike, jsuya, CHAN
Subscribers: #reviewers, Jaehyun, Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T6928
Differential Revision: https://phab.enlightenment.org/D6577
Mike Blumenkrantz [Mon, 13 Aug 2018 06:07:31 +0000 (15:07 +0900)]
elm/naviframe: implement invalidate method for naviframe items
Summary:
move most of the _item_free() calls to the invalidate method and unset some
delete callbacks on content items to avoid invalid calls during deletion
calling any of this during the object destructor is invalid because the parent
object can no longer be accessed at this time
fix T7236
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, stefan_schmidt, cedric, #committers
Tags: #efl_widgets
Maniphest Tasks: T7236
Differential Revision: https://phab.enlightenment.org/D6759
Marcel Hollerbach [Sun, 12 Aug 2018 08:21:19 +0000 (10:21 +0200)]
eio: fix poll backend
it seems that this should have been a pop call, not the function
pointer. This key eina_array_pop is never used. Nor would the array get
smaller, so i assume this should be a pop call.
Differential Revision: https://phab.enlightenment.org/D6814
Yeongjong Lee [Fri, 10 Aug 2018 16:49:50 +0000 (12:49 -0400)]
elm_map: add EINA_UNUSED to avoid build warning
Test Plan: make
Reviewers: devilhorns, zmike
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6813
Hermet Park [Fri, 10 Aug 2018 16:06:42 +0000 (12:06 -0400)]
evas gl_common: code refactoring.
Summary: use boolean instead int, no logic changes.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6807
Derek Foreman [Fri, 10 Aug 2018 15:38:25 +0000 (11:38 -0400)]
ee_wayland: Remove spurious manual_render
Summary:
The line prior to this damages the canvas and should result in a render
anyway.
Forcing a manual render here (without regard to the manual_render_set
state) will cause a post render callback to fire for clients that
think they've disabled automatic rendering.
fix T7275
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7275
Differential Revision: https://phab.enlightenment.org/D6809
JunsuChoi [Fri, 10 Aug 2018 02:02:16 +0000 (11:02 +0900)]
elm_image : Remove unnecessary test about image
Summary:
The elm_transit test is in test_transit.c.
Testing for elm_transit in test_image.c is unnecessary
Test Plan: elementary_test -to "image click"
Reviewers: Hermet, #reviewers, eunue
Reviewed By: Hermet, #reviewers
Subscribers: cedric, akanad, bowonryu, #reviewers, YOhoho, #committers, JackDanielZ, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6799
Mike Blumenkrantz [Thu, 9 Aug 2018 19:51:41 +0000 (15:51 -0400)]
ecore-evas: make manual_render_set a no-op when setting the current value
Summary:
this should not take any action if the existing value of manual_render is
set to the passed value
Reviewers: devilhorns, kimcinoo, ManMower
Reviewed By: devilhorns, kimcinoo, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Differential Revision: https://phab.enlightenment.org/D6786
Yeongjong Lee [Thu, 9 Aug 2018 15:19:46 +0000 (11:19 -0400)]
evas: add safety check code to avoid crash
Test Plan: evas_smart_objects_calculate(NULL);
Reviewers: zmike, Hermet, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6805
Stefan Schmidt [Thu, 9 Aug 2018 09:42:35 +0000 (11:42 +0200)]
release: Update NEWS and bump version for 1.21.0-beta2 release
Carsten Haitzler (Rasterman) [Tue, 24 Jul 2018 08:49:50 +0000 (17:49 +0900)]
elm genlist - remove execsivve calls where we could do less eo lookups
something to help T6580 ... but not that much (0.3% fewer eo calls)
Derek Foreman [Wed, 8 Aug 2018 20:58:33 +0000 (16:58 -0400)]
ee_drm: Fix tick job timestamps for funny GPU clocks
Summary:
The animator timestamps were only getting the offset applied when they
came from page flips. The "early tick" logic failed to apply the offset.
This likely only changes behaviour on vmware's graphics stack, and
only the env var ECORE_EVAS_DRM_GPU_CLOCK_WRONG is set.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: bu5hm4n, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6792
Mike Blumenkrantz [Wed, 8 Aug 2018 16:09:55 +0000 (12:09 -0400)]
build: explicitly add eolian generated files to CLEANFILES
these are all being generated now so they must also be cleaned for
distcheck to pass
Differential Revision: https://phab.enlightenment.org/D6782
Derek Foreman [Wed, 8 Aug 2018 18:58:47 +0000 (14:58 -0400)]
ee_wayland: Update configured state on short-circuit ack-configure
Summary:
When we BAIL from the configure callback with an immediate ack we don't
properly update state, commit the ack, or allow ecore_wl2 to process
a deferred ack_configure that happened during async rendering.
Using a commit here instead should update internal state properly.
ref T7243
Depends on D6783
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7243
Differential Revision: https://phab.enlightenment.org/D6784
Derek Foreman [Wed, 8 Aug 2018 18:58:44 +0000 (14:58 -0400)]
Revert "ee_wayland: Remove pointless ack_configure"
Summary:
This reverts commit
a61f254f19df163c860235e6c19e0d65ce9eb0c4.
and a follow up commit that removed some warnings
Apparently this is instrumental in enlightenment's window maximize
animation processing.
The removed bits would force an ack configure when an inbound
configure didn't result in a change that would cause a re-render.
Since this calculation needs knowledge of state ecore_wl2 doesn't
track, it does need to happen here.
ref T7243
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7243
Differential Revision: https://phab.enlightenment.org/D6783
Stephen Houston [Wed, 8 Aug 2018 18:57:00 +0000 (14:57 -0400)]
efl/ui_format: Use STRING type for format strings that contain %%
Summary: This fixes progressbar format strings that contain the pattern %%, thus making it a string and not a format.
Test Plan: elementary_test progressbar shows %% on the first vertical progressbar before this patch. afterwords it shows % correctly.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6790
Mike Blumenkrantz [Wed, 8 Aug 2018 13:45:30 +0000 (09:45 -0400)]
build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Summary:
this needs to be consistent so that it can be used reliably across suites
also these build flags really need to be consolidated into a single variable
that can be reused
Depends on D6666
Reviewers: devilhorns, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6731
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:22 +0000 (09:39 -0400)]
efl_ui_composition: remove all registered children on unregister
Summary:
ensure that all the children are gone once we unregister the widget
itself. This helps widgets that are not cleaning up theire children /
items on invalidation.
ref T7213.
Reviewers: CHAN, YOhoho, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7213
Differential Revision: https://phab.enlightenment.org/D6754
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:15 +0000 (09:39 -0400)]
efl_ui_focus_composition: do not call legacy API here
Summary:
calling this on a object that is legacy is not going to work. And will
print a error. This will make new widgets less verbose.
ref T7213
Depends on D6755
Reviewers: YOhoho, zmike, CHAN
Reviewed By: YOhoho
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7213
Differential Revision: https://phab.enlightenment.org/D6756
Mike Blumenkrantz [Wed, 8 Aug 2018 13:38:24 +0000 (09:38 -0400)]
ci: automatically clear config.cache if it cannot be used
Summary:
if env vars change between runs then the cache is invalidated, causing
configure to print a very specific error
by running a separate script to catch this error, the build can detect
and clear the cache when necessary to avoid having to manually disable
the cache when changing build settings
Depends on D6697
Reviewers: stefan_schmidt, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6732
Derek Foreman [Wed, 8 Aug 2018 13:37:29 +0000 (09:37 -0400)]
wayland: Fix elementary setting window parents at creation time
Summary:
We need to pass the entire pointer, not just 32-bits of it.
Fixes a crash with enlightenment sandbox gadgets where
ecore_wl2_window_alpha_get() is called with an invalid pointer while
trying to display a pop-up.
Reviewers: zmike, devilhorns
Reviewed By: zmike, devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6775
Mike Blumenkrantz [Wed, 8 Aug 2018 13:37:07 +0000 (09:37 -0400)]
tests/naviframe: namespace test function names
Summary:
no functional changes
Depends on D6759
Reviewers: stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: cedric, #committers
Tags: #efl_widgets, #efl_tests
Differential Revision: https://phab.enlightenment.org/D6760
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:33 +0000 (09:36 -0400)]
tests/genlist: add full test for expanding and contracting a genlist item
Summary:
this adds a fairly complete test for simulating the expand and contract
of a tree item in a genlist, as triggered by a user clicking the expand arrow
on an item
presently this test fails, as it is set to abort if any error messages are
logged and there are a number of focus manager errors
ref D6737
ref T6837
Reviewers: bu5hm4n, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee, cedric, #committers
Tags: #efl_tests, #efl_widgets
Maniphest Tasks: T6837
Differential Revision: https://phab.enlightenment.org/D6750
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:27 +0000 (09:36 -0400)]
tests/genlist: use genlist test namespace for test functions
Summary:
namespacing test function names makes test output easier to read.
no functional changes
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: SanghyeonLee, cedric, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6758
Mike Blumenkrantz [Thu, 19 Jul 2018 23:45:34 +0000 (19:45 -0400)]
edje_cc: change .mo file write location to be relative to the .edj file
previously this would attempt to write the .mo file to the same directory
that the .po file was found in, which is invalid in cases such as distcheck
where the source directory is not writable
@fix
Differential Revision: https://phab.enlightenment.org/D6636
Mike Blumenkrantz [Tue, 24 Jul 2018 15:40:28 +0000 (11:40 -0400)]
build: rewrite remaining $(OBJEXT) rules
fix the naming for these targets based on automake 1.16+ presence and
naming scheme
ref D6594
fix T7154
Differential Revision: https://phab.enlightenment.org/D6675
Yeongjong Lee [Wed, 8 Aug 2018 07:11:02 +0000 (16:11 +0900)]
elm_map: remove unreasonable efl_super call
Summary:
Efl_Ui_Widget which is super of Elm_Map is not implement Efl_Ui_Zoom. to call
efl_super of Elm_Map for Efl_Ui_Zoom method occurs unresolved function error.
Test Plan:
map_example_01
Check that there is no error message.
Reviewers: zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6772
Yeongjong Lee [Wed, 8 Aug 2018 07:05:16 +0000 (16:05 +0900)]
elm_map: implement zoom_mode_get, zoom_level_get
Test Plan:
map_example_01
Check that +,- button is working and no error message.
Reviewers: zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6771
Mike Blumenkrantz [Wed, 8 Aug 2018 06:56:02 +0000 (15:56 +0900)]
efl_ui/image_zoomable: fix internal eina file refcounting
Summary:
this pointer is owned by elm_theme, not the image, so the image refcount
must be increased in order to avoid accidentally closing the file which is
still in use by elm_theme and triggering a crash
this resolves the crash in the `efl_ui_image_zoomable_icon` test
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6774
Bowon Ryu [Wed, 8 Aug 2018 06:20:42 +0000 (15:20 +0900)]
efl_ui_tab_pager: clean up and remove unnecessary signals.
Summary:
TAB of efl_ui_tab_bar is no longer widget_item.
TAB is now layout,
so, do not need below signals.
"efl,text,visible"
"efl,text,hidden"
"efl,icon,visible"
"efl,icon,hidden"
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6770
Bryce Harrington [Wed, 8 Aug 2018 04:52:25 +0000 (13:52 +0900)]
eina: Add doxygen in/out tags for rectangle
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6776
Wonki Kim [Mon, 25 Jun 2018 06:56:11 +0000 (15:56 +0900)]
eina_prefix: Fix a logic to use a canonical path for finding prefix
wip
Change-Id: Ib6b8f9ff15da7cfd3540d93dd8c7021d53678768
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Hermet Park [Tue, 14 Aug 2018 21:13:24 +0000 (17:13 -0400)]
evas gl: fix missing map texture target.
Summary:
Map context missed setting texture target.
I guess this is one of regression bugs in gl backend.
When shader is flushed, it sets invalid texture target with map texture.
That caused blank map rendering, this could be observed temporary
because gl pipe contexts are reusable and missing texture target means,
it could use previous texture target values that mostly have GL_TEXTURE_2D.
@fix
Reviewers: #committers, ManMower
Reviewed By: #committers, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6818
Change-Id: I4fa4f70864da7ee1e244a187116d7f71159e1940
Lukasz Wlazly [Fri, 10 Aug 2018 08:27:13 +0000 (10:27 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: Icb6171e61255b3e5561982387ced4e8440ce234a
Youngbok Shin [Thu, 9 Aug 2018 09:43:45 +0000 (18:43 +0900)]
edje_cc: remove edje_cc build warning message caused by efl_version
In Tizen, new Textblock calculation is already applied by default.
So, this warning message is meaningless in Tizen.
@tizen_fix
Change-Id: I9a02653ddd5c7f6c6eedea767d930687c1f3da54
Joogab Yun [Thu, 9 Aug 2018 03:58:45 +0000 (12:58 +0900)]
evas : fixed coverty issue CID:111611
Change-Id: If5cfe093d251fb75d7c15380ad71a6e81cb5a790
Joogab Yun [Thu, 9 Aug 2018 03:34:49 +0000 (12:34 +0900)]
evas : fixed coverity issue CID:1013912
Change-Id: I8bfcf9e9e2235dd76947f91261fde19c875659b1
Taehyub Kim [Thu, 9 Aug 2018 02:00:53 +0000 (11:00 +0900)]
ecore_wl_dnd: free seat selection event when num_types are less than 0
Change-Id: Ieaf11eb564c478f22c3b0f6ec0b38811b9fa65d3
Hermet Park [Wed, 8 Aug 2018 07:01:11 +0000 (16:01 +0900)]
evas image: fix screen flickering issue at partial + image preloading
Summary:
Prerequisite: Partial rendering ON + Image Prealoding + Triple surface buffer of GL.
Previously, evas trys to draw of an image which didn't prepare of image data yet (in case of preloading)
This time, it will draw a solid color onto the dest sufrace 1,
But luckily, preloading is finished just after, it draws proper image data onto next surface 2 and 3.
Now, triple buffer is filled with the image data but only first frame is still empty. That's a problem.
This patch skips to draw image if it doesn't prepare data yet, but once the preloading is finished,
it starts to draw images.
@fix
Reviewers: #committers
Subscribers: kimcinoo, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6739
Change-Id: I64f4b5a6ca68feba086f05b3d8da5e5110416345
Shinwoo Kim [Wed, 8 Aug 2018 04:51:40 +0000 (13:51 +0900)]
evas_image: do not render while preloading
Summary:
Unexpected image shows if image data is not ready.
Even though there is a change to check the 'preloading' in pre_render phase,
evas_object_image_render is called. So we need to check here as well.
Reference: https://phab.enlightenment.org/D6739
It seems that the 'preloading' is not enough. The 'preloading' could be reset
to FALSE by _evas_image_load_async_cancel > _image_preload_internal.
If the following step happens, then this patch set is neccessary.
(1) evas_object_image_pre_render
(2) _evas_iamge_load_async_start
(3) evas_object_image_render
I could not find out what the correct step, but it actullay happens.
The evas_object_image_render could be called with the 'preloading' TURE.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6778
Change-Id: I0b0d941868ee53bd4f89a0895b029034b6f035f2
Hermet Park [Wed, 8 Aug 2018 06:52:37 +0000 (15:52 +0900)]
elementary image: don't calc size using empty ones.
Summary:
Zero-sized image occasionally happens.
That occurs insane img/clipper region.
bj size => (w, h) then resize => (0, 0)
file_set(xx.jpg) then file_set (NULL)
Because of this, region could be flickered during prev/cur preloading images.
@fix
Reviewers: #committers, zmike
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6725
Change-Id: If3f01f66efe2eef6f62520dabbb6237d68dfb8b5
Lukasz Wlazly [Mon, 13 Aug 2018 08:54:22 +0000 (10:54 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: I558c4f41ce72321272db3db433f259c4d6f08387