Jeremiah Senkpiel [Fri, 28 Aug 2015 21:26:07 +0000 (17:26 -0400)]
doc: clarify cluster behaviour with no workers
Fixes: https://github.com/nodejs/node/issues/1239
Ref:
41b75ca9263f368db790fbdcc3963bb1a8c5cb7e
PR-URL: https://github.com/nodejs/node/pull/2606
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Bradley Meck [Sat, 22 Aug 2015 18:36:03 +0000 (13:36 -0500)]
Introduce --link-module to ./configure
- Allows specifying a _third_party_main outside of the node repository
- Allows embedders to create custom builtin modules outside of node's
repository
PR-URL: https://github.com/nodejs/node/pull/2497
Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
João Reis [Wed, 26 Aug 2015 19:11:27 +0000 (20:11 +0100)]
win,msi: correct installation path registry keys
This is a port of
14db629497d0eb97a5f0fbb70cf3e534e460deec.
Original commit message:
Since install is per machine only, installation path should be stored
in local machine instead of current user. The registry stores HKLM in
different places for 32 and 64 bit applications, so the installer
will not suggest the old path when upgrading from 32 to 64 bit
version.
Fixes joyent/node#5592
Fixes joyent/node#25087
PR-URL: https://github.com/joyent/node/pull/25640
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2565
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
João Reis [Wed, 26 Aug 2015 19:07:33 +0000 (20:07 +0100)]
win,msi: change InstallScope to perMachine
This is an adaptation of
8e80528453aca0354422162e09c7c9f4700ddb1e.
Original commit message:
The MSI install scope was set to the WiX default, which is per-user.
However, with UAC, it could not be installed by a standard user
because InstallPrivileges is elevated by default, hence the install
scope should be set to per-machine. Furthermore, the default install
path is a per-machine location and setting the system path requires
administrator privileges.
By changing the InstallScope to perMachine, Start Menu shortcuts are
placed in ProgramData and not the installing user's AppData folder,
making the shortcuts available to other users. This also fixes the
installation when AppData is a network folder.
The custom action is necessary to allow upgrades. Since a per-machine
MSI cannot upgrade an application installed per-user, the custom
action checks if there is going to be an upgrade to a previous
version installed per-user and sets the installation as per-user to
allow upgrading. Hence, the advantages of installing per-machine will
only apply in fresh installations.
Fixes joyent/node#5849
Fixes joyent/node#7629
PR-URL: https://github.com/joyent/node/pull/25640
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
The original commit was adapted to search all upgrade codes listed in
the upgrade table, as the current installer tries to upgrade from two
different upgrade codes.
PR-URL: https://github.com/nodejs/node/pull/2565
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Michaël Zasso [Thu, 27 Aug 2015 07:10:22 +0000 (09:10 +0200)]
deps: update V8 to 4.4.63.30
PR-URL: https://github.com/nodejs/node/pull/2482
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sakthipriyan Vairamani [Thu, 27 Aug 2015 20:08:10 +0000 (01:38 +0530)]
test: use tmpDir instead of fixturesDir
This test was using fixturesDir to create temp files to test. This
patch replaces that with tmpDir and uses `assert` module to test.
Also, this test has been moved to `parallel`, from `sequential` mode.
PR-URL: https://github.com/nodejs/node/pull/2583
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Ben Noordhuis [Thu, 27 Aug 2015 20:47:15 +0000 (22:47 +0200)]
Revert "lib,src: add unix socket getsockname/getpeername"
This reverts commit
6cd0e2664b1ce944e5e461457d160be83f70d379.
This reverts commit
7a999a13766ac68049812fedbdfd15a0250f0f07.
This reverts commit
f337595441641ad36f6ab8ae770e56c1673ef692.
It turns out that on Windows, uv_pipe_getsockname() is a no-op for
client sockets. It slipped through testing because of a CI snafu.
PR-URL: https://github.com/nodejs/node/pull/2584
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Ben Noordhuis [Thu, 27 Aug 2015 15:57:09 +0000 (17:57 +0200)]
doc: update io.js reference
Commit f337595 ("lib,src: add unix socket getsockname/getpeername")
accidentally left in a reference to io.js v1.5.0 in the documentation.
Update it to say "Node.js v4.0.0", the upcoming release.
PR-URL: https://github.com/nodejs/node/pull/2580
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Ben Noordhuis [Thu, 5 Mar 2015 13:24:53 +0000 (14:24 +0100)]
lib: add net.Socket#localFamily property
Complements the existing net.Socket#remoteFamily property.
PR-URL: https://github.com/nodejs/node/pull/956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Ben Noordhuis [Wed, 25 Feb 2015 16:19:11 +0000 (17:19 +0100)]
lib,src: add unix socket getsockname/getpeername
The implementation is a minor API change in that socket.address() now
returns a `{ address: '/path/to/socket' }` object, like it does for TCP
and UDP sockets. Before this commit, it returned `socket._pipeName`,
which is a string when present.
Change common.PIPE on Windows from '\\\\.\\pipe\\libuv-test' to
'\\\\?\\pipe\\libuv-test'. Windows converts the '.' to a '?' when
creating a named pipe, meaning that common.PIPE didn't match the
result from NtQueryInformationFile().
Fixes: https://github.com/nodejs/node/issues/954
PR-URL: https://github.com/nodejs/node/pull/956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Ben Noordhuis [Wed, 25 Feb 2015 15:40:40 +0000 (16:40 +0100)]
src: DRY getsockname/getpeername code
Extract the common logic into a template function. No functional
changes, just code cleanup.
PR-URL: https://github.com/nodejs/node/pull/956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Сковорода Никита Андреевич [Thu, 27 Aug 2015 08:52:03 +0000 (11:52 +0300)]
doc: minor clarification in buffer.markdown
Replaced "contents is" with "contents are".
Added a note that initial Buffer contents could contain sensitive data.
PR-URL: https://github.com/nodejs/node/pull/2574
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Сковорода Никита Андреевич [Thu, 27 Aug 2015 09:24:45 +0000 (12:24 +0300)]
crypto: Use OPENSSL_cleanse to shred the data.
memset() is not useful here, it's efficiently a noop.
PR-URL: https://github.com/nodejs/node/pull/2575
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Sakthipriyan Vairamani [Sun, 19 Jul 2015 19:20:21 +0000 (19:20 +0000)]
test: handling failure cases properly
Refer: https://github.com/nodejs/io.js/issues/1543
When this test fails, it leaves dead processes in the system. This
patch makes sure that the child processes exit first, in case of
errors.
PR-URL: https://github.com/nodejs/node/pull/2206
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Alexis Campailla [Wed, 26 Aug 2015 10:42:45 +0000 (12:42 +0200)]
test: initial list of flaky tests
This poplulates the lists of flaky tests with tests that failed recently
in Jenkins.
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Alexis Campailla [Wed, 26 Aug 2015 10:41:16 +0000 (12:41 +0200)]
test: pass args to test-ci via env variable
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Alexis Campailla [Wed, 26 Aug 2015 10:38:48 +0000 (12:38 +0200)]
test: support flaky tests in test-ci
Adding support for specifying flaky test mode to
the test runner:
- via an environment variable FLAKY_TESTS for Makefile
- via an argument ignore-flaky for vcbuild.bat
Ported from https://github.com/joyent/node/commit/
2d2494cf140c38327218a087593ff2177a9d0ec9
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Alexis Campailla [Tue, 18 Aug 2015 12:04:14 +0000 (14:04 +0200)]
test: add test configuration templates
Template configuration files for marking tests as flaky.
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Alexis Campailla [Tue, 7 Jul 2015 20:48:26 +0000 (22:48 +0200)]
test: runner should return 0 on flaky tests
Make the test runner return a 0 exit code when only
flaky tests fail and --flaky-tests=dontcare is specified.
Ported from https://github.com/joyent/node/commit/
a9b642cf5b539e1b86698465d3d0b941d84c5352
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Alexis Campailla [Fri, 7 Nov 2014 13:15:24 +0000 (14:15 +0100)]
test: runner support for flaky tests
Adding --flaky-tests option, to allow regarding flaky tests failures
as non-fatal.
Currently only observed by the TapProgressIndicator, which will
add a # TODO directive to tests classified as flaky. According to the
TAP specification, the test harness is supposed to treat failures
that have a # TODO directive as non-fatal.
Ported from https://github.com/joyent/node/commit/
df3a2b2cf21274fe7afc19d14ec0259b964e13f7
PR-URL: https://github.com/nodejs/node/pull/2424
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Minwoo Jung [Wed, 26 Aug 2015 12:17:52 +0000 (21:17 +0900)]
debugger: use strict equality comparison
There is no type-conversion to be done. Therefore, use the === operator.
PR-URL: https://github.com/nodejs/node/pull/2558
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fedor Indutny [Wed, 12 Aug 2015 03:02:22 +0000 (20:02 -0700)]
http_parser: consume StreamBase instance
Consume StreamBase instance and operate on incoming data directly
without allocating Buffer instances. Improves performance.
PR-URL: https://github.com/nodejs/node/pull/2355
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fedor Indutny [Wed, 26 Aug 2015 11:37:50 +0000 (04:37 -0700)]
env: introduce `KickNextTick`
There might be a need to "kick off" the next tick queue and execute
events on it. Normally it is done through the `MakeCallback` interface,
but in case when it is not - we need a way to "kick them off" manually.
PR-URL: https://github.com/nodejs/node/pull/2355
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Rich Trott [Tue, 25 Aug 2015 16:18:25 +0000 (09:18 -0700)]
test: make test-process-argv-0 robust
Remove use of STDERR to avoid test flakiness on CentOS 5.
Use parent process exit event for assertion rather than child exit
event.
PR-URL: https://github.com/nodejs/node/pull/2541
Fixes: https://github.com/nodejs/node/issues/2477
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Jeremiah Senkpiel [Tue, 25 Aug 2015 22:48:15 +0000 (18:48 -0400)]
src: missing Exception::Error in node_http_parser
Fixes:
75adde07f9a2de7f38a67bec72bd377d450bdb52
PR-URL: https://github.com/nodejs/node/pull/2550
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Rod Vagg [Thu, 20 Aug 2015 04:52:33 +0000 (14:52 +1000)]
doc: add @jasnell and @sam-github to release team
Fixes: https://github.com/nodejs/node/issues/2416
PR-URL: https://github.com/nodejs/node/pull/2455
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Rod Vagg [Thu, 20 Aug 2015 04:51:00 +0000 (14:51 +1000)]
doc: reorg release team to separate section
included:
* commands to run to import all active keys
* list of previous Node.js releasers key details
PR-URL: https://github.com/nodejs/node/pull/2455
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
James M Snell [Wed, 26 Aug 2015 01:58:08 +0000 (18:58 -0700)]
doc: fix bad merge on modules.markdown
My previous commit landed a bad merge on modules.markdown.
This fixes it.
James M Snell [Sat, 22 Aug 2015 02:21:06 +0000 (19:21 -0700)]
doc: minor additional corrections and improvements
Per feedback from @thefourtheye: (a) improve word on the
description of the `close` event in stream.markdown and
(b) remove `[module section]: modules.html` from
globals.markdown
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 23:23:00 +0000 (16:23 -0700)]
doc: minor grammatical update in crypto.markdown
Per: https://github.com/joyent/node/pull/8878
Originally submitted by @jacksonhoose
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 23:08:57 +0000 (16:08 -0700)]
doc: minor grammatical update
Per: https://github.com/joyent/node/pull/9009
Originally submitted by @peerwit
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 22:54:28 +0000 (15:54 -0700)]
doc: remove repeated statement in globals.markdown
Per: https://github.com/joyent/node/pull/25102
Originally reported by @kuldipem
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 22:27:17 +0000 (15:27 -0700)]
doc: remove 'dudes' from documentation
per: https://github.com/joyent/node/pull/25572#discussion_r33197896
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 22:23:25 +0000 (15:23 -0700)]
doc: update tense in child_process.markdown
per: https://github.com/joyent/node/pull/25826
originally submitted by: @ClimbsRocks
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 22:12:47 +0000 (15:12 -0700)]
doc: fixed worker.id type
per: https://github.com/joyent/node/pull/25459
originally submitted by @sonnyp
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 22:05:24 +0000 (15:05 -0700)]
doc: port is optional for socket.bind()
per: https://github.com/joyent/node/pull/25356
originally submitted by @dcousens
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 19:56:26 +0000 (12:56 -0700)]
doc: fix minor types and grammar in fs docs
per: https://github.com/joyent/node/pull/7431
originally submitted by @linclark
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 18:43:23 +0000 (11:43 -0700)]
doc: update parameter name in net.markdown
per: https://github.com/joyent/node/pull/7112
originally submitted by @Peekmo
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 18:36:39 +0000 (11:36 -0700)]
doc: small typo in domain.markdown
per: https://github.com/joyent/node/pull/7715
originally submitted by @tonylukasavage
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 18:07:13 +0000 (11:07 -0700)]
doc: fixed typo in net.markdown (missing comma)
per: https://github.com/joyent/node/pull/7930
originally submitted by @pbrewczynski
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:59:07 +0000 (10:59 -0700)]
doc: update description of fs.exists in fs.markdown
per: https://github.com/joyent/node/pull/7944
originally submitted by @oconnore
Minor update to the description in `fs.exists()`
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:46:43 +0000 (10:46 -0700)]
doc: clarification on the 'close' event
per: https://github.com/joyent/node/pull/8209
originally submitted by @jeromew
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:39:20 +0000 (10:39 -0700)]
doc: improve working in stream.markdown
per: https://github.com/joyent/node/pull/8430
originally submitted by @mscdex
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:25:10 +0000 (10:25 -0700)]
doc: update path.extname documentation
per: https://github.com/joyent/node/pull/8509
originally submitted by @thauburger
Adding an additional example to path.extname documentation
to demonstrate the case where the first character of the last
path component is '.'. This case is interesting, as something
like path.extname('.txt') returns an empty string. In this
case, .txt can be used as a valid file name (while arguably
maintaining an extension). I agree with Node's behavior in this
case, but I think the added example provides additional clarity
for the developer.
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:09:30 +0000 (10:09 -0700)]
doc: small clarifications to modules.markdown
per: https://github.com/joyent/node/pull/8708
A modified version of the original PR submitted by @builtbylane.
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 17:00:54 +0000 (10:00 -0700)]
doc: code style cleanups in repl.markdown
per: https://github.com/joyent/node/pull/8778
originally submitted by @reggi
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 16:48:49 +0000 (09:48 -0700)]
doc: correct grammar in cluster.markdown
per: https://github.com/joyent/node/pull/14352
originally submitted by @AlexKVal
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
James M Snell [Fri, 14 Aug 2015 16:46:07 +0000 (09:46 -0700)]
doc: Clarify the module.parent is set once
Per: https://github.com/jorrit/node/commit/
54a7f79a4a2ecb9c6f235a03287fe2992f19f0bb
Fixes: https://github.com/joyent/node/issues/6149
Originally submitted by @jorrit
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2378
Rich Trott [Tue, 25 Aug 2015 16:45:42 +0000 (09:45 -0700)]
test: speed up test-child-process-spawnsync.js
There's a bunch of stuff in test-child-process-spawnsync.js that seems
designed to test that it is in fact blocking/synchronous. However, that
code really just tests the OS sleep command. Change `sleep 1` to `sleep
0` and shave about one second off the test run.`
We check the return status to confirm the command is successful. The
tests in this file in general would not work if spawnSync() were
asynchronous. That includes this one, as a return status would not be
available if the command where asynchronous.
PR-URL: https://github.com/nodejs/node/pull/2542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Evan Lucas [Tue, 25 Aug 2015 00:13:22 +0000 (19:13 -0500)]
build: only define NODE_V8_OPTIONS if not empty
Previously, V8::SetFlagsFromString was called on every launch even if
NODE_V8_OPTIONS was an empty string. This patch only defines
NODE_V8_OPTIONS if node_v8_options is not an empty string.
PR-URL: https://github.com/nodejs/node/pull/2532
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Jeremiah Senkpiel [Mon, 24 Aug 2015 14:29:40 +0000 (10:29 -0400)]
doc: add internal modules notice
Explicitly note that these modules should not be used outside of core.
PR-URL: https://github.com/nodejs/node/pull/2523
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Rich Trott [Tue, 25 Aug 2015 04:25:48 +0000 (21:25 -0700)]
test: make spawnSync() test robust
The test had checked that a timer fired within a period after
spawnSync() returns. The result was a test that sometimes was
flaky.
Because there's no guarantee of how long a timer will take
before running, remove the check. There is a check that the
timer runs after spawnSync() so that is sufficient.
PR-URL: https://github.com/nodejs/node/pull/2535
Fixes: https://github.com/nodejs/node/issues/2470
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
João Reis [Tue, 18 Aug 2015 18:50:10 +0000 (19:50 +0100)]
win,msi: Upgrade from old upgrade code
This enables the MSI to upgrade old Node.js versions and
early versions of io.js before the upgrade code was changed.
This also reverts
24def662936ae8c15770ede0344cd7a7402a63ef.
PR-URL: https://github.com/nodejs/node/pull/2439
Reviewed-By: Rod Vagg <rod@vagg.org>
Ben Noordhuis [Thu, 20 Aug 2015 14:57:03 +0000 (16:57 +0200)]
tools: make add-on scraper print filenames
Make the tool that generates add-ons from doc/api/addons.markdown print
the names of the files it writes out. Before this commit, it printed a
rather unhelpful "Done."
PR-URL: https://github.com/nodejs/node/pull/2428
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Ben Noordhuis [Tue, 18 Aug 2015 19:29:59 +0000 (21:29 +0200)]
build: make ci test addons in test/addons
Make `make test-addons` part of the `make test-ci` target.
Use order-only prerequisites to make generating and building the add-ons
concurrency-safe when $JOBS > 1 and fudge the dependency on $(NODE_EXE)
so that add-ons are only rebuilt when needed instead of all the time.
PR-URL: https://github.com/nodejs/node/pull/2428
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Rod Vagg [Sun, 23 Aug 2015 12:08:06 +0000 (22:08 +1000)]
doc: update changelog for io.js v3.2.0
Notable changes:
* events: Added EventEmitter#listenerCount(event) as a replacement for
EventEmitter.listenerCount(emitter, event), which has now been
marked as deprecated in the docs. (Sakthipriyan Vairamani) #2349
* module: Fixed an error with preloaded modules when the current
working directory doesn't exist. (Bradley Meck) #2353
* node: Startup time is now about 5% faster when not passing V8 flags.
(Evan Lucas) #2483
* repl: Tab-completion now works better with arrays.
(James M Snell) #2409
* string_bytes: Fixed an unaligned write in the handling of UCS2
encoding. (Fedor Indutny) #2480
* tls: Added a new --tls-cipher-list flag that can be used to override
the built-in default cipher list. (James M Snell) #2412
PR-URL: https://github.com/nodejs/node/pull/2512
Rich Trott [Wed, 19 Aug 2015 06:15:25 +0000 (23:15 -0700)]
test: refactor test-https-simple.js
This refactoring:
* eliminates the need for the external `curl` command
* speeds the test by running the two test requests simultaneously
* checks the type of error in the test that expects a failure
(previously, any error type would cause the test to pass)
PR-URL: https://github.com/nodejs/node/pull/2433
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Evan Lucas [Sun, 23 Aug 2015 03:40:41 +0000 (22:40 -0500)]
build: use required platform in android-configure
The introduction of libuv 1.6.0 broke the android-configure script by
not specifying the correct platform. uv_os_homedir uses getpwuid_r
which was not made public until API level 21 on android.
The regression was introduced in a804026...b5cd2f0
PR-URL: https://github.com/nodejs/node/pull/2501
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Ben Noordhuis [Thu, 20 Aug 2015 20:33:12 +0000 (22:33 +0200)]
stream: rename poorly named function
roundUpToNextPowerOf2() does more than just rounding up to the next
power of two. Rename it to computeNewHighWaterMark().
PR-URL: https://github.com/nodejs/node/pull/2479
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Ben Noordhuis [Thu, 20 Aug 2015 20:29:57 +0000 (22:29 +0200)]
stream: micro-optimize high water mark calculation
Don't iterate over all 32 bits, use some hacker's delight bit twiddling
to compute the next power of two.
The logic can be reduced to `n = 1 << 32 - Math.clz32(n)` but then it
can't easily be backported to v2.x; Math.clz32() was added in V8 4.3.
PR-URL: https://github.com/nodejs/node/pull/2479
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Ben Noordhuis [Thu, 20 Aug 2015 20:19:46 +0000 (22:19 +0200)]
stream: fix off-by-factor-16 error in comment
The high watermark is capped at 8 MB, not 128 MB like the comment
in lib/_stream_readable.js said.
PR-URL: https://github.com/nodejs/node/pull/2479
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Bradley Meck [Wed, 12 Aug 2015 00:25:49 +0000 (20:25 -0400)]
module: fix module preloading when cwd is ENOENT
Fixes a regression from
5759722cfacf17cc79651c81801a5e03521db053
that prevented modules from being preloaded if the cwd does not exist.
Absolute and builtin modules now preload correctly again.
Refs: https://github.com/nodejs/node/issues/1803
PR-URL: https://github.com/nodejs/node/pull/2353
Reviewed-By: Jeremiah Senkpiel <fishrock123@rockemail.com>
João Reis [Thu, 20 Aug 2015 10:04:10 +0000 (11:04 +0100)]
test: remove test-timers-first-fire
According to the documentation, "io.js makes no guarantees
about the exact timing of when the callback will fire"
(https://iojs.org/api/timers.html#timers_settimeout_callback_delay_arg),
hence this test is not necessary.
PR-URL: https://github.com/nodejs/node/pull/2458
Reviewed-By: Ben Noordhuis <ben@strongloop.com>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
João Reis [Tue, 21 Jul 2015 20:39:15 +0000 (21:39 +0100)]
win: fix custom actions for WiX older than 3.9
This is a port of joyent/node@
e192f61514cd1500de895cb10128d412f842d7d0 .
Original commit message:
Older WiX versions included a header with extern "C" declaration,
hence the custom action source must be C++.
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: https://github.com/joyent/node/pull/25569
PR-URL: https://github.com/nodejs/node/pull/2365
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Julien Gilli [Fri, 19 Jun 2015 17:24:14 +0000 (10:24 -0700)]
win: fix custom actions on Visual Studio != 2013
This is a port of joyent/node@
16bcd68dc5f449c331499ced22aa626dbb2cdefc .
Original commit message:
The original change that added support for running custom actions
during the install process
(joyent/node@
e7c84f82c730bddb7450dc56065aab11b93ffd30) assumed that
Visual Studio 2013 is used to generate the installer file.
However, that is not always the case, and older versions of Visual
Studio should allow users to generate Windows installer files. This
change makes the custom actions visual studio project use the visual
studio version that is found by vcbuild.bat.
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: https://github.com/joyent/node/pull/25569
PR-URL: https://github.com/nodejs/node/pull/2365
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Sakthipriyan Vairamani [Wed, 19 Aug 2015 22:37:52 +0000 (04:07 +0530)]
doc: make the deprecations consistent
The deprecation messages in the documentations should be in the format
Stability: 0 - Deprecated: Use [alternate] instead.
so that they will be consistent.
PR-URL: https://github.com/nodejs/node/pull/2450
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Roman Reiss [Mon, 24 Aug 2015 05:17:50 +0000 (07:17 +0200)]
doc: fix CHANGELOG.md on master
This patch applies the diff of CHANGELOG from v3.x branch to master,
corresponding to the 3.1.0 release.
Fixes: https://github.com/nodejs/node/issues/2456
Fixes: https://github.com/nodejs/node/issues/2502
PR-URL: https://github.com/nodejs/node/pull/2513
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sakthipriyan Vairamani [Wed, 19 Aug 2015 20:39:47 +0000 (02:09 +0530)]
doc: document deprecation of util.is* functions
This patch documentes the deprecation of util.is* functions.
As per the deprecation policy dicussion, nodejs/dev-policy/issues/49,
we need to start with documenting the deprecation. So, this is
the first step towards officially removing them.
PR-URL: https://github.com/nodejs/node/pull/2447
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
cjihrig [Sun, 23 Aug 2015 20:40:28 +0000 (16:40 -0400)]
node: additional cleanup for node rename
Fixes: https://github.com/nodejs/node/issues/2361
PR-URL: https://github.com/nodejs/node/pull/2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
cjihrig [Fri, 21 Aug 2015 01:45:38 +0000 (21:45 -0400)]
process: make process.release.name "node"
This commit sets the value of process.release.name to "node".
Fixes: https://github.com/nodejs/node/issues/2361
PR-URL: https://github.com/nodejs/node/pull/2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Frederic Hemberger [Thu, 20 Aug 2015 14:53:38 +0000 (10:53 -0400)]
installer: fix installers for node.js rename
This commit completes the io.js to Node.js rename in the
Windows installer.
Fixes: https://github.com/nodejs/node/issues/2418
PR-URL: https://github.com/nodejs/node/pull/2367
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
cjihrig [Thu, 13 Aug 2015 16:14:34 +0000 (12:14 -0400)]
node: rename from io.js to node
This commit replaces instances of io.js with Node.js, based on the
recent convergence. There are some remaining instances of io.js,
related to build and the installer.
Fixes: https://github.com/nodejs/node/issues/2361
PR-URL: https://github.com/nodejs/node/pull/2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Rich Trott [Tue, 28 Jul 2015 00:10:47 +0000 (17:10 -0700)]
test: use reserved IP in test-net-connect-timeout
Use reserved IP in test-net-connect-timeout.js rather than arbitrary
IP.
PR-URL: https://github.com/nodejs/node/pull/2257
Fixes: https://github.com/nodejs/node/issues/2469
Reviewed By: Ben Noordhuis <ben@strongloop.com>
Minwoo Jung [Sat, 22 Aug 2015 06:07:09 +0000 (23:07 -0700)]
doc: fix comments in tls_wrap.cc and _http_client.js
fixed grammatically wrong expressions to make it clear
Reviewed By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2490
PR-URL: https://github.com/nodejs/node/pull/2489
James M Snell [Sat, 15 Aug 2015 16:40:32 +0000 (09:40 -0700)]
tools: add license boilerplate to check-imports.sh
Per: https://github.com/joyent/node/pull/6962
This applies only the first commit from https://github.com/joyent/node/pull/6962.
/cc @bnoorduis
Reviewed By: Ben Noordhuis <ben@strongloop.com>
PR-URL: https://github.com/nodejs/node/pull/2386
James M Snell [Mon, 17 Aug 2015 22:51:51 +0000 (15:51 -0700)]
tls: add --tls-cipher-list command line switch
This adds a new `--tls-cipher-list` command line switch
that can be used to override the built-in default cipher
list. The intent of this is to make it possible to enforce
an alternative default cipher list at the process level.
Overriding the default cipher list is still permitted at
the application level by changing the value of
`require('tls').DEFAULT_CIPHERS`.
As part of the change, the built in default list is moved
out of tls.js and into node_constants.h and node_constants.cc.
Two new constants are added to require('constants'):
* defaultCipherList (the active default cipher list)
* defaultCoreCipherList (the built-in default cipher list)
A test case and doc changes are included.
A new NODE_DEFINE_STRING_CONSTANT macro is also created in
node_internals.h
When node_constants is initialized, it will pick up either
the passed in command line switch or fallback to the default
built-in suite.
Within joyent/node, this change had originaly been wrapped
up with a number of other related commits involving the
removal of the RC4 cipher. This breaks out this isolated
change.
/cc @mhdawson, @misterdjules, @trevnorris, @indutny, @rvagg
Reviewed By: Ben Noordhuis <ben@strongloop.com>
PR-URL: https://github.com/nodejs/node/pull/2412
hackerjs [Tue, 10 Dec 2013 10:56:04 +0000 (18:56 +0800)]
doc: document response.finished in http.markdown
Adds mention of response.finished to http.markdown
Originally submitted by @hackerjs. The original
commit needed a bit of cleanup on grammar.
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2414
Rod Vagg [Sun, 23 Aug 2015 07:45:43 +0000 (17:45 +1000)]
doc: update AUTHORS list
Update AUTHORS list using tools/update-authors.sh
Fix @muddletoes' .mailmap entry
PR-URL: https://github.com/nodejs/node/pull/2505
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Brendan Ashworth [Tue, 18 Aug 2015 23:33:11 +0000 (16:33 -0700)]
tools: enable space-after-keywords in eslint
Requires that you do:
if (x) { ... }
Rather than:
if(x) { ... }
Brendan Ashworth [Tue, 18 Aug 2015 23:32:07 +0000 (16:32 -0700)]
test: add spaces after keywords
eg changes:
if(x) { ... }
to:
if (x) { ... }
Roman Klauke [Sat, 22 Aug 2015 17:19:14 +0000 (19:19 +0200)]
fs: replace bad_args macro with concrete error msg
Instead of throwing an error with `Bad arguments` the fs methods
return a concrete error message. If an argument is missing, the
methods throw an error with the information, what is missing.
In case of a type mismatch, they throw an error with some hints,
what datatype is expected.
PR-URL: https://github.com/nodejs/node/pull/2495
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sakthipriyan Vairamani [Sat, 22 Aug 2015 08:10:55 +0000 (13:40 +0530)]
tools: fix anchors in generated documents
When an anchor tag is used within a pre tag, the link is not
distinguishable. This patch makes sure that the links are highlighted
by underlining them.
PR-URL: https://github.com/nodejs/node/pull/2491
Reviewed-By: Roman Reiss <me@silverwind.io>
Rod Vagg [Thu, 6 Aug 2015 22:33:47 +0000 (15:33 -0700)]
doc: update AUTHORS list
Update AUTHORS list using tools/update-authors.sh
PR-URL: https://github.com/nodejs/node/pull/2318
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Rod Vagg [Wed, 19 Aug 2015 10:47:47 +0000 (20:47 +1000)]
doc: add TSC meeting minutes 2015-07-29
PR-URL: https://github.com/nodejs/node/pull/2437
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Rod Vagg [Thu, 20 Aug 2015 10:46:08 +0000 (20:46 +1000)]
doc: add TSC meeting minutes 2015-08-19
PR-URL: https://github.com/nodejs/node/pull/2460
Reviewed-By: James M Snell <jasnell@gmail.com>
Rod Vagg [Thu, 20 Aug 2015 00:43:17 +0000 (10:43 +1000)]
doc: add TSC meeting minutes 2015-06-03
PR-URL: https://github.com/nodejs/node/pull/2453
Reviewed-By: James M Snell <jasnell@gmail.com>
Rod Vagg [Thu, 20 Aug 2015 03:41:07 +0000 (13:41 +1000)]
doc: fix links to original converged repo
nodejs/node -> nodejs/node-convergence-archive
PR-URL: https://github.com/nodejs/node/pull/2454
Reviewed-By: James M Snell <jasnell@gmail.com>
Rod Vagg [Thu, 20 Aug 2015 03:29:55 +0000 (13:29 +1000)]
doc: fix links to original gh issues for TSC meetings
nodejs/node -> nodejs/node-convergence-archive
PR-URL: https://github.com/nodejs/node/pull/2454
Reviewed-By: James M Snell <jasnell@gmail.com>
Rod Vagg [Thu, 20 Aug 2015 01:00:16 +0000 (11:00 +1000)]
doc: add audio recording links to TSC meeting minutes
PR-URL: https://github.com/nodejs/node/pull/2454
Reviewed-By: James M Snell <jasnell@gmail.com>
James M Snell [Mon, 17 Aug 2015 19:03:32 +0000 (12:03 -0700)]
repl: filter integer keys from repl tab complete list
Refactored version of https://github.com/joyent/node/pull/25819
Removes integer keys (and keys starting with numbers) from
candidate list on repl tab complete. Refactored the originally
submitted change to simplify and ensure that the integer keys
do not show up on objects either.
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/2409
Fedor Indutny [Fri, 21 Aug 2015 19:48:10 +0000 (12:48 -0700)]
buffer: reapply 07c0667
Original commit message:
buffer: align chunks on 8-byte boundary
When slicing global pool - ensure that the underlying buffer's data
ptr is 8-byte alignment to do not ruin expectations of 3rd party C++
addons.
NOTE: 0.10 node.js always returned aligned pointers and io.js should
do this too for compatibility.
PR-URL: https://github.com/nodejs/node/pull/2487
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fedor Indutny [Thu, 20 Aug 2015 23:57:14 +0000 (16:57 -0700)]
string_bytes: fix unaligned write in UCS2
Support unaligned output buffer when writing out UCS2 in
`StringBytes::Write`.
Fix: https://github.com/nodejs/node/issues/2457
PR-URL: https://github.com/nodejs/node/pull/2480
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Evan Lucas [Fri, 21 Aug 2015 09:15:55 +0000 (04:15 -0500)]
src: improve startup time
Previously, V8:SetFlagsFromCommandLine was being called even if v8_argc
was 0. This change prevents that from being called unless v8 arguments
are actually passed.
Improves startup time by about 5%.
PR-URL: https://github.com/nodejs/node/pull/2483
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Rod Vagg [Wed, 19 Aug 2015 10:45:26 +0000 (20:45 +1000)]
doc: add TSC meeting minutes 2015-07-22
PR-URL: https://github.com/nodejs/node/pull/2436
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Karl Skomski [Wed, 12 Aug 2015 13:30:01 +0000 (15:30 +0200)]
crypto: fix mem {de}allocation in ExportChallenge
Use correct deallocator for returned buffera.
Don't free internal structure via ASN1_STRING_data.
Deallocate NETSCAPE_SPKI.
PR-URL: https://github.com/nodejs/node/pull/2359
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Mike Atkins [Mon, 10 Aug 2015 15:55:37 +0000 (11:55 -0400)]
tls: handle empty cert in checkServerIndentity
This resolves joyent/node#9272. `tlsSocket.getPeerCertificate` will
return an empty object when the peer does not provide a certificate,
but, prior to this, when the certificate is empty, `checkServerIdentity`
would throw because the `subject` wasn't present on the cert.
`checkServerIdentity` must return an error, not throw one, so this
returns an error when the cert is empty instead of throwing
a `TypeError`.
PR-URL: https://github.com/nodejs/node/pull/2343
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Jacob Edelman [Sat, 15 Aug 2015 17:56:12 +0000 (10:56 -0700)]
doc: fix spelling mistake in node.js comment
Per: https://github.com/joyent/node/pull/8876
PR-URL: https://github.com/nodejs/node/pull/2391
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Michaël Zasso [Sun, 2 Aug 2015 10:09:38 +0000 (12:09 +0200)]
test: remove unreachable code
There is no way a line can be called after throwing an exception.
PR-URL: https://github.com/nodejs/node/pull/2289
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Michaël Zasso [Thu, 20 Aug 2015 09:37:02 +0000 (11:37 +0200)]
test: disallow unreachable code
PR-URL: https://github.com/nodejs/node/pull/2289
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Todd Kennedy [Wed, 19 Aug 2015 22:44:20 +0000 (15:44 -0700)]
repl: dont throw ENOENT on NODE_REPL_HISTORY_FILE
If you have no history file written to disk, but the environment
variable set, `fs.readFileSync` will throw an ENOENT error,
but there's nothing to convert. The converter should ignore
ENOENT on that `fs.readFileSync` call.
Fixes: https://github.com/nodejs/node/issues/2449
PR-URL: https://github.com/nodejs/node/pull/2451
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
projects / platform / upstream / nodejs.git / log