davewheel [Mon, 15 May 2017 16:52:39 +0000 (18:52 +0200)]
Add a callback to provide NTLM hashes on server-side
Adds a callback that allows servers to compute NTLM hashes by themselves. The typical
use of this callback is to provide a function that gives precomputed hash values.
Sponsored by: Wheel Systems (http://www.wheelsystems.com)
Martin Fleisz [Thu, 18 May 2017 07:49:36 +0000 (09:49 +0200)]
Merge pull request #3964 from akallabeth/update_reset_state_fix
Update reset state fix
Armin Novak [Wed, 17 May 2017 13:58:44 +0000 (15:58 +0200)]
Fixed missing state reset.
Armin Novak [Wed, 17 May 2017 13:58:32 +0000 (15:58 +0200)]
Fixed missing argument checks.
Martin Fleisz [Tue, 16 May 2017 07:37:49 +0000 (09:37 +0200)]
Merge pull request #3957 from akallabeth/gfx_use_logger_instance
Use a preallocated logger instance for GFX
Armin Novak [Mon, 15 May 2017 15:24:47 +0000 (17:24 +0200)]
Use a preallocated logger instance for GFX
The static logger functions of WLog have quite a heavy performance
penalty. Use a pointer to an allocated logger to speed things up.
David Fort [Mon, 15 May 2017 11:56:07 +0000 (13:56 +0200)]
Merge pull request #3942 from akallabeth/shift_warn_fix
Fixed right shift on 32bit platforms.
akallabeth [Mon, 15 May 2017 09:54:57 +0000 (11:54 +0200)]
Merge pull request #3953 from hardening/kill_warnings
Drop some annoying warning
David Fort [Fri, 12 May 2017 09:11:41 +0000 (11:11 +0200)]
Drop some annoying warning
Probably that some unused functions should be removed, but at least it makes
it compile with no warnings.
David Fort [Fri, 12 May 2017 08:23:08 +0000 (10:23 +0200)]
Merge pull request #3952 from akallabeth/set_keyboard_ime
Added support for Set Keyboard IME Status
akallabeth [Fri, 12 May 2017 07:51:17 +0000 (09:51 +0200)]
Merge pull request #3950 from hypherion2/cp_fixes
Fix handle leaks in encomsp and remdesk server
Armin Novak [Fri, 12 May 2017 07:43:58 +0000 (09:43 +0200)]
Added support for Set Keyboard IME Status
Adrian A [Thu, 11 May 2017 20:21:47 +0000 (13:21 -0700)]
Fix handle leaks in encomsp and remdesk server
Ensure proper thread cleanup when these channel servers are stopped.
Martin Fleisz [Thu, 11 May 2017 11:59:00 +0000 (13:59 +0200)]
Merge pull request #3949 from akallabeth/gdi_surface_crash_fix
Check arguments for Bitmap_SetSurface
David Fort [Thu, 11 May 2017 11:49:06 +0000 (13:49 +0200)]
Merge pull request #3948 from hypherion2/master
Remove library prefix override for rdpei-server
Armin Novak [Thu, 11 May 2017 11:34:37 +0000 (13:34 +0200)]
Check arguments for Bitmap_SetSurface
The function may be called during connection phase
where there is no valid GDI available.
David Fort [Wed, 10 May 2017 19:22:18 +0000 (21:22 +0200)]
Merge pull request #3947 from akallabeth/openh264_fixes
Openh264 fixes
Adrian A [Wed, 10 May 2017 16:56:37 +0000 (09:56 -0700)]
Remove library prefix override for rdpei-server
This library was missed in commit
059374457d801351d02ac81badb4aabbfa7689e7, so it was the only one that
stilll had a lib prefix
Armin Novak [Wed, 10 May 2017 12:37:03 +0000 (14:37 +0200)]
Added 64bit file support flag for linux.
Armin Novak [Wed, 10 May 2017 10:36:08 +0000 (12:36 +0200)]
Initialize H264 context size for GFX surfaces.
Armin Novak [Wed, 10 May 2017 10:35:20 +0000 (12:35 +0200)]
Added pkg-config to cmake OpenH264 detection.
akallabeth [Tue, 9 May 2017 09:16:12 +0000 (11:16 +0200)]
Merge pull request #3937 from hardening/h264_multimon
Fix h264 in multimon scenario
Bernhard Miklautz [Tue, 9 May 2017 07:42:20 +0000 (09:42 +0200)]
Merge pull request #3931 from hypherion2/master
Remove unused buffer in Mac shadow subsystem
akallabeth [Mon, 8 May 2017 14:28:58 +0000 (16:28 +0200)]
Merge pull request #3943 from chipitsine/cppcheck
resolve an issue identified by cppcheck:
akallabeth [Mon, 8 May 2017 08:17:27 +0000 (10:17 +0200)]
Merge pull request #3941 from mfleisz/fix_openh264_mt
codec: Fix multi-threading support for OpenH264 1.6 or later
Ilya Shipitsin [Fri, 5 May 2017 19:05:59 +0000 (00:05 +0500)]
resolve an issue identified by cppcheck:
[channels/urbdrc/client/libusb/libusb_udevice.c:1666] -> [channels/urbdrc/client/libusb/libusb_udevice.c:1661]: (warning) Either the condition 'request' is redundant or there is possible null pointer dereference: request.
Martin Fleisz [Fri, 5 May 2017 10:37:27 +0000 (12:37 +0200)]
codec: Fix multi-threading support for OpenH264 1.6 or later
Martin Fleisz [Thu, 4 May 2017 08:53:50 +0000 (10:53 +0200)]
Merge pull request #3924 from akallabeth/gfx_surface_area_update_callback
Added a GFX area update callback.
Armin Novak [Thu, 4 May 2017 07:20:10 +0000 (09:20 +0200)]
Fixed right shift on 32bit platforms.
akallabeth [Wed, 3 May 2017 13:39:40 +0000 (15:39 +0200)]
Merge pull request #3930 from realjiangms/fix_shadow_thread_leak
server/shadow: close the thread handle so that it is detached becauseā¦
Armin Novak [Tue, 25 Apr 2017 11:58:23 +0000 (13:58 +0200)]
Added missing callbacks.
Bernhard Miklautz [Wed, 3 May 2017 07:28:18 +0000 (09:28 +0200)]
Merge pull request #3938 from chipitsine/cppcheck
resolve an issue identified by cppcheck:
Armin Novak [Wed, 19 Apr 2017 12:43:06 +0000 (14:43 +0200)]
Fixed use after free of region.
Armin Novak [Wed, 19 Apr 2017 11:00:26 +0000 (13:00 +0200)]
Added a GFX area update callback.
Ilya Shipitsin [Tue, 2 May 2017 20:32:44 +0000 (01:32 +0500)]
resolve an issue identified by cppcheck:
[server/shadow/X11/x11_shadow.c:386] -> [server/shadow/X11/x11_shadow.c:390]: (warning) Either the condition '!subsystem' is redundant or there is possible null pointer dereference: subsystem.
[server/shadow/X11/x11_shadow.c:387] -> [server/shadow/X11/x11_shadow.c:390]: (warning) Either the condition '!subsystem' is redundant or there is possible null pointer dereference: subsystem.
David Fort [Tue, 2 May 2017 16:39:03 +0000 (18:39 +0200)]
Fixed progressive code style and added error handling
David Fort [Mon, 1 May 2017 20:39:52 +0000 (22:39 +0200)]
Fix H264 in multi monitor case
The H264 context is surface specific, so in multi-monitor (with multiple surfaces)
the decoding was failing. This patch fixes that by introducing a surface specific
h264 context.
Martin Fleisz [Tue, 2 May 2017 14:10:34 +0000 (16:10 +0200)]
Merge pull request #3932 from chipitsine/cppcheck
resolve issues identified by cppcheck
David Fort [Tue, 2 May 2017 14:02:21 +0000 (16:02 +0200)]
Merge pull request #3911 from akallabeth/avc444_v2
Added AVC444v2 client support.
Bernhard Miklautz [Tue, 2 May 2017 11:03:37 +0000 (13:03 +0200)]
Merge pull request #3934 from ilammy/x11-cliprdr/rail-support
Teach RAIL to use clipboard redirection
Ilya Shipitsin [Mon, 1 May 2017 11:40:02 +0000 (16:40 +0500)]
resolve issues identified by cppcheck
[channels/drive/client/drive_file.c:125]: (error) Memory leak: path_slash
[server/Windows/wf_dxgi.c:195]: (error) Invalid number of character '(' when these macros are defined: 'WITH_DXGI_1_2'.
ilammy [Thu, 18 Aug 2016 18:14:52 +0000 (21:14 +0300)]
client/X11: teach RAIL to use clipboard redirection
XSelection protocol does not define any global clipboard as there is on
Windows. Instead each window has its own property for clipboard content
(like CLIPBOARD or PRIMARY) and there is a global notion of clipboard
ownership. Only one window can claim ownership of some clipboard type
at the moment.
FreeRDP uses CLIPBOARD for clipboard transfers (it's the one used by
applications when Ctrl+V is pressed). For regular desktop sessions the
session window itself is used for clipboard interactions via
xfc->drawable field. However, for remote app session there is no session
window. We cannot use the current remote app window as it may change or
be destroyed without closing the session. We also cannot use the root
window as it is already used for CF_RAW transfer protocol.
Therefore we create a simple dummy window to put into xfc->drawable for
this exact job: to act as a clipboard vessel on behalf of the entire
remote app session.
xf_create_window() usually creates the window as we immediately start in
RAIL mode when possible. xf_rail_enable_remoteapp_mode() is invoked only
when autologin failed or remote desktop had to show the session window
to the user for some reason.
Adrian A [Fri, 28 Apr 2017 22:24:59 +0000 (15:24 -0700)]
Remove unused buffer which leaks
The buffer is not used in the code.
Martin Fleisz [Thu, 27 Apr 2017 14:45:18 +0000 (16:45 +0200)]
Merge pull request #3925 from akallabeth/avc_mf_decoder_fix
Fixed MF H264 buffer allocation.
David Fort [Thu, 27 Apr 2017 12:11:51 +0000 (14:11 +0200)]
Merge pull request #3919 from akallabeth/rdpdr_hotplug_fix
Fixed hotplug mount locations.
Armin Novak [Thu, 27 Apr 2017 06:58:01 +0000 (08:58 +0200)]
Fixed FindFirstFileA, do not strip trailing slash
Bernhard Miklautz [Thu, 27 Apr 2017 06:55:39 +0000 (08:55 +0200)]
Merge pull request #3927 from DavBfr/fix-win-printer
Bugfix: wrong test regarding the first GetPrinter
Armin Novak [Thu, 27 Apr 2017 06:31:53 +0000 (08:31 +0200)]
Fixed memory corruption in Find*FileW
David PHAM-VAN [Tue, 25 Apr 2017 18:50:28 +0000 (11:50 -0700)]
Bugfix: wrong test regarding the first GetPrinter. This first call will always return FALSE because the goal of this call is to know the size needed.
akallabeth [Tue, 25 Apr 2017 08:30:42 +0000 (10:30 +0200)]
Merge pull request #3926 from ShaunMaher/master
WS_EX_NOACTIVATE treated as unmanaged
Shaun Maher [Sat, 22 Apr 2017 08:44:37 +0000 (18:44 +1000)]
WS_EX_NOACTIVATE treated as unmanaged\nWindows that carry the WS_EX_NOACTIVATE are treated the same as WS_EX_TOOLWINDOW in that they should not be handled as normal windows by the X window manager. The prevents an issue with MS Outlook 2013 (and probably other applications) where attempting to resize the vertical columns causes some sort of WS_EX_NOACTIVATE window to be created which steals focus and aborts the resizing action.
Armin Novak [Thu, 20 Apr 2017 10:02:04 +0000 (12:02 +0200)]
Fixed MF H264 buffer allocation.
David Fort [Wed, 19 Apr 2017 07:23:14 +0000 (09:23 +0200)]
Merge pull request #3923 from rjcorrig/kb4015193
winpr: Updates time zone data to April 2017
Armin Novak [Wed, 19 Apr 2017 06:28:00 +0000 (08:28 +0200)]
Fix #3922: Use stat insead of lstat
Armin Novak [Wed, 19 Apr 2017 06:27:22 +0000 (08:27 +0200)]
Cleaned up includes.
Robert Corrigan [Tue, 18 Apr 2017 20:15:13 +0000 (16:15 -0400)]
Update timezone data to Apr 2017
Armin Novak [Tue, 18 Apr 2017 13:08:44 +0000 (15:08 +0200)]
Fixed AVC444v2 NEON chroma decoder.
Armin Novak [Tue, 18 Apr 2017 13:03:38 +0000 (15:03 +0200)]
Fixed SSE AVC444v2 chroma decoder.
Armin Novak [Tue, 18 Apr 2017 12:12:40 +0000 (14:12 +0200)]
Added surface width and heigth for YUV combine.
Armin Novak [Tue, 18 Apr 2017 07:13:35 +0000 (09:13 +0200)]
Add legacy mount locations, limited max depth.
Armin Novak [Thu, 13 Apr 2017 14:20:01 +0000 (16:20 +0200)]
Fixed WCHAR/CHAR conversion for drive path.
Armin Novak [Thu, 13 Apr 2017 13:55:17 +0000 (15:55 +0200)]
Fixed hotplug mount locations.
Armin Novak [Thu, 13 Apr 2017 11:09:16 +0000 (13:09 +0200)]
Added SSE AVC444v2
Armin Novak [Wed, 12 Apr 2017 12:37:37 +0000 (14:37 +0200)]
Fixed AVC444 NEON, added AVC444v2.
zihao.jiang [Mon, 10 Apr 2017 18:25:36 +0000 (02:25 +0800)]
server/shadow: close the thread handle so that it is detached because no one is going to join it. Therefore the thread would release its resources automatically when exit
Norbert Federa [Tue, 11 Apr 2017 13:00:30 +0000 (15:00 +0200)]
Merge pull request #3901 from akallabeth/openssl_1_1_no_legacy
Fixed OpenSSL 1.1 no legacy compile issues.
akallabeth [Tue, 11 Apr 2017 11:44:36 +0000 (13:44 +0200)]
Merge pull request #3912 from nfedera/fix-gfx-gdihw-multimon
client/x11: fix gfx drawing bug with /multimon
Norbert Federa [Tue, 11 Apr 2017 10:50:15 +0000 (12:50 +0200)]
Merge pull request #3902 from akallabeth/file_leak_fix
Fixed a memory leak and bad free.
Norbert Federa [Tue, 11 Apr 2017 10:30:37 +0000 (12:30 +0200)]
client/x11: fix gfx drawing bug with /multimon
The surface's damage region is not relative to the output but
lives in its own universe starting at origin 0,0.
Also fixed the drawing coordinates used in the XRENDER code path
which is used with /smart-sizing
Armin Novak [Tue, 11 Apr 2017 09:40:04 +0000 (11:40 +0200)]
Upaded YUV tests.
Armin Novak [Tue, 11 Apr 2017 09:32:45 +0000 (11:32 +0200)]
Added error return in GetFileAttributesExA.
Armin Novak [Mon, 10 Apr 2017 15:16:57 +0000 (17:16 +0200)]
Added AVC444v2 client support.
Armin Novak [Thu, 6 Apr 2017 15:54:44 +0000 (17:54 +0200)]
Fixed broken scoping.
Armin Novak [Thu, 6 Apr 2017 15:46:07 +0000 (17:46 +0200)]
Fixed a memory leak and bad free.
David Fort [Thu, 6 Apr 2017 15:32:21 +0000 (17:32 +0200)]
Merge pull request #3864 from DavBfr/rewrite-disk-redirection
Rewrite disk redirection using WinPR
Armin Novak [Thu, 6 Apr 2017 08:37:28 +0000 (10:37 +0200)]
Fixed OpenSSL 1.1 no legacy compile issues.
Bernhard Miklautz [Thu, 6 Apr 2017 07:54:26 +0000 (09:54 +0200)]
Merge pull request #3897 from akallabeth/mac_os_fix
OSX: Updated RPATH settings for each lib.
Armin Novak [Thu, 6 Apr 2017 06:05:39 +0000 (08:05 +0200)]
Fixed RPATH settings for OS X
David PHAM-VAN [Wed, 5 Apr 2017 22:35:03 +0000 (15:35 -0700)]
Fix indentation
Norbert Federa [Wed, 5 Apr 2017 10:36:38 +0000 (12:36 +0200)]
Merge pull request #3899 from akallabeth/neon_fix
Fixed NEON YUV to RGB conversion issues.
Armin Novak [Wed, 5 Apr 2017 09:37:48 +0000 (11:37 +0200)]
Fixed NEON YUV to RGB conversion issues.
Bernhard Miklautz [Tue, 4 Apr 2017 05:44:38 +0000 (07:44 +0200)]
Merge pull request #3896 from nfedera/fix_gfx_progressive_decoding
rdpegfx: fix RemoteFX Progressive Codec decoding
Norbert Federa [Mon, 3 Apr 2017 16:59:58 +0000 (18:59 +0200)]
rdpegfx: fix RemoteFX Progressive Codec decoding
Since this comes via a Wire-To-Surface-2 PDU we don't have
any left/top/right/bottom destination values.
The current code has always dealt with zeros when updating the
invalid region which resulted in black rectangles.
The correct update region is determined during decompression.
David PHAM-VAN [Fri, 31 Mar 2017 22:33:28 +0000 (15:33 -0700)]
Fix FindFirstFile return values
Norbert Federa [Fri, 31 Mar 2017 11:24:10 +0000 (13:24 +0200)]
Merge pull request #3892 from akallabeth/x11_gfx_surface_update
Update changed rectangles instead of extent.
Norbert Federa [Fri, 31 Mar 2017 10:27:34 +0000 (12:27 +0200)]
Merge pull request #3894 from akallabeth/cache_to_surface_fix
Use exclusive coordinates in CacheToSurface.
Armin Novak [Fri, 31 Mar 2017 10:06:21 +0000 (12:06 +0200)]
Use exclusive coordinates in CacheToSurface.
Armin Novak [Thu, 30 Mar 2017 15:23:04 +0000 (17:23 +0200)]
Update changed rectangles instead of extent.
David Fort [Thu, 30 Mar 2017 14:59:39 +0000 (16:59 +0200)]
Merge pull request #3891 from nfedera/fix-rdpegfx-gdisw-drawing
improve rdpegfx drawing for software gdi
Norbert Federa [Thu, 30 Mar 2017 13:42:13 +0000 (15:42 +0200)]
improve rdpegfx drawing for software gdi
process the region's rectangles individually instead of
just copying the extents
David Fort [Wed, 29 Mar 2017 12:54:57 +0000 (14:54 +0200)]
Merge pull request #3865 from DavBfr/unicode-printer-name
Bugfix: Wrong encoding method used for printer name
Martin Fleisz [Wed, 29 Mar 2017 10:42:32 +0000 (12:42 +0200)]
Merge pull request #3886 from akallabeth/warning_fixes_and_tests
Fixes for AVC420, Warnings and tests
Armin Novak [Tue, 28 Mar 2017 15:56:44 +0000 (17:56 +0200)]
Fixed memory leak and return value check issue.
Armin Novak [Tue, 28 Mar 2017 15:42:35 +0000 (17:42 +0200)]
Fixed AVC420 SSE implementation and test.
Armin Novak [Tue, 28 Mar 2017 14:18:00 +0000 (16:18 +0200)]
Fixed tests and dead store warnings.
David Fort [Tue, 28 Mar 2017 13:06:10 +0000 (15:06 +0200)]
Merge pull request #3884 from akallabeth/memleak_fix
Fixed leak of client random.
Armin Novak [Tue, 28 Mar 2017 12:33:02 +0000 (14:33 +0200)]
Fixed leak of client random.
Norbert Federa [Tue, 28 Mar 2017 10:35:30 +0000 (12:35 +0200)]
Merge pull request #3883 from akallabeth/gfx_x11_speedup
Gfx x11 speedup
Armin Novak [Tue, 28 Mar 2017 09:49:47 +0000 (11:49 +0200)]
Let bitmaps keep XBitmap during lifetime.
Armin Novak [Tue, 28 Mar 2017 09:49:13 +0000 (11:49 +0200)]
X11 GFX: Restrict to region, ignore alpha
* Restrict the screen update to the changed region
* Ignore differences in color format alpha