profile/ivi/qtbase.git
12 years agoStore the is-a QObject fact with the metatype declaration.
Stephen Kelly [Fri, 30 Dec 2011 11:00:09 +0000 (12:00 +0100)]
Store the is-a QObject fact with the metatype declaration.

This is a source incompatible change for Q_DECLARE_METATYPE(T*),
which now requires T to be fully defined.

The consequences of this are:
 * Forward declared types can no longer be declared as a metatype.
     (though this is a very uncommon thing to do).

There is a trivial workaround where necessary.

Change-Id: Id74c40088b8c0b466fcd7c55abd616f69acc82c8
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoQKeySequence: add tests, fix handling of '+' as key or separator.
David Faure [Thu, 19 Jan 2012 11:40:52 +0000 (12:40 +0100)]
QKeySequence: add tests, fix handling of '+' as key or separator.

Change-Id: I3c471dff9b46025aab762d36bb3a3adc64ced561
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMake QUrl always lowercase the scheme().
David Faure [Tue, 24 Jan 2012 13:51:51 +0000 (14:51 +0100)]
Make QUrl always lowercase the scheme().

URL schemes can only contain alphanumeric characters and all
protocols specify that they are case-insensitive. So instead
of doing case-insensitive comparison everywhere and then get
it wrong sometimes, better to lower-case it here.

Change-Id: I61f51a3f4c85b90af1586ebcf69608987fbe2ec3
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRemove dependencies on removed "TEXTSTREAM" option (f65a10b733)
David Faure [Mon, 23 Jan 2012 10:04:24 +0000 (11:04 +0100)]
Remove dependencies on removed "TEXTSTREAM" option (f65a10b733)

Change-Id: If7d6ca7af8eb305bd127776a35223d50c1fb4f04
Reviewed-by: Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agouse QWinOverlappedIoNotifier in QWindowsPipeReader
Joerg Bornemann [Mon, 16 Jan 2012 11:26:40 +0000 (12:26 +0100)]
use QWinOverlappedIoNotifier in QWindowsPipeReader

Change-Id: I71d5feaa07e8febd6c562be1dc6d7790e3a1606c
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoQWinOverlappedIoNotifier introduced
Joerg Bornemann [Fri, 30 Dec 2011 14:20:32 +0000 (15:20 +0100)]
QWinOverlappedIoNotifier introduced

For asynchronous (overlapped) I/O notification on Windows one
can now use the convenience class QWinOverlappedIoNotifier.
It's using one global I/O completion port and a watching thread to
get notified when a read or write operation completes.

Change-Id: If6f904b364be0405580c7e50355529ab136ae3cb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoChanged qnetworkdiskcache unittest to cleanup test directory.
Kurt Korbatits [Mon, 23 Jan 2012 01:58:00 +0000 (11:58 +1000)]
Changed qnetworkdiskcache unittest to cleanup test directory.

- Remove foo directory tree after run.

Change-Id: I2d554b4c64fc7162c7717c840534cf77f5e744d0
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoChanged qtextdocument, qtextdocumentlayout unittests to cleanup tmp files.
Kurt Korbatits [Mon, 23 Jan 2012 01:44:49 +0000 (11:44 +1000)]
Changed qtextdocument, qtextdocumentlayout unittests to cleanup tmp files.

- qtextdocument unittest to remove foo.png after test.
- qtextdocumentlayout unittest to remove expected.png and img.png after test.

Change-Id: I42971e9128d399cadc87b9fd345c868065f180a9
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoChanged painting unittests to remove created files after run.
Kurt Korbatits [Mon, 23 Jan 2012 00:53:15 +0000 (10:53 +1000)]
Changed painting unittests to remove created files after run.

- qpainter cleans up temp files dest.png, expected.png and foo.png
- qpainterpath clean up temp file data
- qprinter cleans up silly, out1.ps, out2.ps, test.pdf and file.pdf

Change-Id: Id434bea0bae5b970355206a250456e4beeca8060
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoChanged qpixmap unittest to remove created file after run.
Kurt Korbatits [Mon, 23 Jan 2012 00:45:21 +0000 (10:45 +1000)]
Changed qpixmap unittest to remove created file after run.

- Removes temp_image.png after test run.

Change-Id: I0b233609c2bbf57151cf173181a40738d934f0ec
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoChanged qxmlstream unittest to remove its created file after run.
Kurt Korbatits [Mon, 23 Jan 2012 00:06:38 +0000 (10:06 +1000)]
Changed qxmlstream unittest to remove its created file after run.

- Removes test.xml after test completed.

Change-Id: I548e2d644cca8ae0d30c3002df45cf57433170af
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoChanged qdatastream unittest to remove the test file it creates.
Kurt Korbatits [Sun, 22 Jan 2012 23:59:35 +0000 (09:59 +1000)]
Changed qdatastream unittest to remove the test file it creates.

- Remove datastream.tmp file after test completed.

Change-Id: I844600f0a477397d129fd01ac755183c2d874da4
Reviewed-by: Kurt Korbatits <kurt.korbatits@nokia.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoAllocate mipmaps in FBOs with glTexImage2D, not glGenerateMipmap.
Kim Motoyoshi Kalland [Fri, 20 Jan 2012 12:40:33 +0000 (13:40 +0100)]
Allocate mipmaps in FBOs with glTexImage2D, not glGenerateMipmap.

Change-Id: I7b7d26da97f82f354d81913eccab46d79ec9e8f0
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agomkspecs: Remove qtopia*.prf from the mkspecs
Holger Hans Peter Freyther [Tue, 15 Nov 2011 18:59:01 +0000 (19:59 +0100)]
mkspecs: Remove qtopia*.prf from the mkspecs

Qtopia was killed some time ago and these files do not have a direct
use. Qt was embedded into the Qtopia sourcetree and it would be in the
hands of the Qt Extended fork to move to Qt5 and update the buildsystem.

It is unlikely that a Qt5 qmake will be used to build the Qt extended fork
as a copy of Qt is embedded in the source tree.

Change-Id: I2ef309c381aaf1d265ef385e85fd5c72d6205765
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoFixed automatic plugin path resolving for predefined Qt plugins.
Janne Anttila [Mon, 19 Sep 2011 17:10:14 +0000 (19:10 +0200)]
Fixed automatic plugin path resolving for predefined Qt plugins.

When Qt is configured for static build, importing static plugins is
supposed to work as described in docs:
http://doc.qt.nokia.com/latest/qtplugin.html#Q_IMPORT_PLUGIN

This commit updates the qmake mapping for predefined Qt plugins, so
that Qt plugins are automatically found when QTPLUGIN keyword is used.

Task-number: QTBUG-18609
Merge-request: 1391
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
(cherry picked from commit 0d0c1082f74888044713d96deca2d510951d018a)
Change-Id: I0d0c1082f74888044713d96deca2d510951d018a
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agoTest connecting to virtual function pointer
Olivier Goffart [Thu, 12 Jan 2012 20:53:56 +0000 (21:53 +0100)]
Test connecting to virtual function pointer

The C++ standard says that the comparison between pointer to virtual
function is unspecified (C++11 $5.10.2)
But we still may rely on it for the Qt::UniqueConnection and the
disconnection

So test if it works while using the same function.
Using function from different classes works for me, but we should
probably not assume it works. I left it commented in the test for
reference.

Change-Id: I1d9b91d4cc1a424d4f43ef2ee4981b8573f1e86f
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoMake it possible to compile with -no-opengl.
Andreas Holzammer [Mon, 23 Jan 2012 08:37:04 +0000 (09:37 +0100)]
Make it possible to compile with -no-opengl.

This takes out the dependency to the header files
of OpenGl. The ifdef QT_NO_OPENGL in the opengl headers
are needed, as qmake adds depends in the makefiles
for all GUI headers.

Task-number: QTBUG-23207

Change-Id: If31448ee35fd8c39194c7cb7d62273fbc6def883
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoRemove reference to Symbian in QtNetwork.
Xizhi Zhu [Mon, 23 Jan 2012 11:12:00 +0000 (12:12 +0100)]
Remove reference to Symbian in QtNetwork.

Change-Id: Iae377505e36ae1239be7ce52c773dc2a4f4a9767
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Symbian / S60 code from util.
Xizhi Zhu [Mon, 23 Jan 2012 11:05:01 +0000 (12:05 +0100)]
Remove Symbian / S60 code from util.

Change-Id: I00a151a5f23bb7258f78712cce569b324c92c7d7
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Symbian code from QtCore.
Xizhi Zhu [Sun, 22 Jan 2012 15:41:55 +0000 (16:41 +0100)]
Remove Symbian code from QtCore.

Change-Id: I9abdc674bcfa7bb38ce27c5213c5a672f59e63d5
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Symbian specific code from QtGui.
Xizhi Zhu [Sun, 22 Jan 2012 15:35:52 +0000 (16:35 +0100)]
Remove Symbian specific code from QtGui.

Change-Id: I103abb545d1a5deed7d40c0b50fc3eff0c89d622
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Symbian and Maemo code from uikit plugin.
Xizhi Zhu [Sun, 22 Jan 2012 15:35:27 +0000 (16:35 +0100)]
Remove Symbian and Maemo code from uikit plugin.

The code is only supposed to be used by iOS, so platform specific code
is removed.

Change-Id: Ibea585dfac9e6a7a87e66a1426793dfd8713fdef
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Qt 5 notes that would result in source incompatibility unnecessarily.
Robin Burchell [Fri, 20 Jan 2012 00:38:40 +0000 (02:38 +0200)]
Remove Qt 5 notes that would result in source incompatibility unnecessarily.

Change-Id: Ib221ab078f9ff5c385d35699ee1d093b0e95557c
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Thorbjørn Lund Martsum <tmartsum@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAdd the capability to use multiple data sources for qhash benchmark.
Robin Burchell [Thu, 19 Jan 2012 23:54:43 +0000 (01:54 +0200)]
Add the capability to use multiple data sources for qhash benchmark.

More data sources to be added in followup commits.

Change-Id: I0393119b36ac5d88fc2c5c8d46b000d13d5ca996
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoRemove executive summary.
Robin Burchell [Thu, 19 Jan 2012 23:28:46 +0000 (01:28 +0200)]
Remove executive summary.

It isn't necessarily that hashing the whole string is the main problem, as the
recently added java string benchmark appears to show, which means the original
purpose of this benchmark is rather voided.

This removal allows gradually repurposing the test towards providing general
benchmarks of QHash performance.

Change-Id: Iaab0a3b493387dcce99240632342235ed9c44d88
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agoMove test files around.
Robin Burchell [Thu, 19 Jan 2012 23:27:46 +0000 (01:27 +0200)]
Move test files around.

main.cpp is easier for my muscle memory to remember than qhash_string as it is
used by a number of other tests.

Change-Id: I044f995d55a4ff1328dde0ae27b6e36a80114c38
Reviewed-by: Richard J. Moore <rich@kde.org>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agoAdd missing documentation to QTemporaryDir constructors
David Faure [Mon, 23 Jan 2012 14:29:49 +0000 (15:29 +0100)]
Add missing documentation to QTemporaryDir constructors

Change-Id: Ic7dea331695fa4653e4b963fef8383f44c3b1fb8
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoMake QAbstractSocket's API virtual where needed.
Jonas M. Gastal [Thu, 19 Jan 2012 19:02:51 +0000 (17:02 -0200)]
Make QAbstractSocket's API virtual where needed.

The following methods have been made virtual:
setReadBufferSize()
socketDescriptor()
setSocketDescriptor()
socketOption()
setSocketOption()
waitForConnected()
waitForDisconnected()

Now that these methods are virtual we no longer need the nasty
polymorphism workarounds for QSslSocket.

Change-Id: I319989b6cdb025ba33d7d53ae90f3a6a3b6b1b7b
Reviewed-by: Richard J. Moore <rich@kde.org>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort the IA-64 atomics to the new QBasicAtomicXXX architecture
Thiago Macieira [Sun, 31 Jul 2011 22:14:42 +0000 (19:14 -0300)]
Port the IA-64 atomics to the new QBasicAtomicXXX architecture

The IA-64 architecture supports the actual memory ordering semantics
in many instructions, but not all. We actually implement the functions
for all operations, so we get the best possible output.

It does support proper load-acquire and store-release semantics, but
we don't need instructions for it: the ABI requires that a volatile
load be acquire and a volatile store be release.

The Intel and HP compiler codepaths are rewritten, but untested.

Change-Id: I7aa62a4ec65f63a97d1bbd8418bb2492c2be465f
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort the MIPS atomics to the new QBasicAtomicXXX architecture
Thiago Macieira [Sun, 31 Jul 2011 22:09:20 +0000 (19:09 -0300)]
Port the MIPS atomics to the new QBasicAtomicXXX architecture

The LL/SC instructions are only present on MIPS II and up, so don't
pretend to support MIPS I. The previous implementation emitted the
instructions by telling the assembler to change instruction sets. Now,
the user must pass an -march= option to GCC telling it which
architecture or processor is being targetted.

On MIPS64, the 64-bit implementation allows supporting for long long
too.

Change-Id: I6dae6f8f61e563aba6a663227d91c5ddf554aa6a
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort the ARM atomics to the new QBasicAtomicXXX architecture
Thiago Macieira [Sun, 31 Jul 2011 21:57:16 +0000 (18:57 -0300)]
Port the ARM atomics to the new QBasicAtomicXXX architecture

The implementation is divided in two files, as it used to be in the
previous implementation: one for ARMv5, one for ARMv6 and up.

For the ARMv5 implementation:

    Drop the non-Linux EABI version of the atomics, as it's not
    ABI-compatible with the ARMv6 and ARMv7 implementations. This
    means this ARMv5 implementation only works on Linux. If other
    systems implement kernel helpers like Linux, they can be added
    too.

    We use the __kernel_cmpxchg located at 0xffff0fc0 to implement the
    operations, except for fetchAndStore, for which we use the SWP
    instruction.

    Also introduce the use of __kernel_dmb (at 0xffff0fa0) for the
    memory barrier. Now this code is SMP-safe even when built with
    ARMv5.

    The kernel cmpxchg helper was introduced in Linux 2.6.12, whereas
    the dmb helper was introduced in 2.6.15. That means 2.6.15 is the
    minimum version now.

For ARMv6 and up:

    Introduce byte, half-word and doubleword atomics that work on
    ARMv6K and up.

    For ARMv6 specifically, the memory barrier instruction (DMB) isn't
    present, so we need to accomplish the same with the MCR
    coprocessor instruction.

Change-Id: Ife7f9b920bcc7d1eef7611761f6c59ea940ec7df
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoMake clang compile the new i386 and x86_64 atomic code
Bradley T. Hughes [Wed, 18 Jan 2012 14:38:16 +0000 (15:38 +0100)]
Make clang compile the new i386 and x86_64 atomic code

The input type needs to match the output type, otherwise we get this
error:

src/corelib/arch/qatomic_x86_64.h:288:25: error: unsupported inline asm:
      input with type '<dependent type>' matching output with type 'T':
                   "0" (valueToAdd * QAtomicAdditiveType<T>::AddScale)
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I26d4efdbcab089dea71ef08e3e65df5b7482865a
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort the i386 and x86-64 atomics to the new QBasicAtomic architecture
Thiago Macieira [Sun, 31 Jul 2011 21:38:00 +0000 (18:38 -0300)]
Port the i386 and x86-64 atomics to the new QBasicAtomic architecture

Both implementations now are very similar to one another, to the point
we could share the code if we wanted to. They are based on assembly
code for the Relaxed functions only, as the i386 and x86-64
architectures only allow for full memory ordering or something that
closely resembles it (see 8.2 "Memory ordering" in the Intel 64 and
IA-32 Architectures Software Developer's Manual Volume 3A). We could
add "lfence/mfence/sfence" in future versions if we wanted to (SSE2+).

Change-Id: I76966d9f8694edfece2c5ebd3387348fac721447
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort the bootstrap atomics to the new QBasicAtomic architecture
Thiago Macieira [Sun, 31 Jul 2011 21:25:24 +0000 (18:25 -0300)]
Port the bootstrap atomics to the new QBasicAtomic architecture

The code is now much simpler and much more complete. Now the bootstrap
atomics (which aren't atomic at all) contain the full set of
operations.

The only integer supported is int, but all others would work too.

Change-Id: Id99f07818f9da059c4ff02520f9cbf2d1a71a514
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRemove QEventLoop::DeferredDeletion
Bradley T. Hughes [Thu, 19 Jan 2012 10:53:09 +0000 (11:53 +0100)]
Remove QEventLoop::DeferredDeletion

This flag has been deprecated since Qt 4.4, so remove it.
tst_QApplication had 2 nearly identical tests, one for testing the
QEventLoop::DeferredDeletion flag, and one to test sendPostedEvents()
with QEvent::DeferredDelete. The latter is the preferred way, so keep
that test, but remove the test for the obsoleted flag.

Change-Id: Icdb7483c32b3c920bda31d2bbb4f7414ece6d826
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoMove Clang mkspec for Mac OS X out of unsupported
Tor Arne Vestbø [Mon, 23 Jan 2012 12:17:23 +0000 (13:17 +0100)]
Move Clang mkspec for Mac OS X out of unsupported

The plan is to make it the default mkspec for Qt 5 on Mac OS X.

Change-Id: I49cf619a06fd7155dfbddc377558327b4be09cef
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoSet macosx-version-min in common Mac OS X mkspec instead of configure
Tor Arne Vestbø [Mon, 23 Jan 2012 11:54:38 +0000 (12:54 +0100)]
Set macosx-version-min in common Mac OS X mkspec instead of configure

When set in configure it would be written to .qmake.cache and would only
apply when building Qt. We then had an override (that was also out of
sync, version-wise) in the g++ mkspec, which would also apply to apps
building agains Qt. This override did howerver not apply when using
the Clang mkspec.

We now move setting macosx-version-min to the common macx mkspec, shared
by both g++ and Clang, which will apply both when building Qt and when
building something against Qt. The latter since an application built
against Qt will not deploy on versions of Mac OS earlier than 10.6
anyways, so we might as well always set the minimum-version.

The modifications to the mkspecs will result in macosx-version-min
being passed twice when compiling qmake, as configure writes its own
makefiles and the mkspec parsing in configure has a bug where it will
lazily evaluate qmake-variables instead of evaluating them inline. This
is not a problem, and can be fixed in a later patch if seen fit.

Change-Id: Ib29503ad00a9dc00e0a50b0dbd9459e89a20dfbd
Reviewed-by: Zeno Albisser <zeno.albisser@nokia.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoIgnore known tst_QStyleSheetStyle failures on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 13:36:07 +0000 (14:36 +0100)]
Ignore known tst_QStyleSheetStyle failures on Mac OS X

Task-number: QTBUG-23686
Change-Id: I566f3b3491576325389862bac2ad7c8526dd930b
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoIgnore tst_QStyleSheetStyle::hoverColors() failures on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 13:33:20 +0000 (14:33 +0100)]
Ignore tst_QStyleSheetStyle::hoverColors() failures on Mac OS X

Qt::WA_UnderMouse is not working at the moment, causing this test to
fail.

Task-number: QTBUG-23685
Change-Id: If167311b09ba8fc3d04d056590588b595825c443
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoIgnore tst_QSizeGrip failures on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 12:33:59 +0000 (13:33 +0100)]
Ignore tst_QSizeGrip failures on Mac OS X

This test currently fails on Mac, mark it as insignificant.

Task-number: QTBUG-23681
Change-Id: I7355cda953966778d651fafaff837f1083eeb3f4
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoSkip tst_QMenu::QTBUG_10735_crashWithDialog() on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 11:51:46 +0000 (12:51 +0100)]
Skip tst_QMenu::QTBUG_10735_crashWithDialog() on Mac OS X

This test currently hangs, preventing the autotest from finishing.

Task-number: QTBUG-23677
Change-Id: I3c5f56c10735d65fb35de4e22a1e2e6414532309
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoIgnore tst_QMenu::keyboardNavigaction() failure on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 13:28:12 +0000 (14:28 +0100)]
Ignore tst_QMenu::keyboardNavigaction() failure on Mac OS X

The shortcut0 test data fails, indicating that keyboard navigation via
shortcuts doesn't work on Mac OS X for the time being. Mark the failure
as expected.

Task-number: QTBUG-23684
Change-Id: I199222a87c09e6f491e5dcd21c9f65c28ecbb86d
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoSkip tst_QPushButton::sizeHint() with Mac style on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 12:26:41 +0000 (13:26 +0100)]
Skip tst_QPushButton::sizeHint() with Mac style on Mac OS X

QStyleFactory cannot create the Mac style, so skip the test for now.

Task-number: QTBUG-23680
Change-Id: I2ae61aab152cd8a4e6a7270902df40dd3cc6df3b
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoMark tst_QDateTimeEdit with insignificant_test on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 09:30:51 +0000 (10:30 +0100)]
Mark tst_QDateTimeEdit with insignificant_test on Mac OS X

This tests has numerous failures on Mac OS X, ignore the test for now.

Task-number: QTBUG-23674
Change-Id: I29bcfd379a6a13f9859e96c5cc6dc7e932feaf4a
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoMark tst_QComboBox::hide() with QEXPECT_FAIL() on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 11:54:05 +0000 (12:54 +0100)]
Mark tst_QComboBox::hide() with QEXPECT_FAIL() on Mac OS X

Task-number: QTBUG-23678

Change-Id: I6ced2aa9392f2688ee982113addef7fffcf4b9f2
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoIgnore tst_QAbstractSlider failures on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 13:29:22 +0000 (14:29 +0100)]
Ignore tst_QAbstractSlider failures on Mac OS X

Mark current failures as expected.

Task-number: QTBUG-23679
Change-Id: Ic574dbb0fea3a21ef9963ef16bdf85da4c809036
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoUse QObject pointer as QCocoaAccessibleElement id.
Morten Johan Sorvig [Thu, 19 Jan 2012 06:49:48 +0000 (07:49 +0100)]
Use QObject pointer as QCocoaAccessibleElement id.

Each QCocoaAccessibleElement needs to provide a
unique stable id through the -(NSUnterger)hash
method.

The previous approach of basing the hash on the parent
hash plus the child index is unpractical now that
childAt() can return distant descendants instead
of immediate children only. Use the QObject pointer,
which is set for all accessible interfaces today.

Change-Id: I5868e3a81c1b4da7233504f30003ab8060e9fa3f
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoFix synthesizing mouse events when touches change ordering
Laszlo Agocs [Mon, 23 Jan 2012 08:28:58 +0000 (10:28 +0200)]
Fix synthesizing mouse events when touches change ordering

There is no guarantee the touches will be listed in the same order in
an update: the platform/generic plug-in, the drivers, etc. are all
free to shuffle the list of touch points in each report (even though
the order is fairly stable with most systems).

Therefore, to be safe, move and release events should be generated not
from the first point in the list but from the one with the matching
id.

Change-Id: I6615224cbf2cfdc440143eb3191482a23d85c6a4
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRevert "Blow up earlier when adding test rows without columns."
Robin Burchell [Mon, 23 Jan 2012 10:32:22 +0000 (12:32 +0200)]
Revert "Blow up earlier when adding test rows without columns."

This seems to break a number of tests using the qmltest library.
Functionality will be restored in a future commit, once the breakage has been
identified.

This reverts commit fdedb49b76b8f9ad69611fbfea6b8371ae1ec3a1.

Task-number: QTBUG-23845
Change-Id: I0ca4dbd54132e4250702f06738edbad5e8fc4f36
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
12 years agoQPropertyAnimation::setTargetObject() fails if new and old target object have the...
Armin Berres [Thu, 10 Nov 2011 16:34:55 +0000 (17:34 +0100)]
QPropertyAnimation::setTargetObject() fails if new and old target object have the same address

If a target object is destroyed QPropertyAnimationPrivate::targetValue
reflects this while QPropertyAnimationPrivate::target stays unchanged.
QPropertyAnimation::setTargetObject() checks if a new target matches
QPropertyAnimationPrivate::target - to bad if the former target has
been destroyed in the meanwhile but the new one has the same memory
address. targetValue is not updated in this case. It will still point
to null and QPropertyAnimation::targetObject() returns 0.
This is not just a theoretical problem - we stubled upon this in
Harmattan when suddenly animations complained that they are having no
target.

Change-Id: Ib4a9c234d04d6f8a3f7aed251d5e79471d95168a
Reviewed-by: Leonardo Sobral Cunha <leo.cunha@nokia.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agodirectfb: Deal with Qt trying to create a QSize(0, 0) platfom window
Holger Hans Peter Freyther [Mon, 23 Jan 2012 11:11:42 +0000 (12:11 +0100)]
directfb: Deal with Qt trying to create a QSize(0, 0) platfom window

Qt will attempt to create a platform window with the above size and
DirectFB will fail to create the window. Make sure the width/height
is at least 1 before handing it to DirectFB.

According to Samuel it is legitimate to create a QPlatformWindow  with
QSize(0, 0) and it is the job of the platform plugin to make it work.
Follow the approach of the XCB plugin and increase the size.

Change-Id: Ifc92780b46f1a73123945988d06bd21a3deb6bb0
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove uses of qMalloc/qFree from out of line code.
Robin Burchell [Sat, 21 Jan 2012 14:09:51 +0000 (16:09 +0200)]
Remove uses of qMalloc/qFree from out of line code.

There is no need to use these, and we are trying to deprecate them.

Change-Id: I70e6f27aca322fe74c31d8ad8496f230cd29e503
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
12 years agoFixed qtmodule-configtests on Windows.
Friedemann Kleint [Wed, 18 Jan 2012 10:02:48 +0000 (11:02 +0100)]
Fixed qtmodule-configtests on Windows.

open() to "|-" and "-|" are unsupported on Windows (see `perldoc
perlport'), so don't do that.

Let the tests write a 'config.log' file which contains the output
of the test commands.

Brings back the part fixing the pipe logic from commit
f865dc1ae44c88f6965acd09bafb01829c35447b which was reverted.

Change-Id: I5060a0885702d925001b98f2d4e84743d6ff226e
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
12 years agoWindows: Implement native event filters.
Friedemann Kleint [Fri, 20 Jan 2012 15:49:44 +0000 (16:49 +0100)]
Windows: Implement native event filters.

Change-Id: Ibdf556428e4dbb9156c87504b923ec9600bcf871
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
12 years agoXCB: Introduce enumeration for event filter types.
Friedemann Kleint [Sun, 22 Jan 2012 20:05:06 +0000 (21:05 +0100)]
XCB: Introduce enumeration for event filter types.

Remove QByteArray-construction and hash lookup in the event
handling; use an enumeration indexing an array instead.

Change-Id: I4d272b32a5ff71c8da58197cf3a0b38c1e61d489
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
12 years agoMark QTriangulatingStroker as Q_GUI_EXPORT
Alex Wilson [Mon, 23 Jan 2012 07:02:38 +0000 (17:02 +1000)]
Mark QTriangulatingStroker as Q_GUI_EXPORT

Change-Id: I6083ba122c33769cd4626f2c4a32959e535da8a4
Reviewed-by: Kim M. Kalland <kim.kalland@nokia.com>
12 years agoqfilesystemengine_win.cpp: compile with namespaced Qt
Joerg Bornemann [Sat, 21 Jan 2012 17:04:23 +0000 (18:04 +0100)]
qfilesystemengine_win.cpp: compile with namespaced Qt

SidCleanup struct must not be in the INCLUDE_NAMESPACE.

Change-Id: Ic51f1734af583c0ba7f715f7b27f314211e698c5
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: hjk <qthjk@ovi.com>
12 years agoxcb: Correctly check the X11 connection
Uli Schlachter [Sun, 22 Jan 2012 20:03:12 +0000 (21:03 +0100)]
xcb: Correctly check the X11 connection

Commit e08453f31ae2a195f86a763f0b1c5e617df0e1ce added a check which makes
sure qt prints an error message instead of segfaulting when it can't
connect to the X11 server.

However, libxcb will never return NULL from xcb_connect() and thus that
commit only works if XCB_USE_XLIB is defined and used.

Change-Id: I8cc1496494a94f07055a3ac5093ce362dd347c5b
Signed-off-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove Symbian specific code from QtXml.
Xizhi Zhu [Sun, 22 Jan 2012 15:35:03 +0000 (16:35 +0100)]
Remove Symbian specific code from QtXml.

Change-Id: I29979c80e401f5d6c2c2b38c4e502340f2025a12
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoRemove Symbian specific code from QtSql.
Xizhi Zhu [Sun, 22 Jan 2012 15:34:40 +0000 (16:34 +0100)]
Remove Symbian specific code from QtSql.

Change-Id: I3fc538862c7334914ec9e4331ef2d3db5c699ea9
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoxcb: Don't crash on missing mouse pointer
Uli Schlachter [Sun, 22 Jan 2012 19:41:42 +0000 (20:41 +0100)]
xcb: Don't crash on missing mouse pointer

The draganddrop examples all crashed here because they were using a
default-constructed QImage() (i.e. one without any content).

I guess this happens here because I don't have any mouse theme set.
To test, one could start a second X server, but without any WM or DE.

The "evil" QImage() came from QGuiApplicationPrivate::getPixmapCursor().
This function seems to just always "return QPixmap();".

This fix is correct because the only caller has another fallback if the
createNonStandardCursor()-fallback didn't work. This caller is
QXcbCursor::createFontCursor().

Change-Id: I7ec7fbcfdf0203e983149b5e73016cc7e85ecf40
Signed-off-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoRemove dead code.
Richard Moore [Sun, 22 Jan 2012 21:03:27 +0000 (21:03 +0000)]
Remove dead code.

Task-number: QTBUG-23524
Change-Id: I6a80af450b599022e9242cccec945887b871f2b0
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoRemove invalid comment.
Richard Moore [Sun, 22 Jan 2012 22:18:29 +0000 (22:18 +0000)]
Remove invalid comment.

No point in making this protected: it breaks existing code including
the unit tests, and the base class has this method as public.

Task-number: QTBUG-23524
Change-Id: I8fae019088fc368213ff7caa4b19fe7ab60488dd
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoExpect tst_QWizard::setPixmap() failure on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 07:49:49 +0000 (08:49 +0100)]
Expect tst_QWizard::setPixmap() failure on Mac OS X

Task-number: QTBUG-23701

Change-Id: Iba5b926e57c1565856d17bbfbff4d1da75645ad4
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoExpect tst_QFileDilaog:clearLineEdit() failure on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 08:05:00 +0000 (09:05 +0100)]
Expect tst_QFileDilaog:clearLineEdit() failure on Mac OS X

Task-number: QTBUG-23703

Change-Id: I981de80d6946d3637c493bede0adb1b90a539261
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoDo not expect tst_QFileDialog::selectFiles() failure on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 07:55:54 +0000 (08:55 +0100)]
Do not expect tst_QFileDialog::selectFiles() failure on Mac OS X

This test no longer fails:

XPASS  : tst_QFiledialog::selectFiles() '!listView->selectionModel()-
   Loc: [tst_qfiledialog.cpp(915)]

Change-Id: Ib790c0f81b3d383117cceceaacbf0c3d6a673404
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoDo not mark tst_QGraphicsWidget as insignificant anymore
Bradley T. Hughes [Wed, 18 Jan 2012 07:40:03 +0000 (08:40 +0100)]
Do not mark tst_QGraphicsWidget as insignificant anymore

Allow new failures in this test to block CI.

Change-Id: I1c7e797740be2f77f82d00943f6f2018b686481f
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoExpect tst_QGraphicsWidget::updateFocusChain...() failure on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 07:39:00 +0000 (08:39 +0100)]
Expect tst_QGraphicsWidget::updateFocusChain...() failure on Mac OS X

tst_QGraphicsWidget::updateFocusChainWhenChildDie() currently fails due
to what appears to be window activation.

Task-number: QTBUG-23699
Change-Id: I404f90d32dba64d558598d97cf805b6c025e6456
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoFix XPASS in tst_QGraphicsWidget on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 07:30:53 +0000 (08:30 +0100)]
Fix XPASS in tst_QGraphicsWidget on Mac OS X

Don't expect failure from these 2 tests anymore:

XPASS  : tst_QGraphicsWidget::initStyleOption(all) COMPARE()
   Loc: [tst_qgraphicswidget.cpp(1162)]
XPASS  : tst_QGraphicsWidget::initialShow2() COMPARE()
   Loc: [tst_qgraphicswidget.cpp(3196)]

Change-Id: Ibd1178f8cab480fa9fad9c829083a4862749c60b
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoFix XPASS in tst_QGraphicsView on Mac OS X
Bradley T. Hughes [Tue, 17 Jan 2012 13:43:47 +0000 (14:43 +0100)]
Fix XPASS in tst_QGraphicsView on Mac OS X

These tests now fail with XPASS on Mac OS X, so remove/skip the
QEXPECTED_FAIL(). Unfortunately we don't know which commit fixed this.

Change-Id: Id919a2c9d56fd7c4dee8ccb8aa3293efdce603b2
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoExpect tst_QGraphicsProxyWidget::updateAndDelete() failure on Mac OS X
Bradley T. Hughes [Wed, 18 Jan 2012 07:42:54 +0000 (08:42 +0100)]
Expect tst_QGraphicsProxyWidget::updateAndDelete() failure on Mac OS X

Task-number: QTBUG-23700

Change-Id: Ic472cea966761afc1e6e17479588b8b53ec4786c
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoReplace Q_WS_MAC with Q_OS_MAC in tests/auto/widgets
Bradley T. Hughes [Mon, 16 Jan 2012 10:49:53 +0000 (11:49 +0100)]
Replace Q_WS_MAC with Q_OS_MAC in tests/auto/widgets

tst_qwidget.cpp will not build/link without tst_qwidget_mac_helpers.mm,
so re-add it to the build as well.

Change-Id: I55130f62c215c4b82683d90456e31fdb09f833a8
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoBlow up earlier when adding test rows without columns.
Robin Burchell [Thu, 19 Jan 2012 23:55:51 +0000 (01:55 +0200)]
Blow up earlier when adding test rows without columns.

Previously, the assertation triggered was rather unhelpful:
 QFATAL : tst_QHash::qhash_qt4() ASSERT: "d->dataCount <
  d->parent->elementCount()" in file qtestdata.cpp,  line 88"

We now try a bit harder to be user-friendly.

Change-Id: I2e3a5ae27914d44fc1dc89af2a084e3d798fe221
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
12 years agoUpdate obsolete contact address.
Jason McDonald [Fri, 20 Jan 2012 03:21:44 +0000 (13:21 +1000)]
Update obsolete contact address.

Replace Nokia contact email address with Qt Project website.

Change-Id: Id689fdb78727abafba033bed7b0402e2cf27aba1
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoUpdate contact information in license headers.
Jason McDonald [Fri, 20 Jan 2012 03:06:31 +0000 (13:06 +1000)]
Update contact information in license headers.

Replace Nokia contact email address with Qt Project website.

Change-Id: I431bbbf76d7c27d8b502f87947675c116994c415
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoMark tst_qhostinfo as insignificant on Linux.
Rohan McGovern [Mon, 23 Jan 2012 00:28:06 +0000 (10:28 +1000)]
Mark tst_qhostinfo as insignificant on Linux.

This test sometimes gives different results on consecutive runs, and is
therefore insignificant for the purpose of regression detection.

Task-number: QTBUG-23837
Change-Id: I8747972c5cb7952089c54cbd22e1660db551e2f5
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
12 years agoRemove dependency of QtDBus onto QtXml
Harald Fernengel [Wed, 18 Jan 2012 20:28:31 +0000 (21:28 +0100)]
Remove dependency of QtDBus onto QtXml

Replace the QDom based code in qdbusxmlparser
with code using QXmlStreamReader.

Task-number: QTBUG-20856
Change-Id: I294e3ebd6faa813c20806be3ae225ac00befb622
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoObsolete QInputDialog::getInteger() 'officially'.
Robin Burchell [Fri, 20 Jan 2012 00:30:02 +0000 (02:30 +0200)]
Obsolete QInputDialog::getInteger() 'officially'.

It has long since been obsolete in code and removed from the documentation, but
was never marked QT_DEPRECATED. Do so, and inline the implementation.

Change-Id: Ic7bfdaf76269b7f9addeba83e64bc9525c581dda
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoUpdate the documentation for bearer.
Xizhi Zhu [Sat, 21 Jan 2012 19:48:39 +0000 (20:48 +0100)]
Update the documentation for bearer.

Removed the reference to Symbian plugin, and added the reference to
ConnMan / oFono plugin.

Change-Id: I6a2ea9159aaa05bf4109bae97889d126a324ef8b
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Alex <alex.blasche@nokia.com>
12 years agoMerge overloads of QInputDialog::getText() and QInputDialog::getItem()
Robin Burchell [Sat, 21 Jan 2012 17:37:39 +0000 (19:37 +0200)]
Merge overloads of QInputDialog::getText() and QInputDialog::getItem()

Change-Id: Ifaefaa5c3faa698c8570da4ef00e130c211b2609
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoMerge overloads of QFontDialog::getFont().
Robin Burchell [Fri, 20 Jan 2012 00:23:16 +0000 (02:23 +0200)]
Merge overloads of QFontDialog::getFont().

Per Qt 5 comment. Note that this leaves one overload of getFont() intact, as
removing it would be a source-incompatible change.

Change-Id: Ieb6ddfef9aa86750c14928ab2e0a9bfb84d322ab
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
12 years agoRemove note about source-incompatible change.
Robin Burchell [Fri, 20 Jan 2012 00:17:09 +0000 (02:17 +0200)]
Remove note about source-incompatible change.

There's no real gain to be had from doing this.

Change-Id: Ifa5fefe4a354cfe1f9a8a915a7041d0cfebccce1
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoRemove copy of libgq.
Robin Burchell [Fri, 20 Jan 2012 15:27:47 +0000 (17:27 +0200)]
Remove copy of libgq.

Nothing in the source tree uses this after the removal of the icd bearer plugin
in 0e0eb207c4ada7a09c980b816dda1c5c6af1c027, so there is no point keeping it
around anymore.

Change-Id: I6ea05c84d561965636e2ca5b03c7ee8edc48c093
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoRemove unnecessary sizehint overload.
Robin Burchell [Fri, 20 Jan 2012 00:35:51 +0000 (02:35 +0200)]
Remove unnecessary sizehint overload.

Change-Id: Id6b3e206d59df25f6252da48ac99265226313635
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoChange QMessageBox::question to default to yes/no buttons instead of ok
Thorbjørn Lund Martsum [Sat, 7 Jan 2012 07:23:17 +0000 (08:23 +0100)]
Change QMessageBox::question to default to yes/no buttons instead of ok

Beside that it also removes a suggestion about making Ok==Yes and
No==Cancel. It would be a problem since we (at least)
can have messageboxes with both yes, no and cancel.

Change-Id: I567979b2e697e7103968d6512fe4835f86888ca3
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
12 years agoIntroduce a qalgorithms benchmark.
Robin Burchell [Sat, 21 Jan 2012 11:45:44 +0000 (13:45 +0200)]
Introduce a qalgorithms benchmark.

Based on the unit test for data production.

Change-Id: I88a411c0079b251d3682c3fbf9fe7ed1b5457a7e
Reviewed-by: Anselmo L. S. Melo <anselmo.melo@openbossa.org>
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoMinor style fixups.
Robin Burchell [Sat, 21 Jan 2012 11:54:36 +0000 (13:54 +0200)]
Minor style fixups.

Add spaces where necessary, and pull braces back to the same line.

Change-Id: If543686c9727a110f8a91f1a88e08d5d2ac12284
Reviewed-by: Richard J. Moore <rich@kde.org>
12 years agoFix incorrect check for error when monitoring a path using inotify.
Robin Burchell [Fri, 20 Jan 2012 11:15:13 +0000 (13:15 +0200)]
Fix incorrect check for error when monitoring a path using inotify.

Per the manpage, inotify_add_watch will return -1 in the case of error, 0 is
a valid watch descriptor.

Task-number: QTBUG-12564
Change-Id: I56a54de2f5cf18b40aaeddc6de51d18dacbf8daf
Reviewed-by: Jonas Gastal <jgastal@profusion.mobi>
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoremove obsolete codec plugin loading code
Mark Brand [Thu, 12 Jan 2012 09:43:29 +0000 (10:43 +0100)]
remove obsolete codec plugin loading code

Change-Id: I1f3dbb5c10009413f701947b1b89ed3dbc94bf3d
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agocosmetic adjustments for files moved to core/codecs
Mark Brand [Sun, 3 Jul 2011 19:53:27 +0000 (21:53 +0200)]
cosmetic adjustments for files moved to core/codecs

-update old reference to 'plugin'
-rename multiple inclusion guards
-add private header warning text

Change-Id: I4c582dcba549d871bd8d929bee5372586117eabb
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoupdate private header references
Mark Brand [Wed, 18 Jan 2012 20:01:26 +0000 (21:01 +0100)]
update private header references

Change-Id: I092d879653b6900532a0c4534c1eb2be84e9d0f6
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agomove plugin text codecs to QtCore
Mark Brand [Thu, 12 Jan 2012 23:24:13 +0000 (00:24 +0100)]
move plugin text codecs to QtCore

Having plugin text codecs adds considerable complexity to
configuring Qt. The plugin interface is designed for optional
features, but text codecs tend to be used for essential functions.
A dramatic example is loading a codec plugin from a file whose path
needs to be converted by the codec.

Codec plugins can also be a nuisance to builders of applications
linking to static Qt. This is because the application might need
to explicilty import the static codec plugins which are actually
dependencies of QtCore.

For these reasons, it has been decided not to have text codec plugins
any longer.

Change-Id: Ic6c80a9c949bd42e881e932d1edae23fe4fe4c88
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agobuild and load text codecs regardless of iconv and platform
Mark Brand [Sun, 3 Jul 2011 22:42:24 +0000 (00:42 +0200)]
build and load text codecs regardless of iconv and platform

Otherwise applications linking to static Qt may have to import
the static plugins to avoid linking failure even if they do not
use the codecs, which is a nuisance.

Also, this is preparation for moving these codecs into QtCore
proper.

Change-Id: I71f3bbb0bac6261983143d0578757b34997d1364
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQFileInfo autotest - don't fail on default configured windows systems
Shane Kearns [Thu, 19 Jan 2012 15:12:29 +0000 (15:12 +0000)]
QFileInfo autotest - don't fail on default configured windows systems

NTFS file access times are disabled by default since windows 6 for
performance reasons. The test now checks the registry setting and
reports XFAIL if access times are disabled.

Change-Id: Ia84ed0c8736e6c7d5817425006f6115d9f3e70a4
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
12 years agoQPA/windows example: Fix positioning for virtual desktops.
Friedemann Kleint [Fri, 20 Jan 2012 08:15:13 +0000 (09:15 +0100)]
QPA/windows example: Fix positioning for virtual desktops.

Position window within screen geometry.

Change-Id: Id931f386c9ef5564887a2f54b71921f062320f54
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agofix whitespace
Mark Brand [Wed, 18 Jan 2012 10:43:10 +0000 (11:43 +0100)]
fix whitespace

Change-Id: I0cfccae085c000d4368386a34f288c1e6f01a88f
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoAdd atomic implementation for Native Client.
Morten Johan Sorvig [Fri, 13 Jan 2012 07:55:43 +0000 (08:55 +0100)]
Add atomic implementation for Native Client.

Uses gcc compiler intrinsics, similar to avr32.

Change-Id: I10cc2bd3cad67ee002386bab1ea764a4ff5ce727
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoFix cursor disappearance in QLineEdit on Mac when deleting all text
Pasi Matilainen [Tue, 17 Jan 2012 11:08:42 +0000 (13:08 +0200)]
Fix cursor disappearance in QLineEdit on Mac when deleting all text

On Mac OS X, if all text in the QLineEdit was selected and then deleted, cursor
visibility was not updated, and so the cursor remained hidden. Fixed
to update cursor visibility also when the text is empty.

Task-number: QTBUG-13169
Change-Id: Id52a20b07bb96609a78c42eb630ee2b20ed7cbcb
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
(cherry picked from commit 181456d0a31b7250da97eafba75e6bc657391777)

12 years agomake tst_QProcess::softExitInSlots pass in under 120 seconds
Joerg Bornemann [Fri, 20 Jan 2012 13:13:09 +0000 (14:13 +0100)]
make tst_QProcess::softExitInSlots pass in under 120 seconds

Due to unconditional waits this test always needed 120 seconds to pass.
Now we're using QTRY_VERIFY and make sure that we write the data before
the process got killed even in the cases 3 and 4.
On my machine this test now takes 8 seconds.

Change-Id: I606a8b43ba4c97704be5202a6c5d8d1c75337f9c
Reviewed-by: Bill King <bill.king@nokia.com>
12 years agoFix glyphsEnd range check
Jiang Jiang [Thu, 19 Jan 2012 15:30:03 +0000 (16:30 +0100)]
Fix glyphsEnd range check

For a character generating more than one glyphs, glyphsRun() needs
to check the next glyph index after the requested range. If that
glyph index is more than one larger than the glyphsEnd we currently
get from logClusters, then glyphsEnd need to be set to the next
glyph index minus one.

Change-Id: I795c595d349418ba755b088d6fe6ff24a6e7dd15
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>