platform/upstream/efl.git
11 years agoEdje: add edje_object_part_text_input_panel_show_on_demand_set/get()
Jihoon Kim [Wed, 14 Aug 2013 09:17:06 +0000 (18:17 +0900)]
Edje: add edje_object_part_text_input_panel_show_on_demand_set/get()

11 years agoconfigure: relax xkbcommon version requirement for ecore-wayland
U. Artie Eoff [Tue, 13 Aug 2013 15:16:22 +0000 (08:16 -0700)]
configure: relax xkbcommon version requirement for ecore-wayland

Summary:
Allow ecore-wayland to be configured and compiled with xkbcommon 0.3.0.
Ecore-wayland does not use any of the new APIs in 0.3.1 nor is it exposed
to the bug that was fixed in 0.3.1.

Most distros don't include xkbcommon > 0.3.0 yet.  Thus, if 0.3.1 is
required right now, then everyone is forced to build xkbcommon, too,
which contributes to dependency *madness*.  Of course, anyone is still
welcome to build and link to xkbcommon 0.3.1 at will.

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Reviewers: devilhorns, antognolli

Reviewed By: devilhorns

Differential Revision: https://phab.enlightenment.org/D203

11 years agoeina: add test for 'eina_file_map_new' function.
Oleksander Sirook [Tue, 13 Aug 2013 08:31:41 +0000 (17:31 +0900)]
eina: add test for 'eina_file_map_new' function.

11 years agoAdd ecore_imf_context_input_panel_on_demand_set/get API
Jihoon Kim [Tue, 13 Aug 2013 06:27:29 +0000 (15:27 +0900)]
Add ecore_imf_context_input_panel_on_demand_set/get API

11 years agoembryo: Fix a potential buffer overflow (klocwork id 321)
Daniel Willmann [Mon, 12 Aug 2013 17:30:24 +0000 (18:30 +0100)]
embryo: Fix a potential buffer overflow (klocwork id 321)

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
11 years agoEnough with this bad align Edje property documentation.
Gustavo Lima Chaves [Mon, 12 Aug 2013 16:29:43 +0000 (13:29 -0300)]
Enough with this bad align Edje property documentation.

11 years agoedje: forth recalc for text part that got adjusted during a calc_only.
Cedric Bail [Mon, 12 Aug 2013 07:47:12 +0000 (16:47 +0900)]
edje: forth recalc for text part that got adjusted during a calc_only.

11 years agodns.c is the default resolver in ALL cases when we have a C99 compiler, not just...
Mike Blumenkrantz [Mon, 12 Aug 2013 07:39:57 +0000 (08:39 +0100)]
dns.c is the default resolver in ALL cases when we have a C99 compiler, not just when ipv6 is available.

11 years agoevas: handle gracefully move from evas_object_image_file_set to and from evas_object_...
Cedric Bail [Mon, 12 Aug 2013 03:12:13 +0000 (12:12 +0900)]
evas: handle gracefully move from evas_object_image_file_set to and from evas_object_image_mmap_set.

11 years agoeina: remove a warning.
Cedric Bail [Mon, 12 Aug 2013 03:11:56 +0000 (12:11 +0900)]
eina: remove a warning.

11 years agoedje: fix forgotten fetch.
Cedric Bail [Sun, 11 Aug 2013 23:58:37 +0000 (08:58 +0900)]
edje: fix forgotten fetch.

11 years agoedje: let's make a difference between file does not exist and no file specified.
Cedric Bail [Sun, 11 Aug 2013 23:55:36 +0000 (08:55 +0900)]
edje: let's make a difference between file does not exist and no file specified.

11 years agoedje: forgotten refcounting of Eina_File use.
Cedric Bail [Sun, 11 Aug 2013 23:42:55 +0000 (08:42 +0900)]
edje: forgotten refcounting of Eina_File use.

11 years agoRemove unused variables.
Chris Michael [Sun, 11 Aug 2013 13:02:21 +0000 (14:02 +0100)]
Remove unused variables.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
11 years agoadjust (as discussed) to have enums for memory and battery state.
Carsten Haitzler (Rasterman) [Sat, 10 Aug 2013 14:23:06 +0000 (23:23 +0900)]
adjust (as discussed) to have enums for memory and battery state.

11 years agoevas - fix up border adjust improvement from last night. handles overlap now
Carsten Haitzler (Rasterman) [Sat, 10 Aug 2013 07:26:30 +0000 (16:26 +0900)]
evas - fix up border adjust improvement from last night. handles overlap now

11 years agoecore: add upower system module.
Gustavo Sverzut Barbieri [Fri, 9 Aug 2013 19:39:10 +0000 (16:39 -0300)]
ecore: add upower system module.

It's always enabled as it's a dbus module and links to nothing,
actually the daemon doesn't need to be running -- in that case it will
do nothing. In the case the daemon becomes active then it will get the
OnLowBattery property and keep it in sync.

NOTE: I couldn't test the property change as my laptop takes many
hours to get to that situation... let's hope it works :-)

11 years agoecore: add system modules, implement 'systemd'.
Gustavo Sverzut Barbieri [Thu, 8 Aug 2013 23:32:53 +0000 (20:32 -0300)]
ecore: add system modules, implement 'systemd'.

Ecore will now load "system modules" on ecore_init(). The "systemd"
module will use DBus to monitor localed, hostnamed and timedated and
add system events related to those changes.

11 years agoecore: detect and emit event on system time changed.
Gustavo Sverzut Barbieri [Fri, 9 Aug 2013 03:02:04 +0000 (00:02 -0300)]
ecore: detect and emit event on system time changed.

If we have timerfd then we can set a timer with special features
(ABSTIME | CANCELON) to be notified if its offset to monotonic time
change, effectively this will alert us if user called settimeofday()
or similar method to change system time.

This code was inspired by Enlightenment's clock module.

11 years agoecore: add system-level events.
Gustavo Sverzut Barbieri [Thu, 8 Aug 2013 23:09:37 +0000 (20:09 -0300)]
ecore: add system-level events.

 - ECORE_EVENT_LOW_MEMORY: Low memory state changed
 - ECORE_EVENT_LOW_BATTERY: Low battery state changed
 - ECORE_EVENT_LOCALE_CHANGED:  Locale changed
 - ECORE_EVENT_HOSTNAME_CHANGED: Hostname changed
 - ECORE_EVENT_SYSTEM_TIMEDATE_CHANGED: Time or Date changed

11 years agoEvas textblock: make an if look nicer (no logic change).
Tom Hacohen [Fri, 9 Aug 2013 14:46:40 +0000 (15:46 +0100)]
Evas textblock: make an if look nicer (no logic change).

This makes things simpler and less confusing and might have prevented
the issue Stefan fixed in 4f484b81d48b73709b3e4b4b1b01e383976ecb0a
from happenning in the first place.

11 years agoeo: slight speed up
Jérémy Zurcher [Fri, 9 Aug 2013 13:58:55 +0000 (15:58 +0200)]
eo: slight speed up

11 years agoevas - OOPS! printf was not meant to go in!
Carsten Haitzler (Rasterman) [Fri, 9 Aug 2013 13:30:14 +0000 (22:30 +0900)]
evas - OOPS! printf was not meant to go in!

11 years agoevas - minor visual fixup with impossible border scaling to be more sensible
Carsten Haitzler (Rasterman) [Fri, 9 Aug 2013 13:06:12 +0000 (22:06 +0900)]
evas - minor visual fixup with impossible border scaling to be more sensible

11 years agoedje: add edje_file_mmap_set.
Cedric Bail [Fri, 9 Aug 2013 11:49:52 +0000 (20:49 +0900)]
edje: add edje_file_mmap_set.

This reduce the number of system call to stat especially when using GROUP
and reduce the risk of a race condition when using GROUP.

11 years agoeina: change eina_file_virtualize to be able to provide a fake name.
Cedric Bail [Fri, 9 Aug 2013 11:35:02 +0000 (20:35 +0900)]
eina: change eina_file_virtualize to be able to provide a fake name.

11 years agoevas/textblock: Do not write out of bounds.
Stefan Schmidt [Fri, 9 Aug 2013 10:54:42 +0000 (11:54 +0100)]
evas/textblock: Do not write out of bounds.

The length is len so last array index must be len - 1. Better not
corrupt memory. :)

CID 1039302

11 years agoedje: Do not access after freeing
Stefan Schmidt [Fri, 9 Aug 2013 10:43:25 +0000 (11:43 +0100)]
edje: Do not access after freeing

Better free it after we access it.

CID 1039917

11 years agoeldbus: Fix copy and paste error.
Stefan Schmidt [Fri, 9 Aug 2013 09:27:54 +0000 (10:27 +0100)]
eldbus: Fix copy and paste error.

We are in the remove case here. The interfaces_added looks like a missed change
from the copy and paste of the add case.

CID 1039671

11 years agoeet: Add comment about missing break in switch statement
Stefan Schmidt [Fri, 9 Aug 2013 09:17:49 +0000 (10:17 +0100)]
eet: Add comment about missing break in switch statement

11 years agoFix glib integration copy/paste issue:
Chris Michael [Fri, 9 Aug 2013 05:38:54 +0000 (06:38 +0100)]
Fix glib integration copy/paste issue:
 - If we are supposed to be deleting an fd handler, let's use
g_source_remove_poll instead of g_source_add_poll ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoEvas textblock: Make the ellipsis format the same as the surrounding.
Tom Hacohen [Thu, 8 Aug 2013 12:09:20 +0000 (13:09 +0100)]
Evas textblock: Make the ellipsis format the same as the surrounding.

This fix is based on a solution by WooHyun Jung.

11 years agoeina module - minor addition ot allowing lazy loading if env var set
Carsten Haitzler (Rasterman) [Thu, 8 Aug 2013 11:18:08 +0000 (20:18 +0900)]
eina module - minor addition ot allowing lazy loading if env var set

11 years agoeina: another fix for windows build.
Cedric Bail [Thu, 8 Aug 2013 08:17:58 +0000 (17:17 +0900)]
eina: another fix for windows build.

11 years agoeina: fix compilation of Eina_File on windows.
Cedric Bail [Thu, 8 Aug 2013 08:05:14 +0000 (17:05 +0900)]
eina: fix compilation of Eina_File on windows.

11 years agoevas: CRIT when someone change object geometry during pixels get callback.
Cedric Bail [Wed, 7 Aug 2013 09:40:42 +0000 (18:40 +0900)]
evas: CRIT when someone change object geometry during pixels get callback.

11 years agoedje: fix off-by-one when x or y where negative.
Cedric Bail [Wed, 7 Aug 2013 09:40:23 +0000 (18:40 +0900)]
edje: fix off-by-one when x or y where negative.

11 years agoecore_evas: Fix potential NULL dereference.
Stefan Schmidt [Wed, 7 Aug 2013 14:38:35 +0000 (15:38 +0100)]
ecore_evas: Fix potential NULL dereference.

We don't want to execute any of the function below if t is NULL. Its not
only about strdup but alsa ecore_x_netwm_name_set which might dereference it.

CID 1039400

11 years agoecore: Check if eina_inarray_grow return NULL.
Stefan Schmidt [Wed, 7 Aug 2013 14:16:07 +0000 (15:16 +0100)]
ecore: Check if eina_inarray_grow return NULL.

We will dereference one line below.

CID 1039337

11 years agoeio: Check return code of fcntl()
Stefan Schmidt [Wed, 7 Aug 2013 14:05:34 +0000 (15:05 +0100)]
eio: Check return code of fcntl()

CID 1039686

11 years agoeeze: Remove unused var and related dead code.
Stefan Schmidt [Wed, 7 Aug 2013 14:00:10 +0000 (15:00 +0100)]
eeze: Remove unused var and related dead code.

Must be a leftover from older times. syspath never get set here.

CID 1039463

11 years agoeeze: Go to next loop iterate if test is NULL.
Stefan Schmidt [Wed, 7 Aug 2013 13:54:14 +0000 (14:54 +0100)]
eeze: Go to next loop iterate if test is NULL.

We would dereference it even if NULL one line later.

CID1039328

11 years agoefreet: Fix buffer overrun, leave space for '\0'
Sebastian Dransfeld [Wed, 7 Aug 2013 09:55:22 +0000 (11:55 +0200)]
efreet: Fix buffer overrun, leave space for '\0'

CID: #1039304, #1039305 and #1039306

11 years agoefreet: be paranoid about '\0' termination
Sebastian Dransfeld [Wed, 7 Aug 2013 09:51:32 +0000 (11:51 +0200)]
efreet: be paranoid about '\0' termination

CID: #1039721

11 years agoefreet: formatting
Sebastian Dransfeld [Wed, 7 Aug 2013 09:50:46 +0000 (11:50 +0200)]
efreet: formatting

11 years agoefreet: clean up ugly internal_get function
Sebastian Dransfeld [Wed, 7 Aug 2013 09:45:30 +0000 (11:45 +0200)]
efreet: clean up ugly internal_get function

CID: #1039186

11 years agoefreet: Remove dead code
Sebastian Dransfeld [Wed, 7 Aug 2013 09:37:39 +0000 (11:37 +0200)]
efreet: Remove dead code

CID: #1039942

11 years agoefreet: Explicitly set num_pending to 0
Sebastian Dransfeld [Wed, 7 Aug 2013 09:33:42 +0000 (11:33 +0200)]
efreet: Explicitly set num_pending to 0

CID: #1039185

11 years agoefreet: Check return value of eet_list
Sebastian Dransfeld [Wed, 7 Aug 2013 08:59:05 +0000 (10:59 +0200)]
efreet: Check return value of eet_list

CID: #1039327

11 years agoefreet: fgetc returns int
Sebastian Dransfeld [Wed, 7 Aug 2013 08:57:13 +0000 (10:57 +0200)]
efreet: fgetc returns int

CID: #1039720

11 years agoefreet: Check return value of chmod
Sebastian Dransfeld [Wed, 7 Aug 2013 08:52:48 +0000 (10:52 +0200)]
efreet: Check return value of chmod

CID: #1039690

11 years agoefreet: Be paranoid about '\0' termination
Sebastian Dransfeld [Wed, 7 Aug 2013 08:52:02 +0000 (10:52 +0200)]
efreet: Be paranoid about '\0' termination

CID: #1039722

11 years agoefreet: Use mkstemp for tempfile
Sebastian Dransfeld [Wed, 7 Aug 2013 08:18:59 +0000 (10:18 +0200)]
efreet: Use mkstemp for tempfile

CID: #1039615

11 years agoefreet: Check return value of chmod
Sebastian Dransfeld [Wed, 7 Aug 2013 08:02:05 +0000 (10:02 +0200)]
efreet: Check return value of chmod

CID: #1039716

11 years agoefreet: TODO++
Sebastian Dransfeld [Wed, 7 Aug 2013 07:41:01 +0000 (09:41 +0200)]
efreet: TODO++

11 years agoSynced libunibreak local copy with upstream.
Tom Hacohen [Wed, 7 Aug 2013 10:56:46 +0000 (11:56 +0100)]
Synced libunibreak local copy with upstream.

11 years agoConvert upper-case characters to lower-case characters on keydown
Chris Michael [Wed, 7 Aug 2013 09:42:34 +0000 (10:42 +0100)]
Convert upper-case characters to lower-case characters on keydown
events.

NB: xkbcommon automatically converts the pressed key to Upper if Shift
is pressed. this is a problem as ecore key down events expect them to
be lower-case (not converted yet).

NB: Fixes Phab Ticket T232.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoUpdated changelog/news with the max ascent/descent fixes.
Tom Hacohen [Wed, 7 Aug 2013 09:26:30 +0000 (10:26 +0100)]
Updated changelog/news with the max ascent/descent fixes.

Commit: 6583b83c7304dcc1cb3f6c869ba1a391770b677c.

11 years agoprint error when ecore-x shm check fails
Mike Blumenkrantz [Wed, 7 Aug 2013 07:36:22 +0000 (08:36 +0100)]
print error when ecore-x shm check fails

11 years agoedje: make min: source work correctly with GROUP part.
Cedric Bail [Wed, 7 Aug 2013 07:00:15 +0000 (16:00 +0900)]
edje: make min: source work correctly with GROUP part.

This close task T54.

11 years agoedje: add warning when not finding the exact match.
Cedric Bail [Wed, 7 Aug 2013 06:02:52 +0000 (15:02 +0900)]
edje: add warning when not finding the exact match.

This will close T223.

11 years agoUpdate ChangeLog for recent wayland requirement changes.
Chris Michael [Wed, 7 Aug 2013 06:50:06 +0000 (07:50 +0100)]
Update ChangeLog for recent wayland requirement changes.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoRequire up-to-date wayland-client library for ecore_imf wayland module
Chris Michael [Wed, 7 Aug 2013 06:48:06 +0000 (07:48 +0100)]
Require up-to-date wayland-client library for ecore_imf wayland module
support.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoRequire up-to-date versions of the wayland libraries for evas engine
Chris Michael [Wed, 7 Aug 2013 06:46:43 +0000 (07:46 +0100)]
Require up-to-date versions of the wayland libraries for evas engine
support.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoAdd wayland library version checks to configure.ac for EFL 1.8
Chris Michael [Wed, 7 Aug 2013 06:41:28 +0000 (07:41 +0100)]
Add wayland library version checks to configure.ac for EFL 1.8

NB: As of today, EFL Head will require an up-to-date version of the
wayland libraries.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoAdd missing EINA_UNUSED to function parameters.
Chris Michael [Tue, 6 Aug 2013 10:26:26 +0000 (11:26 +0100)]
Add missing EINA_UNUSED to function parameters.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoAdd functions for output done and output scale events.
Chris Michael [Tue, 6 Aug 2013 10:18:29 +0000 (11:18 +0100)]
Add functions for output done and output scale events.

NB: Apparently, setting these functions to NULL in the listener Does
Not Work anymore ! :( (used to work just fine).

NB: This makes EFL Apps work again inside Weston with latest from git.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoBump compositor interface version to 3.
Chris Michael [Tue, 6 Aug 2013 10:18:11 +0000 (11:18 +0100)]
Bump compositor interface version to 3.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoGet the 'fd' from the handler First (regardless of read or write) so
Chris Michael [Tue, 6 Aug 2013 08:47:08 +0000 (09:47 +0100)]
Get the 'fd' from the handler First (regardless of read or write) so
that it can be used in the below event callback.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoEvas textblock: Use max ascent/descent at the edges of the textblock.
Tom Hacohen [Tue, 6 Aug 2013 08:28:38 +0000 (09:28 +0100)]
Evas textblock: Use max ascent/descent at the edges of the textblock.

Thanks to Youngbok Shin for reporting the difference in behaviour between
textblock and text object.

11 years agoeina-file - adapt to bsd version of MADV_REMOVE
Carsten Haitzler (Rasterman) [Tue, 6 Aug 2013 07:13:03 +0000 (16:13 +0900)]
eina-file - adapt to bsd version of MADV_REMOVE

11 years agoevas: fix build with debugging rendering trace.
Cedric Bail [Tue, 6 Aug 2013 06:45:07 +0000 (15:45 +0900)]
evas: fix build with debugging rendering trace.

11 years agoevas: fix comment to actually compile if you use them.
Cedric Bail [Tue, 6 Aug 2013 06:44:43 +0000 (15:44 +0900)]
evas: fix comment to actually compile if you use them.

11 years agoeina: fix build on FreeBSD.
Cedric Bail [Tue, 6 Aug 2013 06:44:22 +0000 (15:44 +0900)]
eina: fix build on FreeBSD.

11 years agoefreet: let's pass memset parameter in the right order.
Cedric Bail [Tue, 6 Aug 2013 00:17:46 +0000 (09:17 +0900)]
efreet: let's pass memset parameter in the right order.

11 years agoFix memleak in data_thread_script of edje_cc_out
Chris Michael [Mon, 5 Aug 2013 14:32:12 +0000 (15:32 +0100)]
Fix memleak in data_thread_script of edje_cc_out

NB: If we are going to exit data_thread_script function due to malloc
failure or fread failure, then we should close the previously fdopen'd
file so that we do not leak 'f'.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoIf efreet_menu_parse returns an actual menu, let's free the memory
Chris Michael [Mon, 5 Aug 2013 13:24:46 +0000 (14:24 +0100)]
If efreet_menu_parse returns an actual menu, let's free the memory
allocated to it before we return.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoRemove the directory from the font_first hash First, before calling
Chris Michael [Mon, 5 Aug 2013 13:07:11 +0000 (14:07 +0100)]
Remove the directory from the font_first hash First, before calling
object_text_font_cache_dir_del as the latter function will actually
Free the fd.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoDo not try to append a NULL async client.
Chris Michael [Mon, 5 Aug 2013 13:03:13 +0000 (14:03 +0100)]
Do not try to append a NULL async client.

NB: Above, _ethumb_client_async_free Could have been called, which
will free the async client. Add valid check for async before we append.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoefreet_menu_move_free will free "move" here so remove the menu from
Chris Michael [Mon, 5 Aug 2013 12:58:13 +0000 (13:58 +0100)]
efreet_menu_move_free will free "move" here so remove the menu from
the parent's list Before we free the menu.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years ago_ecore_con_dns_free already frees the timer and whole dns structure,
Chris Michael [Mon, 5 Aug 2013 12:52:06 +0000 (13:52 +0100)]
_ecore_con_dns_free already frees the timer and whole dns structure,
so setting dns->timer = NULL here b0rks.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoFix potential double-free of so->answer.
Chris Michael [Mon, 5 Aug 2013 12:48:23 +0000 (13:48 +0100)]
Fix potential double-free of so->answer.

NB: dns_so_submit calls dns_so_reset twice (once at start, once at end
on error). As so_reset will free so->answer the first time through,
add validity check of so->answer for the second iteration.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoInit fd to zero (removes compiler warning).
Chris Michael [Mon, 5 Aug 2013 12:16:44 +0000 (13:16 +0100)]
Init fd to zero (removes compiler warning).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoRemove Eet_Connection from hash Before we call eet_connection_close
Chris Michael [Mon, 5 Aug 2013 12:13:19 +0000 (13:13 +0100)]
Remove Eet_Connection from hash Before we call eet_connection_close
(as that frees the connection).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoFix eina_file_virtual_map_new function (/me glares at Frenchie).
Chris Michael [Mon, 5 Aug 2013 12:01:52 +0000 (13:01 +0100)]
Fix eina_file_virtual_map_new function (/me glares at Frenchie).
 - Spank Cedric !!!!!

NB: How about we actually fill in "map" after allocation ??

NB: Previously we would malloc "map" and immediately exit without
filling it in, without adding it to the hash....nothing. Just allocate
and get out. Bad Frenchie !!!

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoAvoid potential divide by zero in INF call.
Chris Michael [Mon, 5 Aug 2013 11:42:31 +0000 (12:42 +0100)]
Avoid potential divide by zero in INF call.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoDo not call _ecore_con_client_flush with a NULL client.
Chris Michael [Mon, 5 Aug 2013 11:39:19 +0000 (12:39 +0100)]
Do not call _ecore_con_client_flush with a NULL client.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoCheck for Image_Entry being valid before calling evas_cache_image_drop.
Chris Michael [Mon, 5 Aug 2013 11:32:00 +0000 (12:32 +0100)]
Check for Image_Entry being valid before calling evas_cache_image_drop.

NB: Image_Entry passed in to this function Could be NULL (hence the
previous if ie check above. Do not call evas_cache_image_drop on a
NULL Image_Entry as evas_cache_image_drop does not validity checking.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoActually declare fd at the top of function.
Chris Michael [Mon, 5 Aug 2013 11:17:26 +0000 (12:17 +0100)]
Actually declare fd at the top of function.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoecore_main_fd_handler_fd_get can return -1 so we need to check for a
Chris Michael [Mon, 5 Aug 2013 10:46:04 +0000 (11:46 +0100)]
ecore_main_fd_handler_fd_get can return -1 so we need to check for a
valid fd before calling read().

Reuse returned fd variable in the callback to save extra function call
to ecore_main_fd_handler_fd_get (since we already acquired the fd
above).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoCheck for valid fd returned from ecore_main_fd_handler_fd_get before
Chris Michael [Mon, 5 Aug 2013 10:40:02 +0000 (11:40 +0100)]
Check for valid fd returned from ecore_main_fd_handler_fd_get before
potentially passing -1 to the read() function.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoDon't pass negative values to close:
Chris Michael [Mon, 5 Aug 2013 10:36:24 +0000 (11:36 +0100)]
Don't pass negative values to close:
  ecore_main_fd_handler_fd_get can return -1, so check return value
before passing to close().

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoopen() can fail for various reasons, so check for valid 'fd' return
Chris Michael [Mon, 5 Aug 2013 10:34:34 +0000 (11:34 +0100)]
open() can fail for various reasons, so check for valid 'fd' return
before calling fdopen.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoecore_main_fd_handler_fd_get can return -1 so check fd validity before
Chris Michael [Mon, 5 Aug 2013 10:24:11 +0000 (11:24 +0100)]
ecore_main_fd_handler_fd_get can return -1 so check fd validity before
calling read() with potentially -1.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoecore_main_fd_handler_fd_get Can return -1 so check fd validity before
Chris Michael [Mon, 5 Aug 2013 09:56:37 +0000 (10:56 +0100)]
ecore_main_fd_handler_fd_get Can return -1 so check fd validity before
calling close() on it.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agofopen can fail. check file is open before trying to write to it.
Chris Michael [Mon, 5 Aug 2013 09:41:16 +0000 (10:41 +0100)]
fopen can fail. check file is open before trying to write to it.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agostrchr can return NULL, so check validity before tryint to pass NULL
Chris Michael [Mon, 5 Aug 2013 09:37:15 +0000 (10:37 +0100)]
strchr can return NULL, so check validity before tryint to pass NULL
to ecore_file_cp.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years ago_edje_real_part_recursive_get can return NULL so check validity before
Chris Michael [Mon, 5 Aug 2013 09:26:38 +0000 (10:26 +0100)]
_edje_real_part_recursive_get can return NULL so check validity before
calling _edje_child_remove (with potentially NULL as the real part).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoDon't call fcntl functions if we do not HAVE_FCNTL support built in.
Chris Michael [Mon, 5 Aug 2013 09:13:57 +0000 (10:13 +0100)]
Don't call fcntl functions if we do not HAVE_FCNTL support built in.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
11 years agoevas: limit resize to always be of the right size.
Cedric Bail [Mon, 5 Aug 2013 08:43:17 +0000 (17:43 +0900)]
evas: limit resize to always be of the right size.

This should fix T157.