Lars-Magnus Skog [Fri, 1 Mar 2013 20:09:36 +0000 (21:09 +0100)]
doc change for Readable._read()
isaacs [Fri, 1 Mar 2013 22:26:35 +0000 (14:26 -0800)]
doc: Clarify advisory-ness of stream._read() argument
Gil Pedersen [Fri, 1 Mar 2013 22:15:28 +0000 (23:15 +0100)]
doc: Update to reflect new _read() interface
Evan Oxfeld [Fri, 1 Mar 2013 20:10:36 +0000 (15:10 -0500)]
doc: Fix readable.unshift() example
Slice the portion of the buffer to unshift back into the read queue
Scott Blomquist [Fri, 1 Mar 2013 20:03:44 +0000 (12:03 -0800)]
build/windows: don't use wrong version number
We were using a global temp file while setting the NODE_VERSION
environment variable. This resulted in simultaneous builds swapping
version numbers on occasion.
This patch removes the use of a temp file for this.
isaacs [Fri, 1 Mar 2013 19:23:55 +0000 (11:23 -0800)]
doc: Correct version in changelog
isaacs [Fri, 1 Mar 2013 19:19:38 +0000 (11:19 -0800)]
Now working on 0.9.12
isaacs [Fri, 1 Mar 2013 19:19:20 +0000 (11:19 -0800)]
Merge branch 'v0.9.11-release'
isaacs [Fri, 1 Mar 2013 17:58:35 +0000 (09:58 -0800)]
2013.03.01, Version 0.9.10 (Unstable)
* V8: downgrade 3.14.5
* openssl: update to 1.0.1e
* darwin: Make process.title work properly (Ben Noordhuis)
* fs: Support mode/flag options to read/append/writeFile (isaacs)
* stream: _read() no longer takes a callback (isaacs)
* stream: Add stream.unshift(chunk) (isaacs)
* stream: remove lowWaterMark feature (isaacs)
* net: omit superfluous 'connect' event (Ben Noordhuis)
* build, windows: disable SEH (Ben Noordhuis)
* core: remove errno global (Ben Noordhuis)
* core: Remove the nextTick for running the main file (isaacs)
* core: Mark exit() calls with status codes (isaacs)
* core: Fix debug signal handler race condition lock (isaacs)
* crypto: clear error stack (Ben Noordhuis)
* test: optionally set common.PORT via env variable (Timothy J Fontaine)
* path: Throw TypeError on non-string args to path.resolve/join (isaacs, Arianit Uka)
* crypto: fix uninitialized memory access in openssl (Ben Noordhuis)
isaacs [Fri, 1 Mar 2013 18:21:21 +0000 (10:21 -0800)]
blog: Do not pass undefined to path.join
isaacs [Fri, 1 Mar 2013 17:10:26 +0000 (09:10 -0800)]
fs: Support mode/flag options to read/append/writeFile
Fix #4841
isaacs [Fri, 1 Mar 2013 16:54:49 +0000 (08:54 -0800)]
test: Put fs write test files in tmp
This prevents fixture litter when these tests fail.
Timothy J Fontaine [Fri, 1 Mar 2013 00:56:37 +0000 (16:56 -0800)]
build: windows should append date if nightly
isaacs [Thu, 28 Feb 2013 23:42:55 +0000 (15:42 -0800)]
doc: Provide 2 examples of SimpleProtocol parser
The first example uses Readable, and shows the use of
readable.unshift(). The second uses the Transform class, showing that
it's much simpler in this case.
isaacs [Thu, 28 Feb 2013 23:32:32 +0000 (15:32 -0800)]
stream: There is no _read cb, there is only push
This makes it so that `stream.push(chunk)` is the only way to signal the
end of reading, removing the confusing disparity between the
callback-style _read method, and the fact that most real-world streams
do not have a 1:1 corollation between the "please give me data" event,
and the actual arrival of a chunk of data.
It is still possible, of course, to implement a `CallbackReadable` on
top of this. Simply provide a method like this as the callback:
function readCallback(er, chunk) {
if (er)
stream.emit('error', er);
else
stream.push(chunk);
}
However, *only* fs streams actually would behave in this way, so it
makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have
to bend into this uncomfortable paradigm.
isaacs [Thu, 28 Feb 2013 03:32:19 +0000 (19:32 -0800)]
stream: Add stream.unshift(chunk)
isaacs [Thu, 28 Feb 2013 00:56:30 +0000 (16:56 -0800)]
stream: Break up the onread function
A primary motivation of this is to make the onread function more
inline-friendly, but also to make it more easy to explore not having
onread at all, in favor of always using push() to signal the end of
reading.
Ben Noordhuis [Thu, 28 Feb 2013 22:25:29 +0000 (23:25 +0100)]
net: omit superfluous 'connect' event
Don't emit a 'connect' event on sockets that are handed off to
net.Server 'connection' event listeners.
1. It's superfluous because the connection has already been established
at that point.
2. The implementation is arguably wrong because the event is emitted on
the same tick of the event loop while the rule of thumb is to always
emit it on the next one.
This has been tried before in commit f0a440d but was reverted again in
ede1acc because the change was incomplete (at least one test hadn't
been updated).
Fixes #1047 (again).
Ben Noordhuis [Fri, 1 Mar 2013 01:04:29 +0000 (02:04 +0100)]
deps: upgrade libuv to 2a8d2a5
Ben Noordhuis [Thu, 28 Feb 2013 23:44:55 +0000 (00:44 +0100)]
test: disable simple/test-process-getgroups on os x
The output of `id -G` is unreliable on OS X. It uses an undocumented
Libsystem function called getgrouplist_2() that includes some auxiliary
groups that the POSIX getgroups() function does not return.
Or rather, not always. It leads to fun bug chases where the test fails
in one terminal but not in another.
Ben Noordhuis [Thu, 28 Feb 2013 22:13:54 +0000 (23:13 +0100)]
Merge remote-tracking branch 'origin/v0.8'
Timothy J Fontaine [Thu, 28 Feb 2013 19:46:59 +0000 (11:46 -0800)]
test: fix tap output on windows
Test output is always \n and not platform dependent
Ben Noordhuis [Thu, 28 Feb 2013 16:50:14 +0000 (17:50 +0100)]
lib, src: remove errno global
Remove the errno global. It's a property on the process object now.
Fixes #3095.
Scott Blomquist [Thu, 28 Feb 2013 17:18:12 +0000 (09:18 -0800)]
test: add cleanup to long path test
Ben Noordhuis [Thu, 28 Feb 2013 15:58:24 +0000 (16:58 +0100)]
Merge remote-tracking branch 'origin/v0.8'
Conflicts:
AUTHORS
ChangeLog
deps/uv/src/unix/pipe.c
lib/http.js
src/node_version.h
Ben Noordhuis [Thu, 28 Feb 2013 15:35:17 +0000 (16:35 +0100)]
build, windows: disable SEH
Turn off safe exception handlers, they're incompatible with how
openssl is compiled / linked under MSVS 2012.
Addresses the following build error:
openssl.lib(x86cpuid.obj) : error LNK2026: module unsafe for SAFESEH
image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
openssl.lib(x86.obj) : error LNK2026: module unsafe for SAFESEH
image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
# etc. etc.
g:\jenkins\workspace\nodejs-oneoff\Release\node.exe : fatal error
LNK1281: Unable to generate SAFESEH image.
[g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
Fixes #4242.
Ben Noordhuis [Thu, 28 Feb 2013 15:30:45 +0000 (16:30 +0100)]
doc: update instructions on home page
Document how to run the example on the home page in more detail.
Apparently our Windows brethren are prone to double-clicking on the
binary instead of running it from the command line.
Fixes #4854.
Trevor Norris [Wed, 27 Feb 2013 19:46:35 +0000 (11:46 -0800)]
process: separate nextTick domain logic
It's cleaner to only load domain ticker logic when the domains are being
used. This makes execution slightly quicker in both cases, and simpler
from the spinner since there is no need to check if the latest callback
requires use of domains.
isaacs [Wed, 27 Feb 2013 19:24:02 +0000 (11:24 -0800)]
core: Remove the nextTick for running the main file
Not necessary, since we can handle the error properly on the first tick
now, even if there are event listeners, etc.
Additionally, this removes the unnecessary "_needTickCallback" from
startup, since Module.loadMain() will kick off a nextTick callback right
after it runs the main module.
Fix #4856
isaacs [Wed, 27 Feb 2013 19:23:20 +0000 (11:23 -0800)]
core: Mark exit() calls with status codes
Also, exit with 128+n for signal exit n, as is The Unix Way.
Ben Noordhuis [Wed, 27 Feb 2013 22:31:38 +0000 (23:31 +0100)]
crypto: clear error stack
Clear OpenSSL's error stack on return from Connection::HandleSSLError().
This stops stale errors from popping up later in the lifecycle of the
SSL connection where they would cause spurious failures.
This commit causes a 1-2% performance regression on `make bench-tls`.
We'll address that in follow-up commits if possible but let's ensure
correctness first.
Fixes #4771.
Scott Blomquist [Wed, 27 Feb 2013 06:52:58 +0000 (22:52 -0800)]
openssl: regenerate asm files for openssl 1.0.1e
isaacs [Mon, 25 Feb 2013 06:14:30 +0000 (22:14 -0800)]
stream: Writables are not pipe()able
This handles the fact that stream.Writable inherits from the Stream class,
meaning that it has the legacy pipe() method. Override that with a pipe()
method that emits an error.
Ensure that Duplex streams ARE still pipe()able, however.
Since the 'readable' flag on streams is sometimes temporary, it's probably
better not to put too much weight on that. But if something is an instanceof
Writable, rather than of Readable or Duplex, then it's safe to say that
reading from it is the wrong thing to do.
Fix #3647
isaacs [Wed, 27 Feb 2013 01:54:18 +0000 (17:54 -0800)]
test: Use common.PORT in simple/test-http-timeout
isaacs [Wed, 27 Feb 2013 01:39:04 +0000 (17:39 -0800)]
test: Move test-net-connect-timeout to test/internet
It is not a valid test unless you're connected to the internet, and causes
a lot of spurious failures on Linux anyway, as it's highly dependent on
timing of things that we don't have any control over.
isaacs [Wed, 27 Feb 2013 01:33:30 +0000 (17:33 -0800)]
test: Use common.PORT to determine debugger port
isaacs [Wed, 27 Feb 2013 00:42:47 +0000 (16:42 -0800)]
test: Fix debugger repl tests
This makes the output of simple/test-debugger-repl and
simle/test-debugger-repl-utf8 mirror an actual debugger session, so it's
a bit easier to reason about.
Also, it uses the same code for both, and fixes it so that it doesn't
leave zombie processes lying around when it crashes.
Run 1000 times without any failures or zombies.
isaacs [Tue, 26 Feb 2013 01:46:48 +0000 (17:46 -0800)]
test: catch break in simple/test-debugger-client
Handle break events that come out sometimes, by telling it to continue.
Also, send the child a SIGTERM when it times out.
isaacs [Wed, 27 Feb 2013 00:36:56 +0000 (16:36 -0800)]
core: Use a uv_signal for debug listener
Starting the debugger directly in the SIGUSR1 signal handler results in
a malloc lock contention ~1% of the time. It hangs the test, which is
annoying on a daily basis to all of us, but it also is pretty terrible
if you actually want to debug a node process that has gone sideways.
Credit to @bnoordhuis for most of this. I just added the unref which
keeps it from messing up the event loop for other stuff.
Ben Noordhuis [Tue, 26 Feb 2013 19:30:12 +0000 (20:30 +0100)]
deps: upgrade libuv to a0c1d84
Ben Noordhuis [Tue, 26 Feb 2013 18:38:15 +0000 (19:38 +0100)]
test: merge environment, don't overwrite
The CI system requires that some environment variables are set so merge
our variables into the current environment instead of blindly replacing
it.
This will probably have to be repeated for other tests. C'est la vie.
yangguo@chromium.org [Tue, 18 Dec 2012 09:48:51 +0000 (09:48 +0000)]
v8: Hardfloat does not imply VFPv3, only VFPv2.
Raspberry Pi is an example.
BUG=v8:2393
Review URL: https://chromiumcodereview.appspot.com/
11570061
Patch from Chi-Thanh Christopher Nguyen <nguyenchithanh@gmail.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@13232
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
This is a backport of v8/v8@
44419ad089b729a1aab4a5f27c0833e2ce69d28b.
Ben Noordhuis [Tue, 15 Jan 2013 22:42:23 +0000 (23:42 +0100)]
v8: work around String::WriteAscii segfault
See http://code.google.com/p/v8/issues/detail?id=2493 for details.
This commit reapplies 9668df8. The issue has been fixed upstream but
reappeared after last night's downgrade to V8 3.14.5 in commit b15a10e.
Conflicts:
test/simple/test-buffer.js
Timothy J Fontaine [Tue, 26 Feb 2013 06:19:16 +0000 (22:19 -0800)]
test: optionally set common.PORT via env variable
Andrei Sedoi [Tue, 26 Feb 2013 14:28:53 +0000 (16:28 +0200)]
mips: fix openssl build
Timothy J Fontaine [Tue, 26 Feb 2013 06:51:00 +0000 (22:51 -0800)]
build: automatically add tag for nightly builds
Ben Noordhuis [Tue, 26 Feb 2013 14:17:26 +0000 (15:17 +0100)]
http: fix case in 505 response status line
Fixes #4850.
Fedor Indutny [Tue, 26 Feb 2013 08:16:35 +0000 (08:16 +0000)]
v8: fix postmortem and dtrace helper build
Regardless of previous @bnoordhuis' changes
Fedor Indutny [Tue, 26 Feb 2013 07:57:12 +0000 (07:57 +0000)]
Revert "sunos: unbreak build after v8 downgrade"
This reverts commit
f80f3c5f62a3955636c1af1872ef9539a0b01cb0.
isaacs [Mon, 25 Feb 2013 16:30:05 +0000 (08:30 -0800)]
bench: Make http easier to profile
Do not run the http/simple.js server in a child process.
Fix #4831
Ben Noordhuis [Tue, 26 Feb 2013 00:21:23 +0000 (01:21 +0100)]
sunos: unbreak build after v8 downgrade
Commit 3d67f89 ("fix generation of v8 constants on freebsd") is an
unfortunate victim of this rollback.
Revert "dtrace: fix generation of v8 constants on freebsd"
Revert "dtrace: More style"
Revert "dtrace: Make D style more D-ish"
Revert "dtrace: x64 ustack helper"
Revert "dtrace: fix style in ustack helper"
Revert "dtrace: SeqAsciiString was renamed to SeqOneByteString in v8"
This reverts commit
3d67f895521cf905922d20af9b03e5c73c363868.
This reverts commit
321b8eec08d445d60a4149bfa71959936fc189c6.
This reverts commit
38df9d51a229e1d74b2d1c2835353f07c784cfc3.
This reverts commit
f9afb3f01002e5667a0df80ee784af0dfe2305c2.
This reverts commit
13296e4b13b5ed192c4faa6501f3efec2ded8ac1.
This reverts commit
3b715edda97c8edfd95cc1fb8d31f92cef6bcc52.
Ben Noordhuis [Mon, 25 Feb 2013 22:25:21 +0000 (23:25 +0100)]
src, test: downgrade to v8 3.14 api
Ben Noordhuis [Mon, 25 Feb 2013 22:00:08 +0000 (23:00 +0100)]
v8: reapply floating patches
Reapply floating patches. Special mention: also reapplies 017009f but
with the extra change of removing DescriptorArray::kTransitionsIndex
from the postmortem metadata generator because said field no longer
exists in V8 3.14.
Ben Noordhuis [Mon, 25 Feb 2013 21:45:23 +0000 (22:45 +0100)]
deps: downgrade v8 to 3.14.5
V8 3.15 and newer have stability and performance issues. Roll back to
a known-good version.
isaacs [Mon, 25 Feb 2013 22:17:11 +0000 (14:17 -0800)]
blog: Update with EINPROGRESS changelog item
isaacs [Mon, 25 Feb 2013 21:57:02 +0000 (13:57 -0800)]
ChangeLog: Missed item about EINPROGRESS
isaacs [Mon, 25 Feb 2013 21:56:46 +0000 (13:56 -0800)]
blog: Post for v0.8.21
isaacs [Mon, 25 Feb 2013 21:52:13 +0000 (13:52 -0800)]
Now working on 0.8.22
isaacs [Mon, 25 Feb 2013 21:51:15 +0000 (13:51 -0800)]
Merge branch 'v0.8.21-release' into v0.8
isaacs [Mon, 25 Feb 2013 18:58:10 +0000 (10:58 -0800)]
2013.02.25, Version 0.8.21 (Stable)
* http: Do not free the wrong parser on socket close (isaacs)
* http: Handle hangup writes more gently (isaacs)
* zlib: fix assert on bad input (Ben Noordhuis)
* test: add TAP output to the test runner (Timothy J Fontaine)
* unix: Handle EINPROGRESS from domain sockets (Ben Noordhuis)
isaacs [Mon, 25 Feb 2013 21:07:08 +0000 (13:07 -0800)]
isaacs [Mon, 25 Feb 2013 17:06:44 +0000 (09:06 -0800)]
http: Do not free the wrong parser on socket close
This appears to fix #4673. That bug is very hard to reproduce, so it's
hard to tell for certain, but this approach is more correct anyway.
Hat-tip: @dougwilson
isaacs [Sat, 23 Feb 2013 00:47:27 +0000 (16:47 -0800)]
stream: Do not switch to objectMode implicitly
Only handle objects if explicitly told to do so in the options
object. Non-buffer/string chunks are an error if not already in
objectMode.
Close #4662
isaacs [Sat, 23 Feb 2013 00:45:22 +0000 (16:45 -0800)]
stream: Start out in sync=true state
The Readable and Writable classes will nextTick certain things
if in sync mode. The sync flag gets unset after a call to _read
or _write. However, most of these behaviors should also be
deferred until nextTick if no reads have been made (for example,
the automatic '_read up to hwm' behavior on Readable.push(chunk))
Set the sync flag to true in the constructor, so that it will not
trigger an immediate 'readable' event, call to _read, before the
user has had a chance to set a _read method implementation.
Ben Noordhuis [Sat, 23 Feb 2013 22:43:52 +0000 (23:43 +0100)]
crypto: fix base64 padding regression
Commit
9901b69c introduces a small regression where the trailing base64
padding is no longer written out when Cipher#final is called. Rectify
that.
Fixes #4837.
Ben Noordhuis [Sun, 24 Feb 2013 03:06:14 +0000 (04:06 +0100)]
test: re-enable simple/test-setproctitle on darwin
The functionality is available again per joyent/libuv@14eb8b0
and joyent/libuv@e89aced.
Fixes #3687.
Ben Noordhuis [Sun, 24 Feb 2013 03:03:49 +0000 (04:03 +0100)]
deps: upgrade libuv to e89aced
isaacs [Sat, 23 Feb 2013 00:30:27 +0000 (16:30 -0800)]
lint
isaacs [Fri, 22 Feb 2013 19:24:05 +0000 (11:24 -0800)]
streams: Pre-emptively buffer readables up to the highWaterMark
Also, this adds a test that guarantees that the ordering of several
push() calls in a row is always preserved in synchronous readable streams
isaacs [Fri, 22 Feb 2013 18:35:07 +0000 (10:35 -0800)]
http: Handle hangup writes more gently
Ben Noordhuis [Fri, 22 Feb 2013 00:19:39 +0000 (01:19 +0100)]
doc: add note about child process line buffering
Fixes #4808.
isaacs [Thu, 21 Feb 2013 22:30:36 +0000 (14:30 -0800)]
stream: Return false from push() more properly
There are cases where a push() call would return true, even though
the thing being pushed was in fact way way larger than the high
water mark, simply because the 'needReadable' was already set, and
would not get unset until nextTick.
In some cases, this could lead to an infinite loop of pushing data
into the buffer, never getting to the 'readable' event which would
unset the needReadable flag.
Fix by splitting up the emitReadable function, so that it always
sets the flag on this tick, even if it defers until nextTick to
actually emit the event.
Also, if we're not ending or already in the process of reading, it
now calls read(0) if we're below the high water mark. Thus, the
highWaterMark value is the intended amount to buffer up to, and it
is smarter about hitting the target.
isaacs [Thu, 21 Feb 2013 18:51:15 +0000 (10:51 -0800)]
stream: remove lowWaterMark feature
It seems like a good idea on the face of it, but lowWaterMarks are
actually not useful, and in practice should always be set to zero.
It would be worthwhile for writers if we actually did some kind of
writev() type of thing, but actually this just delays calling write()
and the overhead of doing a bunch of Buffer copies is not worth the
slight benefit of calling write() fewer times.
isaacs [Thu, 21 Feb 2013 20:22:12 +0000 (12:22 -0800)]
path: Throw TypeError on non-string args to path.resolve
Ben Noordhuis [Thu, 21 Feb 2013 22:58:55 +0000 (23:58 +0100)]
zlib: fix assert on bad input
The following test case occasionally triggered an assert because
write_in_progress_ didn't get cleared on error:
$ cat test.js
require('zlib').gunzip('BAM', console.log);
setTimeout(gc, 10);
$ while true; do node --expose-gc test.js || break; done
{ [Error: incorrect header check] errno: -3, code: 'Z_DATA_ERROR' }
Assertion failed: (!write_in_progress_ && "write in progress"),
function Clear, file ../src/node_zlib.cc, line 71.
Abort trap: 6
Steps to avoid that:
* Initialize all primitive member fields in the constructor.
* Clear the write_in_progress_ member field in ZCtx::Error().
* Ref the ZCtx object as soon as write_in_progress_ is set to true.
Before this commit, it could get GC'ed in the time between setting
the field and the call to ctx->Ref().
Fixes #4783.
Nathan Rajlich [Thu, 21 Feb 2013 20:54:13 +0000 (12:54 -0800)]
test: modify async native test.js to test for #4820
Nathan Rajlich [Thu, 21 Feb 2013 19:02:33 +0000 (11:02 -0800)]
test: add an "async-hello-world" native addon test
Arianit Uka [Thu, 21 Feb 2013 16:44:22 +0000 (11:44 -0500)]
path: join throws TypeError on non-string args
lib/path.js:
- throws a TypeError on the filter if the argument is not a string.
test/simple/test-path.js:
- removed the test to check if non-string types are filtered.
- added a test to check if path.join throws TypeError on arguments that
are not strings.
Fedor Indutny [Thu, 21 Feb 2013 09:28:51 +0000 (13:28 +0400)]
tls: _handle.readStart/readStop for CryptoStream
lib/http.js is using stream._handle.readStart/readStop to control
data-flow coming out from underlying stream. If this methods are not
present - data might be buffered regardless of whether it'll be read.
see #4657
Trevor Norris [Thu, 21 Feb 2013 09:40:09 +0000 (01:40 -0800)]
process: fix bug where spinner wasn't called
Apperently there is a case where calling the spinner was required after
passing a callback to nextTick(). This fixes that issue.
isaacs [Mon, 18 Feb 2013 18:46:50 +0000 (10:46 -0800)]
path: Do not coerce paths to strings on Windows
Fix #4795
Ben Noordhuis [Wed, 20 Feb 2013 21:06:41 +0000 (22:06 +0100)]
stream_wrap: remove superfluous buffer len check
It's a buffer so it's never bigger than Buffer::kMaxLength bytes,
which in turn is always < INT_MAX.
Ben Noordhuis [Wed, 20 Feb 2013 20:12:18 +0000 (21:12 +0100)]
deps: upgrade libuv to 26fa6f8
Trevor Norris [Tue, 19 Feb 2013 07:52:34 +0000 (23:52 -0800)]
buffer: check logic simplification
Checks have been simplified and optimized for most-used cases.
Calling Buffer with another Buffer as the subject will now use the
SlowBuffer Copy method instead of the for loop.
No need to call for value coercion, just place the ternary inline.
Timothy J Fontaine [Wed, 19 Dec 2012 04:10:17 +0000 (23:10 -0500)]
test: add TAP output to the test runner
This is a back-port of commit 14ed173 from the master branch.
isaacs [Wed, 20 Feb 2013 17:17:29 +0000 (09:17 -0800)]
benchmark: Fix alignment issues on --html compare output
Ben Noordhuis [Wed, 20 Feb 2013 13:14:58 +0000 (14:14 +0100)]
node: code cleanup, make tick_infobox static
It's not used outside of src/node.cc so make it static.
Ben Noordhuis [Wed, 15 Aug 2012 00:10:02 +0000 (02:10 +0200)]
crypto: fix uninitialized memory access in openssl
ASN1_STRING_to_UTF8() passes an ASN1_STRING to ASN1_STRING_set() but forgot to
initialize the `length` field.
Fixes the following valgrind error:
$ valgrind -q --track-origins=yes --num-callers=19 \
out/Debug/node test/simple/test-tls-client-abort.js
==2690== Conditional jump or move depends on uninitialised value(s)
==2690== at 0x784B69: ASN1_STRING_set (asn1_lib.c:382)
==2690== by 0x809564: ASN1_mbstring_ncopy (a_mbstr.c:204)
==2690== by 0x8090F0: ASN1_mbstring_copy (a_mbstr.c:86)
==2690== by 0x782F1F: ASN1_STRING_to_UTF8 (a_strex.c:570)
==2690== by 0x78F090: asn1_string_canon (x_name.c:409)
==2690== by 0x78EF17: x509_name_canon (x_name.c:354)
==2690== by 0x78EA7D: x509_name_ex_d2i (x_name.c:210)
==2690== by 0x788058: ASN1_item_ex_d2i (tasn_dec.c:239)
==2690== by 0x7890D4: asn1_template_noexp_d2i (tasn_dec.c:746)
==2690== by 0x788CB6: asn1_template_ex_d2i (tasn_dec.c:607)
==2690== by 0x78877A: ASN1_item_ex_d2i (tasn_dec.c:448)
==2690== by 0x7890D4: asn1_template_noexp_d2i (tasn_dec.c:746)
==2690== by 0x788CB6: asn1_template_ex_d2i (tasn_dec.c:607)
==2690== by 0x78877A: ASN1_item_ex_d2i (tasn_dec.c:448)
==2690== by 0x787C93: ASN1_item_d2i (tasn_dec.c:136)
==2690== by 0x78F5E4: d2i_X509 (x_x509.c:141)
==2690== by 0x7C9B91: PEM_ASN1_read_bio (pem_oth.c:81)
==2690== by 0x7CA506: PEM_read_bio_X509 (pem_x509.c:67)
==2690== by 0x703C9A: node::crypto::SecureContext::AddRootCerts(v8::Arguments const&) (node_crypto.cc:497)
==2690== Uninitialised value was created by a stack allocation
==2690== at 0x782E89: ASN1_STRING_to_UTF8 (a_strex.c:560)
Bert Belder [Wed, 12 Sep 2012 23:03:50 +0000 (01:03 +0200)]
openssl: make perlasm target pentium or newer for masm outputs
When perlasm generates MASM code it sets the assembler target to 468.
In this mode MASM refuses to assemble a couple of instructions. Bumping
the target to 686 solves this problem.
Bert Belder [Fri, 21 Sep 2012 16:07:08 +0000 (18:07 +0200)]
openssl: disable HT sidechannel attack mitigation
It used to be off before. It's extremely unlikely that such an attack
would be a viable attack against node. And it makes AES much slower.
Fedor Indutny [Wed, 20 Feb 2013 11:54:22 +0000 (15:54 +0400)]
openssl: update to 1.0.1e
isaacs [Wed, 20 Feb 2013 01:17:29 +0000 (17:17 -0800)]
Merge branch 'benchmark-refactor-2'
isaacs [Wed, 20 Feb 2013 00:57:59 +0000 (16:57 -0800)]
bench: Add bench-crypto
isaacs [Tue, 19 Feb 2013 23:03:41 +0000 (15:03 -0800)]
bench: Simplify duration arguments to benchmarks
For throughput benchmarks, run with just 5s durations rather than 1s and 3s.
For startup benchmark, run with just a single 1s duration, since it's very
consistent anyway.
isaacs [Tue, 19 Feb 2013 22:59:43 +0000 (14:59 -0800)]
bench: Consistency in benchmark filenames
isaacs [Wed, 13 Feb 2013 22:18:27 +0000 (14:18 -0800)]
bench: Only run http,net,fs,tls by default
isaacs [Wed, 13 Feb 2013 22:16:11 +0000 (14:16 -0800)]
bench: Remove _bench_timer (no loner used)
isaacs [Wed, 13 Feb 2013 20:20:36 +0000 (12:20 -0800)]
bench: Use wrk for http benchmarking
Remove ab, since it's no longer used.
isaacs [Wed, 13 Feb 2013 20:19:08 +0000 (12:19 -0800)]
tools: Add wrk for benchmarking http servers
isaacs [Wed, 13 Feb 2013 18:48:55 +0000 (10:48 -0800)]
bench: Show % change rather than % difference