reed@google.com [Tue, 7 Aug 2012 21:35:13 +0000 (21:35 +0000)]
Privatization:
move SkFDot.h to private
move parts of SkMath.h into SkMathPriv.h
Review URL: https://codereview.appspot.com/6461045
git-svn-id: http://skia.googlecode.com/svn/trunk@4997
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 7 Aug 2012 21:25:27 +0000 (21:25 +0000)]
shape ops work in progress
milestone: all rect tests (639706) work
git-svn-id: http://skia.googlecode.com/svn/trunk@4996
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Tue, 7 Aug 2012 20:41:37 +0000 (20:41 +0000)]
Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia code
Review URL: https://codereview.appspot.com/6445088
git-svn-id: http://skia.googlecode.com/svn/trunk@4995
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 7 Aug 2012 19:49:41 +0000 (19:49 +0000)]
Refactor Bitmap Storage for SkPicture using SkPipe's design.
Refactor Picture and Pipe bitmap storage into common data structure
Update SkFlattenable buffers to be more modular.
This CL is an effort to stage the conversion to named
parameters for all SkFlattenable commands. This particular
stage only does the following two things...
1. Move flattenable buffers from SkFlattenable.h into
their own header.
2. Update and Add new read write methods for better clarity
and convenience.
BUG=
Review URL: https://codereview.appspot.com/6445079
git-svn-id: http://skia.googlecode.com/svn/trunk@4994
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 Aug 2012 18:00:31 +0000 (18:00 +0000)]
Fixing NoGPU build of bench
Problem was: As of r4989, SkDeferredCanvas.h no longer includes SkDevice.h
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@4993
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 7 Aug 2012 17:36:29 +0000 (17:36 +0000)]
uniquely name FS functions, add lighting effects to unit test
Review URL: http://codereview.appspot.com/6458080/
git-svn-id: http://skia.googlecode.com/svn/trunk@4992
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 7 Aug 2012 17:32:51 +0000 (17:32 +0000)]
Adding storage of SkPath::fIsOval
http://codereview.appspot.com/6453085/
git-svn-id: http://skia.googlecode.com/svn/trunk@4991
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Tue, 7 Aug 2012 17:11:33 +0000 (17:11 +0000)]
Refactored the bitmap creation into PictureRenderer.
Further, the picture is also stored in the PictureRenderer.
The main gain of all of this is that we will not have to change how the device in more than one place when we end up adding different devices.
Review URL: https://codereview.appspot.com/6458074
git-svn-id: http://skia.googlecode.com/svn/trunk@4990
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 Aug 2012 16:48:22 +0000 (16:48 +0000)]
Moving DeferredDevice and DeferredGPipeController classes out of the deferred canvas API header
Review URL: https://codereview.appspot.com/6449104
git-svn-id: http://skia.googlecode.com/svn/trunk@4989
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 16:24:03 +0000 (16:24 +0000)]
remove until these stop being flakey
git-svn-id: http://skia.googlecode.com/svn/trunk@4988
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 16:15:13 +0000 (16:15 +0000)]
must include SkPath.h after restructure
git-svn-id: http://skia.googlecode.com/svn/trunk@4987
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Tue, 7 Aug 2012 16:12:23 +0000 (16:12 +0000)]
Refactoring into a public facing facing SkDebugger class first pass.
Review URL: https://codereview.appspot.com/6450096
git-svn-id: http://skia.googlecode.com/svn/trunk@4986
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 16:10:42 +0000 (16:10 +0000)]
include SkFlatteningBuffer.h after restructure
git-svn-id: http://skia.googlecode.com/svn/trunk@4985
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 16:09:27 +0000 (16:09 +0000)]
add baselines after test changed
git-svn-id: http://skia.googlecode.com/svn/trunk@4984
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 7 Aug 2012 16:04:54 +0000 (16:04 +0000)]
Fix for r4978 unit test failure. TBR by Brian
git-svn-id: http://skia.googlecode.com/svn/trunk@4983
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 16:01:15 +0000 (16:01 +0000)]
need to explicitly include SkPath.h after refactoring
git-svn-id: http://skia.googlecode.com/svn/trunk@4982
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 15:56:15 +0000 (15:56 +0000)]
remove as test has changed. Will rebaseline later
git-svn-id: http://skia.googlecode.com/svn/trunk@4981
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 7 Aug 2012 15:54:32 +0000 (15:54 +0000)]
Update SkFlattenable buffers to be more modular.
This CL is an effort to stage the conversion to named
parameters for all SkFlattenable commands. This particular
stage only does the following two things...
1. Move flattenable buffers from SkFlattenable.h into
their own header.
2. Update and Add new read write methods for better clarity
and convenience.
BUG=
Review URL: https://codereview.appspot.com/6448095
git-svn-id: http://skia.googlecode.com/svn/trunk@4980
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 15:53:00 +0000 (15:53 +0000)]
change SkTextToPathIter to allow continuation even when there is no path for
the current glyph. Fixes bug in getTextPath() if there are spaces in the text.
Update gm to add space-characters, so images will have to be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@4979
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 7 Aug 2012 15:38:08 +0000 (15:38 +0000)]
Added SkClipStack portion of new clip mask caching system
http://codereview.appspot.com/6449089/
git-svn-id: http://skia.googlecode.com/svn/trunk@4978
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 15:19:47 +0000 (15:19 +0000)]
move SkTextToPathIter into private header
git-svn-id: http://skia.googlecode.com/svn/trunk@4977
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 Aug 2012 15:14:01 +0000 (15:14 +0000)]
Style correction: sprinkling "this->" in SkDeferredCanvas.cpp
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@4976
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Tue, 7 Aug 2012 15:08:33 +0000 (15:08 +0000)]
Quick mem fix for debug canvas leaking when loading new pics.
Review URL: https://codereview.appspot.com/6454096
git-svn-id: http://skia.googlecode.com/svn/trunk@4975
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 Aug 2012 14:53:59 +0000 (14:53 +0000)]
Removing the SkPicture backend from SkDeferredCanvas code
Review URL: https://codereview.appspot.com/6446095
git-svn-id: http://skia.googlecode.com/svn/trunk@4974
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 7 Aug 2012 14:46:05 +0000 (14:46 +0000)]
Remove verylargebitmap gm on Android
We can't allocate that much memory on Android
Review URL: https://codereview.appspot.com/6460054
git-svn-id: http://skia.googlecode.com/svn/trunk@4973
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 7 Aug 2012 14:26:57 +0000 (14:26 +0000)]
Adding API to SkGPipe and SkDeferredCanvas for controlling memory usage externally
BUG=http://code.google.com/p/chromium/issues/detail?id=136828
Review URL: https://codereview.appspot.com/6454102
git-svn-id: http://skia.googlecode.com/svn/trunk@4971
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 14:25:44 +0000 (14:25 +0000)]
document OwnDeviceCanvas
git-svn-id: http://skia.googlecode.com/svn/trunk@4970
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 14:06:34 +0000 (14:06 +0000)]
initial baselines for very large bitmaps
git-svn-id: http://skia.googlecode.com/svn/trunk@4968
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 14:05:14 +0000 (14:05 +0000)]
add gm for very large bitmaps (>32K >64K)
raster expected to fail when scaling >64K (for now)
git-svn-id: http://skia.googlecode.com/svn/trunk@4967
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 14:03:28 +0000 (14:03 +0000)]
rebaseline after resize
git-svn-id: http://skia.googlecode.com/svn/trunk@4966
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 7 Aug 2012 13:19:01 +0000 (13:19 +0000)]
enable large bitmap drawing by default (still disabled in chrome at the moment)
git-svn-id: http://skia.googlecode.com/svn/trunk@4965
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 7 Aug 2012 12:58:50 +0000 (12:58 +0000)]
Add -logFile option to Bench
Logs to a file as well as stdout. Useful for Android,
where logging takes a different format.
Review URL: https://codereview.appspot.com/6450095
git-svn-id: http://skia.googlecode.com/svn/trunk@4963
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 Aug 2012 21:54:10 +0000 (21:54 +0000)]
update baselines for macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4962
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 Aug 2012 21:20:05 +0000 (21:20 +0000)]
move SkFilterShader into private header
Review URL: https://codereview.appspot.com/6454107
git-svn-id: http://skia.googlecode.com/svn/trunk@4961
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 Aug 2012 19:01:34 +0000 (19:01 +0000)]
Even when the pts are restricted to 32K values, we can still overflow computing
a fixed-point coefficient for quadratics. To avoid this, we bias these
coefficients, storing 1/2 of their actual value, and then apply the 2x unbias
in updateQuadratic().
Fixes http://code.google.com/p/chromium/issues/detail?id=140803
Review URL: https://codereview.appspot.com/6450099
git-svn-id: http://skia.googlecode.com/svn/trunk@4960
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 Aug 2012 14:58:35 +0000 (14:58 +0000)]
If we lose precision computing sum of the dash intervals, then we can have the
same error when we subtract-in-a-loop with the phase. The result is that we can
read past the end of the array.
To fix this, we just pin the loop counter, and if we exhaust our intervals, we
just treat the phase as 0. Not precisely the exact answer, but we aren't going
to draw this dash correctly anyway, since it contains massive interval values
that will be imprecise given our current float implementation.
Fixes http://code.google.com/p/chromium/issues/detail?id=140642
Review URL: https://codereview.appspot.com/6458088
git-svn-id: http://skia.googlecode.com/svn/trunk@4959
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Mon, 6 Aug 2012 14:53:32 +0000 (14:53 +0000)]
rm: Introduce SK_ARM_NEON_WRAP handy wrapper macro.
It is used to simplify arm/neon dispatch logic code.
Review URL: https://codereview.appspot.com/6458060
git-svn-id: http://skia.googlecode.com/svn/trunk@4958
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 6 Aug 2012 14:37:22 +0000 (14:37 +0000)]
add LF at the end, since this is SO important the chrome-mac build failed.
git-svn-id: http://skia.googlecode.com/svn/trunk@4957
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 6 Aug 2012 11:15:47 +0000 (11:15 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4956
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 Aug 2012 20:06:12 +0000 (20:06 +0000)]
tie slow sort (STD) to legacy AA, so that skia can use the fast one, and so that
when chrome disables the legacy flag, it will automatically get the faster one.
git-svn-id: http://skia.googlecode.com/svn/trunk@4955
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 19:25:10 +0000 (19:25 +0000)]
revert gpu-less mac sample app, remove busted sample (that has equivalent gm)
Review URL: https://codereview.appspot.com/6450088/
git-svn-id: http://skia.googlecode.com/svn/trunk@4954
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 18:49:51 +0000 (18:49 +0000)]
Ensure that enums used by GrCustomStage TestCreate functions are declared in SK_ALLOW_GLOBAL_STATIC_INITIALIZERS=0 builds (e.g. android)
git-svn-id: http://skia.googlecode.com/svn/trunk@4953
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 18:22:53 +0000 (18:22 +0000)]
Add .0 on float GLSL literals to fix GLPrograms test break
git-svn-id: http://skia.googlecode.com/svn/trunk@4952
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 18:12:20 +0000 (18:12 +0000)]
Add morphology, convolution, single texture, texture domain effects to new unit test system
Review URL: http://codereview.appspot.com/6442085/
git-svn-id: http://skia.googlecode.com/svn/trunk@4951
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Fri, 3 Aug 2012 17:32:05 +0000 (17:32 +0000)]
Moved the ownership of the current clip and current matrix into the debug canvas as part of the upcoming general refactor to everything living in debug canvas.
Review URL: https://codereview.appspot.com/6447077
git-svn-id: http://skia.googlecode.com/svn/trunk@4950
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 3 Aug 2012 15:05:04 +0000 (15:05 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4949
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 15:00:52 +0000 (15:00 +0000)]
Move SK_SUPPORT_GPU checks below first #includes in case the macro is defined in SkUserConfig.h rather than by the build system.
git-svn-id: http://skia.googlecode.com/svn/trunk@4948
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 14:54:45 +0000 (14:54 +0000)]
Fix includes files missing in release builds from GrCustomStageUnitTest.h.
Also fix SK_SUPPORT_GPU=0 build breaks in gmmain.cpp and GLProgramsTest.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@4947
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 3 Aug 2012 14:34:46 +0000 (14:34 +0000)]
Registry-based unit test for custom effects
Review URL: http://codereview.appspot.com/6447085/
git-svn-id: http://skia.googlecode.com/svn/trunk@4946
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 Aug 2012 13:55:37 +0000 (13:55 +0000)]
fix warngs by casting from float to int64_t
git-svn-id: http://skia.googlecode.com/svn/trunk@4945
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 Aug 2012 13:39:57 +0000 (13:39 +0000)]
--picture foo now works if foo is an image (.png, .jpeg) or a picture (.skp)
git-svn-id: http://skia.googlecode.com/svn/trunk@4944
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 3 Aug 2012 12:45:14 +0000 (12:45 +0000)]
add debugging SkFloatToFixed_Check() which asserts that the float is in range of a fixed
git-svn-id: http://skia.googlecode.com/svn/trunk@4942
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 2 Aug 2012 21:27:54 +0000 (21:27 +0000)]
Add Nexus 7 baseline images
Diff'd against Xoom images.
Review URL: https://codereview.appspot.com/6454087
git-svn-id: http://skia.googlecode.com/svn/trunk@4941
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 2 Aug 2012 20:13:12 +0000 (20:13 +0000)]
Reduce usage of GrGLShaderBuilder::SamplerMode
http://codereview.appspot.com/6453080/
git-svn-id: http://skia.googlecode.com/svn/trunk@4940
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 2 Aug 2012 20:08:21 +0000 (20:08 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4939
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Thu, 2 Aug 2012 18:57:53 +0000 (18:57 +0000)]
render_pictures and bench_pictures now use a --mode parameter.
This replaces the --tile, --pipe, etc. options from before as they are mutually exclusive.
Review URL: https://codereview.appspot.com/6443076
git-svn-id: http://skia.googlecode.com/svn/trunk@4930
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 2 Aug 2012 18:49:49 +0000 (18:49 +0000)]
Store more behavior of SkFlatDictionary in SkFlatController.
Code refactoring for simplicity.
Review URL: https://codereview.appspot.com/6427046
git-svn-id: http://skia.googlecode.com/svn/trunk@4929
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 2 Aug 2012 18:11:43 +0000 (18:11 +0000)]
Move GL programs unit test code to tests project.
Review URL: http://codereview.appspot.com/6453079/
git-svn-id: http://skia.googlecode.com/svn/trunk@4927
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 17:56:02 +0000 (17:56 +0000)]
Skipping MSAA GMs on Android
http://codereview.appspot.com/6453079/
git-svn-id: http://skia.googlecode.com/svn/trunk@4926
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 2 Aug 2012 17:43:25 +0000 (17:43 +0000)]
Fixing leak of SkPixelRef object in CanvasTest
Review URL: https://codereview.appspot.com/6441095
git-svn-id: http://skia.googlecode.com/svn/trunk@4925
2bbb7eff-a529-9590-31e7-
b0007b416f81
twiz@google.com [Thu, 2 Aug 2012 17:32:25 +0000 (17:32 +0000)]
Early out the texture key generation if there is no texture passed to the GrGLShaderBuilder::keyForTextureAccess.
Under normal circumstances, there will always be a passed texture. However, when running in the unit tests, CustomStages are constructed without a texture input.
Review URL: https://codereview.appspot.com/6450083
git-svn-id: http://skia.googlecode.com/svn/trunk@4924
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 16:22:47 +0000 (16:22 +0000)]
Added output of failed GMs to assist tracking errors on Android
http://codereview.appspot.com/6452084/
git-svn-id: http://skia.googlecode.com/svn/trunk@4923
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 2 Aug 2012 16:14:35 +0000 (16:14 +0000)]
Rebaseline convex paths tests.
git-svn-id: http://skia.googlecode.com/svn/trunk@4922
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 2 Aug 2012 16:13:23 +0000 (16:13 +0000)]
Disable ReadWriteAlpha test on Android
Failing on Nexus 7
Bug: http://code.google.com/p/skia/issues/detail?id=753
Review URL: https://codereview.appspot.com/6455077
git-svn-id: http://skia.googlecode.com/svn/trunk@4921
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 16:08:51 +0000 (16:08 +0000)]
create inline version of setLine that assumes no clip. 10% faster for dashing gms
Review URL: https://codereview.appspot.com/6455078
git-svn-id: http://skia.googlecode.com/svn/trunk@4920
2bbb7eff-a529-9590-31e7-
b0007b416f81
twiz@google.com [Thu, 2 Aug 2012 15:15:16 +0000 (15:15 +0000)]
Introduction of set of functions to manage generation of texture fetch shader code.
A new set of routines have been added to GrGLShaderBuilder to emit texture fetches, taking into consideration the format of the texture to be accessed, and the channel swizzle.
Review URL: https://codereview.appspot.com/6446072
git-svn-id: http://skia.googlecode.com/svn/trunk@4919
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 15:12:07 +0000 (15:12 +0000)]
rebaseline after change to test
git-svn-id: http://skia.googlecode.com/svn/trunk@4918
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 2 Aug 2012 14:55:45 +0000 (14:55 +0000)]
Fix infinite recursion in cubic->quad conversion, also attempt to detect nearly flat cubics early.
Review URL: http://codereview.appspot.com/6448100/
THIS WILL REQUIRE REBASELINING OF CONVEXPATHS GM.
git-svn-id: http://skia.googlecode.com/svn/trunk@4917
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 14:26:43 +0000 (14:26 +0000)]
special-case edge-building for polygons (paths with only lines)
makes the dashing bench faster (from 13.4 -> 11.5 ticks)
Review URL: https://codereview.appspot.com/6449080
git-svn-id: http://skia.googlecode.com/svn/trunk@4916
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 14:08:54 +0000 (14:08 +0000)]
rebaseline after change to the test
git-svn-id: http://skia.googlecode.com/svn/trunk@4915
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 14:03:00 +0000 (14:03 +0000)]
Rebaselining complexclip2* and simpleaaclip* for r4905
http://codereview.appspot.com/6443079/
git-svn-id: http://skia.googlecode.com/svn/trunk@4913
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 2 Aug 2012 14:03:32 +0000 (14:03 +0000)]
Create GPU-less build of Skia.
git-svn-id: http://skia.googlecode.com/svn/trunk@4912
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 14:01:36 +0000 (14:01 +0000)]
remove these for now, as they are flaky (or buggy) on macpro
git-svn-id: http://skia.googlecode.com/svn/trunk@4911
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 13:41:40 +0000 (13:41 +0000)]
rebaseline, noting bug in msaa output for hair-curves
http://code.google.com/p/skia/issues/detail?id=754
git-svn-id: http://skia.googlecode.com/svn/trunk@4910
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 13:14:53 +0000 (13:14 +0000)]
rebaseline after change to test
gpu images wrong, but known bug: need to colorize A8 bitmap
git-svn-id: http://skia.googlecode.com/svn/trunk@4909
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 2 Aug 2012 13:09:16 +0000 (13:09 +0000)]
rebaseline after change to test
git-svn-id: http://skia.googlecode.com/svn/trunk@4908
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 12:49:00 +0000 (12:49 +0000)]
Added check for aa/bw rect merging
http://codereview.appspot.com/6449079/
git-svn-id: http://skia.googlecode.com/svn/trunk@4907
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 12:42:43 +0000 (12:42 +0000)]
Fixed oversized SkRegion bound problem for complexclip_aa GM
http://codereview.appspot.com/6447076/
git-svn-id: http://skia.googlecode.com/svn/trunk@4906
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 2 Aug 2012 12:37:01 +0000 (12:37 +0000)]
Translated clip GMs to increase stability
http://codereview.appspot.com/6458064/
This will require rebaselining of complexclip2* & simplaaaclip*
git-svn-id: http://skia.googlecode.com/svn/trunk@4905
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 2 Aug 2012 10:06:19 +0000 (10:06 +0000)]
Set fReservedAlign to 0.
Cleans scalar context key and should fix http://code.google.com/p/chromium/issues/detail?id=140196
git-svn-id: http://skia.googlecode.com/svn/trunk@4904
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 1 Aug 2012 21:52:22 +0000 (21:52 +0000)]
rebaseline after gpu change
git-svn-id: http://skia.googlecode.com/svn/trunk@4903
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 1 Aug 2012 20:53:33 +0000 (20:53 +0000)]
Fix memory leak in gammatext GM.
Review URL: https://codereview.appspot.com/6458055
git-svn-id: http://skia.googlecode.com/svn/trunk@4902
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 1 Aug 2012 20:16:34 +0000 (20:16 +0000)]
Replace the asAFoo() functions in SkImageFilter with canFilterImageGPU() and
onFilterImageGPU() virtuals. This allows each filter to implement its own GPU
processing code, even for multi-pass filters.
Review URL: http://codereview.appspot.com/6449075/
git-svn-id: http://skia.googlecode.com/svn/trunk@4900
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 1 Aug 2012 20:08:47 +0000 (20:08 +0000)]
Removed GrClip & related classes
http://codereview.appspot.com/6450071/
git-svn-id: http://skia.googlecode.com/svn/trunk@4899
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 1 Aug 2012 20:01:49 +0000 (20:01 +0000)]
check that copied paths have the same segment-masks as their src
git-svn-id: http://skia.googlecode.com/svn/trunk@4898
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 1 Aug 2012 20:00:03 +0000 (20:00 +0000)]
Turning on deferred canvas SkGPipe backend by default
Review URL: https://codereview.appspot.com/6452080
git-svn-id: http://skia.googlecode.com/svn/trunk@4897
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 1 Aug 2012 19:34:20 +0000 (19:34 +0000)]
Pipe factory names independently from the flattenables using them.
Avoids an issue where a flattenable written twice might be written
differently (the first time the flat data may have a name, whereas
the second time it will have an index).
Also add a test which confirms that identical flattenables will have
the same SkFlatData representation.
BUG=https://code.google.com/p/skia/issues/detail?id=721
TEST=FlatDataTest.cpp
Review URL: https://codereview.appspot.com/6431057
git-svn-id: http://skia.googlecode.com/svn/trunk@4896
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Wed, 1 Aug 2012 17:58:01 +0000 (17:58 +0000)]
Added --picture flag to SampleApp, loads individual skp.
Review URL: https://codereview.appspot.com/6452077
git-svn-id: http://skia.googlecode.com/svn/trunk@4895
2bbb7eff-a529-9590-31e7-
b0007b416f81
keyar@chromium.org [Wed, 1 Aug 2012 17:53:29 +0000 (17:53 +0000)]
Merged bench_pictures and render_pictures rendering methods.
bench_pictures now uses a class based method for choosing the benchmark type as well.
Review URL: https://codereview.appspot.com/6452070
git-svn-id: http://skia.googlecode.com/svn/trunk@4894
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Wed, 1 Aug 2012 16:10:06 +0000 (16:10 +0000)]
Added more DrawPoints debugging info for inspector
Review URL: https://codereview.appspot.com/6441084
git-svn-id: http://skia.googlecode.com/svn/trunk@4893
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Wed, 1 Aug 2012 15:58:41 +0000 (15:58 +0000)]
arm: Move SkUtilsArm.h from include/core to src/core
There is no reason to make this visible to client code.
Review URL: https://codereview.appspot.com/6441082
git-svn-id: http://skia.googlecode.com/svn/trunk@4892
2bbb7eff-a529-9590-31e7-
b0007b416f81
chudy@google.com [Wed, 1 Aug 2012 15:57:52 +0000 (15:57 +0000)]
Optimization: SkDebugCanvas is capable of pausing and drawing incrementally instead of redrawing all commands.
Review URL: https://codereview.appspot.com/6458056
git-svn-id: http://skia.googlecode.com/svn/trunk@4891
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 1 Aug 2012 15:36:46 +0000 (15:36 +0000)]
Handle rgb_to_a8 when kGenA8FromLCD_Flag is set.
git-svn-id: http://skia.googlecode.com/svn/trunk@4889
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Wed, 1 Aug 2012 14:25:07 +0000 (14:25 +0000)]
arm: dynamic NEON support for SkBitmapProcState matrix operations.
This patch implements dynamic ARM NEON support for the functions
implemented by src/core/SkBitmapProcState_matrixProcs.cpp.
- Because the SkBitmapProcState_matrix_{clamp,repeat}.h headers
are NEON-specific, they are renamed with a _neon.h suffix, and
moved to src/opts/ (from src/core/)
- Add a new file src/opts/SkBitmapProcState_matrixProcs_neon.cpp
which implements the NEON code paths for all builds, and add
it to the 'opts_neon' static library.
- Modify SkBitmapProcState_matrixProcs.cpp to select the right
code-path depending on our build configuration. Note that in
the case where 'arm_neon == 1', we do not embed regular ARM
code paths in the final binary. Only 'arm_neon_optional == 1'
builds will contain both regular and NEON code paths at the
same time.
Note that there doesn't seem to be a simple way to put the
NEON-specific selection from that currently is in
SkBitmapProcState_matrixProcs.cpp into src/opts/. Doing so
would require much more drastic restructuring. This is also
true of the other SkBitmapProcState source files that will
be touched in a future patch.
Review URL: https://codereview.appspot.com/6453065
git-svn-id: http://skia.googlecode.com/svn/trunk@4888
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 1 Aug 2012 13:30:54 +0000 (13:30 +0000)]
Whitespace change to see if local bot triggers a rebuild
git-svn-id: http://skia.googlecode.com/svn/trunk@4887
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 31 Jul 2012 22:17:45 +0000 (22:17 +0000)]
Whitespace change to see if local bot triggers a rebuild
git-svn-id: http://skia.googlecode.com/svn/trunk@4877
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 31 Jul 2012 21:39:05 +0000 (21:39 +0000)]
Fix units per em test.
git-svn-id: http://skia.googlecode.com/svn/trunk@4873
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 31 Jul 2012 21:01:51 +0000 (21:01 +0000)]
Prevent deferred canvases from recording draw operations that use an SkPaint object that indirectly references a GPU resource.
The specific case targeted by this patch is SkBitmapProcShaders that use an SkBitmap object that references a GPU texture.
BUG=http://code.google.com/p/chromium/issues/detail?id=139204
Review URL: https://codereview.appspot.com/6447068
git-svn-id: http://skia.googlecode.com/svn/trunk@4871
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Tue, 31 Jul 2012 20:38:06 +0000 (20:38 +0000)]
Remove old constructors from GrGradientEffect subclasses, and moved their declarations into source files.
Review URL: https://codereview.appspot.com/6449067
git-svn-id: http://skia.googlecode.com/svn/trunk@4870
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 31 Jul 2012 20:32:48 +0000 (20:32 +0000)]
Image rebaselines for r4865 (complexclip2 _gpu & _msaa)
http://codereview.appspot.com/6454075/
git-svn-id: http://skia.googlecode.com/svn/trunk@4869
2bbb7eff-a529-9590-31e7-
b0007b416f81