Brian Sullivan [Mon, 14 Mar 2016 19:56:18 +0000 (12:56 -0700)]
Updated with NEW_PASS tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e96968dbed9c6e055ed9dedf2127074c07b6524
Brian Sullivan [Fri, 11 Mar 2016 22:27:25 +0000 (14:27 -0800)]
Major Update for new tests
Updated Tests.lst and preserved Categories tags
We can run all of the Pro, Pri1 tests
We currently run only the ones that were passing
from the previous Tests.lst file
Commit migrated from https://github.com/dotnet/coreclr/commit/
f962259926f481ca0cb172c475ca247039eac944
Matt Mitchell [Fri, 11 Mar 2016 21:14:34 +0000 (13:14 -0800)]
Merge pull request dotnet/coreclr#3197 from mmitche/branchify
[Do Not Merge] Move coreclr to branch model
Commit migrated from https://github.com/dotnet/coreclr/commit/
f410086cc69908e6bd58eff10a20848ea9139927
Jan Kotas [Fri, 11 Mar 2016 19:14:49 +0000 (11:14 -0800)]
Merge pull request dotnet/coreclr#3658 from leemgs/upstream-doc-crossbuild
Documentation: Remove the "patching Urcu" section
Commit migrated from https://github.com/dotnet/coreclr/commit/
de160652475ad578482e2167d031669f8c4bf04d
Sejong Oh [Fri, 11 Mar 2016 19:04:24 +0000 (11:04 -0800)]
Merge pull request dotnet/coreclr#3645 from sejongoh/increase_gctest_time_out
Increase timeout and crond schedule for GC stress testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae11f91bb1695bb455038223af0ed7bc1a26d45c
Matt Mitchell [Fri, 11 Mar 2016 18:45:32 +0000 (10:45 -0800)]
Move coreclr to branched CI model
This moves coreclr to the branch-based CI model. In this model, instead of having the CI generate jobs out of dotnet/coreclr's master branch for all branches (using all sorts of odd naming suffixes of course), the master CI lists tell the CI which branches it should look at for CI config info. It passes the branch name to the netci file, which then can use it to tell the SCM to pull code from specific branches or set branch specific PR triggers.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5554efef30ed1e4bc4987b7a7aae5b92990c21e
Brian Sullivan [Fri, 11 Mar 2016 18:03:03 +0000 (10:03 -0800)]
Merge pull request dotnet/coreclr#3653 from briansull/migrate-tags
Add migrate-tags.py script for migrating Smarty tags
Commit migrated from https://github.com/dotnet/coreclr/commit/
04e4994ac9e983c471d46b72ceb969bf4bff5622
Sean Gillespie [Fri, 11 Mar 2016 17:57:38 +0000 (09:57 -0800)]
Merge pull request dotnet/coreclr#3252 from mjp41/master
Fixed parent pointers becoming corrupt in GC benchmark for Red/Black trees
Commit migrated from https://github.com/dotnet/coreclr/commit/
0804ca9aa4dde3958d9eadb78aba1aba913a6877
Brian Sullivan [Fri, 11 Mar 2016 17:52:27 +0000 (09:52 -0800)]
Added Header and other Codereview feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
57c819d2b467d96aa0c0b4ae393a17714338698f
Geunsik Lim [Fri, 11 Mar 2016 10:30:12 +0000 (19:30 +0900)]
Documentation: Remove Patching Urcu Section
Atomic function parameter types Urcu is already fixed.
We don't need any manual patching for the cross build.
Let's remove this section from now on.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2e59cffc59bfc86f4812bb9fe54cfaae9e24f01
Sejong Oh [Thu, 10 Mar 2016 23:57:09 +0000 (15:57 -0800)]
a This is a combination of 2 commits.
Increase timeout and crond schedule for GC stress testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d9a286c5a465e543bca1733ed2cf1a51e5b13b4
Sejong Oh [Fri, 11 Mar 2016 07:31:18 +0000 (23:31 -0800)]
Merge pull request dotnet/coreclr#3630 from sejongoh/pull_down_coredistool_windows
Pull down coredistool package on Windows
Commit migrated from https://github.com/dotnet/coreclr/commit/
586ce538403c1b859f73d97abec9bb4bfad4cab7
Brian Sullivan [Fri, 11 Mar 2016 03:31:35 +0000 (19:31 -0800)]
Add migrate-tags.py script for migrating Smarty tags
Also added a test case for the script
Commit migrated from https://github.com/dotnet/coreclr/commit/
843ad926b21a72c7c79a52c589347c5fda7e4d35
Sergiy Kuryata [Fri, 11 Mar 2016 02:02:04 +0000 (18:02 -0800)]
Merge pull request dotnet/coreclr#3647 from dagood/fix-pri1-test-dependencies
Fix priority 1 tests: add missing dependencies
Commit migrated from https://github.com/dotnet/coreclr/commit/
efc4eba1b0f05fe7da21c83221e856a53cee6f34
Andy Ayers [Fri, 11 Mar 2016 02:01:36 +0000 (18:01 -0800)]
Merge pull request dotnet/coreclr#3632 from AndyAyersMS/InlineRefactorMoveProfitability
Inline refactoring: move profitability assessment to LegacyPolicy
Commit migrated from https://github.com/dotnet/coreclr/commit/
53d42099f2fd762d4584aee3c97d1cf35c4f0074
Rahul Kumar [Fri, 11 Mar 2016 01:55:27 +0000 (17:55 -0800)]
Merge pull request dotnet/coreclr#3652 from rahku/EHTestPort
exclude test baseservices\exceptions\regressions\Dev11\147911
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e1e3eaaf07ff5a9773a8720da39fe86f61c36af
Rahul Kumar [Fri, 11 Mar 2016 01:03:11 +0000 (17:03 -0800)]
exclude test baseservices\exceptions\regressions\Dev11\147911
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe8033227ee802fb24080dede387a18040cacc61
John Chen [Fri, 11 Mar 2016 00:42:28 +0000 (16:42 -0800)]
Merge pull request dotnet/coreclr#3644 from JohnChen0/master
Fix a GC hole in a Ready-to-Run helper
Commit migrated from https://github.com/dotnet/coreclr/commit/
87191254b67daf43f776a786a37d69dbf3b97b69
Davis Goodin [Fri, 11 Mar 2016 00:04:53 +0000 (18:04 -0600)]
Add new dependencies to tests where package upgrade moved types.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fefb39a3c88da856c7edafa4297c956f02d46b3e
Eugene Rozenfeld [Thu, 10 Mar 2016 23:19:24 +0000 (15:19 -0800)]
Merge pull request dotnet/coreclr#3641 from erozenfeld/GetCORSystemDirectoryInternaLFix
Fix for a bug in GetCORSystemDirectoryInternaL
Commit migrated from https://github.com/dotnet/coreclr/commit/
f52f83ff7e5f7742d800565b6b80c79e4eee7821
Sejong Oh [Wed, 9 Mar 2016 02:11:57 +0000 (18:11 -0800)]
Pull down coredistool package on Windows
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae020a10676a04c12a0c3aa1265069e37b0296e5
Rahul Kumar [Thu, 10 Mar 2016 23:05:34 +0000 (15:05 -0800)]
Merge pull request dotnet/coreclr#3640 from rahku/EHTestPort
Fix arm64 build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
aac4640f6d5c8c64554face6312f61198f00d624
John Chen (CLR) [Thu, 10 Mar 2016 23:04:44 +0000 (15:04 -0800)]
Fix a GC hole in a Ready-to-Run helper
Assembly routines DelayLoad_Helper* were putting an argument at a
wrong location on the stack. This resulted in a GC hole that caused
random crashes, such as dotnet/clidotnet/coreclr#1785 and dotnet/roslyndotnet/coreclr#9632.
Commit migrated from https://github.com/dotnet/coreclr/commit/
16cc69ad6efcc4496969ba097e1fed34ca5d1d11
Aditya Mandaleeka [Thu, 10 Mar 2016 22:29:43 +0000 (14:29 -0800)]
Merge pull request dotnet/coreclr#3603 from bendono/doc
Fix spelling and grammar.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c920d643f4e95699e477c568174350279c9b88e1
Eugene Rozenfeld [Thu, 10 Mar 2016 21:05:23 +0000 (13:05 -0800)]
Fix for a bug in GetCORSystemDirectoryInternaL
Change dotnet/coreclr@
7045ca7a6de381b382a709dc0a61f49ca713d160 introduced a bug in
GetCORSystemDirectoryInternaL. The second parameter of GetRuntimeDirectory
is in/out so passing a pointer to an uninitialized cchBuffer was wrong.
The fix is to initialize cchBuffer to MAX_PATH - 1.
This was causing failures in some non CoreClr ngen scenarios.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ebfb37f98fc2f17b97763838c17b18dd396dc68
Matthew Parkinson [Thu, 10 Mar 2016 20:37:41 +0000 (20:37 +0000)]
Addressing code review feedback.
Commit migrated from https://github.com/dotnet/coreclr/commit/
03809e9754f09cd5a3b404fe098b1ea9cfbcef37
Jan Vorlicek [Thu, 10 Mar 2016 20:32:38 +0000 (21:32 +0100)]
Merge pull request dotnet/coreclr#3639 from svick/patch-1
Remove incorrect escaping in example in BOTR
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cdd7726e0616628616b2dcb0cf24baf35c7eee8
Rahul Kumar [Thu, 10 Mar 2016 19:55:30 +0000 (11:55 -0800)]
Fix arm64 build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
636f5f83cfa6b0fbab8cdbee73dfe02fee1aa0f5
Sejong Oh [Thu, 10 Mar 2016 19:08:15 +0000 (11:08 -0800)]
Merge pull request dotnet/coreclr#3638 from sejongoh/quick_path_fix_for_init_tool_sh
Fix shell command to execute init-tool.sh on CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
712f8c0a1a56da93f173b2f970a7a4f6156ccc40
Petr Onderka [Thu, 10 Mar 2016 18:32:25 +0000 (19:32 +0100)]
Remove incorrect escaping in example in BOTR
The example was casting to `ArrayMethodDesc\*` (note the backslash, possibly there to avoid italics formatting in some previous version?), which doesn't make sense. Now it casts to `ArrayMethodDesc*`.
Also, since I'm already changing this snippet, enable syntax highlighting as C++ for it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
04dc1e0fe809ef973f0d8d3e00d17fa4f0d4f524
Davis Goodin [Thu, 10 Mar 2016 18:13:45 +0000 (12:13 -0600)]
Merge pull request dotnet/coreclr#3589 from dagood/test-dependency-validation
Add dependency validation/tooled-upgrade and make dependencies valid under new rules
Commit migrated from https://github.com/dotnet/coreclr/commit/
43cc989069c400c939f1d4df878876523bf336ed
Sejong Oh [Thu, 10 Mar 2016 17:39:10 +0000 (09:39 -0800)]
Fix shell command to execute init-tool.sh on CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
6197bd9255a99458e2bfbf75b661fd4d53702ff6
Davis Goodin [Thu, 10 Mar 2016 15:28:41 +0000 (09:28 -0600)]
Fix the centralized GC test project.jsons and other new project.jsons from merge.
Commit migrated from https://github.com/dotnet/coreclr/commit/
95f2ca67a3930c54ccaa9e01e0c68b94cda67a82
Davis Goodin [Wed, 9 Mar 2016 22:45:07 +0000 (16:45 -0600)]
Upgrade new test project.json files from merge.
Commit migrated from https://github.com/dotnet/coreclr/commit/
beb3728f9b9d1fe14bae36a08386004066a9ddaf
Davis Goodin [Tue, 8 Mar 2016 17:52:24 +0000 (11:52 -0600)]
Add documentation for dependency validation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c134e7cd3862101634ff0b67c0bed10780b52d11
Davis Goodin [Thu, 3 Mar 2016 23:18:51 +0000 (17:18 -0600)]
Add System.Threading.Thread to tests to restore missing types.
Upgrade System.Runtime dependency for JIT tests to get GCHandle.
Change system.runtime 4.0.20 to 4.1.0 rc2 dependency to try to copy the runtimes to CORE_ROOT.
Fix new project.json files.
Fix hardcoded Microsoft.DotNet.xunit.performance version.
Upgrade System.Runtime.InteropServices to prerelease level to avoid type conflicts with System.Runtime.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6b58c35d0652f49194782a80a7c5a63d432a9ff
Davis Goodin [Thu, 3 Mar 2016 22:30:38 +0000 (16:30 -0600)]
Update dependencies on packages that don't exist.
First checks to see if a stable version of that dependency was restored, and if not, found the stable.minor.patch version with the prerelease spec of the dependency.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a37446b560c138ff7d661c4c37971f31f92ed066
Davis Goodin [Thu, 3 Mar 2016 21:41:17 +0000 (15:41 -0600)]
Add working validation rules for xunit packages and apply them.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3aadaff51856448d9a9f262e31cc5cdf6d2259ed
Davis Goodin [Thu, 3 Mar 2016 21:28:52 +0000 (15:28 -0600)]
Remove potentially unused System.Numerics.Vectors.WindowsRuntime reference and spare WindowsRuntime.
Commit migrated from https://github.com/dotnet/coreclr/commit/
09f29a50f821dbdec83f7bc95d4073ccd4d3f151
Davis Goodin [Thu, 3 Mar 2016 21:05:15 +0000 (15:05 -0600)]
Update all versions to validate.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3e4e27cfa264ca3b8cd7bef5370ec009e7ceaf04
Davis Goodin [Thu, 3 Mar 2016 01:31:29 +0000 (19:31 -0600)]
Add validation to test build.
Don't validate generated files, and make the xunit.runner.msbuild workaround only apply to that specific package.
Commit migrated from https://github.com/dotnet/coreclr/commit/
899d4270b510f5edd1242def8d201b1804dd7683
Jan Kotas [Thu, 10 Mar 2016 15:01:30 +0000 (07:01 -0800)]
Merge pull request dotnet/coreclr#3629 from leemgs/upstream-crossbuild2
Add comment about disabling crossgen command for cross build
Commit migrated from https://github.com/dotnet/coreclr/commit/
2325dea4efa87fc658cb566454e4955f7269ddf6
Sean Gillespie [Thu, 10 Mar 2016 02:57:22 +0000 (18:57 -0800)]
Merge pull request dotnet/coreclr#3394 from swgillespie/gctests
Initial bringup of new set of ported GC tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e483278934c3140092a4b6913fe5d7c88d5d943e
Andy Ayers [Thu, 10 Mar 2016 00:04:11 +0000 (16:04 -0800)]
Inline refactoring: move profitability assessment to LegacyPolicy
LegacyPolicy now encapsulates all the computations needed to evaluate
whether an inline is profitable or not.
This completes the main objective of the refactoring effort, which
was to preserve and encapsulate the current inliner's behavior.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9cbd25871b360647686a79be6d9021bbefd84313
Rahul Kumar [Thu, 10 Mar 2016 01:52:13 +0000 (17:52 -0800)]
Merge pull request dotnet/coreclr#3489 from rahku/EHTestPort
Port EH tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
587e7c08ef1edc53d2ce6bf90da0c63ba70aa00b
Rahul Kumar [Wed, 2 Mar 2016 22:36:15 +0000 (14:36 -0800)]
Port EH tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d81c5359b5083ef4b08ebc3b3ebd8b8764fe418
Geunsik Lim [Thu, 10 Mar 2016 01:46:23 +0000 (10:46 +0900)]
Remove unnecessary expressions.
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
39d7c15e7875a025779d545ccd51ad9d12f0495e
Sean Gillespie [Fri, 26 Feb 2016 22:56:07 +0000 (14:56 -0800)]
Initial bringup of new set of ported GC tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f7c51223d7b3a0153b002b30f619a7f02ff4fc99
Jose Perez Rodriguez [Thu, 10 Mar 2016 01:23:12 +0000 (17:23 -0800)]
Merge pull request dotnet/coreclr#3598 from joperezr/DisableOpenSourceSign
Disable OpenSourceSign and update BuildTools
Commit migrated from https://github.com/dotnet/coreclr/commit/
f178841cda726a30b98ae42529b0cadb6a486151
Jose Perez Rodriguez [Wed, 9 Mar 2016 00:51:35 +0000 (16:51 -0800)]
Disable OpenSourceSign and update Build Tools
Commit migrated from https://github.com/dotnet/coreclr/commit/
227e648d5b2d605e81498ab0b9a06d5e2998590b
Geunsik Lim [Thu, 10 Mar 2016 00:56:27 +0000 (09:56 +0900)]
Add comment about disabling crossgen command for cross build
As we all know, the current cross build generates exectuable
'crossgen' with arm architecture (without x86 architecture).
So, it can not be run to make mscorlib.ni.dll from mscorlib.dll
on X86-based build machine.
Let's add a comment why we have to skip crossgen command in
build_mscorlib() of build.sh in case of cross build for Linux/ARM.
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
af1b954466de2b931809434bf8ad4dc355dc3e98
Rama krishnan Raghupathy [Thu, 10 Mar 2016 00:38:45 +0000 (16:38 -0800)]
Merge pull request dotnet/coreclr#3599 from ramarag/arm64nativetests
Enable native test binaries to be built for Arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
ced387bc0c0e40e4eaacaaa03c65674d290a278c
Andy Ayers [Wed, 9 Mar 2016 23:57:20 +0000 (15:57 -0800)]
Merge pull request dotnet/coreclr#3626 from AndyAyersMS/InlineRefactorFixNames
Fix various naming convention issues in inliner code
Commit migrated from https://github.com/dotnet/coreclr/commit/
81b744d0ea64dc468b48ba35be187d9612c10246
Aditya Mandaleeka [Wed, 9 Mar 2016 22:57:00 +0000 (14:57 -0800)]
Merge pull request dotnet/coreclr#3624 from adityamandaleeka/remove_threadstatic_duplicates
Remove duplicate ThreadStatic tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
426c72fe0ed988b7b00257a48118e9a389cba4e0
Pat Gavlin [Wed, 9 Mar 2016 22:32:39 +0000 (14:32 -0800)]
Merge pull request dotnet/coreclr#3625 from pgavlin/SupportPackageVersion
Accept a build number arg in BuildRyuJitPackage.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2cc393ab07c4cbca5b92e09d181a9ff585b321c
Rama Krishnan Raghupathy [Wed, 9 Mar 2016 02:26:13 +0000 (18:26 -0800)]
Enable native test binaries to be built for Arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8f570dc3028cab153fb6a007ba8d24abb4e1fd3
Andy Ayers [Wed, 9 Mar 2016 19:47:42 +0000 (11:47 -0800)]
Fix various naming convention issues in inliner code
Per the jit coding conventions, rename all class member functions to be
CamelCase. Rename all class data members to begin with `m_`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d55384e34b79c6fd4a5aac212c2645ed6c8a3ee
tijoytom [Wed, 9 Mar 2016 21:45:14 +0000 (13:45 -0800)]
Merge pull request dotnet/coreclr#3562 from tijoytom/master
Improve interop test coverage.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa7e809b17530818975b7c2212f241c1f91d0fe4
Pat Gavlin [Wed, 9 Mar 2016 21:13:02 +0000 (13:13 -0800)]
Accept a build number arg in BuildRyuJitPackage.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bcea96c0db6cc112125a16e862fcb5ffb0da5602
Andy Ayers [Wed, 9 Mar 2016 20:52:52 +0000 (12:52 -0800)]
Merge pull request dotnet/coreclr#3602 from AndyAyersMS/InlineRefactorNativeSize
Inline refactoring: move native callsite estimator
Commit migrated from https://github.com/dotnet/coreclr/commit/
e482ecaaf35a158b463b170d9f02f43fe5fab870
Aditya Mandaleeka [Wed, 9 Mar 2016 20:17:19 +0000 (12:17 -0800)]
Remove duplicate ThreadStatic tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a1ef8c553cf3e61c1b1eb97a49ea4564873817ad
tijoytom [Wed, 9 Mar 2016 19:14:09 +0000 (11:14 -0800)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Commit migrated from https://github.com/dotnet/coreclr/commit/
c661bd0b7a6535713b4d7ec443c787ebb07c7688
Andy Ayers [Tue, 8 Mar 2016 23:13:56 +0000 (15:13 -0800)]
Inline refactoring: move native callsite estimator
Move the native call site estimation logic into `LegacyPolicy`. Rework
the remaining per-callsite bonus multipliers so that they fit into the
observation framework. Remove `hasNativeSizeEstimate` and instead
check that the inline is a candidate and its observation is a
discretionary inline. Fix header comment in `fgFindJumpTargets`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
97c0fcb5bb5b85d45854dcd25e60020215ff6ef9
tijoytom [Wed, 9 Mar 2016 18:07:18 +0000 (10:07 -0800)]
skip ci please
Disable test for legacy backend
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f3605d35c654fe32a7716302b50600a12d8e6d1
Mike McLaughlin [Wed, 9 Mar 2016 17:48:29 +0000 (09:48 -0800)]
Merge pull request dotnet/coreclr#3567 from mikem8361/dbgshimcp
Add process launch APIs to dbgshim
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1b881989aff677980de55a1134e4834f836011b
Matt Mitchell [Wed, 9 Mar 2016 16:26:38 +0000 (08:26 -0800)]
Merge pull request dotnet/coreclr#3621 from kyulee1/arm64
Add folks to private run
Commit migrated from https://github.com/dotnet/coreclr/commit/
42f4d96cdd8fd16630bbcd964a31bedeebeefb15
Kyungwoo Lee [Wed, 9 Mar 2016 15:04:36 +0000 (07:04 -0800)]
Add folks to private run
Commit migrated from https://github.com/dotnet/coreclr/commit/
2cc2dba076908456b6322accace83fe99257d71a
Jan Vorlicek [Wed, 9 Mar 2016 10:20:37 +0000 (11:20 +0100)]
Merge pull request dotnet/coreclr#3595 from janvorli/fix-stack-walk-with-finally
Fix stack walking on Unix in case of finally
Commit migrated from https://github.com/dotnet/coreclr/commit/
b219fbbe1fe72b4a44b5247c9a77f9447d34b028
Sejong Oh [Wed, 9 Mar 2016 07:16:03 +0000 (23:16 -0800)]
Merge pull request dotnet/coreclr#3558 from sejongoh/fix_gc_stress_setup_fail
Fix GC stress setup failure on Unix-like OSes
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb59dda088e11cdd8350cdadf467f5dc3b1f9abc
Ben Monroe [Wed, 9 Mar 2016 02:28:46 +0000 (11:28 +0900)]
Fix spelling and grammar.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a0c8fe6582d93037486c0179bb7591948380fb45
Mike McLaughlin [Sat, 5 Mar 2016 01:19:20 +0000 (17:19 -0800)]
Added CreateProcessForLaunch, ResumeProcess and CloseResumeHandle that can
be better supported cross-plat.
Commit migrated from https://github.com/dotnet/coreclr/commit/
86103a426ace432520c28b0f7ac19bcb88ce8343
Andy Ayers [Wed, 9 Mar 2016 02:02:56 +0000 (18:02 -0800)]
Merge pull request dotnet/coreclr#3574 from AndyAyersMS/InlineRefactorMoveStateMachineMerge
Inline refactoring: move state machine into LegacyPolicy
Commit migrated from https://github.com/dotnet/coreclr/commit/
d2ab1fbd40343e01fcb71fb9793ee7c681eeb1de
Jan Vorlicek [Wed, 9 Mar 2016 01:49:14 +0000 (02:49 +0100)]
Merge pull request dotnet/coreclr#3588 from janvorli/fix-exception-in-finalizer
Fix Unix exception handling in finalizers
Commit migrated from https://github.com/dotnet/coreclr/commit/
770f74904b900d77853c3e94370bc36fa3e97340
Kyungwoo Lee [Wed, 9 Mar 2016 01:20:58 +0000 (17:20 -0800)]
Merge pull request dotnet/coreclr#3478 from kyulee1/var
Fix for asserting var addr on stack
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae2ae64adf19256fd7db7a35d6e836598e77abdc
Stephen Toub [Wed, 9 Mar 2016 00:03:14 +0000 (19:03 -0500)]
Merge pull request dotnet/coreclr#3575 from stephentoub/argexception_names
Add missing parameter name to GetEra ArgumentOutOfRangeException
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdbc51ff1e216804027533baa42eb9c9be7bef1f
Pat Gavlin [Tue, 8 Mar 2016 23:37:06 +0000 (15:37 -0800)]
Merge pull request dotnet/coreclr#3594 from pgavlin/GcInfoEncoderCleanup
Move some definitions out of gcinfoencoder.h.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f93d49062343b12b2e0eb5fab5d4cfa9524370a
Pat Gavlin [Tue, 8 Mar 2016 21:42:39 +0000 (13:42 -0800)]
Move some definitions out of gcinfoencoder.h.
There are a number of macros, method bodies, and type definitions that
do not need to be in gcinfoencoder.h. Instead, these definitions have
been moved into gcinfoencoder.cpp.
Commit migrated from https://github.com/dotnet/coreclr/commit/
98f288530eaa97a5e8ef5c796e6db24c1ac65f49
Pat Gavlin [Tue, 8 Mar 2016 21:42:13 +0000 (13:42 -0800)]
Merge pull request dotnet/coreclr#3587 from pgavlin/UseListInLSRA
Use jitstd::list in the LSRA.
Commit migrated from https://github.com/dotnet/coreclr/commit/
debf196f65f3851a3693805fd1707413fa70d76a
Jan Vorlicek [Mon, 7 Mar 2016 22:17:10 +0000 (23:17 +0100)]
Fix stack walking on Unix in case of finally
The issue is that the code in the StackFrameIterator::Filter that handles cases
when a funclet frame that was already removed from the stack due to native frames
unwinding works for catch funclets only and not for finally ones.
The ExceptionTracker::GetCallerOfActualHandlingFrame is set for catch funclets
only. To make it work for the finally funclets as well, we need to use information
from the ExceptionTracker::m_EnclosingClauseInfoForGCReporting instead.
There was also another problem in the Filter method that caused the function to
spin in an infinite loop when a parent of a funclet was also a funclet. In
such case, the code in the method rechecks the current frame but the special
functionality to check the exception trackers data needs to be skipped for
the recheck.
And finally, when we find that the current frame was a parent of an unwound
funclet from the evidence in the exception trackers, we also need to set
the fSkippingFunclet.
Commit migrated from https://github.com/dotnet/coreclr/commit/
76c2dfc6321bff28c90ac48b0f2ca5abb02abe72
Andy Ayers [Tue, 8 Mar 2016 21:00:23 +0000 (13:00 -0800)]
Merge pull request dotnet/coreclr#3592 from AndyAyersMS/FixAssert
Inliner: fix assert about repeated failing observations
Commit migrated from https://github.com/dotnet/coreclr/commit/
73a9a7b2463baaaa8876fd5688823b713813d7fc
tijoytom [Tue, 8 Mar 2016 20:38:42 +0000 (12:38 -0800)]
Disable tests failing on Linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
1427938c5d3ba1ce1698e91dfe1fd8e7d88c2318
Pat Gavlin [Tue, 8 Mar 2016 16:48:42 +0000 (08:48 -0800)]
Use jitstd::list in the LSRA.
This removes the only usage of ArrayList in the JIT.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8d8bbf3029486b21f04c155561b816d25cd596d
William Godbe [Tue, 8 Mar 2016 19:46:36 +0000 (11:46 -0800)]
Merge pull request dotnet/coreclr#3469 from wtgodbe/raceCond
Fix race condition in Pri 2 tests, and revert those tests to Pri 1
Commit migrated from https://github.com/dotnet/coreclr/commit/
262ba0e41252da354e0d1b60e707656615ccb622
Andy Ayers [Tue, 8 Mar 2016 18:35:30 +0000 (10:35 -0800)]
Inliner: fix assert about repeated failing observations
When an inlining attempt is going to fail, the jit aims to bail out of
the attempt as quickly as possible, since any further work on this
inline will just waste time and memory. The jit monitors this in part
by asserting that it only makes one failing observation.
However, there are as few places where failing fast during inlining is
not currently possible, and repeated failing observations may occur.
This change loosens the assertion check to allow repeated
`CALLSITE_TOO_MANY_LOCALS` observations. This observation is made
at a fairly deep stack in `lvaGrabTemp` with no easy route to bail
out in case of imminent failure.
Closes dotnet/coreclr#3586.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bf443617c47fc03aad093d696b221da806239fe5
Lubomir Litchev [Tue, 8 Mar 2016 18:47:52 +0000 (10:47 -0800)]
Merge pull request dotnet/coreclr#3555 from LLITCHEV/Issue3540
Remove the the RBM_LOWINT define. Change the LsraLimitSmallIntSet to have a better representation of callee saved
Unrelated failure in Ubuntu x64 Checked Build and Test.
Commit migrated from https://github.com/dotnet/coreclr/commit/
59b18caa782caf1f8ff6b07f653051ff917a24b2
Sejong Oh [Mon, 7 Mar 2016 22:28:07 +0000 (14:28 -0800)]
Fix GC stress setup failure on Unix-like OSes
Commit migrated from https://github.com/dotnet/coreclr/commit/
50242dc9cf55f710ae347cda448aa7f0362a9449
Jan Kotas [Tue, 8 Mar 2016 18:13:11 +0000 (10:13 -0800)]
Merge pull request dotnet/coreclr#3573 from vcsjones/fix-3566
Fix failing test in IntPtrGetHashCode.
Commit migrated from https://github.com/dotnet/coreclr/commit/
326dee799c2a63cbe841054dc1eaaec483d85250
Gaurav Khanna [Tue, 8 Mar 2016 17:19:49 +0000 (09:19 -0800)]
Merge pull request dotnet/coreclr#3577 from gkhanna79/FixUbuntu15
Fix Ubuntu 15.10 Build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
56c43a5b229c375b5e11eba25dc0ab5997f23256
Jan Vorlicek [Mon, 7 Mar 2016 22:09:45 +0000 (23:09 +0100)]
Fix Unix exception handling in finalizers
When unhandled exception happens in a finalizer thread and there are
no managed frames till the bottom of the stack,
the Thread::VirtualUnwindToFirstManagedCallFrame then fails fast.
The fix is to make the Thread::VirtualUnwindToFirstManagedCallFrame to
return even in case no managed frame is called, which is indicated by
its returning 0 as the resulting IP address. The DispatchManagedException
then checks that and rethrows the exception instead of trying to call
UnwindManagedExceptionPass1.
I have also added INSTALL_UNHANDLED_MANAGED_EXCEPTION_TRAP to the
FinalizerThread::FinalizerThreadStart so that the unhandled exception
doesn't escape the stack.
And I also needed to modify the UNINSTALL_UNHANDLED_MANAGED_EXCEPTION_TRAP
to detect case when the unhandled exception filter was already executed so
that it doesn't double-report the unhandled exception.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f5d0a5b0546edf283e855d3ae95283485d180ea
Kyungwoo Lee [Fri, 4 Mar 2016 21:18:08 +0000 (13:18 -0800)]
Fix for casting byref to double in morph
This fixes https://github.com/dotnet/coreclr/issues/3517.
JIT didn't cast byref to double in morph, which caused
this assertion later.
The fix is to handle such case as well.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c7b3805184af2a9e6e59baec4a5a8d238af1c4e4
Kyungwoo Lee [Tue, 8 Mar 2016 14:14:53 +0000 (06:14 -0800)]
Merge pull request dotnet/coreclr#3548 from kyulee1/fixgc
ARM64: Fix for handling GC register for call site
Commit migrated from https://github.com/dotnet/coreclr/commit/
e22d5d34d1b32b32443880338e7e9a2a92a16487
Matthew Parkinson [Tue, 8 Mar 2016 11:09:44 +0000 (11:09 +0000)]
Changed to a left leaning red black tree implementation
This change takes the algorithm as presented in Robert
Sedgewick's paper
[Left-leaning Red-Black Trees](http://www.cs.princeton.edu/~rs/talks/LLRB/LLRB.pdf)
and implements it in C#. The implementation is a fairly
direct transliteration of the paper.
The code is integrated with the previous code's harness, but
little else remains.
If the DEBUG property is set, then it checks the invariants
of the tree are re-established after each insert and delete.
Commit migrated from https://github.com/dotnet/coreclr/commit/
705b02f49968690b97558f34ad7bdb40b84ed36c
Jan Kotas [Tue, 8 Mar 2016 09:59:40 +0000 (01:59 -0800)]
Merge pull request dotnet/coreclr#3568 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
85b6c1f77a0cbc660f5c1158ddf0f93c9c61ce3a
Jan Kotas [Tue, 8 Mar 2016 09:58:05 +0000 (01:58 -0800)]
Merge pull request dotnet/coreclr#3576 from leemgs/upstream-crossbuild
ARM: skip generating native image for mscorlib in case of cross build
Commit migrated from https://github.com/dotnet/coreclr/commit/
6bf36e723bf09c0af5f42ca3ddbe7f1098a4ae1c
Gaurav Khanna [Tue, 8 Mar 2016 05:22:03 +0000 (21:22 -0800)]
Fix Ubuntu 15.10 Build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
8807598af6bd36cb7ea09ac5cff6f1e0f42a0a42
Geunsik Lim [Tue, 8 Mar 2016 04:30:21 +0000 (13:30 +0900)]
ARM: skip generating native image for mscorlib in case of cross build
We need to skip generating native image for mscorlib in build_mscorlib()
of ./coreclr/build.sh when we do cross build for Linux/ARM on Ubuntu
14.04 x86 64bit PC.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb3448819c2905605c223a6edbd57990f4eb248c
stephentoub [Tue, 8 Mar 2016 04:03:54 +0000 (23:03 -0500)]
Add missing parameter name to GetEra ArgumentOutOFRangeException
The exception's parameter name is incorrectly getting set to the intended message ("Time value was out of era range.").
Commit migrated from https://github.com/dotnet/coreclr/commit/
424b82d61a54460e76c296f55dc4e73b2b2f069c
Andy Ayers [Fri, 4 Mar 2016 22:16:58 +0000 (14:16 -0800)]
Inline refactoring: move state machine into LegacyPolicy
The state machine used to estimate callee native code size is now an
internal part of the LegacyPolicy.
During `fgFindJumpTargets` the policy determines if the state machine
is need, and if so, sets one up. `fgFindJumpTargets` then notifies the
policy of the various opcodes in the method, and the policy uses this
to drive the state machine forward.
When the IL scan is completed, the `fgFindJumpTargets` notifies the
policy, then, for the discretionary inline case, grabs the native size
estimate, and uses that to evaluate inlinability.
The knowledge of when inlines are "always", "forced", or
"discretionary" is now encapsulated by the policy instead of being
distributed in various places in the code.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1876230e5098541c150f2893644fda413484426c
Lubomir Litchev [Mon, 7 Mar 2016 21:13:38 +0000 (13:13 -0800)]
Remove the RBM_LOWINT define. Change LsraLimitSmallIntSet to have a better representation of callee saved
register for stress mode testing on System V OSs.
Remove the RBM_LOWINT define and change the LsraLimitSmallIntSet register
mask for System V OSs to provide a good
ratio between caller and calles saved register for the purposes of stress
testing.
Fixes issue dotnet/coreclr#3540.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d28c6d7af50d024473948dc6d3ae3d89b3a6379
Jarret Shook [Tue, 8 Mar 2016 02:14:00 +0000 (18:14 -0800)]
Merge pull request dotnet/coreclr#3564 from jashook/x86_lb_excludes
x86 lb excludes
Commit migrated from https://github.com/dotnet/coreclr/commit/
6ae94191aeb19ce330b8c66305866bdc65b492fd