Michal Strehovský [Wed, 22 Feb 2017 20:04:37 +0000 (12:04 -0800)]
Add test coverage for ldtoken with members (#9713)
The test coverage for `ldtoken field X` and `ldtoken method X` in the
repo is very small - this test tries to improve things a little.
In particular, it tests that we get the right reflection objects, and
that we can do this from shared and unshared code.
Bruce Forstall [Wed, 22 Feb 2017 19:29:58 +0000 (11:29 -0800)]
Merge pull request #9714 from BruceForstall/FixRegMasks
Fix non-Windows amd64 register mask initialization
Michelle McDaniel [Wed, 22 Feb 2017 19:00:39 +0000 (11:00 -0800)]
Merge pull request #9702 from adiaaida/fixX86PerfTesting
Fix x86 perf testing
James Ko [Wed, 22 Feb 2017 18:01:40 +0000 (13:01 -0500)]
Separate Comparer and EqualityComparer creation logic into a non-generic class (#9640)
Pat Gavlin [Wed, 22 Feb 2017 17:29:58 +0000 (09:29 -0800)]
Merge pull request #9704 from pgavlin/corefx15913
Correctly pass 12-byte GT_SIMD nodes on x86.
Gaurav Khanna [Wed, 22 Feb 2017 16:58:43 +0000 (08:58 -0800)]
Merge pull request #9660 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25021-03, beta-25022-02, respectively (master)
dotnet-bot [Wed, 22 Feb 2017 15:16:14 +0000 (15:16 +0000)]
Update CoreClr, CoreFx to beta-25021-03, beta-25022-02, respectively
Jonghyun Park [Wed, 22 Feb 2017 14:43:30 +0000 (23:43 +0900)]
Clean up ClrUnwindEx (#9482)
* Clean up ClrUnwindEx
Bruce Forstall [Wed, 22 Feb 2017 01:06:46 +0000 (17:06 -0800)]
Fix non-Windows amd64 register mask initialization
The arrays were being initialized with register numbers, not
register masks. The arrays are only used on non-Windows amd64
for homing circular incoming argument conflicts. Perhaps we
never saw this happen?
Michelle McDaniel [Tue, 21 Feb 2017 19:35:04 +0000 (11:35 -0800)]
Fix x86 perf testing
We did not use a different architecture in run-xunit-perf.cmd, so all the
x86 runs were uploading to the same architecture. This change fixes it so
x86jit32 runs upload to their own architecture. Also fixes the delayed
expansion issue for testenv.
Michal Strehovský [Wed, 22 Feb 2017 00:37:04 +0000 (16:37 -0800)]
Use CORINFO_CALLCONV to check for unmanaged calls (#9697)
`GTF_CALL_UNMANAGED` is a member of the wrong enum and it's something
that would be set on `call->gtFlags` except that at this point it isn't.
Check against the actual unmanaged calling conventions.
SaeHie Park [Wed, 22 Feb 2017 00:26:21 +0000 (09:26 +0900)]
[x86/Linux] Fix framepointer while unwinding (#9678)
Use pCallerContext when getting frame pointer
Pat Gavlin [Tue, 21 Feb 2017 23:15:22 +0000 (15:15 -0800)]
Add a regression test.
Gaurav Khanna [Tue, 21 Feb 2017 22:07:58 +0000 (14:07 -0800)]
Merge pull request #9703 from wtgodbe/CrossgenCode
Have Crossgen Failures exit in a dedicated exit routine
Pat Gavlin [Tue, 21 Feb 2017 21:29:34 +0000 (13:29 -0800)]
Correctly pass 12-byte GT_SIMD nodes on x86.
During lowering, all TYP_SIMD12 GT_SIMD nodes are retyped to TYP_SIMD16.
This is correct except in the case that the GT_SIMD node is going to be
passed by-value on x86, in which case this retyping causes us to push 16
bytes rather than 12. This change recognizes a GT_SIMD node that has
been retyped by checking the value of gtSIMDSize during LowerArg and
uses TYP_SIMD12 for the putarg instead of TYP_SIMD16 (aside from
differences in detecting retyped nodes, this is the same transformation
we already do when passing TYP_SIMD12 lclVars that are being used as
TYP_SIMD16 on x86).
Fixes https://github.com/dotnet/corefx/issues/15913.
wtgodbe [Tue, 21 Feb 2017 20:38:46 +0000 (12:38 -0800)]
Have Crossgen Failures exit in a dedicated exit routine
Jarret Shook [Tue, 21 Feb 2017 19:23:09 +0000 (11:23 -0800)]
Merge pull request #9695 from jashook/up_timeout_for_arm64_gcstress
Up the timeout for gcstress arm64 jobs.
jashook [Tue, 21 Feb 2017 18:05:10 +0000 (10:05 -0800)]
Up the timeout for gcstress arm64 jobs.
Mikhail Filippov [Tue, 21 Feb 2017 17:26:58 +0000 (20:26 +0300)]
Fix compilation on macOS with case sensitive FS (#9693)
Bruce Bowyer-Smyth [Tue, 21 Feb 2017 17:25:18 +0000 (03:25 +1000)]
Improve string.Equals OrdinalIgnoreCase performance for matching chars (#9213)
* Improve string.Equals OrdinalIgnoreCase performance for matching chars
* Added code comment
Jonghyun Park [Tue, 21 Feb 2017 14:33:55 +0000 (23:33 +0900)]
Add --xunitOutputPath option to runtest.sh (#9646)
Jonghyun Park [Tue, 21 Feb 2017 14:01:29 +0000 (23:01 +0900)]
Clean up FixupDispatcherContext (#9685)
Jonghyun Park [Tue, 21 Feb 2017 13:47:11 +0000 (22:47 +0900)]
Use ADJUST_PC_UNWOUND_TO_CALL instead of _TARGET_XXX_ (#9686)
Andy Ayers [Mon, 20 Feb 2017 15:53:14 +0000 (07:53 -0800)]
Merge pull request #9676 from parjong/fix/issue_9576
Fix bogus assert in flowgraph and update related ilproj
Jonghyun Park [Mon, 20 Feb 2017 05:38:40 +0000 (14:38 +0900)]
Rewrite assert using bbInTryRegions
Jonghyun Park [Mon, 20 Feb 2017 01:40:26 +0000 (10:40 +0900)]
Update related .ilproj
Jonghyun Park [Mon, 20 Feb 2017 01:31:43 +0000 (10:31 +0900)]
Fix formatting error
Jonghyun Park [Mon, 20 Feb 2017 01:13:33 +0000 (10:13 +0900)]
Comment out bogus assert in flowgraph
Jarret Shook [Sun, 19 Feb 2017 19:03:31 +0000 (11:03 -0800)]
Merge pull request #9672 from jashook/arm64_regression
Add new regression.
Andy Ayers [Sun, 19 Feb 2017 06:39:31 +0000 (22:39 -0800)]
Merge pull request #9671 from benaadams/revert-encoding
Revert "Fast-path for ASCII & UTF8 Encoding ASCII data (#9187)"
Dan Moseley [Sun, 19 Feb 2017 05:47:48 +0000 (21:47 -0800)]
Merge pull request #9670 from stephentoub/cs_random
Delay Random allocation in ConcurrentStack
jashook [Sun, 19 Feb 2017 05:28:45 +0000 (21:28 -0800)]
Add new regression.
Ben Adams [Sun, 19 Feb 2017 05:03:51 +0000 (05:03 +0000)]
Revert "Fast-path for ASCII & UTF8 Encoding ASCII data (#9187)"
This reverts commit
77e676be9fab34471c4ae9f16a7a51a06bd470ee.
Andy Ayers [Sun, 19 Feb 2017 01:42:43 +0000 (17:42 -0800)]
Merge pull request #9661 from AndyAyersMS/FixTailCallStress1
JIT: tolerate GT_COMMA in tail call position
Stephen Toub [Sun, 19 Feb 2017 01:17:34 +0000 (20:17 -0500)]
Remove a few explicit static cctors (#9669)
Gaurav Khanna [Sun, 19 Feb 2017 00:09:12 +0000 (16:09 -0800)]
Merge pull request #9665 from sdmaclea/PR-ARM64-PT_KNONVOLATILE
[ARM64] Use PT_KNONVOLATILE... for cross
Stephen Toub [Sat, 18 Feb 2017 23:32:20 +0000 (15:32 -0800)]
Delay Random allocation in ConcurrentStack
Ben Adams [Sat, 18 Feb 2017 18:47:36 +0000 (18:47 +0000)]
Fast-path for ASCII & UTF8 Encoding ASCII data (#9187)
Steve MacLean [Sat, 18 Feb 2017 09:15:26 +0000 (04:15 -0500)]
[Arm64/Unix] Fix cmake race condition (#9666)
On a clean build SET(REQUIRE_LLDBPLUGIN false) was being ignored because the cmake
cache variable had not been created
Change order of cmake file to be more natural and to resolve
Sivarv [Sat, 18 Feb 2017 06:29:47 +0000 (22:29 -0800)]
Merge pull request #9667 from sivarv/backout
Back-out promotion of structs containing fields of struct of single field
sivarv [Sat, 18 Feb 2017 04:17:13 +0000 (20:17 -0800)]
Backout promotion of structs containing fields of struct of single field.
[ARM64] Use PT_KNONVOLATILE... for cross
In order to enable cross compilation support, ARM64
needs to use PT_KNONVOLATILE_CONTEXT_POINTERS
Andy Ayers [Sat, 18 Feb 2017 01:17:34 +0000 (17:17 -0800)]
Merge pull request #9657 from AndyAyersMS/FixFinallyChainMergeAssert
JIT: relax assert in fgMergeFinallyChains
Sivarv [Fri, 17 Feb 2017 22:21:33 +0000 (14:21 -0800)]
Merge pull request #9636 from sivarv/shouldPromote
Refactor some of fgPromoteStruct() checks into lvaCanPromoteStructVar() and lvaShouldPromoteStructVar()
Andy Ayers [Fri, 17 Feb 2017 22:02:12 +0000 (14:02 -0800)]
JIT: tolerate GT_COMMA in tail call position
Now that we can tail call from inlined call sites, we may see the call
embedded in a GT_COMMA, if the call's return value is ignored. This triggered
an assert the tail call transformation.
Closes #9641.
chcosta [Fri, 17 Feb 2017 20:47:10 +0000 (12:47 -0800)]
Merge pull request #9658 from chcosta/fix_coreclr_packaging
Exclude ni files from linux arm32 builds
Jiyoung Giuliana Yun [Fri, 17 Feb 2017 20:43:52 +0000 (05:43 +0900)]
Synchronous toolchain.cmake files with CoreFX (#9409)
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
Pat Gavlin [Fri, 17 Feb 2017 20:13:25 +0000 (12:13 -0800)]
Merge pull request #8843 from mikedn/decompose-cast-mul
Improve int->long cast decomposition
Joseph Tremoulet [Fri, 17 Feb 2017 19:40:17 +0000 (14:40 -0500)]
Merge pull request #9615 from JosephTremoulet/UpdateCompareVN
Update array length compare value numbers on CSE
Dan Moseley [Fri, 17 Feb 2017 19:18:50 +0000 (11:18 -0800)]
Merge pull request #9649 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25017-02 (master)
Dan Moseley [Fri, 17 Feb 2017 19:13:59 +0000 (11:13 -0800)]
Merge pull request #9228 from fujiy/fixcorefx4805
Add/Expose String.EndsWith(char) and String.StartsWith(char)
Russ Keldorph [Fri, 17 Feb 2017 19:03:05 +0000 (11:03 -0800)]
Merge pull request #9656 from RussKeldorph/corefx_x86
Fix corefx x86 testing and small netci.groovy fixes
Christopher Costa [Fri, 17 Feb 2017 18:46:41 +0000 (10:46 -0800)]
Remove ubuntu 16.10 arm build from packaging
Steve MacLean [Fri, 17 Feb 2017 18:25:37 +0000 (13:25 -0500)]
[ARM64/Unix] (#9500)
* [Arm64/Unix] Update arm64 *.S files to match *.asm
* [Arm64/Unix] Fix CONTEXTToNativeContext()
* [Arm64/Unix] ThrowExceptionFromContextInternal
* [Arm64/Unix] Preserve x8 argument register
* [ARM64/Unix] Add CFI directives
Add native unwind info
* [Arm64/Unix] Fix RtlRestoreContext
* [Arm64/Unix] Restore FP from CurrentContextPointers
* [Arm64/Unix] fix pointer math
* [Arm64/Unix] Fix CallDescrWorkerInternal personality
* [Arm64/Unix] More Fp fixups
* [Arm64/Unix] CallEHFunclet machine state
Restore non-volatile machine state in CallEHFunclet
* [Arm64/Unix] CallDescrWorkerInternal
Use empty stack slot to save argument
* [Arm64/Unix] RtlVirtualUnwind update pointers
* [Arm64] LazyMachState fixes
* [Arm64/Unix] disable USE_REDIRECT_FOR_GCSTRESS
When FEATURE_PAL is enableds USE_REDIRECT_FOR_GCSTRESS
is not supported
* [Arm64] ClearRegDisplayArgumentAndScratchRegisters()
* [Arm64] Remove unnecesary copy in TransitionFrame
* [Arm64/Unix] Fix comment per review
* [Arm64/Unix] move constants per review
* [Arm64/Unix] Use ldp per review
Also fix indentation
* [Arm64/Unix] Fix indentation per review
* [Arm64/Unix] Remove m_Unwound per review comments
* [Arm64/Unix] Use PREPARE_EXTERNAL_VAR to access globals
* [Arm64/Unix] Fix more whitespace per earlier review comments
Christopher Costa [Fri, 17 Feb 2017 18:23:20 +0000 (10:23 -0800)]
Remove contraction from property name
Christopher Costa [Fri, 17 Feb 2017 18:20:58 +0000 (10:20 -0800)]
Exclude ni files from linux arm32 builds
Russ Keldorph [Fri, 17 Feb 2017 17:12:04 +0000 (09:12 -0800)]
Fix corefx x86 testing and small netci.groovy fixes
run-corefx-tests.py fixes
- Switch to using the same corefx build switches as the corefx CI.
netci.groovy fixes
- Add COMPlus_Ready2Run=0 to existing ZapDisable jobs to get the coverage
we intended to have in these jobs. Previously, R2R images were slipping
through.
- Add architecture to the trigger strings fore corefx jobs so it's
possible to request x86 corefx runs.
- Add the -u option to python command line in netci.groovy so Python
output is synchronized with subcommand output in the CI logs.
- Fix whitespace in name formatting of corefx_baseline jobs
- Remove trailing (sorry, my editor did this and now it is too hard to
undo. Add ?w=1 to Github diff URL to filter out ws diffs.)
Jarret Shook [Fri, 17 Feb 2017 16:27:18 +0000 (08:27 -0800)]
Merge pull request #9580 from sdmaclea/PR-ARM64-CROSSGENFAILS
[Arm64/Unix] Add crossgen fails
Andy Ayers [Fri, 17 Feb 2017 16:04:55 +0000 (08:04 -0800)]
JIT: relax assert in fgMergeFinallyChains
In some rare and likely IL-only cases the jit may create unreachable
callfinallys. This trips up finally chain merging since it spots a
merge opportunity but no merge actually happens.
Relax the assertion checks so that `canMerge && !didMerge` is now ok.
Closes #9651.
dotnet-bot [Fri, 17 Feb 2017 15:07:22 +0000 (15:07 +0000)]
Update CoreFx to beta-25017-02
Hanjoung Lee [Fri, 17 Feb 2017 11:39:26 +0000 (20:39 +0900)]
[x86/Linux] Remove unnecessary x86-specific part (#9627)
This inlined assembly is no longer necessary for x86.
Jonghyun Park [Fri, 17 Feb 2017 11:11:46 +0000 (20:11 +0900)]
Clean up nested WIN64EXCEPTIONS (#9644)
Jonghyun Park [Fri, 17 Feb 2017 09:27:17 +0000 (18:27 +0900)]
Clean up dummy implementation in regdisp.h (#9643)
Jonghyun Park [Fri, 17 Feb 2017 09:19:16 +0000 (18:19 +0900)]
[x86/Linux] Fix GetCallerSp (#9384)
* [x86/Linux] Fix GetCallerSp
* Do NOT pop stack argument for TransitionFrame
* Add ResumeEsp to CONTEXT
Drew Scoggins [Fri, 17 Feb 2017 08:45:22 +0000 (00:45 -0800)]
Merge pull request #9645 from DrewScoggins/EmptyVariableFix
Fix x64 perf run break
Drew Scoggins [Fri, 17 Feb 2017 07:39:53 +0000 (23:39 -0800)]
Fix x64 perf run break
After the checkin to add legacy JIT testing support for x86 we broke x64
runs. THe issue is that we do not pass anything in to the TEST_ENV
variable on x64 and when a variable is empty and you attempt to use the
if exists syntax you fail. I have added a nonsense file name that we
set this to before we go through the args loop. I was not able to find a
better solution and want to get the lab unblocked, but any batch masters
feel free to solve this the right way.
Dan Moseley [Fri, 17 Feb 2017 05:45:12 +0000 (21:45 -0800)]
Merge pull request #9642 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25017-01 (master)
Dan Moseley [Fri, 17 Feb 2017 05:44:36 +0000 (21:44 -0800)]
Merge pull request #9639 from parjong/fix/wrong_comment
Fix wrong comment
dotnet-bot [Fri, 17 Feb 2017 03:03:57 +0000 (03:03 +0000)]
Update CoreFx to beta-25017-01
Dan Moseley [Fri, 17 Feb 2017 02:47:45 +0000 (18:47 -0800)]
Merge pull request #8778 from dnickless/master
Performance improvement: Make ConcurrentDictionary with Enum values also profit from atomic writes.
William Godbe [Fri, 17 Feb 2017 01:58:46 +0000 (17:58 -0800)]
Merge pull request #9637 from wtgodbe/noMoreSuse
Remove all references to OpenSuse13.2
Gaurav Khanna [Fri, 17 Feb 2017 01:31:17 +0000 (17:31 -0800)]
Merge pull request #9628 from dotnet-bot/master-UpdateDependencies
Update CoreFx to beta-25016-03 (master)
Jonghyun Park [Fri, 17 Feb 2017 01:10:09 +0000 (10:10 +0900)]
Fix wrong comment
Bruce Forstall [Thu, 16 Feb 2017 23:42:34 +0000 (15:42 -0800)]
Merge pull request #9610 from sdmaclea/PR-ARM64-CALLSITE
[Arm64/Unix] Correct ControlPC when unwinding
wtgodbe [Thu, 16 Feb 2017 22:40:39 +0000 (14:40 -0800)]
Remove all references to OpenSuse13.2
sivarv [Thu, 16 Feb 2017 22:01:24 +0000 (14:01 -0800)]
Refactor fgPromoteStrut into lvaShouldPromoteStructVar
Joseph Tremoulet [Thu, 16 Feb 2017 21:53:47 +0000 (13:53 -0800)]
Rename cseArrLenMap to optCseArrLenMap
This lines up better with other names in code that optimizes common sub-
expressions.
Joseph Tremoulet [Thu, 16 Feb 2017 19:45:52 +0000 (11:45 -0800)]
Factor signedness test into helper
Gaurav Khanna [Thu, 16 Feb 2017 18:03:03 +0000 (10:03 -0800)]
Merge pull request #9629 from sdmaclea/PR-FIX-LLDB-REGRESSION
Pr fix lldb regression typo
Michelle McDaniel [Thu, 16 Feb 2017 17:14:35 +0000 (09:14 -0800)]
Merge pull request #9588 from adiaaida/perfLegacyJit
Add perf job for legacy jit
Jonghyun Park [Thu, 16 Feb 2017 16:40:03 +0000 (01:40 +0900)]
[x86/Linux] Emit proper frame for FastGetSharedStaticBase (#9618)
* [x86/Linux] Emit proper frame for FastGetSharedStaticBase
* Adjust Stack-align Padding
* Remove FEATURE_PAL ifdef
Steve MacLean [Thu, 16 Feb 2017 13:16:20 +0000 (08:16 -0500)]
Merge branch 'master' into PR-FIX-LLDB-REGRESSION
[Unix] Fix arm/lldb rootfs breakage (typo)
dotnet-bot [Thu, 16 Feb 2017 09:09:29 +0000 (09:09 +0000)]
Update CoreFx to beta-25016-03
Steve MacLean [Thu, 16 Feb 2017 08:55:20 +0000 (03:55 -0500)]
[Unix] Fix arm/lldb rootfs breakage (#9625)
SaeHie Park [Thu, 16 Feb 2017 08:50:08 +0000 (17:50 +0900)]
[x86/Linux] Fix IsIPInMarkedJitHelper to handle sigsegv (#9605)
Include JIT_WriteBarrier and JIT_CheckedWriteBarrier functions
so that we can handle NullReferenceException for sigsegv from WriteBarriers.
Dan Moseley [Thu, 16 Feb 2017 05:50:01 +0000 (21:50 -0800)]
Merge pull request #9603 from danmosemsft/defines4
Remove more dead native defines
[Unix] Fix arm/lldb rootfs breakage
Dan Moseley [Thu, 16 Feb 2017 02:09:34 +0000 (18:09 -0800)]
Update testing-with-corefx.md
Felipe Fujiy Pessoto [Thu, 16 Feb 2017 02:08:58 +0000 (00:08 -0200)]
Remove unnecessary "this"
Andy Ayers [Thu, 16 Feb 2017 01:48:59 +0000 (17:48 -0800)]
Merge pull request #9622 from AndyAyersMS/FixRetDesktopBreak
JIT: fix desktop build break
Dan Moseley [Wed, 15 Feb 2017 23:55:09 +0000 (15:55 -0800)]
Merge pull request #9599 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25015-04, beta-25015-02, respectively (master)
danmosemsft [Wed, 15 Feb 2017 23:52:17 +0000 (15:52 -0800)]
Other props stragglers for never defined symbols
danmosemsft [Wed, 15 Feb 2017 23:44:09 +0000 (15:44 -0800)]
More FEATURE_WIN_DB_APPCOMPAT
danmosemsft [Wed, 15 Feb 2017 23:41:02 +0000 (15:41 -0800)]
More FEATURE_ISOSTORE
danmosemsft [Wed, 15 Feb 2017 23:38:26 +0000 (15:38 -0800)]
Remove never defined FEATURE_X509
danmosemsft [Wed, 15 Feb 2017 22:58:27 +0000 (14:58 -0800)]
Remove never defined FEATURE_WIN_DB_APPCOMPAT
danmosemsft [Wed, 15 Feb 2017 22:55:46 +0000 (14:55 -0800)]
Remove never defined FEATURE_UEF_CHAINMANAGER
danmosemsft [Wed, 15 Feb 2017 22:20:38 +0000 (14:20 -0800)]
Remove never defined FEATURE_TRACELOGGING except in jit/**
danmosemsft [Wed, 15 Feb 2017 21:49:49 +0000 (13:49 -0800)]
Remove never defined FEATURE_SERIALIZATION