platform/upstream/gstreamer.git
3 years agova: Delay decoders downstream negotiation.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 14:05:24 +0000 (16:05 +0200)]
va: Delay decoders downstream negotiation.

Delay decoders downstream negotiation just before an output frame
needs to be allocated.

This is required, are least for H.264 and H.265 decoders, since
codec_data might trigger a new sequence before finishing upstream
negotiation, and sink pad caps need to set before setting source pad
caps, particularly to forward HDR fields. The other decoders are
changed too in order to keep the same structure among them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

3 years agovabasedec: Move warning message to decoder's category.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:41:53 +0000 (09:41 +0200)]
vabasedec: Move warning message to decoder's category.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

3 years agova: Move common variable need_negotiation to GstBaseDec.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:28:10 +0000 (09:28 +0200)]
va: Move common variable need_negotiation to GstBaseDec.

This is a common variable to all decoders, so it's sound to move it to
the base helper.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

3 years agova: Move back parent_object to each element.
Víctor Manuel Jáquez Leal [Tue, 26 Oct 2021 07:23:42 +0000 (09:23 +0200)]
va: Move back parent_object to each element.

Using GstBaseDec hack to access the parent_object of each element in
the element itself is a bit fragile. It would be better to keep its
own parent object as the usual global variable. It would make it
resistant to code changes.

The GstBaseDec macro to access the parent object now it's internal to
base decoder.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257>

3 years agovideo-format: Add support for ARGB64 LE/BE and similar variants
Piotrek Brzeziński [Fri, 22 Oct 2021 22:44:57 +0000 (00:44 +0200)]
video-format: Add support for ARGB64 LE/BE and similar variants

Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247>

3 years agoidentity: Fix crash when receiving a gap event outside the current segment
Vivia Nikolaidou [Fri, 29 Oct 2021 10:27:37 +0000 (13:27 +0300)]
identity: Fix crash when receiving a gap event outside the current segment

We were checking if the start time of the gap event was
GST_CLOCK_TIME_NONE, which is superfluous because that cannot happen,
and then not checking if it was NONE after gst_segment_to_running_time,
which caused a crash if an identity received a gap event fully or
partially outside the current segment.

This patch was done in cooperation with:
Jan Alexander Steffens (heftig) <jan.steffens@ltnglobal.com>

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1269>

3 years agortptwcc: don't assume all PacketInfo->data are buffers
Mathieu Duponchelle [Fri, 29 Oct 2021 01:46:25 +0000 (03:46 +0200)]
rtptwcc: don't assume all PacketInfo->data are buffers

They can also be buffer lists

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1268>

3 years agoneon: Allow building against neon 0.32.x
Heiko Becker [Sun, 26 Sep 2021 19:34:30 +0000 (21:34 +0200)]
neon: Allow building against neon 0.32.x

No API/ABI changes: https://github.com/notroj/neon/blob/0.32.0/NEWS#L3

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1267>

3 years agomeson: require matching GStreamer dep versions for unstable development releases
Tim-Philipp Müller [Mon, 25 Oct 2021 10:37:45 +0000 (11:37 +0100)]
meson: require matching GStreamer dep versions for unstable development releases

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/929

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>

3 years agosubprojects: fdk-aac: add fallback_url
Tim-Philipp Müller [Mon, 25 Oct 2021 14:57:36 +0000 (15:57 +0100)]
subprojects: fdk-aac: add fallback_url

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244>

3 years agowebrtcbin: fix check_negotiation computing on caps event
Mathieu Duponchelle [Tue, 26 Oct 2021 22:20:57 +0000 (00:20 +0200)]
webrtcbin: fix check_negotiation computing on caps event

It seems logical that check_negotiation be true if received_caps
is *not* equal to the new caps.

Also clean up handling of transceivers' ssrc events, as this
patch triggered a leaky code path.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

3 years agowebrtcbin: connect input stream when receiving caps
Mathieu Duponchelle [Fri, 22 Oct 2021 23:54:05 +0000 (01:54 +0200)]
webrtcbin: connect input stream when receiving caps

.. if a current direction has already been set

When `webrtcbin` has created an offer based on codec_preferences,
it might not have received caps on its sinkpads by the time a
remote description is set, in which case we want to connect the
input stream upon actual reception of the caps instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

3 years agowebrtcbin: consider pads with trans->codec_preferences ready
Mathieu Duponchelle [Mon, 18 Oct 2021 13:23:48 +0000 (15:23 +0200)]
webrtcbin: consider pads with trans->codec_preferences ready

.. when determining whether we can emit on-negotiation-needed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233>

3 years agompeg4videoparse: fix criticals trying to insert configs that don't exist yet
Tim-Philipp Müller [Thu, 28 Oct 2021 16:41:54 +0000 (17:41 +0100)]
mpeg4videoparse: fix criticals trying to insert configs that don't exist yet

With mpeg4videoparse drop=false config-interval=N|-1 we might be
trying to insert a config before we have actually received one,
in which case we'll try to map a NULL buffer which will generate
lots of criticals.

Fixes #855

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1265>

3 years agoqtdemux: Fix text and closed-caption handling.
Jan Schmidt [Thu, 28 Oct 2021 10:37:47 +0000 (21:37 +1100)]
qtdemux: Fix text and closed-caption handling.

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182
broke text and and closed caption extraction when introducing WebVTT
support, by making the output buffers not have timestamps any more.

Fix that by making the process functions copy buffer metadata
when generating new output buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1262>

3 years agomsdk: Insert hdr sei at hevc encoder
Mengkejiergeli Ba [Wed, 20 Oct 2021 09:46:10 +0000 (17:46 +0800)]
msdk: Insert hdr sei at hevc encoder

There are two HDR SEIs defined in spec: mastering display colour volume and
content light level. Add insertion of HDR SEIs when they are available
during encoding.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1242>

3 years agowebrtcbin: Also check data channel transport when collating connection state
Rob Agar [Thu, 21 Oct 2021 15:12:06 +0000 (16:12 +0100)]
webrtcbin: Also check data channel transport when collating connection state

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/838

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1224>

3 years agovapostproc: Color fixation will choose othercaps' structure.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:54:09 +0000 (11:54 +0200)]
vapostproc: Color fixation will choose othercaps' structure.

gst_va_fixate_format() will iterate all othercaps' structures to find
the one with less information lost at color conversion. If a structure
with same color format is found, the iteration stops. It's like a
smart truncation. Then, this function also will choose the caps
feature.

Later this structure is used fixate its size and no further truncation
is needed.

Don't intersect at fixate, since it kills possible resizing.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

3 years agovapostproc: Ignore direction at orientation swapping.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 09:53:28 +0000 (11:53 +0200)]
vapostproc: Ignore direction at orientation swapping.

It doesn't matter the direction of the negotiation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

3 years agovapostproc: Consider video orientation for border calculation.
Víctor Manuel Jáquez Leal [Wed, 27 Oct 2021 08:31:04 +0000 (10:31 +0200)]
vapostproc: Consider video orientation for border calculation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1261>

3 years agodecodebin3: Only unblock for GAP events and buffers.
Jan Schmidt [Wed, 27 Oct 2021 11:49:44 +0000 (22:49 +1100)]
decodebin3: Only unblock for GAP events and buffers.

An alternate fix for
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1239
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1236
that makes it clear the intent is to only unblock on a GAP event, and
not any others.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1260>

3 years agopython: Update audiotestsrc to return correct tuple on FlowReturn Errors
Chris Wiggins [Wed, 27 Oct 2021 04:20:39 +0000 (17:20 +1300)]
python: Update audiotestsrc to return correct tuple on FlowReturn Errors

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1259>

3 years agoavtpsrc: Retry receive with same buffer size
Timo Wischer [Wed, 6 Oct 2021 14:00:56 +0000 (16:00 +0200)]
avtpsrc: Retry receive with same buffer size

Without this patch in case of a retry recv() will be called with a
negative size argument.

Signed-off-by: Timo Wischer <timo.wischer@de.bosch.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1078>

3 years agoparsebin: fix critical when sorting pads
Guillaume Desmottes [Tue, 26 Oct 2021 13:12:16 +0000 (15:12 +0200)]
parsebin: fix critical when sorting pads

If the pad does not have a current caps, get_pad() returns the query
caps which can be ANY. In such case the caps does not have any structure
resulting in a critical warning when calling gst_caps_get_structure().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1254>

3 years agocccombiner: fix default value when installing schedule property
Mathieu Duponchelle [Tue, 26 Oct 2021 14:00:36 +0000 (16:00 +0200)]
cccombiner: fix default value when installing schedule property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

3 years agocccombiner: fix emission of selected-samples in one case
Mathieu Duponchelle [Tue, 26 Oct 2021 13:58:26 +0000 (15:58 +0200)]
cccombiner: fix emission of selected-samples in one case

Detected while reading the code, cccombiner must set
self->current_video_buffer to NULL *after* emitting selected-samples
in order for the application to get a useful return when peeking
the next video sample.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

3 years agocccombiner: stop attaching caption buffers when caption pad has gone EOS
Mathieu Duponchelle [Mon, 25 Oct 2021 23:09:58 +0000 (01:09 +0200)]
cccombiner: stop attaching caption buffers when caption pad has gone EOS

When schedule is true (as is the case by default), we insert padding
when no caption data is present in the schedule queue, and previously
weren't checking whether the caption pad had gone EOS, leading to
infinite scheduling of padding after EOS on the caption pad.

Rectify that by adding a "drain" parameter to dequeue_caption()

In addition, update the captions_and_eos test to push valid cc_data
in: without this cccombiner was attaching padding buffers it had
generated itself, and with that patch would now stop attaching
said padding to the second buffer. By pushing valid, non-padding
cc_data we ensure a caption buffer is indeed attached to the first
and second video buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1252>

3 years agoci/fuzzing: update for mono repo
Matthew Waters [Tue, 26 Oct 2021 08:11:19 +0000 (19:11 +1100)]
ci/fuzzing: update for mono repo

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1253>

3 years agocurlsftpsink: Add support for sha256 fingerprint
Mats Lindestam [Wed, 20 Oct 2021 11:19:00 +0000 (13:19 +0200)]
curlsftpsink: Add support for sha256 fingerprint

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1193>

3 years agomsdkvpp: Add 12bit formats
Mengkejiergeli Ba [Thu, 21 Oct 2021 03:09:07 +0000 (11:09 +0800)]
msdkvpp: Add 12bit formats

Add 12bit formats for different chroma samplings at sink pad and
src pad, including P012_LE, Y212_LE and Y412_LE.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1218>

3 years agodevicemonitor: g_queue_clear_full introduced in glib 2.60
Ruben Gonzalez [Mon, 25 Oct 2021 19:55:25 +0000 (21:55 +0200)]
devicemonitor: g_queue_clear_full introduced in glib 2.60

The GStreamer dependency is glib >=2.56.0. Therefore, define
g_queue_clear_full if glib < 2.60.

Issue added in commit 1912bcbc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1251>

3 years agogs: update README to use fixed versions
Floris [Mon, 25 Oct 2021 16:52:24 +0000 (18:52 +0200)]
gs: update README to use fixed versions

Use specific versions, instead of relying on 'master'.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>

3 years agogssrc: use default blocksize
Floris [Mon, 25 Oct 2021 16:47:46 +0000 (18:47 +0200)]
gssrc: use default blocksize

The blocksize is set to 3 * 1024 * 1024 / 2, which is the default download_size of Google-Cloud-CPP.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/846

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1246>

3 years agovah265dec: Fix end_picture() vmethod.
Víctor Manuel Jáquez Leal [Mon, 25 Oct 2021 14:53:14 +0000 (16:53 +0200)]
vah265dec: Fix end_picture() vmethod.

Since commit 88437a9c the signature of h265decoder's end_picture()
changed to return GstFlowReturn, but vah265dec was not updated.

This commit fixes this regression.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1248>

3 years agodevicemonitor: Only fail start() if no provider at all could be started
Sebastian Dröge [Tue, 19 Oct 2021 10:39:55 +0000 (13:39 +0300)]
devicemonitor: Only fail start() if no provider at all could be started

Also refactor various internals of the monitor code:
  - Don't allow starting twice but just return directly when starting a
    second time.
  - Don't end up in an inconsistent state if call start() a second time
    while the monitor is starting up.
  - Remove complicated cookie code: it was not possible to add/remove
    filters while the monitor was started anyway so this was only useful
    in the very small time-window while starting the monitor or while
    getting the devices. Instead disallow adding/removing filters while
    the monitor is starting, and when getting devices work on a snapshot
    of providers/filters.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/667

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1189>

3 years agodocs: contribute: bump compiler reqs and coding style to C99
Tim-Philipp Müller [Sun, 16 May 2021 00:00:53 +0000 (01:00 +0100)]
docs: contribute: bump compiler reqs and coding style to C99

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-project/-/issues/78

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1243>

3 years agotypefindfunctions: Use memcmp() instead of a strange macro around strncmp()
Sebastian Dröge [Sat, 23 Oct 2021 13:06:54 +0000 (16:06 +0300)]
typefindfunctions: Use memcmp() instead of a strange macro around strncmp()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

3 years agotypefindfunctions: Add various CMAF brands to the MP4 typefinder
Sebastian Dröge [Sat, 23 Oct 2021 11:31:59 +0000 (14:31 +0300)]
typefindfunctions: Add various CMAF brands to the MP4 typefinder

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

3 years agotypefindfunctions: Refactor ftyp brands checking
Sebastian Dröge [Sat, 23 Oct 2021 11:30:02 +0000 (14:30 +0300)]
typefindfunctions: Refactor ftyp brands checking

Store known brands in arrays and add a helper function to check them.

Also add all the `iso3` to `isob` ISO brands and the `hlsf` ISO
fragmented brand.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

3 years agotypefindfunctions: Add various other boxes to the list of known top-level MP4 boxes
Sebastian Dröge [Sat, 23 Oct 2021 11:28:35 +0000 (14:28 +0300)]
typefindfunctions: Add various other boxes to the list of known top-level MP4 boxes

styp, udta, sidx, ssix, prft, mfra, pdin and meta are in the ISOBMFF
spec and emsg in the CMAF spec.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1234>

3 years agova: allocator: Fix possible memory leaks
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:32:30 +0000 (17:32 +0800)]
va: allocator: Fix possible memory leaks

At gst_va_dmabuf_allocator_setup_buffer_full, static code analysis tool
does not know number of objects in descriptor is always larger than 0 if
export_surface_to_dmabuf succeeds. Thus, the tool will assume buf is
allocated with mem but not released when desc.num_objects equals to 0
and raise a mem leak issue.

For gst_va_dambuf_memories_setup, we should also inform the tool that
n_planes will be larger than 0 by checking the value at very beginning.
Then, the defect similar to above will not be raised during static analysis.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1241>

3 years agogst-plugins-ugly: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:36 +0000 (01:02 +0100)]
gst-plugins-ugly: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

3 years agogst-plugins-bad: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:28 +0000 (01:02 +0100)]
gst-plugins-bad: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

3 years agogst-plugins-good: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:02:07 +0000 (01:02 +0100)]
gst-plugins-good: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

3 years agogst-plugins-base: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:01:56 +0000 (01:01 +0100)]
gst-plugins-base: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

3 years agogstreamer: update translations
Tim-Philipp Müller [Mon, 25 Oct 2021 00:01:28 +0000 (01:01 +0100)]
gstreamer: update translations

Fixes #656

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1240>

3 years agod3d11: add support for new debug layer versions
Andoni Morales Alastruey [Sat, 23 Oct 2021 17:26:06 +0000 (19:26 +0200)]
d3d11: add support for new debug layer versions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1237>

3 years agoqtdemux: Add pasp box to the list of known boxes
Sebastian Dröge [Sat, 23 Oct 2021 11:38:06 +0000 (14:38 +0300)]
qtdemux: Add pasp box to the list of known boxes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1235>

3 years agoassrender: Add "application/vnd.ms-opentype" mimetype detection
Rafał Dzięgiel [Wed, 20 Jan 2021 11:04:48 +0000 (12:04 +0100)]
assrender: Add "application/vnd.ms-opentype" mimetype detection

The "application/vnd.ms-opentype" mimetype is commonly used in many fonts attached in the matroska videos.
Assrender should treat it as compatible without the need of parsing the file extension.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1207>

3 years agodocs: contribute: update how-to-submit-patches section for monorepo
Tim-Philipp Müller [Fri, 22 Oct 2021 16:56:26 +0000 (17:56 +0100)]
docs: contribute: update how-to-submit-patches section for monorepo

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/840#note_1114907

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1231>

3 years agowrap: libopenjp2: use patch version 7
Stéphane Cerveau [Fri, 22 Oct 2021 16:13:46 +0000 (18:13 +0200)]
wrap: libopenjp2: use patch version 7

Add support for win32 build
Disable the binary to avoid the thirdparty
dependency to be checked.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1229>

3 years agobaseparse: fix invalid avg_bitrate after reset
Pascal Hache [Fri, 22 Oct 2021 15:00:06 +0000 (11:00 -0400)]
baseparse: fix invalid avg_bitrate after reset

gst_base_parse_reset() does not reset data_bytecount to 0, so
gst_base_parse_update_bitrates() uses a wrong value to calculate
the average bitrate on subsequent pipeline starts. This leads to an
excessive amount of "tag" events being pushed. These events include
very high "bitrate" values that diminish over time, and are produced
until the average bitrate is back to sane values.

Fixes #840

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1228>

3 years agoRename toplevel project to gstreamer-full
Xavier Claessens [Fri, 22 Oct 2021 16:38:46 +0000 (12:38 -0400)]
Rename toplevel project to gstreamer-full

This generates better tarball names when doing "meson dist" on the top
level project. It is also consistent with that project providing
gstreamer-full library.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1230>

3 years agogl/egl: install required egl.h header
Matthew Waters [Fri, 22 Oct 2021 06:54:55 +0000 (17:54 +1100)]
gl/egl: install required egl.h header

Fixes build against using the gir.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1227>

3 years agogstvulkan: Constify code in create_shader
Martin Reboredo [Fri, 22 Oct 2021 02:35:41 +0000 (23:35 -0300)]
gstvulkan: Constify code in create_shader

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1226>

3 years agomeson: default to gpl=disabled for gst-plugins-bad and -ugly
Tim-Philipp Müller [Wed, 20 Oct 2021 23:33:06 +0000 (00:33 +0100)]
meson: default to gpl=disabled for gst-plugins-bad and -ugly

This will only affect individual/tarball module builds, as the
options yield to the parent project which was set to gpl=disabled
by default already. We kept it as auto in the original commit
to accommodate the need to update cerbero as well, which had to
be done separately after the initial commit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1217>

3 years agoassrender: Do not iterate over mimetypes without filename
Rafał Dzięgiel [Wed, 20 Jan 2021 12:38:03 +0000 (13:38 +0100)]
assrender: Do not iterate over mimetypes without filename

No point spending time on iterating and comparing strings if we
are going to reject the value due to missing filename anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

3 years agoassrender: Fix mimetype detection
Rafał Dzięgiel [Wed, 20 Jan 2021 10:46:17 +0000 (11:46 +0100)]
assrender: Fix mimetype detection

Previously gst_structure_has_name was used to get a string to compare with supported mimetypes.
This is incorrect as above function returns a user defined structure name which is
not the structure mimetype value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

3 years agomatroska: Set image/attachment structure mimetype
Rafał Dzięgiel [Wed, 20 Jan 2021 10:53:51 +0000 (11:53 +0100)]
matroska: Set image/attachment structure mimetype

Set structure mimetype to fix data detection by mimetype in other plugins.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

3 years agomatroska: Treat non-image structure as attachment
Rafał Dzięgiel [Wed, 20 Jan 2021 10:33:39 +0000 (11:33 +0100)]
matroska: Treat non-image structure as attachment

Otherwise each structure is named as GstTagImageInfo even if
it does not contain any images which is misleading.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

3 years agortpbin: fix leak of pad when a fec encoder and aux sender a created
Matthew Waters [Thu, 21 Oct 2021 09:32:05 +0000 (20:32 +1100)]
rtpbin: fix leak of pad when a fec encoder and aux sender a created

The ghost sink pad retrieved by rtpbin from the aux sender was not freed
when there was a previous element (fec encoder) in the chain.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1222>

3 years agoci: gstreamer-full: remove static build
Stéphane Cerveau [Wed, 20 Oct 2021 15:56:49 +0000 (17:56 +0200)]
ci: gstreamer-full: remove static build

The gstreamer-full jobs act as
static builds,  no need to perform it twice.

gstreamer-full-minimal can be nodebug.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1215>

3 years agoREADME: Remove outdated Windows ARM64 related comment
Seungha Yang [Thu, 21 Oct 2021 09:25:47 +0000 (18:25 +0900)]
README: Remove outdated Windows ARM64 related comment

We bumped required meson version which contains the mentioned
meson patch already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1221>

3 years agovulkan/swapper: add some debug logging for surface size and present modes
Matthew Waters [Thu, 21 Oct 2021 08:17:18 +0000 (19:17 +1100)]
vulkan/swapper: add some debug logging for surface size and present modes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1219>

3 years agointerlace: Replace custom lock with object lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:28:25 +0000 (00:28 +0200)]
interlace: Replace custom lock with object lock

The object lock is sufficient for the task of protecting against
object property data races.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

3 years agointerlace: Protect all properties with the lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:37:47 +0000 (00:37 +0200)]
interlace: Protect all properties with the lock

Avoid blatant data races here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

3 years agointerlace: Reset src_fps_d together with src_fps_n
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:36:47 +0000 (00:36 +0200)]
interlace: Reset src_fps_d together with src_fps_n

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

3 years agointerlace: Clear stored_fields together with stored_frame
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:35:00 +0000 (00:35 +0200)]
interlace: Clear stored_fields together with stored_frame

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

3 years agointerlace: Reset after changing state to READY
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:31:24 +0000 (00:31 +0200)]
interlace: Reset after changing state to READY

Trying to reset before the pads have been deactivated races with the
streaming thread. There was also a buggy buffer clear leaving a dangling
`stored_frame` pointer around. Use `gst_interlace_reset` so this happens
properly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

3 years agonvh264enc: add constrained-baseline to the caps profiles
Mathieu Duponchelle [Wed, 20 Oct 2021 12:34:42 +0000 (14:34 +0200)]
nvh264enc: add constrained-baseline to the caps profiles

In practice, when baseline is requested from the encoder it
produces constrained baseline, and it is already reflected
in the profile-iop flags.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1213>

3 years agomediafoundation: Fix for UWP build
Seungha Yang [Wed, 20 Oct 2021 16:47:07 +0000 (01:47 +0900)]
mediafoundation: Fix for UWP build

We don't support D3D11 interop for UWP because some APIs
(specifically MFTEnum2) are desktop application only.
However, the code for symbol loading is commonly used by both UWP and WIN32.
Just link GModule unconditionally which is UWP compatible, and simply don't
try to load any library/symbol dynamically when D3D11 interop is unavailable.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1216>

3 years agoRevert "ci: Split base and core valgrind on different runners"
Thibault Saunier [Wed, 20 Oct 2021 12:09:33 +0000 (09:09 -0300)]
Revert "ci: Split base and core valgrind on different runners"

Those job are not the ones that take most time in normal run (they
where when running with --n-runs) and that leads to using more runners
which might be a problem at this point.

This reverts commit 4ad22b05a15056b9e85468af266bacc7d3758ee9.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1212>

3 years agodocs: remove mms plugin from symbol index
Tim-Philipp Müller [Wed, 20 Oct 2021 00:06:12 +0000 (01:06 +0100)]
docs: remove mms plugin from symbol index

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>

3 years agomms: remove mmssrc plugin
Tim-Philipp Müller [Tue, 19 Oct 2021 23:54:26 +0000 (00:54 +0100)]
mms: remove mmssrc plugin

Doubtful that anyone still needs that or there are even
any streams left out there.

MMS was deprecated in 2003 (in favour of RTSP) and support for
it was dropped with Microsoft Media Services 2008.

https://en.wikipedia.org/wiki/Microsoft_Media_Server
https://sdp.ppona.com/news2008.html

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/821

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>

3 years agostreamsynchronizer: set running time offset on events
Guillaume Desmottes [Wed, 20 Oct 2021 09:56:32 +0000 (11:56 +0200)]
streamsynchronizer: set running time offset on events

It's cleaner and more generic than overriding the qos events.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1210>

3 years agoconcat: fix qos event handling
Guillaume Desmottes [Wed, 20 Oct 2021 09:20:13 +0000 (11:20 +0200)]
concat: fix qos event handling

We were shadowing the sinkpad variable resulting in:
- the QoS event to be send to all sink pads instead of the active one
- the pad to be leaked

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1208>

3 years agodoc: update meson version in README.md
Brad Hards [Wed, 20 Oct 2021 09:28:27 +0000 (20:28 +1100)]
doc: update meson version in README.md

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1209>

3 years agomeson: va, msdk: simplify dep.get_variable() use
Tim-Philipp Müller [Tue, 19 Oct 2021 17:18:25 +0000 (18:18 +0100)]
meson: va, msdk: simplify dep.get_variable() use

With recent Meson versions we can just write dep.get_variable('foo')
instead of dep.get_variable(pkgconfig: 'driverdir', internal: 'driverdir').

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agomeson: fix use of deprecated meson api external_program.path()
Tim-Philipp Müller [Mon, 18 Oct 2021 15:55:14 +0000 (16:55 +0100)]
meson: fix use of deprecated meson api external_program.path()

Just using .full_path() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agomeson: fix use of deprecated meson api meson.has_exe_wrapper()
Tim-Philipp Müller [Mon, 18 Oct 2021 15:51:37 +0000 (16:51 +0100)]
meson: fix use of deprecated meson api meson.has_exe_wrapper()

Use meson.can_run_host_binaries() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agomeson: update for meson.build_root() and .build_source() deprecation
Tim-Philipp Müller [Mon, 18 Oct 2021 14:47:00 +0000 (15:47 +0100)]
meson: update for meson.build_root() and .build_source() deprecation

-> use meson.project_build_root() or .global_build_root() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agomeson: update for dep.get_pkgconfig_variable() deprecation
Tim-Philipp Müller [Sun, 17 Oct 2021 23:40:14 +0000 (00:40 +0100)]
meson: update for dep.get_pkgconfig_variable() deprecation

... in favour of dep.get_variable('foo', ..) which in some
cases allows for further cleanups in future since we can
extract variables from pkg-config dependencies as well as
internal dependencies using this mechanism.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agomeson: clean up conditional paths after version bump
Tim-Philipp Müller [Sun, 17 Oct 2021 23:03:47 +0000 (00:03 +0100)]
meson: clean up conditional paths after version bump

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

3 years agoassrender: fix smooth scaling by disabling hinting
Rafał Dzięgiel [Thu, 19 Nov 2020 17:03:11 +0000 (18:03 +0100)]
assrender: fix smooth scaling by disabling hinting

When ass hinting value is set to anything other than NONE,
subtitles cannot use smooth scaling, thus all animations will jitter.

The libass author warns about possibility of breaking some scripts when it is enabled,
so lets do what is recommended and disable it to get the smooth scaling working.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1201>

3 years agodiscoverer: Set number to stream infos
Thibault Saunier [Tue, 9 Feb 2021 22:56:49 +0000 (19:56 -0300)]
discoverer: Set number to stream infos

The idea is that we can reference to streams using this unique number,
within the context of that discoverer info. That number should always
be usable to reference the streams for a specific stream.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/897>

3 years agodiscoverer: Don't ref NULL taglist
Edward Hervey [Wed, 20 Oct 2021 07:37:40 +0000 (09:37 +0200)]
discoverer: Don't ref NULL taglist

Fixes warning introduced in 064f7bbbfac9610fd391c45091e35391b80e1212

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1200>

3 years agointegration/ges: Ignore GstStream for validate tests
Edward Hervey [Tue, 19 Oct 2021 15:11:24 +0000 (17:11 +0200)]
integration/ges: Ignore GstStream for validate tests

Requires the ges runner to be configured in such a way that the resulting
stream-id is consistent (and therefore can be checked)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>

3 years agostream: Set the object name to the stream id
Edward Hervey [Fri, 28 May 2021 05:54:32 +0000 (07:54 +0200)]
stream: Set the object name to the stream id

Makes it more meaningful in debug logs (instead of streamNNNNN)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>

3 years agodocs: remove mention of mms from docs and mmssrc from tutorials
Tim-Philipp Müller [Wed, 20 Oct 2021 00:03:26 +0000 (01:03 +0100)]
docs: remove mention of mms from docs and mmssrc from tutorials

Prerequisite for our removing it from the cerbero build, see
https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/760

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1199>

3 years agortphdrext-clientaudiolevel: Rename RFC 6464 element
Olivier Crête [Wed, 15 Sep 2021 18:19:06 +0000 (14:19 -0400)]
rtphdrext-clientaudiolevel: Rename RFC 6464 element

Multiplying elements named after RFC numbers is confusing,
so let's give them meaningful names.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1125>

3 years agoci: gstreamer-full: reenable build
Stéphane Cerveau [Tue, 19 Oct 2021 11:11:01 +0000 (13:11 +0200)]
ci: gstreamer-full: reenable build

The gstreamer-full job should be run
during the integrate stage always.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1190>

3 years agosubprojects: Update ogg and vorbis wraps
Seungha Yang [Tue, 19 Oct 2021 15:28:33 +0000 (00:28 +0900)]
subprojects: Update ogg and vorbis wraps

... to 1.3.5-2 and 1.3.7-2, respectively. Specifically to fix
ogg/vorbis plugin loading on Windows devenv environment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1196>

3 years agoRevert "meson: Link to objects instea of static helper library"
Xavier Claessens [Tue, 19 Oct 2021 14:24:42 +0000 (10:24 -0400)]
Revert "meson: Link to objects instea of static helper library"

This reverts commit b19de413b94d228b1460b0899f9b41b2b5233943.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

3 years agoRevert "audio: Merge simd libs into the main one"
Xavier Claessens [Tue, 19 Oct 2021 14:07:55 +0000 (10:07 -0400)]
Revert "audio: Merge simd libs into the main one"

This reverts commit 4d3a200358439e6c76c5dd1be2daae0cceb0e44a.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

3 years agoAdd initial meson devenv support
Xavier Claessens [Sun, 21 Feb 2021 15:20:15 +0000 (10:20 -0500)]
Add initial meson devenv support

There is still a few things missing compared to gst-env.py, but it is
functional.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1162>

3 years agovideo-overlay-composition: Fix constructor guard to actually allow NULL as parameter
Sebastian Dröge [Tue, 19 Oct 2021 14:07:37 +0000 (17:07 +0300)]
video-overlay-composition: Fix constructor guard to actually allow NULL as parameter

And don't use a NULL rectangle later.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1195>

3 years agogl/eagl: fix eagl display creation
Matthew Waters [Tue, 19 Oct 2021 08:46:48 +0000 (19:46 +1100)]
gl/eagl: fix eagl display creation

The GstGLDisplayType of the display was win32 instead of the required eagl.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1188>

3 years agoqtdemux: Add support for wvtt (WebVTT) subtitles.
Jan Schmidt [Fri, 4 Jun 2021 17:13:52 +0000 (03:13 +1000)]
qtdemux: Add support for wvtt (WebVTT) subtitles.

WebVTT in ISO MP4 is specified in ISO 14496-30,
and needed for DASH support. It's stored in an
mp4 specific format. To handle it compatibly,
the wvtt boxes are converted back into WebVTT text
and pushed as application/x-subtitle-vtt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

3 years agoisomp4: Split buffer process functions.
Jan Schmidt [Fri, 27 Aug 2021 12:45:18 +0000 (22:45 +1000)]
isomp4: Split buffer process functions.

Split the different handling for closed captions, VobSub subpicture
and timed text samples into separate simplified process functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

3 years agoisomp4: Use a function pointer for buffer splitting.
Jan Schmidt [Fri, 27 Aug 2021 11:58:25 +0000 (21:58 +1000)]
isomp4: Use a function pointer for buffer splitting.

Swap the `need_process` boolean check on qtdemux streams
for a direct function pointer to the splitting function,
so we can stop adding extra cases to the single growing
`gst_qtdemux_process_buffer()` function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>