humper [Tue, 17 Jun 2014 20:39:29 +0000 (13:39 -0700)]
Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.
approved over in https://codereview.chromium.org/
331863006/; reuploading
because it had the wrong base url
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
341543005
Ben Wagner [Tue, 17 Jun 2014 20:28:20 +0000 (16:28 -0400)]
Update Windows baselines due to VS2013 update.
Floating point operations now differ in the low bits from before.
reed [Tue, 17 Jun 2014 19:31:49 +0000 (12:31 -0700)]
rebaseline after changing labels in bitmapfilters
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
340583004
mtklein [Tue, 17 Jun 2014 19:08:15 +0000 (12:08 -0700)]
Add EXPERIMENTAL_beginRecording() for SkRecord-based recording.
The interesting stuff is in SkPictureRecorder.{h,cpp}. The rest is mostly moving SkRecord from its own directories into core to avoid circular dependencies in GYP.
After plumbing SkRecord all the way through in Picture, I'll delete its old entry point include/record/SkRecording.h. For now it and record.gypi need to stay where they are to keep Chrome building.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
331573004
mtklein [Tue, 17 Jun 2014 18:47:40 +0000 (11:47 -0700)]
Silence warnings about using offsetof on near-POD structs.
This is coming up with SkMatrix, which is POD according to GCC >= 4.6
but not before (specifically, not at GCC 4.4).
BUG=skia:
R=reed@google.com, mtklein@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
339193002
henrik.smiding [Tue, 17 Jun 2014 18:32:47 +0000 (11:32 -0700)]
Add SSE4 optimization of S32A_Opaque_Blitrow
Adds optimization of Skia S32A_Opaque_Blitrow blitter using SSE4.2 SIMD
instruction set. Special case for when alpha is zero or opaque.
Performance increase of 10%-400% compared to the existing SSE2
optimization (measured on Silvermont architecture).
Noticeable in ~25 different skia bench subtests, especially in
bitmap_8888_*, repeatTile_*, and morph_*.
bitmap_8888_A - 100% faster
bitmap_8888_A_source_transparent - 250% faster
bitmap_8888_A_source_opaque - 25% faster
bitmap_8888_A_scale_bicubic - 75% faster
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: https://skia.googlesource.com/skia/+/
e2527b147679b0c43019fae7d59cc3777d2d097e
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
289473009
dandov [Tue, 17 Jun 2014 18:21:45 +0000 (11:21 -0700)]
* Removed bitmapshaders from expectations/gm/ignored-tests.txt.
* Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps
because it didn't consider the skpaint's color.
BUG=skia:2293
R=jvanverth@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
339923004
bungeman [Tue, 17 Jun 2014 17:48:04 +0000 (10:48 -0700)]
DirectWrite to use PostScript name for PDF.
The PDF backend expects info->fFontName to be the PostScript name.
Prior to this change the '<family> <sytle>' name was used instead.
R=vandebo@chromium.org, halcanary@google.com, reed@google.com, thestig@chromium.org
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
324403010
reed [Tue, 17 Jun 2014 17:32:30 +0000 (10:32 -0700)]
rebaseline after GM change to bitmapfilters
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
341593003
reed [Tue, 17 Jun 2014 17:28:08 +0000 (10:28 -0700)]
ignore bitmapfilters failures until we can rebaseline
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
339153004
reed [Tue, 17 Jun 2014 16:04:45 +0000 (09:04 -0700)]
move some headers out of public
patch from issue
338263003
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
339183002
reed [Tue, 17 Jun 2014 15:38:31 +0000 (08:38 -0700)]
hide SkBitmap::Config entirely (behind a flag)
patch from issue
339463002
TBR=
I think the NoGPU failure is unrelated, so ignoring
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
340533002
mtklein [Tue, 17 Jun 2014 14:42:34 +0000 (07:42 -0700)]
Move SkStringUtils.h to src/core.
Doesn't need to be in include/.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
335413004
mtklein [Tue, 17 Jun 2014 14:06:29 +0000 (07:06 -0700)]
BenchSysTimer_mach drops all sub-ms precision. Fix that!
BUG=skia:
R=bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
336903005
caryclark [Tue, 17 Jun 2014 12:41:12 +0000 (05:41 -0700)]
fix chrome
had #if SK_DEBUG instead of #ifdef SK_DEBUG
R=reed@android.com
TBR=reed
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
338333002
caryclark [Tue, 17 Jun 2014 12:15:38 +0000 (05:15 -0700)]
Enabling the canvas bit to turn the clip stack into a flat replace exposed around 100 failures when testing the 800K skp set generated from the top 1M web sites.
This fixes all but one of those failures.
Major changes include:
- Replace angle indices with angle pointers. This was motivated by the need to add angles later but not renumber existing angles.
- Aggressive segment chase. When the winding is known on a segment, more aggressively passing that winding to adjacent segments allows fragmented data sets to succeed.
- Line segments with ends nearly the same are treated as coincident first.
- Transfer partial coincidence by observing that if segment A is partially coincident to B and C then B and C may be partially coincident.
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
272153002
mtklein [Tue, 17 Jun 2014 03:21:06 +0000 (20:21 -0700)]
Add nanomsg to third_party, with some demos.
This isn't something I want to make part of Skia, but just a substrate to build cross-process demos on top of. If I client were to use Skia cross-process, they'd drop their own IPC system in here.
If you're not familiar, nanomsg (nanomsg.org) is the next-gen zeromq (zeromq.org), from the same author, righting all his design wrongs from zeromq.
It's a lot like the lower half of mojo, dealing with making the connections and getting messages reliably from A to B. Think, better sockets, and it spans nicely across in-process (with zero-copy), inter-process, and TCP.
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
294873004
mtklein [Tue, 17 Jun 2014 03:03:43 +0000 (20:03 -0700)]
Split out DEPS change from
294873004 to land first.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
331913004
reed [Mon, 16 Jun 2014 22:18:25 +0000 (15:18 -0700)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE -- not needed
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
332163005
mtklein [Mon, 16 Jun 2014 21:04:32 +0000 (14:04 -0700)]
Refine bench_record and bench_playback:
- use high-precision wall timer only
- warm caches once before measuring
- measure independent samples, calculating statistics
- add --verbose to control how much data we output
Also removed some unloved features from bench_record.
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
338203002
borenet [Mon, 16 Jun 2014 20:41:25 +0000 (13:41 -0700)]
Fix Windows bots
BUG=skia:
R=mtklein@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
339733002
mtklein [Mon, 16 Jun 2014 20:11:27 +0000 (13:11 -0700)]
Revert of Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. (https://codereview.chromium.org/
331193004/)
Reason for revert:
Experiment is over: disabling SSSE3 is a 25-50% perf regression for bitmap scaling on every machine we've got.
Original issue's description:
> Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots.
>
> BUG=372232
>
> Committed: https://skia.googlesource.com/skia/+/
f1e5a04832e4d350f9ebf5d556c6d3897345f883
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=372232
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
332213005
fmalita [Mon, 16 Jun 2014 19:13:39 +0000 (12:13 -0700)]
Prepare for internal SaveFlags removal.
Chromium has a couple of SkCanvas subclasses which override willSave().
This adds a transitional shim to facilitate converting these to the
parameter-less API.
BUG=skia:2297
R=reed@google.com, scroggo@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
338913002
piotaixr [Mon, 16 Jun 2014 18:50:49 +0000 (11:50 -0700)]
Cleaned a repeated if(condition) with the same condition
R=junov@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
338933002
senorblanco [Mon, 16 Jun 2014 17:49:58 +0000 (10:49 -0700)]
Perlin noise cleanup.
Remove Simplex noise implementation and now-redundant base classes.
BUG=skia:
R=sugoi@chromium.org, sugoi@google.com, reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
336043002
mtklein [Mon, 16 Jun 2014 17:22:12 +0000 (10:22 -0700)]
Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots.
BUG=372232
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
331193004
kevin.petit [Mon, 16 Jun 2014 17:05:41 +0000 (10:05 -0700)]
Armv8/64bit doesn't (apparently) need rebaselining
BUG=skia:
R=reed@google.com
NOTRY=True
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
334743009
senorblanco [Mon, 16 Jun 2014 15:54:57 +0000 (08:54 -0700)]
Add sugoi@ to CQ_COMMITTERS.
R=junov@chromium.org
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
337033005
reed [Mon, 16 Jun 2014 15:25:57 +0000 (08:25 -0700)]
fix legacy code path for SK_SUPPORT_LEGACY_IMAGEDECODER_CONFIG
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
332223002
Eric Boren [Mon, 16 Jun 2014 14:02:42 +0000 (10:02 -0400)]
Enable compiling with automatically-downloaded VS toolchain on Windows bots
Requires that the bots have CHROME_HEADLESS=1 and CHROME_PATH set.
BUG=skia:2216
R=epoger@google.com
Review URL: https://codereview.chromium.org/
332833002
borenet [Mon, 16 Jun 2014 06:52:57 +0000 (23:52 -0700)]
Update SKP version to 24
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
332983003
tfarina [Mon, 16 Jun 2014 03:10:44 +0000 (20:10 -0700)]
Minor cleanups in picture_utils header file.
1) Remove unused include.
2) Remove unused forward declarations.
BUG=None
TEST=make tests
R=epoger@google.com
TBR=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
339493004
borenet [Sun, 15 Jun 2014 06:47:32 +0000 (23:47 -0700)]
Update SKP version to 23
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
332843006
reed [Sat, 14 Jun 2014 12:30:20 +0000 (05:30 -0700)]
stop using SkBitmap::Config
R=scroggo@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
338493005
borenet [Sat, 14 Jun 2014 11:50:12 +0000 (04:50 -0700)]
Update SKP version to 22
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
332013002
tfarina [Sat, 14 Jun 2014 11:50:04 +0000 (04:50 -0700)]
Delete unused path_utils.* component.
filter tool includes it but isn't using, and nobody else seems to
be using it either. So just remove it now.
BUG=None
TEST=make filter
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
324273002
reed [Sat, 14 Jun 2014 11:24:56 +0000 (04:24 -0700)]
hide virtuals on device for width/height/isopaque
R=bsalomon@google.com
NOTREECHECKS=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
334993002
rmistry [Fri, 13 Jun 2014 18:59:43 +0000 (11:59 -0700)]
Testing trybot triggering
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-x86_64-Debug-CrOS_Link-Trybot
BUG=skia:2659
NOTREECHECKS=true
TBR=
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
332933005
kkinnunen [Fri, 13 Jun 2014 06:06:28 +0000 (23:06 -0700)]
Extract "text align proc" functions as reusable classes
Extract "text align proc" as reusable classes. These classes need to be used
when writing GrTextContext subclasses.
Moves "text align proc" code that is duplicated in SkDraw and
SkBitmapTextContext to SkDrawProcs.h and SkTextMapState.h. This functionality is
also used in the new GrStencilAndCoverTextContext.
Creates new functor classes SkTextAlignProc and SkTextAlignProcScalar which
represent the previous "text align procs".
Moves TextMapState from SkDraw to SkTextMapStateProc and make it similar functor.
The transform should be comparable in speed, as the compiler can and does avoid
the call and eliminate some of the branches.
R=jvanverth@google.com, reed@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
335573002
rs.prinja [Fri, 13 Jun 2014 05:55:08 +0000 (22:55 -0700)]
Randomize seed for SkDiscretePathEffect::filterPath()
Fix for https://code.google.com/p/skia/issues/detail?id=2581. Randomizes
the seed in SkDiscretePathEffect::filterPath(). Prior to this we were
using the path length as a seed.
Now, if we have two different paths with identical contents and we
apply an SkDiscretePathEffect to each, we obtain two different random
paths. Previously, we would obtain two overlapping paths (identical
path contents leading to the same seed).
BUG=skia:
R=reed@google.com, scroggo@google.com
Author: rs.prinja@samsung.com
Review URL: https://codereview.chromium.org/
311803002
reed [Fri, 13 Jun 2014 00:40:00 +0000 (17:40 -0700)]
hide Config in SkImageDecoder -- use SkColorType instead
patch from issue
334613003
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
334793002
senorblanco [Thu, 12 Jun 2014 21:31:56 +0000 (14:31 -0700)]
New baselines for perlin noise tests affected by ce6a35.
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.
R=scroggo@google.com
TBR=scroggo
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
336703002
robertphillips [Thu, 12 Jun 2014 19:56:58 +0000 (12:56 -0700)]
Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag
Chromium/Blink should no longer need this flag after:
Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/
322123002/
Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/
326953002/
R=mtklein@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
328343002
reed [Thu, 12 Jun 2014 19:53:00 +0000 (12:53 -0700)]
rebaselines for removal of unitmapper
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
330513005
Stephen White [Thu, 12 Jun 2014 19:51:46 +0000 (15:51 -0400)]
Add more tests to ignore-tests.txt.
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/
332523006/.
TBR=scroggo
BUG=skia:
Review URL: https://codereview.chromium.org/
336663002
scroggo [Thu, 12 Jun 2014 19:10:24 +0000 (12:10 -0700)]
Revert of third try at landing improved blur rect; this time with more correctness (https://codereview.chromium.org/
331443003/)
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html
Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/
72abfc2b4e7caead660f6b6a05e60d05eaf1a66f
R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
333763002
egdaniel [Thu, 12 Jun 2014 18:58:15 +0000 (11:58 -0700)]
Add another fail-ignore for flaky dashing4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
329223007
bensong [Thu, 12 Jun 2014 18:36:53 +0000 (11:36 -0700)]
Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 968
R=bsalomon@google.com
TBR=scroggo@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
338453004
kelvinly [Thu, 12 Jun 2014 18:27:40 +0000 (11:27 -0700)]
Added in framework to get more bench data
BUG=skia:
NOTRY=true
R=jcgregorio@google.com, bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
331683003
senorblanco [Thu, 12 Jun 2014 18:24:19 +0000 (11:24 -0700)]
Fix tiled perlin noise.
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495).
The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.
This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)
R=sugoi@google.com, sugoi
TBR=senorblanco
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
332523006
egdaniel [Thu, 12 Jun 2014 17:24:21 +0000 (10:24 -0700)]
Use vertex attributes for dash effect in gpu
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
326103002
bensong [Thu, 12 Jun 2014 16:40:47 +0000 (09:40 -0700)]
manual bench rebase after 679426c using old algorithm
R=robertphillips@google.com
TBR=borenet@google.com, robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
330103002
reed [Thu, 12 Jun 2014 16:21:31 +0000 (09:21 -0700)]
remove GetDeviceConfig/SetDeviceConfig
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
332453002
krajcevski [Thu, 12 Jun 2014 16:20:38 +0000 (09:20 -0700)]
Use scratch with LATC data if possible
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
330593004
tfarina [Thu, 12 Jun 2014 15:50:56 +0000 (08:50 -0700)]
Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().
BUG=None
TEST=make tools tests && out/Debug/tests
R=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
327403002
bensong [Thu, 12 Jun 2014 15:25:04 +0000 (08:25 -0700)]
removes deprecated -q flag for gsutil.
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
333643005
bensong [Thu, 12 Jun 2014 15:05:43 +0000 (08:05 -0700)]
Really revert bench trigger changes.
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
324403009
egdaniel [Thu, 12 Jun 2014 15:02:43 +0000 (08:02 -0700)]
Rebase flakey windows dash4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2667
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
335443003
kelvinly [Thu, 12 Jun 2014 13:40:57 +0000 (06:40 -0700)]
Revert trigger changes
BUG=skia:
NOTRY=true
R=robertphillips@google.com, bensong@google.com, jcgregorio@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
334673002
egdaniel [Thu, 12 Jun 2014 13:26:15 +0000 (06:26 -0700)]
Add expectations for dashing gm
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
330033002
rmistry [Thu, 12 Jun 2014 13:23:38 +0000 (06:23 -0700)]
Whitespace change to test trybot triggering
BUG=skia:
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-Arm7-Release-Android-Trybot
TBR=
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
333663002
scroggo [Thu, 12 Jun 2014 12:54:37 +0000 (05:54 -0700)]
manual bench rebase after 679426c
In response to:
- new SKPs
- Kelvin's changes around regression testing
R=robertphillips@google.com, kelvinly@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
332483004
robertphillips [Thu, 12 Jun 2014 12:51:22 +0000 (05:51 -0700)]
Remove SkPicture pointer from SkPicturePlayback
This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
334493002
borenet [Thu, 12 Jun 2014 07:43:39 +0000 (00:43 -0700)]
Update SKP version to 21
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
327213004
epoger [Thu, 12 Jun 2014 03:35:59 +0000 (20:35 -0700)]
rebaseline_server: delete no-longer-used weightedDiffMeasure
(replaced by perceptual diff)
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
334533003
epoger [Thu, 12 Jun 2014 03:02:26 +0000 (20:02 -0700)]
rebaseline_server: change 2 image expectations within unittests
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
329933002
mtklein [Thu, 12 Jun 2014 00:22:14 +0000 (17:22 -0700)]
Suppress libpoppler and its dependent liblcms in TSAN.
This will let us eventually turn PDF back on in DM.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
330433003
krajcevski [Wed, 11 Jun 2014 23:08:50 +0000 (16:08 -0700)]
Add ifdef to not use function pointer that we don't have yet on Chromium??
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326423003
krajcevski [Wed, 11 Jun 2014 23:07:50 +0000 (16:07 -0700)]
Allow compressed texture data to be updated.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326383003
epoger [Wed, 11 Jun 2014 21:01:35 +0000 (14:01 -0700)]
rebaseline_server: merge identical results (across multiple builders/configs) into a single row
BUG=skia:2534
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
326013002
jvanverth [Wed, 11 Jun 2014 20:59:22 +0000 (13:59 -0700)]
Fix a number of issues with iOS build.
Set pointer to root view in window (for SampleApp)
Set up the correct function pointer for GL multisampling
Remove use of SkBitmap::setConfig()
Remove incomplete iOS implementation of SkFILE (use SkOSFile for now)
R=caryclark@google.com, reed@google.com, bsalomon@google.com, tfarina@chromium.org
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
322403007
humper [Wed, 11 Jun 2014 19:42:49 +0000 (12:42 -0700)]
third try at landing improved blur rect; this time with more correctness
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
331443003
krajcevski [Wed, 11 Jun 2014 19:26:49 +0000 (12:26 -0700)]
Texture compression unit tests along with a couple of bug fixes
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
330453005
mtklein [Wed, 11 Jun 2014 18:57:43 +0000 (11:57 -0700)]
SkNEW as default Create() for SkLazyPtr macros.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
326413003
robertphillips [Wed, 11 Jun 2014 18:37:55 +0000 (11:37 -0700)]
Remove picture pre-allocation from SkPictureRecorder
This CL improves the separation of the SkPicture and SkPictureRecord classes. It delays creation of the SkPicture (in SkPictureRecorder) until recording is actually completed. To accomplish this the SkRecord-derived classes now get SkPathHeap and SkPictureContentInfo members that are absorbed by the SkPicture when it is constructed.
As an ancillary change, this CL also moves the SkPictureContentInfo object from SkPicture to SkPicturePlayback. This is intended to centralize all the data in the SkPicturePlayback object.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324293004
scroggo [Wed, 11 Jun 2014 17:51:42 +0000 (10:51 -0700)]
Hide chooseFromOneChoice along with Chooser.
Fixes chrome canary.
R=reed@android.com
TBR=reed
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
329113003
krajcevski [Wed, 11 Jun 2014 17:38:47 +0000 (10:38 -0700)]
Add support for glCompressedTexSubImage2D
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
329213002
reed [Wed, 11 Jun 2014 17:33:13 +0000 (10:33 -0700)]
hide SkImageDecoder::Chooser
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
331433003
egdaniel [Wed, 11 Jun 2014 17:30:05 +0000 (10:30 -0700)]
Push dash checks into GrContext.
Add class to hold stroke and dash info.
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
311183002
halcanary [Wed, 11 Jun 2014 16:40:23 +0000 (09:40 -0700)]
Use new SkBaseMutex::assertHeld() in DiscardableMemoryPool
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
324413003
tfarina [Wed, 11 Jun 2014 15:58:50 +0000 (08:58 -0700)]
Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename().
BUG=None
TEST=make tests && out/Debug/tests
R=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
321693002
kelvinly [Wed, 11 Jun 2014 15:05:11 +0000 (08:05 -0700)]
Narrowed expectation margins noticeably
BUG=skia:
NOTRY=true
R=bensong@google.com, bsalomon@google.com, jcgregorio@google.com, robertphillips@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
323373002
reed [Wed, 11 Jun 2014 14:26:23 +0000 (07:26 -0700)]
Revert of second try at landing improved blur rect (https://codereview.chromium.org/
325703002/)
Reason for revert:
broke some fast/canvas layout tests
Original issue's description:
> second try at landing improved blur rect
>
> BUG=skia:2095
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/
e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76
R=bsalomon@google.com, reed@chromium.org, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: reed@google.com
Review URL: https://codereview.chromium.org/
322423002
reed [Wed, 11 Jun 2014 14:17:11 +0000 (07:17 -0700)]
remove SK_SUPPORT_LEGACY_DEVICE_CONFIG code
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
327263002
mtklein [Wed, 11 Jun 2014 14:12:09 +0000 (07:12 -0700)]
Code reviews -> reviews@skia.org.
BUG=skia:
R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
328613003
djordje.pesut [Wed, 11 Jun 2014 13:56:10 +0000 (06:56 -0700)]
MIPS: added optimization for functions from SkBlitRow.
gain is ~40%
following function are optimized:
S32_D565_Blend
S32A_D565_Opaque_Dither
S32_D565_Opaque_Dither
S32_D565_Blend_Dither
S32A_D565_Opaque
S32A_D565_Blend
S32_Blend_BlitRow32
R=djsollen@google.com, teodora.petrovic@gmail.com
Author: djordje.pesut@imgtec.com
Review URL: https://codereview.chromium.org/
326913004
egdaniel [Wed, 11 Jun 2014 13:51:51 +0000 (06:51 -0700)]
Move Dashing filterPath to a dashing utils file
From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
576dcdc793a762ec63fbecdbfd5768066b548fe5
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
314623004
sugoi [Wed, 11 Jun 2014 13:31:29 +0000 (06:31 -0700)]
Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D.
The multiplication of 2 signed ints was producing a result larger than what's supported by a single signed int and the memory was accessed out of bounds. Using uint64_t solves the issue.
BUG=378491
R=reed@google.com, rmistry@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
323013005
reed [Wed, 11 Jun 2014 13:09:50 +0000 (06:09 -0700)]
switch to colortype for deepcopy
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
323283002
rmistry [Wed, 11 Jun 2014 13:03:31 +0000 (06:03 -0700)]
Whitespace change to test trybot triggering
BUG=skia:
TBR=
NOTREECHECKS=true
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
325213002
borenet [Wed, 11 Jun 2014 08:52:00 +0000 (01:52 -0700)]
Update SKP version to 20
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
329043002
krajcevski [Wed, 11 Jun 2014 00:25:28 +0000 (17:25 -0700)]
Add an LATC compressor to the A8 masks, and hide it behind an ifdef.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326223002
kelvinly [Tue, 10 Jun 2014 22:32:44 +0000 (15:32 -0700)]
Fix what I just broke
BUG=skia:
NOTRY=true
TBR=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
328883003
kelvinly [Tue, 10 Jun 2014 22:24:39 +0000 (15:24 -0700)]
Fix broken rebaseline code
BUG=skia:
NOTRY=true
R=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
327943003
krajcevski [Tue, 10 Jun 2014 22:06:47 +0000 (15:06 -0700)]
Split caching from allocation in GrClipMaskManager
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
324963005
kelvinly [Tue, 10 Jun 2014 22:05:08 +0000 (15:05 -0700)]
Try 1 at rebaseline
BUG=skia:
R=bensong@google.com, bsalomon@google.com, robertphillips@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
324083007
reed [Tue, 10 Jun 2014 21:56:29 +0000 (14:56 -0700)]
fix when DEVICE_CONFIG is still defined
BUG=skia:
R=djsollen@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
329553005
krajcevski [Tue, 10 Jun 2014 21:52:28 +0000 (14:52 -0700)]
Add texture compression utility
R=robertphillips@google.com, egdaniel@google.com, halcanary@google.com, scroggo@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
325733004
dandov [Tue, 10 Jun 2014 21:38:28 +0000 (14:38 -0700)]
SkShader::asNewEffect Refactoring
The new signature is:
bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;
It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.
BUG=skia:2646
R=jvanverth@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
318923005
krajcevski [Tue, 10 Jun 2014 21:34:00 +0000 (14:34 -0700)]
Add Daniel and Pavel to committers list
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
316403003