reed [Fri, 19 Aug 2016 00:15:25 +0000 (17:15 -0700)]
quick check to not use AutoDrawLooper
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248373004
Review-Url: https://codereview.chromium.org/
2248373004
reed [Thu, 18 Aug 2016 23:13:50 +0000 (16:13 -0700)]
Revert of Return color shader instead of 2-color gradient when color count is 1 (patchset #3 id:40001 of https://codereview.chromium.org/
2259823005/ )
Reason for revert:
breaks 2-pt-conical, which can sometimes not draw anything
Original issue's description:
> Return color shader instead of 2-color gradient when color count is 1
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259823005
>
> Committed: https://skia.googlesource.com/skia/+/
da082a5767d7edfd3abe74fc683392422565a606
TBR=fmenozzi@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2257993002
mtklein [Thu, 18 Aug 2016 22:59:08 +0000 (15:59 -0700)]
Detect CRC32 instructions on ARMv8.
I have successfully detected CRC32 instruction support on my Nexus 5x.
Use of these instructions to follow... I am not yet sure which compilers if any will give me instrinsics or let me write them in asm.
defined(__ARM_FEATURE_CRC32) should cover users like Android Framework who build with the best settings possible. cpu-features.h covers use cases like Clank and our bots.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259133002
Review-Url: https://codereview.chromium.org/
2259133002
msarett [Thu, 18 Aug 2016 22:46:03 +0000 (15:46 -0700)]
Batched implementation of drawLattice() for GPU
Bechmarks (Nexus 6P):
Src=100x100, Dst=250x250, NumRects=9
Android 77.7us
Skia (without patch) 57.2us
Skia (with patch) 30.9us
Src=100x100, Dst=500x500, NumRects=9
Android 77.0us
Skia (without patch) 56.9us
Skia (with patch) 31.8us
Src=100x100, Dst=1000x1000, NumRects=9
Android 180us
Skia (without patch) 96.8us
Skia (with patch) 70.5us
Src=100x100, Dst=250x250, NumRects=15
Android 208us
Skia (without patch) 155us
Skia (with patch) 38.2us
Src=100x100, Dst=500x500, NumRects=15
Android 207us
Skia (without patch) 152us
Skia (with patch) 38.4us
Src=100x100, Dst=1000x1000, NumRects=15
Android 233us
Skia (without patch) 156us
Skia (with patch) 99.9us
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2255963002
Committed: https://skia.googlesource.com/skia/+/
93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d
Review-Url: https://codereview.chromium.org/
2255963002
mtklein [Thu, 18 Aug 2016 22:42:32 +0000 (15:42 -0700)]
Fast path translate() in SkCanvas and SkLiteDL.
This adds didTranslate() so that SkLiteDL (and other canvas recorders)
can record the translate rather than the full concat.
It also adds a case to SkMatrix::preTranslate() to fast path
translate x translate -> translate (i.e. +=).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2255283002
Review-Url: https://codereview.chromium.org/
2255283002
egdaniel [Thu, 18 Aug 2016 22:21:55 +0000 (15:21 -0700)]
Relax check for gpu use of static src-over XP
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259113002
Review-Url: https://codereview.chromium.org/
2259113002
reed [Thu, 18 Aug 2016 22:01:10 +0000 (15:01 -0700)]
add simplerect gm
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2257263002
TBR=bsalomon
NOTRY=True
Review-Url: https://codereview.chromium.org/
2257263002
fmenozzi [Thu, 18 Aug 2016 21:50:56 +0000 (14:50 -0700)]
Return color shader instead of 2-color gradient when color count is 1
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259823005
Review-Url: https://codereview.chromium.org/
2259823005
bungeman [Thu, 18 Aug 2016 21:36:02 +0000 (14:36 -0700)]
Use CSS3 style matching on Android.
Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2256843003
Review-Url: https://codereview.chromium.org/
2256843003
msarett [Thu, 18 Aug 2016 21:29:22 +0000 (14:29 -0700)]
Revert of Batched implementation of drawLattice() for GPU (patchset #7 id:180001 of https://codereview.chromium.org/
2255963002/ )
Reason for revert:
Things drawing weird.
Original issue's description:
> Batched implementation of drawLattice() for GPU
>
> Bechmarks (Nexus 6P):
>
> Src=100x100, Dst=250x250, NumRects=9
> Android 77.7us
> Skia (without patch) 57.2us
> Skia (with patch) 34.7us
>
> Src=100x100, Dst=500x500, NumRects=9
> Android 77.0us
> Skia (without patch) 56.9us
> Skia (with patch) 44.5us
>
> Src=100x100, Dst=1000x1000, NumRects=9
> Android 180us
> Skia (without patch) 96.8us
> Skia (with patch) 70.5us
>
> Src=100x100, Dst=250x250, NumRects=15
> Android 208us
> Skia (without patch) 155us
> Skia (with patch) 55.9us
>
> Src=100x100, Dst=500x500, NumRects=15
> Android 207us
> Skia (without patch) 152us
> Skia (with patch) 63.0us
>
> Src=100x100, Dst=1000x1000, NumRects=15
> Android 233us
> Skia (without patch) 156us
> Skia (with patch) 99.9us
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2255963002
>
> Committed: https://skia.googlesource.com/skia/+/
93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d
TBR=bsalomon@google.com,reed@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2255683004
halcanary [Thu, 18 Aug 2016 21:22:52 +0000 (14:22 -0700)]
SkPDF: in-place font subsetting
Motivation: gross code simplification, also no bitset lookups at draw time.
SkPDFFont owns its glyph useage bitset.
SkPDFSubstituteMap goes away.
SkPDFObject interface is simplified.
SkPDFDocument tracks font usage (as hash set), not glyph usage.
SkPDFFont gets a simpler constructor.
SkPDFFont has first and last glyph set in constructor, not adjusted later.
SkPDFFont implementations are simplified.
SkPDFGlyphSet is replaced with simple SkBitSet.
SkPDFFont sizes its SkBitSets based on glyph count.
SkPDFGlyphSetMap goes away.
SkBitSet is now non-copyable.
SkBitSet now how utility methods to match old SkPDFGlyphSet.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253283004
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot
Review-Url: https://codereview.chromium.org/
2253283004
msarett [Thu, 18 Aug 2016 21:03:30 +0000 (14:03 -0700)]
Fix initialization bug for fConservativeIsScaleTranslate
Also don't mark it as conservative, we expect it to be correct all
the time.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2261573002
Review-Url: https://codereview.chromium.org/
2261573002
robertphillips [Thu, 18 Aug 2016 21:01:14 +0000 (14:01 -0700)]
Delay creation of cpu-side buffer memory until actually needed
IIUC what is going on, this won't really do anything bad but will defer allocation of the cpu-side buffer until it is actually needed.
BUG=635015
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248283007
Review-Url: https://codereview.chromium.org/
2248283007
msarett [Thu, 18 Aug 2016 20:11:48 +0000 (13:11 -0700)]
Batched implementation of drawLattice() for GPU
Bechmarks (Nexus 6P):
Src=100x100, Dst=250x250, NumRects=9
Android 77.7us
Skia (without patch) 57.2us
Skia (with patch) 34.7us
Src=100x100, Dst=500x500, NumRects=9
Android 77.0us
Skia (without patch) 56.9us
Skia (with patch) 44.5us
Src=100x100, Dst=1000x1000, NumRects=9
Android 180us
Skia (without patch) 96.8us
Skia (with patch) 70.5us
Src=100x100, Dst=250x250, NumRects=15
Android 208us
Skia (without patch) 155us
Skia (with patch) 55.9us
Src=100x100, Dst=500x500, NumRects=15
Android 207us
Skia (without patch) 152us
Skia (with patch) 63.0us
Src=100x100, Dst=1000x1000, NumRects=15
Android 233us
Skia (without patch) 156us
Skia (with patch) 99.9us
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2255963002
Review-Url: https://codereview.chromium.org/
2255963002
reed [Thu, 18 Aug 2016 19:45:34 +0000 (12:45 -0700)]
make LayerIter private, and remove skipClip option
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2257203002
Review-Url: https://codereview.chromium.org/
2257203002
mtklein [Thu, 18 Aug 2016 19:04:13 +0000 (12:04 -0700)]
GN: make libjpeg_turbo target Chrome-compatible
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2257903002
Review-Url: https://codereview.chromium.org/
2257903002
senorblanco [Thu, 18 Aug 2016 17:20:47 +0000 (10:20 -0700)]
Tessellator: better fix for reused-edges issue.
The GrTessellator fix for doubly-added edges in
https://codereview.chromium.org/
2259493002/ could leave
a MonotonePoly with zero edges. This is a problem for
Poly::addEdge(), which assumes that MonotonePolys always have
at least one edge. The fix is to move the check and early-out up to
Poly::addEdge(). This should also tighten up the vertex count.
(Unfortunately, the only repro I have for this issue is very
convoluted, and requires non-landed code.)
BUG=skia:5636
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251643008
Review-Url: https://codereview.chromium.org/
2251643008
halcanary [Thu, 18 Aug 2016 16:52:48 +0000 (09:52 -0700)]
SkPDF: cache metrics once.
Motivation: drawText can look up unicode mapping at draw time to see
if ActualText should be used after crrev.com/
2084533004 lands.
For each SkTypeface, only call getAdvancedTypefaceMetrics() once per
document. Cache the result in the SkPDFCanon, indexed by SkFontID.
Also cache PDF FontDescriptors in the canon, also indexed by SkFontID
(Type1 fonts only).
Simplify PDF font lookup, map SkFontID+SkGlyphID into a uint64_t. Map
that uint64_t to SkPDFFonts. Remove SkPDFCanon::findFont(),
SkPDFCanon::addFont(), SkPDFFont::IsMatch(), and enum SkPDFFont::Match.
SkPDFFont no longer holds on to ref of SkAdvancedTypefaceMetrics.
Instead, SkPDFFont::GetFontResource() and SkPDFFont::getFontSubset()
get metrics from canon.
SkPDFFont multybite bool is now a function of type.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253993002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot
Review-Url: https://codereview.chromium.org/
2253993002
reed [Thu, 18 Aug 2016 16:30:44 +0000 (09:30 -0700)]
remove disable aa/dither flags from Props -- never used
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2257643003
TBR=bsalomon
Review-Url: https://codereview.chromium.org/
2257643003
dvonbeck [Thu, 18 Aug 2016 15:55:48 +0000 (08:55 -0700)]
Interactive Bevel Sample App
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246243002
Review-Url: https://codereview.chromium.org/
2246243002
bsalomon [Thu, 18 Aug 2016 15:32:27 +0000 (08:32 -0700)]
Don't emit dead code in circle shader when not using distance vectors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2254103004
Review-Url: https://codereview.chromium.org/
2254103004
robertphillips [Thu, 18 Aug 2016 14:11:13 +0000 (07:11 -0700)]
Rename WorseCaseSize to WorstCasSize
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259863002
Review-Url: https://codereview.chromium.org/
2259863002
brianosman [Thu, 18 Aug 2016 13:43:03 +0000 (06:43 -0700)]
Add alpha type to texture producer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250403003
Review-Url: https://codereview.chromium.org/
2250403003
anmittal [Thu, 18 Aug 2016 11:36:25 +0000 (04:36 -0700)]
Add executable bit and shebang to python files
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253373002
Review-Url: https://codereview.chromium.org/
2253373002
robertphillips [Wed, 17 Aug 2016 23:29:39 +0000 (16:29 -0700)]
Revert of Reduce window rectangles cap to 8 (patchset #1 id:1 of https://codereview.chromium.org/
2254013002/ )
Reason for revert:
Breaking Ubuntu
Original issue's description:
> Reduce window rectangles cap to 8
>
> Lowers the cap to 8 and adds a warning message if this value is ever
> exceeded. The largest (only) implementation currently supports 8, so
> there isn't yet reason to go higher.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2254013002
>
> Committed: https://skia.googlesource.com/skia/+/
52d721580ee22525c285e2d13cf3975a7a1b2843
TBR=mjk@nvidia.com,bsalomon@google.com,csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2253293003
robertphillips [Wed, 17 Aug 2016 23:28:28 +0000 (16:28 -0700)]
Revert of SkPDF: cache metrics once. (patchset #4 id:60001 of https://codereview.chromium.org/
2253993002/ )
Reason for revert:
because
Original issue's description:
> SkPDF: cache metrics once.
>
> Motivation: drawText can look up unicode mapping at draw time to see
> if ActualText should be used after crrev.com/
2084533004 lands.
>
> For each SkTypeface, only call getAdvancedTypefaceMetrics() once per
> document. Cache the result in the SkPDFCanon, indexed by SkFontID.
> Also cache PDF FontDescriptors in the canon, also indexed by SkFontID
> (Type1 fonts only).
>
> Simplify PDF font lookup, map SkFontID+SkGlyphID into a uint64_t. Map
> that uint64_t to SkPDFFonts. Remove SkPDFCanon::findFont(),
> SkPDFCanon::addFont(), SkPDFFont::IsMatch(), and enum SkPDFFont::Match.
>
> SkPDFFont no longer holds on to ref of SkAdvancedTypefaceMetrics.
> Instead, SkPDFFont::GetFontResource() and SkPDFFont::getFontSubset()
> get metrics from canon.
>
> SkPDFFont multybite bool is now a function of type.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253993002
>
> Committed: https://skia.googlesource.com/skia/+/
0a61270f4ba85d10659fb63a86817b435ec04c94
TBR=bungeman@google.com,halcanary@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2251813006
fmalita [Wed, 17 Aug 2016 22:08:48 +0000 (15:08 -0700)]
[SVGDom] Fix <ellipse> positioning
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253283002
Review-Url: https://codereview.chromium.org/
2253283002
senorblanco [Wed, 17 Aug 2016 21:56:22 +0000 (14:56 -0700)]
Fix assert caused by floating point error in tessellating path renderer.
In rare cases, floating point error causes the tesselator to add the
same Vertex to more than one Poly on the same side. This was not a big
problem when we were allocating new vertices when constructing Polys,
but after https://codereview.chromium.org/
2029243002 it causes more serious
issues, since each Edge can only belong to two Polys, and violating this
condition messes up the linked list of Edges used for left & right Polys
and the associated estimated vertex count.
The fix is to simply let the first Poly win, and skip that vertex for
subsequent Polys. Since this only occurs in cases where vertices are very
close to each other, it should have little visual effect.
This is also exercised by Nebraska-StateSeal.svg.
BUG=skia:5636
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259493002
Review-Url: https://codereview.chromium.org/
2259493002
fmalita [Wed, 17 Aug 2016 21:51:03 +0000 (14:51 -0700)]
[SVGDom] Add support for assorted absolute units
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2259473002
Review-Url: https://codereview.chromium.org/
2259473002
halcanary [Wed, 17 Aug 2016 21:21:42 +0000 (14:21 -0700)]
SkPDF: cache metrics once.
Motivation: drawText can look up unicode mapping at draw time to see
if ActualText should be used after crrev.com/
2084533004 lands.
For each SkTypeface, only call getAdvancedTypefaceMetrics() once per
document. Cache the result in the SkPDFCanon, indexed by SkFontID.
Also cache PDF FontDescriptors in the canon, also indexed by SkFontID
(Type1 fonts only).
Simplify PDF font lookup, map SkFontID+SkGlyphID into a uint64_t. Map
that uint64_t to SkPDFFonts. Remove SkPDFCanon::findFont(),
SkPDFCanon::addFont(), SkPDFFont::IsMatch(), and enum SkPDFFont::Match.
SkPDFFont no longer holds on to ref of SkAdvancedTypefaceMetrics.
Instead, SkPDFFont::GetFontResource() and SkPDFFont::getFontSubset()
get metrics from canon.
SkPDFFont multybite bool is now a function of type.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253993002
Review-Url: https://codereview.chromium.org/
2253993002
brianosman [Wed, 17 Aug 2016 21:01:05 +0000 (14:01 -0700)]
Add alphaType() to SkImage
Keep isOpaque as a convenience method -- many places really only need to
know that for optimization purposes (SrcOver -> Src, etc...).
In all the places where we pull data back out or convert to another
object and need to supply an SkImageInfo, we can avoid losing information
about premulness.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250663002
Review-Url: https://codereview.chromium.org/
2250663002
anmittal [Wed, 17 Aug 2016 20:57:26 +0000 (13:57 -0700)]
Fix BUILD.gn for arch other then x86 and x64
opts_gypi should only be defined for x86 and x64 else we get unused
variable error
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248323002
Review-Url: https://codereview.chromium.org/
2248323002
bsalomon [Wed, 17 Aug 2016 20:56:57 +0000 (13:56 -0700)]
Fix computation of clipped src rect when tiling bitmaps in SkGpuDevice
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2252913004
Review-Url: https://codereview.chromium.org/
2252913004
csmartdalton [Wed, 17 Aug 2016 20:52:15 +0000 (13:52 -0700)]
Reduce window rectangles cap to 8
Lowers the cap to 8 and adds a warning message if this value is ever
exceeded. The largest (only) implementation currently supports 8, so
there isn't yet reason to go higher.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2254013002
Review-Url: https://codereview.chromium.org/
2254013002
herb [Wed, 17 Aug 2016 20:51:54 +0000 (13:51 -0700)]
Eagerly update the unichar to glyphID mapping.
In addition, some small cleanups.
BUG=chromium:635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249063005
Review-Url: https://codereview.chromium.org/
2249063005
reed [Wed, 17 Aug 2016 20:24:05 +0000 (13:24 -0700)]
fix no-gpu build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253073003
TBR=robertphilips
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/
2253073003
egdaniel [Wed, 17 Aug 2016 19:55:30 +0000 (12:55 -0700)]
Fix fb variable name in GLSL
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2252143002
NOTREECHECKS=True
Review-Url: https://codereview.chromium.org/
2252143002
mtklein [Wed, 17 Aug 2016 18:39:48 +0000 (11:39 -0700)]
SkLiteDL: a little spring cleaning
- kill off optimizeFor() now that we know it's broken and have a better way;
- simplify makeThreadsafe() a bit: we're not calling it anyway.
This sort of earns me back some crazy code currency,
which I am going to try to spend making reset() faster.
If anything, this appears to make makeThreadsafe() _faster_.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2254913002
Review-Url: https://codereview.chromium.org/
2254913002
bsalomon [Wed, 17 Aug 2016 18:33:39 +0000 (11:33 -0700)]
Simplify adding attributes to GrGeometryProcessor
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248323003
Review-Url: https://codereview.chromium.org/
2248323003
fmalita [Wed, 17 Aug 2016 18:33:29 +0000 (11:33 -0700)]
Fix SampleAndroidShadows warnings
R=jvanverth@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2255863002
NOTRY=true
Review-Url: https://codereview.chromium.org/
2255863002
reed [Wed, 17 Aug 2016 18:12:33 +0000 (11:12 -0700)]
pin as texture api
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241353002
Review-Url: https://codereview.chromium.org/
2241353002
bungeman [Wed, 17 Aug 2016 17:59:30 +0000 (10:59 -0700)]
Move FamilyClass and Panose enums to enum class.
The IBMFamilyClass and Panose structures are obvious candidates
for simplification now that it is no longer necessary to nest
enums inside structs to avoid name clashes.
Review-Url: https://codereview.chromium.org/
2253543004
egdaniel [Wed, 17 Aug 2016 17:59:00 +0000 (10:59 -0700)]
Fix various issues with framebuffer fetch
This CL does two things. First it fixes a bug of ours where when using
a custom fbFetch variable (es 3.0 and higher), we sometimes overwrite
the out color and then attempt to use it as the dst color later. This is
fixed here by using an intermediate variable.
Secondly I've added a workaround to an andreno fbFetch where reading from
the outColor always returns the original dstColor even if we've overwritten
the value.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248403003
Review-Url: https://codereview.chromium.org/
2248403003
bsalomon [Wed, 17 Aug 2016 17:30:17 +0000 (10:30 -0700)]
Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()
Instead take a local matrix parameter.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250563004
Review-Url: https://codereview.chromium.org/
2250563004
mtklein [Wed, 17 Aug 2016 17:20:27 +0000 (10:20 -0700)]
SkLiteDL: inline empty()
1.85% 1.85% RenderThread 6458 6475 /system/lib64/libskia.so SkLiteDL::empty() const
:/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2254823002
Review-Url: https://codereview.chromium.org/
2254823002
jvanverth [Wed, 17 Aug 2016 17:06:18 +0000 (10:06 -0700)]
Add alternative spot shadow to Android shadow sample
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246273003
Review-Url: https://codereview.chromium.org/
2256713002
csmartdalton [Wed, 17 Aug 2016 17:00:21 +0000 (10:00 -0700)]
Implement difference clip rects with window rectangles
Plumbs the pipeline for window rectangles and uses them for a very
basic implementation of difference clip rects. This puts a common
Blink pattern on fast path, but we will still eventually need to make
more comprehensive use of window rectangles during clipping.
GTX 960 perf result:
gpu glinst4 glinst16
desk_jsfiddlebigcar.skp 0.254 -> 0.177 [70%] 0.279 -> 0.197 [71%] 0.577 -> 0.196 [34%]
keymobi_sfgate_com_.skp 0.697 -> 0.513 [74%] 0.766 -> 0.451 [59%] 0.769 -> 0.597 [78%]
keymobi_blogger.skp 0.406 -> 0.314 [77%] 0.436 -> 0.292 [67%] 0.696 -> 0.319 [46%]
desk_pokemonwiki.skp 0.121 -> 0.098 [81%] 0.13 -> 0.105 [81%] 0.216 -> 0.097 [45%]
desk_wikipedia.skp 0.121 -> 0.098 [81%] 0.13 -> 0.104 [80%] 0.199 -> 0.104 [52%]
keymobi_androidpolice_co... 0.443 -> 0.382 [86%] 0.447 -> 0.398 [89%] 0.444 -> 0.396 [89%]
keymobi_booking_com_sear... 1 .15 -> 1.03 [90%] 1.17 -> 1.06 [91%] 1.17 -> 1.05 [90%]
keymobi_theverge_com.skp 0.417 -> 0.396 [95%] 0.426 -> 0.405 [95%] 0.429 -> 0.4 [93%]
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251573002
Review-Url: https://codereview.chromium.org/
2251573002
csmartdalton [Wed, 17 Aug 2016 16:39:38 +0000 (09:39 -0700)]
Make GrReducedClip's gen ID only apply to the element list
Renames fGenID to fElementsGenID and designates this value as
undefined when when the element list is empty.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2244223004
Review-Url: https://codereview.chromium.org/
2244223004
robertphillips [Wed, 17 Aug 2016 16:28:59 +0000 (09:28 -0700)]
Kick the can down the road a bit w.r.t. fuzzer complaint
BUG=635787
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2247033006
Review-Url: https://codereview.chromium.org/
2247033006
bsalomon [Wed, 17 Aug 2016 16:02:09 +0000 (09:02 -0700)]
Fix tile bitmap code in SkGpuDevice to compute correct local coords.
This fixes a bug when using an alpha bitmap/image with a SkShader where the SkShader's GrFragmentProcessor would receive incorrect coordinates.
BUG=skia:5643
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249163004
Review-Url: https://codereview.chromium.org/
2249163004
bsalomon [Wed, 17 Aug 2016 16:00:24 +0000 (09:00 -0700)]
Minor cleanup of GP classes in GrOvalRenderer
Move GLSL nested classes to private and remove unnecessary public getters.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2253903002
Review-Url: https://codereview.chromium.org/
2253903002
msarett [Wed, 17 Aug 2016 15:54:08 +0000 (08:54 -0700)]
Modify SkPngCodec to recognize 565 images from the sBIT chunk
Conveniently, SkPngImageEncoder already writes the sBIT chunk
appropriately.
BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2212563003
Review-Url: https://codereview.chromium.org/
2212563003
fmalita [Wed, 17 Aug 2016 15:38:15 +0000 (08:38 -0700)]
[SVGDom] Add <line> support
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2244223005
Review-Url: https://codereview.chromium.org/
2244223005
robertphillips [Wed, 17 Aug 2016 15:02:51 +0000 (08:02 -0700)]
Cast for fuzzer complaint
Given the cast in the following else block, this isn't the first time we've encountered this.
BUG=637187
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2258463002
Review-Url: https://codereview.chromium.org/
2258463002
jvanverth [Wed, 17 Aug 2016 14:59:41 +0000 (07:59 -0700)]
Add alternative ambient shadow method to Android shadow sample
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249973003
Review-Url: https://codereview.chromium.org/
2249973003
halcanary [Wed, 17 Aug 2016 14:57:27 +0000 (07:57 -0700)]
SkPDF: pull out SkPDFMakeCIDGlyphWidthsArray.cpp
Extract from inside SkPDFFont.cpp
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251803002
Review-Url: https://codereview.chromium.org/
2251803002
rmistry [Wed, 17 Aug 2016 14:51:57 +0000 (07:51 -0700)]
Add gerrit config lines to cq.cfg
Needed for the CQ to see Gerrit. Eg:
https://cs.chromium.org/chromium/tools/depot_tools/infra/config/cq.cfg?q=cq.cfg&sq=package:chromium&dr=C&l=9
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251643005
Review-Url: https://codereview.chromium.org/
2251643005
reed [Wed, 17 Aug 2016 14:37:57 +0000 (07:37 -0700)]
move private test for sect_with_horizontal into unittests
BUG=638575
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250353004
Review-Url: https://codereview.chromium.org/
2250353004
egdaniel [Wed, 17 Aug 2016 13:26:16 +0000 (06:26 -0700)]
Add mssa configs for vulkan, and simple bug fix
BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251473002
Review-Url: https://codereview.chromium.org/
2251473002
caryclark [Wed, 17 Aug 2016 13:14:06 +0000 (06:14 -0700)]
fix fuzz
TBR=reed@google.com
BUG=638496
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250413002
Review-Url: https://codereview.chromium.org/
2250413002
mtklein [Wed, 17 Aug 2016 01:28:43 +0000 (18:28 -0700)]
GN: make current_cpu work
Then we can use it to remind ourselves that SSE and AVX are x86-only.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2247413003
Review-Url: https://codereview.chromium.org/
2247413003
mtklein [Wed, 17 Aug 2016 00:18:27 +0000 (17:18 -0700)]
SkLiteDL: thread the original canvas matrix through for SetMatrix::Draw().
The SkLiteDL is recorded in some identity space (imagine, SkMatrix::I()),
but played back in a different one (here named SkMatrix original). Any
calls to setMatrix() need to be made relative to this new space.
All other ops already operate in relative coordinates.
This should let us not fiddle with setMatrix().
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2247353003
Review-Url: https://codereview.chromium.org/
2247353003
robertphillips [Tue, 16 Aug 2016 22:49:20 +0000 (15:49 -0700)]
Revert of Start using vertex attributes for nine-patch blurred rrect draws (patchset #8 id:140001 of https://codereview.chromium.org/
2245653002/ )
Reason for revert:
??
Original issue's description:
> Start using vertex attributes for nine-patch blurred rrect draws
>
> Calved off:
> https://codereview.chromium.org/
2243133002/ (Pull handling of blurred circles out of GrRRectBlurEffect::Make)
> https://codereview.chromium.org/
2249463002/ (Update blurred rrect mask filter creation method to also handle caching)
> https://codereview.chromium.org/
2248533002/ (Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws)
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245653002
>
> Committed: https://skia.googlesource.com/skia/+/
087905a730241939da320092543c19dc06d5a7b4
TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2250543004
fmalita [Tue, 16 Aug 2016 22:38:51 +0000 (15:38 -0700)]
[SVGDom] Add <circle>, <ellipse> support
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249033003
Review-Url: https://codereview.chromium.org/
2249033003
msarett [Tue, 16 Aug 2016 22:11:24 +0000 (15:11 -0700)]
Add test for platform encoders, turn off platform encoders by default
Clients that like WIC and CG can still use them. And we can be
confident about that, since we now test WIC and CG.
Let Skia always use our own encoders by default, so we can do cool,
custom things on all platforms.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250683003
Review-Url: https://codereview.chromium.org/
2250683003
hstern [Tue, 16 Aug 2016 22:10:34 +0000 (15:10 -0700)]
Fix bug in cubic derivative coefficient with missing parens
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2242603002
Review-Url: https://codereview.chromium.org/
2242603002
robertphillips [Tue, 16 Aug 2016 21:50:18 +0000 (14:50 -0700)]
Start using vertex attributes for nine-patch blurred rrect draws
Calved off:
https://codereview.chromium.org/
2243133002/ (Pull handling of blurred circles out of GrRRectBlurEffect::Make)
https://codereview.chromium.org/
2249463002/ (Update blurred rrect mask filter creation method to also handle caching)
https://codereview.chromium.org/
2248533002/ (Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245653002
Review-Url: https://codereview.chromium.org/
2245653002
fmalita [Tue, 16 Aug 2016 21:23:29 +0000 (14:23 -0700)]
Only test SVG DM sources against direct raster/gpu sinks.
There isn't much value in testing against indirect or vector sinks.
R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2252443002
Review-Url: https://codereview.chromium.org/
2252443002
bungeman [Tue, 16 Aug 2016 19:27:49 +0000 (12:27 -0700)]
Remove SkPreprocessorSeq.h and SkTypedEnum.h.
These were added to allow the use of typed enums before typed enums were
available on all platforms. Now that typed enums are available, just use
them directly.
Review-Url: https://codereview.chromium.org/
2254513002
halcanary [Tue, 16 Aug 2016 18:54:57 +0000 (11:54 -0700)]
SkPDF: Font names need escaping
NOTRY=true
Review-Url: https://codereview.chromium.org/
2250763002
halcanary [Tue, 16 Aug 2016 17:29:38 +0000 (10:29 -0700)]
SkPDF: eliminate SkPDFCIDfont class
get_glyph_widths() and set_glyph_widths() combined.
set_glyph_widths() now takes a SkPDFGlyphSet*.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2244173005
Review-Url: https://codereview.chromium.org/
2244173005
caryclark [Tue, 16 Aug 2016 17:25:29 +0000 (10:25 -0700)]
fix fuzz bug
TBR=reed@google.com
BUG=637968, 638002
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2250573003
Review-Url: https://codereview.chromium.org/
2250573003
halcanary [Tue, 16 Aug 2016 16:36:23 +0000 (09:36 -0700)]
SkPDF: SkPDFFont class changes
SkPDFFont:
* inline some one-line methdods.
- SkPDFFont::typeface()
- SkPDFFont::fontInfo()
- SkPDFFont::firstGlyphID()
- SkPDFFont::lastGlyphID()
- SkPDFFont::getFontDescriptor()
* de-virtualize some methods:
- SkPDFFont::getType()
- SkPDFFont::multiByteGlyphs()
* Constructor takes more arguments:
fontType, multiByteGlyphs
* re-order fields (pointers before shorts)
* use sk_sp<T> more, T* less
SkAdvancedTypefaceMetrics:
* SkAdvancedTypefaceMetrics::fFont now a uint8_t
* other enumes are sized.
* SkAdvancedTypefaceMetrics::fStyle now big enough.
* remove use of SkTBitOr, replaced with fancy templates
No public API changes.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246903002
Review-Url: https://codereview.chromium.org/
2246903002
mtklein [Tue, 16 Aug 2016 16:36:18 +0000 (09:36 -0700)]
SkLiteDL: remove freelisting, add reset() and SKLITEDL_PAGE knob.
We think Android can cache these better than a global freelist allows.
This removes the freelisting but adds reset() to allow reuse.
I took the opportunity to abstract 4096 as a define SKLITEDL_PAGE.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248693004
Review-Url: https://codereview.chromium.org/
2248693004
mtklein [Tue, 16 Aug 2016 16:31:16 +0000 (09:31 -0700)]
GN: add extra_cflags et al.
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.
For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.
I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'. By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.
Another good use case is a hypothetical Actually-Shippable-Release mode. Our
Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely. To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there
too, '-fomit-frame-pointer', etc.
There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest. This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241263003
Review-Url: https://codereview.chromium.org/
2241263003
msarett [Tue, 16 Aug 2016 16:31:08 +0000 (09:31 -0700)]
Add onDrawBitmapLattice(), avoid unnecessary bitmap->image copy
out/Release/nanobench --match Lattice --config gpu --ms 3000
3.42ms -> 17.2us
For reference, a loop over drawBitmapRects (which is what
Android currently does) is about 13us.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2205273003
Review-Url: https://codereview.chromium.org/
2205273003
robertphillips [Tue, 16 Aug 2016 16:30:03 +0000 (09:30 -0700)]
Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws
This is split out of: https://codereview.chromium.org/
2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248533002
Review-Url: https://codereview.chromium.org/
2248533002
mtklein [Tue, 16 Aug 2016 16:29:57 +0000 (09:29 -0700)]
32-bit fast hash, tidy up murmur3 a bit
Nothing too surprising in the new 32-bit x86 hash. It's about half speed of the 64-bit variant, just as you'd expect.
Using unaligned_load like the others makes the may_alias parts of murmur3 moot. I've updated some of the terms in the murmur hash to read consistently with the others.
The existing hashes are the same speed and produce the same hashes. In case this is not obvious, all three hash functions produce different hashes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2251773002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2251773002
bsalomon [Tue, 16 Aug 2016 16:24:57 +0000 (09:24 -0700)]
Improvements for circluar blurs in GPU backend.
Use half plane approximation for small blur of a large circle. This reduces
the number of textures used and also avoids numerical issues with large
circle radii.
Make GrCircleGradientEffect use fixed sized textures.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2242973002
Review-Url: https://codereview.chromium.org/
2242973002
fmenozzi [Tue, 16 Aug 2016 16:24:52 +0000 (09:24 -0700)]
Reducing number of calls to GLSL mix() from two to one reduces frame render time by 21%
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2247113003
Review-Url: https://codereview.chromium.org/
2247113003
brianosman [Tue, 16 Aug 2016 14:09:47 +0000 (07:09 -0700)]
Remove isOpaque from SkSpecialImage, just use alpha type
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246193002
Review-Url: https://codereview.chromium.org/
2246193002
fmalita [Tue, 16 Aug 2016 14:08:48 +0000 (07:08 -0700)]
Disable Nebraska-StateSeal.svg on Win8 bots
Temporary suppression, pending bug fix.
BUG=skia:5636
R=robertphillips@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249763002
Review-Url: https://codereview.chromium.org/
2249763002
reed [Tue, 16 Aug 2016 13:39:39 +0000 (06:39 -0700)]
simplify GrTextureAdjuster given there is only one subclass
Intended as a pre-cl for https://codereview.chromium.org/
2241353002#
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2242373002
Review-Url: https://codereview.chromium.org/
2242373002
vjiaoblack [Tue, 16 Aug 2016 12:38:45 +0000 (05:38 -0700)]
Moved "drawShadowedPicture" call outside of if cases in onDrawContent.
Bug description:
If you updated the view without changing frames (such as moving around the
cursor with 'z' (pixel zoom) on) the window would turn gray.
This was because I left the drawShadowedPicture call inside of the "if-updated"
case inside of SampleShadowing's onDrawContent handler.
If nothing changed and onDrawContent is called, we still need to update the
given canvas's fLights (there is no guarantee of whether the canvas (or its
fLights) has been updated or not), and then draw the shadowed picture.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245923002
Review-Url: https://codereview.chromium.org/
2245923002
msarett [Tue, 16 Aug 2016 11:54:19 +0000 (04:54 -0700)]
Revert of Add regression test (patchset #2 id:20001 of https://codereview.chromium.org/
2243143002/ )
Reason for revert:
Nexus 9 and Nexus Player failures.
Original issue's description:
> Add regression test
>
> Original bug fix was in:
> https://codereview.chromium.org/
2230163002
>
> BUG:636268
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2243143002
>
> Committed: https://skia.googlesource.com/skia/+/
bcae9d3d15d34a59d279c34e187e6101975500c0
TBR=reed@google.com,gogil@stealien.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2243403003
msarett [Tue, 16 Aug 2016 01:52:17 +0000 (18:52 -0700)]
Fix WIC encoder to support kJPEG_Type
(1) Add support for kJPEG to WIC
(2) Add encoding test.
(3) Turn on WIC jpeg encoder on Windows and CG jpeg
encoder on Mac.
A follow-up may make Skia's encoders the default on all
platforms. But, in order to do that, I think we need
to write better encoding unit tests for CG and WIC.
BUG=skia:3969
BUG=skia:5632
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245453002
Committed: https://skia.googlesource.com/skia/+/
b3a7ef1fc0adc24859d2498aee54d3ec2cbcac3a
Review-Url: https://codereview.chromium.org/
2245453002
halcanary [Tue, 16 Aug 2016 01:40:07 +0000 (18:40 -0700)]
SkPDF: unify drawText and drawPosText
Motivation: a later CL will add drawTextBlob() (after
https://crrev.com/
2084533004 lands). This CL is designed
with that change in mind. Also fewer redundant lines of
code.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241683005
Committed: https://skia.googlesource.com/skia/+/
6059dc32fe36358175cb81541c91e74a2a7e771a
Review-Url: https://codereview.chromium.org/
2241683005
robertphillips [Mon, 15 Aug 2016 22:36:58 +0000 (15:36 -0700)]
Revert of SkPDF: unify drawText and drawPosText (patchset #2 id:40001 of https://codereview.chromium.org/
2241683005/ )
Reason for revert:
I believe this is breaking the Google3 roll
Original issue's description:
> SkPDF: unify drawText and drawPosText
>
> Motivation: a later CL will add drawTextBlob() (after
> https://crrev.com/
2084533004 lands). This CL is designed
> with that change in mind. Also fewer redundant lines of
> code.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241683005
>
> Committed: https://skia.googlesource.com/skia/+/
6059dc32fe36358175cb81541c91e74a2a7e771a
TBR=bungeman@google.com,halcanary@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2248923002
hstern [Mon, 15 Aug 2016 22:26:31 +0000 (15:26 -0700)]
Defined SkDEBUGFAILF on Release builds
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2244253003
Review-Url: https://codereview.chromium.org/
2244253003
bsalomon [Mon, 15 Aug 2016 21:49:10 +0000 (14:49 -0700)]
Attempt to throw away rrect clips of rrects.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241273003
Review-Url: https://codereview.chromium.org/
2241273003
brianosman [Mon, 15 Aug 2016 21:06:31 +0000 (14:06 -0700)]
Fix compile warning on MSVC-vulkan (VkDeviceSize -> size_t)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246183002
Review-Url: https://codereview.chromium.org/
2246183002
msarett [Mon, 15 Aug 2016 20:52:31 +0000 (13:52 -0700)]
Revert of Fix WIC encoder to support kJPEG_Type (patchset #3 id:140001 of https://codereview.chromium.org/
2245453002/ )
Reason for revert:
Broken Windows bot.
Original issue's description:
> Fix WIC encoder to support kJPEG_Type
>
> (1) Add support for kJPEG to WIC
> (2) Add encoding test.
> (3) Turn on WIC jpeg encoder on Windows and CG jpeg
> encoder on Mac.
>
> A follow-up may make Skia's encoders the default on all
> platforms. But, in order to do that, I think we need
> to write better encoding unit tests for CG and WIC.
>
> BUG=skia:3969
> BUG=skia:5632
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245453002
>
> Committed: https://skia.googlesource.com/skia/+/
b3a7ef1fc0adc24859d2498aee54d3ec2cbcac3a
TBR=mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3969
Review-Url: https://codereview.chromium.org/
2246203002
bsalomon [Mon, 15 Aug 2016 20:49:32 +0000 (13:49 -0700)]
Print error from driver when shader compiler fails
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2248853002
Review-Url: https://codereview.chromium.org/
2248853002
fmalita [Mon, 15 Aug 2016 20:38:18 +0000 (13:38 -0700)]
Fix up infra bot change
Follow up to https://codereview.chromium.org/
2246943002/.
R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2247903002
Review-Url: https://codereview.chromium.org/
2247903002
msarett [Mon, 15 Aug 2016 20:19:20 +0000 (13:19 -0700)]
Fix WIC encoder to support kJPEG_Type
(1) Add support for kJPEG to WIC
(2) Add encoding test.
(3) Turn on WIC jpeg encoder on Windows and CG jpeg
encoder on Mac.
A follow-up may make Skia's encoders the default on all
platforms. But, in order to do that, I think we need
to write better encoding unit tests for CG and WIC.
BUG=skia:3969
BUG=skia:5632
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2245453002
Review-Url: https://codereview.chromium.org/
2245453002
mtklein [Mon, 15 Aug 2016 19:56:00 +0000 (12:56 -0700)]
Revert of add parallel public API for recording SkLiteDL. (patchset #1 id:1 of https://codereview.chromium.org/
2246893002/ )
Reason for revert:
looking like we won't need this
Original issue's description:
> add parallel public API for recording SkLiteDL.
>
> The API is restricted to pretty much just what Derek calls,
> but it's enough that we can switch testing over to use it.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246893002
>
> Committed: https://skia.googlesource.com/skia/+/
ced26a3d6b77d3a6744a8ccb8eff23eda45fc867
TBR=djsollen@google.com,reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2243393002
fmalita [Mon, 15 Aug 2016 19:45:11 +0000 (12:45 -0700)]
[SVGDom] Add opacity support
Group opacity support. Unlike the other presentation attributes we
support thus far, group opacity is not inherited.
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2246943002
Review-Url: https://codereview.chromium.org/
2246943002
robertphillips [Mon, 15 Aug 2016 19:37:00 +0000 (12:37 -0700)]
Update blurred rrect mask filter creation method to also handle caching
The caching of the mask will also be required for the vertex attribute path so I moved that into the helper. The parameters computed by ComputeBlurredRRectParams will be needed to construct the coverage geometry by the vertex attribute path so I moved that out of the helper.
This is split out of https://codereview.chromium.org/
2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249463002
Review-Url: https://codereview.chromium.org/
2249463002
caryclark [Mon, 15 Aug 2016 19:03:33 +0000 (12:03 -0700)]
add gm that exercises compose shader allocations
This gm triggers the assert in SkSmallAllocator.h
commented out by this CL.
PDFium constructs shaders that resemble the GM.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2249703002
Review-Url: https://codereview.chromium.org/
2249703002
halcanary [Mon, 15 Aug 2016 18:45:36 +0000 (11:45 -0700)]
SkPDF: unify drawText and drawPosText
Motivation: a later CL will add drawTextBlob() (after
https://crrev.com/
2084533004 lands). This CL is designed
with that change in mind. Also fewer redundant lines of
code.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2241683005
Review-Url: https://codereview.chromium.org/
2241683005