Lennart Poettering [Thu, 31 May 2018 09:21:43 +0000 (11:21 +0200)]
Merge pull request #9131 from poettering/memory-startswith
add new memory_startswith() helper and make use of it everywhere
Lennart Poettering [Thu, 31 May 2018 09:13:52 +0000 (11:13 +0200)]
Merge pull request #9083 from yuwata/empty-assignment
load-fragment: make many settings accept empty string
Lennart Poettering [Wed, 30 May 2018 16:21:58 +0000 (18:21 +0200)]
smack: make mac_smack_fix() deal somewhat sensible with non-absolute paths
This tries to improve the mac_smack_fix() logic a bit, by properly
handling non-absolute paths.
It's still pretty broken though, which is sad for security technology:
non-normalized paths (for example "/usr/../dev/sda") will still not be
treated correctly. I am not sure how to fix that properly though, and I
don't understand SMACK well enough to do so. This fix hence just fixes
to most obvious glaring issue.
Lennart Poettering [Thu, 31 May 2018 08:50:10 +0000 (10:50 +0200)]
Merge pull request #9142 from yuwata/coverity-fixes
Coverity fixes
Yu Watanabe [Thu, 31 May 2018 04:27:06 +0000 (13:27 +0900)]
load-fragment: use free_and_replace()
Yu Watanabe [Thu, 31 May 2018 04:26:24 +0000 (13:26 +0900)]
load-fragment: add missing oom check
Fixes CID#1391379.
Yu Watanabe [Thu, 31 May 2018 04:16:47 +0000 (13:16 +0900)]
portable: fix memleak
Fixes CID#1391382.
Yu Watanabe [Tue, 29 May 2018 04:32:05 +0000 (13:32 +0900)]
core/socket: fix coding style
Yu Watanabe [Thu, 31 May 2018 02:04:52 +0000 (11:04 +0900)]
load-fragment: move macro-defined config parsers
Yu Watanabe [Tue, 29 May 2018 03:57:06 +0000 (12:57 +0900)]
load-fragment: use DEFINE_CONFIG_PARSE_*() macros
Yu Watanabe [Tue, 29 May 2018 03:52:14 +0000 (12:52 +0900)]
load-fragment: make IPTOS= accept the empty string
Yu Watanabe [Tue, 29 May 2018 03:49:47 +0000 (12:49 +0900)]
load-fragment: make SocketProtocol= accept the empty string
Yu Watanabe [Tue, 29 May 2018 03:44:57 +0000 (12:44 +0900)]
namespace: rename parse_protect_{home,system}_or_bool() to protect_{home,system}_or_bool_to_string()
Hence, we can define config_parse_protect_{home,system}() by using
DEFINE_CONFIG_PARSE_ENUM() macro.
Yu Watanabe [Tue, 29 May 2018 03:40:28 +0000 (12:40 +0900)]
socket-util: rename parse_socket_address_bind_ipv6_only_or_bool() to socket_address_bind_ipv6_only_or_bool_from_string()
Hence, we can define config_parse_socket_bind() by using
DEFINE_CONFIG_PARSE_ENUM() macro.
Yu Watanabe [Sat, 26 May 2018 16:39:12 +0000 (01:39 +0900)]
conf-parser: introduce DEFINE_CONFIG_PARSE*() macros
This introduces several macros for defining config parsers.
Also this fixes errno in DEFINE_CONFIG_PARSE_ENUM() and _ENUMV()
and makes the log level lower when a duplicated item is
specified to the settings parsed by the function defined by
DEFINE_CONFIG_PARSE_ENUMV().
Yu Watanabe [Fri, 25 May 2018 03:52:12 +0000 (12:52 +0900)]
load-fragment: drop config_parse_no_new_privileges() and use config_parse_bool() instead
Yu Watanabe [Fri, 25 May 2018 03:25:41 +0000 (12:25 +0900)]
load-fragment: make WorkingDirectory= accept the empty string
Yu Watanabe [Fri, 25 May 2018 03:17:52 +0000 (12:17 +0900)]
load-fragment: use parse_sec_fix_0() instead of updating the value later
Yu Watanabe [Fri, 25 May 2018 03:16:24 +0000 (12:16 +0900)]
load-fragment: use config_parse_sec_fix_0() for TimeoutStopSec=
Yu Watanabe [Fri, 25 May 2018 02:54:59 +0000 (11:54 +0900)]
load-fragment: always include config_parse_warn_compat() in the table used by unit_dump_config_items()
Yu Watanabe [Fri, 25 May 2018 02:53:39 +0000 (11:53 +0900)]
load-fragment: drop unused function config_parse_sysv_priority()
Yu Watanabe [Fri, 25 May 2018 02:36:10 +0000 (11:36 +0900)]
load-fragment: make CPUSchedulingPolicy= accept the empty string
Yu Watanabe [Fri, 25 May 2018 02:25:43 +0000 (11:25 +0900)]
load-fragment: make IOScheduling{Class,Priority}= accept the empty string
Yu Watanabe [Fri, 25 May 2018 01:52:47 +0000 (10:52 +0900)]
load-fragment: setting empty string to Nice= resets the previous assignments
Jared Kazimir [Wed, 30 May 2018 15:30:09 +0000 (11:30 -0400)]
hwdb: consolidate multiple razer evdev sections
Lennart Poettering [Wed, 30 May 2018 22:58:41 +0000 (00:58 +0200)]
Merge pull request #9132 from poettering/sd-bus-slot-set-floating
make sure we don't leak bus slots when sd_bus_add_match_async() is used
Sergio Lindo Mansilla [Fri, 18 May 2018 14:24:36 +0000 (16:24 +0200)]
Fix pattern to detect distribution
With operator '=', when in /etc/os-release:
ID_LIKE="opensuse suse" # Tumbleweed since at least 2018-04-24
or
ID_LIKE="suse opensuse" # Leap 15
Lennart Poettering [Wed, 30 May 2018 14:35:36 +0000 (16:35 +0200)]
sd-bus: make add match method callback slot "floating"
When we allocate an asynchronous match object we will allocate an
asynchronous bus call object to install the match server side.
Previously the call slot would be created as regular slot, i.e.
non-floating which meant installing the match even if it was itself
floating would result in a non-floating slot to be created internally,
which ultimately would mean the sd_bus object would be referenced by it,
and thus never be freed.
Let's fix that by making the match method callback floating in any case
as we have no interest in leaving the bus allocated beyond the match
slot.
Fixes: #8551
Lennart Poettering [Wed, 30 May 2018 14:34:06 +0000 (16:34 +0200)]
bus-slot: for bus slot objects with no explicit description use the match string as description
Let's make debugging a but easier with implicit descriptions for some
match objects.
Lennart Poettering [Wed, 30 May 2018 14:33:12 +0000 (16:33 +0200)]
man: document the new sd_bus_slot_set_floating() call
Also extend the memory management description of sd-bus highlighting the
effect of "floating" slot objects a bit.
Lennart Poettering [Wed, 30 May 2018 14:29:33 +0000 (16:29 +0200)]
sd-bus: add new sd_bus_slot_set_floating() call
This new call allows explicit control of the "floating" state of a bus
slot object. This is useful for creating a bus slot object first,
retaining a reference to it, using it for making changes to the slot
object (for example, set a description) and then handing it over to
sd-bus for lifecycle management.
It's also useful to fix #8551.
Lennart Poettering [Wed, 30 May 2018 14:28:28 +0000 (16:28 +0200)]
man: fix minor typo
Lennart Poettering [Wed, 30 May 2018 11:09:03 +0000 (13:09 +0200)]
tree-wide: make use of memory_startswith() at various places
Lennart Poettering [Wed, 30 May 2018 11:07:37 +0000 (13:07 +0200)]
string-util: add new memory_startswith() helper
We have code like this at various placer, let's make things shorter and
more readable with a helper for it.
Susant Sahani [Tue, 29 May 2018 14:58:11 +0000 (20:28 +0530)]
networkd: Add ability to set MULTICAST flag on interface
Closes #9113
fix ARP toggling flag
Sylvain Plantefève [Tue, 29 May 2018 19:26:39 +0000 (21:26 +0200)]
po: update French translation
Yu Watanabe [Wed, 30 May 2018 03:56:23 +0000 (12:56 +0900)]
Merge pull request #9120 from poettering/timedated-timezone-minifixes
Minor improvements to timedated
Yu Watanabe [Tue, 29 May 2018 16:07:37 +0000 (01:07 +0900)]
tree-wide: fix typo in comments and NEWS
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 10:19:27 +0000 (12:19 +0200)]
man: recommend After= with Requisite=
Fixes #8309.
Vito Caputo [Mon, 28 May 2018 22:09:55 +0000 (15:09 -0700)]
journal-file: avoid joining offline thread
In journal_file_set_online() the offline thread doesn't need to be
joined if it's been canceled before actually reaching the phase of
writing the offline state.
Lennart Poettering [Tue, 29 May 2018 10:39:16 +0000 (12:39 +0200)]
timedated: add some debug logging when a number of kernel calls fail
Lennart Poettering [Tue, 29 May 2018 10:36:40 +0000 (12:36 +0200)]
timedated: show the short timezone name when changing timezones in logs
Lennart Poettering [Mon, 28 May 2018 19:47:43 +0000 (21:47 +0200)]
conf-parser: add a bit more whitespace
We usually seperate case statements within a switch from each other by
empty lines. We also often add an empty line after multi-line function
prototypes, let's do so here too
Also, no trailing ; after }...
Lennart Poettering [Mon, 28 May 2018 19:47:12 +0000 (21:47 +0200)]
core: drop deprecated (and ignored) configuration items from --dump-configuration-items output
Zbigniew Jędrzejewski-Szmek [Tue, 29 May 2018 13:23:03 +0000 (15:23 +0200)]
Merge pull request #9116 from poettering/tmpfiles-tmp-var-tmp
add new specifiers %T and %V that expand to /tmp or /var/tmp or $TMP/$TMPDIR/$TEMP
Zbigniew Jędrzejewski-Szmek [Tue, 29 May 2018 13:13:34 +0000 (15:13 +0200)]
Merge pull request #9084 from yuwata/fix-8965
core: make StateDirectory= or friends works with DynamicUser= and RootDirectory=/RootImage=
Lennart Poettering [Tue, 29 May 2018 09:40:49 +0000 (11:40 +0200)]
update TODO
Lennart Poettering [Tue, 29 May 2018 09:32:27 +0000 (11:32 +0200)]
man: don't refer to "service manager" in tmpfiles.d(5)
system-tmpfiles is not a "service manager" hence say "command" instead.
Lennart Poettering [Tue, 29 May 2018 09:30:10 +0000 (11:30 +0200)]
resolved: reindent specifier table
Lennart Poettering [Tue, 29 May 2018 09:25:26 +0000 (11:25 +0200)]
core: introduce specifiers for /tmp and /var/tmp
This corresponds nicely with the specifiers we already pass for
/var/lib, /var/cache, /run and so on.
This is particular useful to update the test-path service files to
operate without guessable files, thus allowing multiple parallel
test-path invocations to pass without issues (the idea is to set $TMPDIR
early on in the test to some private directory, and then only use the
new %T or %V specifier to refer to it).
Lennart Poettering [Tue, 29 May 2018 09:13:40 +0000 (11:13 +0200)]
man: sort specifier list in systemd.unit(5) alphabetically
Usually, we order our settings in our unit files in a logical order,
grouping related settings together, and putting more relevant stuff
first, instead of following a strictly alphabetical order.
For specifiers I think it makes sense to follow an alphabetical order
however, since they literally are just characters, and hence I think the
concept of alphabetical ordering is much more commanding for them. Also,
since specifiers are usually not used in combination, but mostly used
indepdently of each other I think it's not that important to group
similar ones together.
No other changes except the reordering.
Yu Watanabe [Tue, 29 May 2018 06:11:35 +0000 (15:11 +0900)]
doc: mention RestrictNamespaces= merges multiple assignment now
Follow-up for #8817.
Lennart Poettering [Mon, 28 May 2018 12:24:19 +0000 (14:24 +0200)]
Merge pull request #9103 from keszybz/more-tables-tests
More tables tests
Lennart Poettering [Mon, 28 May 2018 12:24:00 +0000 (14:24 +0200)]
Merge pull request #9104 from keszybz/nspawn-umask
Nspawn umask
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 07:07:36 +0000 (09:07 +0200)]
meson: test out headers with more standard versions
They all pass fine, but let's keep testing regularly.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 09:42:02 +0000 (11:42 +0200)]
Merge pull request #9099 from yuwata/list-dbus-prop
completion: fixes for `systemctl status --property`
Yu Watanabe [Mon, 28 May 2018 09:16:32 +0000 (18:16 +0900)]
man: use IMAGE for portable service image name
Yu Watanabe [Mon, 28 May 2018 06:38:19 +0000 (15:38 +0900)]
bash-completion: add completion for portablectl
Yu Watanabe [Mon, 28 May 2018 05:57:00 +0000 (14:57 +0900)]
bash-completion: also suggest template unit files
Fixes #9041.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 06:41:04 +0000 (08:41 +0200)]
zsh-completion: suggest bus properties instead of configuration items for 'systemctl -p'
Yu Watanabe [Mon, 28 May 2018 05:19:16 +0000 (14:19 +0900)]
bash-completion: suggest bus properties instead of configuration items for 'systemctl -p'
Closes #5137.
Yu Watanabe [Mon, 28 May 2018 09:13:19 +0000 (18:13 +0900)]
core: add --dump-bus-properties option to systemd
If systemd is invoked with this option, this dumps all bus properties.
This may be useful for shell completion for `systemctl --property`.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 09:01:30 +0000 (11:01 +0200)]
nspawn: reset umask early
Fixes #8911.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 08:53:11 +0000 (10:53 +0200)]
nspawn: remove some vertical whitespace
Sometimes an empty line is good for readability, but here I think
they all can be removed without any loss.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 08:38:03 +0000 (10:38 +0200)]
test-nspawn-tables: add another "tables" test
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 08:37:11 +0000 (10:37 +0200)]
meson: use a convenience static library for nspawn core
This makes it easier to link the nspawn implementation to the tests.
Right now this just means that nspawn-patch-uid.c is not compiled
twice, which is nice, but results in test-patch-uid being slightly bigger,
which is not nice. But in general, we should use convenience libs to
compile everything just once, as far as possible. Otherwise, once we
start compiling a few files here twice, and a few file there thrice, we
soon end up in a state where we are doing hundreds of extra compilations.
So let's do the "right" thing, even if is might not be more efficient.
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 08:33:30 +0000 (10:33 +0200)]
test-tables,test-network-tables: add a few more tests
Zbigniew Jędrzejewski-Szmek [Mon, 28 May 2018 07:38:14 +0000 (09:38 +0200)]
test-tables*: sort
Piotr Drąg [Mon, 28 May 2018 05:24:25 +0000 (07:24 +0200)]
po: update Polish translation
Yu Watanabe [Mon, 28 May 2018 01:36:19 +0000 (10:36 +0900)]
po: update japanese translation
Yu Watanabe [Mon, 28 May 2018 04:36:35 +0000 (13:36 +0900)]
core: include sd-bus-vtable.h in dbus-*.h
Yu Watanabe [Mon, 28 May 2018 01:38:54 +0000 (10:38 +0900)]
Merge pull request #9092 from keszybz/sd-bus-cleanup-more
sd-bus: use _cleanup_ more
Piotr Drąg [Sun, 27 May 2018 08:33:59 +0000 (10:33 +0200)]
Update POTFILES.in
Zbigniew Jędrzejewski-Szmek [Sat, 26 May 2018 15:02:53 +0000 (17:02 +0200)]
doc: fix quoting
Noticed by Craig Barnes.
Yu Watanabe [Sat, 26 May 2018 11:56:44 +0000 (20:56 +0900)]
portablectl: fix memleaks
Fixes #9089.
Yu Watanabe [Sat, 26 May 2018 11:49:43 +0000 (20:49 +0900)]
portable: fix memleak
Closes #9086.
Zbigniew Jędrzejewski-Szmek [Sat, 26 May 2018 14:56:01 +0000 (16:56 +0200)]
sd-bus: use _cleanup_ more
Luca Boccassi [Tue, 22 May 2018 11:22:00 +0000 (12:22 +0100)]
journalctl: add with-unit mode
When dealing with a large number of template instances, for example
when launching daemons per VRF, it is hard for operators to correlate
log lines to arguments.
Add a new with-unit mode which, if available, prefixes unit and user
unit names when displaying its log messages instead of the syslog
identifier. It will also use the full timestamp with timezones, like
the short-full mode.
Yu Watanabe [Fri, 25 May 2018 09:09:01 +0000 (18:09 +0900)]
tree-wide: drop unused variables
Follow-ups for #8620.
Zbigniew Jędrzejewski-Szmek [Fri, 25 May 2018 08:48:12 +0000 (10:48 +0200)]
Merge pull request #8620 from poettering/portablectl
an implementation of the "portable services" concept
Yu Watanabe [Fri, 25 May 2018 08:32:55 +0000 (17:32 +0900)]
core: setup mount namespace when RootDirectory= and RuntimeDirectory= or friends are set
The directories specified by RuntimeDirectory= or friends are created
on host. So, it is necessary to bind-mount them on root directory.
Yu Watanabe [Fri, 25 May 2018 08:25:17 +0000 (17:25 +0900)]
core: make StateDirectory= or friends works with DynamicUser= and RootDirectory=/RootImage=
The symbolic links to private directories specified by StateDirectory=
or its friends are created on the host. So, when DynamicUser= and
RootDirectory=/RootImage= are set, then the executed process cannot
access private directory.
This makes the private directories are mounted on the non-private place
when both DynamicUser= and RootDirectory=/RootImage= are set.
Fixes #8965.
Mike Gilbert [Thu, 24 May 2018 14:48:55 +0000 (10:48 -0400)]
basic: fix raw_clone() on 32-bit sparc
The clone syscall uses the same semantics as on 64-bit. The trap number
for syscall entry is different.
Bug: https://bugs.gentoo.org/656368
Lennart Poettering [Mon, 16 Apr 2018 10:37:25 +0000 (12:37 +0200)]
update TODO
Lennart Poettering [Tue, 17 Apr 2018 16:43:42 +0000 (18:43 +0200)]
doc: add introductory docs for portable services
Lennart Poettering [Tue, 17 Apr 2018 15:40:34 +0000 (17:40 +0200)]
man: add man pages for the portable service stuff
Lennart Poettering [Mon, 16 Apr 2018 19:41:40 +0000 (21:41 +0200)]
add new portable service framework
This adds a small service "systemd-portabled" and a matching client
"portablectl", which implement the "portable service" concept.
The daemon implements the actual operations, is PolicyKit-enabled and is
activated on demand with exit-on-idle.
Both the daemon and the client are an optional build artifact, enabled
by default rhough.
Lennart Poettering [Mon, 9 Apr 2018 17:44:21 +0000 (19:44 +0200)]
machined: move bus_reply_pair_array() into generic utilities
This way, we can reuse it in portabled.
Lennart Poettering [Fri, 6 Apr 2018 17:18:47 +0000 (19:18 +0200)]
machined: unify how we forward image method calls from manager to image object
Much like the previous commit, but for Image objects rather than Machine
objects.
Lennart Poettering [Fri, 6 Apr 2018 17:09:53 +0000 (19:09 +0200)]
machined: introduce a common function for redirecting machine method calls from manager to machine object
Let's shorten the code a bit, and unify how we forward executoin from
the machine functions that take a machine name as first argument to the
matching functions on the machine object.
Lennart Poettering [Tue, 17 Apr 2018 09:08:54 +0000 (11:08 +0200)]
machine-image: extend search path
This adds directories in /etc and /run to the search paths for OS
images. While it doesn't make much sense to actually place huge disk
images there, it's good enough for symlinks to those.
The main reason for supporting this is that this allows us to neatly
symlink portable image files located outside of the search path into the
search path when attaching them, so that attaching them also means they
are discoverable properly for all commands.
Lennart Poettering [Tue, 17 Apr 2018 09:14:57 +0000 (11:14 +0200)]
machine-image: add 'discoverable' flag for images
This new flag indicates whether the image object was found in the search
paths using the usual algorithm, or was instantiated by path.
This is useful for code that wants to know whether an image may be
referenced by its shortened name or must be specified by its full name.
Lennart Poettering [Mon, 16 Apr 2018 19:38:24 +0000 (21:38 +0200)]
machine-image: add proper refcounting
Lennart Poettering [Fri, 6 Apr 2018 16:58:28 +0000 (18:58 +0200)]
machine-image: add APIs for converting arbitrary image paths into Image objects
Lennart Poettering [Fri, 6 Apr 2018 16:57:08 +0000 (18:57 +0200)]
machine-image: fix a debug log message
Lennart Poettering [Fri, 6 Apr 2018 16:53:57 +0000 (18:53 +0200)]
machine-image: rework error handling
Let's rework error handling a bit in image_find() and friends: when we
can't find an image, return -ENOENT rather than 0. That's better as
before we violated the usual rule in our codebase that return parameters
are initialized when the return value is >= 0 and otherwise not touched.
This also makes enumeration and validation a bit more strict: we'll only
accept ".raw" as suffix for regular files, and filter out this suffix
handling on directories/subvolumes, where it makes no sense.
Lennart Poettering [Thu, 5 Apr 2018 16:01:54 +0000 (18:01 +0200)]
machine-image: use pretty names if we already have them and validated them
Lennart Poettering [Thu, 5 Apr 2018 16:01:27 +0000 (18:01 +0200)]
machine-image: validate pretty names when auto-generating them
Lennart Poettering [Thu, 5 Apr 2018 15:56:22 +0000 (17:56 +0200)]
machine-image: fix duplicate detection when discovering images
We need to chop off the .raw suffix from the files we find before we can
test it against the hashmap. Hence do that.
And while we are at it, we can pass the pretty name into image_make(),
since we already have it properly formatted.
Lennart Poettering [Thu, 5 Apr 2018 13:39:43 +0000 (15:39 +0200)]
machine-image: introduce two different classes of images
This distuingishes two different classes of images, one for the purpose
of npsawn-like containers, i.e. "machines", and one for portable
services.
This distinction is mostly about search paths. We look for machine
images in /var/lib/machines and for portable images in
/var/lib/portables.