review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

bsalomon [Fri, 5 Sep 2014 20:34:00 +0000 (13:34 -0700)]

"NULL !=" = NULL

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/544233002

commit | commitdiff | tree

stephana [Fri, 5 Sep 2014 20:21:42 +0000 (13:21 -0700)]

For certain input skpdiff segfaulted. This prevents the segfault and should fix the failed test in housekeeping.

BUG=skia:2902
R=mtklein@google.com, rmistry@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/546753003

commit | commitdiff | tree

bsalomon [Fri, 5 Sep 2014 19:23:12 +0000 (12:23 -0700)]

Don't take a ref on GP in AutoEffectRestore.

BUG=skia:2889
R=joshualitt@chromium.org, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/546043002

commit | commitdiff | tree

joshualitt [Fri, 5 Sep 2014 17:45:30 +0000 (10:45 -0700)]

Small fix for RODrawState

BUG=skia:
R=egdaniel@google.com, joshualitt@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/545273002

commit | commitdiff | tree

mtklein [Fri, 5 Sep 2014 17:36:39 +0000 (10:36 -0700)]

Suppress mystery leak.

BUG=skia:2916
R=caryclark@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/543063002

commit | commitdiff | tree

bsalomon [Fri, 5 Sep 2014 16:18:51 +0000 (09:18 -0700)]

Change behavior of GrDS::AutoEffectRestort wrt GPs.

BUG=skia:2889
R=robertphillips@google.com, joshualitt@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/545253002

commit | commitdiff | tree

bsalomon [Fri, 5 Sep 2014 13:13:43 +0000 (06:13 -0700)]

Add pop_back() to GrAllocator and add unit test.

BUG=skia:2889
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/538183002

commit | commitdiff | tree

borenet [Fri, 5 Sep 2014 04:14:04 +0000 (21:14 -0700)]

Update SKP version to 92

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/546583003

commit | commitdiff | tree

bsalomon [Thu, 4 Sep 2014 21:13:44 +0000 (14:13 -0700)]

Add method to GrProgramResource to record that pending a execution was completed.

BUG=skia:2889
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/543833002

commit | commitdiff | tree

mtklein [Thu, 4 Sep 2014 21:12:44 +0000 (14:12 -0700)]

Implement all SkCanvas overrides that SkPictureRecord does.

Primarily this is for isDrawingToLayer(). drawData() and onNewSurface() are
for completeness.

BUG=409138
R=robertphillips@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/545613002

commit | commitdiff | tree

joshualitt [Thu, 4 Sep 2014 20:52:34 +0000 (13:52 -0700)]

Updating expectations
TBR=
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/543813003

commit | commitdiff | tree

reed [Thu, 4 Sep 2014 20:18:36 +0000 (13:18 -0700)]

don't use local static bitmap -- racy and unnecessary

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/540993003

commit | commitdiff | tree

bsalomon [Thu, 4 Sep 2014 20:12:37 +0000 (13:12 -0700)]

Add GrProgramElement base class for GrEffect with deferred exec ref.

BUG=skia:2889
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/537773004

commit | commitdiff | tree

reed [Thu, 4 Sep 2014 19:45:18 +0000 (12:45 -0700)]

add SK_API to forward declare in canvas.h

NOTRY=True
TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/541073002

commit | commitdiff | tree

reed [Thu, 4 Sep 2014 19:14:36 +0000 (12:14 -0700)]

remove getTotalClipAsPath, privatize getTotalClip

R=robertphillips@google.com, djsollen@google.com
TBR=robertphilips

Author: reed@google.com

Review URL: https://codereview.chromium.org/546493002

commit | commitdiff | tree

mtklein [Thu, 4 Sep 2014 17:50:53 +0000 (10:50 -0700)]

disable flaky test

BUG=skia:2912
R=reed@google.com, mtklein@google.com, tfarina@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/537363003

commit | commitdiff | tree

reed [Thu, 4 Sep 2014 16:02:23 +0000 (09:02 -0700)]

cleanup rasterclip helper

R=robertphillips@google.com
TBR=robertphilips

Author: reed@google.com

Review URL: https://codereview.chromium.org/540983002

commit | commitdiff | tree

joshualitt [Thu, 4 Sep 2014 15:56:46 +0000 (08:56 -0700)]

Initial change to create GeometryProcessor

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com, egdaniel@google.com, jvanverth@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/509153002

commit | commitdiff | tree

robertphillips [Thu, 4 Sep 2014 15:42:50 +0000 (08:42 -0700)]

Change SkPicture::draw to playback

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/540963002

commit | commitdiff | tree

Mike Klein [Thu, 4 Sep 2014 15:08:07 +0000 (11:08 -0400)]

Finish off some lingering rebaselines.

BUG=skia:

Review URL: https://codereview.chromium.org/538023002

commit | commitdiff | tree

Mike Klein [Thu, 4 Sep 2014 15:03:30 +0000 (11:03 -0400)]

rebaseline downsamplebitmaps

BUG=skia:

Review URL: https://codereview.chromium.org/537913003

commit | commitdiff | tree

qiankun.miao [Thu, 4 Sep 2014 14:36:38 +0000 (07:36 -0700)]

Enable highQualityFilter_SSE2

With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40%
performance improvement on desktop i7-3770.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b381fa10d8079c58928058bb8a6db32b39f05e51

CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
R=mtklein@google.com, humper@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/525283002

commit | commitdiff | tree

robertphillips [Thu, 4 Sep 2014 14:24:18 +0000 (07:24 -0700)]

Switch Layer Hoisting over to SkRecord backend

R=bsalomon@google.com
TBR=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/540543002

commit | commitdiff | tree

Derek Sollenberger [Thu, 4 Sep 2014 13:51:33 +0000 (09:51 -0400)]

Temporarily disable tiling another GM that produces errors with the existing 64-bit ARM toolchain.

BUG=skia:2908

Review URL: https://codereview.chromium.org/537343003

commit | commitdiff | tree

borenet [Thu, 4 Sep 2014 04:23:26 +0000 (21:23 -0700)]

Update SKP version to 91

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/544493002

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 22:34:37 +0000 (15:34 -0700)]

SkThreadPool ~~> SkTaskGroup

SkTaskGroup is like SkThreadPool except the threads stay in
one global pool.  Each SkTaskGroup itself is tiny (4 bytes)
and its wait() method applies only to tasks add()ed to that
instance, not the whole thread pool.

This means we don't need to bring up new thread pools when
tests themselves want to use multithreading (e.g. pathops,
quilt).  We just create a new SkTaskGroup and wait for that
to complete.  This should be more efficient, and allow us
to expand where we use threads to really latency sensitive
places.  E.g. we can probably now use these in nanobench
for CPU .skp rendering.

Now that all threads are sharing the same pool, I think we
can remove most of the custom mechanism pathops tests use
to control threading.  They'll just ride on the global pool
with all other tests now.

This (temporarily?) removes the GPU multithreading feature
from DM, which we don't use.

On my desktop, DM runs a little faster (57s -> 55s) in
Debug, and a lot faster in Release (36s -> 24s).  The bots
show speedups of similar proportions, cutting more than a
minute off the N4/Release and Win7/Debug runtimes.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f

R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/531653002

commit | commitdiff | tree

Mike Klein [Wed, 3 Sep 2014 21:39:25 +0000 (17:39 -0400)]

remove unused n4 expectations

BUG=skia:

Review URL: https://codereview.chromium.org/537163002

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 21:17:48 +0000 (14:17 -0700)]

Revert of SkThreadPool ~~> SkTaskGroup (patchset #4 id:60001 of https://codereview.chromium.org/531653002/)

Reason for revert:
Leaks, leaks, leaks.

Original issue's description:
> SkThreadPool ~~> SkTaskGroup
>
> SkTaskGroup is like SkThreadPool except the threads stay in
> one global pool.  Each SkTaskGroup itself is tiny (4 bytes)
> and its wait() method applies only to tasks add()ed to that
> instance, not the whole thread pool.
>
> This means we don't need to bring up new thread pools when
> tests themselves want to use multithreading (e.g. pathops,
> quilt).  We just create a new SkTaskGroup and wait for that
> to complete.  This should be more efficient, and allow us
> to expand where we use threads to really latency sensitive
> places.  E.g. we can probably now use these in nanobench
> for CPU .skp rendering.
>
> Now that all threads are sharing the same pool, I think we
> can remove most of the custom mechanism pathops tests use
> to control threading.  They'll just ride on the global pool
> with all other tests now.
>
> This (temporarily?) removes the GPU multithreading feature
> from DM, which we don't use.
>
> On my desktop, DM runs a little faster (57s -> 55s) in
> Debug, and a lot faster in Release (36s -> 24s).  The bots
> show speedups of similar proportions, cutting more than a
> minute off the N4/Release and Win7/Debug runtimes.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f

R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, reed@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, caryclark@google.com, mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/533393002

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 21:06:47 +0000 (14:06 -0700)]

SkThreadPool ~~> SkTaskGroup

SkTaskGroup is like SkThreadPool except the threads stay in
one global pool.  Each SkTaskGroup itself is tiny (4 bytes)
and its wait() method applies only to tasks add()ed to that
instance, not the whole thread pool.

This means we don't need to bring up new thread pools when
tests themselves want to use multithreading (e.g. pathops,
quilt).  We just create a new SkTaskGroup and wait for that
to complete.  This should be more efficient, and allow us
to expand where we use threads to really latency sensitive
places.  E.g. we can probably now use these in nanobench
for CPU .skp rendering.

Now that all threads are sharing the same pool, I think we
can remove most of the custom mechanism pathops tests use
to control threading.  They'll just ride on the global pool
with all other tests now.

This (temporarily?) removes the GPU multithreading feature
from DM, which we don't use.

On my desktop, DM runs a little faster (57s -> 55s) in
Debug, and a lot faster in Release (36s -> 24s).  The bots
show speedups of similar proportions, cutting more than a
minute off the N4/Release and Win7/Debug runtimes.

BUG=skia:
R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/531653002

commit | commitdiff | tree

bsalomon [Wed, 3 Sep 2014 21:05:49 +0000 (14:05 -0700)]

Add reference base class to GrGpuResourcewith pending IO references.

BUG=skia:2889
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/533343002

commit | commitdiff | tree

Mike Klein [Wed, 3 Sep 2014 21:02:04 +0000 (17:02 -0400)]

fix up GM suppressions

BUG=skia:2911

Review URL: https://codereview.chromium.org/538723002

commit | commitdiff | tree

robertphillips [Wed, 3 Sep 2014 20:46:02 +0000 (13:46 -0700)]

Remove use of EXPERIMENTAL_getActiveOps from layer hoisting code

This is getting in the way of switching to the SkRecord backend and is of questionable value.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/539693002

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 20:40:52 +0000 (13:40 -0700)]

Turn downsamplebitmap GMs vertical to fit in 2048x2048.

BUG=skia:2911
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/536103002

commit | commitdiff | tree

djsollen [Wed, 3 Sep 2014 20:38:32 +0000 (13:38 -0700)]

Revert to enabling all of -O2 as it exposes a bug in the toolchain.

Instead as a workaround we will temporarily disable tiling the
few GMs that produce errors with the existing 64-bit ARM toolchain.

BUG=skia:2908
R=mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/537713002

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 20:22:46 +0000 (13:22 -0700)]

On Android, skip tiling for all giantbitmap variants.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/537693002

commit | commitdiff | tree

piotaixr [Wed, 3 Sep 2014 19:34:57 +0000 (12:34 -0700)]

Remove SkBitmapCache::Find/Add(_,width,height,_)
in favor of the versions having a SkIRect as input parameter

BUG=skia:2909
R=reed@google.com, junov@chromium.org

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/539643002

commit | commitdiff | tree

reed [Wed, 3 Sep 2014 18:54:58 +0000 (11:54 -0700)]

Hide fields in SkImageInfo

R=rmistry@google.com
TBR=bsalomon

Author: reed@google.com

Review URL: https://codereview.chromium.org/536003002

commit | commitdiff | tree

piotaixr [Wed, 3 Sep 2014 18:33:13 +0000 (11:33 -0700)]

The key for SkBitmapCache can now be genID+SkIRect

BUG=skia:2894
R=junov@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/518983002

commit | commitdiff | tree

robertphillips [Wed, 3 Sep 2014 18:04:30 +0000 (11:04 -0700)]

Replace SkPictureReplacementPlayback with GrRecordReplaceDraw

I think this is sufficiently specialized to keep it in Ganesh for the time being.

R=bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/535953002

commit | commitdiff | tree

djsollen [Wed, 3 Sep 2014 17:44:00 +0000 (10:44 -0700)]

Disable -fexpensive-optimizations on 64-bit ARM.

BUG=skia:2908
R=mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/535113004

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 15:57:02 +0000 (08:57 -0700)]

Revert of Enable highQualityFilter_SSE2 (patchset #1 id:1 of https://codereview.chromium.org/525283002/)

Reason for revert:
Color order looks wrong on Macs:

Before: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/12823183142873462143.png

After: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/13683040204546320578.png

Original issue's description:
> Enable highQualityFilter_SSE2
>
> With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40%
> performance improvement on desktop i7-3770.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b381fa10d8079c58928058bb8a6db32b39f05e51

R=humper@google.com, qiankun.miao@intel.com
TBR=humper@google.com, qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/539523002

commit | commitdiff | tree

jvanverth [Wed, 3 Sep 2014 15:44:59 +0000 (08:44 -0700)]

Update fontcache GM to stress the font atlas.

Pulled out of https://codereview.chromium.org/466363009/.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/534253003

commit | commitdiff | tree

qiankun.miao [Wed, 3 Sep 2014 15:24:12 +0000 (08:24 -0700)]

Enable highQualityFilter_SSE2

With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40%
performance improvement on desktop i7-3770.

BUG=skia:
R=mtklein@google.com, humper@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/525283002

commit | commitdiff | tree

bsalomon [Wed, 3 Sep 2014 14:19:50 +0000 (07:19 -0700)]

Remove GrDrawTarget::AutoRenderTargetRestore.

Pass GrRenderTarget in GrGpuG clear\bind methods.

BUG=skia:2889
R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/533883004

commit | commitdiff | tree

mtklein [Wed, 3 Sep 2014 14:02:07 +0000 (07:02 -0700)]

Disable SSE4 S32A_Opaque blit.

This code sometimes generates a build warning that bothers Chrome.

BUG=399842,skia:2906
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/538463003

commit | commitdiff | tree

reed [Wed, 3 Sep 2014 13:31:06 +0000 (06:31 -0700)]

remove flags that are already mirrored in chrome's SkUserConfig.h

NOTRY=True
TBR=fmalita@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/537563002

commit | commitdiff | tree

qiankun.miao [Wed, 3 Sep 2014 13:27:54 +0000 (06:27 -0700)]

Remove dead code in SkBitmapFilter_opts_SSE2.h/cpp

BUG=skia:
R=mtklein@google.com, humper@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/530673002

commit | commitdiff | tree

Derek Sollenberger [Wed, 3 Sep 2014 13:10:20 +0000 (09:10 -0400)]

Update failing testimagefilter GM with new baseline and bug number

Review URL: https://codereview.chromium.org/535843003

commit | commitdiff | tree

Derek Sollenberger [Wed, 3 Sep 2014 13:01:29 +0000 (09:01 -0400)]

Rebase NEON image procs based on C++ implementation.

BUG=skia:2845

Review URL: https://codereview.chromium.org/532193003

commit | commitdiff | tree

reed [Wed, 3 Sep 2014 12:48:56 +0000 (05:48 -0700)]

Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/527073003/)

Reason for revert:
virtual gpu failures in layouttests

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/23717

[6:6:0903/041147:1700960503:INFO:SkBitmap.cpp(1003)] ../../third_party/skia/src/core/SkBitmap.cpp:1003: failed assertion "fPixelRef->info() == pixelRef->info()"

[6:6:0903/041147:1700961002:FATAL:SkBitmap.cpp(1003)] SK_CRASH
#0 0x7f9867df2c1e base::debug::StackTrace::StackTrace()
#1 0x7f9867e89e05 logging::LogMessage::~LogMessage()
#2 0x7f98689c4970 SkDebugf_FileLine()
#3 0x7f986870ebc6 SkBitmap::deepCopyTo()
#4 0x7f98690a3b6d blink::deepSkBitmapCopy()
#5 0x7f98690a3abe blink::ImageBuffer::copyImage()
#6 0x7f985fd4479e blink::ImageBitmap::ImageBitmap()
#7 0x7f985fd45942 blink::ImageBitmap::create()
#8 0x7f985fd84fdc blink::ImageBitmapFactories::createImageBitmap()
#9 0x7f985fd84d11 blink::ImageBitmapFactories::createImageBitmap()
#10 0x7f985ec9a7f2 blink::LocalDOMWindowV8Internal::createImageBitmap13Method()
#11 0x7f985ec96b0c blink::LocalDOMWindowV8Internal::createImageBitmapMethod()
#12 0x7f985ec91954 blink::LocalDOMWindowV8Internal::createImageBitmapMethodCallback()
#13 0x7f9869955af0 v8::internal::FunctionCallbackArguments::Call()
#14 0x7f98699833bd v8::internal::Builtin_HandleApiCall()

Original issue's description:
> Add gamma/sRGB tag to SkImageInfo
>
> This reverts commit 1cbc68f9659f15206d920dacd434ddf4b658ad1f.
>
> requires this to land in blink https://codereview.chromium.org/531883002/
>
> Committed: https://skia.googlesource.com/skia/+/2f6abdecc5c2f21da13003c615903679abc73fc7

R=fmalita@google.com, reed@chromium.org
TBR=fmalita@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/535113002

commit | commitdiff | tree

Derek Sollenberger [Wed, 3 Sep 2014 12:31:02 +0000 (08:31 -0400)]

Update GM baselines for Arm64 bot.

Review URL: https://codereview.chromium.org/530423003

commit | commitdiff | tree

reed [Wed, 3 Sep 2014 04:56:40 +0000 (21:56 -0700)]

Add gamma/sRGB tag to SkImageInfo

This reverts commit 1cbc68f9659f15206d920dacd434ddf4b658ad1f.

requires this to land in blink https://codereview.chromium.org/531883002/

R=fmalita@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/527073003

commit | commitdiff | tree

mtklein [Tue, 2 Sep 2014 22:19:48 +0000 (15:19 -0700)]

Fix drawPosText() bounds bug.

We didn't catch this in our local tests because we tend to use default
kUTF8_TextEncoding with single-byte characters, which means N == byteLength.

BUG=409110
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/531933002

commit | commitdiff | tree

reed [Tue, 2 Sep 2014 20:50:39 +0000 (13:50 -0700)]

add legacy guard for SK_SUPPORT_LEGACY_ALLOCPIXELS_BOOL to android

NOTRY=True

BUG=skia:
R=djsollen@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/530163002

commit | commitdiff | tree

pkasting [Tue, 2 Sep 2014 20:40:48 +0000 (13:40 -0700)]

Address MSVC warnings about possible value truncation. In the process removes some apparently unused code.

BUG=81439
TEST=none
R=reed@google.com

Author: pkasting@chromium.org

Review URL: https://codereview.chromium.org/517763002

commit | commitdiff | tree

djsollen [Tue, 2 Sep 2014 20:34:49 +0000 (13:34 -0700)]

Remove legacy (and also broken) SkPicture constructor.

R=robertphillips@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/532703004

commit | commitdiff | tree

jvanverth [Tue, 2 Sep 2014 20:15:40 +0000 (13:15 -0700)]

Fix matrix similarity test on arm64

Addresses precision issue by using a simpler test.
Also fixes issues with IvMatrix::preservesRightAngles, and adds unit tests.

BUG=skia:2405
R=robertphillips@google.com, egdaniel@google.com, djsollen@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/520123002

commit | commitdiff | tree

egdaniel [Tue, 2 Sep 2014 19:53:12 +0000 (12:53 -0700)]

Rebaseline bezier cubics
TBR=bsalomon@google.com
NOTRY=True

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/528033002

commit | commitdiff | tree

reed [Tue, 2 Sep 2014 19:50:45 +0000 (12:50 -0700)]

make allocPixels throw on failure

BUG=skia:
R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/510423005

commit | commitdiff | tree

mtklein [Tue, 2 Sep 2014 19:03:31 +0000 (12:03 -0700)]

SkRecordPartialDraw with less code duplication

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/527423002

commit | commitdiff | tree

piotaixr [Tue, 2 Sep 2014 18:50:59 +0000 (11:50 -0700)]

Rename ScaledImageCache.cpp to SkResourceCacheTest.cpp

BUG=skia:
R=junov@chromium.org, reed@android.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/518213003

commit | commitdiff | tree

piotaixr [Tue, 2 Sep 2014 18:27:11 +0000 (11:27 -0700)]

Added Doc for GetAllocator in SkResourceCache and SkBitmapCache

BUG=skia:2896
R=junov@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/533713003

commit | commitdiff | tree

robertphillips [Tue, 2 Sep 2014 17:20:50 +0000 (10:20 -0700)]

Reorganize Layer Hoisting code

With the new MultiPictureDraw API the GrContext will be performing the layer hoisting (instead of the SkGpuDevice). This CL being moving the layer hoisting functionality to GrLayerHoister rather then dumping it straight into GrContext.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/531733003

commit | commitdiff | tree

egdaniel [Tue, 2 Sep 2014 17:01:30 +0000 (10:01 -0700)]

When ignoring color input don't use vertex attribs on gpu

Also rename SolidWhite_ColorInput enum to be AllOnes_ColorInput to better reflect what it's use is

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/525433002

commit | commitdiff | tree

djsollen [Tue, 2 Sep 2014 15:57:39 +0000 (08:57 -0700)]

Disable NEON procs for box blur as it produces invalid results

R=reed@google.com, mtklein@google.com, senorblanco@google.com
TBR=reed@google.com
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/527973002

commit | commitdiff | tree

egdaniel [Tue, 2 Sep 2014 15:02:38 +0000 (08:02 -0700)]

Add option to add precision to varyings in shader

Also use highp varying on bezier cubics to fix numerical issues for n10 and n4.

BUG=skia:2860
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/522303004

commit | commitdiff | tree

bsalomon [Tue, 2 Sep 2014 14:54:47 +0000 (07:54 -0700)]

Use non-VBO vertex arrays on QC GPUs.

BUG=skia:2901
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/529993003

commit | commitdiff | tree

djsollen [Tue, 2 Sep 2014 13:32:25 +0000 (06:32 -0700)]

Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/)

Reason for revert:
failing more GMs than expected.

Original issue's description:
> Disable NEON procs for box blur as it produces invalid results
>
> BUG=skia:2845
>
> Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

R=senorblanco@google.com, mtklein@google.com
TBR=mtklein@google.com, senorblanco@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/531023002

commit | commitdiff | tree

djsollen [Tue, 2 Sep 2014 12:32:23 +0000 (05:32 -0700)]

Disable NEON procs for box blur as it produces invalid results

BUG=skia:2845
R=senorblanco@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/520963002

commit | commitdiff | tree

Mike Klein [Tue, 2 Sep 2014 12:04:43 +0000 (08:04 -0400)]

whitespace change

BUG=skia:

Review URL: https://codereview.chromium.org/529973002

commit | commitdiff | tree

reed [Tue, 2 Sep 2014 11:14:37 +0000 (04:14 -0700)]

Revert of Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/532583002/)

Reason for revert:
linux_blink_rel

[ RUN      ] DeferredImageDecoderTest.drawIntoSkPicture
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:172: Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) | (static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) | (static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[1457/1458] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[ RUN      ] DeferredImageDecoderTest.decodeOnOtherThread
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:233: Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) | (static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) | (static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
[1458/1458] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
Retrying 2 tests (retry #2)

Original issue's description:
> Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/525113005/)
>
> Reason for revert:
> Experiment to see resulting failures
>
> Original issue's description:
> > Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)
> >
> > Reason for revert:
> > seems to be breaking layout tests in roll
> >
> > Original issue's description:
> > > Add gamma/sRGB tag to SkImageInfo
> > >
> > > This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb
> >
> > TBR=reed@google.com
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4581828014eb3d015e6ed55c9a5b6932b8751818

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/524593005

commit | commitdiff | tree

reed [Tue, 2 Sep 2014 01:36:24 +0000 (18:36 -0700)]

Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/525113005/)

Reason for revert:
Experiment to see resulting failures

Original issue's description:
> Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)
>
> Reason for revert:
> seems to be breaking layout tests in roll
>
> Original issue's description:
> > Add gamma/sRGB tag to SkImageInfo
> >
> > This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/532583002

commit | commitdiff | tree

reed [Mon, 1 Sep 2014 21:28:32 +0000 (14:28 -0700)]

Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)

Reason for revert:
seems to be breaking layout tests in roll

Original issue's description:
> Add gamma/sRGB tag to SkImageInfo
>
> This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/525113005

commit | commitdiff | tree

reed [Mon, 1 Sep 2014 19:14:29 +0000 (12:14 -0700)]

Add gamma/sRGB tag to SkImageInfo

This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b.

BUG=skia:
R=reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/522813002

commit | commitdiff | tree

borenet [Mon, 1 Sep 2014 03:37:00 +0000 (20:37 -0700)]

Update SKP version to 90

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/528673002

commit | commitdiff | tree

Mike Klein [Sun, 31 Aug 2014 15:51:21 +0000 (11:51 -0400)]

Force a build.

BUG=skia:

Review URL: https://codereview.chromium.org/530553002

commit | commitdiff | tree

borenet [Sun, 31 Aug 2014 03:50:55 +0000 (20:50 -0700)]

Update SKP version to 89

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/529543002

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 21:33:06 +0000 (14:33 -0700)]

Revert of Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/524133002/)

Reason for revert:
another build

Original issue's description:
> Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519413002/)
>
> Reason for revert:
> dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah
>
> Original issue's description:
> > Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)
> >
> > Reason for revert:
> > ws
> >
> > Original issue's description:
> > > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
> > >
> > > Reason for revert:
> > > ws
> > >
> > > Original issue's description:
> > > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> > > >
> > > > Reason for revert:
> > > > spring break forever
> > > >
> > > > Original issue's description:
> > > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > > > >
> > > > > Reason for revert:
> > > > > nah
> > > > >
> > > > > Original issue's description:
> > > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > > > >
> > > > > > Reason for revert:
> > > > > > i like the old file better
> > > > > >
> > > > > > Original issue's description:
> > > > > > > moar ws
> > > > > > >
> > > > > > > BUG=skia:
> > > > > > >
> > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > > > >
> > > > > > TBR=mtklein@chromium.org
> > > > > > NOTREECHECKS=true
> > > > > > NOTRY=true
> > > > > > BUG=skia:
> > > > > >
> > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > > > >
> > > > > TBR=mtklein@chromium.org
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/525153003

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 15:47:49 +0000 (08:47 -0700)]

Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519413002/)

Reason for revert:
dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah

Original issue's description:
> Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)
>
> Reason for revert:
> ws
>
> Original issue's description:
> > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
> >
> > Reason for revert:
> > ws
> >
> > Original issue's description:
> > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> > >
> > > Reason for revert:
> > > spring break forever
> > >
> > > Original issue's description:
> > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > > >
> > > > Reason for revert:
> > > > nah
> > > >
> > > > Original issue's description:
> > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > > >
> > > > > Reason for revert:
> > > > > i like the old file better
> > > > >
> > > > > Original issue's description:
> > > > > > moar ws
> > > > > >
> > > > > > BUG=skia:
> > > > > >
> > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > > >
> > > > > TBR=mtklein@chromium.org
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/524133002

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 15:06:37 +0000 (08:06 -0700)]

Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)

Reason for revert:
ws

Original issue's description:
> Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
>
> Reason for revert:
> ws
>
> Original issue's description:
> > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> >
> > Reason for revert:
> > spring break forever
> >
> > Original issue's description:
> > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > >
> > > Reason for revert:
> > > nah
> > >
> > > Original issue's description:
> > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > >
> > > > Reason for revert:
> > > > i like the old file better
> > > >
> > > > Original issue's description:
> > > > > moar ws
> > > > >
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/519413002

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 14:54:38 +0000 (07:54 -0700)]

Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)

Reason for revert:
ws

Original issue's description:
> Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
>
> Reason for revert:
> spring break forever
>
> Original issue's description:
> > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> >
> > Reason for revert:
> > nah
> >
> > Original issue's description:
> > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > >
> > > Reason for revert:
> > > i like the old file better
> > >
> > > Original issue's description:
> > > > moar ws
> > > >
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/523413002

commit | commitdiff | tree

Mike Klein [Sat, 30 Aug 2014 14:33:22 +0000 (10:33 -0400)]

Rebaseline one N4 GM we must have missed.

BUG=skia:

Review URL: https://codereview.chromium.org/524103002

commit | commitdiff | tree

borenet [Sat, 30 Aug 2014 04:18:01 +0000 (21:18 -0700)]

Update SKP version to 88

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/520323002

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 01:40:23 +0000 (18:40 -0700)]

Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)

Reason for revert:
spring break forever

Original issue's description:
> Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
>
> Reason for revert:
> nah
>
> Original issue's description:
> > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> >
> > Reason for revert:
> > i like the old file better
> >
> > Original issue's description:
> > > moar ws
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/519303002

commit | commitdiff | tree

mtklein [Sat, 30 Aug 2014 01:33:24 +0000 (18:33 -0700)]

Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)

Reason for revert:
nah

Original issue's description:
> Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
>
> Reason for revert:
> i like the old file better
>
> Original issue's description:
> > moar ws
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/7a353e9
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/520023003

commit | commitdiff | tree

mtklein [Fri, 29 Aug 2014 23:03:35 +0000 (16:03 -0700)]

Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)

Reason for revert:
i like the old file better

Original issue's description:
> moar ws
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7a353e9

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/518333002

commit | commitdiff | tree

Mike Klein [Fri, 29 Aug 2014 22:52:18 +0000 (18:52 -0400)]

moar ws

BUG=skia:

Review URL: https://codereview.chromium.org/518233004

commit | commitdiff | tree

Mike Klein [Fri, 29 Aug 2014 22:15:59 +0000 (18:15 -0400)]

another ws

BUG=skia:

Review URL: https://codereview.chromium.org/519583008

commit | commitdiff | tree

fmalita [Fri, 29 Aug 2014 22:08:20 +0000 (15:08 -0700)]

Debugger render support for SkDrawTextBlobCommand.

R=robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/523833003

commit | commitdiff | tree

bsalomon [Fri, 29 Aug 2014 22:05:53 +0000 (15:05 -0700)]

Move MakeDivByTextureWHMatrix to GrCoordTransform

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/522873005

commit | commitdiff | tree

Mike Klein [Fri, 29 Aug 2014 21:53:34 +0000 (17:53 -0400)]

ws2

BUG=skia:

Review URL: https://codereview.chromium.org/524853004

commit | commitdiff | tree

Mike Klein [Fri, 29 Aug 2014 21:20:44 +0000 (17:20 -0400)]

ws

BUG=skia:

Review URL: https://codereview.chromium.org/523133002

commit | commitdiff | tree

Derek Sollenberger [Fri, 29 Aug 2014 19:46:28 +0000 (15:46 -0400)]

Add baselines for all GMs that are currently labeled "no comparison".

R=mtklein@google.com

Review URL: https://codereview.chromium.org/519063004

commit | commitdiff | tree

Greg Humphreys [Fri, 29 Aug 2014 19:39:03 +0000 (15:39 -0400)]

rebaseline and re-enable all perspective tests

BUG=skia:

Review URL: https://codereview.chromium.org/518253002

commit | commitdiff | tree

Greg Humphreys [Fri, 29 Aug 2014 19:35:49 +0000 (15:35 -0400)]

fix names of suppresssed tests on win7

BUG=skia:

Review URL: https://codereview.chromium.org/524643003

commit | commitdiff | tree

Greg Humphreys [Fri, 29 Aug 2014 19:29:38 +0000 (15:29 -0400)]

partial rebaseline for image scaling

BUG=skia:

Review URL: https://codereview.chromium.org/520863002

commit | commitdiff | tree

cdalton [Fri, 29 Aug 2014 19:18:36 +0000 (12:18 -0700)]

Don't assert on empty GrGLPaths

Ensure asserts aren't fired when creating a GrGLPath path from an
empty SkPath. An empty path is valid and has practical use, for
example, as a template path for certain nvpr calls.

BUG=skia:2891
R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/522883002

commit | commitdiff | tree

egdaniel [Fri, 29 Aug 2014 18:12:30 +0000 (11:12 -0700)]

Fix to use high precision on cubics not conics.
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2860

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/521623003

commit | commitdiff | tree

bungeman [Fri, 29 Aug 2014 17:38:48 +0000 (10:38 -0700)]

Update FontConfig valgrind suppressions.

FcPattern uses 'intptr_t elts_offsets' instead of 'FcPatternEltPtr elts'
to reference its elements. Therefore, valgrind suspects possible leaks
on all values, elements, and element lists in FontConfig.

BUG=skia:2879
R=djsollen@google.com, mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/518903002

commit | commitdiff | tree

reed [Fri, 29 Aug 2014 17:25:26 +0000 (10:25 -0700)]

harden requirements on SkBitmapCache

BUG=skia:
R=humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/521433002

Domain: Dotnet / API;