platform/upstream/libSkiaSharp.git
9 years agoDefault geometry processor
joshualitt [Sat, 8 Nov 2014 17:24:25 +0000 (09:24 -0800)]
Default geometry processor

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd

Review URL: https://codereview.chromium.org/678953002

9 years agorebasing some gms
joshualitt [Sat, 8 Nov 2014 15:09:38 +0000 (07:09 -0800)]
rebasing some gms

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/713633002

9 years agoReignore some tests that use distance fields
jvanverth [Fri, 7 Nov 2014 22:57:13 +0000 (14:57 -0800)]
Reignore some tests that use distance fields

NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/708173002

9 years agoRebase for win7 x86 gpu
egdaniel [Fri, 7 Nov 2014 22:22:57 +0000 (14:22 -0800)]
Rebase for win7 x86 gpu

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/708153002

9 years agosimple cl to cleanup friends in GrGpu
joshualitt [Fri, 7 Nov 2014 22:11:45 +0000 (14:11 -0800)]
simple cl to cleanup friends in GrGpu

BUG=skia:

Review URL: https://codereview.chromium.org/709003006

9 years agoMake gpudft non-default config for gm
jvanverth [Fri, 7 Nov 2014 21:49:49 +0000 (13:49 -0800)]
Make gpudft non-default config for gm

Review URL: https://codereview.chromium.org/692153003

9 years agoFinish rebase from df and add baseline images for n10 debug
egdaniel [Fri, 7 Nov 2014 21:19:22 +0000 (13:19 -0800)]
Finish rebase from df and add baseline images for n10 debug

TBR=jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/705353003

9 years agocleaning up geometry handling in gpu
joshualitt [Fri, 7 Nov 2014 20:58:46 +0000 (12:58 -0800)]
cleaning up geometry handling in gpu

BUG=skia:

Review URL: https://codereview.chromium.org/707953004

9 years agoRebaseline s4 gms
egdaniel [Fri, 7 Nov 2014 20:56:35 +0000 (12:56 -0800)]
Rebaseline s4  gms

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/712693002

9 years agoUpdate GrTRecorder to preserve memory allocations
cdalton [Fri, 7 Nov 2014 20:51:18 +0000 (12:51 -0800)]
Update GrTRecorder to preserve memory allocations

Rather than freeing almost all of its memory on calls to reset(), this
change updates GrTRecorder so it keeps around enough to satisfy the
storage requirements from last time, plus up to ~50% growth. This is
based on the assumption that subsequent draw calls require roughly the
same amount of memory.

BUG=skia:

Review URL: https://codereview.chromium.org/684203003

9 years agoRevert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromiu...
fmalita [Fri, 7 Nov 2014 20:26:46 +0000 (12:26 -0800)]
Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/)

Reason for revert:
Canary borkage.

Original issue's description:
> SkDrawCommand scrubbing
>
> Remove unused ctor, constify, etc.
>
> R=robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/712683002

9 years agoSkDrawCommand scrubbing
fmalita [Fri, 7 Nov 2014 20:09:20 +0000 (12:09 -0800)]
SkDrawCommand scrubbing

Remove unused ctor, constify, etc.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/706363002

9 years agoRevert of Default geometry processor (patchset #9 id:160001 of https://codereview...
joshualitt [Fri, 7 Nov 2014 20:08:03 +0000 (12:08 -0800)]
Revert of Default geometry processor (patchset #9 id:160001 of https://codereview.chromium.org/678953002/)

Reason for revert:
breaks nexus 5

Original issue's description:
> Default geometry processor
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/691313003

9 years agoDefault geometry processor
joshualitt [Fri, 7 Nov 2014 19:47:10 +0000 (11:47 -0800)]
Default geometry processor

BUG=skia:

Review URL: https://codereview.chromium.org/678953002

9 years agoadd patch and clicktracking to lua
reed [Fri, 7 Nov 2014 18:23:55 +0000 (10:23 -0800)]
add patch and clicktracking to lua

BUG=skia:

Review URL: https://codereview.chromium.org/712613002

9 years agoOne more attempt at rebaselining
jvanverth [Fri, 7 Nov 2014 18:17:36 +0000 (10:17 -0800)]
One more attempt at rebaselining

TBR=egdaniel@google.com
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/708903006

9 years agoMesa ES 3.0 requires sized internal formats
derekf [Fri, 7 Nov 2014 17:39:26 +0000 (09:39 -0800)]
Mesa ES 3.0 requires sized internal formats

Mesa's ES 3.0 implementation requires GL_R8 as an internal format instead
of GL_RED

Review URL: https://codereview.chromium.org/705183002

9 years agoMissed some expectations
jvanverth [Fri, 7 Nov 2014 16:50:16 +0000 (08:50 -0800)]
Missed some expectations

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/705293002

9 years agoRefactor DrawTarget and GPU to be independent
joshualitt [Fri, 7 Nov 2014 16:48:51 +0000 (08:48 -0800)]
Refactor DrawTarget and GPU to be independent

BUG=skia:

Review URL: https://codereview.chromium.org/705593002

9 years agoRebaseline for https://codereview.chromium.org/703463002/.
jvanverth [Fri, 7 Nov 2014 16:16:49 +0000 (08:16 -0800)]
Rebaseline for https://codereview.chromium.org/703463002/.

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/709043002

9 years agodocument the SkStrAppend methods
reed [Fri, 7 Nov 2014 15:37:33 +0000 (07:37 -0800)]
document the SkStrAppend methods

BUG=skia:

Review URL: https://codereview.chromium.org/709063002

9 years agoGet gpudft support working in dm, gm, nanobench and bench_pictures
jvanverth [Fri, 7 Nov 2014 15:12:46 +0000 (07:12 -0800)]
Get gpudft support working in dm, gm, nanobench and bench_pictures

Adds a new config to test distance field text.
Clean up some flags and #defines to read "distance field text",
not "distance field fonts" to be consistent with Chromium

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b

Review URL: https://codereview.chromium.org/699453005

9 years agoUpdate SKP version
skia.buildbots [Fri, 7 Nov 2014 14:12:39 +0000 (06:12 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/693583003

9 years agoCleanup: Use SkAutoGraphics in gm and tests.
tfarina [Fri, 7 Nov 2014 14:12:30 +0000 (06:12 -0800)]
Cleanup: Use SkAutoGraphics in gm and tests.

BUG=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/704413002

9 years agoWhen running DM, write test failures to json.
scroggo [Fri, 7 Nov 2014 14:07:32 +0000 (06:07 -0800)]
When running DM, write test failures to json.

Add skiatest::Failure to keep track of data about a test failure.

Reporter::reportFailed and ::onReportFailed now take Failure as a
parameter. This allows the implementation to treat the failure as it
wishes. Provide a helper to format the failure the same as prior to
the change.

Update the macros for calling reportFailed (REPORTER_ASSERT etc) to
create a Failure object.

Convert a direct call to reportFailed to the macro ERRORF.

Write Failures to Json.
Sample output when running dm on the dummy test crrev.com/705723004:
{
   "test_results" : {
      "failures" : [
         {
            "condition" : "0 > 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 10,
            "message" : ""
         },
         {
            "condition" : "false",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 4,
            "message" : ""
         },
         {
            "condition" : "1 == 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 5,
            "message" : "I can too count!"
         },
         {
            "condition" : "",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 6,
            "message" : "seven is 7"
         },
         {
            "condition" : "1 == 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 14,
            "message" : "I can too count!"
         }
      ]
   }
}

Report all of the failures from one test.
Previously, if one test had multiple failures, only one was reportered.
e.g:

Failures:
  test Dummy: ../../tests/DummyTest.cpp:6   seven is 7
  test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3
  test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3
3 failures.

Now, we get all the messages:

Failures:
  test Dummy: ../../tests/DummyTest.cpp:4   false
        ../../tests/DummyTest.cpp:5 I can too count!: 1 == 3
        ../../tests/DummyTest.cpp:6 seven is 7
  test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3
  test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3
3 failures.

(Note that we still state "3 failures" because 3 DM::Tasks failed.)

BUG=skia:3082
BUG=skia:2454

Review URL: https://codereview.chromium.org/694703005

9 years agofor X in {Dec,BigDec,Scalar}, SkWStream::write"X"AsText no longer mallocs
halcanary [Fri, 7 Nov 2014 14:07:23 +0000 (06:07 -0800)]
for X in {Dec,BigDec,Scalar}, SkWStream::write"X"AsText no longer mallocs

Review URL: https://codereview.chromium.org/706063002

9 years agoAdd LOCAL_PICKUP_FILES to dm and bench makefiles.
scroggo [Fri, 7 Nov 2014 14:02:20 +0000 (06:02 -0800)]
Add LOCAL_PICKUP_FILES to dm and bench makefiles.

Update the generator to include a line for LOCAL_PICKUP_FILES. When
generating makefiles for our tests, they will now have the following line:

LOCAL_PICKUP_FILES := \
    $(LOCAL_PATH)/../resources

This allows testing infrastructure to pick up resource files used by
our tests.

Update expectations files to test LOCAL_PICKUP_FILES.

BUG=skia:2454

Review URL: https://codereview.chromium.org/704393002

9 years agoRemove 1d glyph positions from nvpr text
cdalton [Fri, 7 Nov 2014 14:02:15 +0000 (06:02 -0800)]
Remove 1d glyph positions from nvpr text

Removes the case for x-only glyph positions from nvpr text, opting to
always send 2d glyph positions instead. The 1d glyph positions saved a
bit on memory bandwidth, but ended up a net loss because they required
more updates to the view matrix. Now we can draw an entire paragraph
without touching the GL state, whereas before we would have to update
the view matrix at every new line.

BUG=skia:

Review URL: https://codereview.chromium.org/700283002

9 years agoRevert of Get gpudft support working in dm, gm, nanobench and bench_pictures (patchse...
jvanverth [Thu, 6 Nov 2014 21:52:45 +0000 (13:52 -0800)]
Revert of Get gpudft support working in dm, gm, nanobench and bench_pictures (patchset #2 id:20001 of https://codereview.chromium.org/699453005/)

Reason for revert:
Not compiling in ANGLE build

Original issue's description:
> Get gpudft support working in dm, gm, nanobench and bench_pictures
>
> Adds a new config to test distance field text.
> Clean up some flags and #defines to read "distance field text",
> not "distance field fonts" to be consistent with Chromium
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b

TBR=bsalomon@google.com,mtklein@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/707723005

9 years agoGet gpudft support working in dm, gm, nanobench and bench_pictures
jvanverth [Thu, 6 Nov 2014 21:38:52 +0000 (13:38 -0800)]
Get gpudft support working in dm, gm, nanobench and bench_pictures

Adds a new config to test distance field text.
Clean up some flags and #defines to read "distance field text",
not "distance field fonts" to be consistent with Chromium

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/699453005

9 years agoClip in grdrawtarget
joshualitt [Thu, 6 Nov 2014 20:57:13 +0000 (12:57 -0800)]
Clip in grdrawtarget

NOTREECHECKS=true
BUG=skia:

Review URL: https://codereview.chromium.org/685883003

9 years agoRevert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobenc...
mtklein [Thu, 6 Nov 2014 16:06:39 +0000 (08:06 -0800)]
Revert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #1 id:1 of https://codereview.chromium.org/693933004/)

Reason for revert:
Try again with loops overflow fix landed.

Original issue's description:
> Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/)
>
> Reason for revert:
> Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now.
>
> Original issue's description:
> > Turn on NVPR 4x MSAA by default when supported in DM and nanobench.
> >
> > This brings DM and nanobench's default configs in line with GM's.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739
>
> TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14

TBR=bsalomon@google.com,mtklein@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/685923003

9 years agoDetect loops overflow for gpu benches.
mtklein [Thu, 6 Nov 2014 16:04:34 +0000 (08:04 -0800)]
Detect loops overflow for gpu benches.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/709473002

9 years agoSend coverage VA as floats instead of bytes
egdaniel [Thu, 6 Nov 2014 16:00:48 +0000 (08:00 -0800)]
Send coverage VA as floats instead of bytes
NOTREECHECKS=True

BUG=skia:

Review URL: https://codereview.chromium.org/700943005

9 years agoUpdate SKP version
skia.buildbots [Thu, 6 Nov 2014 07:19:12 +0000 (23:19 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/701363002

9 years agoAdd mock context and use in ResourceCacheTest.
bsalomon [Wed, 5 Nov 2014 22:47:41 +0000 (14:47 -0800)]
Add mock context and use in ResourceCacheTest.

BUG=skia:2889

Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30

Review URL: https://codereview.chromium.org/702083003

9 years agoRevert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchs...
egdaniel [Wed, 5 Nov 2014 22:21:33 +0000 (14:21 -0800)]
Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/)

Reason for revert:
Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now.

Original issue's description:
> Turn on NVPR 4x MSAA by default when supported in DM and nanobench.
>
> This brings DM and nanobench's default configs in line with GM's.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739

TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693933004

9 years agoRevert of Add mock context and use in ResourceCacheTest. (patchset #4 id:60001 of...
bsalomon [Wed, 5 Nov 2014 20:30:32 +0000 (12:30 -0800)]
Revert of Add mock context and use in ResourceCacheTest. (patchset #4 id:60001 of https://codereview.chromium.org/702083003/)

Reason for revert:
Breaking tests

Original issue's description:
> Add mock context and use in ResourceCacheTest.
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889

Review URL: https://codereview.chromium.org/704563004

9 years agoTurn on NVPR 4x MSAA by default when supported in DM and nanobench.
mtklein [Wed, 5 Nov 2014 20:28:26 +0000 (12:28 -0800)]
Turn on NVPR 4x MSAA by default when supported in DM and nanobench.

This brings DM and nanobench's default configs in line with GM's.

BUG=skia:

Review URL: https://codereview.chromium.org/704563003

9 years agoAdd mock context and use in ResourceCacheTest.
bsalomon [Wed, 5 Nov 2014 20:09:45 +0000 (12:09 -0800)]
Add mock context and use in ResourceCacheTest.

BUG=skia:2889

Review URL: https://codereview.chromium.org/702083003

9 years agoS4 Rebaselines
bsalomon [Wed, 5 Nov 2014 19:59:25 +0000 (11:59 -0800)]
S4 Rebaselines

TBR=

Review URL: https://codereview.chromium.org/706653003

9 years agoAvoid dec = -dec overflow when appending most negative signed integers.
mtklein [Wed, 5 Nov 2014 19:35:21 +0000 (11:35 -0800)]
Avoid dec = -dec overflow when appending most negative signed integers.

BUG=skia:3096

Review URL: https://codereview.chromium.org/700953003

9 years agoAdd new baselines for remaining dashing5 GM images
robertphillips [Wed, 5 Nov 2014 17:00:22 +0000 (09:00 -0800)]
Add new baselines for remaining dashing5 GM images

This are the baselines for the problem children:
The N5 & N10 gpu images related to Issue 3097
The perspective Windows images

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/702143002

9 years agoRemove gm from ignore expectation file
egdaniel [Wed, 5 Nov 2014 16:57:16 +0000 (08:57 -0800)]
Remove gm from ignore expectation file

No gm's actually changed from my recent change to dashing gm. This was the desired
outcome since the added calls were lines of length zero

TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/706633002

9 years agoAdd baselines for the new dashing5 GM
robertphillips [Wed, 5 Nov 2014 16:25:40 +0000 (08:25 -0800)]
Add baselines for the new dashing5 GM

These are all the correct images

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/707513002

9 years agoAdd unit test for SkDashPathEffect::asPoints' culling
robertphillips [Wed, 5 Nov 2014 16:06:40 +0000 (08:06 -0800)]
Add unit test for SkDashPathEffect::asPoints' culling

This is a follow on to (Crop the fast path dashed lines to the cull rect - https://codereview.chromium.org/699623003/)

Review URL: https://codereview.chromium.org/701133002

9 years agoWhitelist intentionally racy TRACE_EVENT reads and writes.
mtklein [Wed, 5 Nov 2014 16:03:27 +0000 (08:03 -0800)]
Whitelist intentionally racy TRACE_EVENT reads and writes.

Chrome's tracing framework appears to be intentionally racy on its
quick-reject checks, trading some data loss for better performance
when disabled.  People will never notice the data loss, but TSAN does.
Let's assuage TSAN with some annotations.

The 'volatile' val in SK_ANNOTATE_UNPROTECTED_WRITE was making this
not compile, but that volatile doesn't really make sense there: the value we're
writing is not what we care about, it's the destination.

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot

No API changes.
TBR=reed

BUG=skia:

Review URL: https://codereview.chromium.org/702883002

9 years agoRevert of Bisect Mac performance regression. (patchset #6 id:100001 of https://codere...
egdaniel [Wed, 5 Nov 2014 15:40:07 +0000 (07:40 -0800)]
Revert of Bisect Mac performance regression. (patchset #6 id:100001 of https://codereview.chromium.org/693213002/)

Reason for revert:
Block deps roll by breaking webkit test hit-test-counts on mac.

Original issue's description:
> With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance.
>
> BUG=chromium:425566
>
> Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3

TBR=reed@google.com,bungeman@google.com
NOTREECHECKS=true
NOTRY=true
BUG=chromium:425566

Review URL: https://codereview.chromium.org/683753003

9 years agoCleanup: Remove unused InstallNewHandler() function from SkGraphics.
tfarina [Wed, 5 Nov 2014 15:20:51 +0000 (07:20 -0800)]
Cleanup: Remove unused InstallNewHandler() function from SkGraphics.

BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/701813006

9 years agoWorkaround for PowerVR clear issue.
bsalomon [Wed, 5 Nov 2014 15:05:34 +0000 (07:05 -0800)]
Workaround for PowerVR clear issue.

BUG=skia:

Review URL: https://codereview.chromium.org/701573002

9 years agoAdd suppression to valgrind.supp for fun:FcConfigEvaluate.
bungeman [Wed, 5 Nov 2014 14:44:11 +0000 (06:44 -0800)]
Add suppression to valgrind.supp for fun:FcConfigEvaluate.

Any allocation under FcConfigValues will be 'lost'.
Update the valgrind suppression to reflect this.

Review URL: https://codereview.chromium.org/703893003

9 years agoBug fix for cull_line in SkDashPathEffect.
egdaniel [Wed, 5 Nov 2014 13:02:27 +0000 (05:02 -0800)]
Bug fix for cull_line in SkDashPathEffect.

In cull_line we must also check if both points are the same. Otherwise we
fail the assert in the else "SkASSERT(dy && !dx)".

This is currently blocking the roll as it fails a webkit test.

BUG=skia:

Review URL: https://codereview.chromium.org/703783002

9 years agoCrop the fast path dashed lines to the cull rect
robertphillips [Tue, 4 Nov 2014 21:33:50 +0000 (13:33 -0800)]
Crop the fast path dashed lines to the cull rect

Without:

maxrss  loops   min     median  mean    max     stddev  samples         config  bench
  56M   1       13.3ms  13.6ms  13.6ms  14.2ms  2%      Ooooo.....      8888    GM_dashing5_bw
  56M   13      390us   417us   416us   459us   5%      ooooO..o.o      gpu     GM_dashing5_bw
  56M   1       13.4ms  13.9ms  14.1ms  15ms    3%      Oooo..ooOo      8888    GM_dashing5_aa
  56M   13      402us   421us   416us   425us   2%      Ooo.ooOOOO      gpu     GM_dashing5_aa

With:

  40M   1       1.53ms  1.54ms  1.54ms  1.55ms  0%      oo.O...o..      8888    GM_dashing5_bw
  40M   12      407us   412us   415us   445us   3%      ...Oo.....      gpu     GM_dashing5_bw
  40M   1       1.7ms   1.7ms   1.7ms   1.72ms  0%      o.O.......      8888    GM_dashing5_aa
  43M   13      405us   409us   409us   415us   1%      ooo.Ooo..o      gpu     GM_dashing5_aa

The GM images (including the new one) are the same with and without this CL.

BUG=428296

Review URL: https://codereview.chromium.org/699623003

9 years agoDFText: fix placement of glyphs when we fall back to paths
jvanverth [Tue, 4 Nov 2014 21:32:53 +0000 (13:32 -0800)]
DFText: fix placement of glyphs when we fall back to paths

Rendering a glyph with a path wants to place it at the (sx, sy) we get
as input to the method, but we add (dx, dy) for the clipRect check.
Hence, we need to subtract that out before we render the path.

Review URL: https://codereview.chromium.org/699283003

9 years agoupdate slides
reed [Tue, 4 Nov 2014 21:24:47 +0000 (13:24 -0800)]
update slides

BUG=skia:

Review URL: https://codereview.chromium.org/686853005

9 years agoRevert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset...
piotaixr [Tue, 4 Nov 2014 21:21:41 +0000 (13:21 -0800)]
Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset #8 id:140001 of https://codereview.chromium.org/613673005/)

Reason for revert:
The patch is breaking the telemetry blink build on some windows configurations

Original issue's description:
> Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
>
> Depend on https://codereview.chromium.org/663233002
>
> BUG=skia:2947
>
> Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8
>
> Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684

BUG=skia:2947, 426708

Review URL: https://codereview.chromium.org/705633002

9 years agoAdditional baselines for 4b86bacb0428.
bungeman [Tue, 4 Nov 2014 20:28:51 +0000 (15:28 -0500)]
Additional baselines for 4b86bacb0428.

The Nexus9 lacked a trybot at the time.

9 years agoAdd tracing to the SkCanvas drawFoo() methods to find long draw ops.
danakj [Tue, 4 Nov 2014 19:48:43 +0000 (11:48 -0800)]
Add tracing to the SkCanvas drawFoo() methods to find long draw ops.

BUG=skia:3088

Review URL: https://codereview.chromium.org/702473004

9 years agoPictureRecordBench's benchmarks are no longer relevant with SkRecord.
mtklein [Tue, 4 Nov 2014 19:14:48 +0000 (11:14 -0800)]
PictureRecordBench's benchmarks are no longer relevant with SkRecord.

BUG=skia:

Review URL: https://codereview.chromium.org/698163004

9 years agoadd more typeface methods to lua
reed [Tue, 4 Nov 2014 18:58:42 +0000 (10:58 -0800)]
add more typeface methods to lua

BUG=skia:
NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/697053004

9 years agoAllow all font weights on Android and respect overrides.
bungeman [Tue, 4 Nov 2014 18:54:31 +0000 (10:54 -0800)]
Allow all font weights on Android and respect overrides.

This removes the code which forces 400 and 700 weights only,
and also overrides the font weight with the configured weight.

Review URL: https://codereview.chromium.org/694533006

9 years agoWith https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a2...
bungeman [Tue, 4 Nov 2014 18:27:35 +0000 (10:27 -0800)]
With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance.

BUG=chromium:425566

Review URL: https://codereview.chromium.org/693213002

9 years agoFix PictureTest for new GPU veto
jvanverth [Tue, 4 Nov 2014 16:50:15 +0000 (08:50 -0800)]
Fix PictureTest for new GPU veto

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/702733002

9 years agoInclude SkTypes so that SK_SUPPORT_GPU is meaningful.
scroggo [Tue, 4 Nov 2014 16:11:07 +0000 (08:11 -0800)]
Include SkTypes so that SK_SUPPORT_GPU is meaningful.

For the Android framework build, we get our defines from
SkUserConfig, rather than from the makefile, so we need to
include it (via SkTypes) before we can use our defines.

Fixes Android framework build.

Review URL: https://codereview.chromium.org/700893002

9 years agoEnable distance field path rendering in Chrome.
jvanverth [Tue, 4 Nov 2014 15:59:01 +0000 (07:59 -0800)]
Enable distance field path rendering in Chrome.

- Add stat tracking for df-renderable paths
- Modify GPU rasterization veto to account for df-renderable paths
- Remove #define hiding df paths from Chromium and Android

BUG=skia:2935

Review URL: https://codereview.chromium.org/685113003

9 years agoRoll common to d7c2e2b9464.
bungeman [Tue, 4 Nov 2014 15:55:41 +0000 (07:55 -0800)]
Roll common to d7c2e2b9464.

Picks up code removal and changes to download_file.

https://skia.googlesource.com/common.git/+log/5eee100ab..d7c2e2b9464

Review URL: https://codereview.chromium.org/700763003

9 years agoremoving setVertexArraySource from drawtarget
joshualitt [Tue, 4 Nov 2014 15:47:55 +0000 (07:47 -0800)]
removing setVertexArraySource from drawtarget

BUG=skia:

Review URL: https://codereview.chromium.org/699733002

9 years agoSeparate JSON functions from DMWriteTask.
scroggo [Tue, 4 Nov 2014 15:21:10 +0000 (07:21 -0800)]
Separate JSON functions from DMWriteTask.

Add JsonWriter, which handles Json output from DM, in preparation for
adding json output for tests. This change should not affect behavior.

BUG=skia:2454

Review URL: https://codereview.chromium.org/702513003

9 years agoFix layer cache memory leak
robertphillips [Tue, 4 Nov 2014 14:46:11 +0000 (06:46 -0800)]
Fix layer cache memory leak

The issue was that, with caching disabled, the layer cache code was removing layers outside of a purge (i.e., in unlock) but not correctly cleaning up the GrPictureInfo objects (as is done in purgePlot).

Review URL: https://codereview.chromium.org/703643002

9 years agoremove dead SK_DISABLE_DASHING_OPTIMIZATION flag
reed [Tue, 4 Nov 2014 13:17:39 +0000 (05:17 -0800)]
remove dead SK_DISABLE_DASHING_OPTIMIZATION flag

BUG=skia:

Review URL: https://codereview.chromium.org/698003004

9 years agoUpdate SKP version
skia.buildbots [Tue, 4 Nov 2014 07:13:10 +0000 (23:13 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/698223002

9 years agoupdate slide content
reed [Tue, 4 Nov 2014 06:32:07 +0000 (22:32 -0800)]
update slide content

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/698563004

9 years agoadd textblobs to lua
reed [Tue, 4 Nov 2014 03:55:41 +0000 (19:55 -0800)]
add textblobs to lua

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/688363003

9 years agoupdate baselines and ignores for texture_domain
joshualitt [Tue, 4 Nov 2014 01:47:47 +0000 (17:47 -0800)]
update baselines and ignores for texture_domain

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/697233003

9 years agoTurn SkTaskGroups back on.
mtklein [Tue, 4 Nov 2014 01:41:08 +0000 (17:41 -0800)]
Turn SkTaskGroups back on.

Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."

NOTREECHECKS=true

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

Review URL: https://codereview.chromium.org/687263007

9 years agoManually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).
mtklein [Tue, 4 Nov 2014 01:25:54 +0000 (17:25 -0800)]
Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).

Tested by running DM on XP.  Before this patch, it fails at startup (even just out/Debug/dm --help).  Now it asserts for other reasons later on in user code, which is just fine by me.

The net effect is that SkTaskGroups will always be synchronous on XP.  That's not ideal, but a step up from crashing.

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot

BUG=skia:

Review URL: https://codereview.chromium.org/700683002

9 years agoExport (SK_API) SkSurfaceProps
fmalita [Tue, 4 Nov 2014 01:07:35 +0000 (17:07 -0800)]
Export (SK_API) SkSurfaceProps

R=reed@google.com

Review URL: https://codereview.chromium.org/693973003

9 years agoCleanup: Remove SimpleiOSApp xcode project file.
tfarina [Mon, 3 Nov 2014 23:10:49 +0000 (15:10 -0800)]
Cleanup: Remove SimpleiOSApp xcode project file.

There is already an GYP version for it in:
https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp

BUG=None
TEST=None
R=caryclark@google.com

Review URL: https://codereview.chromium.org/691133004

9 years agomove SkTextBox into utils
reed [Mon, 3 Nov 2014 22:55:40 +0000 (14:55 -0800)]
move SkTextBox into utils

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/696293005

9 years agoOptimize SkRect::sort()
qiankun.miao [Mon, 3 Nov 2014 22:34:30 +0000 (14:34 -0800)]
Optimize SkRect::sort()

This optimization can reduce comparison and assignments. For
geo_rect_sort benchmark, performance improved to 1.63us from 3.28us.

BUG=skia:

Review URL: https://codereview.chromium.org/695443005

9 years agoRename and clarify semantics of GrContext::resolveRenderTarget.
bsalomon [Mon, 3 Nov 2014 22:28:32 +0000 (14:28 -0800)]
Rename and clarify semantics of GrContext::resolveRenderTarget.

Review URL: https://codereview.chromium.org/696293004

9 years agoTemporary fix to remove drawrect call from GpuGL
joshualitt [Mon, 3 Nov 2014 22:16:35 +0000 (14:16 -0800)]
Temporary fix to remove drawrect call from GpuGL

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

Review URL: https://codereview.chromium.org/694933002

9 years agoImprove quality of distance field rendering
jvanverth [Mon, 3 Nov 2014 22:00:24 +0000 (14:00 -0800)]
Improve quality of distance field rendering
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs

BUG=skia:2933,skia:2935

Review URL: https://codereview.chromium.org/703463002

9 years agoDetect Mesa OpenGL ES
derekf [Mon, 3 Nov 2014 21:36:40 +0000 (13:36 -0800)]
Detect Mesa OpenGL ES

Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/700633002

9 years agoRevert changes to GrContext::resolveRenderTarget
bsalomon [Mon, 3 Nov 2014 21:32:00 +0000 (13:32 -0800)]
Revert changes to GrContext::resolveRenderTarget

TBR=joshualitt@google.com,egdaniel@google.com

Review URL: https://codereview.chromium.org/700483003

9 years agoAdd comments to SkRecordDraw to help people follow.
danakj [Mon, 3 Nov 2014 20:43:30 +0000 (12:43 -0800)]
Add comments to SkRecordDraw to help people follow.

The calls to visit() to execute the SkRecord::Draw::operator() code path
is not clear to read, so adding some comments to help other new-comers
follow this through to the SkCanvas calls.

R=mtklein@chromium.org

Review URL: https://codereview.chromium.org/695403003

9 years agoTest factory uses the inorder draw buffer
joshualitt [Mon, 3 Nov 2014 20:31:14 +0000 (12:31 -0800)]
Test factory uses the inorder draw buffer

BUG=skia:

Review URL: https://codereview.chromium.org/696353002

9 years agoadd bullets to slides
reed [Mon, 3 Nov 2014 20:18:24 +0000 (12:18 -0800)]
add bullets to slides

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/699723002

9 years agoDon't allow renderTarget==NULL to GrContext::clear() and friends.
bsalomon [Mon, 3 Nov 2014 20:08:42 +0000 (12:08 -0800)]
Don't allow renderTarget==NULL to GrContext::clear() and friends.

Review URL: https://codereview.chromium.org/680413005

9 years agorebase and ignore dash cubics winnvpr
joshualitt [Mon, 3 Nov 2014 20:03:06 +0000 (12:03 -0800)]
rebase and ignore dash cubics winnvpr

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691803005

9 years agorelease expectations rebase
joshualitt [Mon, 3 Nov 2014 19:36:40 +0000 (11:36 -0800)]
release expectations rebase
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/700613002

9 years agorebase nvpr expectations
joshualitt [Mon, 3 Nov 2014 19:14:25 +0000 (11:14 -0800)]
rebase nvpr expectations

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/688413004

9 years agoRemove GrGLTexID
bsalomon [Mon, 3 Nov 2014 19:07:12 +0000 (11:07 -0800)]
Remove GrGLTexID

BUG=skia:2889

Review URL: https://codereview.chromium.org/695133003

9 years agoignoring degenerat segments across all nvprm
joshualitt [Mon, 3 Nov 2014 18:51:42 +0000 (10:51 -0800)]
ignoring degenerat segments across all nvprm
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/696373002

9 years agopatch from issue 697743002
mtklein [Mon, 3 Nov 2014 18:45:50 +0000 (10:45 -0800)]
patch from issue 697743002
working

The key here was to get everything into a single library.  Our shared library build is the easiest way to do that.  Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too.

BUG=skia:

Review URL: https://codereview.chromium.org/698943002

9 years agoForce input coverage to be only a byte in gpu shaders.
egdaniel [Mon, 3 Nov 2014 18:07:07 +0000 (10:07 -0800)]
Force input coverage to be only a byte in gpu shaders.

Prime coverage invariant output calculations with single component

BUG=skia:

Review URL: https://codereview.chromium.org/649783003

9 years agoAdd class GrGLTextureRenderTarget for GL texture/rendertarget objects
bsalomon [Mon, 3 Nov 2014 16:47:23 +0000 (08:47 -0800)]
Add class GrGLTextureRenderTarget for GL texture/rendertarget objects

BUG=skia:2889

Review URL: https://codereview.chromium.org/695813003

9 years agoCleanup: Remove svn.py script.
tfarina [Mon, 3 Nov 2014 16:33:53 +0000 (08:33 -0800)]
Cleanup: Remove svn.py script.

We have moved on to a git world.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/691203002

9 years agoCleanup: Remove unnecessary forward declarations from some views files.
tfarina [Mon, 3 Nov 2014 16:31:23 +0000 (08:31 -0800)]
Cleanup: Remove unnecessary forward declarations from some views files.

Cautch in
https://skia.googlesource.com/skia/+/a3a706fcd4cc9376a1223a53f57589f29d4a36ea

BUG=None
TEST=None
R=djsollen@google.com

Review URL: https://codereview.chromium.org/680253004

9 years agoRebaselines for new colortype-xfermodes gm
egdaniel [Mon, 3 Nov 2014 16:26:28 +0000 (08:26 -0800)]
Rebaselines for new colortype-xfermodes gm

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/695343002