John Ericson [Thu, 4 Nov 2021 02:09:30 +0000 (02:09 +0000)]
Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""
This reverts commit
797b50d4be873b4662983413a06806fca544c276.
See the original D99484. @mib who noticed the original problem could not longer
reproduce it, after I tried and also failed. We are threfore hoping it went
away on its own!
Reviewed By: mib
Differential Revision: https://reviews.llvm.org/D115544
Joseph Huber [Fri, 10 Dec 2021 20:56:55 +0000 (15:56 -0500)]
Revert "[OpenMP] Avoid costly shadow map traversals whenever possible"
This reverts commit
7c8f4e7b85ed98497f37571d72609f39a8eed447.
Fails a few OpenMP tests, causes a few updates to segfault.
Jonathan Peyton [Tue, 30 Nov 2021 22:43:47 +0000 (16:43 -0600)]
[OpenMP][libomp] Add core attributes to KMP_HW_SUBSET
Allow filtering of resources based on core attributes. There are two new
attributes added:
1) Core Type (intel_atom, intel_core)
2) Core Efficiency (integer) where the higher the efficiency, the more
performant the core
On hybrid architectures , e.g., Alder Lake, users can specify
KMP_HW_SUBSET=4c:intel_atom,4c:intel_core to select the first four Atom
and first four Big cores. The can also use the efficiency syntax. e.g.,
KMP_HW_SUBSET=2c:eff0,2c:eff1
Differential Revision: https://reviews.llvm.org/D114901
Michael Liao [Fri, 10 Dec 2021 19:21:30 +0000 (14:21 -0500)]
Fix shared build of unittests.
Sami Tolvanen [Fri, 10 Dec 2021 19:11:28 +0000 (11:11 -0800)]
[ThinLTO][MC] Use conditional assignments for promotion aliases
Inline assembly refererences to static functions with ThinLTO+CFI were
fixed in D104058 by creating aliases for promoted functions. Creating
the aliases unconditionally resulted in an unexpected size increase in
a Chrome helper binary:
https://bugs.chromium.org/p/chromium/issues/detail?id=1261715
This is caused by the compiler being unable to drop unused code now
referenced by the alias in module-level inline assembly. This change
adds a .set_conditional assembly extension, which emits an assignment
only if the target symbol is also emitted, avoiding phantom references
to functions that could have otherwise been dropped.
This is an alternative to the solution proposed in D112761.
Reviewed By: pcc, nickdesaulniers, MaskRay
Differential Revision: https://reviews.llvm.org/D113613
Augie Fackler [Fri, 10 Dec 2021 20:17:18 +0000 (12:17 -0800)]
Verifier: accept enums as scopes
Rust allows enums to be scopes, as shown by the previous change. Sadly,
D111770 disallowed enums-as-scopes in the LLVM Verifier, which means
that LLVM HEAD stopped working for Rust compiles. As a result, we back
out the verifier part of D111770 with a modification to the testcase so
we don't break this in the future.
The testcase is now actual IR from rustc at commit
8f8092cc3, which is
the nightly as of 2021-09-28. I would expect rustc 1.57 to produce
similar or identical IR if someone wants to reproduce this IR in the
future with minimal changes. A recipe for reproducing the IR using rustc
is included in the test file.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D115353
LLVM GN Syncbot [Fri, 10 Dec 2021 19:52:50 +0000 (19:52 +0000)]
[gn build] Port
04f2712ef4e4
Florian Mayer [Fri, 10 Dec 2021 19:52:26 +0000 (11:52 -0800)]
Revert "[sanitizers] include build ids in stacks on linux."
This reverts commit
2a31b240df1ce1724960fd7cf98f673064b44206.
River Riddle [Fri, 10 Dec 2021 19:36:21 +0000 (19:36 +0000)]
[mlir:PDL] Allow non-bound pdl.attribute/pdl.type operations that create constants
This allows for passing in these attributes/types to constraints/rewrites as arguments.
Differential Revision: https://reviews.llvm.org/D114817
River Riddle [Fri, 10 Dec 2021 19:36:07 +0000 (19:36 +0000)]
[mlir:PDL] Fix bugs in PDLPatternModule merging
* Constraints/Rewrites registered before a pattern was added were dropped
* Constraints/Rewrites may be registered multiple times (if different pattern sets depend on them)
* ModuleOp no longer has a terminator, so we shouldn't be removing the terminator from it
Differential Revision: https://reviews.llvm.org/D114816
River Riddle [Fri, 10 Dec 2021 19:35:55 +0000 (19:35 +0000)]
[mlir:PDL] Adjust the assembly format for AttributeOp to avoid conflicts with DictionaryAttr
Switch the attribute creation operations to use attr-dict-with-
keyword to avoid conflicts (in the case of pdl.attribute) and
confusion(in the case of pdl_interp.create_attribute) with
having a DictionaryAttr as a value and specifying the
attributes of the operation itself (as a dictionary).
Differential Revision: https://reviews.llvm.org/D114815
River Riddle [Fri, 10 Dec 2021 19:35:43 +0000 (19:35 +0000)]
[mlir:PDL] Fix assembly format for pdl.apply_native_rewrite
The results of a rewrite are optional, but we currently require
them to be present in the assembly format. This commit
makes the results component in the format optional.
Differential Revision: https://reviews.llvm.org/D114814
Mogball [Fri, 10 Dec 2021 15:04:46 +0000 (15:04 +0000)]
[mlir][ods] Fix OpFormatGen sometimes not calling inferReturnTypes
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D115522
Mogball [Fri, 10 Dec 2021 13:30:11 +0000 (13:30 +0000)]
[mlir][ir] OpRewritePattern should accept generatedNames
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D115514
Mogball [Fri, 10 Dec 2021 00:47:48 +0000 (00:47 +0000)]
[mlir][ir] Custom ops' parse/print fall back to dialect hooks
Custom ops that have no parser or printer should fall back to the dialect's parser and/or printer hooks. This avoids the need to define parsers and printers that simply dispatch to the dialect hook.
Reviewed By: mehdi_amini, rriddle
Differential Revision: https://reviews.llvm.org/D115481
Joseph Huber [Fri, 10 Dec 2021 17:49:59 +0000 (12:49 -0500)]
[OpenMP] Avoid costly shadow map traversals whenever possible
In the OpenMC app we saw `omp target update` spending an awful lot of
time in the shadow map traversal without ever doing any update there.
There are two cases that allow us to avoid the traversal completely.
The simplest thing is that small updates cannot (reasonably) contain
an attached pointer part. The other case requires to track in the
mapping table if an entry might contain an attached pointer as part.
Given that we have a single location shadow map entries are created,
the latter is actually fairly easy as well.
Reviewed By: grokos
Differential Revision: https://reviews.llvm.org/D113124
Florian Mayer [Thu, 18 Nov 2021 03:50:33 +0000 (19:50 -0800)]
[sanitizers] include build ids in stacks on linux.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D114294
Duncan P. N. Exon Smith [Fri, 10 Dec 2021 02:57:38 +0000 (18:57 -0800)]
utils: Remove some no-op raw_string_ostream flush calls, NFC
Since
65b13610a5226b84889b923bae884ba395ad084d, raw_string_ostream has
been unbuffered by default. Based on an audit of llvm/utils/, this
commit removes every call to `raw_string_ostream::flush()` and any call
to `raw_string_ostream::str()` whose result is ignored or that doesn't
help with clarity.
I left behind a few calls to `str()`. In these cases, the underlying
std::string was declared pretty far away and never used again, whereas
stream recently had its last write. The code is easier to read as-is;
the no-op call to `flush()` inside `str()` isn't harmful, and when
https://reviews.llvm.org/D115421 lands it'll be gone anyway.
Mircea Trofin [Thu, 9 Dec 2021 20:56:16 +0000 (12:56 -0800)]
[NFC][MLGO] Factor ModelUnderTrainingRunner for reuse
This is so we may reuse it. It was very non-inliner specific already.
Differential Revision: https://reviews.llvm.org/D115465
Carlo Bertolli [Fri, 10 Dec 2021 19:10:53 +0000 (19:10 +0000)]
[OpenMP] Part 2 of At present, amdgpu plugin merges both asynchronous
and synchronous kernel launch implementations into a single
synchronous version. This patch prepares the plugin for asynchronous
implementation by:
Privatizing actual kernel launch code (valid in both cases) into
an anonymous namespace base function (submitted at D115267)
- Separating the control flow path of asynchronous and synchronous
kernel launch functions** (this diff)
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D115273
LLVM GN Syncbot [Fri, 10 Dec 2021 18:58:26 +0000 (18:58 +0000)]
[gn build] Port
d25a65030bc1
Jayson Yan [Fri, 10 Dec 2021 18:46:55 +0000 (18:46 +0000)]
[llvm-readobj] Add JSONScopedPrinter to llvm-readelf
Adds JSONScopedPrinter to llvm-readelf. It includes an empty
JSONELFDumper class which will be used to override any LLVMELFDumper
methods which utilize startLine() which JSONScopedPrinter cannot
provide.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114225
Jayson Yan [Fri, 10 Dec 2021 18:44:45 +0000 (18:44 +0000)]
[llvm] Add JSONScopedPrinter class
This change adds a JSONScopedPrinter as a subclass to ScopedPrinter.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114224
Jayson Yan [Fri, 10 Dec 2021 18:35:11 +0000 (18:35 +0000)]
[llvm] Add ScopedPrinter unit tests
Add unit tests for the ScopedPrinter class.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114684
Jayson Yan [Fri, 10 Dec 2021 18:29:09 +0000 (18:29 +0000)]
[NFC] Move printNumber method
Move printNumber(StringRef Label, StringRef Str, T Value) to
be with the rest of the printNumber(...) methods.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114741
Jayson Yan [Fri, 10 Dec 2021 18:14:53 +0000 (18:14 +0000)]
[NFC] Remove unneeded printString methods
Both std::string and char * implicitly convert to StringRef so
the overloaded method using std::string and char* are unneeded.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114740
Jayson Yan [Fri, 10 Dec 2021 17:45:40 +0000 (17:45 +0000)]
[llvm] Make ScopedPrinter interface virtual
Make the interface provided by ScopedPrinter virtual to support a future
JSONScopedPrinter which will supply it's own implementation.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D114223
Simon Pilgrim [Fri, 10 Dec 2021 17:30:27 +0000 (17:30 +0000)]
[MCA][X86] Add missing VPMOVSX/VPMOVZX from AVX512 tests
Joel E. Denny [Fri, 10 Dec 2021 17:07:31 +0000 (12:07 -0500)]
[OpenMP] Add test for custom state machine if have reduction
D113602 broke the custom state machine when a reduction is present, as
revealed by the reproducer this patch adds to the test suite. In that
case, openmp-opts changes the return value to undef in
`__kmpc_get_warp_size` (which the custom state machine calls as of
D113602). Later optimizations then optimize away the custom state
machine code as if all threads are outside the thread block, so the
target region does not execute. D114802 fixed that but didn't add a
reproducer.
This patch also adds a `__OMP_RTL_ATTRS` entry for
`__kmpc_get_warp_size` to OMPKinds.def, which D113602 missed. This
change does not seem to have any impact on the reduction problem.
Reviewed By: JonChesterfield, jdoerfert
Differential Revision: https://reviews.llvm.org/D113824
Craig Topper [Fri, 10 Dec 2021 17:27:13 +0000 (09:27 -0800)]
[RISCV] Share tablegen classes for F, D, and Zfh. Other simplifications. NFC
By adding the register class and funct as template parameters we
can share the classes with all 3 extensions.
I've used "let SchedRW =" to avoid repeating scheduler classes on
multiple lines where we previously inherited from the Sched class.
A subsequent patch will add mayRaiseFPException and FRM dependencies.
Reducing the number of classes means less repeating for those changes.
This of course conflicts with the Zfinx patch D93298.
Reviewed By: achieveartificialintelligence
Differential Revision: https://reviews.llvm.org/D115469
Adrian Prantl [Fri, 10 Dec 2021 17:15:54 +0000 (09:15 -0800)]
[DwarfDebug] Refuse to emit DW_OP_LLVM_arg values wider than 64 bits
DwarfExpression::addUnsignedConstant(const APInt &Value) only supports
wider-than-64-bit values when it is used to emit a top-level DWARF
expression representing the location of a variable. Before this change,
it was possible to call addUnsignedConstant on >64 bit values within a
subexpression when substituting DW_OP_LLVM_arg values.
This can trigger an assertion failure (e.g. PR52584, PR52333) when it
happens in a fragment (DW_OP_LLVM_fragment) expression, as
addUnsignedConstant on >64 bit values splits the constant into separate
DW_OP_pieces, which modifies DwarfExpression::OffsetInBits.
This change papers over the assertion errors by bailing on overly wide
DW_OP_LLVM_arg values. A more comprehensive fix might be to be to split
wide values into pointer-sized fragments.
[0] https://github.com/llvm/llvm-project/blob/e71fa03/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp#L799-L805
Patch by Ricky Zhou!
Differential Revision: https://reviews.llvm.org/D115343
Craig Topper [Fri, 10 Dec 2021 17:20:40 +0000 (09:20 -0800)]
[RISCV] Remove FCSR from RISCVRegisterInfo.
We only used this to mark it as a reserved register. But that's not
important if we don't do anything else with it.
I think if we were ever to do anything with it, we would need to
model it as a super register of FRM and FFLAGS. But it might be
easier to reference both FRM and FFLAGS in implicit defs/uses
for anything we were to do with "fcsr".
Reviewed By: sepavloff
Differential Revision: https://reviews.llvm.org/D115455
Zakk Chen [Thu, 4 Nov 2021 17:13:50 +0000 (10:13 -0700)]
[RISCV][Clang] Compute the default target-abi if it's empty.
Every generated IR has a corresponding target-abi value, so
encoding a non-empty value would improve the robustness and
correctness.
Reviewed By: asb, jrtc27, arichardson
Differential Revision: https://reviews.llvm.org/D105555
Kazu Hirata [Fri, 10 Dec 2021 16:53:14 +0000 (08:53 -0800)]
[Support] Use range-based for loops (NFC)
Denys Petrov [Thu, 18 Nov 2021 14:06:06 +0000 (16:06 +0200)]
[analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency
Summary: Handle intersected and adjacent ranges uniting them into a single one.
Example:
intersection [0, 10] U [5, 20] = [0, 20]
adjacency [0, 10] U [11, 20] = [0, 20]
Differential Revision: https://reviews.llvm.org/D99797
Kazu Hirata [Fri, 10 Dec 2021 16:33:07 +0000 (08:33 -0800)]
[AArch64] Fix a warning
This patch fixes:
llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:315:7:
error: unused variable 'ValTy' [-Werror,-Wunused-variable]
Nikita Popov [Fri, 10 Dec 2021 11:32:05 +0000 (12:32 +0100)]
[IR] Extract method to get single GEP index from offset (NFC)
This exposes the core logic of getGEPIndicesForOffset() as a
getGEPIndexForOffset() method that only returns a single offset,
instead of following the whole chain.
Nico Weber [Fri, 10 Dec 2021 16:05:59 +0000 (11:05 -0500)]
Revert "[clang][dataflow] Add framework for testing analyses."
Doesn't build on Windows.
This reverts commit
5a40df6381819b38df66e4b6eaa02e7140e07a0c
and commit
db494bd4e815bc5546ee0986cb738da1a54bf6ab.
Simon Pilgrim [Fri, 10 Dec 2021 15:59:36 +0000 (15:59 +0000)]
[MCA][X86] Add missing ALIGND/ALIGNQ from AVX512F/AVX512VL tests
Simon Pilgrim [Fri, 10 Dec 2021 15:33:20 +0000 (15:33 +0000)]
[MCA][X86] Add missing PALIGNR from AVX512BW/AVX512BWVL tests
Simon Pilgrim [Fri, 10 Dec 2021 15:27:52 +0000 (15:27 +0000)]
[MCA][X86] Add missing PSLLDQ/PSRLDQ from AVX512BW/AVX512BWVL tests
Simon Pilgrim [Fri, 10 Dec 2021 15:18:30 +0000 (15:18 +0000)]
[MCA][X86] Add missing PACKSS/PACKUS from AVX512BW/AVX512BWVL tests
Paul Robinson [Fri, 10 Dec 2021 15:54:17 +0000 (07:54 -0800)]
Verify inferattrs doesn't infer unexpected attributes
Add --match-full-lines or `{{$}}` to ensure that no unexpected
attributes appear at the ends of lines. Account for the cases
where attributes were in fact appearing.
Differential Revision: https://reviews.llvm.org/D110720
David Green [Fri, 10 Dec 2021 15:40:58 +0000 (15:40 +0000)]
[LV][ARM] Improve reduction costmodel for mismatching extension types.
Given a MLA reduction from two different types (say i8 and i16), we were
previously failing to find the reduction pattern, often making us chose
the lower vector factor. This improves that by using the largest of the
two extension types, allowing us to use the larger VF as the type of the
reduction.
As per https://godbolt.org/z/KP549EEYM the backend handles this
valiantly, leading to better performance.
Differential Revision: https://reviews.llvm.org/D115432
Nikita Popov [Fri, 10 Dec 2021 15:37:49 +0000 (16:37 +0100)]
[ConstantFold] Handle same type in ConstantFoldLoadThroughBitcast
Usually the case where the types are the same ends up being handled
fine because it's legal to do a trivial bitcast to the same type.
However, this is not true for aggregate types. Short-circuit the
whole code if the types match exactly to account for this.
Nico Weber [Fri, 10 Dec 2021 15:39:28 +0000 (10:39 -0500)]
[gn build] (semimanually) port
ebc31d2e7297
Nico Weber [Fri, 10 Dec 2021 15:34:07 +0000 (10:34 -0500)]
[gn build] Port
5a40df638181
Kirill Stoimenov [Fri, 10 Dec 2021 15:08:26 +0000 (15:08 +0000)]
[ASan] Shared optimized callbacks implementation.
This change moves optimized callbacks from each .o file to compiler-rt. Instead of using code generation it uses direct assembly implementation. Please note that the 'or' version is not implemented and it will produce unresolved external if somehow 'or' version is requested.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D114558
Nico Weber [Fri, 10 Dec 2021 15:26:55 +0000 (10:26 -0500)]
Revert "[Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer."
This reverts commit
5bba0fe12b2971a9cbc859f48ee6e6c1356c88b8.
Makes lld depend on libcurl, see comments on https://reviews.llvm.org/D113717
Yitzhak Mandelbaum [Tue, 16 Nov 2021 16:57:26 +0000 (16:57 +0000)]
[clang][dataflow] Add framework for testing analyses.
Adds a general-purpose framework to support testing of dataflow analyses.
Differential Revision: https://reviews.llvm.org/D115341
Nikita Popov [Fri, 10 Dec 2021 15:11:32 +0000 (16:11 +0100)]
[InstSimplify] Add test for load of aggregate (NFC)
The test is switched to use -instsimplify as it is in the
InstSimplify directory. In this particular case InstCombine does
fold the load (in a very roundabout way), but InstSimplify does not.
Nikita Popov [Thu, 9 Dec 2021 15:23:39 +0000 (16:23 +0100)]
[GlobalOpt] Add test for PR51879 (NFC)
Archibald Elliott [Fri, 10 Dec 2021 15:09:43 +0000 (15:09 +0000)]
[AArch64] Use Feature for A53 Erratum 835769 Fix
When this pass was originally implemented, the fix pass was enabled
using a llvm command-line flag. This works fine, except in the case of
LTO, where the flag is not passed into the linker plugin in order to
enable the function pass in the LTO backend.
Now LTO exists, the expectation now is to use target features rather
than command-line arguments to control code generation, as this ensures
that different command-line arguments in different files are correctly
represented, and target-features always get to the LTO plugin as they
are encoded into LLVM IR.
The fall-out of this change is that the fix pass has to always be added
to the backend pass pipeline, so now it makes no changes if the function
does not have the right target feature to enable it. This should make a
minimal difference to compile time.
One advantage is it's now much easier to enable when compiling for a
Cortex-A53, as CPUs imply their own individual sets of target-features,
in a more fine-grained way. I haven't done this yet, but it is an
option, if the fix should be enabled in more places.
Existing tests of the user interface are unaffected, the changes are to
reflect that the argument is now turned into a target feature.
Reviewed By: tmatheson
Differential Revision: https://reviews.llvm.org/D114703
Yitzhak Mandelbaum [Fri, 10 Dec 2021 14:27:15 +0000 (14:27 +0000)]
Revert "[clang][dataflow] Add framework for testing analyses."
This reverts commit
47d526d67e3cc66771eed1d0b607226a4fb9a5b5.
The commit is failing to build on some platforms. Rolling back while we investigate.
Min-Yih Hsu [Fri, 10 Dec 2021 14:02:15 +0000 (22:02 +0800)]
[M68k][NFC] Fixed unused argument warnings in M68kInstrControl.td
Removed those unused template arguments. NFC.
Simon Pilgrim [Fri, 10 Dec 2021 14:02:19 +0000 (14:02 +0000)]
[MCA][X86] Add missing PSHUFLW from AVX512BWVL tests
Yitzhak Mandelbaum [Tue, 16 Nov 2021 16:57:26 +0000 (16:57 +0000)]
[clang][dataflow] Add framework for testing analyses.
Adds a general-purpose framework to support testing of dataflow analyses.
Differential Revision: https://reviews.llvm.org/D115341
Florian Hahn [Fri, 10 Dec 2021 13:56:43 +0000 (13:56 +0000)]
[LV] Remove redundant IV casts using VPlan (NFCI).
This patch simplifies handling of redundant induction casts, by
removing dead cast instructions after initial VPlan construction.
This has the following benefits:
1. fixes a crash
(see @test_optimized_cast_induction_feeding_first_order_recurrence)
2. Simplifies VPWidenIntOrFpInduction to a single-def recipes
3. Retires recordVectorLoopValueForInductionCast.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D115112
Nico Weber [Fri, 10 Dec 2021 13:54:17 +0000 (08:54 -0500)]
[gn build] Prevent deps on HTTP requests in clang and lld at GN time
To make sure no regressions creep in. See also discussion on
https://reviews.llvm.org/D113717
We don't want this dep in most targets, but protecting clang and lld is
a good start.
David Sherwood [Tue, 7 Dec 2021 14:13:55 +0000 (14:13 +0000)]
[CodeGen] Improve SelectionDAGBuilder lowering code for get.active.lane.mask intrinsic
Previously we were using UADDO to generate a two-result value with
the unsigned addition and the overflow mask. We then combined the
overflow mask with the trip count comparison to get a result.
However, we don't need to do this - we can simply use a UADDSAT
saturating add node to add the vector index splat and the stepvector
together. Then we can just compare this to a splat of the trip count.
This results in overall better code quality for both Thumb2 and AArch64.
Differential Revision: https://reviews.llvm.org/D115354
Brian Cain [Thu, 9 Dec 2021 01:57:20 +0000 (17:57 -0800)]
Reapply [xray] add support for hexagon
Adds x-ray support for hexagon to llvm codegen, clang driver,
compiler-rt libs.
Differential Revision: https://reviews.llvm.org/D113638
Reapplying this after
543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45,
which fixes the leak introduced there.
AndreyChurbanov [Fri, 10 Dec 2021 13:23:21 +0000 (16:23 +0300)]
[OpenMP] libomp: fix Fortran header: lines exceeded 72-char length
Added line continuation to two long lines in Fortran header.
Differential Revision: https://reviews.llvm.org/D114537
Yitzhak Mandelbaum [Fri, 10 Dec 2021 12:55:48 +0000 (12:55 +0000)]
[clang][dataflow] Fix build breakage from commit
8dcaf3aa0bf25508700a7452ed963c1487221dfd
Nico Weber [Fri, 10 Dec 2021 12:49:25 +0000 (07:49 -0500)]
[gn build] (manually) port
8dcaf3aa0bf25 and
6e2aecd759dc
Konstantin Boyarinov [Fri, 10 Dec 2021 12:00:10 +0000 (15:00 +0300)]
[libcxx][test][NFC] Extend testing for vector.cons
Extending std::vector tests in vector.cons module:
- std::vector::assign when source range is bigger than destination
capacity
- construction of empty vector using copy ctor, initializer_list ctor and
others
Reviewed By: ldionne, rarutyun, #libc
Differential Revision: https://reviews.llvm.org/D114954
Kadir Cetinkaya [Thu, 9 Dec 2021 08:36:04 +0000 (09:36 +0100)]
[clangd] Provide documentation as MarkupContent in signaturehelp
This unifies the behaviour we have in code completion item
documentations and signaturehelp. Providing better line wrapping and detection
of inline code blocks in comments to be renedered appropriately in markdown.
Differential Revision: https://reviews.llvm.org/D115442
Ties Stuij [Fri, 10 Dec 2021 11:52:09 +0000 (11:52 +0000)]
Add PACBTI-M support to LLVM release notes.
Clang release note changes will be added once the last PACBTI-M command line
patch lands.
Reviewed By: vhscampos
Differential Revision: https://reviews.llvm.org/D115507
Konstantin Boyarinov [Fri, 10 Dec 2021 09:51:42 +0000 (12:51 +0300)]
[libcxx][test][NFC] Tests for set comparisons
Add tests for std::set and std::multiset comparisons that were missed by
D111738 and D112424.
Reviewed By: ldionne, rarutyun, #libc
Differential Revision: https://reviews.llvm.org/D115136
Florian Hahn [Fri, 10 Dec 2021 11:42:45 +0000 (11:42 +0000)]
[Passes] Only run extra vector passes if loops have been vectorized.
This patch uses a similar trick as in D113947 to only run the extra
passes after vectorization on functions where loops have been
vectorized.
The reason for running the 'extra vector passes' is
simplification/unswitching of the runtime checks created by LV, there
should be no need to run them if nothing got vectorized
To do that, a new dummy analysis ShouldRunExtraVectorPasses has been
added. If loops have been vectorized for a function, LV will cache the
analysis. At the moment it uses MadeCFGChanges as proxy for loop
vectorized, which isn't perfect (it could be too aggressive, e.g.
because no runtime checks have been added), but should be good enough
for now.
The extra passes are now managed by a new FunctionPassManager that
runs its passes only if ShouldRunExtraVectorPasses has been cached.
Without this patch, `-extra-vectorizer-passes` has the following
compile-time impact:
NewPM-O3: +4.86%
NewPM-ReleaseThinLTO: +3.56%
NewPM-ReleaseLTO-g: +7.17%
http://llvm-compile-time-tracker.com/compare.php?from=
ead3979a92fc33add4710c4510d6906260dcb4ad&to=
c292da649e2c6e88a31e702fdc474727d09c72bc&stat=instructions
With this patch, that gets reduced to
NewPM-O3: +1.43%
NewPM-ReleaseThinLTO: +1.00%
NewPM-ReleaseLTO-g: +1.58%
http://llvm-compile-time-tracker.com/compare.php?from=
ead3979a92fc33add4710c4510d6906260dcb4ad&to=
e67d86b57810011cf285eb9aa1944781be6096f0&stat=instructions
It is probably still too high to enable by default, but much better.
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D115052
Evgeniy Brevnov [Wed, 24 Nov 2021 12:41:47 +0000 (19:41 +0700)]
[LV][NFC] New test case for compile time known trip count (TC)
New test to test/track upcoming chnages
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D114526
Alexander Potapenko [Tue, 23 Nov 2021 09:32:35 +0000 (10:32 +0100)]
[asan] Add support for disable_sanitizer_instrumentation attribute
For ASan this will effectively serve as a synonym for
__attribute__((no_sanitize("address")))
Differential Revision: https://reviews.llvm.org/D114421
Alexander Belyaev [Fri, 10 Dec 2021 11:03:47 +0000 (12:03 +0100)]
[mlir] Move `linalg.tensor_expand/collapse_shape` to TensorDialect.
RFC: https://llvm.discourse.group/t/rfc-reshape-ops-restructuring/3310
linalg.fill gets a canonicalizer, because `FoldFillWithTensorReshape` cannot be moved to tensorops (it uses linalg::FillOp inside). Before it was listed as a canonicalization pattern for the reshape operations, now it became a canonicalization for FillOp.
Differential Revision: https://reviews.llvm.org/D115502
Noah Shutty [Fri, 10 Dec 2021 11:08:15 +0000 (11:08 +0000)]
Revert "[llvm] [Debuginfo] Add llvm-debuginfod-find tool and end-to-end-tests."
This reverts commit
350fe22f2a7f16791f9269fd50f1fca1e7fa74d1 because it
caused buildbot breakages (https://lab.llvm.org/buildbot/#/builders/91/builds/387).
Stanislav Gatev [Fri, 10 Dec 2021 09:37:07 +0000 (10:37 +0100)]
[clang][dataflow] Implement a basic algorithm for dataflow analysis
This is part of the implementation of the dataflow analysis framework.
See "[RFC] A dataflow analysis framework for Clang AST" on cfe-dev.
Reviewed By: xazax.hun, gribozavr2
Differential Revision: https://reviews.llvm.org/D115235
Noah Shutty [Fri, 10 Dec 2021 10:22:15 +0000 (10:22 +0000)]
[llvm] [Debuginfo] Add llvm-debuginfod-find tool and end-to-end-tests.
This implements the `llvm-debuginfod-find` tool, which wraps the Debuginfod library (D112758) to query debuginfod servers for artifacts according to the [[ https://www.mankier.com/8/debuginfod#Webapi | specification ]].
Reviewed By: labath
Differential Revision: https://reviews.llvm.org/D112759
Florian Hahn [Fri, 10 Dec 2021 09:55:09 +0000 (09:55 +0000)]
[VPlan] Add InductionDescriptor to VPWidenIntOrFpInduction. (NFC)
This allows easier access to the induction descriptor from VPlan,
without needing to go through Legal. VPReductionPHIRecipe already
contains a RecurrenceDescriptor in a similar fashion.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D115111
Ties Stuij [Fri, 10 Dec 2021 09:36:19 +0000 (09:36 +0000)]
[ARM][libcxxabi] Add PACBTI-M support to libcxxabi
This change consists of just adding 'BTI' to the prologue of Arm assembly
functions, which is just the one: __cxa_end_cleanup
This patch is part of a series that adds support for the PACBTI-M extension of
the Armv8.1-M architecture, as detailed here:
https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/armv8-1-m-pointer-authentication-and-branch-target-identification-extension
The PACBTI-M specification can be found in the Armv8-M Architecture Reference
Manual:
https://developer.arm.com/documentation/ddi0553/latest
The following people contributed to this patch:
- Mikhail Maltsev
Reviewed By: lenary, danielkiss
Differential Revision: https://reviews.llvm.org/D112432
Alexander Potapenko [Tue, 7 Dec 2021 12:20:12 +0000 (13:20 +0100)]
[msan] Implement -msan-disable-checks.
To ease the deployment of KMSAN, we need a way to apply
__attribute__((no_sanitize("kernel-memory"))) to the whole source file.
Passing -msan-disable-checks=1 to the compiler will make it
treat every function in the file as if it was lacking the
sanitize_memory attribute.
Differential Revision: https://reviews.llvm.org/D115236
LLVM GN Syncbot [Fri, 10 Dec 2021 09:08:48 +0000 (09:08 +0000)]
[gn build] Port
1d0244aed781
Sameer Sahasrabuddhe [Fri, 10 Dec 2021 09:06:43 +0000 (14:36 +0530)]
Reapply CycleInfo: Introduce cycles as a generalization of loops
Reverts
02940d6d2202. Fixes breakage in the modules build.
LLVM loops cannot represent irreducible structures in the CFG. This
change introduce the concept of cycles as a generalization of loops,
along with a CycleInfo analysis that discovers a nested
hierarchy of such cycles. This is based on Havlak (1997), Nesting of
Reducible and Irreducible Loops.
The cycle analysis is implemented as a generic template and then
instatiated for LLVM IR and Machine IR. The template relies on a new
GenericSSAContext template which must be specialized when used for
each IR.
This review is a restart of an older review request:
https://reviews.llvm.org/D83094
Original implementation by Nicolai Hähnle <nicolai.haehnle@amd.com>,
with recent refactoring by Sameer Sahasrabuddhe <sameer.sahasrabuddhe@amd.com>
Differential Revision: https://reviews.llvm.org/D112696
Jason Molenda [Fri, 10 Dec 2021 09:01:17 +0000 (01:01 -0800)]
Remove one change from https://reviews.llvm.org/D115431
The change to ArchSpec::SetArchitecture that was setting the
ObjectFile of a mach-o binary to llvm::Triple::MachO. It's not
necessary for my patch, and it changes the output of image list -t
causing TestUniversal.py to fail on x86_64 systems. The bots
turned up the failure, I was developing and testing this on
an Apple Silicon mac.
Andrzej Warzynski [Fri, 10 Dec 2021 08:56:57 +0000 (08:56 +0000)]
[flang][nfc] Fix formatting
Andrzej Warzynski [Wed, 17 Nov 2021 10:03:19 +0000 (10:03 +0000)]
[flang][codegen] Add a conversion for `!fir.coordinate_of` - part 1
This patch extends the `FIRToLLVMLowering` pass in Flang by adding a
hook to transform `!fir.coordinate_of` into a sequence of LLVM MLIR
instructions.
The following cases are currently supported:
1. the input object is a `!fir.complex` (wrapped in e.g. `!fir.ref` or
`!fir.box`)
2. the input object is wrapped in a `!fir.box` (including e.g.
`!fir.array`).
Note that `!fir.complex` inside a `!fir.box` falls under case 1. above
(i.e. it's a special case regardless of the wrapping type).
This is part of the upstreaming effort from the `!fir-dev` branch in [1].
Differential Revision: https://reviews.llvm.org/D114159
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: V Donaldson <vdonaldson@nvidia.com>
Christudasan Devadasan [Thu, 9 Dec 2021 07:55:21 +0000 (02:55 -0500)]
[AMDGPU] Add AV class spill pseudo instructions
While enabling vector superclasses with D109301,
the AV spills are converted into VGPR spills by
introducing appropriate copies. The whole thing
ended up adding two instructions per spill (a copy
+ vgpr spill pseudo) and caused an incorrect
liverange update during inline spiller.
This patch adds the pseudo instructions for all
AV spills from 32b to 1024b and handles them in
the way all other spills are lowered.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D115439
Qiu Chaofan [Fri, 10 Dec 2021 08:01:45 +0000 (16:01 +0800)]
[PowerPC] Require htm feature for HTM builtins
Reviewed By: jsji
Differential Revision: https://reviews.llvm.org/D114569
Nikita Popov [Fri, 10 Dec 2021 07:59:59 +0000 (08:59 +0100)]
[Inline] Add test for exponential deferred inlining (NFC)
This shows a case where deferred inlining produces an exponential
result. The test case demonstrates the basic exponential behavior,
but is nowhere close to the worst case. For example, the file at
https://gist.github.com/nikic/
1262b5f7d27278e1b34a190ae10947f5
currently gets expanded from <100 lines to nearly 500000 lines of
IR by opt -inline.
Konstantin Schwarz [Thu, 9 Dec 2021 16:18:42 +0000 (17:18 +0100)]
[GlobalISel] Fix IRTranslator for constexpr fcmp
The existing code assumed fcmp to always be an Instruction, but it can also be a ConstExpr.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D115450
Chuanqi Xu [Fri, 10 Dec 2021 07:18:53 +0000 (15:18 +0800)]
[NFC] Format the newly added table for coro.end in coroutines.rst
The intention should be formatted in two lines instead of one.
Jason Molenda [Fri, 10 Dec 2021 06:43:39 +0000 (22:43 -0800)]
Set a default number of address bits on Darwin arm64 systems
With arm64e ARMv8.3 pointer authentication, lldb needs to know how
many bits are used for addressing and how many are used for pointer
auth signing. This should be determined dynamically from the inferior
system / corefile, but there are some workflows where it still isn't
recorded and we fall back on a default value that is correct on some
Darwin environments.
This patch also explicitly sets the vendor of mach-o binaries to
Apple, so we select an Apple ABI instead of a random other ABI.
It adds a function pointer formatter for systems where pointer
authentication is in use, and we can strip the ptrauth bits off
of the function pointer address and get a different value that
points to an actual symbol.
Differential Revision: https://reviews.llvm.org/D115431
rdar://
84644661
Siva Chandra Reddy [Fri, 10 Dec 2021 06:36:50 +0000 (06:36 +0000)]
[libc][NFC] Add NOLINT annotations at call sites to immintrin functions.
These annotations are intended to be temporary while we understand why
clang-tidy is not able to treat them as builtin exceptions.
Vitaly Buka [Fri, 10 Dec 2021 05:50:32 +0000 (21:50 -0800)]
[sanitizer] Update symbols after D113717
eopXD [Sat, 23 Oct 2021 10:18:24 +0000 (03:18 -0700)]
[RISCV] Unify depedency check and extension implication parsing logics
Originially there are two places that does parsing - `parseArchString` and
`parseFeatures`, each with its code on dependency check and implication.
This patch extracts common parts of the two as functions of `RISCVISAInfo`
and let them 2 use it.
Reviewed By: asb
Differential Revision: https://reviews.llvm.org/D112359
eopXD [Sat, 23 Oct 2021 05:25:57 +0000 (22:25 -0700)]
[RISCV] Fix arch string parsing for multi-character extensions
Current implementation can't parse extension names that contains digits
correctly (e.g. `zvl128b`). This patch fixes it.
Reviewed By: asb
Differential Revision: https://reviews.llvm.org/D109215
Mehdi Amini [Fri, 10 Dec 2021 05:02:25 +0000 (05:02 +0000)]
Fix crash from use of a temporary after its scope exit
Introduced in D110448 and broke some bots (reported by ASAN).
Differential Revision: https://reviews.llvm.org/D110448
Kazu Hirata [Fri, 10 Dec 2021 04:50:38 +0000 (20:50 -0800)]
[llvm] Use llvm::count (NFC)
Amara Emerson [Fri, 10 Dec 2021 00:05:14 +0000 (16:05 -0800)]
[AArch64][GlobalISel] Split vector stores of zero.
This results in a very minor improvement in most cases, generating
stores of xzr instead of moving zero to a vector register.
Differential Revision: https://reviews.llvm.org/D115479
Taewook Oh [Thu, 9 Dec 2021 23:49:00 +0000 (15:49 -0800)]
[dfsan] Add missing test for the new pass manager with -dfsan-ignore-personality-routine
A test for the new pass manager was missed from the original diff D115317.
Reviewed By: browneee
Differential Revision: https://reviews.llvm.org/D115477
Duncan P. N. Exon Smith [Wed, 8 Dec 2021 01:22:47 +0000 (17:22 -0800)]
Support: Avoid using SmallVector::set_size() in MemoryBuffer
Update getMemoryBufferForStream() to use `resize_for_overwrite()` and
`truncate()` instead of `reserve()` and `set_size()`.
Differential Revision: https://reviews.llvm.org/D115384
Phoebe Wang [Fri, 10 Dec 2021 02:31:09 +0000 (10:31 +0800)]
Revert "[X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits"
This reverts commit
4a2c827b178f89d4cdeb56153d9440ad4ba786a3.
Need to fix the problem when using `-mno-sse` together with "x86intrin.h"
Kirill Stoimenov [Fri, 10 Dec 2021 00:08:33 +0000 (00:08 +0000)]
Revert "[ASan] Shared optimized callbacks implementation."
This reverts commit
428ed61a921c092b638ee512c73d48352af915e6.
Build bot failure:
https://lab.llvm.org/buildbot/#/builders/37
https://lab.llvm.org/buildbot/#/builders/37/builds/9041
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D115489