platform/upstream/dotnet/runtime.git
7 years agoMerge pull request dotnet/corefx#16150 from JonHanna/pointer_types_type_equal_is
Vladimir Sadov [Sun, 19 Feb 2017 19:40:05 +0000 (11:40 -0800)]
Merge pull request dotnet/corefx#16150 from JonHanna/pointer_types_type_equal_is

Test and optimise TypeEqual and TypeIs behaviour for pointer types.

Commit migrated from https://github.com/dotnet/corefx/commit/11c6841b9e0a68c159c0bf0a412b56795311e2cb

7 years agoMerge pull request dotnet/corefx#16295 from stephentoub/cs_random
Stephen Toub [Sun, 19 Feb 2017 15:18:53 +0000 (10:18 -0500)]
Merge pull request dotnet/corefx#16295 from stephentoub/cs_random

Delay Random allocation in ConcurrentStack

Commit migrated from https://github.com/dotnet/corefx/commit/c97abfa305b6e9ce139cb0c4ef362a106b3bc156

7 years agoEnable tests in inner loop (dotnet/corefx#16297)
Saurabh Singh [Sun, 19 Feb 2017 06:58:59 +0000 (22:58 -0800)]
Enable tests in inner loop (dotnet/corefx#16297)

Commit migrated from https://github.com/dotnet/corefx/commit/6d3e8dd1f6f7a7aa59752a87c37de57e9cf07bde

7 years agoMerge pull request dotnet/corefx#16281 from Priya91/fixproxyauth
Lakshmi Priya Sekar [Sun, 19 Feb 2017 03:59:45 +0000 (19:59 -0800)]
Merge pull request dotnet/corefx#16281 from Priya91/fixproxyauth

Ignore curl error on failed proxy authentication.

Commit migrated from https://github.com/dotnet/corefx/commit/1543bcfce778ef9d124c638cde712ed147e826bd

7 years agoMerge pull request dotnet/corefx#16253 from Priya91/curlhandler
Lakshmi Priya Sekar [Sun, 19 Feb 2017 03:27:22 +0000 (19:27 -0800)]
Merge pull request dotnet/corefx#16253 from Priya91/curlhandler

Change host to idnhost on curlhandler.

Commit migrated from https://github.com/dotnet/corefx/commit/c9fb7954d5490214a9f5422ba231eac02ef584fa

7 years agoAdd curl error code to native layer.
Lakshmi Priya Sekar [Sun, 19 Feb 2017 03:22:34 +0000 (19:22 -0800)]
Add curl error code to native layer.

Commit migrated from https://github.com/dotnet/corefx/commit/72f9076d569b15d12579d71cfa8706699d621ed8

7 years agoUpdate cross-platform-testing.md
Dan Moseley [Sun, 19 Feb 2017 02:14:58 +0000 (18:14 -0800)]
Update cross-platform-testing.md

Rename mscorlib ref.

Commit migrated from https://github.com/dotnet/corefx/commit/cddaeacf0023f0e95f6e59fabaeb0b04c4b97dff

7 years agoDelay Random allocation in ConcurrentStack
Stephen Toub [Sat, 18 Feb 2017 23:28:32 +0000 (15:28 -0800)]
Delay Random allocation in ConcurrentStack

ConcurrentStack currently uses a randomized-backoff scheme, where under contention it spins for increasingly longer periods of time, with a duration influenced by some randomness.  If the initial attempt at popping an item fails due to contention, it allocates a Random, then tries again one or more times, and then uses the randomness to influence backoff for subsequent attempts.  While it's not clear to me that this scheme is optimal, we can at least delay the allocation of the Random (and the underlying cost it entails, like an int[] in its ctor) until it's actually used.  Since it's typically not used for a few attempts, this significantly decreases the number of instances that get created under heavy contention.

Commit migrated from https://github.com/dotnet/corefx/commit/c0a0c55c10c820088a249991376251ad7e6eb7ae

7 years agoStrings fix followup (dotnet/corefx#16294)
Dan Moseley [Sat, 18 Feb 2017 23:18:10 +0000 (15:18 -0800)]
Strings fix followup (dotnet/corefx#16294)

Commit migrated from https://github.com/dotnet/corefx/commit/3de4de8dd4328aafcb1b7dbd099ce7e12a982441

7 years agoMerge pull request dotnet/corefx#16231 from JonHanna/open_generic_property_field
Vladimir Sadov [Sat, 18 Feb 2017 20:35:18 +0000 (12:35 -0800)]
Merge pull request dotnet/corefx#16231 from JonHanna/open_generic_property_field

Prohibit open generics in Expression.Property and Expression.Field

Commit migrated from https://github.com/dotnet/corefx/commit/e02adc60844d53991bfba296b738d2e007f470f7

7 years agoTest and optimise TypeEqual and TypeIs behaviour for pointer types.
Jon Hanna [Tue, 14 Feb 2017 18:12:06 +0000 (18:12 +0000)]
Test and optimise TypeEqual and TypeIs behaviour for pointer types.

Contributes to dotnet/corefx#8081, but since the current behaviour is to safely
always return false, continue to allow pointer type operands.

There is already code that examines these expressions for always-false
or always-true behaviour, so have pointer types also result in the
always-false path being taken.

Commit migrated from https://github.com/dotnet/corefx/commit/7f887e994228b8c6b292908875105c06b5d7459b

7 years agoMerge pull request dotnet/corefx#16127 from JonHanna/sle_interpret_lighter_converts
Vladimir Sadov [Sat, 18 Feb 2017 19:49:14 +0000 (11:49 -0800)]
Merge pull request dotnet/corefx#16127 from JonHanna/sle_interpret_lighter_converts

Lighten some numeric conversions in S.L.Expression interpreter

Commit migrated from https://github.com/dotnet/corefx/commit/7d8b208c8fd607cd9b5c6ee585cf3cddca84820a

7 years agoMerge pull request dotnet/corefx#16233 from JonHanna/lambda_open_delegate
Vladimir Sadov [Sat, 18 Feb 2017 19:34:13 +0000 (11:34 -0800)]
Merge pull request dotnet/corefx#16233 from JonHanna/lambda_open_delegate

Prohibit open generic delegate types for LambdaExpression

Commit migrated from https://github.com/dotnet/corefx/commit/d7d09c4bfad9ef5e22588cf06c58423421a36be1

7 years agoMake RemoteExecutorConsoleApp runs against the full framework (dotnet/corefx#16282)
Tarek Mahmoud Sayed [Sat, 18 Feb 2017 19:11:45 +0000 (11:11 -0800)]
Make RemoteExecutorConsoleApp runs against the full framework (dotnet/corefx#16282)

* Make RemoteExecutorConsoleApp runs against the full framework

All tests using RemoteExecutorConsoleApp having it run under the dotnet host which is not correct for the netfx runs.
The fix here is to allow running RemoteExecutorConsoleApp directly against the full framework and uses the same Netfx runtime bits.
We have to copy the config file too to prevent assembly binding issues

* Use RuntimeInformation.FrameworkDescription

Commit migrated from https://github.com/dotnet/corefx/commit/9e693eed46efd17f39090de336ee82d318edbbec

7 years agoRemove dead string resources (dotnet/corefx#16284)
Dan Moseley [Sat, 18 Feb 2017 14:01:59 +0000 (06:01 -0800)]
Remove dead string resources (dotnet/corefx#16284)

Commit migrated from https://github.com/dotnet/corefx/commit/6b4423f47d5048b4c1437aaefe87859b258c89b7

7 years agoMerge pull request dotnet/corefx#16085 from JonHanna/fix_16028
Vladimir Sadov [Sat, 18 Feb 2017 03:41:55 +0000 (19:41 -0800)]
Merge pull request dotnet/corefx#16085 from JonHanna/fix_16028

Correctly handle dynamic lifted enum arithmetic

Commit migrated from https://github.com/dotnet/corefx/commit/75a5d2cd50f0300aae644dc6221a4bd8b03719ed

7 years agoIgnore curl error on failed proxy authentication.
Lakshmi Priya Sekar [Sat, 18 Feb 2017 02:46:05 +0000 (18:46 -0800)]
Ignore curl error on failed proxy authentication.

Commit migrated from https://github.com/dotnet/corefx/commit/ad9d5e26477a57bac8a2362bed84f50bb1632a61

7 years agoCorrectly handle dynamic lifted enum arithmetic
Jon Hanna [Sun, 12 Feb 2017 12:39:12 +0000 (12:39 +0000)]
Correctly handle dynamic lifted enum arithmetic

Microsoft.CSharp special-cases enum binary operations, but not when
lifted. In most cases the nett result is an expression that will have
the same outcome as if the expression had been special-cased to
similarly match the C# rules exactly.

E.g. the C# rules for adding an short-backed enum x and a short y would
convert both to int, add them and then cast the result to the short-
backed enum. The expression produced casts both to short, adds them and
casts to the short-backed enum. Since in S.L.Expressions the result of
short addition is a short (unlike in C# where it is an int) the final
cast means the result is the same either way.

In the case of addition and subtraction with byte- or sbyte-based enums
however this means the expression produced tries to add byte or sbyte
values, which is not valid in S.L.Expressions, and an
InvalidOperationException results.

Catch the case of lifted enum arithmetic, producing an expression with
the correct intermediary casts.

Fixes dotnet/corefx#16028.

Commit migrated from https://github.com/dotnet/corefx/commit/cc6234c8617b5b5c1813ed874a235b3931015cf5

7 years agoRespond to PR feedback.
Lakshmi Priya Sekar [Fri, 17 Feb 2017 21:46:30 +0000 (13:46 -0800)]
Respond to PR feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/ed492c8764fad6e2bcab460dab9f504efb295e4d

7 years agoAdd /usr/local/bin to PATH (dotnet/corefx#16280)
Matt Mitchell [Sat, 18 Feb 2017 00:43:55 +0000 (16:43 -0800)]
Add /usr/local/bin to PATH (dotnet/corefx#16280)

Add /usr/local/bin to PATH

Add the /usr/local/bin to the PATH so as to ensure cmake is on the PATH in sudo run outerloop tests

Commit migrated from https://github.com/dotnet/corefx/commit/7537b5b28c1522c75d9eeb8d43145bed5f9d5556

7 years agoMerge pull request dotnet/corefx#16035 from JonHanna/single_pass_tryemitconstant
Vladimir Sadov [Fri, 17 Feb 2017 21:14:12 +0000 (13:14 -0800)]
Merge pull request dotnet/corefx#16035 from JonHanna/single_pass_tryemitconstant

Have S.L.Expressions compiler test and add constants in a single pass.

Commit migrated from https://github.com/dotnet/corefx/commit/31cb598e14f543be608a05f0c959abc40b5323e3

7 years agoMerge pull request dotnet/corefx#15941 from JonHanna/simpler_lifted_relational
Vladimir Sadov [Fri, 17 Feb 2017 21:08:37 +0000 (13:08 -0800)]
Merge pull request dotnet/corefx#15941 from JonHanna/simpler_lifted_relational

Simpler lifted comparison operation compilation in S.L.Expressions

Commit migrated from https://github.com/dotnet/corefx/commit/b9d21f963d7f27828fc2c7551ba52c6bfff7508c

7 years agoMerge pull request dotnet/corefx#16141 from JonHanna/type_check_throw
Vladimir Sadov [Fri, 17 Feb 2017 21:02:47 +0000 (13:02 -0800)]
Merge pull request dotnet/corefx#16141 from JonHanna/type_check_throw

Throw on byref or pointer types in linq Throw expressions.

Commit migrated from https://github.com/dotnet/corefx/commit/c2fdb550c60fa98eb5fd9e45ecefa1919e09fc59

7 years agoMerge pull request dotnet/corefx#15854 from JonHanna/dont_always_emit_typebuilder_type
Vladimir Sadov [Fri, 17 Feb 2017 20:56:50 +0000 (12:56 -0800)]
Merge pull request dotnet/corefx#15854 from JonHanna/dont_always_emit_typebuilder_type

Don't assume TypeBuilder types can be emitted as tokens.

Commit migrated from https://github.com/dotnet/corefx/commit/c9a8567138694d3607f3999733ac3e25e59663a7

7 years agoRobustify Mono configuration tests (dotnet/corefx#16273)
Jeremy Kuhne [Fri, 17 Feb 2017 20:20:07 +0000 (12:20 -0800)]
Robustify Mono configuration tests (dotnet/corefx#16273)

Creating a temp file and deleting then rewriting over it is risky. File
deletions aren't synchronous- they are just flagged for deletion.

This change uses one of our existing temp directory classes and creates
random filenames within.

See dotnet/corefx#16270

Commit migrated from https://github.com/dotnet/corefx/commit/2c36834c5e8dd00e7aaf09cfb25717271ff16f18

7 years agoMerge pull request dotnet/corefx#15590 from JonHanna/ms_cs_merge_null_checks
Vladimir Sadov [Fri, 17 Feb 2017 20:09:00 +0000 (12:09 -0800)]
Merge pull request dotnet/corefx#15590 from JonHanna/ms_cs_merge_null_checks

Null propagation and merging of null-checks in Microsoft.CSharp

Commit migrated from https://github.com/dotnet/corefx/commit/5ba62e82302f458506935b0e46f01d210f1ee91f

7 years agoMerge pull request dotnet/corefx#15484 from jamesqo/grouping.debug
Vladimir Sadov [Fri, 17 Feb 2017 20:05:35 +0000 (12:05 -0800)]
Merge pull request dotnet/corefx#15484 from jamesqo/grouping.debug

Show a more helpful description in the debugger for Grouping/Lookup

Commit migrated from https://github.com/dotnet/corefx/commit/41319b8e8190b3018b7d6955274c883cd79bb006

7 years agoMerge pull request dotnet/corefx#16271 from MattGal/Fix_relative_paths_Pushing_to_helix
Matt Galbraith [Fri, 17 Feb 2017 19:50:12 +0000 (11:50 -0800)]
Merge pull request dotnet/corefx#16271 from MattGal/Fix_relative_paths_Pushing_to_helix

Workaround recent test break for Helix runs

Commit migrated from https://github.com/dotnet/corefx/commit/fffebba0595338b28706cca9c033fbdea96fc054

7 years agoPR Feedback. Noted that since we're actually using RecursiveDir, RelativeBlobPath...
Matt Galbraith [Fri, 17 Feb 2017 19:44:59 +0000 (11:44 -0800)]
PR Feedback.  Noted that since we're actually using RecursiveDir, RelativeBlobPath calculation is unnecessary.

Commit migrated from https://github.com/dotnet/corefx/commit/546ebae48d787f1497772ae96fdfcd08ae30b139

7 years agoAdd reporting parameter Crossbuild (dotnet/corefx#16268)
Mariana Rios Flores [Fri, 17 Feb 2017 19:17:43 +0000 (11:17 -0800)]
Add reporting parameter Crossbuild (dotnet/corefx#16268)

Commit migrated from https://github.com/dotnet/corefx/commit/baddea890ac483d465388acc10c5c91d6b8928bc

7 years agoRe-enable Vector3GetHashCodeTest test (dotnet/corefx#16267)
Stephen Toub [Fri, 17 Feb 2017 18:51:06 +0000 (10:51 -0800)]
Re-enable Vector3GetHashCodeTest test (dotnet/corefx#16267)

Commit migrated from https://github.com/dotnet/corefx/commit/89d30903160b194fa246e4565cbf3616bd418a0d

7 years agoWorkaround recent test break by calculating Functional test list again. Previously...
Matt Galbraith [Fri, 17 Feb 2017 18:39:59 +0000 (10:39 -0800)]
Workaround recent test break by calculating Functional test list again.  Previously this was done by the FilterForUpload task, which is now deprecated.

Commit migrated from https://github.com/dotnet/corefx/commit/d0370ebe47f2f6e737f7b738c733028d93ef4734

7 years agoFix several typos (dotnet/corefx#16264)
Jon Hanna [Fri, 17 Feb 2017 18:31:00 +0000 (18:31 +0000)]
Fix several typos (dotnet/corefx#16264)

* Fix several typos

coment → comment
rangecheck → range check
testcase → test case
deffer → defer
everytime → every time
whitespaces → whitespace (whitespace is uncountable)
white space → whitespace
white spaces → whitespace
the the → the
a → a
nametest → name test
scaned → scanned
and and → and
undecision → indecision
are no whitespace → is no whitespace
Whidbey casing
Everett casing
unkown → unknown
messsage → message
mesage → message
mesasage → message
publically → publicly (publically is attested but questionable).
exceptionto → exception to
mutatable → mutable
implemention → implementation
hadnt → hadn't
couldnt → couldn't
wouldnt → wouldn't
wont → won't
isntead → instead
preocessor → processor
particural → particular
interations → iterations
enterying → entering
stoppped → stopped
stoped → stopped
verication → verification
compuatation → computation
revisisted → revisited
partioner → partitioner
lock'ed → locked
table'd → table would
hashtable'ed → hashtabled (still coining, but tabled is analogous)
intialize → initialize
calcuate → calculate
perfom → perform
performr → perform
matthing → matching
corect → correct
thorw → throw
supress → suppress
reqeust → request
mutliple → multiple
ot → to
trival → trivial
upto → up to
specfices → specifies
patttern → pattern
descrepancy → discrepancy
explict → explicit
implict → implicit
usign → using
non-sensical → nonsensical
contination → continuation
producs → products
childred → children
parametr → parameter
approriate → appropriate
insted → instead
expection → exception
successsfully → successfully
funtion → function
unqiue → unique
apparant → apparent
expception → exception
conatined → contained
apssed → passed
propogate → propagate
cutoms → custom
currrent → current
curent → current
concurent → concurrent
coplted → completed
unexcepted → Unexpected (where the latter seems more appropriate)
to to → to
abd → and
refence → reference
particiant → participant
cuurrent → current
extratc → extract
cparticipant → participant
ehich → which
choosen → chosen
mske → make
alread → already
aquire → acquire
droppping → dropping
intial → initial
tru → true
aprticipant → participant
excption → exception
sempahore → semaphore
fileds → fields
threashold → threshold
duting → during
didnt → didn't
atribute → attribute
serliazation → serialization
localy → locally
channge → change
prperties → properties
attrbute → attribute
sentinal → sentinel
shoukd → should
existant → existent
commnent → comment
expeted → expected
propert → property
commnet → comment
datat → data
ther → the
mach → match
inhertiance → inheritance
convience → convenience
completley → completely
otheriwse → otherwise
actuall → actual
inefficent → inefficient
defalut → default
comparsion → comparison
charcters → characters
postion → position
aleady → already
charater → character
incosistent → inconsistent
seperate → separate
veify → verify
currentlly → currently
corect → correct
betwwen → between
omiting → omitting
readr → reader
compae → compare
allways → always
thown → thrown
with with → with
usecase → use case
avare → aware
lexem → lexeme
grammer → grammar
oposite → opposite
overrided → overridden
everithig → everything
chages → changes
memeber → member
proerties → properties
identifer → identifier
doesnot → does not
deriaved → derived
varialble → variable

* defered -> deferred

* Revert changes within clrcompression.

* Revert underreach → under-reach

* Fix casing broken while fixing spelling.

* Use type name instead of "Diagnostic sources"

Commit migrated from https://github.com/dotnet/corefx/commit/f0ccd9742065ee2aa296448fe3dd38ef6ff77af9

7 years agoMerge pull request dotnet/corefx#16266 from JonHanna/RuntimeBinderExceptionTests
Stephen Toub [Fri, 17 Feb 2017 18:30:36 +0000 (10:30 -0800)]
Merge pull request dotnet/corefx#16266 from JonHanna/RuntimeBinderExceptionTests

Add tests for public API of RuntimeBinderException

Commit migrated from https://github.com/dotnet/corefx/commit/e7574660aa3257baccaf5a612dde7f0b9268ffe9

7 years agoRemove 'using Res = System.SR'. As it requires SR to be in System and in all other...
Egor Bogatov [Fri, 17 Feb 2017 18:30:10 +0000 (21:30 +0300)]
Remove 'using Res = System.SR'. As it requires SR to be in System and in all other places SR is used directly. (dotnet/corefx#16262)

Commit migrated from https://github.com/dotnet/corefx/commit/edcedfbe4efefd11df15f6028877b86f91a74990

7 years agoMerge pull request dotnet/corefx#16269 from ericstj/flowConfigBuildAll
Eric StJohn [Fri, 17 Feb 2017 18:25:42 +0000 (13:25 -0500)]
Merge pull request dotnet/corefx#16269 from ericstj/flowConfigBuildAll

Config system should flow insignificant properties

Commit migrated from https://github.com/dotnet/corefx/commit/0a10f34e46c521b14c553f1249580466bc4fcea3

7 years agoConfig system should flow insignificant properties
Eric St. John [Fri, 17 Feb 2017 17:54:22 +0000 (09:54 -0800)]
Config system should flow insignificant properties

Some properties are "insignificant" which means that they aren't
considered for compatibility decisions but should still flow to child
projects.

In a normal build traversal these will flow because
FindBestConfiguration finds all compatible configurations for the
BuildConfiguration then chooses the best of these (which include
insignificant property values) from the set of project
BuildConfigurations.  As a result FindBestConfiguration will flow the
insignificant properties from BuildConfiguration to the Configuration
that gets passed to child projects.

This is different than BuildAllConfigurations.  In that case we don't
call any task to select configurations, we just repeat the
configurations verbatim from the project's BuildConfigurations.
Since projects never specify these insignificant properties
(eg: ConfigurationGroup, ArchGroup) we weren't flowing the values and
instead were always choosing the default value.

This change makes it so that we first try to pull insignificant
properties from the Configuration string, but if we can't find them,
we'll then try to persist the value (along with creating any derived
properties) and only if they are unset will we try to set them to their
default value.

Commit migrated from https://github.com/dotnet/corefx/commit/4e9399bcccafdb6a0cd9007b89116a2ae4d15e44

7 years agoAdd tests for public API of RuntimeBinderException
Jon Hanna [Fri, 17 Feb 2017 13:10:04 +0000 (13:10 +0000)]
Add tests for public API of RuntimeBinderException

Commit migrated from https://github.com/dotnet/corefx/commit/322a57f64e334674c2659890da6157c5b6f948b4

7 years agoEnable Dumpling for Unix CI tests (dotnet/corefx#16246)
Eric Mellino [Fri, 17 Feb 2017 05:34:21 +0000 (21:34 -0800)]
Enable Dumpling for Unix CI tests (dotnet/corefx#16246)

* Pass a simple flag "IsCIBuild" in netci.groovy
* In dir.props, define a common set of properties that are contingent on
  "IsCIBuild", so they don't need to be duplicated everywhere in
  netci.groovy.
* Set EnableDumpling=true for Unix builds (Windows support forthcoming).

Commit migrated from https://github.com/dotnet/corefx/commit/bf9b0fe87b824145fda11e7eb194b4cb4834e059

7 years agoFix for System.Configuration.SettingsPropertyValue (dotnet/corefx#16239)
Pavel Maltsev [Fri, 17 Feb 2017 04:20:18 +0000 (06:20 +0200)]
Fix for System.Configuration.SettingsPropertyValue (dotnet/corefx#16239)

Commit migrated from https://github.com/dotnet/corefx/commit/35a3c5802f2a34c28ffbf3dfad70cd373c2b9f33

7 years agoSerialPort: Move test file locations and set namespaces (dotnet/corefx#16228)
Will Dean [Fri, 17 Feb 2017 04:19:15 +0000 (04:19 +0000)]
SerialPort: Move test file locations and set namespaces (dotnet/corefx#16228)

* Move migrated tests out of Legacy subdirectory

* Correct namespaces in SerialStream tests

* Introduce namespace in SerialPort folder

Commit migrated from https://github.com/dotnet/corefx/commit/a5473390a7da48fbc01ced6985da38679983faca

7 years agoEnabling GenSspiClientContext() to be used in Windows (dotnet/corefx#16211)
Gene Lee [Fri, 17 Feb 2017 03:35:29 +0000 (19:35 -0800)]
Enabling GenSspiClientContext() to be used in Windows (dotnet/corefx#16211)

Commit migrated from https://github.com/dotnet/corefx/commit/b02fbd79fd4782f8fd92a45e0622a15dfd22aed2

7 years agoChange host to idnhost on curlhandler.
Lakshmi Priya Sekar [Fri, 17 Feb 2017 03:29:50 +0000 (19:29 -0800)]
Change host to idnhost on curlhandler.

Commit migrated from https://github.com/dotnet/corefx/commit/52de4fdbd8dc87411800978099ab62fcdb9052b6

7 years agoMerge pull request dotnet/corefx#16249 from ericstj/binplaceHardlink
Eric StJohn [Fri, 17 Feb 2017 03:27:54 +0000 (22:27 -0500)]
Merge pull request dotnet/corefx#16249 from ericstj/binplaceHardlink

Use Hardlinks when binplacing

Commit migrated from https://github.com/dotnet/corefx/commit/cb9f5bbb65f76ec27f76ef0320ac2c510787a419

7 years agoMerge pull request dotnet/corefx#16250 from JonHanna/loosing_typo
Stephen Toub [Fri, 17 Feb 2017 03:08:06 +0000 (19:08 -0800)]
Merge pull request dotnet/corefx#16250 from JonHanna/loosing_typo

Fix typo loosing -> losing

Commit migrated from https://github.com/dotnet/corefx/commit/2310babf0d7a0f8bf288dd2b08f23e6c357a9548

7 years agoMerge pull request dotnet/corefx#16247 from morganbr/NetPrimitivesResources
Stephen Toub [Fri, 17 Feb 2017 03:07:20 +0000 (19:07 -0800)]
Merge pull request dotnet/corefx#16247 from morganbr/NetPrimitivesResources

System.Net.Primitives Resource Cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/47986c2f3efda3ae24c9054136010b028aa71c8e

7 years agoWarn for attempt to build on 32 bit unix (dotnet/corefx#16232)
Dan Moseley [Fri, 17 Feb 2017 02:36:46 +0000 (18:36 -0800)]
Warn for attempt to build on 32 bit unix (dotnet/corefx#16232)

Commit migrated from https://github.com/dotnet/corefx/commit/f19e230eb2f8cf4898faaaaec40e5aad9bfa6a6e

7 years agoFix typo loosing -> losing
Jon Hanna [Fri, 17 Feb 2017 02:21:05 +0000 (02:21 +0000)]
Fix typo loosing -> losing

Commit migrated from https://github.com/dotnet/corefx/commit/ae645321e8c358b4313aa303cdbf3dcd1da292a0

7 years agoUse Hardlinks when binplacing
Eric St. John [Fri, 17 Feb 2017 02:15:15 +0000 (18:15 -0800)]
Use Hardlinks when binplacing

Help save disk space with unnecessary copies.  This may also fix an
issue where our signed files aren't getting packaged / used for testing.

Commit migrated from https://github.com/dotnet/corefx/commit/0d714b30a602f2f1fc32ae71ec64de295ffc6c32

7 years agoSystem.Private.Reflection.Metadata.Ecma335 (dotnet/corefx#15366)
David Wrighton [Fri, 17 Feb 2017 02:07:14 +0000 (18:07 -0800)]
System.Private.Reflection.Metadata.Ecma335 (dotnet/corefx#15366)

* System.Private.Reflection.Metadata.Ecma335.dll
- This is to be used as part of the jit bring up on CoreRT. This is NOT a generally useable metadata reader. (For that, use System.Reflection.Metadata)
- Remove all dependencies other than System.Private.Corelib from System.Reflection.Metadata
- Build Shims to provide api surface not present in Corelib. (Many of these shims will go away over time as corelib for .NET Native is enhanced to cover all of .NET Standard 2.0)
- Remove dependence on Values property of Dictionary
- Remove dependence on HashSet<T>
- The Path shim is not entirely correct, but the correct variant is not necessary for cases which are to be used with this dll yet
- The ResourceManager shim does not actually provide useful resource manager results, but should avoid crashing
- Additionally, a strings.resx file with sufficient resources to compile the shims+metadata sources is included in this commit
- Remove embedded portable pdb handling to partial classes. Embedded portable pdbs are not yet needed by any scenario this dll will be used for

Commit migrated from https://github.com/dotnet/corefx/commit/d5dc42495de7fa663642dd31765d2671c1758576

7 years agoMerge pull request dotnet/corefx#16245 from ericstj/updateConfigs
Eric StJohn [Fri, 17 Feb 2017 01:59:49 +0000 (20:59 -0500)]
Merge pull request dotnet/corefx#16245 from ericstj/updateConfigs

Update configs and solutions

Commit migrated from https://github.com/dotnet/corefx/commit/cd40e57b7d8be1b38a37f58bdd299d890843c812

7 years agoMerge pull request dotnet/corefx#16244 from ericstj/refactorMemoryUnsafeConfigs
Eric StJohn [Fri, 17 Feb 2017 01:59:36 +0000 (20:59 -0500)]
Merge pull request dotnet/corefx#16244 from ericstj/refactorMemoryUnsafeConfigs

Make sure Memory and Unsafe are packaged w/o RID

Commit migrated from https://github.com/dotnet/corefx/commit/b31ed134b377acd545c9052f76e1ea18c1f8a307

7 years agoFix Http test that randomly fails under Windows (dotnet/corefx#16241)
Steve Harter [Fri, 17 Feb 2017 01:14:08 +0000 (17:14 -0800)]
Fix Http test that randomly fails under Windows (dotnet/corefx#16241)

Commit migrated from https://github.com/dotnet/corefx/commit/3a71007e65e38b1b10b3e3c8ba5dc0803b9bf6ed

7 years agoMake sure Memory and Unsafe are packaged w/o RID
Eric St. John [Fri, 17 Feb 2017 00:41:21 +0000 (16:41 -0800)]
Make sure Memory and Unsafe are packaged w/o RID

The workaround being used by our build system to only build these
packages on Windows was leaking into the packaging.

To fix that I overrode the packaging RID for Unsafe, since it was the
only thing that actually needed the filtering.

Then to fix Memory I added a reference assembly for unsafe and built
against that instead.

Commit migrated from https://github.com/dotnet/corefx/commit/fbafeb42ea7488fa62240f03a233ddef9382a210

7 years agoProhibit open generic delegate types for LambdaExpression
Jon Hanna [Thu, 16 Feb 2017 22:01:42 +0000 (22:01 +0000)]
Prohibit open generic delegate types for LambdaExpression

Contributes to dotnet/corefx#8081

Commit migrated from https://github.com/dotnet/corefx/commit/6fa63d16bd0bc05dd017ff30378aa4dd4ec5a064

7 years agoUpdate configs and solutions
Eric St. John [Fri, 17 Feb 2017 00:54:55 +0000 (16:54 -0800)]
Update configs and solutions

Update theses that have become out of sync.

Commit migrated from https://github.com/dotnet/corefx/commit/1548822f8d15dcb5587802c3ce7d70fabcc8c36e

7 years agoCleanup of string resources for System.Net.Primitives based on an automated source...
Morgan Brown [Fri, 17 Feb 2017 00:06:45 +0000 (16:06 -0800)]
Cleanup of string resources for System.Net.Primitives based on an automated source scanning tool. Of the original 776 strings, this keeps the 17 that were being used, saving around 100kb.

Commit migrated from https://github.com/dotnet/corefx/commit/fe41c4f7885a3dcb2a5a23b1e6ca19a1590821a1

7 years agoDisable Crypto tests for Fedora\Ubuntu (dotnet/corefx#16237)
Steve Harter [Thu, 16 Feb 2017 23:47:57 +0000 (15:47 -0800)]
Disable Crypto tests for Fedora\Ubuntu (dotnet/corefx#16237)

* Disable Crypto tests for Fedora\Ubuntu

Commit migrated from https://github.com/dotnet/corefx/commit/177b00202e79acdb44440049791997d5e94947dd

7 years agoMerge pull request dotnet/corefx#16191 from ericstj/packages
Eric StJohn [Thu, 16 Feb 2017 22:44:52 +0000 (17:44 -0500)]
Merge pull request dotnet/corefx#16191 from ericstj/packages

Re-enable packages for BuildAllConfigurations

Commit migrated from https://github.com/dotnet/corefx/commit/9d1d63fb791e80399b008bc7ed0801fbb49c6e0b

7 years agoUpdate netstandard version (dotnet/corefx#16234)
Tarek Mahmoud Sayed [Thu, 16 Feb 2017 22:44:31 +0000 (14:44 -0800)]
Update netstandard version (dotnet/corefx#16234)

Commit migrated from https://github.com/dotnet/corefx/commit/b7a7243034036ed621c100c5dec240a3735ffd76

7 years agoEnabling overflow checks for debug (dotnet/corefx#16189)
Dennis "D.C." Dietrich [Thu, 16 Feb 2017 22:42:33 +0000 (23:42 +0100)]
Enabling overflow checks for debug (dotnet/corefx#16189)

* Marking code as unchecked (pt 9)

Additional unchecked for new test code and missed cases in BitConverter

* Marking code as unchecked (pt 9a)

Added unchecked to two casts in ManagedWebSocket

* CI test failure fixes

Overflow exceptions in:
 - Windows NT Debug dotnet/corefx#3458
 - OS X Debug dotnet/corefx#3357

* CI test failure fixes

Overflow exceptions in:
 - Windows 7 Debug Outerloop (build 8)
 - OS X Debug Outerloop (build 45)

* CI test failure fixes

Fixed overflow exception from OS X Debug Outerloop (build 46)

Commit migrated from https://github.com/dotnet/corefx/commit/7f6ac8bf97a84666ed3e7ef6b77c1a9470ae78c8

7 years agoMerge pull request dotnet/corefx#16188 from dagood/retain-drops
Davis Goodin [Thu, 16 Feb 2017 22:37:55 +0000 (16:37 -0600)]
Merge pull request dotnet/corefx#16188 from dagood/retain-drops

Retain VSTS Drop of packages indefinitely

Commit migrated from https://github.com/dotnet/corefx/commit/d901be91cdcf5687a74f7729b51e97f1f6fdacb0

7 years agoGenerate xunit runner config automatically (dotnet/corefx#16215)
Tarek Mahmoud Sayed [Thu, 16 Feb 2017 22:31:51 +0000 (14:31 -0800)]
Generate xunit runner config automatically (dotnet/corefx#16215)

* Generate xunit runner config automatically

The change here is to enumerate the assemblies in the runtime folder and generate the binding elements in the config file.
we are getting rid of the template we used to generate the config file from

* Conslidate GenerateXUnitRunnerConfigFile task code

* Revert un-needed change

Commit migrated from https://github.com/dotnet/corefx/commit/6792b029b45bcfbb65ba927873ed57a9684add99

7 years agoAdd 'Key = ' prefix
James Ko [Thu, 16 Feb 2017 21:59:45 +0000 (16:59 -0500)]
Add 'Key = ' prefix

Commit migrated from https://github.com/dotnet/corefx/commit/899f6a4261ad1cf7502d1489f3cb8ed6ad3d915f

7 years agoConform to existing style for debugger proxy names
James Ko [Sat, 28 Jan 2017 04:20:35 +0000 (23:20 -0500)]
Conform to existing style for debugger proxy names

Commit migrated from https://github.com/dotnet/corefx/commit/4c1836d6f1fa46ddbcce20b0363793c99aeb0fbf

7 years agoSome clarifying comments
James Ko [Sat, 28 Jan 2017 04:06:01 +0000 (23:06 -0500)]
Some clarifying comments

Commit migrated from https://github.com/dotnet/corefx/commit/dd0ed898cb6625448068534c776a802ad0726ef9

7 years agoFix test failures
James Ko [Sat, 28 Jan 2017 03:58:27 +0000 (22:58 -0500)]
Fix test failures

Commit migrated from https://github.com/dotnet/corefx/commit/4fd0fd1b050f58f345d9e11d0151e0e7837ed8df

7 years agoValidate the debugger proxy too
James Ko [Sat, 28 Jan 2017 03:46:36 +0000 (22:46 -0500)]
Validate the debugger proxy too

Commit migrated from https://github.com/dotnet/corefx/commit/993118f3471f4310a25d9c5ed87b8e6063665650

7 years agoMake ValidateDebuggerDisplayReferences return a string, add tests for it
James Ko [Thu, 26 Jan 2017 02:58:53 +0000 (21:58 -0500)]
Make ValidateDebuggerDisplayReferences return a string, add tests for it

Commit migrated from https://github.com/dotnet/corefx/commit/aa598e76b97976f17417650e133dfb152dd3eaad

7 years agoCache the arrays for display
James Ko [Wed, 25 Jan 2017 00:15:17 +0000 (19:15 -0500)]
Cache the arrays for display

Commit migrated from https://github.com/dotnet/corefx/commit/f0875eff019f20dcc30fce64f0aaea4791d204dc

7 years agoAdd the Lookup proxy
James Ko [Sat, 14 Jan 2017 06:08:19 +0000 (01:08 -0500)]
Add the Lookup proxy

Commit migrated from https://github.com/dotnet/corefx/commit/c65ba8d4990a2037635ca3e698097df7d5430c78

7 years agoAdd a debugger proxy for Grouping
James Ko [Sat, 14 Jan 2017 05:59:12 +0000 (00:59 -0500)]
Add a debugger proxy for Grouping

Commit migrated from https://github.com/dotnet/corefx/commit/28c2cd817c0a002001429b9f49910d9d851a7e3a

7 years agoMerge pull request dotnet/corefx#16208 from mmitche/remove-unused-args
Matt Mitchell [Thu, 16 Feb 2017 21:24:13 +0000 (13:24 -0800)]
Merge pull request dotnet/corefx#16208 from mmitche/remove-unused-args

Removed unused arguments from the NoTest versions of the pipeline/build definitions

Commit migrated from https://github.com/dotnet/corefx/commit/b31d143b63f31ddcf19b6e9d4c013d24997ca6f4

7 years agoUpdate to BuildTools 01316-07
Eric St. John [Thu, 16 Feb 2017 21:21:39 +0000 (13:21 -0800)]
Update to BuildTools 01316-07

Commit migrated from https://github.com/dotnet/corefx/commit/f643be311efe0721d91cb682f4b832c6dd03be68

7 years agoUpdate packageIndex to contain inbox items
Eric St. John [Thu, 16 Feb 2017 20:46:28 +0000 (12:46 -0800)]
Update packageIndex to contain inbox items

This to start I did a one-time call of UpdatePackageIndex specifying
InboxFrameworkListFolder=<buildTools>\FrameworkLists

This committed all the previous framework lists to the package index.

Then I updated using the included target to include the inbox items
from framework packages.

Commit migrated from https://github.com/dotnet/corefx/commit/f89a5385afaf3467b426c85d3b034af21f458951

7 years agoProhibit open generics in Expression.Property and Expression.Field
Jon Hanna [Thu, 16 Feb 2017 20:49:46 +0000 (20:49 +0000)]
Prohibit open generics in Expression.Property and Expression.Field

Contributes to dotnet/corefx#8081.

Also fill other testing gaps in MemberExpression.

Commit migrated from https://github.com/dotnet/corefx/commit/85c1cf00548205927195a2103ca0d87078491d14

7 years agoFix baseline for packages that no longer ship.
Eric St. John [Wed, 15 Feb 2017 18:48:17 +0000 (10:48 -0800)]
Fix baseline for packages that no longer ship.

For all libraries that no longer ship in packages, remove baseline
entries for the non-shipping versions.

Commit migrated from https://github.com/dotnet/corefx/commit/e275580fd92a863f51a56cf9245207c8a37f977d

7 years agoRemove runtime packages from package index
Eric St. John [Wed, 15 Feb 2017 18:46:18 +0000 (10:46 -0800)]
Remove runtime packages from package index

All runtime packages will be part of the framework package.

One exception (still TBD) is SqlClient's SNI.dll.

Commit migrated from https://github.com/dotnet/corefx/commit/ed5b685e7dad03c3c737fa20e573b752336aad7a

7 years agoEnable package build
Eric St. John [Wed, 15 Feb 2017 00:32:08 +0000 (16:32 -0800)]
Enable package build

This turns the package build back on and fixes all packages so that
they build.

There is still work to do to fix dependencies.

Commit migrated from https://github.com/dotnet/corefx/commit/c0f0fdd87135f9fcca0d4026819d8c388c455967

7 years agoMerge pull request dotnet/corefx#15900 from hqueue/arm/ci
Gaurav Khanna [Thu, 16 Feb 2017 16:59:53 +0000 (08:59 -0800)]
Merge pull request dotnet/corefx#15900 from hqueue/arm/ci

[ARM/CI] ARM CI script for arm and armel

Commit migrated from https://github.com/dotnet/corefx/commit/698c6b22329954ed31aa24ca9b3e66dbe97ae325

7 years agoMerge remote-tracking branch 'upstream/master' into remove-unused-args
Matt Mitchell [Thu, 16 Feb 2017 16:38:19 +0000 (08:38 -0800)]
Merge remote-tracking branch 'upstream/master' into remove-unused-args

Commit migrated from https://github.com/dotnet/corefx/commit/9db6eccf1eae6556ef29cbca64abb3fc017b6a63

7 years agoMerge pull request dotnet/corefx#16219 from dotnet/Fix_FilterToTestTFM_Removal_2
Matt Galbraith [Thu, 16 Feb 2017 07:51:26 +0000 (23:51 -0800)]
Merge pull request dotnet/corefx#16219 from dotnet/Fix_FilterToTestTFM_Removal_2

Official Test build fix

Commit migrated from https://github.com/dotnet/corefx/commit/ee5acbafbafb1128026a96afac3508f494b857e8

7 years agoTest build fix
Matt Galbraith [Thu, 16 Feb 2017 07:51:00 +0000 (23:51 -0800)]
Test build fix

2nd attempt trying to unblock Helix build break introduced by removal of FilterTo... properties.  ForUploadList was a property previously set by the build task in charge of filtering, which was broken by the removal of these variables.

Commit migrated from https://github.com/dotnet/corefx/commit/ca5e35c29f8a6ee88abe8c50863b82a5f67333e9

7 years agoMerge pull request dotnet/corefx#16218 from MattGal/Fix_SendToHelix
Matt Galbraith [Thu, 16 Feb 2017 06:38:02 +0000 (22:38 -0800)]
Merge pull request dotnet/corefx#16218 from MattGal/Fix_SendToHelix

Minimum set of changes to (hopefully) unblock Helix build.

Commit migrated from https://github.com/dotnet/corefx/commit/3a60b231ce0528216606d3cf74d5b5f9bdd86da1

7 years agoMinimum set of changes to (hopefully) unblock Helix build.
Matt Galbraith [Thu, 16 Feb 2017 06:22:57 +0000 (22:22 -0800)]
Minimum set of changes to (hopefully) unblock Helix build.

Commit migrated from https://github.com/dotnet/corefx/commit/7de038b762e2ade5e8d664283618d390265b505c

7 years agoMerge pull request dotnet/corefx#16182 from hqueue/fix/rootfs
Stephen Toub [Thu, 16 Feb 2017 03:59:41 +0000 (19:59 -0800)]
Merge pull request dotnet/corefx#16182 from hqueue/fix/rootfs

Fix build-rootfs.sh to include lldb package

Commit migrated from https://github.com/dotnet/corefx/commit/8eedc0798268025b971bfe217512f3cbe871fb72

7 years agoMerge pull request dotnet/corefx#16212 from weshaggard/MiscCleanup
Wes Haggard [Thu, 16 Feb 2017 01:52:52 +0000 (17:52 -0800)]
Merge pull request dotnet/corefx#16212 from weshaggard/MiscCleanup

Misc cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/5b01b1942f56a249623e9bfb31de35eef74f1b4f

7 years agoMerge pull request dotnet/corefx#16210 from weshaggard/FixExternalRestoring
Wes Haggard [Thu, 16 Feb 2017 01:52:35 +0000 (17:52 -0800)]
Merge pull request dotnet/corefx#16210 from weshaggard/FixExternalRestoring

Fix the project.json templating under external to not always restore

Commit migrated from https://github.com/dotnet/corefx/commit/a46da0bd926a45c14d8d71c6ead21633589378c5

7 years agoRemove FilterToOSGroup from pipeline file as it is no longer needed
Wes Haggard [Thu, 16 Feb 2017 01:01:37 +0000 (17:01 -0800)]
Remove FilterToOSGroup from pipeline file as it is no longer needed

Commit migrated from https://github.com/dotnet/corefx/commit/ffbf1ea28a1bdb9d1259080108559fbaebc635a3

7 years agoFix the project.json templating under external to not always restore
Wes Haggard [Thu, 16 Feb 2017 00:53:14 +0000 (16:53 -0800)]
Fix the project.json templating under external to not always restore

Currently we generate a project.json and project.lock.json file
for the depproj's under external and we add the files to the clean-up
list. This causes us to always delete them if we do a rebuild and thus
causes a restore to happen each time. When this was just on the depproj's
it wasn't a big deal but now we take ProjectReferences to these from other
projects and we don't want to have to do a restore everytime we do a rebuild
of an individual library.

To ensure we don't get into this state we will not clean-up these generate
project.json files unless the project.json.template is updated or we clean
the entire bin folder. While this isn't great I think it is better then
having to be online all the time to do a rebuild of an individual library.

Commit migrated from https://github.com/dotnet/corefx/commit/0c9cfb817dce76e91f0af1f2da8a2d1f47114034

7 years agoMerge pull request dotnet/corefx#16207 from weshaggard/AddBuildAllOption
Wes Haggard [Thu, 16 Feb 2017 00:50:06 +0000 (16:50 -0800)]
Merge pull request dotnet/corefx#16207 from weshaggard/AddBuildAllOption

Adds -tests option for build.cmd that will add the test build and running

Commit migrated from https://github.com/dotnet/corefx/commit/6d4d7cda2950305131b8037be10c31940e524089

7 years agoRemove all .builds files under pkg/ref/src/tests library folders
Wes Haggard [Thu, 16 Feb 2017 00:32:03 +0000 (16:32 -0800)]
Remove all .builds files under pkg/ref/src/tests library folders

Commit migrated from https://github.com/dotnet/corefx/commit/b60cbe5a2edb5ef3b88a7738507822d13d125d62

7 years agoRemove some old properties
Wes Haggard [Thu, 16 Feb 2017 00:27:36 +0000 (16:27 -0800)]
Remove some old properties

Remove *TestTFM, FilterToOSGroup

No need to explicitly pass ConfigurationGroup down for traversal projects.

Commit migrated from https://github.com/dotnet/corefx/commit/5e324e4e11bb4f5b5a750b26f43384681ed759dd

7 years agoAdds -tests option for build.cmd that will add the test build and running
Wes Haggard [Wed, 15 Feb 2017 23:37:29 +0000 (15:37 -0800)]
Adds -tests option for build.cmd that will add the test build and running

Commit migrated from https://github.com/dotnet/corefx/commit/0b5bdf94a207a9facfcdd17eb34362ffca845212

7 years agoMerge pull request dotnet/corefx#16186 from JonHanna/unbox_byref_generic_pointer
Stephen Toub [Wed, 15 Feb 2017 23:46:18 +0000 (15:46 -0800)]
Merge pull request dotnet/corefx#16186 from JonHanna/unbox_byref_generic_pointer

Test byref, pointer & generic types can't be used with Expression.Unbox

Commit migrated from https://github.com/dotnet/corefx/commit/c63ff633bd8d02174da9770d063f97c3c99c6231

7 years agoAdd back DbProviderFactory::CreatePermission (as additional implementation). (dotnet...
Egor Bogatov [Wed, 15 Feb 2017 23:45:24 +0000 (02:45 +0300)]
Add back DbProviderFactory::CreatePermission (as additional implementation).  (dotnet/corefx#16190)

* Add back CreatePermission (as additional implementation). This fixes Mono breakage.
* Add a Mono-specific comment to DbProviderFactory.CreatePermission.cs file

Commit migrated from https://github.com/dotnet/corefx/commit/afa69666e425d2b018a3105bbec08073f513aed1

7 years agoUpdate issue-guide.md
Dan Moseley [Wed, 15 Feb 2017 23:36:36 +0000 (15:36 -0800)]
Update issue-guide.md

Commit migrated from https://github.com/dotnet/corefx/commit/aeb8c178f6754f67b61acd34a813e1f52f9a9a9a

7 years agoMerge pull request dotnet/corefx#16169 from Priya91/skipnettest
Lakshmi Priya Sekar [Wed, 15 Feb 2017 23:34:25 +0000 (15:34 -0800)]
Merge pull request dotnet/corefx#16169 from Priya91/skipnettest

Disable networking test failing only on fedora and redhat.

Commit migrated from https://github.com/dotnet/corefx/commit/2e7884b43e97f5c9beb9d5bea6459470e1222537

7 years agoMerge pull request dotnet/corefx#16140 from JonHanna/type_check_labeltarget
Vladimir Sadov [Wed, 15 Feb 2017 23:29:02 +0000 (15:29 -0800)]
Merge pull request dotnet/corefx#16140 from JonHanna/type_check_labeltarget

Throw on byref or pointer types in LabelTarget

Commit migrated from https://github.com/dotnet/corefx/commit/d0aa362ec463840c62b979ac942a6065f0fd50a8

7 years agoRemoved unused arguments from the NoTest versions of the pipeline/build definitions
Matt Mitchell [Wed, 15 Feb 2017 23:28:44 +0000 (15:28 -0800)]
Removed unused arguments from the NoTest versions of the pipeline/build definitions

Commit migrated from https://github.com/dotnet/corefx/commit/07f6a18eee2f98b60eb1174fe6759dee9bcff20f