Nicolas Dufresne [Tue, 25 Mar 2014 14:49:39 +0000 (10:49 -0400)]
v4l2object: Fix support for planar format in 1 v4l2 mplane
So far we where only setting saving the first plane stride in the meta. This was
leading to wrong values in GstVideoMeta.
Nicolas Dufresne [Wed, 19 Mar 2014 21:52:08 +0000 (17:52 -0400)]
v4l2videodec: Cleanly fail if set_format is never called
Nicolas Dufresne [Wed, 19 Mar 2014 21:00:56 +0000 (17:00 -0400)]
v4l2: Expose RGB32 formats with and without alpha
As soon a the alpha component can be set, we can expose the RGB32 and BGR32
format as ARGB and BGRA as long we can deterministically set the alpha padding
value.
Nicolas Dufresne [Tue, 18 Mar 2014 19:49:49 +0000 (15:49 -0400)]
v4l2: Correctly check if video meta is needed
Correctly check if video meta is needed. In buffer pool, trust need_video_meta
flag in order to decide if configuration should succeed.
Nicolas Dufresne [Tue, 18 Mar 2014 19:45:18 +0000 (15:45 -0400)]
v4l2object: Fix tiled stride request
Fix stride request for tiled format and improve logging.
Nicolas Dufresne [Tue, 18 Mar 2014 15:53:57 +0000 (11:53 -0400)]
v4l2object: Ensure video and crop meta are enabled if needed
In certain cases we cannot live without video meta and/or crop meta
being enabled in our internal buffer pool. Ensure this is always the case,
regardless of having support for allocation query.
Nicolas Dufresne [Sun, 16 Mar 2014 17:39:32 +0000 (18:39 +0100)]
v4l2videodec: Ensure internal pool are activated
Nicolas Dufresne [Sun, 16 Mar 2014 16:01:10 +0000 (17:01 +0100)]
v4l2videodec: Check that pool where allocated before flushing them
Upon error, the pools might not have been allocated yet, hence we should not
try and flush them (even though we still want to make sure the processing thread
is fully stopped).
Nicolas Dufresne [Sun, 16 Mar 2014 15:55:43 +0000 (16:55 +0100)]
v4l2bufferpool: Enforce activation outside of process
Enforce pool being activate from before calling pool process. This should
help catching basic errors in the usage of buffer pool.
Nicolas Dufresne [Sun, 16 Mar 2014 11:44:14 +0000 (12:44 +0100)]
v4l2object: don't use own pool if downstream don't support video meta
Nicolas Dufresne [Thu, 13 Mar 2014 23:31:32 +0000 (00:31 +0100)]
v4l2bufferpool: Use obj->n_v4l2_planes for correct number of planes
Buffer pool was guessing wrongly the number of planes rather
then reading the value from obj->n_v4l2_planes. This was causing
format YU12 (I420) to fail upon check.
Nicolas Dufresne [Fri, 7 Mar 2014 21:39:29 +0000 (16:39 -0500)]
v4l2object: Fix handling of contiuous vs non-contiguous support
The complex mechanic to try and choose the right thing did not work. Instead,
simply probe the non-contiguous format first and then the contiguous one.
This is in fact very low overhead, as there is a relatively small number of
pixel format supported by each devices.
Nicolas Dufresne [Tue, 15 Apr 2014 19:07:23 +0000 (15:07 -0400)]
v4l2: Add initial support for alignment and cropping
Nicolas Dufresne [Thu, 13 Mar 2014 18:24:51 +0000 (19:24 +0100)]
v4l2object: Rename setup_format() method into acquire_format()
The setup_format() was confusing since it does not set anything, in fact
it reads the setup from the driver and save it.
Nicolas Dufresne [Thu, 13 Mar 2014 17:21:41 +0000 (18:21 +0100)]
v4l2object: Move type declaration to the top
Nicolas Dufresne [Wed, 12 Mar 2014 17:07:38 +0000 (18:07 +0100)]
v4l2videodec: Protect NULL pool while going to READY
When the pipeline fails early, the pool might be unset before the processing
thread has run once. Add protection against that.
Nicolas Dufresne [Wed, 12 Mar 2014 17:01:09 +0000 (18:01 +0100)]
v4l2object: Fail cleanly if pixel format is unkown or not raw video
Certain decoder has been found to not choose a format automatically. Running
v4l2videodec on these would assert. This patch will make it fail cleanly
instead.
Nicolas Dufresne [Wed, 12 Mar 2014 16:56:18 +0000 (17:56 +0100)]
v4l2videodec: Clear the input state pointer after unref
If caps are set again, we have a risk od returning from set_format with a
input_state pointing to dead memory. Clearing the pointer after unref fix
this issue.
Nicolas Dufresne [Wed, 12 Mar 2014 16:11:16 +0000 (17:11 +0100)]
v4l2videodec: handle stop being called without flush
Uppon certain downstream error, stop() is called without a flush(). This mean that
the streaming thread may still be running even though unlock has been called.
Now calling flush to reset the decoder state if we are processing.
Nicolas Dufresne [Thu, 6 Mar 2014 23:13:14 +0000 (18:13 -0500)]
v4l2videodec: Default to template in caps query
Nicolas Dufresne [Tue, 11 Mar 2014 18:23:32 +0000 (14:23 -0400)]
v4l2videodec: Ensure processing thread has stopped when draining
Nicolas Dufresne [Tue, 11 Mar 2014 18:01:27 +0000 (14:01 -0400)]
v4l2videodec: Don't drain if processing thread is inactive
Sebastian Dröge [Thu, 8 May 2014 07:49:24 +0000 (09:49 +0200)]
souphttpsrc: Clean up all pending operations from libsoup before unreffing our context
When we cancel connection attempts and similar things, there are still
some operations pending on our main context from the GCancellables. We
should let them all run before unreffing our context, otherwise we leak
file descriptors.
Unfortunately this requires libsoup 2.47.0 or newer as earlier versions
steal our main context from us and we can't use it for cleanup later
without assertions and funny crashes.
Based on a patch by Dmitry Shatrov <shatrov@gmail.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=663944
Tim-Philipp Müller [Wed, 7 May 2014 14:49:39 +0000 (15:49 +0100)]
tests: fix compilation of souphttpsrc test for libsoup 2.40 for real
https://bugzilla.gnome.org/show_bug.cgi?id=727329
Tim-Philipp Müller [Wed, 7 May 2014 12:23:50 +0000 (13:23 +0100)]
tests: fix compilation of souphttpsrc test for libsoup 2.40
SOUP_CHECK_VERSION was only added in 2.41, but we only
depend on 2.40.
https://bugzilla.gnome.org/show_bug.cgi?id=727329
Tim-Philipp Müller [Tue, 6 May 2014 23:58:15 +0000 (00:58 +0100)]
flacparse: skip PICTURE headers without any image data
Fixes warning if the image length is 0.
Руслан Ижбулатов [Tue, 6 May 2014 09:22:18 +0000 (09:22 +0000)]
configure: use X11 detection macro from common
https://bugzilla.gnome.org/show_bug.cgi?id=729621
Guillaume Desmottes [Wed, 30 Apr 2014 09:13:12 +0000 (11:13 +0200)]
rtp/README: update pipelines to work with 1.0
- Use gst-libav encoders/decoders instead of gst-ffmpeg
- gstrtpjitterbuffer -> rtpjitterbuffer
- gst-launch-0.10 -> gst-launch-1.0
- Add 'videoconvert' element
- xvimagesink -> autovideosink
https://bugzilla.gnome.org/show_bug.cgi?id=729247
Vincent Penquerc'h [Mon, 5 May 2014 13:41:05 +0000 (14:41 +0100)]
matroska: rejig test to avoid undefined shift behavior
Coverity 1195121, 1195120
Vincent Penquerc'h [Mon, 5 May 2014 13:33:38 +0000 (14:33 +0100)]
vp9enc: do not dereference NULL pointer
Coverity 1197703
Vincent Penquerc'h [Mon, 5 May 2014 13:32:06 +0000 (14:32 +0100)]
matroskamux: ensure we don't dereference a NULL pointer
while working out the codec ID.
Coverity 1195148
Tim-Philipp Müller [Mon, 5 May 2014 11:07:25 +0000 (12:07 +0100)]
v4l2: minor fix for closing the fd
The fd returned by open() could theoretically be 0 as well.
Coverity CID 1211823.
Olivier Crête [Mon, 5 May 2014 00:23:29 +0000 (20:23 -0400)]
rtpaux/rtprtx: Make tests non-racy
Fix the raciness by iterating on a condition instead of using the gmainloop.
Don't use the EOS as the target, otherwise the retransmission of the last
packets are lost. Also count the retranmissions requests that are dropped.
Check the condition before blocking on the GCond
https://bugzilla.gnome.org/show_bug.cgi?id=728501
Olivier Crête [Mon, 5 May 2014 02:32:54 +0000 (22:32 -0400)]
rtprtxreceive: Wait until timeout to clear association requests
If two streams request a retranmission for the same SSRC, ignore the second
one if the first oen is less than one second old, otherwise time out the first
one and ignore the second.
Olivier Crête [Sun, 4 May 2014 22:59:33 +0000 (18:59 -0400)]
rtpmux: Always let upstream chose the ssrc if it wishes
Mark Nauwelaerts [Sun, 4 May 2014 11:37:46 +0000 (13:37 +0200)]
rtpjitterbuffer: avoid stall by corrupted seqnum accounting
Olivier Crête [Sun, 4 May 2014 05:14:33 +0000 (01:14 -0400)]
pulsedevicemonitor: Index are per facility, not global
So need to keep the type of device in the device object
Olivier Crête [Sun, 4 May 2014 05:13:24 +0000 (01:13 -0400)]
pulsedevicemonitor: pa_subscription_event_t are enums, not flags
Coverity 1195132
Nicolas Dufresne [Sat, 3 May 2014 02:42:54 +0000 (22:42 -0400)]
v4l2devicemonitor: Port to use GstV4l2Iterator
https://bugzilla.gnome.org/show_bug.cgi?id=727925
Nicolas Dufresne [Sat, 3 May 2014 01:38:30 +0000 (21:38 -0400)]
v4l2: Use single pass iterator for M2M probe
Instead of having each M2M class do their own probing, use the
GstV4l2Iterator and probe all devices in a single pass.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
Nicolas Dufresne [Fri, 2 May 2014 20:55:05 +0000 (16:55 -0400)]
v4l2: Add a common device enumerator
This will allow removing code duplication (hence bugs duplication).
https://bugzilla.gnome.org/show_bug.cgi?id=727925
Nicolas Dufresne [Sun, 16 Mar 2014 10:38:07 +0000 (11:38 +0100)]
v4l2videodec: Simplify sub-instanciation mechanism
Simplify sub-instanciation by defining an absract type and using subtype
class and instance init callback. This also fixes a bug where the template
pads get initialized too late.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
Nicolas Dufresne [Fri, 2 May 2014 22:18:26 +0000 (18:18 -0400)]
v4l2: Cleanup plugin registration
There is no plan to introduce special sources for jpeg, te v4l2src works fine
for this.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
Olivier Crête [Sat, 3 May 2014 22:30:20 +0000 (18:30 -0400)]
rtpsession: Keep local conflicting addresses in the session
As we now replace the local RTPSource on a conflict, it's no longer possible
to keep local conflicts in the RTPSource, so they instead need to be kept
in the RTPSession.
Also fix the rtpcollision test to generate multiple collisions instead of
one by change the address, as otherwise we detected that it was a single one.
Sebastian Dröge [Sat, 3 May 2014 18:48:30 +0000 (20:48 +0200)]
Back to development
Sebastian Dröge [Sat, 3 May 2014 16:02:23 +0000 (18:02 +0200)]
Release 1.3.1
Sebastian Dröge [Sat, 3 May 2014 16:02:01 +0000 (18:02 +0200)]
Update .po files
Sebastian Dröge [Sat, 3 May 2014 15:22:45 +0000 (17:22 +0200)]
po: Update translations
Sebastian Dröge [Sat, 3 May 2014 09:43:21 +0000 (11:43 +0200)]
shapewipe: Send initial events after setting the elements to PLAYING
Otherwise we send them too early, and setting the elements to PLAYING
afterwards will drop all the events again.
Sebastian Dröge [Sat, 3 May 2014 08:15:03 +0000 (10:15 +0200)]
Automatic update of common submodule
From bcb1518 to 211fa5f
Sebastian Dröge [Fri, 2 May 2014 15:12:29 +0000 (17:12 +0200)]
imagefreeze: Set segment position to the stop position of the buffer
Sebastian Dröge [Fri, 2 May 2014 15:10:18 +0000 (17:10 +0200)]
imagefreeze: Properly report errors before stopping the srcpad task
Sebastian Dröge [Fri, 2 May 2014 15:02:02 +0000 (17:02 +0200)]
imagefreeze: Error out if we have no caps yet
Vincent Penquerc'h [Fri, 2 May 2014 13:49:27 +0000 (14:49 +0100)]
wavparse: avoid dividing by a 0 blockalign
This can be 0. In that case, do not try to cut off the last few
bytes from the last buffer.
Coverity 1146971
Vincent Penquerc'h [Fri, 2 May 2014 13:25:01 +0000 (14:25 +0100)]
matroskamux: do not use uinitialized clut on error
If we're missing part of the clut, do not try to use it. It seems
very likely the break was meant to break out of the switch rather
than from the loop.
Coverity 1139878
Vincent Penquerc'h [Fri, 2 May 2014 13:18:08 +0000 (14:18 +0100)]
flxdec: fix integer overflow
Coverity 1139859
Vincent Penquerc'h [Fri, 2 May 2014 13:09:02 +0000 (14:09 +0100)]
rtpqdmdepay: remove pointless check
Besides, the pointer was dereferenced earlier anyway.
Coverity 1139853
Vincent Penquerc'h [Fri, 2 May 2014 13:06:25 +0000 (14:06 +0100)]
rtspsrc: remove duplicate test
item was dereference previously.
While there, reorder some test for faster early out.
Coverity 1139844
Vincent Penquerc'h [Fri, 2 May 2014 13:02:52 +0000 (14:02 +0100)]
vp8enc: guard against NULL pointer dereference
Coverity 1139838
Vincent Penquerc'h [Fri, 2 May 2014 12:59:07 +0000 (13:59 +0100)]
flacdec: fix theoretical integer overflow
This code isn't actually used at the moment, unsure if I should
just remove it or not...
Coverity 1139811
Vincent Penquerc'h [Fri, 2 May 2014 12:33:02 +0000 (13:33 +0100)]
matroska: blindly fix writing variable length negative values
Spotted while fixing something else in the area.
Nothing calls this with a negative value.
Vincent Penquerc'h [Fri, 2 May 2014 12:29:33 +0000 (13:29 +0100)]
matroska: do not lose the top bits when writing a > 32 bit value
Coverity 1139806
Vincent Penquerc'h [Fri, 2 May 2014 11:10:26 +0000 (12:10 +0100)]
videoflip: add missing break in switch
Coverity 1139755
Vincent Penquerc'h [Fri, 2 May 2014 10:39:39 +0000 (11:39 +0100)]
matroska: do not try to call gst_pad_query_default on a NULL pad
gst_matroska_parse_query can be called explicitely with a NULL pad.
If we reach this point with a NULL pad, fail the query.
Coverity 1139715
Vincent Penquerc'h [Fri, 2 May 2014 10:28:01 +0000 (11:28 +0100)]
matroska: do not return GST_FLOW_OK if we did not get a buffer
Coverity 1139714 (which will likely come back in another guise,
as the _read_init call can have a failing _map)
Vincent Penquerc'h [Fri, 2 May 2014 10:20:33 +0000 (11:20 +0100)]
matroska: catch failure to map buffer
Avoids dereferencing NULL.
Coverity 1139712
Vincent Penquerc'h [Fri, 2 May 2014 09:52:44 +0000 (10:52 +0100)]
avimux: refuse caps with invalid framerate
Coverity 1139701
Vincent Penquerc'h [Fri, 2 May 2014 09:21:09 +0000 (10:21 +0100)]
qtmux: handle 0 size packets without dividing by 0
Coverity 1139691
Vincent Penquerc'h [Fri, 2 May 2014 08:49:32 +0000 (09:49 +0100)]
qtdemux: guard against invalid frame size to avoid division by 0
Coverity 1139690
Vincent Penquerc'h [Fri, 2 May 2014 08:49:17 +0000 (09:49 +0100)]
qtdemux: trivial typo fix
Vincent Penquerc'h [Fri, 2 May 2014 08:43:54 +0000 (09:43 +0100)]
speexdec: remove dead code
fpp can never equal 0 here, or the loop would not execute at all.
Zero fpp was possible before as the loop condition was allowing
it specifically, but no more.
Coverity 1139681
Vincent Penquerc'h [Fri, 2 May 2014 08:41:19 +0000 (09:41 +0100)]
oss4: remove dead mixer code
This was partly removed in the port to 0.11. If still needed,
it's still there in the history.
Coverity 1139687
Vincent Penquerc'h [Fri, 2 May 2014 08:33:51 +0000 (09:33 +0100)]
oss4: fix a missing unlock and a return-only-when-assertions-enabled
Spotted on the side while looking at another issue.
Nicolas Dufresne [Fri, 7 Mar 2014 22:31:29 +0000 (17:31 -0500)]
v4l2: Correctly map RGB32 format
In v4l2 specification, RGB32 has the alpha, or pading, first, not last.
See http://linuxtv.org/downloads/v4l-dvb-apis/packed-rgb.html .
https://bugzilla.gnome.org/show_bug.cgi?id=540941
Vincent Penquerc'h [Wed, 30 Apr 2014 17:06:40 +0000 (18:06 +0100)]
flacdec: remove dead code
For 8 bit width, we always have depth==gdepth==width==8.
Coverity 1139678
Vincent Penquerc'h [Wed, 30 Apr 2014 16:48:53 +0000 (17:48 +0100)]
mpegaudioparse: remove dead code
A stricer check is already done earlier, and integer overflows
do not seem possible here.
Coverity 1139675
Vincent Penquerc'h [Wed, 30 Apr 2014 13:50:44 +0000 (14:50 +0100)]
rtpvrawpay: guard against pathological "no space" condition
Even if one woul hope one pixel can fit in a MTU, ensure we do not
overwrite a buffer if this is not the case.
Spotted while looking at Coverity 1208786
Vincent Penquerc'h [Wed, 30 Apr 2014 10:52:10 +0000 (11:52 +0100)]
rtpjpegdepay: sanity check for NULL qtable
Can happen (at least in crafted stream)
Coverity 1208778
Tim-Philipp Müller [Wed, 30 Apr 2014 00:08:41 +0000 (01:08 +0100)]
wavparse: pass on tags from upstream if there are any
Don't just ignore upstream tags from e.g. an ID3 tag before
the .wav data, pass them on downstream.
https://bugzilla.gnome.org/show_bug.cgi?id=729223
Wim Taymans [Tue, 29 Apr 2014 14:26:53 +0000 (16:26 +0200)]
rtpjitterbuffer: optimize timer update
When we are not doing retransmission, we just need to find the current
seqnum so we can stop when we found it.
Wim Taymans [Tue, 29 Apr 2014 14:21:44 +0000 (16:21 +0200)]
rtpjitterbuffer: small optimizations
Small optimizations where we can.
Add some more debug.
Wim Taymans [Tue, 29 Apr 2014 14:16:17 +0000 (16:16 +0200)]
rtpjitterbuffer: signal when next_seqnum changed
Signal the pushing thread when the next_seqnum changed and we might be
able to push a buffer now.
Wim Taymans [Tue, 29 Apr 2014 14:12:29 +0000 (16:12 +0200)]
rtpjitterbuffer: only signal event when head changed
After adding a buffer, only signal the pushing thread when the head
buffer changed or else we cause a useless wakeup.
Wim Taymans [Tue, 29 Apr 2014 13:29:31 +0000 (15:29 +0200)]
rtpjitterbuffer: rework packet insert
Rework the packet queue so that the most common action (insert a packet
at the tail of the queue) goes very fast.
Report if a packet was inserted at the head instead of the tail so that
we can know when to retry _pop or _peek.
Wim Taymans [Mon, 28 Apr 2014 12:41:10 +0000 (14:41 +0200)]
rtpvraw: use plane pointers when needed
Pack/unpack planar formats to/from the first plane.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=729058
Sebastian Dröge [Mon, 28 Apr 2014 07:47:10 +0000 (09:47 +0200)]
souphttpsrc: Remember if a redirect is permanent or not and store it in the query
Nicolas Dufresne [Mon, 28 Apr 2014 01:57:31 +0000 (21:57 -0400)]
goom: Remove french comment saying to prefix functions
All non-static function in this file are already prefixed with goom_.
Tim-Philipp Müller [Sun, 27 Apr 2014 23:20:47 +0000 (00:20 +0100)]
goom: fix compilation on ios-arm7-10.9 and osx-x86_64
uint is not a standard type, and the rest of the code uses
Uint which is locally typedefed to unsigned int.
https://bugzilla.gnome.org/show_bug.cgi?id=729067
Luis de Bethencourt [Sun, 27 Apr 2014 22:29:11 +0000 (18:29 -0400)]
goom: fix undefined behaviour of left-shift
Don't left-shift into the sign bit, the result is undefined and potentially
an overflow could flip the sign.
Luis de Bethencourt [Sun, 27 Apr 2014 00:51:36 +0000 (20:51 -0400)]
qtdemux: check return from qt_demux_video_caps
Now qtdemux_video_caps() can return NULL. We need to check this return before
using it's value.
https://bugzilla.gnome.org/show_bug.cgi?id=728987
Tim-Philipp Müller [Sat, 26 Apr 2014 22:35:17 +0000 (23:35 +0100)]
docs: remove outdated and pointless 'Last reviewed' lines from docs
They are very confusing for people, and more often than not
also just not very accurate. Seeing 'last reviewed: 2005' in
your docs is not very confidence-inspiring. Let's just remove
those comments.
Luis de Bethencourt [Fri, 25 Apr 2014 21:58:42 +0000 (17:58 -0400)]
qtdemux: initialize caps pointer to null
Make sure the caps pointer returns initialized when using it in
qtdemux_parse_tree ().
https://bugzilla.gnome.org/show_bug.cgi?id=728987
Jan Schmidt [Tue, 22 Apr 2014 07:07:38 +0000 (17:07 +1000)]
rtpjitterbuffer: Clear last_pt on flush-stop.
Otherwise, we don't recheck the buffer caps for clock-rate
properly on the next chain.
Sebastian Dröge [Tue, 22 Apr 2014 15:29:02 +0000 (17:29 +0200)]
deinterlace: Fix compiler warning
gstdeinterlace.c: In function 'gst_deinterlace_output_frame':
gstdeinterlace.c:1537:57: error: 'pattern.length' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This actually is always initialized before it is used there, but
let's just silence gcc here.
Vincent Penquerc'h [Mon, 21 Apr 2014 14:58:45 +0000 (15:58 +0100)]
rtpmux: fix buffer list drop check
While porting to 0.11, the check was mistakenly made constant,
instead of testing for the return value of process_buffer_locked.
Coverity 1139663
Vincent Penquerc'h [Mon, 21 Apr 2014 12:44:15 +0000 (13:44 +0100)]
matroska: fix content encoding scope validity check
It's 3 bits, and http://matroska.org/technical/specs/index.html
says it can't be 0.
Coverity 1139660
Vincent Penquerc'h [Mon, 21 Apr 2014 12:34:37 +0000 (13:34 +0100)]
matroskamux: fix PAR fraction sanity check
It was checking par_num twice, and never par_denum.
Coverity 1139634
Vincent Penquerc'h [Mon, 21 Apr 2014 12:32:40 +0000 (13:32 +0100)]
multiidpsink: warn when setsockopt fails
This doesn't seem to be fatal, but it's good to let the user know
in the logs.
Coverity 1139630
Vincent Penquerc'h [Mon, 21 Apr 2014 12:27:24 +0000 (13:27 +0100)]
interlace: catch failure to create audio info from caps
Coverity 1139627, 1139628
Göran Jönsson [Thu, 13 Mar 2014 08:37:48 +0000 (09:37 +0100)]
gstrtph264pay: Reset sps pps variable when state change.
Reset last_spspps and sps/pps arrays when state transition
GST_STATE_CHANGE_PAUSED_TO_READY.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726015