Mike Blumenkrantz [Wed, 15 Aug 2018 08:45:06 +0000 (09:45 +0100)]
elm/list: use while() loop to iterate item list during smart delete
Summary:
using EINA_LIST_FREE here double deletes 2 list items on every iteration
due to recursive list removals, which prevents some items from being
deleted as expected
fix T7266
Reviewers: netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7266
Differential Revision: https://phab.enlightenment.org/D6829
Mike Blumenkrantz [Mon, 6 Aug 2018 18:26:08 +0000 (14:26 -0400)]
tests/elm: remove elm_test_helper.(c|h) files
these timer functions are only used by fileselector and I'm trying to consolidate
timer usage
no functional changes
Differential Revision: https://phab.enlightenment.org/D6768
Mike Blumenkrantz [Mon, 6 Aug 2018 18:03:48 +0000 (14:03 -0400)]
tests/naviframe: add test to verify preserve_on_pop functionality
this adds a naviframe with button content and pushes/pops the stack
a couple times to see if a delete callback is called on the button
ref T7236
Differential Revision: https://phab.enlightenment.org/D6762
Mike Blumenkrantz [Tue, 14 Aug 2018 21:26:08 +0000 (17:26 -0400)]
tests/eina: suppress deprecated api warnings for eina abi test
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6810
Marcel Hollerbach [Tue, 14 Aug 2018 21:12:07 +0000 (17:12 -0400)]
evas: support wayland static engine loading
Summary: This fixes static loading of the here changes engines.
Reviewers: ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6795
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:53 +0000 (17:11 -0400)]
elm/win: skip frame updating if csd is not active
Summary:
this avoids extra recalcs and resizes when csd is not active, which has
the side benefit of not breaking the x11 engine's behavior--currently only
an issue because the ecore-evas x11 backend does not have an implementation
of ConfigureNotify event handling which is even remotely correct
these issues will be resolved in future patches
fix T7243
ref T7008
Reviewers: devilhorns, ManMower
Reviewed By: devilhorns, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Maniphest Tasks: T7243, T7008
Differential Revision: https://phab.enlightenment.org/D6794
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:31 +0000 (17:11 -0400)]
ecore-evas/x: rework draw_block unsetting from ConfigureNotify
Summary:
draw_block should only be unset if the event is triggered by the wm
or the window is an override, otherwise it prematurely begins rendering
the window at a size which may or may not be accurate
ref T7008
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Maniphest Tasks: T7008
Differential Revision: https://phab.enlightenment.org/D6793
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:32 +0000 (17:09 -0400)]
ecore/main: only update loop_time during loop iteration if the change is monotonic
Summary:
in the case where the user has called loop_time_set with a value in the future,
avoid setting the loop time to something that would potentially cause a callback
to occur with a loop_time value before a previous occurrence of that callback
@fix
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_main_loop
Differential Revision: https://phab.enlightenment.org/D6764
Marcel Hollerbach [Tue, 14 Aug 2018 21:09:22 +0000 (17:09 -0400)]
eina_vpath: specilice the eina_vpath headers
Summary: For now its beta, and the since tag is added.
Reviewers: zmike
Reviewed By: zmike
Subscribers: #reviewers, kimcinoo, Hermet, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6751
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:11 +0000 (17:09 -0400)]
build: fix evas static build of gl engines
Summary:
when gl_common is built statically, the include directories for it need
to be added to the main evas library build
@fix
Reviewers: devilhorns, vtorri, ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6681
Alastair Poole [Tue, 14 Aug 2018 19:48:27 +0000 (15:48 -0400)]
elm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN
Summary:
As with other checks in ELM return if object is not yet
finalized. This stops lots of console noise.
@fix T7265
Test Plan:
elementary_test: use panel test from console and view the noise
from EINA. Apply then do the same.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, zmike
Tags: #efl
Maniphest Tasks: T7265
Differential Revision: https://phab.enlightenment.org/D6826
Chris Michael [Tue, 14 Aug 2018 14:45:30 +0000 (15:45 +0100)]
elementary: Check for valid cursor_rect when (un)setting focus
Summary:
As the cursor_rect for elm_code_widget is not created until the code
widget gets focus, we cannot just assume it is already there when
trying to emit a focus signal. The cursor_rect does not get created
until widget_cursor_update is called.
This fixes an issue where NULL is passed to efl_layout_signal_emit.
To test this, just launch elementary_test and click the Code Editor
test. As soon as you try to click into the Code Editor, this gets
triggered.
ref T7030
Reviewers: netstar, ajwillia.ms
Reviewed By: netstar
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6701
Mike Blumenkrantz [Tue, 14 Aug 2018 14:45:13 +0000 (10:45 -0400)]
edje: unset internal _need_imf flag on shutdown
Summary:
failing to unset this causes the ecore_imf flag to go negative if edje
is ever completely shut down twice
@fix
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: ManMower, #reviewers, cedric, #committers
Tags: #efl_layout_engine, #easy
Differential Revision: https://phab.enlightenment.org/D6763
Jaehyun Cho [Tue, 14 Aug 2018 14:19:16 +0000 (10:19 -0400)]
theme: add programs for deferred naviframe push/pop signals
Summary:
Naviframe provides deferred push/pop signals to begin transition effect and
not to emit signals frequently for transition callbacks.
To handle the deferred naviframe push/pop signals, programs which catch the
signals are added.
@fix
Test Plan: Test naviframe in elementary_test by pressing next and prev buttons.
Reviewers: zmike, Hermet
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6823
Yeongjong Lee [Thu, 9 Aug 2018 08:36:27 +0000 (08:36 +0000)]
tests/genlist: add focus test
This adds test for simulating focus state.
Differential Revision: https://phab.enlightenment.org/D6800
Marcel Hollerbach [Thu, 9 Aug 2018 08:52:55 +0000 (10:52 +0200)]
efl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL
Otherwise we might end up with focus beeing NULL.
Differential Revision: https://phab.enlightenment.org/D6803
Marcel Hollerbach [Thu, 9 Aug 2018 08:50:44 +0000 (10:50 +0200)]
efl_ui_focus_manager_calc: fix unregistering the root of a redirect
There is often a tree of elements registered in a manager that are
having all the same redirect element. Unserting the redirect property
just because the node has this redirect element is not helpfull as this
would break basically elm_tests button search. However, if it is the
container itself, then the redirect can be unset, as nothing else can
ever reach again the redirect manager.
ref D6800
Differential Revision: https://phab.enlightenment.org/D6802
Marcel Hollerbach [Thu, 9 Aug 2018 08:38:27 +0000 (10:38 +0200)]
efl_ui_focus_manager: adjust pop history pop
It now searches for a element if the focus stack is empty.
Differential Revision: https://phab.enlightenment.org/D6801
Felipe Magno de Almeida [Mon, 13 Aug 2018 15:12:44 +0000 (11:12 -0400)]
efl-cxx: Add -Wno-shadow to disable huge warnings in C++
Summary:
-Wno-shadow warnings disable a improper warning directive for C++, this is made because
it is common for people to use the same CFLAGS as CXXFLAGS, enabling, unadvertadly, the
smae warning for C and C++.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6821
chris [Mon, 13 Aug 2018 14:55:52 +0000 (10:55 -0400)]
Elementary test : add a checkbox to hide beta apis.
Reviewers: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6817
Marcel Hollerbach [Mon, 13 Aug 2018 13:57:47 +0000 (09:57 -0400)]
emotion: make intree running work
Summary:
before it would have only worked if there would have been the
architecture in the path, which was definitly not the case.
This fixes the problems.
Depends on D6795
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6819
Xavi Artigas [Mon, 13 Aug 2018 11:03:39 +0000 (07:03 -0400)]
elm: bring back elm/uiclock
Summary:
It turns out elm/uiclock (which was removed in
89675c3219) is actually used,
at least by the datetime legacy widget. Removing this widget broke the
datetime_example test.
This commit reverts
89675c3219 and fixes the elm/uiclock part names:
- Part names are prefixed with 'elm.'
- efl_ui_clock.c (which is used for both the new efl and the legacy elm widgets)
now looks for part names with 'efl.' and 'elm.' prefixes, and without any
prefix, for compatibility with older themes.
Fixes T6928
Test Plan: the Datetime elementary_test (and all other clock-related tests) now work.
Reviewers: zmike, jsuya, CHAN, devilhorns, Jaehyun_Cho
Reviewed By: zmike, jsuya, CHAN
Subscribers: #reviewers, Jaehyun, Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T6928
Differential Revision: https://phab.enlightenment.org/D6577
Mike Blumenkrantz [Mon, 13 Aug 2018 06:07:31 +0000 (15:07 +0900)]
elm/naviframe: implement invalidate method for naviframe items
Summary:
move most of the _item_free() calls to the invalidate method and unset some
delete callbacks on content items to avoid invalid calls during deletion
calling any of this during the object destructor is invalid because the parent
object can no longer be accessed at this time
fix T7236
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, stefan_schmidt, cedric, #committers
Tags: #efl_widgets
Maniphest Tasks: T7236
Differential Revision: https://phab.enlightenment.org/D6759
Marcel Hollerbach [Sun, 12 Aug 2018 08:21:19 +0000 (10:21 +0200)]
eio: fix poll backend
it seems that this should have been a pop call, not the function
pointer. This key eina_array_pop is never used. Nor would the array get
smaller, so i assume this should be a pop call.
Differential Revision: https://phab.enlightenment.org/D6814
Yeongjong Lee [Fri, 10 Aug 2018 16:49:50 +0000 (12:49 -0400)]
elm_map: add EINA_UNUSED to avoid build warning
Test Plan: make
Reviewers: devilhorns, zmike
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6813
Hermet Park [Fri, 10 Aug 2018 16:06:42 +0000 (12:06 -0400)]
evas gl_common: code refactoring.
Summary: use boolean instead int, no logic changes.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6807
Derek Foreman [Fri, 10 Aug 2018 15:38:25 +0000 (11:38 -0400)]
ee_wayland: Remove spurious manual_render
Summary:
The line prior to this damages the canvas and should result in a render
anyway.
Forcing a manual render here (without regard to the manual_render_set
state) will cause a post render callback to fire for clients that
think they've disabled automatic rendering.
fix T7275
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7275
Differential Revision: https://phab.enlightenment.org/D6809
JunsuChoi [Fri, 10 Aug 2018 02:02:16 +0000 (11:02 +0900)]
elm_image : Remove unnecessary test about image
Summary:
The elm_transit test is in test_transit.c.
Testing for elm_transit in test_image.c is unnecessary
Test Plan: elementary_test -to "image click"
Reviewers: Hermet, #reviewers, eunue
Reviewed By: Hermet, #reviewers
Subscribers: cedric, akanad, bowonryu, #reviewers, YOhoho, #committers, JackDanielZ, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6799
Mike Blumenkrantz [Thu, 9 Aug 2018 19:51:41 +0000 (15:51 -0400)]
ecore-evas: make manual_render_set a no-op when setting the current value
Summary:
this should not take any action if the existing value of manual_render is
set to the passed value
Reviewers: devilhorns, kimcinoo, ManMower
Reviewed By: devilhorns, kimcinoo, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers
Tags: #efl_display_system
Differential Revision: https://phab.enlightenment.org/D6786
Yeongjong Lee [Thu, 9 Aug 2018 15:19:46 +0000 (11:19 -0400)]
evas: add safety check code to avoid crash
Test Plan: evas_smart_objects_calculate(NULL);
Reviewers: zmike, Hermet, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6805
Stefan Schmidt [Thu, 9 Aug 2018 09:42:35 +0000 (11:42 +0200)]
release: Update NEWS and bump version for 1.21.0-beta2 release
Carsten Haitzler (Rasterman) [Tue, 24 Jul 2018 08:49:50 +0000 (17:49 +0900)]
elm genlist - remove execsivve calls where we could do less eo lookups
something to help T6580 ... but not that much (0.3% fewer eo calls)
Derek Foreman [Wed, 8 Aug 2018 20:58:33 +0000 (16:58 -0400)]
ee_drm: Fix tick job timestamps for funny GPU clocks
Summary:
The animator timestamps were only getting the offset applied when they
came from page flips. The "early tick" logic failed to apply the offset.
This likely only changes behaviour on vmware's graphics stack, and
only the env var ECORE_EVAS_DRM_GPU_CLOCK_WRONG is set.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: bu5hm4n, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6792
Mike Blumenkrantz [Wed, 8 Aug 2018 16:09:55 +0000 (12:09 -0400)]
build: explicitly add eolian generated files to CLEANFILES
these are all being generated now so they must also be cleaned for
distcheck to pass
Differential Revision: https://phab.enlightenment.org/D6782
Derek Foreman [Wed, 8 Aug 2018 18:58:47 +0000 (14:58 -0400)]
ee_wayland: Update configured state on short-circuit ack-configure
Summary:
When we BAIL from the configure callback with an immediate ack we don't
properly update state, commit the ack, or allow ecore_wl2 to process
a deferred ack_configure that happened during async rendering.
Using a commit here instead should update internal state properly.
ref T7243
Depends on D6783
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7243
Differential Revision: https://phab.enlightenment.org/D6784
Derek Foreman [Wed, 8 Aug 2018 18:58:44 +0000 (14:58 -0400)]
Revert "ee_wayland: Remove pointless ack_configure"
Summary:
This reverts commit
a61f254f19df163c860235e6c19e0d65ce9eb0c4.
and a follow up commit that removed some warnings
Apparently this is instrumental in enlightenment's window maximize
animation processing.
The removed bits would force an ack configure when an inbound
configure didn't result in a change that would cause a re-render.
Since this calculation needs knowledge of state ecore_wl2 doesn't
track, it does need to happen here.
ref T7243
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7243
Differential Revision: https://phab.enlightenment.org/D6783
Stephen Houston [Wed, 8 Aug 2018 18:57:00 +0000 (14:57 -0400)]
efl/ui_format: Use STRING type for format strings that contain %%
Summary: This fixes progressbar format strings that contain the pattern %%, thus making it a string and not a format.
Test Plan: elementary_test progressbar shows %% on the first vertical progressbar before this patch. afterwords it shows % correctly.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6790
Mike Blumenkrantz [Wed, 8 Aug 2018 13:45:30 +0000 (09:45 -0400)]
build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Summary:
this needs to be consistent so that it can be used reliably across suites
also these build flags really need to be consolidated into a single variable
that can be reused
Depends on D6666
Reviewers: devilhorns, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6731
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:22 +0000 (09:39 -0400)]
efl_ui_composition: remove all registered children on unregister
Summary:
ensure that all the children are gone once we unregister the widget
itself. This helps widgets that are not cleaning up theire children /
items on invalidation.
ref T7213.
Reviewers: CHAN, YOhoho, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7213
Differential Revision: https://phab.enlightenment.org/D6754
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:15 +0000 (09:39 -0400)]
efl_ui_focus_composition: do not call legacy API here
Summary:
calling this on a object that is legacy is not going to work. And will
print a error. This will make new widgets less verbose.
ref T7213
Depends on D6755
Reviewers: YOhoho, zmike, CHAN
Reviewed By: YOhoho
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7213
Differential Revision: https://phab.enlightenment.org/D6756
Mike Blumenkrantz [Wed, 8 Aug 2018 13:38:24 +0000 (09:38 -0400)]
ci: automatically clear config.cache if it cannot be used
Summary:
if env vars change between runs then the cache is invalidated, causing
configure to print a very specific error
by running a separate script to catch this error, the build can detect
and clear the cache when necessary to avoid having to manually disable
the cache when changing build settings
Depends on D6697
Reviewers: stefan_schmidt, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6732
Derek Foreman [Wed, 8 Aug 2018 13:37:29 +0000 (09:37 -0400)]
wayland: Fix elementary setting window parents at creation time
Summary:
We need to pass the entire pointer, not just 32-bits of it.
Fixes a crash with enlightenment sandbox gadgets where
ecore_wl2_window_alpha_get() is called with an invalid pointer while
trying to display a pop-up.
Reviewers: zmike, devilhorns
Reviewed By: zmike, devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6775
Mike Blumenkrantz [Wed, 8 Aug 2018 13:37:07 +0000 (09:37 -0400)]
tests/naviframe: namespace test function names
Summary:
no functional changes
Depends on D6759
Reviewers: stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: cedric, #committers
Tags: #efl_widgets, #efl_tests
Differential Revision: https://phab.enlightenment.org/D6760
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:33 +0000 (09:36 -0400)]
tests/genlist: add full test for expanding and contracting a genlist item
Summary:
this adds a fairly complete test for simulating the expand and contract
of a tree item in a genlist, as triggered by a user clicking the expand arrow
on an item
presently this test fails, as it is set to abort if any error messages are
logged and there are a number of focus manager errors
ref D6737
ref T6837
Reviewers: bu5hm4n, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee, cedric, #committers
Tags: #efl_tests, #efl_widgets
Maniphest Tasks: T6837
Differential Revision: https://phab.enlightenment.org/D6750
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:27 +0000 (09:36 -0400)]
tests/genlist: use genlist test namespace for test functions
Summary:
namespacing test function names makes test output easier to read.
no functional changes
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: SanghyeonLee, cedric, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6758
Mike Blumenkrantz [Thu, 19 Jul 2018 23:45:34 +0000 (19:45 -0400)]
edje_cc: change .mo file write location to be relative to the .edj file
previously this would attempt to write the .mo file to the same directory
that the .po file was found in, which is invalid in cases such as distcheck
where the source directory is not writable
@fix
Differential Revision: https://phab.enlightenment.org/D6636
Mike Blumenkrantz [Tue, 24 Jul 2018 15:40:28 +0000 (11:40 -0400)]
build: rewrite remaining $(OBJEXT) rules
fix the naming for these targets based on automake 1.16+ presence and
naming scheme
ref D6594
fix T7154
Differential Revision: https://phab.enlightenment.org/D6675
Yeongjong Lee [Wed, 8 Aug 2018 07:11:02 +0000 (16:11 +0900)]
elm_map: remove unreasonable efl_super call
Summary:
Efl_Ui_Widget which is super of Elm_Map is not implement Efl_Ui_Zoom. to call
efl_super of Elm_Map for Efl_Ui_Zoom method occurs unresolved function error.
Test Plan:
map_example_01
Check that there is no error message.
Reviewers: zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6772
Yeongjong Lee [Wed, 8 Aug 2018 07:05:16 +0000 (16:05 +0900)]
elm_map: implement zoom_mode_get, zoom_level_get
Test Plan:
map_example_01
Check that +,- button is working and no error message.
Reviewers: zmike, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6771
Mike Blumenkrantz [Wed, 8 Aug 2018 06:56:02 +0000 (15:56 +0900)]
efl_ui/image_zoomable: fix internal eina file refcounting
Summary:
this pointer is owned by elm_theme, not the image, so the image refcount
must be increased in order to avoid accidentally closing the file which is
still in use by elm_theme and triggering a crash
this resolves the crash in the `efl_ui_image_zoomable_icon` test
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6774
Bowon Ryu [Wed, 8 Aug 2018 06:20:42 +0000 (15:20 +0900)]
efl_ui_tab_pager: clean up and remove unnecessary signals.
Summary:
TAB of efl_ui_tab_bar is no longer widget_item.
TAB is now layout,
so, do not need below signals.
"efl,text,visible"
"efl,text,hidden"
"efl,icon,visible"
"efl,icon,hidden"
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6770
Bryce Harrington [Wed, 8 Aug 2018 04:52:25 +0000 (13:52 +0900)]
eina: Add doxygen in/out tags for rectangle
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6776
Wonki Kim [Mon, 25 Jun 2018 06:56:11 +0000 (15:56 +0900)]
eina_prefix: Fix a logic to use a canonical path for finding prefix
wip
Change-Id: Ib6b8f9ff15da7cfd3540d93dd8c7021d53678768
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Hermet Park [Tue, 14 Aug 2018 21:13:24 +0000 (17:13 -0400)]
evas gl: fix missing map texture target.
Summary:
Map context missed setting texture target.
I guess this is one of regression bugs in gl backend.
When shader is flushed, it sets invalid texture target with map texture.
That caused blank map rendering, this could be observed temporary
because gl pipe contexts are reusable and missing texture target means,
it could use previous texture target values that mostly have GL_TEXTURE_2D.
@fix
Reviewers: #committers, ManMower
Reviewed By: #committers, ManMower
Subscribers: ManMower, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6818
Change-Id: I4fa4f70864da7ee1e244a187116d7f71159e1940
Lukasz Wlazly [Fri, 10 Aug 2018 08:27:13 +0000 (10:27 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: Icb6171e61255b3e5561982387ced4e8440ce234a
Youngbok Shin [Thu, 9 Aug 2018 09:43:45 +0000 (18:43 +0900)]
edje_cc: remove edje_cc build warning message caused by efl_version
In Tizen, new Textblock calculation is already applied by default.
So, this warning message is meaningless in Tizen.
@tizen_fix
Change-Id: I9a02653ddd5c7f6c6eedea767d930687c1f3da54
Joogab Yun [Thu, 9 Aug 2018 03:58:45 +0000 (12:58 +0900)]
evas : fixed coverty issue CID:111611
Change-Id: If5cfe093d251fb75d7c15380ad71a6e81cb5a790
Joogab Yun [Thu, 9 Aug 2018 03:34:49 +0000 (12:34 +0900)]
evas : fixed coverity issue CID:1013912
Change-Id: I8bfcf9e9e2235dd76947f91261fde19c875659b1
Taehyub Kim [Thu, 9 Aug 2018 02:00:53 +0000 (11:00 +0900)]
ecore_wl_dnd: free seat selection event when num_types are less than 0
Change-Id: Ieaf11eb564c478f22c3b0f6ec0b38811b9fa65d3
Hermet Park [Wed, 8 Aug 2018 07:01:11 +0000 (16:01 +0900)]
evas image: fix screen flickering issue at partial + image preloading
Summary:
Prerequisite: Partial rendering ON + Image Prealoding + Triple surface buffer of GL.
Previously, evas trys to draw of an image which didn't prepare of image data yet (in case of preloading)
This time, it will draw a solid color onto the dest sufrace 1,
But luckily, preloading is finished just after, it draws proper image data onto next surface 2 and 3.
Now, triple buffer is filled with the image data but only first frame is still empty. That's a problem.
This patch skips to draw image if it doesn't prepare data yet, but once the preloading is finished,
it starts to draw images.
@fix
Reviewers: #committers
Subscribers: kimcinoo, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6739
Change-Id: I64f4b5a6ca68feba086f05b3d8da5e5110416345
Shinwoo Kim [Wed, 8 Aug 2018 04:51:40 +0000 (13:51 +0900)]
evas_image: do not render while preloading
Summary:
Unexpected image shows if image data is not ready.
Even though there is a change to check the 'preloading' in pre_render phase,
evas_object_image_render is called. So we need to check here as well.
Reference: https://phab.enlightenment.org/D6739
It seems that the 'preloading' is not enough. The 'preloading' could be reset
to FALSE by _evas_image_load_async_cancel > _image_preload_internal.
If the following step happens, then this patch set is neccessary.
(1) evas_object_image_pre_render
(2) _evas_iamge_load_async_start
(3) evas_object_image_render
I could not find out what the correct step, but it actullay happens.
The evas_object_image_render could be called with the 'preloading' TURE.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6778
Change-Id: I0b0d941868ee53bd4f89a0895b029034b6f035f2
Hermet Park [Wed, 8 Aug 2018 06:52:37 +0000 (15:52 +0900)]
elementary image: don't calc size using empty ones.
Summary:
Zero-sized image occasionally happens.
That occurs insane img/clipper region.
bj size => (w, h) then resize => (0, 0)
file_set(xx.jpg) then file_set (NULL)
Because of this, region could be flickered during prev/cur preloading images.
@fix
Reviewers: #committers, zmike
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6725
Change-Id: If3f01f66efe2eef6f62520dabbb6237d68dfb8b5
Lukasz Wlazly [Mon, 13 Aug 2018 08:54:22 +0000 (10:54 +0200)]
atspi: check service, bus and path names for Dbus communication
This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.
Change-Id: I558c4f41ce72321272db3db433f259c4d6f08387
Yeongjong Lee [Tue, 14 Aug 2018 09:41:23 +0000 (18:41 +0900)]
Revert "evas engines: do not immediately free native surface when unsetting it"
This reverts commit
c0ddc1b6a0dc710f4220250b40fd67234cb4ff9a.
@tizen-fix
Change-Id: I2426a5e602b1da688302555c943c9f01002066f6
Signed-off-by: Yeongjong Lee <yj34.lee@samsung.com>
Taehyub Kim [Wed, 8 Aug 2018 06:54:29 +0000 (15:54 +0900)]
efl_ui_popup_alert_text: apply tizen theme for label
Change-Id: I1c5a30990bf08f2d42262eb75de9f53a7ffffb9e
Shinwoo Kim [Mon, 18 Jun 2018 10:36:10 +0000 (19:36 +0900)]
ecore_evas: use timer for animator
[Problem]
The animator on the wayland ecore_evas engine used wl_surface frame callback
as its source(of _ecore_evas_tick_source_find). This made wl_surface_commit
be called too much and caused the Enlightenment performance issue.
[Solution]
So this patch set is using the timer for animator source.
The animator is working without intervention of the Enlightenment.
@tizen_only
Change-Id: Id20a95a35107454a908397eeb3640d7f6650ef2d
Taehyub Kim [Tue, 7 Aug 2018 06:23:53 +0000 (15:23 +0900)]
efl_selection: check the sel lost object to prevent invalid acesss
Change-Id: Iad7928d7da691e96dcce6b409f756ac80342a353
Mike Blumenkrantz [Tue, 7 Aug 2018 16:10:22 +0000 (12:10 -0400)]
tests/eolian: remove eolian_decl test
Summary:
<q66> just remove decl.eo and remove the eolian_decl test; it's useless
<q66> the reason: it used to be testing some specific API, which got replaced with more generalized API that is now used everywhere in the tests, so that specific test no longer has a purpose
resolves some compile errors due to type conflicts
Reviewers: q66
Reviewed By: q66
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6773
Marcel Hollerbach [Tue, 7 Aug 2018 04:25:34 +0000 (13:25 +0900)]
elm_genlist: fix item registration by correct realization
Summary:
there was a case when a block could be realized while a item that is
realized was brought from one block to the this new one. The block now
is simply realized using api instead of just setting the flag, this sets
the correct focus registrations. While fixing this the error of double
regiration of items came up, this is also fixed by unregistration and
reregistration in the correct block.
fix T7247
Reviewers: zmike, SanghyeonLee, YOhoho
Reviewed By: zmike
Subscribers: Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T7247
Differential Revision: https://phab.enlightenment.org/D6737
Mike Blumenkrantz [Mon, 6 Aug 2018 19:18:14 +0000 (15:18 -0400)]
ecore-evas/wayland: fix parent setting on canvas creation
Summary:
use the correct pointer when applying the passed parent object in order to
successfully set the parent
ref
78f27a3efff24ba3b935cc9e2620718e51af9304
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl_display_system
Differential Revision: https://phab.enlightenment.org/D6757
Change-Id: Iad0aeeb7542a3e6145c986434aa92b5d8a97fd3f
Hermet Park [Mon, 6 Aug 2018 11:23:48 +0000 (07:23 -0400)]
evas image: code refactoring.
Summary: remove duplicated, no logical changes.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6738
Marcel Hollerbach [Mon, 6 Aug 2018 07:38:58 +0000 (16:38 +0900)]
elm_genlist: remove unused function
Summary:
this got replaced by the none composition implementation and is not
required anymore.
Depends on D6737
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6752
Change-Id: I025bda18f9a6b67229a2ef33cc89a332a48e26ba
Marcel Hollerbach [Mon, 6 Aug 2018 07:34:05 +0000 (16:34 +0900)]
elm_genlist: fix ghost objects from the genlist cache
Summary:
the cache simply moved the objects to -9999 -9999 while leaving them
visible and focusable. Hiding them does not work since edje makes it
visible all the time again. Making them unfocusable fixes this.
Depends on D6752
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6753
Change-Id: I3e7ee3f04aa9f18110ca07305134dd56ca9be8cf
Mike Blumenkrantz [Mon, 6 Aug 2018 07:26:52 +0000 (16:26 +0900)]
tests/elm: when using buffer engine, clamp render and edje timing to 0.05s
Summary:
this sets manual render on buffer engine windows and dumps the render at every
interval in order to avoid doing any real rendering or animating or having to
wait on some irrelevant timing.
tests using buffer engine just want to complete as fast as possible, as they are
never being displayed anywhere, so just perform canvas operations (recalcs mostly)
and BAIL
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6749
Shinwoo Kim [Mon, 6 Aug 2018 07:21:55 +0000 (16:21 +0900)]
test/evas: add to check smart class overriding
Summary:
If Evas_Smart_Class.move is overridden,
then user defined move function should be used.
Check if "https://phab.enlightenment.org/D6468" works or not.
Reviewers: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6740
Alastair Poole [Sun, 5 Aug 2018 20:13:39 +0000 (21:13 +0100)]
elm_code_widget: match bg color with widget color.
Test Plan: elm_test -> "Code Editor" -> Consistent widget colours.
Reviewers: #committers, ajwillia.ms, zmike
Reviewed By: #committers, ajwillia.ms
Subscribers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6719
Mike Blumenkrantz [Mon, 23 Jul 2018 14:27:53 +0000 (10:27 -0400)]
ci: add build time to IRC notification
this will be useful while profiling CI builds to know whether a patch
has made builds slower so that it can potentially be examined
Differential Revision: https://phab.enlightenment.org/D6666
Mike Blumenkrantz [Sun, 22 Jul 2018 16:01:47 +0000 (12:01 -0400)]
ci: remove --always-build-examples from misc build
these should only be explicitly built by the examples target or built
during distcheck
Differential Revision: https://phab.enlightenment.org/D6665
Mike Blumenkrantz [Sun, 22 Jul 2018 02:22:17 +0000 (22:22 -0400)]
build: remove infuriating VTIME build define
this does nothing but ruin your entire ccache every time configure runs.
ref
cae354d299688304f609c5f064702891f02260b9
ref T5495
Differential Revision: https://phab.enlightenment.org/D6662
Mike Blumenkrantz [Fri, 20 Jul 2018 21:46:44 +0000 (17:46 -0400)]
build: remove BUILT_SOURCES usage from cxx examples makefiles
ref T7154
Differential Revision: https://phab.enlightenment.org/D6656
Mike Blumenkrantz [Wed, 18 Jul 2018 21:55:09 +0000 (17:55 -0400)]
build: move src/examples/ to a single makefile
this greatly improves build times by improving parallelizing, though it
does introduce more BUILT_SOURCES usage which causes builds with cxx
bindings to take significantly longer
fix T7157
ref T7154
Differential Revision: https://phab.enlightenment.org/D6633
Mike Blumenkrantz [Thu, 2 Aug 2018 20:42:56 +0000 (16:42 -0400)]
elm/genlist: use correct type of list when iterating
itb-items is Eina_List, not Eina_Inlist. this crashes due to wrong type
use
ref D6720
fix T7246
Differential Revision: https://phab.enlightenment.org/D6736
Marcel Hollerbach [Thu, 2 Aug 2018 13:42:06 +0000 (09:42 -0400)]
genlist: rework the focus model for performance
Summary:
the focus model before was more meant for simplicity and not for
performance, this now is more made for performance.
The performance boost is achived by not using composition anymore,
but rather register realized items by hand. This keeps the amount
of items bound to the size of the viewport.
Additionally item realization that is followed by unrealization
immediately is not resulting in focus calls.
This solves the performance issue from T6580 in regards of focus.
perf results after this:
http://www.enlightenment.org/ss/e-
5b61b50657f3c3.
82619729.png
Reviewers: ManMower, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6720
Change-Id: I5b753db6fca3d1feed5e4f13d7e08da717d9977e
Hermet Park [Thu, 2 Aug 2018 13:22:59 +0000 (09:22 -0400)]
elementary image: apply lazy calculation and guarantee retained method.
Summary:
Image couldn't gurantee retained concept status.
This patch change to setting up image object on the request time,
recovering image status, removing unencessary jobs.
Reviewers: #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6726
Change-Id: I8aec4de5c865d5110d1d317094e8f31a8aba9e71
Hosang Kim [Thu, 2 Aug 2018 13:14:15 +0000 (09:14 -0400)]
ecore: fix that timers are not called in the order they were registered.
Summary:
Timers are not called in the order they were registered.
Because when current timer is deleted, getting next timer is called twice.
Test Plan:
<error>
Timer1 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.
<correct>
Timer1 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.|
{
F3268233}
Reviewers: Hermet, Jaehyun_Cho, zmike, SanghyeonLee
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6700
Shinwoo Kim [Thu, 2 Aug 2018 13:10:41 +0000 (09:10 -0400)]
Efl.Canvas.Group: use desired function
Summary:
If a smart class overrides Evas_Smart_Class.move as below,
then original behavior must not be used for the smart class.
Evas_Smart_Class sc = EVAS_SMART_CLASS_INIT_NAME_VERSION("MyClass");
evas_object_smart_clipped_smart_set(&sc);
sc.move = &myMove;
But current implementation makes original behavior work.
So before using the original method, this patch is checking if the original
method is changed or not.
Reviewers: zmike, devilhorns
Reviewed By: zmike
Subscribers: woohyun, jypark, cedric, raster, jpeg, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6468
Hermet Park [Thu, 2 Aug 2018 13:08:43 +0000 (09:08 -0400)]
elementary bg: fix to guarantee compatibility.
Summary: This is additional fix to
b9b209f60f040d0afbccc1db0c96c8e36d14e682.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6727
Mike Blumenkrantz [Wed, 27 Jun 2018 20:53:55 +0000 (16:53 -0400)]
elm/genlist: remove conditional in _calc_job for verifying show_item code
I think at some point in the past this was necessary to avoid weird show
mechanics, but now things have changed and it's best to always attempt to
scroll and let the scroller internals figure things out
this resolves the case where attempting to scroll to an item during a genlist's
calc (ie. the item was not present in a full layout calc) would fail to scroll
to the item if the scroll method was TOP and the item was too close to the
bottom of the list
fix T6368
@fix
Differential Revision: https://phab.enlightenment.org/D6466
Jaehyun Cho [Thu, 2 Aug 2018 09:16:46 +0000 (18:16 +0900)]
evas_events: Fix to set mouse_in state to all pointers in the seat.
Summary:
mouse coordinate is set by seat.
Therefore, mouse_in state should be set based on seat.
As a result, mouse_in state of all pointers in the seat should be
updated at the same time.
Reviewers: eagleeye, devilhorns, zmike
Reviewed By: eagleeye, devilhorns, zmike
Subscribers: devilhorns, Hermet, kimcinoo, cedric, iscaro, zmike, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6699
Mike Blumenkrantz [Mon, 30 Jul 2018 11:12:31 +0000 (07:12 -0400)]
edje: add back function prototype for edje_object_color_class_description_get
this was removed in D4403
Differential Revision: https://phab.enlightenment.org/D6694
Hermet Park [Thu, 2 Aug 2018 03:20:27 +0000 (12:20 +0900)]
evas sdl: don't make confusing, we only use one-indexed egl handles.
Reviewers: ManMower
Subscribers: devilhorns, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6693
Felipe Magno de Almeida [Wed, 1 Aug 2018 22:45:36 +0000 (19:45 -0300)]
elementary: efl_ui_view_list cleanup
Summary:
private data cleanup
removed callbacks
Reviewers: felipealmeida, SanghyeonLee
Reviewed By: felipealmeida
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D6707
Change-Id: I20c7af06992ba7b03ab72ff773c6f7a866e0f75e
Felipe Magno de Almeida [Wed, 1 Aug 2018 21:42:13 +0000 (18:42 -0300)]
Efl.Ui.Layout.Factory: added missing factory_model_connect
Summary:
connect factory to edje part name
when create a new layout connect a factory to it
change example to use the factory_model_connect
Reviewers: felipealmeida
Differential Revision: https://phab.enlightenment.org/D6667
Daniel Kolesa [Wed, 1 Aug 2018 17:31:15 +0000 (13:31 -0400)]
build: disable Lua binding generation
Summary:
As Lua bindings don't work right now, it is pointless to waste
build time generating them. Elua itself on the other hand is
useful and should stay enabled.
This also does some preparation work for separate configure
switch for bindings after release, but for now keep configure
switches as they are.
Reviewers: zmike, stefan_schmidt
Subscribers: cedric, bu5hm4n, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6721
Mike Blumenkrantz [Wed, 1 Aug 2018 00:05:07 +0000 (20:05 -0400)]
ci: print config.log if configure fails
Differential Revision: https://phab.enlightenment.org/D6717
Mike Blumenkrantz [Wed, 1 Aug 2018 02:38:03 +0000 (22:38 -0400)]
ci: explicitly set PKG_CONFIG_PATH for openssl
travis upgraded to macos high sierra overnight without notification(?)
and this is now required in order to find openssl for some reason
also disable config.cache to prevent configure errors
Differential Revision: https://phab.enlightenment.org/D6718
Hosang Kim [Thu, 28 Jun 2018 11:17:46 +0000 (20:17 +0900)]
ttrace: apply ttrace log system.
@tizen_fix
Change-Id: I31526279b4ca1f6b15f01c157b385bcf4b2a14a1
Wonki Kim [Wed, 1 Aug 2018 12:02:34 +0000 (21:02 +0900)]
neon: fix a build fail on aarch64
there is a tizen only code on draw_convert.c.
and it make a build fail on aarch64.
this patch fix it.
Change-Id: I3b1270f5bb2258aca241222843b96e5d4bf8f82a
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Hermet Park [Mon, 30 Jul 2018 06:25:08 +0000 (15:25 +0900)]
evas gl_tbm: don't make confusing, we only use one-indexed egl handles.
Change-Id: I7d2708707b9d80e27ea4f21dc01702cd1ce5f9da
Yeshwanth Reddivari [Mon, 30 Jul 2018 16:34:44 +0000 (22:04 +0530)]
region_add: Fix copying wrong rect during smart merge
Summary:
When testing partial rendering on TV, found this bug.
Probably this was caused because of wrong copy/paste.
When region1 completely subsumes region2, region2 should be ignored.
But currently region2 is copied to region1 which makes region1 rect completly wrong.
This was causing lot of visual defects because of wrong rects.
This patch will fix those visual defects when partial rendering is enabled.
Test Plan: Tested with the patch on TV after enabling partial rendering.
Differential Revision: https://phab.enlightenment.org/D6696
Change-Id: I63c2d91e48a29311562d116ccb03c1a0e2db4ed1
Signed-off-by: Yeshwanth Reddivari <yashu21985@gmail.com>