platform/upstream/libSkiaSharp.git
8 years agoRepurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
djsollen [Wed, 27 Apr 2016 20:37:23 +0000 (13:37 -0700)]
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
DOCS_PREVIEW= https://skia.org/?cl=1927583002

Review-Url: https://codereview.chromium.org/1927583002

8 years agoRefactor drawContext/RenderTarget creation
robertphillips [Wed, 27 Apr 2016 20:34:01 +0000 (13:34 -0700)]
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002

Review-Url: https://codereview.chromium.org/1914883002

8 years agoAdd tests for volatile paths to GrShapeTest
bsalomon [Wed, 27 Apr 2016 20:30:25 +0000 (13:30 -0700)]
Add tests for volatile paths to GrShapeTest

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923403003

Review-Url: https://codereview.chromium.org/1923403003

8 years agoAdd tests for empty GrShapes.
bsalomon [Wed, 27 Apr 2016 19:36:02 +0000 (12:36 -0700)]
Add tests for empty GrShapes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927673002

Review-Url: https://codereview.chromium.org/1927673002

8 years agoSimplify style handling in custom font manager.
bungeman [Wed, 27 Apr 2016 19:30:25 +0000 (12:30 -0700)]
Simplify style handling in custom font manager.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915103002

Review-Url: https://codereview.chromium.org/1915103002

8 years agoSkDocument::CreateXPS fix roll
halcanary [Wed, 27 Apr 2016 19:07:55 +0000 (12:07 -0700)]
SkDocument::CreateXPS fix roll

NOTRY=true
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/1918713006

8 years agoRemove AttachmentInfo from VulkanViewer setup
jvanverth [Wed, 27 Apr 2016 18:42:21 +0000 (11:42 -0700)]
Remove AttachmentInfo from VulkanViewer setup

It's not necessary to pass this information back up to the client;
we can store it in the TestContext if needed for Surface creation.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920163004

Review-Url: https://codereview.chromium.org/1920163004

8 years agoAdd work around for vulkan copies on the 5X
egdaniel [Wed, 27 Apr 2016 18:31:59 +0000 (11:31 -0700)]
Add work around for vulkan copies on the 5X

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923963002

Review-Url: https://codereview.chromium.org/1923963002

8 years agoImage filters: de-nest SkImageFilter::Cache and Cache::Key.
senorblanco [Wed, 27 Apr 2016 18:31:23 +0000 (11:31 -0700)]
Image filters: de-nest SkImageFilter::Cache and Cache::Key.

This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919063002

Review-Url: https://codereview.chromium.org/1919063002

8 years agoSkPDF/None: fix compilation
halcanary [Wed, 27 Apr 2016 17:57:52 +0000 (10:57 -0700)]
SkPDF/None: fix compilation

TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/1929593002

8 years agoBring sk_sp to GrDrawContext
robertphillips [Wed, 27 Apr 2016 17:47:51 +0000 (10:47 -0700)]
Bring sk_sp to GrDrawContext

This is split out of: https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918003003

Review-Url: https://codereview.chromium.org/1918003003

8 years agoAdd oblique as a slant.
bungeman [Wed, 27 Apr 2016 17:21:04 +0000 (10:21 -0700)]
Add oblique as a slant.

Some fonts have italic and oblique in the same family, see

http://lucidafonts.com/fonts/family/lucida-sans
http://www.gust.org.pl/projects/e-foundry/latin-modern

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921903002

Chromium side change at https://crrev.com/1921503006/ .

Review-Url: https://codereview.chromium.org/1921903002

8 years agoAdd dry_run_access_list to Skia's cq.proto
rmistry [Wed, 27 Apr 2016 16:43:20 +0000 (09:43 -0700)]
Add dry_run_access_list to Skia's cq.proto

This will give all users who have access to our trybots access to our dry run CQ as well.

BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002

8 years agoRevert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https...
mtklein [Wed, 27 Apr 2016 16:29:34 +0000 (09:29 -0700)]
Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/1913843002/ )

Reason for revert:
Release mode bots appear to be crashing while loading .skp files in nanobench.

Original issue's description:
> Enable flattening of SkRecordedDrawable
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002
>
> Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd

TBR=djsollen@google.com,reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/1923393002

8 years agoEnable flattening of SkRecordedDrawable
msarett [Wed, 27 Apr 2016 16:03:17 +0000 (09:03 -0700)]
Enable flattening of SkRecordedDrawable

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002

Review-Url: https://codereview.chromium.org/1913843002

8 years agoUpgrade Android Gradle plugins
djsollen [Wed, 27 Apr 2016 15:48:56 +0000 (08:48 -0700)]
Upgrade Android Gradle plugins
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926743002

Review-Url: https://codereview.chromium.org/1926743002

8 years agoremove 'deprecated' region from SkDraw
reed [Wed, 27 Apr 2016 14:49:17 +0000 (07:49 -0700)]
remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925693002

Review URL: https://codereview.chromium.org/1925693002

8 years agoSkDocument/PDF: new API
halcanary [Wed, 27 Apr 2016 14:45:18 +0000 (07:45 -0700)]
SkDocument/PDF: new API

has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916093002

Review URL: https://codereview.chromium.org/1916093002

8 years agotools/pdf-comparison.sh: stop relying on /usr/bin/timeout
halcanary [Wed, 27 Apr 2016 14:44:03 +0000 (07:44 -0700)]
tools/pdf-comparison.sh: stop relying on /usr/bin/timeout

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1921943006

8 years agoTreat kIncompleteInput as successes in get_images_from_skps
rmistry [Wed, 27 Apr 2016 14:31:23 +0000 (07:31 -0700)]
Treat kIncompleteInput as successes in get_images_from_skps

Context:
https://bugs.chromium.org/p/skia/issues/detail?id=5226
and
https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_skps.cpp#newcode83

BUG=skia:5226
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917413003

Review URL: https://codereview.chromium.org/1917413003

8 years agoDisable ReadWriteAlpha on TSAN
stephana [Wed, 27 Apr 2016 13:50:03 +0000 (06:50 -0700)]
Disable ReadWriteAlpha on TSAN

BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927573002

Review URL: https://codereview.chromium.org/1927573002

8 years agoAdd support for building GrShape from SkPath and more tests
bsalomon [Wed, 27 Apr 2016 13:46:23 +0000 (06:46 -0700)]
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002

Review URL: https://codereview.chromium.org/1922713002

8 years agoAdd comments and sanity checks to parsing of ICC headers
msarett [Wed, 27 Apr 2016 13:12:26 +0000 (06:12 -0700)]
Add comments and sanity checks to parsing of ICC headers

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922073003

Review URL: https://codereview.chromium.org/1922073003

8 years agoDon't isolate the Skia repo for Swarming compiles
borenet [Wed, 27 Apr 2016 13:06:25 +0000 (06:06 -0700)]
Don't isolate the Skia repo for Swarming compiles

BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002

Review URL: https://codereview.chromium.org/1886343002

8 years agoChange default window size on Windows.
brianosman [Tue, 26 Apr 2016 23:51:03 +0000 (16:51 -0700)]
Change default window size on Windows.

The OS tends to pick a very large size if you let it. Instead, choose a
smaller (fixed) window (matching what we currently use on Linux).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919133004

Review URL: https://codereview.chromium.org/1919133004

8 years agoEnsure we're operating on the correct texture when generating mipmaps.
brianosman [Tue, 26 Apr 2016 23:48:06 +0000 (16:48 -0700)]
Ensure we're operating on the correct texture when generating mipmaps.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915403004

Review URL: https://codereview.chromium.org/1915403004

8 years agoRevert of Remove gpu-specialization of SkSpecialImage (patchset #5 id:80001 of https...
robertphillips [Tue, 26 Apr 2016 22:02:25 +0000 (15:02 -0700)]
Revert of Remove gpu-specialization of SkSpecialImage (patchset #5 id:80001 of https://codereview.chromium.org/1918993002/ )

Reason for revert:
N6 bot has gone red

Original issue's description:
> Remove gpu-specialization of SkSpecialImage
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002
>
> Committed: https://skia.googlesource.com/skia/+/0533d6e4142c2787d6d3c325ef0d8d1962292cad

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1921393003

8 years agoRemove unmatched restore call in gamma GM
brianosman [Tue, 26 Apr 2016 21:37:27 +0000 (14:37 -0700)]
Remove unmatched restore call in gamma GM

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917303002

Review URL: https://codereview.chromium.org/1917303002

8 years agoRemove gpu-specialization of SkSpecialImage
robertphillips [Tue, 26 Apr 2016 21:33:36 +0000 (14:33 -0700)]
Remove gpu-specialization of SkSpecialImage

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002

Review URL: https://codereview.chromium.org/1918993002

8 years agoDon't buffer stdout in DM
bsalomon [Tue, 26 Apr 2016 21:27:21 +0000 (14:27 -0700)]
Don't buffer stdout in DM

TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922223002

Review URL: https://codereview.chromium.org/1922223002

8 years agopathops: Split loop type cubics only when there is a self-intersection.
deanm [Tue, 26 Apr 2016 21:15:21 +0000 (14:15 -0700)]
pathops: Split loop type cubics only when there is a self-intersection.

The ComplexBreak code comes from Loop and Blinn, which requires loops to be
split if either double point is visible.  However for intersection loops only
need to be split when there is actually a self-intersection (when both double
points are in [0, 1]).  This patch splits cubics much less often so the output
doesn't have extra segments unless the input had a self-intersecting loop.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920663002

Review URL: https://codereview.chromium.org/1920663002

8 years agopathops: Cosmetic only change, update comments around ComplexBreak().
deanm [Tue, 26 Apr 2016 21:12:22 +0000 (14:12 -0700)]
pathops: Cosmetic only change, update comments around ComplexBreak().

Rename loopT to splitT and make it clearer that it is not just
self intersecting loop cubics that are split.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921173003

Review URL: https://codereview.chromium.org/1921173003

8 years agopathops: Add missing header guards in two files.
deanm [Tue, 26 Apr 2016 21:09:01 +0000 (14:09 -0700)]
pathops: Add missing header guards in two files.

Guards were missing in SkIntersectionHelper.h and
SkPathOpsTSect.h.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914873002

Review URL: https://codereview.chromium.org/1914873002

8 years agoUpdate SK_IMAGE_VERSION, run nanobench on its own image set
msarett [Tue, 26 Apr 2016 20:08:57 +0000 (13:08 -0700)]
Update SK_IMAGE_VERSION, run nanobench on its own image set

I've added a new directory to the cloud
(gs://chromium-skia-gm/skimage/v4/nanobench) which will
allow us to run dm and nanobench on different sets of
images.

The dm image set will stay the same, and includes
incomplete images, edge cases images, etc.

The nanobench set is much smaller, and includes jpegs and
pngs that we've found useful to bench in the past, plus
a couple of each for the other formats.  We can refine
this set as we move forward (and may also want to monitor
these images on perf.skia.org).

For now the goal is to reduce nanobench runtime by not
testing on many, many obscure images that are not
particularly interesting to time.

The actual change to use nanobench images is in:
https://codereview.chromium.org/1917903003/

BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913813004

Review URL: https://codereview.chromium.org/1913813004

8 years agoRemove redundant tests to make DM a little faster
msarett [Tue, 26 Apr 2016 20:06:38 +0000 (13:06 -0700)]
Remove redundant tests to make DM a little faster

This should help with some of the slow down caused by
https://codereview.chromium.org/1907593004.

BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923533002

Review URL: https://codereview.chromium.org/1923533002

8 years agoRemove redundant test
msarett [Tue, 26 Apr 2016 19:59:47 +0000 (12:59 -0700)]
Remove redundant test

FlattenDrawable test now exercises the use of custom unflatten procs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917183002

Review URL: https://codereview.chromium.org/1917183002

8 years agoAdd initial implementation of GrShape and GrStyle classes and tests
bsalomon [Tue, 26 Apr 2016 19:56:00 +0000 (12:56 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests

The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003

Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8

Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09

Review URL: https://codereview.chromium.org/1822723003

8 years agoAdd runhooks to multi_repo_trybots
liyuqian [Tue, 26 Apr 2016 19:54:05 +0000 (12:54 -0700)]
Add runhooks to multi_repo_trybots

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1924573002

Review URL: https://codereview.chromium.org/1924573002

8 years agopdf comparison tool
halcanary [Tue, 26 Apr 2016 19:43:59 +0000 (12:43 -0700)]
pdf comparison tool

NOTRY=true

Review URL: https://codereview.chromium.org/1924513002

8 years agoUpdate android docs for how to sync source code
djsollen [Tue, 26 Apr 2016 19:38:52 +0000 (12:38 -0700)]
Update android docs for how to sync source code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921023002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1921023002

Review URL: https://codereview.chromium.org/1921023002

8 years agobin/fetch-skps: print instruction on error
halcanary [Tue, 26 Apr 2016 19:38:47 +0000 (12:38 -0700)]
bin/fetch-skps: print instruction on error

NOTRY=true

Review URL: https://codereview.chromium.org/1919133003

8 years agoWhitespace change to trigger bots after recipe fix
borenet [Tue, 26 Apr 2016 19:16:52 +0000 (12:16 -0700)]
Whitespace change to trigger bots after recipe fix

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922783003
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1922783003

8 years agoRevert of Add initial implementation of GrShape and GrStyle classes and tests (patchs...
bsalomon [Tue, 26 Apr 2016 15:41:47 +0000 (08:41 -0700)]
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )

Reason for revert:
test failing

Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09

TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1919243002

8 years agoReturn error code when get_images_from_skps has failures.
rmistry [Tue, 26 Apr 2016 15:27:49 +0000 (08:27 -0700)]
Return error code when get_images_from_skps has failures.

BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916183002

Review URL: https://codereview.chromium.org/1916183002

8 years agoDo not globally register drawables in test code
msarett [Tue, 26 Apr 2016 15:20:14 +0000 (08:20 -0700)]
Do not globally register drawables in test code

TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922853003

Review URL: https://codereview.chromium.org/1922853003

8 years agoAdd guards for edge cases.
herb [Tue, 26 Apr 2016 15:15:27 +0000 (08:15 -0700)]
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915263002

Review URL: https://codereview.chromium.org/1915263002

8 years agoRemove unnessary uniform barriers in Vulkan.
egdaniel [Tue, 26 Apr 2016 15:15:09 +0000 (08:15 -0700)]
Remove unnessary uniform barriers in Vulkan.

Also added a fix to descriptor set allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914053004

Review URL: https://codereview.chromium.org/1914053004

8 years agoAdd automatic generation of mipmaps to Vulkan
jvanverth [Tue, 26 Apr 2016 15:01:44 +0000 (08:01 -0700)]
Add automatic generation of mipmaps to Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916563002

Review URL: https://codereview.chromium.org/1916563002

8 years agoFix animation with stats in VulkanViewer
jvanverth [Tue, 26 Apr 2016 15:01:33 +0000 (08:01 -0700)]
Fix animation with stats in VulkanViewer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918083003

Review URL: https://codereview.chromium.org/1918083003

8 years agomake context() virtual on device
reed [Tue, 26 Apr 2016 13:57:31 +0000 (06:57 -0700)]
make context() virtual on device

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922123002

TBR=robertphilips

Review URL: https://codereview.chromium.org/1922123002

8 years agoAdd initial implementation of GrShape and GrStyle classes and tests
bsalomon [Tue, 26 Apr 2016 13:53:45 +0000 (06:53 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests

The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003

Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8

Review URL: https://codereview.chromium.org/1822723003

8 years agoRevert of Add initial implementation of GrShape and GrStyle classes and tests (patchs...
robertphillips [Tue, 26 Apr 2016 12:07:23 +0000 (05:07 -0700)]
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/1822723003/ )

Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.

Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8

TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1918203002

8 years agoDocumentation: FAQ: drop shadow
halcanary [Tue, 26 Apr 2016 11:49:45 +0000 (04:49 -0700)]
Documentation: FAQ: drop shadow

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1918833003#text-shadow
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918833003

Review URL: https://codereview.chromium.org/1918833003

8 years agoAdd initial implementation of GrShape and GrStyle classes and tests
bsalomon [Mon, 25 Apr 2016 20:37:22 +0000 (13:37 -0700)]
Add initial implementation of GrShape and GrStyle classes and tests

The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003

Review URL: https://codereview.chromium.org/1822723003

8 years agobin/sync
halcanary [Mon, 25 Apr 2016 20:34:06 +0000 (13:34 -0700)]
bin/sync

Review URL: https://codereview.chromium.org/1915223002

8 years agoImprove Android Quick Start Guide
liyuqian [Mon, 25 Apr 2016 20:15:37 +0000 (13:15 -0700)]
Improve Android Quick Start Guide

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919973002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1919973002

Review URL: https://codereview.chromium.org/1919973002

8 years agobin/sync-and-gyp: more dirs to search
halcanary [Mon, 25 Apr 2016 19:39:39 +0000 (12:39 -0700)]
bin/sync-and-gyp: more dirs to search

Review URL: https://codereview.chromium.org/1914993003

8 years agoAdd another dollop of sk_sp to SkSpecialImage and SkSpecialSurface
robertphillips [Mon, 25 Apr 2016 19:32:54 +0000 (12:32 -0700)]
Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface

This is split out of https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913743002

Review URL: https://codereview.chromium.org/1913743002

8 years agoshare code with drawSpriteWithFilter
reed [Mon, 25 Apr 2016 19:29:38 +0000 (12:29 -0700)]
share code with drawSpriteWithFilter

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920733003

Review URL: https://codereview.chromium.org/1920733003

8 years agoMake clang the default Android compiler.
djsollen [Mon, 25 Apr 2016 18:45:35 +0000 (11:45 -0700)]
Make clang the default Android compiler.

BUG=skia:5215
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919873003

Review URL: https://codereview.chromium.org/1919873003

8 years agoRemove SkEncodedInfo kPreSwizzled_Color from public API
msarett [Mon, 25 Apr 2016 18:41:15 +0000 (11:41 -0700)]
Remove SkEncodedInfo kPreSwizzled_Color from public API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918943002

Review URL: https://codereview.chromium.org/1918943002

8 years agobuild_command_buffer: Don't 'git checkout' when --no-sync
borenet [Mon, 25 Apr 2016 18:22:41 +0000 (11:22 -0700)]
build_command_buffer: Don't 'git checkout' when --no-sync

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915063002

Review URL: https://codereview.chromium.org/1915063002

8 years agoTest decoding and output failures to JSON in get_images_from_skps.
rmistry [Mon, 25 Apr 2016 17:35:03 +0000 (10:35 -0700)]
Test decoding and output failures to JSON in get_images_from_skps.

Testing for decoding was copy pasted from msarett's CL https://codereview.chromium.org/1828323002/

BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844713003

Review URL: https://codereview.chromium.org/1844713003

8 years agoSkDefaultColorProfile: Hide gDefaultProfileIsSRGB
halcanary [Mon, 25 Apr 2016 17:32:23 +0000 (10:32 -0700)]
SkDefaultColorProfile: Hide gDefaultProfileIsSRGB

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917443002

Review URL: https://codereview.chromium.org/1917443002

8 years agoSkMD5: .update() -> .write()
halcanary [Mon, 25 Apr 2016 17:29:36 +0000 (10:29 -0700)]
SkMD5: .update() -> .write()

Review URL: https://codereview.chromium.org/1913173003

8 years agoRemove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API
msarett [Mon, 25 Apr 2016 16:30:24 +0000 (09:30 -0700)]
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918873002

Review URL: https://codereview.chromium.org/1918873002

8 years agoSkStringPrintf and SkString::printf now are no longer limted by a static buffer
halcanary [Mon, 25 Apr 2016 16:25:35 +0000 (09:25 -0700)]
SkStringPrintf and SkString::printf now are no longer limted by a static buffer

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002

Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c

Review URL: https://codereview.chromium.org/1403803002

8 years agosimplify handle-affine: subclass overrides just describe their leaf behavior
reed [Mon, 25 Apr 2016 16:25:15 +0000 (09:25 -0700)]
simplify handle-affine: subclass overrides just describe their leaf behavior

added new test case (that would have failed before) of blur with a colorfilter input

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915943002

Review URL: https://codereview.chromium.org/1915943002

8 years agoWhitespace change.
herb [Mon, 25 Apr 2016 16:05:14 +0000 (09:05 -0700)]
Whitespace change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915073002

Review URL: https://codereview.chromium.org/1915073002

8 years agoWhitespace change
stephana [Mon, 25 Apr 2016 15:35:04 +0000 (08:35 -0700)]
Whitespace change

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920893002

TBR=borenet
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1920893002

8 years agoRevert of Call SkGraphics::Init() automatically for Google3 processes. (patchset...
benjaminwagner [Mon, 25 Apr 2016 14:33:19 +0000 (07:33 -0700)]
Revert of Call SkGraphics::Init() automatically for Google3 processes. (patchset #1 id:1 of https://codereview.chromium.org/1906813002/ )

Reason for revert:
Fixed in a different way in internal cl/120632580.

Original issue's description:
> Call SkGraphics::Init() automatically for Google3 processes.
>
> This is logically a partial revert of https://codereview.chromium.org/1903503002.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002
>
> Committed: https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395

TBR=mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Review URL: https://codereview.chromium.org/1916793002

8 years agoFix kSubset_Mode tests on non-native swizzles
msarett [Mon, 25 Apr 2016 14:04:58 +0000 (07:04 -0700)]
Fix kSubset_Mode tests on non-native swizzles

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918813002

Review URL: https://codereview.chromium.org/1918813002

8 years agoRevert of Batch multiple single NVPR draw paths to instanced draws (patchset #5 id...
stephana [Mon, 25 Apr 2016 14:01:22 +0000 (07:01 -0700)]
Revert of Batch multiple single NVPR draw paths to instanced draws (patchset #5 id:80001 of https://codereview.chromium.org/1908433002/ )

Reason for revert:
This causes what looks like significantly wrong results. Here is an example:

https://gold.skia.org/diff?test=stroke-fill&left=cb47dc2cabbad7d146aedaac199ebace&top=2c6e65d597c574e3bb170a19ca9634c6

Original issue's description:
> Batch multiple single NVPR draw paths to instanced draws
>
> Batch multiple single NVPR draw paths to instanced draws.
> A draw path batch can be combined to other batch if the
> batches do not overlap and have same draw characteristics.
>
> Join the batches in linked list and flatten the list to a
> path list during draw time.
>
> Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.
>
> Perf changes ARM, Shield TV device, Tegra X1 GPU:
>                 desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x
>                     desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x
> Others results are more volatile.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002
>
> Committed: https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22

TBR=joshualitt@chromium.org,bsalomon@google.com,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1919843002

8 years agoMake SkDrawable an SkFlattenable
msarett [Mon, 25 Apr 2016 13:40:26 +0000 (06:40 -0700)]
Make SkDrawable an SkFlattenable

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911403004

Review URL: https://codereview.chromium.org/1911403004

8 years agoUse BUILD_TYPE in cmake_build.
rmistry [Mon, 25 Apr 2016 13:29:21 +0000 (06:29 -0700)]
Use BUILD_TYPE in cmake_build.

Build files were directly written to the out directory. This change makes them go to the expected out/{Release, Debug} directory.

BUG=skia:5160

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916773002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Review URL: https://codereview.chromium.org/1916773002

8 years ago"Using Skia" tutorial: googlecode -> googlesource
borenet [Mon, 25 Apr 2016 13:01:51 +0000 (06:01 -0700)]
"Using Skia" tutorial: googlecode -> googlesource

BUG=skia:5212
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915013002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1915013002

Review URL: https://codereview.chromium.org/1915013002

8 years agoBatch multiple single NVPR draw paths to instanced draws
kkinnunen [Mon, 25 Apr 2016 09:16:09 +0000 (02:16 -0700)]
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x
                    desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x
Others results are more volatile.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002

Review URL: https://codereview.chromium.org/1908433002

8 years agoCompute bounds union while combining path range draw path batches
kkinnunen [Mon, 25 Apr 2016 06:35:35 +0000 (23:35 -0700)]
Compute bounds union while combining path range draw path batches

Compute bounds union while combining batches generated by NVPR device
independent text code-path. Otherwise the overlap test of the
GrDrawTarget::recordBatch violate painter's algorithm order.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1894973008

Review URL: https://codereview.chromium.org/1894973008

8 years agoUpdate DNG SDK version
yujieqin [Sun, 24 Apr 2016 15:14:57 +0000 (08:14 -0700)]
Update DNG SDK version

* Add PATENTS file

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1897773003

Review URL: https://codereview.chromium.org/1897773003

8 years agoUpdate SKP version
update-skps [Sun, 24 Apr 2016 07:32:19 +0000 (00:32 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918653002

Review URL: https://codereview.chromium.org/1918653002

8 years agoallow imagefilter to manage CTM decomposition
reed [Sat, 23 Apr 2016 22:19:07 +0000 (15:19 -0700)]
allow imagefilter to manage CTM decomposition

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908173006

Review URL: https://codereview.chromium.org/1908173006

8 years agoRemove SkCanvas::LayerIter guard
robertphillips [Sat, 23 Apr 2016 15:26:43 +0000 (08:26 -0700)]
Remove SkCanvas::LayerIter guard

The LayerIter is no longer required by the Bazel build.

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917693002

Review URL: https://codereview.chromium.org/1917693002

8 years agoSupport the non-native (RGBA/BGRA) swizzle
msarett [Fri, 22 Apr 2016 23:27:24 +0000 (16:27 -0700)]
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:4456
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1907593004

Review URL: https://codereview.chromium.org/1907593004

8 years agoUse SkEncodedInfo in place of SkSwizzler::SrcConfig
msarett [Fri, 22 Apr 2016 20:18:37 +0000 (13:18 -0700)]
Use SkEncodedInfo in place of SkSwizzler::SrcConfig

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911613002

Review URL: https://codereview.chromium.org/1911613002

8 years agoEnable flattening/unflattening with custom unflatten procs
msarett [Fri, 22 Apr 2016 19:43:07 +0000 (12:43 -0700)]
Enable flattening/unflattening with custom unflatten procs

Now flattenables are serialized using a string name, so that
flattenables do not necessarily need to be registered before
serialization.  They just need to override getTypeName().

Allows custom unflatten procs to be set on the SkReadBuffer.
This is optional if the flattenable is registered, but otherwise
must be called.

This was split off from:
https://codereview.chromium.org/1837913003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858323002

Review URL: https://codereview.chromium.org/1858323002

8 years agodocs: fix fiddle image links.
jcgregorio [Fri, 22 Apr 2016 18:43:42 +0000 (11:43 -0700)]
docs: fix fiddle image links.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915493004
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1915493004
TBR=hal

Review URL: https://codereview.chromium.org/1915493004

8 years agoOptionally enable SkValidatingReadBuffer in SkPictureImageFilter
robertphillips [Fri, 22 Apr 2016 18:40:42 +0000 (11:40 -0700)]
Optionally enable SkValidatingReadBuffer in SkPictureImageFilter

The task here is to get the type of ReadBuffer being used in SkPicture::MakeFromBuffer mirrored in the down-stack SkPicturePlayback::draw call.

BUG=skia:5208

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918433002

Review URL: https://codereview.chromium.org/1918433002

8 years agoskia.org: Update all fiddles for fiddle 2.0.
jcgregorio [Fri, 22 Apr 2016 18:25:43 +0000 (11:25 -0700)]
skia.org: Update all fiddles for fiddle 2.0.

The images won't show up in the preview, which won't happen until I switch over to fiddle 2.0 in production later today.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1910593005
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005

Review URL: https://codereview.chromium.org/1910593005

8 years agoRetract SkDevice a bit more
robertphillips [Fri, 22 Apr 2016 17:57:16 +0000 (10:57 -0700)]
Retract SkDevice a bit more

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905383002

Review URL: https://codereview.chromium.org/1905383002

8 years agoSkMD5: cleanup header and minor refactor
halcanary [Fri, 22 Apr 2016 17:40:49 +0000 (10:40 -0700)]
SkMD5: cleanup header and minor refactor

Also: I now define a non-virtual function in terms of a final virtual
function.  This reduces the number of actual functions while adding
no overhead.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911363002

Review URL: https://codereview.chromium.org/1911363002

8 years agoRevert of SkStringPrintf and SkString::printf now are no longer limted by a static...
halcanary [Fri, 22 Apr 2016 15:19:04 +0000 (08:19 -0700)]
Revert of SkStringPrintf and SkString::printf now are no longer limted by a static buffer (patchset #5 id:80001 of https://codereview.chromium.org/1403803002/ )

Reason for revert:
breaking something

Original issue's description:
> SkStringPrintf and SkString::printf now are no longer limted by a static buffer
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002
>
> Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c

TBR=tomhudson@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1908423002

8 years agoSkStringPrintf and SkString::printf now are no longer limted by a static buffer
halcanary [Fri, 22 Apr 2016 15:03:03 +0000 (08:03 -0700)]
SkStringPrintf and SkString::printf now are no longer limted by a static buffer

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002

Review URL: https://codereview.chromium.org/1403803002

8 years agoutils.gypi: remove empty file SkMD5.cpp
halcanary [Fri, 22 Apr 2016 14:45:38 +0000 (07:45 -0700)]
utils.gypi: remove empty file SkMD5.cpp

Review URL: https://codereview.chromium.org/1905363002

8 years agoRemove some unnecessary #includes of SkImageFilter.h
senorblanco [Fri, 22 Apr 2016 14:36:12 +0000 (07:36 -0700)]
Remove some unnecessary #includes of SkImageFilter.h

R=robertphillips@google.com
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1907283002

Review URL: https://codereview.chromium.org/1907283002

8 years agoFixes for SkRWBuffer
scroggo [Fri, 22 Apr 2016 13:59:01 +0000 (06:59 -0700)]
Fixes for SkRWBuffer

Do not call SkBufferHead::validate in SkROBuffer's destructor, which
may be called in a separate thread from SkRWBuffer::append. validate()
reads SkBufferBlock::fUsed, and append() writes to it, resulting in
a data race.

Update some comments to be more clear about how it is safe to use
these classes across threads.

Test the readers in separate threads.

In addition, make sure it is safe to create a reader even when no
data has been appended. Add tests for this case.

Mark a parameter to SkBufferHead::validate() as const, reflecting
its use.

BUG=chromium:601578
BUG=chromium:605479

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1871953002

Review URL: https://codereview.chromium.org/1871953002

8 years agoSkPDF: PDF/A runtime switch
halcanary [Fri, 22 Apr 2016 13:10:21 +0000 (06:10 -0700)]
SkPDF: PDF/A runtime switch

TODO: remove gyp variable and modify API  in SkDocument.h

SkMD5 now moved into core as pdf depends on it now.

BUG=skia:3110
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1891873002

Committed: https://skia.googlesource.com/skia/+/570f18b43417d73c3fbd113cc0b4258e08b14c82

Review URL: https://codereview.chromium.org/1891873002

8 years agoRefactor to separate backend object lifecycle and GpuResource budget decision
kkinnunen [Fri, 22 Apr 2016 08:48:29 +0000 (01:48 -0700)]
Refactor to separate backend object lifecycle and GpuResource budget decision

Refactor GrGpuResource to contain two different pieces of state:
 a) instance is budgeted or not budgeted
 b) instance references wrapped backend objects or not

The "object lifecycle" was also attached to backend object
handles (ids), which made the code a bit unclear. Backend objects
would be associated with GrGpuResource::LifeCycle, even though
GrGpuResource::LifeCycle refers to the GpuResource, and individual
backend objects in one GpuResource might be governed with different
"lifecycle".

Mark the budgeted/not budgeted with SkBudgeted::kYes, SkBudgeted::kNo.
This was previously GrGpuResource::kCached_LifeCycle,
GrGpuResource::kUncached_LifeCycle.

Mark the "references wrapped object" with boolean. This was previously
GrGpuResource::kBorrowed_LifeCycle,
GrGpuResource::kAdopted_LifeCycle for GrGpuResource.

Associate the backend object ownership status with
GrBackendObjectOwnership for the backend object handles.

The resource type leaf constuctors, such has GrGLTexture or
GrGLTextureRenderTarget take "budgeted" parameter. This parameter
is passed to GrGpuResource::registerWithCache().

The resource type intermediary constructors, such as GrGLTexture
constructors for class GrGLTextureRenderTarget do not take "budgeted"
parameters, intermediary construtors do not call registerWithCache.

Removes the need for tagging GrGpuResource -derived subclass
constructors with "Derived" parameter.

Makes instances that wrap backend objects be registered with
a new function GrGpuResource::registerWithCacheWrapped().

Removes "budgeted" parameter from classes such as StencilAttahment, as
they are always cached and never wrap any external backend objects.

Removes the use of concept "external" from the member function names.
The API refers to the objects as "wrapped", so make all related
functions use the term consistently.

No change in functionality. Resources referencing wrapped objects are
always inserted to the cache with budget decision kNo.

BUG=594928
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862043002

Review URL: https://codereview.chromium.org/1862043002

8 years agoAdd compile guard for SkCanvas::LayerIter
robertphillips [Thu, 21 Apr 2016 22:22:14 +0000 (15:22 -0700)]
Add compile guard for SkCanvas::LayerIter

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1911893002

Review URL: https://codereview.chromium.org/1911893002

8 years agoRevise WSI setup.
jvanverth [Thu, 21 Apr 2016 18:46:23 +0000 (11:46 -0700)]
Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1899213002

Review URL: https://codereview.chromium.org/1899213002

8 years agoGuard against FramebufferStatus checks in GrGLRenderTarget
robertphillips [Thu, 21 Apr 2016 18:27:43 +0000 (11:27 -0700)]
Guard against FramebufferStatus checks in GrGLRenderTarget

BUG=skia:5200

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905063002

Review URL: https://codereview.chromium.org/1905063002