Eric St. John [Fri, 8 Sep 2017 17:47:47 +0000 (10:47 -0700)]
Allow copy-local ReferenceFromRuntime
Tests may want to copy a ReferenceFromRuntime to the test output directory.
To do this, a test can set Private=true (same as you would for a Reference).
By default we don't do this, because anything in the runtime folder will be
part of the shared framework that the test runs on.
In the case of Microsoft.XmlSerializer.Generator it's reference is an
application and the project expects this to be next to the test assembly.
Commit migrated from https://github.com/dotnet/corefx/commit/
a938b3b95063b442981078b9d11ff66296daf51f
David Shulman [Tue, 12 Sep 2017 14:12:24 +0000 (10:12 -0400)]
Fix WinHttpHandler when building certificate chain (dotnet/corefx#23951)
* Fix WinHttpHandler when building certificate chain
Unlike SslStream, WinHttpHandler was not using all the certificates
obtained from the TLS/SSL handshake when building the chain. In
addition to the end-entity server certificate, there were other certs
available in the native cert handle that could be passed along
to the chain build operation.
As part of fixing this, I refactored the Common schannel and crypto
interop code so that it can be used in both SslStream and
WinHttpHandler.
I tested this manually because this cannot be easily tested in the CI
system. Added traces in WinHttpHandler to support this.
Fixes dotnet/corefx#23827
Fixes dotnet/corefx#4473
* Address PR feedback
Check for null IntPtr.
Commit migrated from https://github.com/dotnet/corefx/commit/
dcc29528c9c4633e81b1937e7dd9fde7115a938c
Viktor Hofer [Tue, 12 Sep 2017 10:29:54 +0000 (12:29 +0200)]
Cleanup code in System.Runtime.Serialization.Formatters.Tests (dotnet/corefx#23940)
* Cleanup code in System.Runtime.Serialization.Formatters.Tests
* Moved UnitySerializationHolder serialization test to System.Runtime.Tests
Commit migrated from https://github.com/dotnet/corefx/commit/
705dc4196a6139b70dcf818c109b01aa295edcb1
Viktor Hofer [Mon, 11 Sep 2017 23:38:42 +0000 (01:38 +0200)]
Adding dbnull to dbtable (dotnet/corefx#23959)
Commit migrated from https://github.com/dotnet/corefx/commit/
15c191b29a5efb4d5dbc59784feb7af54ddbe8d5
Dan Moseley [Mon, 11 Sep 2017 23:36:08 +0000 (16:36 -0700)]
Rename IsNotWinRT (dotnet/corefx#23963)
* Rename IsNotWinRT
* Remove redundant clause
Commit migrated from https://github.com/dotnet/corefx/commit/
4e529f5ddf30c69815c21211d3b1cc5d0b205070
Eric Mellino [Mon, 11 Sep 2017 23:08:58 +0000 (16:08 -0700)]
Merge pull request dotnet/corefx#23957 from qmfrederik/drawing/pathgradientbrush-pinvoke
Simplify P/Invoke logic in PathGradientBrush.InterpolationColors and SurroundColors
Commit migrated from https://github.com/dotnet/corefx/commit/
558920119d099ee3b84bd8dcfec4a13c30e723a8
Eric Mellino [Mon, 11 Sep 2017 22:47:48 +0000 (15:47 -0700)]
Merge pull request dotnet/corefx#23958 from qmfrederik/drawing/pen-pinvoke
System.Drawing - Simplify Pen.get_DashPattern P/Invoke code
Commit migrated from https://github.com/dotnet/corefx/commit/
839f044a48f46fef0771e2fd255d061c0a9fcb44
Eric Mellino [Mon, 11 Sep 2017 22:14:43 +0000 (15:14 -0700)]
Merge pull request dotnet/corefx#23956 from qmfrederik/drawing/pinvoke
System.Drawing - Fix and simplify PathGradientBrush.Blend and GdipSaveImageToFile_delegate PInvoke code
Commit migrated from https://github.com/dotnet/corefx/commit/
3a09bd39562d6af40caaddeb7783976c2755d3a3
Ahson Ahmed Khan [Mon, 11 Sep 2017 21:44:24 +0000 (14:44 -0700)]
Enable S.R.CS.Unsafe and System.Memory tests for UAP (dotnet/corefx#23905)
* Enable S.R.CS.Unsafe and System.Memory tests for UAP
* Disable tests failing on uapaot with issues 23952 and 23953.
* Fixing typo in issue#
Commit migrated from https://github.com/dotnet/corefx/commit/
7b6024a58127ca855823a3f007c76d240f89db64
Ahson Ahmed Khan [Mon, 11 Sep 2017 21:43:44 +0000 (14:43 -0700)]
Adding log message containing actual number of compares for Span API tests (dotnet/corefx#23901)
* Logging actual number of compares on test failures.
* Simplifying log message as per PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
2f83f08a343920e60391bed3b09eb38223e6c78a
Frederik Carlier [Mon, 11 Sep 2017 21:29:05 +0000 (23:29 +0200)]
Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6351e27655cc8aec281acdf35e4c9c2397580904
Frederik Carlier [Mon, 11 Sep 2017 21:14:10 +0000 (23:14 +0200)]
PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
2827f05456d52e4509bb72bf58f20b0c9e5642f2
Viktor Hofer [Mon, 11 Sep 2017 20:49:26 +0000 (22:49 +0200)]
DbNull serialization with tests and forward (dotnet/corefx#23897)
* DbNull tests and forward
* UnitySerializationHolder deserialization test added
Commit migrated from https://github.com/dotnet/corefx/commit/
9ab8189268fbc6c4e98f8d10a6753d0477ef3239
Frederik Carlier [Thu, 7 Sep 2017 11:39:20 +0000 (13:39 +0200)]
Save Pen.cs using UTF-8 encoding
Commit migrated from https://github.com/dotnet/corefx/commit/
c75e0a7c6fa4f3075a81f3c2056f478c570f7fdf
Frederik Carlier [Thu, 7 Sep 2017 07:08:54 +0000 (09:08 +0200)]
Pen: Try to replicate exact Desktop System.Drawing behavior, cross-platform.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ebd22464238bc1bd84e635e554c317220d0fc03
Frederik Carlier [Wed, 6 Sep 2017 21:43:31 +0000 (23:43 +0200)]
Further fine-tine the PenTests
Commit migrated from https://github.com/dotnet/corefx/commit/
161d15ecd63d0b67fe66de1af3cb3b37c1af0cad
Frederik Carlier [Wed, 6 Sep 2017 21:30:57 +0000 (23:30 +0200)]
Simplify Pen.get_DashPattern, improve libgdiplus compatibility.
Commit migrated from https://github.com/dotnet/corefx/commit/
22d0801f6bd285c884b4a9649e666b682c88d4e2
Frederik Carlier [Wed, 6 Sep 2017 21:17:19 +0000 (23:17 +0200)]
Simplify PathGradientBrush.set_SurroundColors, to better match Desktop behavior
Replicate the Desktop behavior in PathGradientBrush.set_InterpolationColors
Commit migrated from https://github.com/dotnet/corefx/commit/
8690ad7eefdfd54b59b7e4054f902104792e74c3
Frederik Carlier [Wed, 6 Sep 2017 20:24:33 +0000 (22:24 +0200)]
Simplify P/Invoke logic in PathGradientBrush.InterpolationColors
Commit migrated from https://github.com/dotnet/corefx/commit/
8fa9cac973f7cb7cb0bf5746b753f75f88f2227a
Frederik Carlier [Mon, 4 Sep 2017 21:05:03 +0000 (23:05 +0200)]
Fix P/Invoke for PathGradientBrush
Commit migrated from https://github.com/dotnet/corefx/commit/
e9bd0a167b8bb087d01f73993641808601c05829
Stephen Toub [Mon, 11 Sep 2017 19:03:22 +0000 (12:03 -0700)]
Make Stream.Write/ReadAsync(Memory, ...) virtual in ref (dotnet/corefx#23944)
I neglected to add the virtual keyword when adding these to the ref file.
Commit migrated from https://github.com/dotnet/corefx/commit/
0db882976652ca2df45e763ffbab063f4faef79a
William Godbe [Mon, 11 Sep 2017 18:49:33 +0000 (11:49 -0700)]
Merge pull request dotnet/corefx#23895 from wtgodbe/RevertLabel
Revert PreReleaseLabel
Commit migrated from https://github.com/dotnet/corefx/commit/
ae4c6915057ebf62e75ef213c8797ed28e8aec1d
Eric Mellino [Mon, 11 Sep 2017 18:33:50 +0000 (11:33 -0700)]
Merge pull request dotnet/corefx#23489 from fiigii/IntelIntrinsic
Add Intel hardware intrinsic APIs to CoreFX
Commit migrated from https://github.com/dotnet/corefx/commit/
651372eef1fc4b95a1098c868b725d7fc6090970
Jose Perez Rodriguez [Mon, 11 Sep 2017 18:31:36 +0000 (11:31 -0700)]
Merge pull request dotnet/corefx#23946 from dotnet/joperezr-fixbuildbreak
Fixing build break
Commit migrated from https://github.com/dotnet/corefx/commit/
6a24dde7453f201508f9aad3196a72457660a37f
Eric Mellino [Mon, 11 Sep 2017 17:54:08 +0000 (10:54 -0700)]
Merge pull request dotnet/corefx#23753 from mellinoe/system.drawing-cleanup-misc
Delete Unix-specific ColorTranslator, KnownColor, SystemColors
Commit migrated from https://github.com/dotnet/corefx/commit/
49e7212e2ee18bbe9c6138bbb4d0fe17b641967e
Jose Perez Rodriguez [Mon, 11 Sep 2017 17:48:38 +0000 (10:48 -0700)]
Fixing build break
Changing Reference item with P2P reference instead.
Commit migrated from https://github.com/dotnet/corefx/commit/
2d5901e37416d3d737f7405b94c0ec3d42e5f806
Jon Hanna [Mon, 11 Sep 2017 14:51:28 +0000 (15:51 +0100)]
Remove dead path from BigInteger ctor (dotnet/corefx#23930)
If a BigInteger is created from a byte array of more than 4 bytes, and
all of them are zero, then a path is taken assign the zero constant to
the constructed struct.
However, as trailing zero bytes are skipped, no all-zero sequence will
be treated as being larger than zero bytes, so the path can never be
hit.
Remove it.
Commit migrated from https://github.com/dotnet/corefx/commit/
3842ebf5358a00fdfc3400b3af7703149aa7c561
Petr Bred [Mon, 11 Sep 2017 14:47:20 +0000 (17:47 +0300)]
Fix Tizen build (dotnet/corefx#23939)
- fix repos logic
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
68e404ad24b6061130f97b188f84766f840c4649
Stephen Toub [Mon, 11 Sep 2017 14:03:31 +0000 (10:03 -0400)]
Expose/add tests for Memory-based Stream overloads (dotnet/corefx#23776)
Commit migrated from https://github.com/dotnet/corefx/commit/
4001151f37e05146e870e96f2a8d417193447c33
Eric Erhardt [Mon, 11 Sep 2017 14:01:29 +0000 (09:01 -0500)]
Merge pull request dotnet/corefx#23894 from eerhardt/UpdateBuildTools
Automatic updating of buildtools version.
Commit migrated from https://github.com/dotnet/corefx/commit/
a368dbee815412cf92d8d38f1d2129effc7b0cd9
James Ko [Mon, 11 Sep 2017 07:20:46 +0000 (03:20 -0400)]
Cleanup code in SortedSet (dotnet/corefx#22839)
* Cleanup code in SortedSet
* Respond to PR feedback
* Remove failing assert
* Respond to PR feedback
* Move some static methods
* Remove duplicate comments
Commit migrated from https://github.com/dotnet/corefx/commit/
6ad6bce5f9fd1f2d98ea30a049bdfcee3f4d0ed3
Kevin Gosse [Mon, 11 Sep 2017 07:17:36 +0000 (09:17 +0200)]
Add BinaryReader Span-based APIs (dotnet/corefx#23589)
* Add BinaryReader Span-based APIs
* Add non-regression tests on impacted methods
* Move span tests to netcoreapp file
* Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
d9438cbfe9a203a009b5d1a6e5970d898f72fcc1
Dan Moseley [Mon, 11 Sep 2017 06:57:28 +0000 (23:57 -0700)]
Rename IsWinRT to IsInAppContainer (dotnet/corefx#23935)
* Rename IsWinRT to IsInAppContainer
* Grep error
Commit migrated from https://github.com/dotnet/corefx/commit/
8d51233795da222041c23d33b1eb44bbe458d0eb
dotnet-maestro-bot [Mon, 11 Sep 2017 06:22:57 +0000 (23:22 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-25711-01, preview2-25710-02, beta-25711-00, beta-25711-00, respectively (dotnet/corefx#23931)
Commit migrated from https://github.com/dotnet/corefx/commit/
8239bcfd7eb13f5617084962a00bdaef5fae25e5
Dan Moseley [Mon, 11 Sep 2017 06:09:11 +0000 (23:09 -0700)]
Log Windows ProductType (dotnet/corefx#23934)
* Log Windows ProductType
* Missed line
Commit migrated from https://github.com/dotnet/corefx/commit/
45ebf46731aee78fefbbe06de90dc222fba12835
Stephen Toub [Sun, 10 Sep 2017 11:29:02 +0000 (07:29 -0400)]
Add more DateTime parsing tests (dotnet/corefx#23893)
* Add more DateTime parsing tests
As part of adding span support to DateTime, I'm adding some more tests. This increases code coverage of DateTimeParse from a bit over 40% to a bit over 60%.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
dd62712ca69f0c817f6ae59eb30236bc2eaec795
dotnet-maestro-bot [Sun, 10 Sep 2017 03:37:15 +0000 (20:37 -0700)]
Update CoreClr, CoreSetup to preview2-25709-04, preview2-25709-02, respectively (dotnet/corefx#23924)
Commit migrated from https://github.com/dotnet/corefx/commit/
03076d337e700b2760f0cfb680f97f55cddc7069
David Shulman [Sun, 10 Sep 2017 01:38:32 +0000 (21:38 -0400)]
Disable brittle WebSockets.Client test (dotnet/corefx#23920)
System.Net.WebSockets.Client.Tests.KeepAliveTest/KeepAlive_LongDelayBetweenSendReceives_Succeeds
"System.Net.WebSockets.WebSocketException : The WebSocket is in an
invalid state ('Aborted') for this operation. Valid states are: 'Open,
CloseReceived, CloseSent, Closed'"
dotnet/corefx#23204
Commit migrated from https://github.com/dotnet/corefx/commit/
d075c7d1ca07657a3c4f71a94dd944d9ab28d31a
dotnet-maestro-bot [Sat, 9 Sep 2017 23:38:14 +0000 (16:38 -0700)]
Update CoreClr to preview2-25709-03 (dotnet/corefx#23914)
Commit migrated from https://github.com/dotnet/corefx/commit/
8201068403325a92b7fdc0c7013c14776517c9a7
Stephen Toub [Sat, 9 Sep 2017 23:22:32 +0000 (19:22 -0400)]
Merge pull request dotnet/corefx#23841 from ahsonkhan/AddToSystemRuntime
Expose {ReadOnly}Memory from System.Runtime
Commit migrated from https://github.com/dotnet/corefx/commit/
df221ece47fa78ae2d714eb821dfbf90a85914e6
Eric Erhardt [Sat, 9 Sep 2017 22:35:51 +0000 (17:35 -0500)]
Merge branch 'master' into UpdateBuildTools
Commit migrated from https://github.com/dotnet/corefx/commit/
df28f7d7fe63e9c8413a70ecf9b8424fcc839e8d
Jon Hanna [Sun, 27 Aug 2017 20:47:40 +0000 (21:47 +0100)]
Don't use .Append within tests, as netfx doesn't support it.
Commit migrated from https://github.com/dotnet/corefx/commit/
b0fe5f463cd2cba63ba43372af9a228a3032b027
Jon Hanna [Sun, 27 Aug 2017 17:47:58 +0000 (18:47 +0100)]
Add more HttpUtilityTests
Commit migrated from https://github.com/dotnet/corefx/commit/
dcdc4cb2a55239945bddddf5a3b39addf8b92416
Jon Hanna [Sun, 27 Aug 2017 17:16:51 +0000 (18:16 +0100)]
Inline private ParseQueryString into caller.
Allows for avoiding allocation for initial ?
Commit migrated from https://github.com/dotnet/corefx/commit/
c10afbe49244f2f0940265d48531710abf6dc331
Jon Hanna [Sun, 27 Aug 2017 16:22:34 +0000 (17:22 +0100)]
Simplify ParseQueryString exit logic.
Checks for exit conditions two ways, when just one suffices.
Commit migrated from https://github.com/dotnet/corefx/commit/
8f54be4d97424996822d4aead20886435c34ea1a
Jon Hanna [Sun, 27 Aug 2017 16:19:43 +0000 (17:19 +0100)]
Only strip initial ? in HttpUtility.ParseQueryString once.
Fixes dotnet/corefx#23574
Commit migrated from https://github.com/dotnet/corefx/commit/
b571c57580f4ca5140f2b83061c1589b018fe4a6
Jon Hanna [Sun, 27 Aug 2017 16:13:48 +0000 (17:13 +0100)]
Don't HTML-decode in HttpUtility.ParseQueryString
Fixes dotnet/corefx#23582
Commit migrated from https://github.com/dotnet/corefx/commit/
2142e46b27193362bfe6279ca4cff70ef61572b2
dotnet-maestro-bot [Sat, 9 Sep 2017 04:10:15 +0000 (21:10 -0700)]
Update CoreClr, CoreSetup to preview2-25709-02, preview2-25708-02, respectively (dotnet/corefx#23903)
Commit migrated from https://github.com/dotnet/corefx/commit/
408b2bc542034729303a8dc36617963165a17091
Tarek Mahmoud Sayed [Sat, 9 Sep 2017 01:05:32 +0000 (18:05 -0700)]
Switch OSX CI runs to use Helix (dotnet/corefx#23831)
* Switch CI OSX runs to use Helix
* remove wrong property
* Add run test stage on helix
Commit migrated from https://github.com/dotnet/corefx/commit/
6c8013510eea8cd789633916cc7d130bdd5d41b5
dotnet-maestro-bot [Sat, 9 Sep 2017 00:25:54 +0000 (17:25 -0700)]
Update CoreClr, Standard to preview2-25708-02, preview1-25708-01, respectively (dotnet/corefx#23880)
Commit migrated from https://github.com/dotnet/corefx/commit/
cc01449a9cfc92796b93d1497abc1d8cde0eeb7e
danmosemsft [Sat, 9 Sep 2017 00:12:21 +0000 (17:12 -0700)]
Update apicompat baselines. Not in build
Commit migrated from https://github.com/dotnet/corefx/commit/
9f62ce17f4132fea37e7216ab74d3639070debe0
David Shulman [Fri, 8 Sep 2017 23:57:29 +0000 (19:57 -0400)]
Merge pull request dotnet/corefx#23892 from davidsh/22808_1
Disable sockets test always failing on Desktop
Commit migrated from https://github.com/dotnet/corefx/commit/
d8ca67afa622db4a88d76da4658b9d74da84e44e
Atsushi Kanamori [Fri, 8 Sep 2017 21:55:05 +0000 (14:55 -0700)]
Expose the recently approved Reflection apis in contracts (dotnet/corefx#23882)
Fixes https://github.com/dotnet/corefx/issues/22866
Fixes https://github.com/dotnet/corefx/issues/16567
Commit migrated from https://github.com/dotnet/corefx/commit/
59a56d0676ff239851ae5d0c1ce55d6a50605f76
ahsonkhan [Fri, 8 Sep 2017 21:39:30 +0000 (14:39 -0700)]
Move GCHandle and GCHandleType to System.Runtime reference assembly.
Commit migrated from https://github.com/dotnet/corefx/commit/
cf17f15ed10e6151df062e477cbb87de018056d8
Eric Erhardt [Fri, 8 Sep 2017 21:04:16 +0000 (16:04 -0500)]
Automatic updating of buildtools version.
Commit migrated from https://github.com/dotnet/corefx/commit/
18f7ad2ddcfd72c3b6473a4a4a0edd6ab5283f1b
Fei Peng [Tue, 22 Aug 2017 22:00:47 +0000 (15:00 -0700)]
Add Intel hardware intrinsic APIs to CoreFX
Commit migrated from https://github.com/dotnet/corefx/commit/
06c518ba822fd753fcdf8bd7ba7969e1b4377191
wtgodbe [Fri, 8 Sep 2017 21:14:27 +0000 (14:14 -0700)]
Revert PreReleaseLabel
Commit migrated from https://github.com/dotnet/corefx/commit/
7cd209226ef8f83bec8078dda1193b80824b6ea1
David Shulman [Fri, 8 Sep 2017 20:42:59 +0000 (13:42 -0700)]
Disable sockets test always failing on Desktop
System.Net.Sockets.Tests.AcceptTask
Accept_WithTargetSocket_ReuseAfterDisconnect_Success
"System.InvalidOperationException : acceptSocket: The socket must not be
bound or connected."
dotnet/corefx#22808
Commit migrated from https://github.com/dotnet/corefx/commit/
f42ac6027ce087766cc69fd9f8b053a0737a9b5a
Vitek Karas [Fri, 8 Sep 2017 19:51:53 +0000 (12:51 -0700)]
Xml schema dependency removal for AOT compilers (dotnet/corefx#23867)
This changes fixes a size issue in AOT compiled code which uses XmlReader. Using XmlReader for just reading XML without validation still pulls in all of the XmlSchema code. This makes the AOT compilation slow (it's more than 400KB of IL) and the resulting app is larger (.NET Native X86 measures the difference at more than 800KB of native code).
The change relies on an assumption, that apps which don't need validation will not call the XmlReaderSettings.ValidationType setter. As such it can be reduced away and the change then ties all the dependencies needed for validation to that setter. So if the setter itself is not called XmlSchema is not pulled in.
Commit migrated from https://github.com/dotnet/corefx/commit/
91e89384e54a23a4d70bc1cc90182ac7f98232af
Tom Deseyn [Fri, 8 Sep 2017 19:50:29 +0000 (21:50 +0200)]
Only truncate to IOV_MAX for stream sockets (dotnet/corefx#23826)
* Only truncate to IOV_MAX for stream sockets
* Don't check for -1
* Add UDP tests
* Remove truncated condition
* SocketPal.Unix: don't truncate iovecs
* segmentCount -> SegmentCount
* Move IovMax tests to non-template SendReceive class
* Only receive udp packets meant for us
* retrieve receiver EndPoint before it is possibly disposed
* Avoid blocking test due to dropped UDP packets
Commit migrated from https://github.com/dotnet/corefx/commit/
7f5b838709fb4726b6227922cfaca1ea6d99d779
Stephen Toub [Fri, 8 Sep 2017 13:38:17 +0000 (09:38 -0400)]
Merge pull request dotnet/corefx#23594 from stephentoub/timespan_span
Expose/test TimeSpan span-based methods
Commit migrated from https://github.com/dotnet/corefx/commit/
41d1d77c93f4302b0bc87c0eb1fe6618d210c9ab
dotnet-maestro-bot [Fri, 8 Sep 2017 11:13:39 +0000 (04:13 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25708-01, preview2-25707-02, preview2-25707-02, beta-25708-00, beta-25708-00, preview1-25707-01, respectively (dotnet/corefx#23784)
Commit migrated from https://github.com/dotnet/corefx/commit/
02375998595cabb83bb8ef54ab2a20501d106922
Karthik Rajasekaran [Thu, 7 Sep 2017 23:32:02 +0000 (16:32 -0700)]
Retry arm leg on a new machine (dotnet/corefx#23860)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a234013d2bfa76f1bc1e52f75303fd0fe03b879
Lakshmi Priya Sekar [Thu, 7 Sep 2017 22:11:59 +0000 (15:11 -0700)]
Merge pull request dotnet/corefx#23821 from Priya91/credentialmh
Use only CredentialCache for authentication when redirecting Uris in ManagedHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
2b889c4a2d9877b7112d9a57061b92366d9c257a
Maggie Tsang [Thu, 7 Sep 2017 22:03:42 +0000 (15:03 -0700)]
Random span-based API tests (dotnet/corefx#23692)
* Random span extensions
* Random span tests
* random span tests
* Test configurations
* Fixed item group condition
Commit migrated from https://github.com/dotnet/corefx/commit/
94a3498f3f8536e198e0e51c98fea3343e2e2a50
Joel Braun [Thu, 7 Sep 2017 21:53:15 +0000 (14:53 -0700)]
Ported a missing SqlParameter constructor (dotnet/corefx#23787)
* Added a SqlParameter constructor
* Added SqlParameter constuctor test
* Updated SqlParameter constructor to use different chained constructor
* Update SqlParameter constructor test
Commit migrated from https://github.com/dotnet/corefx/commit/
4341d5c9beef55566b85d4e57d2ed93b4f3d388b
Omar Tawfik [Thu, 7 Sep 2017 21:27:19 +0000 (14:27 -0700)]
Fix LargeArrayBuilder.CopyTo returning incorrect end-of-copy position (dotnet/corefx#23817)
* Fix dotnet/corefx#23680
* PR Feedback
* More tests
* More tests
Commit migrated from https://github.com/dotnet/corefx/commit/
9b889979fdef831c77280d2b2fd506a76ddc01c2
Krzysztof Wicher [Thu, 7 Sep 2017 20:24:55 +0000 (13:24 -0700)]
Merge pull request dotnet/corefx#23832 from krwq/XmlTestsXunit
Make Xunit detect tests from Xml custom test fx (no more outerloop tests in S.P.Xml)
Commit migrated from https://github.com/dotnet/corefx/commit/
c21cfe8e9ac156cb77044fae0c8500aba90e6f20
Viktor Hofer [Thu, 7 Sep 2017 20:06:38 +0000 (22:06 +0200)]
backport of REGEX_DEFAULT_MATCH_TIMEOUT (dotnet/corefx#23666)
* backport of REGEX_DEFAULT_MATCH_TIMEOUT
* Add more exception tests && improve exception logging
Commit migrated from https://github.com/dotnet/corefx/commit/
a6a75b9f2db48137256d2e92cb3df89a9dbf638b
Chen [Thu, 7 Sep 2017 18:37:59 +0000 (02:37 +0800)]
Fix ArgumentException message in CookieContainer.Add . (dotnet/corefx#23849)
* Fix ArgumentException message in CookieContainer.Add .
Add SR.Format usage.
* Make argument name refactoring-friendly.
Commit migrated from https://github.com/dotnet/corefx/commit/
fc5de7098fb11b919e4c945924e8bb80924de92e
Italo Pessoa [Thu, 7 Sep 2017 18:31:15 +0000 (15:31 -0300)]
remove dead strings (dotnet/corefx#23710) (dotnet/corefx#23851)
System.Runtime.Extensions\src\Resources\Strings.resx
* Argument_PathFormatNotSupported
* Arg_PathIllegal
* Arg_PathIllegalUNC
* InvalidOperation_Cryptography
* Serialization_InsufficientState
Commit migrated from https://github.com/dotnet/corefx/commit/
7b0161a36dd4d254a9913a771811769cf2f9b191
Lakshmi Priya Sekar [Thu, 7 Sep 2017 18:18:43 +0000 (11:18 -0700)]
Consolidate code between different Http handlers.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ef59053709ef8b6f5b30b709bffbe38fcb19823
Krzysztof Wicher [Thu, 7 Sep 2017 17:03:29 +0000 (10:03 -0700)]
add copyright header, simplify method syntax
Commit migrated from https://github.com/dotnet/corefx/commit/
54e89a60294963bab46656819c337596860a565a
Jeremy Barton [Thu, 7 Sep 2017 15:49:11 +0000 (08:49 -0700)]
Merge pull request dotnet/corefx#23417 from vladimir-kazakov/encrypted-xml-missing-apis
Add missing members to EncryptedXml.
Commit migrated from https://github.com/dotnet/corefx/commit/
46579e40b32f86301363f8e7c7d9637218e243b2
Eric StJohn [Thu, 7 Sep 2017 15:38:39 +0000 (08:38 -0700)]
Merge pull request dotnet/corefx#23836 from ericstj/rollBackRefAssmVerInbox
Avoid downgrading to netstandard reference assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
c068d0159261c54a68db37186c9692887ced634b
Frederik Carlier [Thu, 7 Sep 2017 06:58:16 +0000 (08:58 +0200)]
System.Drawing: Consolidate the FontFamily class (dotnet/corefx#23194)
* Use the Windows FontFamily implementation on both Windows and Unix
* Use the name when comparing two font families.
* Fix SystemFont_Get_ReturnsExpected
Commit migrated from https://github.com/dotnet/corefx/commit/
c31564c6153f1b2d377839590a9ac93740e4dad5
Dan Moseley [Thu, 7 Sep 2017 04:47:40 +0000 (21:47 -0700)]
Disable RO-filesystem tests on RH69 (dotnet/corefx#23842)
* Disable RO filesystem tests on RH69
* Disable
Commit migrated from https://github.com/dotnet/corefx/commit/
3f6fc6bdb578cfa06324735a2fcab09decced96a
Stephen Toub [Thu, 7 Sep 2017 04:11:34 +0000 (00:11 -0400)]
Respect UseProxy better in ManagedHandler (dotnet/corefx#23750)
To match CurlHandler, we should only be using environment variable-based proxy configuration if UseProxy is true, but we're currently using it regardless. This commit fixes that and adds a test for it.
Commit migrated from https://github.com/dotnet/corefx/commit/
7615a2c1dde51e0797ed3ffbca70191af2aef79e
ahsonkhan [Thu, 7 Sep 2017 00:55:42 +0000 (17:55 -0700)]
Expose {ReadOnly}Memory from System.Runtime
Commit migrated from https://github.com/dotnet/corefx/commit/
6843117e57d30dda013fcafe470ea17053426939
Krzysztof Wicher [Wed, 6 Sep 2017 21:38:30 +0000 (14:38 -0700)]
fix runtime errors on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
1efef1283c0c3338b2adcbb70a54780b11b9340e
Eric St. John [Wed, 6 Sep 2017 21:25:52 +0000 (14:25 -0700)]
Avoid downgrading to netstandard reference assembly
Similar to dotnet/corefx@
75962dae7f338445b57d7d276d018774e1dd2e46 but for the reference assembly.
The reference assembly for System.Memory on netcoreapp2.1 is significantly
different since types have been pushed down into System.Runtime. We need to
make sure that is used on netcoreapp2.1 to avoid any type conflicts.
Commit migrated from https://github.com/dotnet/corefx/commit/
abaff3c1ad600ee8fa7e85a313966cf2e214dcba
Ahson Ahmed Khan [Wed, 6 Sep 2017 20:28:04 +0000 (13:28 -0700)]
Adding Memory, OwnedMemory, MemoryHandle, and IRetainable & Tests (dotnet/corefx#23701)
* Adding Memory, OwnedMemory, MemoryHandle, and IRetainable
* Adding initial tests and fixing Memory.Empty property
* Adding {RO}Memory tests and fixing XML comments based on feedback.
* Removing netstandard1.0 build configuration and adding netstandard1.1.
* Fixing errors in the upgrade from netstandard1.0 to netstandard1.1.
* Removing Windows Phone 8 as a supported framework for System.Memory package.
Commit migrated from https://github.com/dotnet/corefx/commit/
f10dc060613fe2a3a4e6181673de934781ed7e8c
Krzysztof Wicher [Wed, 6 Sep 2017 18:01:17 +0000 (11:01 -0700)]
Make Xunit detect tests from Xml custom test fx (no more outerloop tests
in S.P.Xml)
Commit migrated from https://github.com/dotnet/corefx/commit/
d32bf2ab4cee61ec1cbf4018fb77b460bf12a679
David Shulman [Wed, 6 Sep 2017 18:42:35 +0000 (14:42 -0400)]
Merge pull request dotnet/corefx#23829 from davidsh/23702_1
Disable default proxy test on Desktop
Commit migrated from https://github.com/dotnet/corefx/commit/
68aa52ff5387d6bfc8f15fad45945376a8d70b72
Egor Bogatov [Wed, 6 Sep 2017 18:39:12 +0000 (21:39 +0300)]
[System.Data] fix dotnet/corefx#22879 (SqlConnection doesn't support empty values) (dotnet/corefx#23352)
* [System.Data] fix dotnet/corefx#22879 (SqlConnection doesn't support empty values)
* replace string.IsNullOrWhiteSpace with null-check to match reference sources.
* split SqlConnectionEmptyParameters test into three different tests
* handle empty value in ConvertValueToIntegratedSecurity
Commit migrated from https://github.com/dotnet/corefx/commit/
fdbb160aeb0fad168b3603dbdd971d568151a0c8
David Shulman [Wed, 6 Sep 2017 17:41:14 +0000 (10:41 -0700)]
Disable default proxy test on Desktop
HttpClient test ProxyExplicitlyProvided_DefaultCredentials_Ignored has
started failing on Desktop due to build system changes. Disabling for
now.
dotnet/corefx#23702
Commit migrated from https://github.com/dotnet/corefx/commit/
2c50d92d6d07173db6ec5c8a6a17085613972a3b
Tarek Mahmoud Sayed [Wed, 6 Sep 2017 16:48:03 +0000 (09:48 -0700)]
Fix NumberFormatInfoNumberGroupSizes failed test (dotnet/corefx#23820)
Commit migrated from https://github.com/dotnet/corefx/commit/
0ba94e226e0440e3faaecdc7c2643b6002e5a167
Alfred Myers [Wed, 6 Sep 2017 12:16:04 +0000 (09:16 -0300)]
fixed typos and formatting (dotnet/corefx#23819)
Commit migrated from https://github.com/dotnet/corefx/commit/
53308c54ec3d91c529cb48d54b7f780fce79f3df
Lakshmi Priya Sekar [Wed, 6 Sep 2017 00:59:17 +0000 (17:59 -0700)]
Use only CredentialCache when redirecting Uris in ManagedHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
9d5f5d1f8630e3c50404647926496b0d45cf1203
José Rivero [Wed, 6 Sep 2017 00:39:16 +0000 (17:39 -0700)]
Moving the Windows Performance runs from Server 2012 to Server 2016. (dotnet/corefx#23714)
Commit migrated from https://github.com/dotnet/corefx/commit/
06b1365d9881ed26a921490d7edd2d4e4de35565
Viktor Hofer [Tue, 5 Sep 2017 23:34:07 +0000 (01:34 +0200)]
Fixing uap serialization errors for exceptions (dotnet/corefx#23808)
* Fixing uap serialization errors for exceptions
* pr changes
* Revert two updated blobs
Commit migrated from https://github.com/dotnet/corefx/commit/
c89b4fb5050d9ca3de86dddce7fe3fd9dc34dc33
lajones [Tue, 5 Sep 2017 22:07:21 +0000 (15:07 -0700)]
Merge pull request dotnet/corefx#23581 from JonHanna/annotation_refactor
Some refactoring in System.ComponentModel.DataAnnotations
Commit migrated from https://github.com/dotnet/corefx/commit/
7269a3b3cd0873d85cd93ba7435d15887fac2fd2
Tarek Mahmoud Sayed [Tue, 5 Sep 2017 22:03:06 +0000 (15:03 -0700)]
Enable detecting Red Hat distors in PlatformDetection (dotnet/corefx#23775)
* Enable detecting Red Hat distors in PlatformDetection
* Add RedHat properties to PlatformDetection class
Commit migrated from https://github.com/dotnet/corefx/commit/
f0a9551d38ddf76a02c4c65cce74559263466ddd
Gene Lee [Tue, 5 Sep 2017 21:00:09 +0000 (14:00 -0700)]
Fix connection pool & connection pool group fragmentation (dotnet/corefx#23722)
Commit migrated from https://github.com/dotnet/corefx/commit/
4839aaf6dbbf2d453b9c27283325e0df90db5f5d
Jon Hanna [Tue, 5 Sep 2017 20:48:09 +0000 (21:48 +0100)]
Remove code in Microsoft.CSharp for casting from method groups. (dotnet/corefx#23371)
As a method group cannot be cast to object, the casting from method
group to delegate that can be done in static code is not relevant, and
code related to such casts is never reached.
Remove it. Includes removal of ExprFuncPtr, and ERR_MethGrpToNonDel,
ERR_BadRetType, ERR_DelegateOnNullable & ERR_BadDelegateConstructor,
contributes to dotnet/corefx#22470
Commit migrated from https://github.com/dotnet/corefx/commit/
ac9ccd4f02e0c4f2c887618048bcca4c33c89200
Santiago Fernandez Madero [Tue, 5 Sep 2017 20:30:09 +0000 (13:30 -0700)]
Add BinPlaceConfiguration for test projects to have a working directory per BuildConfiguration (dotnet/corefx#23633)
* With this change we will have the next behavior when building/running tests:
-When building the tests we will still bin place the test assets to the OutputDirectory (corefx\bin\OSGroup.Configuration\TestProject\TargetGroup/)
-When running the tests we will bin place the tests assets to this new TestPath which will be the TestPath. This new path will be the test's working directory where we will bin place the RunTests.cmd and necessary dependencies in tests.targets. Also the testResults.xml will be found here after the test execution.
-TestPath is set to be bin/tests/<TestProject>/<BuildConfiguration>/ (i.e corefx\bin\tests\System.Collections.Immutable.Tests\netcoreapp-Windows_NT-Debug-x64) in dir.props
-This TestPath will be added to the BinPlaceDir in FrameworkTargeting.targets when BinPlaceTest is set to true. Then in the BinPlaceFiles target the test assets will be hardlinked to the TestPath.
This will isolate every test execution per build configuration and will allow people to run the same test project for all of the supported configurations on the same repo without having to clean the repo.
Commit migrated from https://github.com/dotnet/corefx/commit/
664ca9508a03483a7fb2714b55b9cba885593d90
Jon Hanna [Tue, 5 Sep 2017 20:29:54 +0000 (21:29 +0100)]
Remove Microsoft.CSharp's checks on pointer or static type parameters. (dotnet/corefx#23286)
Since types come from live instances, and pointer operations are
already prohibited, this case can't come up.
Entails removal of ERR_BadTypeArgument and ERR_GenericArgIsStaticClass,
contributes to dotnet/corefx#22470
Commit migrated from https://github.com/dotnet/corefx/commit/
23cd62dfaf37712c4acf765e9b21914f848e0d84
Jon Hanna [Tue, 5 Sep 2017 20:25:39 +0000 (21:25 +0100)]
Remove unused properties from ErrorType (dotnet/corefx#23248)
* Remove parent parameter to CreateError and pParentType to GetErrorType
Only ever called with null; the one path that sets it to something else
only being hit if another ErrorType instance had it set to something
else, and so never happening.
* Remove TypeParent from ErrorType
Never not null
* Remove by-parent-type lookup for ErrorType instances.
Never used.
* Remove ErrAppendParentType
If called with an ErrorType calls ErrAppendParentCore which returns immediately if the namespace parent is either null or the rootNS, which is the only two possibilities.
As such it's always an no-op, so remove that call. Since this is the only call existing, remove entirely.
* Remove namespace parameter from LookupError and InsertError
Always the root namespace, so doesn't affect lookup.
* Make HasParent a simple boolean property.
Since the namespace, if set, is always the same one, and not examined beyond whether it is set, it's essentially a flag.
* Determine ErrorType.HasParent by whether nameText is null.
Always false if it's null, true otherwise, so use that as the storage.
* Add explanatory comment.
Commit migrated from https://github.com/dotnet/corefx/commit/
10a76752c95853ed74297fa817ff897ad389e3d8
Stephen Toub [Tue, 5 Sep 2017 17:04:59 +0000 (13:04 -0400)]
Fix behavior of Dns.GetHost* with empty string (dotnet/corefx#23794)
On Windows, passing an empty string to gethostbyname/GetAddrInfoW results in the host's information being used; that behavior then bubble's up through (and is documented for) the Dns.GetHost* APIs in .NET. On Unix, the native functions being used don't provide that same behavior, instead returning an error.
This just special-cases empty string in the Unix implementation.
Commit migrated from https://github.com/dotnet/corefx/commit/
e9bd4c87e5032184c51ba03b81ef74328bbdfb1a
Tom Deseyn [Tue, 5 Sep 2017 16:53:36 +0000 (18:53 +0200)]
Truncate sendmsg/recvmsg to IOV_MAX (dotnet/corefx#23781)
* Truncate sendmsg/recvmsg to IOV_MAX
* PR feedback
* Remove newline
Commit migrated from https://github.com/dotnet/corefx/commit/
b15aab8a6fa286585da10f3f4c017852f89edbd7