Robert Dewar [Fri, 22 Aug 2008 15:46:00 +0000 (17:46 +0200)]
s-sopco4.adb: Minor code fix to avoid warning
2008-08-22 Robert Dewar <dewar@adacore.com>
* s-sopco4.adb: Minor code fix to avoid warning
* s-sopco5.adb: Minor code fix to avoid warning
* s-strops.adb: Minor code fix to avoid warning
From-SVN: r139488
Arnaud Charlet [Fri, 22 Aug 2008 15:45:45 +0000 (17:45 +0200)]
lib-xref.ads: Fix typo in subprogram reference definition.
2008-08-22 Arnaud Charlet <charlet@adacore.com>
* lib-xref.ads: Fix typo in subprogram reference definition.
From-SVN: r139487
Robert Dewar [Fri, 22 Aug 2008 15:45:29 +0000 (17:45 +0200)]
s-sopco3.adb: Minor code fix to avoid warning
2008-08-22 Robert Dewar <dewar@adacore.com>
* s-sopco3.adb: Minor code fix to avoid warning
From-SVN: r139486
Arnaud Charlet [Fri, 22 Aug 2008 15:07:34 +0000 (17:07 +0200)]
checks.adb (Determine_Range): Deal with values that might be invalid
2008-08-22 Robert Dewar <dewar@adacore.com>
* checks.adb (Determine_Range): Deal with values that might be invalid
* opt.adb, opt.ads (Assume_No_Invalid_Values[_Config]): New configuration
switches.
* par-prag.adb: Dummy entry for pragma Assume_No_Invalid_Values
* sem_prag.adb: Implement pragma Assume_No_Default_Values
* snames.adb, snames.ads, snames.h:
Add entries for pragma Assume_No_Invalid_Values
* switch-c.adb: Add processing for -gnatB switch
* usage.adb: Add entry for flag -gnatB (no bad invalid values)
From-SVN: r139484
Javier Miranda [Fri, 22 Aug 2008 15:07:18 +0000 (17:07 +0200)]
exp_ch3.adb (Build_Init_Statements): Transfer to the body of the init procedure all the expanded code associated...
2008-08-22 Javier Miranda <miranda@adacore.com>
* exp_ch3.adb (Build_Init_Statements): Transfer to the body of the
init procedure all the expanded code associated with the spec of
task types and protected types.
From-SVN: r139483
Arnaud Charlet [Fri, 22 Aug 2008 14:56:55 +0000 (16:56 +0200)]
opt.ads: Minor code reorganization (put entries in alpha order)
2008-08-22 Robert Dewar <dewar@adacore.com>
* opt.ads: Minor code reorganization (put entries in alpha order)
From-SVN: r139481
Gary Dismukes [Fri, 22 Aug 2008 14:56:32 +0000 (16:56 +0200)]
sem_util.adb (Has_Preelaborable_Initialization): Revise checking of private types to allow for types derived from a private type...
2008-08-22 Gary Dismukes <dismukes@adacore.com>
* sem_util.adb (Has_Preelaborable_Initialization): Revise checking of
private types to allow for types derived from a private type with
preelaborable initialization, but return False for a private extension
(unless it has the pragma).
From-SVN: r139480
Gary Dismukes [Fri, 22 Aug 2008 14:56:20 +0000 (16:56 +0200)]
exp_aggr.adb (Static_Array_Aggregate): Call Analyze_And_Resolve on the component expression copies rather than...
2008-08-22 Gary Dismukes <dismukes@adacore.com>
* exp_aggr.adb (Static_Array_Aggregate): Call Analyze_And_Resolve on the
component expression copies rather than directly setting Etype and
Is_Static_Expression.
From-SVN: r139479
Javier Miranda [Fri, 22 Aug 2008 14:55:14 +0000 (16:55 +0200)]
exp_ch3.adb: Revert previous patch.
2008-08-22 Javier Miranda <miranda@adacore.com>
* exp_ch3.adb: Revert previous patch.
From-SVN: r139478
Arnaud Charlet [Fri, 22 Aug 2008 14:38:14 +0000 (16:38 +0200)]
exp_ch3.adb (Build_Init_Statements): Transfer to the body of the init procedure all the expanded code associated...
2008-08-22 Javier Miranda <miranda@adacore.com>
* exp_ch3.adb (Build_Init_Statements): Transfer to the body of the
init procedure all the expanded code associated with the spec of
task types and protected types.
From-SVN: r139477
Pascal Obry [Fri, 22 Aug 2008 14:37:57 +0000 (16:37 +0200)]
initialize.c, adaint.c: Use Lock_Task and Unlock_Task for non-blocking spawn.
2008-08-22 Pascal Obry <obry@adacore.com>
* initialize.c, adaint.c: Use Lock_Task and Unlock_Task for non-blocking
spawn.
From-SVN: r139476
Uros Bizjak [Fri, 22 Aug 2008 13:58:52 +0000 (15:58 +0200)]
re PR target/37184 (ice in ix86_match_ccmode)
PR target/37184
* config/i386/i386.c (ix86_match_ccmode): Handle CCAmode,
CCCmode, CCOmode and CCSmode destination modes.
PR target/37191
* config/i386/mmx.md (*vec_extractv2sf_0): Avoid combining registers
from different units in a single alternative.
(*vec_extractv2sf_1): Ditto.
(*vec_extractv2si_0): Ditto.
(*vec_extractv2si_1): Ditto.
* config/i386/sse.md (sse2_storehpd): Ditto.
(sse2_storelpd): Ditto.
(sse2_loadhpd): Ditto.
(sse2_loadlpd): Ditto.
PR target/37197
* config/i386/i386.md (clzsi2_abm): Fix operand 1 constraints.
(popcountsi2): Ditto.
(clzdi2_abm): Ditto.
(popcountdi2): Ditto.
(clzhi2_abm): Ditto.
(popcounthi2): Ditto.
testsuite/ChangeLog:
PR target/37184
* gcc.target/i386/pr37184.c: New test.
PR target/37191
* gcc.target/i386/pr37191.c: New test.
PR target/37197
* gcc.target/i386/pr37197.c: New test.
From-SVN: r139471
Geert Bosch [Fri, 22 Aug 2008 13:29:10 +0000 (13:29 +0000)]
trans.c: Define FP_ARITH_MAY_WIDEN
2008-08-22 Geert Bosch <bosch@adacore.com>
* gcc-interface/trans.c: Define FP_ARITH_MAY_WIDEN
(convert_with_check): Only use longest_float_type if FP_ARITH_MAY_WIDEN is 0
From-SVN: r139468
Arnaud Charlet [Fri, 22 Aug 2008 13:27:35 +0000 (15:27 +0200)]
2008-08-22 Robert Dewar <dewar@adacore.com>
* checks.adb:
(In_Subrange_Of): New calling sequence
(Determine_Range): Prepare for new processing using base type
* exp_ch4.adb:
(Compile_Time_Compare): Use new calling sequence
* exp_ch5.adb:
(Compile_Time_Compare): Use new calling sequence
* sem_eval.adb:
(Compile_Time_Compare): New calling sequence allows dealing with
invalid values.
(In_Subrange_Of): Ditto
* sem_eval.ads:
(Compile_Time_Compare): New calling sequence allows dealing with
invalid values.
(In_Subrange_Of): Ditto
From-SVN: r139467
Pascal Obry [Fri, 22 Aug 2008 13:26:38 +0000 (15:26 +0200)]
adaint.c: Fix possible race condition on win32_wait().
2008-08-22 Pascal Obry <obry@adacore.com>
* adaint.c: Fix possible race condition on win32_wait().
From-SVN: r139466
Ed Schonberg [Fri, 22 Aug 2008 13:26:28 +0000 (15:26 +0200)]
2008-08-22 Ed Schonberg <schonberg@adacore.com>
* exp_tss.adb:
(Base_Init_Proc): For a protected subtype, use the base type of the
corresponding record to locate the propoer initialization procedure.
From-SVN: r139465
Robert Dewar [Fri, 22 Aug 2008 13:26:19 +0000 (15:26 +0200)]
sem_ch5.adb (One_Bound): Fix latent bug involving secondary stack
2008-08-22 Robert Dewar <dewar@adacore.com>
* sem_ch5.adb (One_Bound): Fix latent bug involving secondary stack
From-SVN: r139464
Vincent Celier [Fri, 22 Aug 2008 13:26:09 +0000 (15:26 +0200)]
prj.ads: Minor comment update
2008-08-22 Vincent Celier <celier@adacore.com>
* prj.ads: Minor comment update
From-SVN: r139463
Robert Dewar [Fri, 22 Aug 2008 13:26:00 +0000 (15:26 +0200)]
exp_dist.adb: Minor reformatting
2008-08-22 Robert Dewar <dewar@adacore.com>
* exp_dist.adb: Minor reformatting
From-SVN: r139462
Robert Dewar [Fri, 22 Aug 2008 13:25:50 +0000 (15:25 +0200)]
exp_ch7.ads: Put routines in proper alpha order
2008-08-22 Robert Dewar <dewar@adacore.com>
* exp_ch7.ads: Put routines in proper alpha order
From-SVN: r139461
Robert Dewar [Fri, 22 Aug 2008 13:25:41 +0000 (15:25 +0200)]
exp_ch7.adb: Minor reformatting
2008-08-22 Robert Dewar <dewar@adacore.com>
* exp_ch7.adb: Minor reformatting
From-SVN: r139460
Robert Dewar [Fri, 22 Aug 2008 13:25:29 +0000 (15:25 +0200)]
exp_ch6.adb: Minor reformatting
2008-08-22 Robert Dewar <dewar@adacore.com>
* exp_ch6.adb: Minor reformatting
From-SVN: r139459
Bob Duff [Fri, 22 Aug 2008 13:25:19 +0000 (15:25 +0200)]
exp_ch6.ads: Remove pragma Precondition, since it breaks some builds.
2008-08-22 Bob Duff <duff@adacore.com>
* exp_ch6.ads: Remove pragma Precondition, since it breaks some builds.
From-SVN: r139458
Ed Schonberg [Fri, 22 Aug 2008 13:25:08 +0000 (15:25 +0200)]
sem_ch8.adb (Use_One_Type): Do not emit warning message about redundant use_type_clause in an instance.
2008-08-22 Ed Schonberg <schonberg@adacore.com>
* sem_ch8.adb (Use_One_Type): Do not emit warning message about redundant
use_type_clause in an instance.
From-SVN: r139457
Doug Rupp [Fri, 22 Aug 2008 13:24:49 +0000 (15:24 +0200)]
bindgen.adb [VMS] (Gen_Adainit_Ada, [...]): Import and call __gnat_set_features.
2008-08-22 Doug Rupp <rupp@adacore.com>
* bindgen.adb [VMS] (Gen_Adainit_Ada, Gen_Adainit_C): Import and call
__gnat_set_features.
* init.c
(__gnat_set_features): New function.
(__gnat_features_set): New tracking variable.
(__gl_no_malloc_64): New feature global variable
From-SVN: r139456
Bob Duff [Fri, 22 Aug 2008 12:59:45 +0000 (12:59 +0000)]
exp_ch5.adb, [...]: Rename...
2008-08-22 Bob Duff <duff@adacore.com>
* exp_ch5.adb, exp_ch7.adb, exp_ch7.ads, exp_util.adb, freeze.adb,
exp_ch4.adb, exp_ch6.ads, exp_ch6.adb, sem_ch6.adb, exp_aggr.adb,
exp_intr.adb, exp_ch3.adb: Rename:
Exp_Ch7.Controlled_Type => Needs_Finalization
Exp_Ch7.CW_Or_Controlled_Type => CW_Or_Has_Controlled_Part
Exp_Ch5.Expand_N_Extended_Return_Statement.Controlled_Type =>
Has_Controlled_Parts
(Has_Some_Controlled_Component): Fix bug in array case.
From-SVN: r139452
Richard Guenther [Fri, 22 Aug 2008 12:43:49 +0000 (12:43 +0000)]
re PR middle-end/36548 (remainder gives the wrong result for wrapping case with unsigned types)
2008-08-22 Richard Guenther <rguenther@suse.de>
PR middle-end/36548
PR middle-end/37125
* fold-const.c (extract_muldiv_1): Optimize (X * C1) % C2 only
if the multiplication does not overflow.
* gcc.c-torture/execute/pr37125.c: New testcase.
From-SVN: r139450
Arnaud Charlet [Fri, 22 Aug 2008 12:42:17 +0000 (14:42 +0200)]
exp_ch6.ads: Minor comment fix
2008-08-22 Bob Duff <duff@adacore.com>
* exp_ch6.ads: Minor comment fix
From-SVN: r139449
Bob Duff [Fri, 22 Aug 2008 12:41:42 +0000 (14:41 +0200)]
exp_ch7.adb: Minor comment fix
2008-08-22 Bob Duff <duff@adacore.com>
* exp_ch7.adb: Minor comment fix
From-SVN: r139448
Ed Schonberg [Fri, 22 Aug 2008 12:41:30 +0000 (14:41 +0200)]
exp_ch5.adb (Expand_Simple_Function_Return): If secondary stack is involved and the return type is class-wide...
2008-08-22 Ed Schonberg <schonberg@adacore.com>
* exp_ch5.adb (Expand_Simple_Function_Return): If secondary stack is
involved and the return type is class-wide, use the type of the expression
for the generated access type. Suppress useless discriminant checks on the
allocator.
From-SVN: r139447
Eric Botcazou [Fri, 22 Aug 2008 12:41:18 +0000 (14:41 +0200)]
init.c: adjust EH support code on Alpha/Tru64 as well.
2008-08-22 Eric Botcazou <ebotcazou@adacore.com>
* init.c: adjust EH support code on Alpha/Tru64 as well.
* raise-gcc.c: Add back a couple of comments.
From-SVN: r139446
Kevin Pouget [Fri, 22 Aug 2008 12:41:03 +0000 (14:41 +0200)]
s-shasto.ads, [...]: Move Shared_Var_ROpen...
2008-08-22 Kevin Pouget <pouget@adacore.com>
* s-shasto.ads, s-shasto.adb: Move Shared_Var_ROpen, Shared_Var_WOpen and
Shared_Var_Close procedure specifications from package spec to package body.
* rtsfind.ads: Remove RE_Shared_Var_Close, RE_Shared_Var_ROpen,
RE_Shared_Var_WOpen entries.
* exp_dist.adb: Update RE_Any_Content_Ptr to RE_Any_Container_Ptr in
Build_To_Any_Call, Build_TypeCode_Call and Build_From_Any_Call procedures.
From-SVN: r139445
Robert Dewar [Fri, 22 Aug 2008 12:40:43 +0000 (14:40 +0200)]
sem_ch8.adb: Minor reformatting
2008-08-22 Robert Dewar <dewar@adacore.com>
* sem_ch8.adb: Minor reformatting
From-SVN: r139444
Arnaud Charlet [Fri, 22 Aug 2008 12:13:14 +0000 (14:13 +0200)]
2008-08-22 Robert Dewar <dewar@adacore.com>
* exp_attr.adb:
(Expand_N_Attribute_Reference): No validity checking on OUT parameter of
Read or Input attribute.
From-SVN: r139443
Gary Dismukes [Fri, 22 Aug 2008 12:12:04 +0000 (14:12 +0200)]
exp_aggr.adb (Static_Array_Aggregate): When a static array aggregate with a range is transformed into a positional...
2008-08-22 Gary Dismukes <dismukes@adacore.com>
* exp_aggr.adb (Static_Array_Aggregate): When a static array aggregate
with a range is transformed into a positional aggregate, any copied
component literals should be marked Is_Static_Expression.
* sem_eval.adb (Compile_Time_Known_Value): Don't treat null literals as
not being known at at compile time when Configurable_Run_Time_Mode is
true.
From-SVN: r139442
Eric Botcazou [Fri, 22 Aug 2008 12:11:31 +0000 (14:11 +0200)]
init.c (__gnat_adjust_context_for_raise): Delete for AIX, HP-UX, Solaris, FreeBSD, VxWorks and PowerPC/Linux.
2008-08-22 Eric Botcazou <ebotcazou@adacore.com>
* init.c (__gnat_adjust_context_for_raise): Delete for AIX, HP-UX,
Solaris, FreeBSD, VxWorks and PowerPC/Linux. For x86{-64}/Linux,
do not adjust the PC anymore.
(__gnat_error_handler): Do not call __gnat_adjust_context_for_raise
on AIX, HP-UX, Solaris, FreeBSD and VxWorks.
* raise-gcc.c (get_call_site_action_for): Use _Unwind_GetIPInfo
instead of _Unwind_GetIP.
From-SVN: r139441
Sergey Rybin [Fri, 22 Aug 2008 12:11:03 +0000 (14:11 +0200)]
gnat_ugn.texi: Change the description of gnatcheck default rule settings.
2008-08-22 Sergey Rybin <rybin@adacore.com>
* gnat_ugn.texi: Change the description of gnatcheck default rule
settings.
From-SVN: r139440
Thomas Quinot [Fri, 22 Aug 2008 12:10:38 +0000 (14:10 +0200)]
sem_ch8.adb: Minor reformatting Minor code reorganization (introduce subprogram to factor...
2008-08-22 Thomas Quinot <quinot@adacore.com>
* sem_ch8.adb: Minor reformatting
Minor code reorganization (introduce subprogram to factor duplicated
code).
From-SVN: r139439
Daniel Kraft [Fri, 22 Aug 2008 10:53:40 +0000 (12:53 +0200)]
gfortran.h (in_prefix): Removed from this header.
2008-08-22 Daniel Kraft <d@domob.eu>
* gfortran.h (in_prefix): Removed from this header.
* match.h (gfc_matching_prefix): Moved and renamed from `in_prefix'.
* decl.c (in_prefix): Removed from here.
(gfc_match_prefix): Use new name of `gfc_matching_prefix'.
* symbol.c (gfc_check_symbol_typed): Ditto.
* expr.c (check_typed_ns): New helper variable.
(expr_check_typed_help): New helper method.
(gfc_expr_check_typed): Rewrote to use gfc_traverse_expr to do the
work, fixing a minor problem.
* match.c (gfc_matching_prefix): New variable.
From-SVN: r139435
Arnaud Charlet [Fri, 22 Aug 2008 09:03:53 +0000 (11:03 +0200)]
exp_attr.adb (Expand_N_Attribute_Reference): In case of access attributes add missing support to handle designated types...
2008-08-22 Javier Miranda <miranda@adacore.com>
* exp_attr.adb (Expand_N_Attribute_Reference): In case of access
attributes add missing support to handle designated types that come
from the limited view.
* exp_disp.adb (Expand_Interface_Conversion): Remove wrong assertion.
From-SVN: r139432
Sergey Rybin [Fri, 22 Aug 2008 09:03:30 +0000 (11:03 +0200)]
vms_data.ads: Add entry for new gnatcheck -mNNN option
2008-08-22 Sergey Rybin <rybin@adacore.com>
* vms_data.ads: Add entry for new gnatcheck -mNNN option
* gnat_ugn.texi: Add description for gnatcheck option '-m'
From-SVN: r139431
Ed Schonberg [Fri, 22 Aug 2008 09:03:16 +0000 (11:03 +0200)]
sem_ch8.adb (Use_One_Type): when checking which of two use_type clauses in related units is redundant...
2008-08-22 Ed Schonberg <schonberg@adacore.com>
* sem_ch8.adb (Use_One_Type): when checking which of two use_type
clauses in related units is redundant, if one of the units is a package
instantiation, use its instance_spec to determine which unit is the
ancestor of the other.
From-SVN: r139430
Arnaud Charlet [Fri, 22 Aug 2008 08:54:46 +0000 (10:54 +0200)]
make.adb (Check.File_Not_A_Source_Of): New Boolean function
2008-08-22 Vincent Celier <celier@adacore.com>
* make.adb (Check.File_Not_A_Source_Of): New Boolean function
(Check): Check if the file names registered in the ALI file for the
spec, the body and each of the subunits are the ones expected.
From-SVN: r139429
Robert Dewar [Fri, 22 Aug 2008 08:54:14 +0000 (10:54 +0200)]
g-catiio.adb: Code cleanup.
2008-08-22 Robert Dewar <dewar@adacore.com>
* g-catiio.adb: Code cleanup.
From-SVN: r139428
Sergey Rybin [Fri, 22 Aug 2008 08:54:05 +0000 (10:54 +0200)]
gnat_ugn.texi: Update the gnatcheck subsection for metric rules acoording to the latest...
2008-08-22 Sergey Rybin <rybin@adacore.com>
* gnat_ugn.texi: Update the gnatcheck subsection for metric rules
acoording to the latest changes in the metric rule interface
From-SVN: r139427
Nathan Sidwell [Fri, 22 Aug 2008 08:51:32 +0000 (08:51 +0000)]
* c-ppoutput.c (init_pp_output): Initialize src_line to 1.
From-SVN: r139426
Daniel Kraft [Fri, 22 Aug 2008 07:13:25 +0000 (09:13 +0200)]
re PR fortran/32095 (Accepts invalid character(len(a)),dimension(1) :: a)
2008-08-22 Daniel Kraft <d@domob.eu>
PR fortran/32095
PR fortran/34228
* gfortran.h (in_prefix): New global.
(gfc_check_symbol_typed), (gfc_check_expr_typed): New methods.
* array.c (match_array_element_spec): Check that bounds-expressions
don't have symbols not-yet-typed in them.
* decl.c (var_element): Check that variable used is already typed.
(char_len_param_value): Check that expression does not contain
not-yet-typed symbols.
(in_prefix): New global.
(gfc_match_prefix): Record using `in_prefix' if we're at the moment
parsing a prefix or not.
* expr.c (gfc_expr_check_typed): New method.
* parse.c (verify_st_order): New argument to disable error output.
(check_function_result_typed): New helper method.
(parse_spec): Check that the function-result declaration, if given in
a prefix, contains no not-yet-typed symbols when the IMPLICIT rules are
parsed.
* symbol.c (gfc_check_symbol_typed): Check that a symbol already has
a type associated to it, otherwise use the IMPLICIT rules or signal
an error.
2008-08-22 Daniel Kraft <d@domob.eu>
PR fortran/32095
PR fortran/34228
* gfortran.dg/used_before_typed_1.f90: New test.
* gfortran.dg/used_before_typed_2.f90: New test.
* gfortran.dg/used_before_typed_3.f90: New test.
* gfortran.dg/array_constructor_26.f03: Add -std=gnu to not enable
legacy-behaviour for the new check.
* gfortran.dg/array_constructor_27.f03: Ditto.
* gfortran.dg/blockdata_4.f90: Ditto.
* gfortran.dg/bound_2.f90: Reordered declarations to satisfy the check.
* gfortran.dg/result_in_spec_1.f90: Ditto.
* gfortran.dg/argument_checking_7.f90: Adapted expected error messages.
From-SVN: r139425
GCC Administrator [Fri, 22 Aug 2008 00:16:37 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r139421
Richard Henderson [Thu, 21 Aug 2008 19:31:02 +0000 (12:31 -0700)]
configure.ac (HAVE_GAS_CFI_PERSONALITY_DIRECTIVE): Remove spurrious comma from test.
* configure.ac (HAVE_GAS_CFI_PERSONALITY_DIRECTIVE): Remove
spurrious comma from test.
* configure: Rebuild.
From-SVN: r139408
Manuel López-Ibáñez [Thu, 21 Aug 2008 19:05:46 +0000 (19:05 +0000)]
re PR c/30457 (Please warn about va_start(ap, invalid))
2008-08-21 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR 30457
* builtins.c (fold_builtin_next_arg): Add warning about undefined
behaviour.
testsuite/
* gcc.dg/pr30457.c: New.
From-SVN: r139406
Aldy Hernandez [Thu, 21 Aug 2008 17:50:01 +0000 (17:50 +0000)]
c-tree.h (grokfield): New argument.
* c-tree.h (grokfield): New argument.
* c-decl.c (grokfield): Handle new location argument.
* c-parser.c (c_parser_struct_declaration): Pass location to
grokfield.
testsuite/
* gcc.dg/
20011008-1.c: Test column.
* gcc.dg/
20080820.c: New.
* gcc.dg/fltconst-1.c: Test column.
* gcc.dg/cpp/cpp.exp: Add -fno-show-column.
* gcc.dg/cpp/trad/trad.exp: Same.
* lib/gcc.exp (gcc_target_compile): Remove -fno-show-column.
* lib/gcc-dg.exp (process-message): Handle columns.
From-SVN: r139403
Sebastian Redl [Thu, 21 Aug 2008 17:37:23 +0000 (19:37 +0200)]
eh_ptr.cc (__gxx_dependent_exception_cleanup): Call __cxa_free_dependent_exception.
2008-08-21 Sebastian Redl <sebastian.redl@getdesigned.at>
* libsupc++/eh_ptr.cc (__gxx_dependent_exception_cleanup): Call
__cxa_free_dependent_exception.
From-SVN: r139402
Joseph Myers [Thu, 21 Aug 2008 16:32:38 +0000 (17:32 +0100)]
anchor1.C (foo): Return the return value of ycf->ascent.
* g++.dg/opt/anchor1.C (foo): Return the return value of
ycf->ascent.
From-SVN: r139399
Richard Guenther [Thu, 21 Aug 2008 16:15:08 +0000 (16:15 +0000)]
tree-ssa-ccp.c (ccp_fold): Fold VIEW_CONVERT_EXPRs of constants.
2008-08-21 Richard Guenther <rguenther@suse.de>
* tree-ssa-ccp.c (ccp_fold): Fold VIEW_CONVERT_EXPRs of constants.
* gcc.dg/vect/vect-fold-1.c: Scan ccp1 dump instead of dom1.
From-SVN: r139398
David Daney [Thu, 21 Aug 2008 16:08:26 +0000 (16:08 +0000)]
class.c (make_class_data): Don't add field_index when flag_reduced_reflection set.
2008-08-21 David Daney <ddaney@avtrex.com>
* class.c (make_class_data): Don't add field_index when
flag_reduced_reflection set.
From-SVN: r139397
Nathan Froyd [Thu, 21 Aug 2008 15:45:37 +0000 (15:45 +0000)]
Fix ChangeLog typo
From-SVN: r139394
Nathan Froyd [Thu, 21 Aug 2008 15:37:05 +0000 (15:37 +0000)]
libgomp.exp (libgomp_init): Only set things that depend on blddir if blddir exists.
* testsuite/libgomp.exp (libgomp_init): Only set things that
depend on blddir if blddir exists.
(libgomp_target_compile): Likewise.
* testsuite/libgomp.c++/c++.exp: Likewise.
* testsuite/libgomp.fortran/fortran.exp: Likewise.
From-SVN: r139393
Jan Hubicka [Thu, 21 Aug 2008 15:26:59 +0000 (17:26 +0200)]
cgraph.c (first_cgraph_function_insertion_hook): New variable.
* cgraph.c (first_cgraph_function_insertion_hook): New variable.
(cgraph_add_function_insertion_hook, cgraph_remove_function_insertion_hook,
cgraph_call_function_insertion_hooks): New functions.
* cgraph.h (cgraph_add_function_insertion_hook, cgraph_remove_function_insertion_hook,
cgraph_call_function_insertion_hooks): Declare.
* ipa-reference.c (function_insertion_hook_holder): New variable.
(check_operand, look_for_address_of): When checking late, do not care
about module bitmaps.
(add_new_function): New function.
(generate_summary): Register hooks; zero module bitmaps.
(propagate): Unregister hooks.
* ipa-pure-const.c (function_insertion_hook_holder): New variable.
(add_new_function): New function.
(generate_summary): Register hook.
(propagate): Remove hook.
* ipa-cp.c (ipcp_need_redirect_p): Fix to not be constant 0.
* tree-pass.h (pass_ipa_cp): Make ipa_opt_pass.
* ipa-cp.c (ipcp_update_cloned_node): New function.
(build_const_val): Handle functions correctly; bring type logic
into sync with tree-inline.c
(ipcp_init_stage): Take care of computing stuff needed by
indirect inlining; update clones.
(ipcp_generate_summary): Break out of ipcp_driver.
(ipcp_driver): Do only execution and transformation.
(pass_ipa_cp): Make IPA_PASS.
* tree-ssa-ccp.c (fold_stmt_r): Check type before trying to fold
offset to address.
* ipa-inline.c (inline_indirect_intraprocedural_analysis): When doing
ipcp, some info is already available.
* ipa-prop.c (ipa_count_arguments): Grow edge lists as needed.
* tree-inline.c (remap_ssa_name): Unshare expression.
From-SVN: r139389
Richard Guenther [Thu, 21 Aug 2008 15:18:58 +0000 (15:18 +0000)]
tree-ssa-pre.c (insert_into_preds_of_block): Before inserting a PHI ask VN if it is already available.
2008-08-21 Richard Guenther <rguenther@suse.de>
* tree-ssa-pre.c (insert_into_preds_of_block): Before inserting
a PHI ask VN if it is already available.
* tree-ssa-sccvn.h (vn_phi_lookup): Declare.
* tree-ssa-sccvn.c (vn_phi_lookup): Export.
From-SVN: r139388
Richard Guenther [Thu, 21 Aug 2008 13:50:30 +0000 (13:50 +0000)]
re PR middle-end/36817 (internal compiler error: in compare_values_warnv)
2008-08-21 Richard Guenther <rguenther@suse.de>
PR middle-end/36817
* tree-chrec.c (chrec_apply): Always call chrec_fold_plus which
makes sure to produce a result of the correct type.
* gcc.c-torture/compile/pr36817.c: New testcase.
From-SVN: r139385
Jan Hubicka [Thu, 21 Aug 2008 12:39:35 +0000 (14:39 +0200)]
Backport from LTO branch:
2008-05-05 Kenneth Zadeck <zadeck@naturalbridge.com>
Jan Hubicka <jh@suse.cz>
* ipa-pure-const.c
(init_state, finish_state, set_function_state, generate_summary):
New functions.
(scan_stmt): Renamed from scan_function. Changed to keep state in
local static vars rather than cgraph aux field.
(propagate): Renamed from static_execute. Changed to keep state in
local static vars rather than cgraph aux field.
(pass_ipa_pure_const): Changed from SIMPLE_IPA_PASS to IPA_PASS.
* tree-pass.h (pass_ipa_pure_const): Turn into IPA_PASS.
2008-07-15 Kenneth Zadeck <zadeck@naturalbridge.com>
* tree-pass.h (pass_ipa_reference): Make into ipa_opt_pass.
* ipa-reference.c (init_function_info, generate_summary,
propagate): New functions.
(analyze_function): Call init_function_info.
(static_execute): Stripped into generate_summary and propagate.
(pass_ipa_reference): Made into ipa_opt_pass.
From-SVN: r139378
Aaron W. LaFramboise [Thu, 21 Aug 2008 11:58:40 +0000 (05:58 -0600)]
Makefile.am: Add -no-undefined
2008-08-21 Aaron W. LaFramboise <aaronavay62@aaronwl.com>
* Makefile.am: Add -no-undefined
* Makefile.in: Regenerate.
From-SVN: r139377
Richard Guenther [Thu, 21 Aug 2008 11:31:57 +0000 (11:31 +0000)]
ssa-fre-13.c: Remove XFAIL.
2008-08-21 Richard Guenther <rguenther@suse.de>
* gcc.dg/tree-ssa/ssa-fre-13.c: Remove XFAIL.
* gcc.dg/tree-ssa/ssa-fre-14.c: Likewise.
* gcc.dg/tree-ssa/ssa-fre-17.c: Likewise.
* gcc.dg/tree-ssa/data-dep-1.c: Likewise.
* gcc.dg/tree-ssa/ltrans-3.c: Likewise.
From-SVN: r139376
Richard Guenther [Thu, 21 Aug 2008 11:25:28 +0000 (11:25 +0000)]
re PR tree-optimization/37181 (FAIL: Divide_1 -O3)
2008-08-21 Richard Guenther <rguenther@suse.de>
PR tree-optimization/37181
* tree-vrp.c (extract_range_from_binary_expr): Check for NULL
folding result.
(extract_range_from_unary_expr): Likewise.
From-SVN: r139375
Richard Guenther [Thu, 21 Aug 2008 11:22:52 +0000 (11:22 +0000)]
re PR testsuite/37182 (Revision 139286 caused gcc.dg/pr17506.c and gcc.dg/uninit-15.c)
2008-08-21 Richard Guenther <rguenther@suse.de>
PR testsuite/37182
* gcc.dg/pr17506.c: Remove duplicate testcase.
* gcc.dg/uninit-15.c: Adjust to allow for both correct
behaviors, one xfailed.
From-SVN: r139374
Manuel López-Ibáñez [Thu, 21 Aug 2008 10:55:13 +0000 (10:55 +0000)]
diagnostic.c (pedwarn_at): Rename as pedwarn.
2008-08-21 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
* diagnostic.c (pedwarn_at): Rename as pedwarn.
(pedwarn): Delete.
* toplev.h (pedwarn_at): Likewise.
* builtins.c: Update all calls to pedwarn.
* c-lex.c: Likewise.
* toplev.c: Likewise.
* c-tree.h: Likewise.
* c-decl.c: Likewise.
* c-errors.c: Likewise.
* c-typeck.c: Likewise.
* c-common.c: Likewise.
* c-parser.c: Likewise.
cp/
* typeck.c: Update all calls to pedwarn.
* decl.c: Likewise.
* call.c: Likewise.
* error.c: Likewise.
* pt.c: Likewise.
* name-lookup.c: Likewise.
* parser.c: Likewise.
fortran/
* f95-lang.c: Update all calls to pedwarn.
From-SVN: r139373
Paolo Carlini [Thu, 21 Aug 2008 01:06:45 +0000 (01:06 +0000)]
char_traits.h (char_traits<char16_t>:: assign(char_type*, size_t, char_type), [...]): For now, just open-code.
2008-08-20 Paolo Carlini <paolo.carlini@oracle.com>
* include/bits/char_traits.h (char_traits<char16_t>::
assign(char_type*, size_t, char_type), char_traits<char32_t>::
assign(char_type*, size_t, char_type)): For now, just open-code.
From-SVN: r139367
Joseph Myers [Thu, 21 Aug 2008 00:17:45 +0000 (01:17 +0100)]
re PR target/31070 (ICE in function_arg_slotno)
PR target/31070
* config/sparc/sparc.c (function_arg_slotno): Handle structure
with MODE_VECTOR_INT mode.
From-SVN: r139363
GCC Administrator [Thu, 21 Aug 2008 00:16:43 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r139361
Manuel López-Ibáñez [Wed, 20 Aug 2008 22:23:45 +0000 (22:23 +0000)]
re PR middle-end/179 (-Wuninitialized missing warning with &var)
2008-08-21 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR middle-end/179
* tree-ssa.c (warn_uninit): Do not warn for variables that can be
initialized outside the current module.
(warn_uninitialized_var): Ignore left-hand side when walking the
trees. Ignore address expressions. Examine VUSE operands in gimple
statements with a variable declaration on the right-hand side.
testsuite/
* gcc.dg/uninit-6.c (make_something): Remove XFAIL.
* gcc.dg/uninit-6-O0.c (make_something): Remove XFAIL.
* gcc.dg/uninit-B.c (baz): Remove XFAIL.
* gcc.dg/uninit-B-2.c: New.
* gcc.dg/uninit-B-O0-2.c: New.
* gcc.dg/uninit-pr19430-O0.c: New.
* gcc.dg/uninit-pr19430.c: New.
* gcc.dg/uninit-pr19430-2.c: New.
From-SVN: r139347
H.J. Lu [Wed, 20 Aug 2008 21:05:15 +0000 (14:05 -0700)]
re PR bootstrap/37155 (Revision 139207 failed to bootstrap on Linux/ia64)
PR bootstrap/37155
Fixed by revision 139338.
From-SVN: r139343
Paolo Carlini [Wed, 20 Aug 2008 19:37:48 +0000 (19:37 +0000)]
2008-08-20 Paolo Carlini <paolo.carlini@oracle.com>
* Fix last ChangeLog entry.
From-SVN: r139341
Paolo Carlini [Wed, 20 Aug 2008 19:29:54 +0000 (19:29 +0000)]
PR libstdc++/33979 (partial)
2008-08-20 Paolo Carlini <paolo.carlini@oracle.com>
PR libstdc++/33979 (partial)
* include/bits/postypes.h (u16streampos, u32streampos): Add.
* include/bits/char_traits.h (char_traits<char16_t>,
char_traits<char32_t>): Add.
* include/bits/stringfwd.h (u16string, u32string): Add.
* include/ext/vstring_fwd.h: Add typedefs for char16_t/char32_t.
* testsuite/21_strings/char_traits/requirements/char32_t/typedefs.cc:
New.
* testsuite/21_strings/char_traits/requirements/
explicit_instantiation/short/1.cc: Likewise.
* testsuite/21_strings/char_traits/requirements/
explicit_instantiation/char32_t/1.cc: Likewise.
* testsuite/21_strings/char_traits/requirements/
explicit_instantiation/wchar_t/1.cc: Likewise.
* testsuite/21_strings/char_traits/requirements/
explicit_instantiation/char16_t/1.cc: Likewise.
* testsuite/21_strings/char_traits/requirements/
explicit_instantiation/char/1.cc: Likewise.
* testsuite/21_strings/char_traits/requirements/char16_t/typedefs.cc:
Likewise.
* testsuite/21_strings/basic_string/requirements/
explicit_instantiation/char32_t/1.cc: Likewise.
* testsuite/21_strings/basic_string/requirements/
explicit_instantiation/wchar_t/1.cc: Likewise.
* testsuite/21_strings/basic_string/requirements/
explicit_instantiation/char16_t/1.cc: Likewise.
* testsuite/21_strings/basic_string/requirements/
explicit_instantiation/char/1.cc: Likewise.
* testsuite/21_strings/headers/string/types_std_c++0x.cc: Likewise.
* testsuite/ext/vstring/requirements/explicit_instantiation/
char32_t/1.cc: Likewise.
* testsuite/ext/vstring/requirements/explicit_instantiation/
char16_t/1.cc: Likewise.
From-SVN: r139339
Richard Sandiford [Wed, 20 Aug 2008 19:07:38 +0000 (19:07 +0000)]
rtlanal.c (subreg_offset_representable_p): Revert last change.
gcc/
* rtlanal.c (subreg_offset_representable_p): Revert last change.
From-SVN: r139338
Manuel López-Ibáñez [Wed, 20 Aug 2008 16:35:21 +0000 (16:35 +0000)]
re PR c++/35158 (g++ does not compile valid C++ for loops with -fopenmp)
2008-08-20 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR c++/35158
cp/
* parser.c (cp_parser_omp_for_loop): Handle parenthesized
initializers.
testsuite/
* g++.dg/gomp/pr35158.C: New.
From-SVN: r139335
Arnaud Charlet [Wed, 20 Aug 2008 16:13:06 +0000 (18:13 +0200)]
raise-gcc.c: Fix formatting nits.
2008-08-20 Eric Botcazou <ebotcazou@adacore.com>
* raise-gcc.c: Fix formatting nits.
From-SVN: r139334
Emmanuel Briot [Wed, 20 Aug 2008 16:12:38 +0000 (18:12 +0200)]
2008-08-20 Emmanuel Briot <briot@adacore.com>
* g-catiio.ads, g-catiio.adb:
(Value): Avoid an unnecessary system call to Clock in most cases.
This call is only needed when only the time is provided in the string,
and ignored in all other cases. This is more efficient.
From-SVN: r139333
Jose Ruiz [Wed, 20 Aug 2008 16:12:17 +0000 (18:12 +0200)]
errno.c (__get_errno, [...]): Transform then into weak symbols so we use the version provided by MaRTE when...
2008-08-20 Jose Ruiz <ruiz@adacore.com>
* errno.c (__get_errno, __set_errno for MaRTE): Transform then into
weak symbols so we use the version provided by MaRTE when available.
From-SVN: r139332
Vincent Celier [Wed, 20 Aug 2008 16:11:55 +0000 (18:11 +0200)]
2008-08-20 Vincent Celier <celier@adacore.com>
* ali.adb:
(Scan_ALI): Use Name_Find, not Name_Enter to get the name of a subunit,
as the name may already have been entered in the table by the Project
Manager.
From-SVN: r139331
Vincent Celier [Wed, 20 Aug 2008 16:11:44 +0000 (18:11 +0200)]
make.adb (Gnatmake): Remove extra space in version line
2008-08-20 Vincent Celier <celier@adacore.com>
* make.adb (Gnatmake): Remove extra space in version line
From-SVN: r139330
Manuel López-Ibáñez [Wed, 20 Aug 2008 16:09:45 +0000 (16:09 +0000)]
re PR c/35701 (Quieten -Wconversion warnings)
2008-08-20 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR 35701
* c-common.c (conversion_warning): Do not warn if applying bit-and
operator to unsigned constant that fits in the target type.
testsuite/
* gcc.dg/pr35701.c: New.
* gcc.dg/Wconversion-real-integer.c: Add more tests.
* gcc.dg/Wconversion-pr34389.c: Update.
* g++.dg/warn/Wconversion-pr34389.C: Update.
From-SVN: r139329
Manuel López-Ibáñez [Wed, 20 Aug 2008 16:05:58 +0000 (16:05 +0000)]
re PR c++/35602 (Bogus warning with -Wsign-conversion)
2008-08-20 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR c++/35602
* c-common.c (conversion_warning): Do not warn for artificial
expressions.
testsuite/
* g++.dg/warn/pr35602.C: New.
From-SVN: r139328
Richard Guenther [Wed, 20 Aug 2008 16:01:59 +0000 (16:01 +0000)]
tree-vrp.c (op_with_constant_singleton_value_range): New function.
2008-08-20 Richard Guenther <rguenther@suse.de>
* tree-vrp.c (op_with_constant_singleton_value_range): New function.
(extract_range_from_binary_expr): Fall back to constant propagation.
(extract_range_from_unary_expr): Likewise.
* gcc.dg/tree-ssa/pr21829.c: Scan optimized and cddce2 dumps
instead of phicprop2. Make sure all is fine after cddce2,
add an XFAILed scan for merging the two remaining ifs.
From-SVN: r139326
Richard Guenther [Wed, 20 Aug 2008 15:58:47 +0000 (15:58 +0000)]
tree-ssa-ccp.c (maybe_fold_stmt_indirect): Do not mess with TREE_THIS_VOLATILE on shared nodes.
2008-08-20 Richard Guenther <rguenther@suse.de>
* tree-ssa-ccp.c (maybe_fold_stmt_indirect): Do not mess
with TREE_THIS_VOLATILE on shared nodes.
(fold_stmt_r): Likewise.
* gcc.c-torture/compile/
20080820-1.c: New testcase.
From-SVN: r139325
Robert Dewar [Wed, 20 Aug 2008 15:51:37 +0000 (15:51 +0000)]
2008-08-20 Robert Dewar <dewar@adacore.com>
* sem_ch13.adb:
(Adjust_Record_For_Reverse_Bit_Order): Do not access First_Bit for
non-existing component clause.
From-SVN: r139323
Robert Dewar [Wed, 20 Aug 2008 15:51:15 +0000 (17:51 +0200)]
stylesw.ads: Minor reformatting
2008-08-20 Robert Dewar <dewar@adacore.com>
* stylesw.ads: Minor reformatting
From-SVN: r139322
Robert Dewar [Wed, 20 Aug 2008 15:51:02 +0000 (17:51 +0200)]
make.adb: Minor reformatting
2008-08-20 Robert Dewar <dewar@adacore.com>
* make.adb: Minor reformatting
From-SVN: r139321
Robert Dewar [Wed, 20 Aug 2008 15:50:52 +0000 (17:50 +0200)]
g-comlin.adb: Minor reformatting
2008-08-20 Robert Dewar <dewar@adacore.com>
* g-comlin.adb: Minor reformatting
From-SVN: r139320
Robert Dewar [Wed, 20 Aug 2008 15:50:40 +0000 (17:50 +0200)]
g-comlin.adb: Minor reformatting
2008-08-20 Robert Dewar <dewar@adacore.com>
* g-comlin.adb: Minor reformatting
From-SVN: r139319
Robert Dewar [Wed, 20 Aug 2008 15:50:31 +0000 (17:50 +0200)]
exp_ch5.adb: Minor reformatting
2008-08-20 Robert Dewar <dewar@adacore.com>
* exp_ch5.adb: Minor reformatting
From-SVN: r139318
Jakub Jelinek [Wed, 20 Aug 2008 15:50:23 +0000 (17:50 +0200)]
re PR c/37171 (Canonical spelling optimization dependency)
PR c/37171
* c-parser.c (c_parser_attributes): For keywords use canonical
spelling for attr_name.
* gcc.dg/pr37171.c: New test.
* g++.dg/ext/attrib34.C: New test.
From-SVN: r139317
Arnaud Charlet [Wed, 20 Aug 2008 15:43:11 +0000 (17:43 +0200)]
styleg-c.ads, [...] (Missing_Overriding): new procedure to implement style check that overriding operations are...
2008-08-20 Ed Schonberg <schonberg@adacore.com>
* styleg-c.ads, styleg-c.adb (Missing_Overriding): new procedure to
implement style check that overriding operations are explicitly marked
at such.
* style.ads (Missing_Overriding): new procedure that provides interface
to previous one.
* stylesw.ads, stylesw.adb: New style switch -gnatyO, to enable check
that the declaration or body of overriding operations carries an
explicit overriding indicator.
* sem_ch8.adb
(Analyze_Subprogram_Renaming): if operation is overriding, check whether
explicit indicator should be present.
* sem_ch6.adb (Verify_Overriding_Indicator,
Check_Overriding_Indicator): If operation is overriding, check whether
declaration and/or body of subprogram should be present
From-SVN: r139316
Vincent Celier [Wed, 20 Aug 2008 15:42:52 +0000 (17:42 +0200)]
make.adb (Gnatmake_Switch_Found): New Boolean global variable
2008-08-20 Vincent Celier <celier@adacore.com>
* make.adb (Gnatmake_Switch_Found): New Boolean global variable
(Switch_May_Be_Passed_To_The_Compiler): New Boolean global variable
(Add_Switches): New Boolean parameter Unknown_Switches_To_The_Compiler
defaulted to True. Fail when Unknown_Switches_To_The_Compiler is False
and a switch is not recognized by gnatmake.
(Gnatmake): Implement new scheme for gnatmake switches and global
compilation switches.
(Switches_Of): Try successively Switches (<file name>),
Switches ("Ada"), Switches (others) and Default_Switches ("Ada").
From-SVN: r139315
Arnaud Charlet [Wed, 20 Aug 2008 15:30:04 +0000 (17:30 +0200)]
g-comlin.adb (For_Each_Simple_Switch): Take care of switches not part of any alias or prefix but having attached...
2008-08-20 Jerome Lambourg <lambourg@adacore.com>
* g-comlin.adb (For_Each_Simple_Switch): Take care of switches not part
of any alias or prefix but having attached parameters (as \"-O2\").
From-SVN: r139314
Gary Dismukes [Wed, 20 Aug 2008 15:29:44 +0000 (17:29 +0200)]
exp_ch3.adb (Build_Array_Init_Proc): Clarify comment related to creating dummy init proc.
2008-08-20 Gary Dismukes <dismukes@adacore.com>
* exp_ch3.adb (Build_Array_Init_Proc): Clarify comment related to
creating dummy init proc.
(Requires_Init_Proc): Return False in the case No_Default_Initialization
is in force and the type does not have associated default
initialization. Move test of Is_Public (with tests of restrictions
No_Initialize_Scalars and No_Default_Initialization) to end, past tests
for default initialization.
From-SVN: r139313
Vincent Celier [Wed, 20 Aug 2008 15:29:33 +0000 (17:29 +0200)]
prj-nmsc.adb (Check_Naming_Schemes): Accept source file names for gprbuild when casing is MixedCase...
2008-08-20 Vincent Celier <celier@adacore.com>
* prj-nmsc.adb (Check_Naming_Schemes): Accept source file names for
gprbuild when casing is MixedCase, whatever the casing of the letters
in the file name.
From-SVN: r139312
Arnaud Charlet [Wed, 20 Aug 2008 15:02:41 +0000 (15:02 +0000)]
* gnat.dg/div_no_warning.adb: New test.
From-SVN: r139311
Arnaud Charlet [Wed, 20 Aug 2008 14:29:06 +0000 (16:29 +0200)]
s-os_lib.ads: Minor reformatting.
2008-08-20 Pascal Obry <obry@adacore.com>
* s-os_lib.ads: Minor reformatting.
From-SVN: r139310
Vincent Celier [Wed, 20 Aug 2008 14:28:36 +0000 (16:28 +0200)]
prj-nmsc.adb (Check_File): An excluded Ada source file may be a source of another project.
2008-08-20 Vincent Celier <celier@adacore.com>
* prj-nmsc.adb (Check_File): An excluded Ada source file may be a
source of another project.
From-SVN: r139309
Thomas Quinot [Wed, 20 Aug 2008 14:28:26 +0000 (16:28 +0200)]
freeze.adb: Minor reformatting
2008-08-20 Thomas Quinot <quinot@adacore.com>
* freeze.adb: Minor reformatting
From-SVN: r139308