platform/upstream/libSkiaSharp.git
11 years agogm/bitmapcopy: create the bitmap in a secondary canvas, since the one in which we...
commit-bot@chromium.org [Wed, 7 Aug 2013 17:03:09 +0000 (17:03 +0000)]
gm/bitmapcopy: create the bitmap in a secondary canvas, since the one in which we draw might be backed by PDF and then accessBitmap does not work.

R=borenet@google.com, jvanverth@google.com

Author: edisonn@google.com

Review URL: https://chromiumcodereview.appspot.com/22353006

git-svn-id: http://skia.googlecode.com/svn/trunk@10614 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIgnore gif_test.gif, take two. Add missing comma.
jvanverth@google.com [Wed, 7 Aug 2013 16:52:05 +0000 (16:52 +0000)]
Ignore gif_test.gif, take two. Add missing comma.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10613 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkCanvas::drawPosTextBounded.
commit-bot@chromium.org [Wed, 7 Aug 2013 16:22:47 +0000 (16:22 +0000)]
Add SkCanvas::drawPosTextBounded.

This allows subclasses which need bounding box information to get it
from the caller if it has already been computed.

BUG=chromium:269080
R=reed@google.com, tomhudson@chromium.org, tomhudson@google.com

Author: jbroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22585002

git-svn-id: http://skia.googlecode.com/svn/trunk@10612 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTry to ignore gif_test.gif in skimage test
jvanverth@google.com [Wed, 7 Aug 2013 16:07:43 +0000 (16:07 +0000)]
Try to ignore gif_test.gif in skimage test

git-svn-id: http://skia.googlecode.com/svn/trunk@10610 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10608 (Add getFamilyNames to SkTypeface) due to compilation failures
robertphillips@google.com [Wed, 7 Aug 2013 15:56:51 +0000 (15:56 +0000)]
Reverting r10608 (Add getFamilyNames to SkTypeface) due to compilation failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10609 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Wed, 7 Aug 2013 15:46:29 +0000 (15:46 +0000)]
Add getFamilyNames to SkTypeface.

Committed: https://code.google.com/p/skia/source/detail?r=10589

Committed: https://code.google.com/p/skia/source/detail?r=10592

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10608 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodownload and rebaseline images using server
zachr@google.com [Wed, 7 Aug 2013 15:43:04 +0000 (15:43 +0000)]
download and rebaseline images using server

BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/20654006

git-svn-id: http://skia.googlecode.com/svn/trunk@10607 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow multiple images for flaky dashing GM on intel/win7/gpu
bsalomon@google.com [Wed, 7 Aug 2013 15:35:35 +0000 (15:35 +0000)]
Allow multiple images for flaky dashing GM on intel/win7/gpu

R=epoger@google.com

Review URL: https://codereview.chromium.org/22327004

git-svn-id: http://skia.googlecode.com/svn/trunk@10606 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoenable SK_FONTHOST_USES_FONTMGR for mac and win. linux fontmgr not ready
reed@google.com [Wed, 7 Aug 2013 15:30:09 +0000 (15:30 +0000)]
enable SK_FONTHOST_USES_FONTMGR for mac and win. linux fontmgr not ready

BUG=

Review URL: https://codereview.chromium.org/22406004

git-svn-id: http://skia.googlecode.com/svn/trunk@10605 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMozilla diabolical clamp case added to gm/gradients.cpp
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:13 +0000 (15:22 +0000)]
Mozilla diabolical clamp case added to gm/gradients.cpp

Added diabolical clamp case.

BUG=
R=reed@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/22484002

git-svn-id: http://skia.googlecode.com/svn/trunk@10604 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove operator== from SkPaint
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:05 +0000 (15:22 +0000)]
Remove operator== from SkPaint

R=mtklein@google.com, reed@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/21949007

git-svn-id: http://skia.googlecode.com/svn/trunk@10603 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "rebaseline gpu dashing on win7"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:26 +0000 (13:34 +0000)]
Revert "rebaseline gpu dashing on win7"

This reverts commit r10577.

git-svn-id: http://skia.googlecode.com/svn/trunk@10602 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add blend optimization helpers and use to convert rect draws to clears."
bsalomon@google.com [Wed, 7 Aug 2013 13:34:14 +0000 (13:34 +0000)]
Revert "Add blend optimization helpers and use to convert rect draws to clears."

This reverts commit r10537.

git-svn-id: http://skia.googlecode.com/svn/trunk@10601 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Sanitizing source files in Housekeeper-Nightly"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:08 +0000 (13:34 +0000)]
Revert "Sanitizing source files in Housekeeper-Nightly"

This reverts commit r10594.

git-svn-id: http://skia.googlecode.com/svn/trunk@10600 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Rebaseline flaky non AA lines on intel/win/gpu"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:01 +0000 (13:34 +0000)]
Revert "Rebaseline flaky non AA lines on intel/win/gpu"

This reverts commit r10566.

git-svn-id: http://skia.googlecode.com/svn/trunk@10599 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: /Pattern color space, uses the matrix of the last content stream, not...
edisonn@google.com [Wed, 7 Aug 2013 11:56:16 +0000 (11:56 +0000)]
pdfviewer: /Pattern color space, uses the matrix of the last content stream, not the global matrix.

Review URL: https://codereview.chromium.org/22460004

git-svn-id: http://skia.googlecode.com/svn/trunk@10595 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 7 Aug 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10594 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWork around broken SkFontMgr_fontconfig.cpp for test.
bungeman@google.com [Wed, 7 Aug 2013 03:17:12 +0000 (03:17 +0000)]
Work around broken SkFontMgr_fontconfig.cpp for test.

git-svn-id: http://skia.googlecode.com/svn/trunk@10593 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Wed, 7 Aug 2013 02:45:25 +0000 (02:45 +0000)]
Add getFamilyNames to SkTypeface.

Committed: https://code.google.com/p/skia/source/detail?r=10589

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10592 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkComposeImageFilter into its own {.h, .cpp} files
commit-bot@chromium.org [Wed, 7 Aug 2013 00:07:51 +0000 (00:07 +0000)]
Move SkComposeImageFilter into its own {.h, .cpp} files

In http://crrev.com/21154002, SkComposeImageFilter will be used
outside of tests. Consequently, this moves SkComposeImageFilter from
SkTestImageFilters.{h, cpp} into its own {.h, .cpp} files.

BUG=181613
R=senorblanco@chromium.org

Author: ajuma@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22438003

git-svn-id: http://skia.googlecode.com/svn/trunk@10591 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10589: Add getFamilyNames to SkTypeface
jvanverth@google.com [Tue, 6 Aug 2013 23:31:44 +0000 (23:31 +0000)]
Reverting r10589: Add getFamilyNames to SkTypeface

git-svn-id: http://skia.googlecode.com/svn/trunk@10590 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Tue, 6 Aug 2013 22:53:04 +0000 (22:53 +0000)]
Add getFamilyNames to SkTypeface.

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10589 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: load image pain settings (like transparency), pass the page number, report...
edisonn@google.com [Tue, 6 Aug 2013 21:48:44 +0000 (21:48 +0000)]
pdfviewer: load image pain settings (like transparency), pass the page number, report failure if at least one render fails, and check that xref section starts with xref keyword.

Review URL: https://codereview.chromium.org/22465006

git-svn-id: http://skia.googlecode.com/svn/trunk@10588 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10583: Upstreaming DropShadowImageFilter into skia, from Blink
jvanverth@google.com [Tue, 6 Aug 2013 21:12:59 +0000 (21:12 +0000)]
Reverting r10583: Upstreaming DropShadowImageFilter into skia, from Blink

git-svn-id: http://skia.googlecode.com/svn/trunk@10587 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRegenerate bitmaps before each draw in tilemodes_npot GM
bsalomon@google.com [Tue, 6 Aug 2013 20:47:52 +0000 (20:47 +0000)]
Regenerate bitmaps before each draw in tilemodes_npot GM

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22415004

git-svn-id: http://skia.googlecode.com/svn/trunk@10586 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-organize Android scripts
borenet@google.com [Tue, 6 Aug 2013 20:32:29 +0000 (20:32 +0000)]
Re-organize Android scripts

Addresses https://code.google.com/p/skia/issues/detail?id=1486

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22411004

git-svn-id: http://skia.googlecode.com/svn/trunk@10585 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange SkPreConfig.h to recognise uppercase PPC/PPC64.
george@mozilla.com [Tue, 6 Aug 2013 20:16:34 +0000 (20:16 +0000)]
Change SkPreConfig.h to recognise uppercase PPC/PPC64.

git-svn-id: http://skia.googlecode.com/svn/trunk@10584 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpstreaming DropShadowImageFilter into skia, from Blink
junov@chromium.org [Tue, 6 Aug 2013 20:01:40 +0000 (20:01 +0000)]
Upstreaming DropShadowImageFilter into skia, from Blink

GM imagefiltersbase will need rebaselining after this change

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/22258005

git-svn-id: http://skia.googlecode.com/svn/trunk@10583 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove invalid expectation.
scroggo@google.com [Tue, 6 Aug 2013 19:35:48 +0000 (19:35 +0000)]
Remove invalid expectation.

Fixes build.

git-svn-id: http://skia.googlecode.com/svn/trunk@10582 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd config option to skimage.
scroggo@google.com [Tue, 6 Aug 2013 18:56:53 +0000 (18:56 +0000)]
Add config option to skimage.

Allows testing 565 and A8, in addition to 8888.

Also makes the preference consistent for each test (in one run).

BUG=skia:1465
R=djsollen@google.com

Review URL: https://codereview.chromium.org/22297007

git-svn-id: http://skia.googlecode.com/svn/trunk@10579 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDo not fail skimage on missing expectations.
scroggo@google.com [Tue, 6 Aug 2013 18:51:30 +0000 (18:51 +0000)]
Do not fail skimage on missing expectations.

This will allow adding new images to test without turning the bots
red.

R=epoger@google.com

Review URL: https://codereview.chromium.org/22301006

git-svn-id: http://skia.googlecode.com/svn/trunk@10578 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline gpu dashing on win7
bsalomon@google.com [Tue, 6 Aug 2013 18:46:56 +0000 (18:46 +0000)]
rebaseline gpu dashing on win7

git-svn-id: http://skia.googlecode.com/svn/trunk@10577 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a default value for SK_OVERRIDE in SkPostConfig.h
george@mozilla.com [Tue, 6 Aug 2013 18:35:00 +0000 (18:35 +0000)]
Add a default value for SK_OVERRIDE in SkPostConfig.h

Review URL: https://chromiumcodereview.appspot.com/22288002

git-svn-id: http://skia.googlecode.com/svn/trunk@10576 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAnnotate SK_COMPILE_ASSERT's typedef as permissibly unused, to fix GCC 4.8 build...
bungeman@google.com [Tue, 6 Aug 2013 18:32:29 +0000 (18:32 +0000)]
Annotate SK_COMPILE_ASSERT's typedef as permissibly unused, to fix GCC 4.8 build warning. Patch originally by dholbert.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22285002

git-svn-id: http://skia.googlecode.com/svn/trunk@10575 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOne last rebaseline to try to get Nexus-10 GMs green.
jvanverth@google.com [Tue, 6 Aug 2013 18:28:25 +0000 (18:28 +0000)]
One last rebaseline to try to get Nexus-10 GMs green.

Unreviewed.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10574 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTweak -mssse3 on Mac a little.
commit-bot@chromium.org [Tue, 6 Aug 2013 18:13:01 +0000 (18:13 +0000)]
Tweak -mssse3 on Mac a little.

Using OTHER_CPLUSPLUSFLAGS instead of OTHER_CFLAGS will append -mssse3 into the
argument list instead of overwriting as the old note warns about.  (So it's
actually there twice now for the files in opts_ssse3, and we can still build if
we remove -mssse3 from common_conditions.gypi.)

We could also just delete this clause entirely given that
common_conditions.gypi sets it anyway.  Which do you think is best?  This code
won't compile unless _someone_ has set -mssse3.  Seems to me the redundancy
helps communicate that and protect against changes in common_conditions.gypi.

BUG=
R=epoger@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/21279005

git-svn-id: http://skia.googlecode.com/svn/trunk@10573 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix mime-type on expectations.
jvanverth@google.com [Tue, 6 Aug 2013 17:30:28 +0000 (17:30 +0000)]
Fix mime-type on expectations.
Rebaseline one DirectWrite GM.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10570 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus-10 GMs... again.
jvanverth@google.com [Tue, 6 Aug 2013 16:34:38 +0000 (16:34 +0000)]
Rebaseline Nexus-10 GMs... again.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10568 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert Accidental commit "patch from issue 20151002"
bsalomon@google.com [Tue, 6 Aug 2013 16:06:14 +0000 (16:06 +0000)]
Revert Accidental commit "patch from issue 20151002"

This reverts commit r10565.

git-svn-id: http://skia.googlecode.com/svn/trunk@10567 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline flaky non AA lines on intel/win/gpu
bsalomon@google.com [Tue, 6 Aug 2013 16:04:42 +0000 (16:04 +0000)]
Rebaseline flaky non AA lines on intel/win/gpu

git-svn-id: http://skia.googlecode.com/svn/trunk@10566 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopatch from issue 20151002
bsalomon@google.com [Tue, 6 Aug 2013 16:04:39 +0000 (16:04 +0000)]
patch from issue 20151002

git-svn-id: http://skia.googlecode.com/svn/trunk@10565 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove toolchain setup into a function in android_setup.sh
borenet@google.com [Tue, 6 Aug 2013 15:42:15 +0000 (15:42 +0000)]
Move toolchain setup into a function in android_setup.sh

Addresses https://code.google.com/p/skia/issues/detail?id=1486

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22339008

git-svn-id: http://skia.googlecode.com/svn/trunk@10563 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd blend optimization helpers and use to convert rect draws to clears.
commit-bot@chromium.org [Tue, 6 Aug 2013 15:07:23 +0000 (15:07 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.

Committed: http://code.google.com/p/skia/source/detail?r=10537

R=robertphillips@google.com, jvanverth@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/21877006

git-svn-id: http://skia.googlecode.com/svn/trunk@10562 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus 10 GMs
jvanverth@google.com [Tue, 6 Aug 2013 14:17:16 +0000 (14:17 +0000)]
Rebaseline Nexus 10 GMs

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10561 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNormalize indents in android_setup.sh
borenet@google.com [Tue, 6 Aug 2013 13:47:54 +0000 (13:47 +0000)]
Normalize indents in android_setup.sh

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22422002

git-svn-id: http://skia.googlecode.com/svn/trunk@10560 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoN7 Performance Trigger rebaselines
robertphillips@google.com [Tue, 6 Aug 2013 12:20:38 +0000 (12:20 +0000)]
N7 Performance Trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10557 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix race condition when locking/unlocking pixels.
djsollen@google.com [Tue, 6 Aug 2013 12:19:38 +0000 (12:19 +0000)]
Fix race condition when locking/unlocking pixels.

R=reed@google.com

Review URL: https://codereview.chromium.org/22235002

git-svn-id: http://skia.googlecode.com/svn/trunk@10556 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUbuntu Performance trigger rebaseline
robertphillips@google.com [Tue, 6 Aug 2013 12:17:53 +0000 (12:17 +0000)]
Ubuntu Performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10555 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 6 Aug 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10554 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoold compiler is dumb
mtklein@google.com [Mon, 5 Aug 2013 23:08:19 +0000 (23:08 +0000)]
old compiler is dumb

BUG=

Review URL: https://codereview.chromium.org/22318002

git-svn-id: http://skia.googlecode.com/svn/trunk@10553 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevise SkTDynamicHash and add unit tests
commit-bot@chromium.org [Mon, 5 Aug 2013 22:31:20 +0000 (22:31 +0000)]
revise SkTDynamicHash and add unit tests
BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22292004

git-svn-id: http://skia.googlecode.com/svn/trunk@10552 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove debug traces
edisonn@google.com [Mon, 5 Aug 2013 22:08:50 +0000 (22:08 +0000)]
pdfviewer: remove debug traces

Review URL: https://codereview.chromium.org/22284004

git-svn-id: http://skia.googlecode.com/svn/trunk@10551 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline imagemagnifier GM for Nexus-4
jvanverth@google.com [Mon, 5 Aug 2013 21:47:24 +0000 (21:47 +0000)]
Rebaseline imagemagnifier GM for Nexus-4

git-svn-id: http://skia.googlecode.com/svn/trunk@10549 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: debug code for crash
edisonn@google.com [Mon, 5 Aug 2013 20:45:40 +0000 (20:45 +0000)]
pdfviewer: debug code for crash

Review URL: https://codereview.chromium.org/22269002

git-svn-id: http://skia.googlecode.com/svn/trunk@10548 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSeparate quad UV calculation from bloat_quad
egdaniel@google.com [Mon, 5 Aug 2013 20:43:12 +0000 (20:43 +0000)]
Separate quad UV calculation from bloat_quad

For GPU hairlines move UV calculation on vertices for quads to its
own function outside of bloat_quad. This is done since conics share
the bloat quad function and don't need to do this calcuation.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22043006

git-svn-id: http://skia.googlecode.com/svn/trunk@10547 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove warning comment from SkImageFilter.
senorblanco@chromium.org [Mon, 5 Aug 2013 20:29:59 +0000 (20:29 +0000)]
Remove warning comment from SkImageFilter.

R=reed@google.com

Review URL: https://codereview.chromium.org/22236002

git-svn-id: http://skia.googlecode.com/svn/trunk@10546 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor sk_memset{16|32}_SSE2 optimization.
commit-bot@chromium.org [Mon, 5 Aug 2013 20:25:57 +0000 (20:25 +0000)]
Minor sk_memset{16|32}_SSE2 optimization.

Using explicitly indexed references allows some compilers to generate more efficient loops. For gcc 4.6.3:

613c18: 83 ea 10 sub $0x10,%edx
613c1b: 66 0f 7f 07 movdqa %xmm0,(%rdi)
613c1f: 66 0f 7f 47 10 movdqa %xmm0,0x10(%rdi)
613c24: 66 0f 7f 47 20 movdqa %xmm0,0x20(%rdi)
613c29: 66 0f 7f 47 30 movdqa %xmm0,0x30(%rdi)
613c2e: 48 83 c7 40 add $0x40,%rdi
613c32: 83 fa 0f cmp $0xf,%edx
613c35: 7f e1 jg 613c18 <_Z16sk_memset32_SSE2Pjji+0x38>

vs. previous:

613c18: 83 ea 10 sub $0x10,%edx
613c1b: 66 0f 7f 07 movdqa %xmm0,(%rdi)
613c1f: 66 0f 7f 47 10 movdqa %xmm0,0x10(%rdi)
613c24: 66 0f 7f 47 20 movdqa %xmm0,0x20(%rdi)
613c29: 48 83 c7 40 add $0x40,%rdi
613c2d: 83 fa 0f cmp $0xf,%edx
613c30: 66 0f 7f 47 f0 movdqa %xmm0,-0x10(%rdi)
613c35: 7f e1 jg 613c18 <_Z16sk_memset32_SSE2Pjji+0x38>

This yields a 0.2% - 1% improvement with the memset micro benchmarks, presumably due to avoiding a stall on the next store after the %rdi increment.

R=reed@google.com, senorblanco@chromium.org

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21703003

git-svn-id: http://skia.googlecode.com/svn/trunk@10545 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGPU Font Cache improvements:
commit-bot@chromium.org [Mon, 5 Aug 2013 19:42:56 +0000 (19:42 +0000)]
GPU Font Cache improvements:
- If a strike has multiple atlases, check all for room for a new glyph
- Mark remaining atlases unused after a purge, then check for an unused
atlas before purging (reduces TextContext flushes and ghosting)
- Hide Atlas management a little better inside AtlasMgr

R=robertphillips@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/21594005

git-svn-id: http://skia.googlecode.com/svn/trunk@10544 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add blend optimization helpers and use to convert rect draws to clears."
bsalomon@google.com [Mon, 5 Aug 2013 18:27:23 +0000 (18:27 +0000)]
Revert "Add blend optimization helpers and use to convert rect draws to clears."

This reverts commit r10537.

git-svn-id: http://skia.googlecode.com/svn/trunk@10542 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: add virtual destructor for SkPdfFont
edisonn@google.com [Mon, 5 Aug 2013 18:18:06 +0000 (18:18 +0000)]
pdfviewer: add virtual destructor for SkPdfFont

Review URL: https://codereview.chromium.org/22239002

git-svn-id: http://skia.googlecode.com/svn/trunk@10541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: fix typo
edisonn@google.com [Mon, 5 Aug 2013 17:59:11 +0000 (17:59 +0000)]
pdfviewer: fix typo

Review URL: https://codereview.chromium.org/22076007

git-svn-id: http://skia.googlecode.com/svn/trunk@10540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: set backdround to transparent, and add an app to chop transparent content...
edisonn@google.com [Mon, 5 Aug 2013 17:26:11 +0000 (17:26 +0000)]
pdfviewer: set backdround to transparent, and add an app to chop transparent content in png files.

Review URL: https://codereview.chromium.org/21981008

git-svn-id: http://skia.googlecode.com/svn/trunk@10538 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd blend optimization helpers and use to convert rect draws to clears.
commit-bot@chromium.org [Mon, 5 Aug 2013 16:55:55 +0000 (16:55 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.

R=robertphillips@google.com, jvanverth@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/21877006

git-svn-id: http://skia.googlecode.com/svn/trunk@10537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded ctm matrix to GPU path
commit-bot@chromium.org [Mon, 5 Aug 2013 16:53:50 +0000 (16:53 +0000)]
Added ctm matrix to GPU path

There should be no changes in behavior caused by this cl, it just adds the ctm matrix to filterImageGPU so that it may be used for scaling on all platforms when it is implemented on the blink side.

BUG=
R=senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22209002

git-svn-id: http://skia.googlecode.com/svn/trunk@10536 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix OverdrawFilter not set on first call to SkDebugCanvas::drawTo()
commit-bot@chromium.org [Mon, 5 Aug 2013 16:31:27 +0000 (16:31 +0000)]
Fix OverdrawFilter not set on first call to SkDebugCanvas::drawTo()

R=robertphillips@google.com

Author: egraether@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21789005

git-svn-id: http://skia.googlecode.com/svn/trunk@10535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject
edisonn@google.com [Mon, 5 Aug 2013 16:23:23 +0000 (16:23 +0000)]
pdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject

Review URL: https://codereview.chromium.org/21738005

git-svn-id: http://skia.googlecode.com/svn/trunk@10534 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable GpuTestPath.
jvanverth@google.com [Mon, 5 Aug 2013 14:50:31 +0000 (14:50 +0000)]
Temporarily disable GpuTestPath.

git-svn-id: http://skia.googlecode.com/svn/trunk@10532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable SkUtilsArm on all ARM platforms and always use NDK compliant NEON detection...
djsollen@google.com [Mon, 5 Aug 2013 13:38:28 +0000 (13:38 +0000)]
Enable SkUtilsArm on all ARM platforms and always use NDK compliant NEON detection on Android.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/22193002

git-svn-id: http://skia.googlecode.com/svn/trunk@10530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoActually flush the path stencil transform when the matrix changes
commit-bot@chromium.org [Mon, 5 Aug 2013 13:30:59 +0000 (13:30 +0000)]
Actually flush the path stencil transform when the matrix changes

Fixes many tests to match the master gm more closely. Examples of fixes:
mixed_xfermodes, strokes_poly, gradients_view_perspective, strokes_round,
... .

Total 58 differing results.

BUG=1479
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22176002

git-svn-id: http://skia.googlecode.com/svn/trunk@10529 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a crash on stroking empty paths with nv_path_rendering enabled
commit-bot@chromium.org [Mon, 5 Aug 2013 13:28:55 +0000 (13:28 +0000)]
Fix a crash on stroking empty paths with nv_path_rendering enabled

Fix the crash by defining that GrPathRenderer::drawPath and
GrPathRenderer::stencilPath are called only with non-empty paths.

Adds a new test "GpuDrawPath" and tests the condition.

BUG=1477
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22173002

git-svn-id: http://skia.googlecode.com/svn/trunk@10528 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid counting verbs twice in SkPath::isEmpty()
commit-bot@chromium.org [Mon, 5 Aug 2013 13:23:13 +0000 (13:23 +0000)]
Avoid counting verbs twice in SkPath::isEmpty()

Remove redundant call to SkPathRef::countVerbs. The intention was
probably to count points. Instead, assert that all two-verb paths
begin with a 'move' and that if the second verb is a 'line', then the
point count is indeed two.

BUG=1478
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22171002

git-svn-id: http://skia.googlecode.com/svn/trunk@10527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn preparation for make Chromium's skia.gyp use pdf.gypi.
commit-bot@chromium.org [Sun, 4 Aug 2013 15:09:23 +0000 (15:09 +0000)]
In preparation for make Chromium's skia.gyp use pdf.gypi.

R=edisonn@google.com, djsollen@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/21952002

git-svn-id: http://skia.googlecode.com/svn/trunk@10526 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoN7 Performance trigger rebaselines
robertphillips@google.com [Sun, 4 Aug 2013 15:00:58 +0000 (15:00 +0000)]
N7 Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10525 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete image-based rebaselining tool; we have switched to checksums
epoger@google.com [Fri, 2 Aug 2013 20:54:46 +0000 (20:54 +0000)]
Delete image-based rebaselining tool; we have switched to checksums

R=borenet@google.com

Review URL: https://codereview.chromium.org/21901004

git-svn-id: http://skia.googlecode.com/svn/trunk@10524 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: implementation of one type of pattern - simple tile patern, colored, with...
edisonn@google.com [Fri, 2 Aug 2013 20:24:48 +0000 (20:24 +0000)]
pdfviewer: implementation of one type of pattern - simple tile patern, colored, with xstep and ystep positive.

Review URL: https://codereview.chromium.org/21919003

git-svn-id: http://skia.googlecode.com/svn/trunk@10523 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocorrectly copy constant coverage from GrPaint to GrDrawState
bsalomon@google.com [Fri, 2 Aug 2013 19:54:28 +0000 (19:54 +0000)]
correctly copy constant coverage from GrPaint to GrDrawState

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/21924006

git-svn-id: http://skia.googlecode.com/svn/trunk@10522 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdds poppler and dependencies to DEPS. This is a pre-CL for 20220002, and getting...
commit-bot@chromium.org [Fri, 2 Aug 2013 19:10:06 +0000 (19:10 +0000)]
Adds poppler and dependencies to DEPS. This is a pre-CL for 20220002, and getting DEPS committed first is necessary to get the trybots to run on the larger CL (since the trybots do 'gclient sync' before patching).

R=vandebo@chromium.org, edisonn@google.com, djsollen@chromium.org, bungeman@chromium.org, djsollen@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21945002

git-svn-id: http://skia.googlecode.com/svn/trunk@10521 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate AJAX live-viewer of expected-vs-actual GM results
epoger@google.com [Fri, 2 Aug 2013 19:08:52 +0000 (19:08 +0000)]
Create AJAX live-viewer of expected-vs-actual GM results

R=zachr@google.com

Review URL: https://codereview.chromium.org/20526007

git-svn-id: http://skia.googlecode.com/svn/trunk@10520 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRestore a default timer to bench_pictures.
scroggo@google.com [Fri, 2 Aug 2013 16:09:10 +0000 (16:09 +0000)]
Restore a default timer to bench_pictures.

https://codereview.chromium.org/19862002 removed the default timer
to display from PictureBenchmark. Restore a default by putting it
in the flag description.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/21567005

git-svn-id: http://skia.googlecode.com/svn/trunk@10516 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix skpdiff viewer bug when using relative paths
zachr@google.com [Fri, 2 Aug 2013 15:54:30 +0000 (15:54 +0000)]
fix skpdiff viewer bug when using relative paths

BUG=skia:1463
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21601002

git-svn-id: http://skia.googlecode.com/svn/trunk@10515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoved duplicate file
sugoi@google.com [Fri, 2 Aug 2013 15:45:41 +0000 (15:45 +0000)]
Removed duplicate file

BUG=

Review URL: https://codereview.chromium.org/21890003

git-svn-id: http://skia.googlecode.com/svn/trunk@10514 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing SkDeferredCanvas::writePixels to trigger appropriate change notifications...
junov@chromium.org [Fri, 2 Aug 2013 15:36:02 +0000 (15:36 +0000)]
Fixing SkDeferredCanvas::writePixels to trigger appropriate change notifications to SkSurface

BUG=crbug.com/256269
TEST=DeferredCanvas unit test, TestDeferredCanvasWritePixelsToSurface
R=reed@google.com

Review URL: https://codereview.chromium.org/20628005

git-svn-id: http://skia.googlecode.com/svn/trunk@10513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd nv_path_rendering entry points to Unix GLInterface
commit-bot@chromium.org [Fri, 2 Aug 2013 15:19:40 +0000 (15:19 +0000)]
Add nv_path_rendering entry points to Unix GLInterface

Add nv_path_rendering entry points to Unix GLInterface.
Also add few other GL entry points that are used by nv_path_rendering
codepaths.

BUG=1468
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/21808003

git-svn-id: http://skia.googlecode.com/svn/trunk@10512 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd remote debugging support for x86 phone
commit-bot@chromium.org [Fri, 2 Aug 2013 15:14:24 +0000 (15:14 +0000)]
add remote debugging support for x86 phone

R=djsollen@google.com, borenet@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/19920003

git-svn-id: http://skia.googlecode.com/svn/trunk@10511 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd fullscreen rect bench
bsalomon@google.com [Fri, 2 Aug 2013 14:39:25 +0000 (14:39 +0000)]
Add fullscreen rect bench

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/21592002

git-svn-id: http://skia.googlecode.com/svn/trunk@10510 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSupport MSAA in the picture debugger
commit-bot@chromium.org [Fri, 2 Aug 2013 13:59:50 +0000 (13:59 +0000)]
Support MSAA in the picture debugger

Add radio buttons for setting the GL sample count to 0 ("off"), 4 or
16.

Change the default mode of the GL widget to MSAA4. Previous behavior
corresponded to "off".

BUG=1459
R=robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/21752002

git-svn-id: http://skia.googlecode.com/svn/trunk@10509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 2 Aug 2013 07:00:59 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10503 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd onRefMatchingStyle to SkFontHost_linux.
bungeman@google.com [Fri, 2 Aug 2013 00:20:34 +0000 (00:20 +0000)]
Add onRefMatchingStyle to SkFontHost_linux.

git-svn-id: http://skia.googlecode.com/svn/trunk@10502 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SkTMin call introduced in 10500 which fails on some platforms.
bungeman@google.com [Thu, 1 Aug 2013 22:48:21 +0000 (22:48 +0000)]
Fix SkTMin call introduced in 10500 which fails on some platforms.

git-svn-id: http://skia.googlecode.com/svn/trunk@10501 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement onGetTableTags and onGetTableData on Windows.
bungeman@google.com [Thu, 1 Aug 2013 22:29:43 +0000 (22:29 +0000)]
Implement onGetTableTags and onGetTableData on Windows.

Implements these and removes default implementation, making the
declaration in SkTypeface pure virtual.

Review URL: https://codereview.chromium.org/20672004

git-svn-id: http://skia.googlecode.com/svn/trunk@10500 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix memory leak in SkPDFResourceDict
commit-bot@chromium.org [Thu, 1 Aug 2013 21:54:26 +0000 (21:54 +0000)]
Fix memory leak in SkPDFResourceDict

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20655004

git-svn-id: http://skia.googlecode.com/svn/trunk@10499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: debug the parameters for snc, and for resolveReference
edisonn@google.com [Thu, 1 Aug 2013 21:20:47 +0000 (21:20 +0000)]
pdfviewer: debug the parameters for snc, and for resolveReference

Review URL: https://codereview.chromium.org/21604003

git-svn-id: http://skia.googlecode.com/svn/trunk@10498 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReintroduce default impls removed in 10495.
bungeman@google.com [Thu, 1 Aug 2013 21:01:28 +0000 (21:01 +0000)]
Reintroduce default impls removed in 10495.

Due to poor placement of overrides in the hierarchy, nacl is failing.

git-svn-id: http://skia.googlecode.com/svn/trunk@10497 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement onGetTableTags and onGetTableData on Windows.
bungeman@google.com [Thu, 1 Aug 2013 20:18:41 +0000 (20:18 +0000)]
Implement onGetTableTags and onGetTableData on Windows.

Implements these and removes default implementation, making the
declaration in SkTypeface pure virtual.

Review URL: https://codereview.chromium.org/20672004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10495 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: finish implementation of SkPdfObject.toString(), and include in debugging...
edisonn@google.com [Thu, 1 Aug 2013 20:06:42 +0000 (20:06 +0000)]
pdfviewer: finish implementation of SkPdfObject.toString(), and include in debugging traces we leave when rendering.

Review URL: https://codereview.chromium.org/20628008

git-svn-id: http://skia.googlecode.com/svn/trunk@10494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Don't call SkGpuDevice::drawVertices from drawPoints when AA is required."
djsollen@google.com [Thu, 1 Aug 2013 18:36:08 +0000 (18:36 +0000)]
Revert "Don't call SkGpuDevice::drawVertices from drawPoints when AA is required."

This reverts commit r10489.

Review URL: https://codereview.chromium.org/21496003

git-svn-id: http://skia.googlecode.com/svn/trunk@10492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew baselines for imagefiltersgraph GM after r10482.
senorblanco@chromium.org [Thu, 1 Aug 2013 18:33:03 +0000 (18:33 +0000)]
New baselines for imagefiltersgraph GM after r10482.

TBR=djsollen
BUG=

Review URL: https://codereview.chromium.org/20938004

git-svn-id: http://skia.googlecode.com/svn/trunk@10491 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded 3-color gradient scraper for detecting symmetrical gradients.
commit-bot@chromium.org [Thu, 1 Aug 2013 17:32:56 +0000 (17:32 +0000)]
Added 3-color gradient scraper for detecting symmetrical gradients.

Made changes to lua to scrape info about 3 color gradients

BUG=
R=reed@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/21571002

git-svn-id: http://skia.googlecode.com/svn/trunk@10490 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't call SkGpuDevice::drawVertices from drawPoints when AA is required.
commit-bot@chromium.org [Thu, 1 Aug 2013 17:30:32 +0000 (17:30 +0000)]
Don't call SkGpuDevice::drawVertices from drawPoints when AA is required.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/12943007

git-svn-id: http://skia.googlecode.com/svn/trunk@10489 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd Loop Blinn hairline conics to GPU
egdaniel@google.com [Thu, 1 Aug 2013 17:09:11 +0000 (17:09 +0000)]
Add Loop Blinn hairline conics to GPU

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/21036008

git-svn-id: http://skia.googlecode.com/svn/trunk@10487 2bbb7eff-a529-9590-31e7-b0007b416f81