Oleg Drokin [Thu, 1 Oct 2015 04:12:28 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_namespace_free()
It was directly used only on the server. Client side part
was split into smaller chunks to avoid deadlocks.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:27 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_lock_fail_match()
It's not used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:26 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_glimpse_ast()
Only used on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:25 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_errno2error()
This particular incarnation is only used on the server.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:24 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()
Not used anywhere
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:23 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_init/fini_flock_export
And all supporting export infrastructure. There's no use for it
all on client.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:22 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_cli_enqueue_local()
This is only used on the server.
Also while we are at it, remove unused prototypes for
ldlm_server_ast and ldlm_handle_enqueue0() that are not
defined anywhere
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:21 +0000 (00:12 -0400)]
staging/lustre/ldlm: Get rid of lr_converting queue
Now that we removed all the lock conversion functions,
also get rid of the converson queue since nothing could ever
get there anyway.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:20 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unimplemented lock conversion traces.
Lock conversion is not really implemented, so let's stop
pretending here.
This removes ldlm_lock_convert, ldlm_cli_lock_convert
and ldlm_lock_downgrade.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:19 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove ldlm_init/destroy_export()
These functions are used on the server-only, so get rid of them.
Also get rid of ldlm export hash operations and the struct.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:18 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused ldlm_cancel_locks_for_exports()
This is only used on the server in case a client gets disconnected.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:17 +0000 (00:12 -0400)]
staging/lustre/ldlm: Remove unused interval tree bits
On client side interval-tree code operations are pretty basic,
so get rid of the code that is only used on the server to figure
out how much to extend the locks and such.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:16 +0000 (00:12 -0400)]
staging/lustre/lov: Remove unused lov_lsm_decref()
Also lov_lsm_addref is only used in the file it is defined,
so make it static
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:15 +0000 (00:12 -0400)]
staging/lustre/lov: Remove unused lov_dump_lmm/pool()
These generic switch functions appear to be unused as all the
individual ones are called directly.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:14 +0000 (00:12 -0400)]
staging/lustre/llite: Remove unused ll_rmdir_entry()
The ioctl for this function was removed, but the function was
forgotten, so kill it now.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:13 +0000 (00:12 -0400)]
staging/lustre: Remove ununused ll_ra_read_get()
Also ll_ra_read_get_locked that was only used by it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:12 +0000 (00:12 -0400)]
staging/lustre: KEY_DEFAULT/MAX_COOKIESIZE key is unused, remove them
Also remove the lmv and mdc infrastructure to query these keys.
In fact this whole "unlink cookies" thing becomes irrelevant
with newer servers, but since we still retain 2.[123] servers
commpatibility, we cannot completely remove all traces of it yet.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Thu, 1 Oct 2015 04:12:11 +0000 (00:12 -0400)]
staging/lustre/llite: Remove unused ll_get_default/max_cookiesize()
This was used for a function that's no longer important, but
is no longer used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ronit Halder [Wed, 30 Sep 2015 06:09:45 +0000 (11:39 +0530)]
staging: dgap: fix memory leak in dgap_parsefile()
In dgap_parsefile() char pointers are set with kstrdup()
without checking that some string is allocated to that
char pointer before. This patch frees the memory if already allocated
and then set the poniter with kstrdup().
Signed-off-by: Ronit halder <ronit.crj@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:59 +0000 (08:24 +0300)]
staging: sm750fb: remove unused enable{ZVPort,SSP,PWM} functions
The functions that enable/disable power for some sub-devices are not
used and therefore they can be removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:58 +0000 (08:24 +0300)]
staging: sm750fb: staticize getPowerMode function
The getPowerMode function is not used outside ddk750_power, make it
static.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:57 +0000 (08:24 +0300)]
staging: sm750fb: remove unused macros
Several macros defined in sm750.h and sm750_help.h are not used and
therefore they can be removed
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:56 +0000 (08:24 +0300)]
staging: sm750fb: remove unused ddk750_initDVIDisp function
The ddk750_initDVIDisp function is never used and therefore it can be
removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:55 +0000 (08:24 +0300)]
staging: sm750fb: remove unused calcPllValue2 function
The calcPllValue2 function is never called and therefore it can be
removed.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Wed, 30 Sep 2015 05:24:54 +0000 (08:24 +0300)]
staging: sm750fb: staticize local functions in ddk750_chip
Several functions in ddk750_chip are not used elsewhere, let's make them
static.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 30 Sep 2015 08:52:14 +0000 (17:52 +0900)]
staging: wilc1000: fix build error for openrisc-allmodconfig
The kbuild test robot reports the following build error for
openrisc-allmodconfig.
>> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
>> declaration of function 'memset'
The error occurs due to missing a standard header file as
<linux/string.h> so that three .c files are included it.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 30 Sep 2015 02:59:24 +0000 (11:59 +0900)]
staging: wilc1000: remove define CONNECT_DIRECT
The driver use CONNECT_DIRECT define as always. No need to provide as feature.
This patch removes ifdef/ifndef CONNECT_DIRECT line and it's related codes
inside ifndef CONNECT_DIRECT.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 30 Sep 2015 02:59:23 +0000 (11:59 +0900)]
staging: wilc1000: remove define WILC_PARSE_SCAN_IN_HOST
The define WILC_PARSE_SCAN_IN_HOST is always used in the driver, so just
delete ifdef WILC_PARSE_SCAN_IN_HOST line, ifndef WILC_PARSE_SCAN_IN_HOST
line and it's related codes. Finally, remove define in Makefile.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 29 Sep 2015 23:15:42 +0000 (08:15 +0900)]
staging: wilc1000: delete wilc_oswrapper.h
This patch deletes wilc_oswrapper.h that has nothing inside.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 29 Sep 2015 23:15:41 +0000 (08:15 +0900)]
staging: wilc1000: remove wilc_platform include file
This patch removes wilc_platform.h include file in wilc_oswrapper.h
wilc_platform.h have several standard header files so that some header
files should be included to avoid compilation errors.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Tue, 29 Sep 2015 19:15:49 +0000 (12:15 -0700)]
wilc1000 : Use BIT() macro where possible
Replace (1 << x) by BIT(x) as recommended by
checkpatch.pl
Signed-off-by: Anish Bhatt <anish@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Tue, 29 Sep 2015 19:15:48 +0000 (12:15 -0700)]
wilc1000 : Remove leftover comment delimiters
Remove leftover comment delimiters that were only partially removed
in a previous cleanup.
Fixes :
c3ca63728ad8 ("staging: wilc1000: remove useless comment")
Signed-off-by: Anish Bhatt <anish@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cristina Moraru [Tue, 29 Sep 2015 21:47:25 +0000 (14:47 -0700)]
staging:emxx_udc: Fixed comparison style warnings
Fixed 'Comparisons should place the constant on the right side of the
test' Warnings
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 29 Sep 2015 19:21:28 +0000 (00:51 +0530)]
Staging: media: lirc: Use USB API functions rather than constants
Introduce use of function usb_endpoint_is_int_in() and
usb_endpoint_is_int_out(). Also remove the variables
ep_dir and ep_type as they are not used anymore.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Wed, 30 Sep 2015 01:46:43 +0000 (03:46 +0200)]
staging: iio: iio_dummy_evgen: handle_simple_irq() build fix
handle_simple_irq() has dropped the first parameter, so fix it up in the
iio_dummy_evgen.c driver to prevent the build from breaking.
Cc: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Wed, 30 Sep 2015 01:37:48 +0000 (03:37 +0200)]
Merge tag 'iio-for-4.4a' of git://git./linux/kernel/git/jic23/iio into staging-next
Jonathan writes:
First round of new driver, new functionality and cleanups for IIO in the 4.4 cycle
New device support
* APDS9960 ALS + proximity driver
* bmg160 SPI devices.
* HDC100x humidity sensors
* Holt HI-8435 threshold detector
* mma8453Q accelerometer added to the mma8452 driver
* mma86452FC and mma8653FC accelerometers added to the mma8452 driver
* mxc4005 accelerometer
* PulsedLight LIDAR
* SensorTech VZ89x volatile organic compound sensor
* UPISEMI uS5182d ALS and proximity sensors
New core functionality
* triggered events - use triggers to check for changes in threshold type
detectors on devices with out interrupt support. First user is the holt
comparator.
* chemical concentration and resistance channel types.
New driver functionality
* vf610
- buffer support.
- followup coccinelle warning fix.
Core rework
* buffers
- break out callback buffer to own module.
- move buffer implementations to a new subdirectory
* percolate the error code form iio_event_getfd out to userspace
rather than giving a missleading error later on.
Cleanups
* adddac drivers
- use BIT macro where appropriate.
* meter drivers
- use BIT macro where appropriate.
* ad7303
- add an OF match table to line up with the binding docs.
* adc128s052
- add an OF match table to line up with the binding docs.
* adf4350
- add an OF match table to line up with the binding docs
* as3935
- add an OF match table to line up with the binding docs.
* berlin2-adc
- use GENMASK and BIT for masks
- prevent attempting to sample multiple channels at once by moving a
mutex scop
- coding style cleanups
* bmg150_magn
- kconfig sort order was wrong - fix it.
* bmg160
- use i2c regmap and drop all uses of i2c_client
- separate i2c and core driver
* cc10001_adc
- kconfig sort order was wrong - fix it.
* evgen (dummy driver helper module)
- move interrupt generation to irq_work to reduce differences between
the dummy driver and real hardware drivers.
* hmc5843
- set the name dynamically rather than to a fixed value for one of the
suported parts.
- export module alias information to allow autoprobing of module.
* lpc32xx
- on failure to get resource or irq return -ENXIO as uppose to -EBUSY
* max1027
- set .of_match_table to actually allow OF style matching.
* max5821
- add MODULE_DEVICE_TABLE for OF table.
* mma8452
- refactor to separate out chip specific data.
- add freefall / motion interrupt source for devices that do their
interrupts slightly differently.
- update copywrite notice.
- leave naming of events directory in sysfs to the core
* mcp320x
- set .of_match_table so that it can be use for OF style matching.
* mlx90614
- Implement filter configuration (note the datasheet changed as a result
of the driver reviews to include the values we needed ;)
* opt3001
- drop .owner field as assigned by platform driver core.
* si7020
- replace a bitmask on the humidity values with a more correct range
check.
* stk310
- improved error handling.
- use BIT macro where appropriate and use the resulting defines
instead of magic numbers in the code.
- fix indentation
* st-sensors
- add debugfs register read hook
* tsl4531
- fix error handling in check_id
* twl6030
- fix module autoload for OF
* iio-trig-sysfs
- document add and remove attribute
* trigger in staging
- code alignment fixes.
- braces on both branches of if statement if needed for one.
* xilinx-xadc
- push interrupts into hardirq context as there isn't much in them
any more and it avoids breaking PREEMPT_RT builds due to the use
of a spinlock between the hardirq and the thread.
Tools
* event-monitor
- report unsupported events. We keep expanding what can come from drivers
so give a helpful error if one turns up in an out of date userspace
program.
* generic-buffer
- helpful message about needing to enable a channel to start the buffer.
Oleg Drokin [Tue, 29 Sep 2015 03:44:12 +0000 (23:44 -0400)]
staging/lustre: Remove ccc_transient_page_* methods
All of them but the ccc_transient_page_prep are unused, so remove
the unused ones.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:11 +0000 (23:44 -0400)]
staging/lustre: Remove unused ccc_io_fini()
Does not appear to be used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:10 +0000 (23:44 -0400)]
staging/lustre: Remove ccc_attr/conf_set()
These seem to be unused.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:09 +0000 (23:44 -0400)]
staging/lustre: Remove server-only recovery-related bits
This patch is a first stab at trying to remove structure fields
from obd_export and obd structures that are only used on the
server or make sense on the server. These include tracking
requests in recovery, various recovery stages, lists of
recovered and not yet recovered clients and so on.
Also prune functions that use these fields.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:08 +0000 (23:44 -0400)]
staging/lustre/obdclass: Remove unused nid_hash
nid_hash is used on export to faster find clients based on
their NID. There's no use for that on the client.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:07 +0000 (23:44 -0400)]
staging/lustre/fid: Remove unused struct lu_server_seq
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:06 +0000 (23:44 -0400)]
staging/lustre/fid: Get rid of lcs_srv in lu_client_seq
Since we know lcs_srv is always NULL, just get rid of it completely
and fix up all the code to assumee it was never there.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:05 +0000 (23:44 -0400)]
staging/lustre/fid: Remove unused seq_client_get_seq function
Also while we are at it, remove seq_site_fini forward declaration
as there's no such function anymore.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:04 +0000 (23:44 -0400)]
staging/lustre/fid: seq_client_init/fini don't need to be exported
In fact they could be static as they are only used inside
this file, so remove EXPORT_SYMBOL and declarations.
Also seq_client_init is always called with srv = NULL, so just
drop this argument.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:03 +0000 (23:44 -0400)]
staging/lustre/fid: Remove server fid function declarations
Those functions are not present anywhere in the client code.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Tue, 29 Sep 2015 03:44:02 +0000 (23:44 -0400)]
staging/lustre: remove lots of dead code
This is a large patch to remove all dead code from obdclass and
ptlrpc, purely removing functions and declarations now, so
despite the size should be easy enough to verify.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:01 +0000 (23:44 -0400)]
staging/lustre: Drop unused obdo_from_la() and la_from_obdo()
They are no longer used anywhere.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:44:00 +0000 (23:44 -0400)]
staging/lustre/ptlrpc: secure wrapping code cleanup
Drop unused functions.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:59 +0000 (23:43 -0400)]
staging/lustre/ptlrpc: Drop unused client code
These client request/import functions are not used anywhere,
so drop them.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:58 +0000 (23:43 -0400)]
staging/lustre/obdclass: Drop unused code from obdo.c
These functions are not even referenced in any header files anymore.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:57 +0000 (23:43 -0400)]
staging/lustre: Remove unused function server_name2svname()
All users are only in the server code
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:56 +0000 (23:43 -0400)]
staging/lustre: Remove unused function class_handle_hash_back()
No callers left.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:55 +0000 (23:43 -0400)]
staging/lustre/obdclass: Remove unused functions from genops.c
These functions are mostly used on the server.
class_uuid2obd, get_devices_count, class_obd_list, class_conn2obd,
class_conn2cliimp, class_connected_export, obd_exports_barrier,
kuc_* (kernel-userspace communications).
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:54 +0000 (23:43 -0400)]
staging/lustre/ldlm: Remove unused round_timeout function
It's not referenced anywhere anymore.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:53 +0000 (23:43 -0400)]
staging/lustre: Remove unused lu_object functions.
Quite a bunch of them are only used on the server.
lu_object_put_nocache, lu_object_invariant, lu_dev_del_linkage,
lu_context_tags_update, lu_context_tags_clear, lu_session_tags_update,
lu_session_tags_clear, lu_env_refill_by_tags, lu_printk_printer,
lu_object_assign_fid, lu_object_anon, lu_buf_free, lu_buf_alloc,
lu_buf_realloc, lu_buf_check_and_alloc, lu_buf_check_and_grow
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:52 +0000 (23:43 -0400)]
staging/lustre: Remove unused functions and definitions from cl_object
cl_object_header_fini, cl_object_has_locks, cl_attr2lvb,
cl_page_list_own, cl_page_list_unmap, cl_2queue_assume,
cl_io_print, cl_enqueue,
also cleanup extern declarations in cl_object.h
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:51 +0000 (23:43 -0400)]
staging/lustre: Remove unused ptlrpcd_add_rqset()
No point in retaining it if it's unused.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:50 +0000 (23:43 -0400)]
staging/lustre: Remove unused statfs_pack()
It's only used on the server.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:49 +0000 (23:43 -0400)]
staging/lustre: Remove high-priority request callbacks
This function is only used on the server where real high-priority
requests actually exist.
This deletes ptlrpc_hpreq_handler() and ptlrpc_request_change_export()
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:48 +0000 (23:43 -0400)]
staging/lustre: Remove unused reply state batches code
rs_batch is used on the server only.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:47 +0000 (23:43 -0400)]
staging/lustre: Remove unused req_capsule_server_grow
It's only used on the server
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:46 +0000 (23:43 -0400)]
staging/lustre/ptlrpc: Remove server-specific health checks
ptlrpc_service_health_check is only used on a service, so
it makes no point to retain it in the client code.
Also removing it's helpers: ptlrpc_svcpt_health_check and
ptlrpc_nrs_req_peek_nolock
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:45 +0000 (23:43 -0400)]
staging/lustre: Remove unused lustre_acl_xattr_merge2posix()
Apparently this is only used only on the metadata server.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 29 Sep 2015 03:43:44 +0000 (23:43 -0400)]
staging/lustre: Remove unused target_print_req()
This is a server-side request printing function, so we don't
really need it on the client.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 29 Sep 2015 05:44:42 +0000 (11:14 +0530)]
Staging: most: Use module_i2c_driver
Macro module_i2c_driver is used for drivers whose init
and exit paths does only register and unregister to i2c
API. Remove some boilerplate code by using module_i2c_driver.
Problem found using Coccinelle.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis de Bethencourt [Tue, 29 Sep 2015 11:22:03 +0000 (12:22 +0100)]
staging: comedi: ni_tiocmd: remove unused code
Code after a return will never run, removing this dead code.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Tue, 29 Sep 2015 07:47:49 +0000 (10:47 +0300)]
staging: sm750fb: remove dead code
Remove the code enclosed in '#if 0'
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis de Bethencourt [Mon, 28 Sep 2015 21:52:33 +0000 (22:52 +0100)]
staging: rtl8712: remove dead code
The while() loop will only exit in a return or a goto ask_for_joinbss,
which means it will never break and execute the return after it.
Removing return _FAIL since it is dead code.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:48 +0000 (22:15 -0800)]
Staging: rtl819u: Fix brace styling issues
This is a patch to correct two flavors of brace styling issues in
ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:43 +0000 (22:15 -0800)]
Staging: rtl8192u: spaces required around = operator
This is a patch to add spaces around = operators in several instances
in ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:38 +0000 (22:15 -0800)]
Staging: rtl8192u: add spaces around == and || operators
This is a patch to add missing spaces around == and || operators in one
instance in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:34 +0000 (22:15 -0800)]
Staging: rtl8192u: move open braces to previous lines
This is a patch to move opening braces to the lines on which their
corresponding if-statements exist in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:29 +0000 (22:15 -0800)]
Staging: rtl8192u: add missing blank lines after declarations
This is a patch to add blank lines after declaration ins several
instances in iee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 24 Sep 2015 06:15:24 +0000 (22:15 -0800)]
Staging: rtl8192u: space required after ','
This is a fix to add spaces after commas in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 27 Sep 2015 19:48:19 +0000 (21:48 +0200)]
staging: rtl8723au: Fix resource leak
Firmware was not released properly if kmemdup fails.
Addresses-Coverity-Id: 1269118
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jakub Sitnicki [Wed, 23 Sep 2015 21:42:26 +0000 (23:42 +0200)]
staging: rtl8188eu: Fix build error when CFG80211 is not selected
The kbuild test robot reports the following build error for
i386-randconfig-c0-
09230740:
>> ERROR: "ieee80211_hdrlen" [drivers/staging/rtl8188eu/r8188eu.ko] undefined!
Add a dependency on CFG80211 to fix it.
Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 22 Sep 2015 21:50:38 +0000 (23:50 +0200)]
staging: rtl8188eu: issue_action_BA(): extract ADDBA_req pointer
pmlmeinfo->ADDBA_req is accessed three times in this function, but it
contributes to generating lines above 80 characters that are not easy to
split in a nice way.
Extract a pointer to it to make code slightly more concise and fix some
lines over 80 characters.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 22 Sep 2015 21:50:37 +0000 (23:50 +0200)]
staging: rtl8188eu: don't cast when calling rtw_set_fixed_ie()
The 'pbuf' and 'source' arguments to rtw_set_fixed_ie() are (void *), the
explicit typecasts are not needed. They just make code less readable.
Also fix checkpatch issues in the lines touched:
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: line over 80 characters
CHECK: Unnecessary parentheses around <var>
Note: some of the modified lines are still over 80 characters because they
are not fixable by just adding newlines. They will be fixed in a later
patch.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 22 Sep 2015 21:50:36 +0000 (23:50 +0200)]
staging: rtl8188eu: rtw_set_fixed_ie(): accept void* parameters
rtw_set_ie() is a memcpy-like function, taking addresses of memory buffers
among its parameters. Similarly to memcpy, change the parameters to be
void*. This will allow to get rid of typecasts whenever it is called.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 22 Sep 2015 21:50:35 +0000 (23:50 +0200)]
staging: rtl8188eu: remove useless comment
This comment gives pretty much the same information as the name of the
function that it immediately precedes.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:33 +0000 (21:04 +0200)]
staging: rtl8192e: Merge/Remove _rtl92e_dm_bb_initialgain_backup
Merge rtl92e_dm_backup_state and _rtl92e_dm_bb_initialgain_backup.
Static function is called only once and dm_backup_state had short body.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:32 +0000 (21:04 +0200)]
staging: rtl8192e: Simplify _rtl92e_calculate_bit_shift
Use ffs instead of iteration. Behaviour of function doesn't change.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:31 +0000 (21:04 +0200)]
staging: rtl8192e: Remove extra braces
Remove extra braces in _rtl92e_dm_check_tx_power_tracking_thermal.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:30 +0000 (21:04 +0200)]
staging: rtl8192e: Remove _rtl92e_dm_check_pbc_gpio
Function is empty.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:29 +0000 (21:04 +0200)]
staging: rtl8192e: Remove _rtl92e_silent_reset_mesh
Function is empty.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:28 +0000 (21:04 +0200)]
staging: rtl8192e: Fix FSF_MAILING_ADDRESS warnings
Remove FSF address from licenses at the beginning of files.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:27 +0000 (21:04 +0200)]
staging: rtl8192e: Fix CONSTANT_COMPARISON warnings
Remove yoda conditions where pointed by checkpatch.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:26 +0000 (21:04 +0200)]
staging: rtl8192e: Fix SUSPECT_CODE_INDENT warnings
Fix SUSPECT_CODE_INDENT warnings (indentation).
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 19:04:25 +0000 (21:04 +0200)]
staging: rtl8192e: rtl_wx: Fix BRACES warning
Fix checkpatch BRACES warning.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Fri, 25 Sep 2015 16:21:01 +0000 (11:21 -0500)]
staging: fsl-mc: Fixed uintX_t CHECK checkpatch warnings
Replaced all uses of uintX_t types to uX types, to be
checkpatch clean.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Thu, 24 Sep 2015 19:26:54 +0000 (14:26 -0500)]
staging: fsl-mc: Moved kernel-doc comments to .c files
Moved kernel-doc comments for non-inline functions
from header files to .c files.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:11:03 +0000 (16:11 -0500)]
staging: fsl-mc: up-rev dprc binary interface to v4.0
Add cmd_flags parameter to all dprc APIs to comply
with the dprc 4.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
dprc 4.0 uses MC-relative offsets to specify object regions,
instead of physical addresses. So, translate_mc_addr() and
struct fsl_mc_addr_translation_range need to be updated
accordingly.
Update commands for 4.0: add new commands 'set/get
obj irq', 'set obj label', 'get obj descriptor'.
Remove 'get portal paddr'.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:11:02 +0000 (16:11 -0500)]
staging: fsl-mc: up-rev dpcon binary interface to v2.0
dpcon object minor version number updated to match latest
MC firmware. This change is needed because the dpcon
object binds to the allocator and the current driver match
logic uses object version numbers.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:11:01 +0000 (16:11 -0500)]
staging: fsl-mc: up-rev dpmcp binary interface to v2.0
Add cmd_flags parameter to all dpbp APIs to comply
with the dpmcp 2.0 MC interface. Updated version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:11:00 +0000 (16:11 -0500)]
staging: fsl-mc: up-rev dpbp binary interface to v2.0
Add cmd_flags parameter to all dpbp APIs to comply
with the dpbp 2.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:10:59 +0000 (16:10 -0500)]
staging: fsl-mc: uprev dpmng binary interface to v8.0
Add cmd_flags parameter to all dpmng APIs to comply
with 8.0 MC firmware interface. Updated MC version
major number.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
J. German Rivera [Wed, 23 Sep 2015 21:10:58 +0000 (16:10 -0500)]
staging: fsl-mc: Add new flags field to MC command header
The Management Complex (MC) binary interface added a new "flags"
field to the command header.
Add the definitions for this field in preparation for adding the
new cmd_flags parameter to all MC interface APIs.
Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sriram Raghunathan [Tue, 22 Sep 2015 17:05:51 +0000 (22:35 +0530)]
staging: android: Fix checkpatch block comments warnings
This patch is intended to fix the checkpatch warning for ``block``
comments for staging/android driver.
Signed-off-by: Sriram Raghunathan <sriram@marirs.net.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 27 Sep 2015 08:17:44 +0000 (09:17 +0100)]
staging: vt6656: remove RX complete locking.
The lock in vnt_submit_rx_urb_complete is blocked by TX activity.
The lock comes from a time when RX needed to be synchronized with
other parts of the driver because the WLAN API was in driver.
Since this is now dealt with in mac80211 the lock is unnecessary.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>