Initial datawrapper diagram.

Parser state diagram.

providers/imap/camel-imap-summary.c now builds

Added rules to build camel-imap-stream

2000-06-07  Jeffrey Stedfast  <fejj@helixcode.com>

* providers/imap/Makefile.am: Added rules to build
camel-imap-stream

* providers/imap/camel-imap-store.c (get_folder): Update.
Moved imap_create here.

* providers/imap/camel-imap-folder.c (delete_messages): Remove.
(imap_create): Removed.
(imap_delete): Removed.
(imap_exists): Removed.

* providers/imap/camel-imap-stream.h: Added typedef's for the stream

* providers/imap/camel-imap-stream.c: Modified to build cleanly

Properly dereference warning/debug messages. (header_references_decode):

2000-06-07  Not Zed  <NotZed@HelixCode.com>

        * camel-mime-utils.c (header_msgid_decode_internal): Properly
        dereference warning/debug messages.
        (header_references_decode): Check we actually have msgid stuff
        before trying to decode it ...

moved camel-imap-stream.* to providers/imap
added providers/imap/camel-imap-summary.c

Remove exists, create, delete. A CamelFolder now always references an

* camel-folder.c: Remove exists, create, delete. A CamelFolder
now always references an existing folder. Remove delete_messages
too since it wasn't being used. Add a "create" flag to
get_subfolder saying whether or not to create the subfolder if it
doesn't yet exist.

* camel-store.c (camel_store_get_folder): Add a "create" flag to
say whether or not to create the folder if it doesn't yet exist.
(camel_store_delete_folder): New method, moved from CamelFolder.
(cache_folder, uncache_folder): Fix up a bit.
(get_folder_name): Explain what this is for.

* providers/mbox/camel-mbox-folder.c:
* providers/mbox/camel-mbox-store.c: Update. Remove support for
hierarchical folders to simplify this for now, since we're not
using it, and it's not completely clear how they should work in an
ELocalStorage world. Needs to be revisited.

* providers/pop3/camel-pop3-folder.c (delete_messages): Remove.
* providers/pop3/camel-pop3-store.c (get_folder): Update.

* providers/vee/camel-vee-folder.c (exists): Remove.
* providers/vee/camel-vee-store.c (vee_get_folder): Update.

Updated: a separator is now a char* rather than a single char because IMAP

2000-06-14  Jeffrey Stedfast  <fejj@helixcode.com>

* camel-folder.c (init): Updated: a separator is now a char* rather than
a single char because IMAP can have a string for a directory separator.
Also, since IMAP does not begin with a directory separator, there is a new
argument (path_begins_with_sep) which decides if a directory should begin
with a directory separator.

* providers/imap/camel-imap-store.c (imap_create): Since, on connect,
Camel tries to create INBOX (which already exists on every IMAP provider)
we can return TRUE when the folder name is "INBOX".

* providers/vee/camel-vee-folder.c (vee_init): Updated.

* providers/imap/camel-imap-folder.c (camel_imap_folder_new): Updated.

* providers/mbox/camel-mbox-store.c (get_folder): Updated.

* providers/mbox/camel-mbox-folder.c (mbox_init): Updated.

* providers/pop3/camel-pop3-folder.c (camel_pop3_folder_new): Updated.

Remove exists, create, delete. A CamelFolder now always references an

* camel-folder.c: Remove exists, create, delete. A CamelFolder
now always references an existing folder. Remove delete_messages
too since it wasn't being used. Add a "create" flag to
get_subfolder saying whether or not to create the subfolder if it
doesn't yet exist.

* camel-store.c (camel_store_get_folder): Add a "create" flag to
say whether or not to create the folder if it doesn't yet exist.
(camel_store_delete_folder): New method, moved from CamelFolder.
(cache_folder, uncache_folder): Fix up a bit.
(get_folder_name): Explain what this is for.

* providers/mbox/camel-mbox-folder.c:
* providers/mbox/camel-mbox-store.c: Update. Remove support for
hierarchical folders to simplify this for now, since we're not
using it, and it's not completely clear how they should work in an
ELocalStorage world. Needs to be revisited.

* providers/pop3/camel-pop3-folder.c (delete_messages): Remove.
* providers/pop3/camel-pop3-store.c (get_folder): Update.

* providers/vee/camel-vee-folder.c (exists): Remove.
* providers/vee/camel-vee-store.c (vee_get_folder): Update.

if the mbox doesn't end with a '\n', write one before appending the new

* providers/mbox/camel-mbox-folder.c (mbox_append_message): if the
mbox doesn't end with a '\n', write one before appending the new
message.

Updated: a separator is now a char* rather than a single char because IMAP

2000-06-14  Jeffrey Stedfast  <fejj@helixcode.com>

* camel-folder.c (init): Updated: a separator is now a char* rather than
a single char because IMAP can have a string for a directory separator.
Also, since IMAP does not begin with a directory separator, there is a new
argument (path_begins_with_sep) which decides if a directory should begin
with a directory separator.

* providers/imap/camel-imap-store.c (imap_create): Since, on connect,
Camel tries to create INBOX (which already exists on every IMAP provider)
we can return TRUE when the folder name is "INBOX".

* providers/vee/camel-vee-folder.c (vee_init): Updated.

* providers/imap/camel-imap-folder.c (camel_imap_folder_new): Updated.

* providers/mbox/camel-mbox-store.c (get_folder): Updated.

* providers/mbox/camel-mbox-folder.c (mbox_init): Updated.

* providers/pop3/camel-pop3-folder.c (camel_pop3_folder_new): Updated.

Renamed from camel_mbox_summary_expunge. Takes a gboolean saying whether

* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_sync):
Renamed from camel_mbox_summary_expunge. Takes a gboolean saying
whether to expunge or just sync the mbox file. Change some
g_errors to g_warning so we don't abort. Make the quick
X-Evolution updating code lseek around correctly. Update the
mbox mtime in the summary file even in the quick case.

* providers/mbox/camel-mbox-summary.h: make
CAMEL_MESSAGE_FOLDER_NOXEV not conflict with
CAMEL_MESSAGE_FOLDER_FLAGGED defined in camel-mime-message.h

* providers/mbox/camel-mbox-folder.c (mbox_close): call
camel_mbox_summary_sync to save flag state if not expunging.
(mbox_expunge): Update for camel_mbox_summary_expunge rename.

Remove exists, create, delete. A CamelFolder now always references an

* camel-folder.c: Remove exists, create, delete. A CamelFolder
now always references an existing folder. Remove delete_messages
too since it wasn't being used. Add a "create" flag to
get_subfolder saying whether or not to create the subfolder if it
doesn't yet exist.

* camel-store.c (camel_store_get_folder): Add a "create" flag to
say whether or not to create the folder if it doesn't yet exist.
(camel_store_delete_folder): New method, moved from CamelFolder.
(cache_folder, uncache_folder): Fix up a bit.
(get_folder_name): Explain what this is for.

* providers/mbox/camel-mbox-folder.c:
* providers/mbox/camel-mbox-store.c: Update. Remove support for
hierarchical folders to simplify this for now, since we're not
using it, and it's not completely clear how they should work in an
ELocalStorage world. Needs to be revisited.

* providers/pop3/camel-pop3-folder.c (delete_messages): Remove.
* providers/pop3/camel-pop3-store.c (get_folder): Update.

* providers/vee/camel-vee-folder.c (exists): Remove.
* providers/vee/camel-vee-store.c (vee_get_folder): Update.

Changed the read and write method prototypes to return an ssize_t type

2000-06-06  Jeffrey Stedfast  <fejj@helixcode.com>

* camel-stream.[c,h]: Changed the read and write method prototypes
to return an ssize_t type rather than an int and also changed
the 'number of bytes' to read or write to a size_t type

* camel-stream-fs.c: same as above

* camel-stream-mem.c: again, same as above

* camel-stream-buffer.c: same

* camel-imap-stream.[c,h]: Added this new stream, cache's previously
read data so each successive call will instead read from the cache

worked on getting providers/imap/* to build cleanly, fixed a number of stupid errors and things like that
am commit'ing code since there are some volunteers that would like to work on imap

fix typo/braino (set "Content-Disposition", not "Content-Description")

* camel-mime-part.c (camel_mime_part_set_disposition): fix
typo/braino (set "Content-Disposition", not "Content-Description")
(camel_mime_part_set_filename): const poison

Ick, damn signs! Fix a bug with sign extended bytes.

2000-06-02  Not Zed  <NotZed@HelixCode.com>

        * camel-mime-utils.c (base64_encode_step): Ick, damn signs!  Fix a
        bug with sign extended bytes.

        * camel-mime-filter-smtp.c (filter): Changed layout/logic slightly
        (to match From filter)

Jeffrey Stedfast  <fejj@helixcode.com>

* camel-mime-filter-smtp.c (filter): Fixed the filter so that it wouldn't
insert garbage under certain conditions.

Don't ref the services in the cache.

2000-06-02  Christopher James Lahey  <clahey@helixcode.com>

* camel-session.c: Don't ref the services in the cache.

moved some debug print statements to better locations

If we get a funny result, just throw it out. Basically a fix for the one

2000-06-02  Not Zed  <NotZed@HelixCode.com>

        * camel-mime-utils.c (header_decode_date): If we get a funny
        result, just throw it out.  Basically a fix for the one true
        broken TradeClient.

2000-06-01  Not Zed  <NotZed@HelixCode.com>

        * camel-folder-summary.c (message_info_free): Free
        references/messsage id.
        (message_info_save): Save them.
        (message_info_load): Load them.
        (message_info_new): And get them from the new message.
        (CAMEL_FOLDER_SUMMARY_VERSION): Bumped for new changes.

        * camel-folder-summary.h: Added references and messageid to
        summary.

Ref and unref objects in the service cache properly.

2000-06-02  Christopher James Lahey  <clahey@helixcode.com>

* camel-session.c: Ref and unref objects in the service cache
properly.

* camel-store.c: Ref the folder when returning it using
lookup_folder.  Used the folder's full name for the key for the
folder cache since that's used to uncache it.

Fun with purify.

* providers/pop3/camel-pop3-store.c (pop3_connect): free msg on
success as well as failure.
(camel_pop3_command_get_additional_data): free buf after reading
the last line (".").

* providers/pop3/camel-pop3-folder.c (get_message_by_uid): free
body data after creating the memstream from it (which will copy
the data).

* providers/mbox/camel-mbox-folder.c (mbox_finalize): free summary
and index paths.

* camel-data-wrapper.c (finalize): unref the stream, if it exists.

Fixes Bug 192.

2000-06-01  Not Zed  <NotZed@HelixCode.com>

        * camel-mime-part.c (construct_from_parser): For a message part,
        set the default content-type to message/rfc822.  Maybe needs to be
        done for multiparts too?

2000-05-31  Not Zed  <NotZed@HelixCode.com>

        * camel-mime-message.c (construct_from_parser): Typo in assersion.

        * camel-mime-parser.c (folder_scan_step): Use a default type of
        message/rfc822 for multipart/digest.  Bug Z192.
        (folder_scan_drop_step): Remove warning.

Init filter_from to NULL, for exception case. (mbox_get_message_by_uid):

2000-05-30  Not Zed  <NotZed@HelixCode.com>

        * providers/mbox/camel-mbox-folder.c (mbox_append_message): Init
        filter_from to NULL, for exception case.
        (mbox_get_message_by_uid): Cast off_t to long int for diagnostics.

        * camel-url.c (camel_url_hash): Hash funciton for using camel
        url's as hash keys.
        (camel_url_equal): equal function for same.

        * camel-session.c (camel_session_finalise): Free cached services.
        (camel_session_init): Init service cache.
        (service_cache_remove): destroy callback to remove a service from
        the cache.

        * camel-store.c (get_folder_internal): Remove the extra ref of the
        folder.  That seems the right behaviour ...?
        (camel_store_get_type): Doh, actually call store init, so the
        cache works.
        (cache_folder): strdup the folder name!  no wonder it never found
        it again.

Renamed from camel_mbox_summary_expunge. Takes a gboolean saying whether

* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_sync):
Renamed from camel_mbox_summary_expunge. Takes a gboolean saying
whether to expunge or just sync the mbox file. Change some
g_errors to g_warning so we don't abort. Make the quick
X-Evolution updating code lseek around correctly. Update the
mbox mtime in the summary file even in the quick case.

* providers/mbox/camel-mbox-summary.h: make
CAMEL_MESSAGE_FOLDER_NOXEV not conflict with
CAMEL_MESSAGE_FOLDER_FLAGGED defined in camel-mime-message.h

* providers/mbox/camel-mbox-folder.c (mbox_close): call
camel_mbox_summary_sync to save flag state if not expunging.
(mbox_expunge): Update for camel_mbox_summary_expunge rename.

Init filter_from to NULL, for exception case. (mbox_get_message_by_uid):

2000-05-30  Not Zed  <NotZed@HelixCode.com>

        * providers/mbox/camel-mbox-folder.c (mbox_append_message): Init
        filter_from to NULL, for exception case.
        (mbox_get_message_by_uid): Cast off_t to long int for diagnostics.

        * camel-url.c (camel_url_hash): Hash funciton for using camel
        url's as hash keys.
        (camel_url_equal): equal function for same.

        * camel-session.c (camel_session_finalise): Free cached services.
        (camel_session_init): Init service cache.
        (service_cache_remove): destroy callback to remove a service from
        the cache.

        * camel-store.c (get_folder_internal): Remove the extra ref of the
        folder.  That seems the right behaviour ...?
        (camel_store_get_type): Doh, actually call store init, so the
        cache works.
        (cache_folder): strdup the folder name!  no wonder it never found
        it again.

Implemented a few more imap functions in providers/imap/camel-imap-folder.c

diff -r1.206 ChangeLog
2a3,9
>  * camel-store.c (camel_store_init): Move it to here.  If this
>  level is going to maintain it, it should set it up.  Lets see what
>  caching folders breaks :(
>
>  * providers/pop3/camel-pop3-store.c (camel_pop3_store_init): Dont
>  init folder cache here.
>
7a15,16
>  (camel_mbox_summary_expunge): Remove some debug, and dont offset
>  frompos?

Make sure we copy messages which are still intact to the new folder.

2000-05-29  Not Zed  <NotZed@HelixCode.com>

        * providers/mbox/camel-mbox-summary.c
        (camel_mbox_summary_expunge): Make sure we copy messages which are
        still intact to the new folder.
        (camel_mbox_summary_expunge): Update the frompos as well when
        moving the content.

>  (message_changed): Track changes to the source message in the
>  summary.
>  (folder_changed): Track folder changes, re-query the folder that
>  changed, and cascade the changed event as well.
>  (camel_vee_folder_finalise): Free subfolder and subfolder summary.

Check the searched folder is open before trying to search it.

2000-05-29  Not Zed  <NotZed@HelixCode.com>

        * providers/vee/camel-vee-folder.c (vee_folder_build): Check the
        searched folder is open before trying to search it.

Fix up some glib precondition stuff. Try to set the URL in

* camel-service.c (camel_service_new): Fix up some glib
precondition stuff. Try to set the URL in camel_service_new before
checking whether or not it's "empty" so that you can successfully
set "sendmail:" as a URL.

Typo

Add a domain field to CamelProvider, to say what kind of data it provides.

* camel-provider.h: Add a domain field to CamelProvider, to say
what kind of data it provides.

* providers/imap/camel-imap-provider.c:
* providers/mbox/camel-mbox-provider.c:
* providers/pop3/camel-pop3-provider.c:
* providers/sendmail/camel-sendmail-provider.c:
* providers/smtp/camel-smtp-provider.c: Set domain to "mail".

* providers/nntp/camel-nntp-provider.c: Set domain to "news".

* providers/vee/camel-vee-provider.c: Set domain to "vfolder". (So
it doesn't end up being listed as a potential mail source in the
mail config wizard.)

(connect_to_server): Remove port number from error message since
it's not terribly useful and we were getting it from the wrong
place anyway.

Split apart password and APOP auth, since some servers seem to do both,

* providers/pop3/camel-pop3-store.c: Split apart password and APOP
auth, since some servers seem to do both, but don't really.
(connect_to_server): Renamed from try_connect. Now actually does
the connection up to the point of checking the greeting for APOP
support.
(query_auth_types): Return APOP, if appropriate. Call
pop3_disconnect after connect_to_server since we don't really want
to be connected.
(pop3_connect): Use connect_to_server rather than duplicating
code. Fix a one-byte buffer overrun in the APOP code.
(pop3_disconnect): Make this able to clean up after a partial
connect.

Use `foo@bar' rather than `"" <foo@bar>' for email addresses with no name

* camel-mime-utils.c (header_address_list_format_append): Use
`foo@bar' rather than `"" <foo@bar>' for email addresses with no
name component.

Added a missing smtp-related file to the dist.

Ripped out camel_imap_command_get_additional_data() from camel-imap-store and implemented a number of methods in camel-imap-folder

Don't set a default boundary. Require the caller to do that.

* camel-multipart.c (camel_multipart_init): Don't set a default
boundary. Require the caller to do that.
(set_boundary): if boundary is NULL, generate a "random" boundary.

* camel-mime-part-utils.c
(camel_mime_part_construct_content_from_parser): Add a call to
camel_multipart_set_boundary after creating a new multipart.

updated changelog to reflect changes I made in providers/imap

Added initial code to camel-imap-folder.c

Updated several imap source files

Replace simple data wrapper here too, oops.

2000-05-25  NotZed  <NotZed@HelixCode.com>

* camel-mime-part-utils.c
(camel_mime_part_construct_content_from_parser): Replace simple
data wrapper here too, oops.

Removed camel-simple-data-wrapper again. Less code to maintain == better

2000-05-25  NotZed  <NotZed@HelixCode.com>

* Makefile.am (libcamel_la_SOURCES): Removed
camel-simple-data-wrapper again.  Less code to maintain == better
code.

* camel-data-wrapper.c (construct_from_stream): Fixes for bug
where text attachments dont work.  Made data-wrapper concrete for
the second time.

Took out code that had been there to reconnect to the server if it was not

2000-05-25  Jeffrey Stedfast  <fejj@helixcode.com>

        * providers/smtp/camel-smtp-transport.c (_send_to): Took out code
        that had been there to reconnect to the server if it was not
        already connected - Mailer code was fixed so that this should not
        be needed.

        * providers/imap/camel-imap-store.[c,h]: Initial code.

Re-add camel-simple-data-wrapper.h, which was removed for some reason.

* camel.h: Re-add camel-simple-data-wrapper.h, which was removed
for some reason.

Added more files to the imap provider to use as an outline - will likely need heavy editing later in development

This is mostly meant as guidance to both me and any volunteers that start working on imap

Fixes to make the SMTP transport thread-safe

Wed May 24 18:09:26 EDT 2000  Jeffrey Stedfast  <fejj@helixcode.com>

* providers/smtp/camel-smtp-transport.[c,h]: Fixes to make the
SMTP transport thread-safe

Added debug fprintfs, tested with a few messages (smtp_data): Fixed to use

Tue May 23 17:49:21 EDT 2000  Jeffrey Stedfast  <fejj@helixcode.com>

* providers/smtp/camel-smtp-transport.c: Added debug fprintfs, tested with a few messages
(smtp_data): Fixed to use data_wrapper_write_to_stream()

* camel-mime-filter-smtp.c (filter): Modified to escape all lines
beginning with a '.' and to place \r before each \n if one did
not previously exist. Removed code to escape "From " as it was found to not be needed

* providers/imap/.cvsignore: added file

Shut up.

stuff

stuff

stuff dude

junk

changelog

more stuff

changelog

stuff

dude, just stuff

added camel-mime-filter-smtp.[c,h] and made mods to camel-mime-filter-from.c

>  searchpart = strchr(namepart, '?');
2000-05-19  NotZed  <NotZed@HelixCode.com>

        * camel-simple-data-wrapper.c (construct_from_stream): If we
        already have been constructed, unref our content.
        (write_to_stream): Check we've been constructued, and change for
        stream api changes.

        * camel-mime-parser.c: Removed exception stuff.

        * md5-utils.c (md5_get_digest_from_stream): repaired.

        * camel-mime-message.c: Remove exception from write_to_stream, and
        fix, and fix formatting.

        * providers/sendmail/camel-sendmail-transport.c (_send_internal):
        Fix for stream changes.

        * providers/pop3/camel-pop3-store.c (camel_pop3_command): Fixes
        for stream changes.

        * providers/mbox/camel-mbox-folder.c, and elsewhere, fix all
        stream api changes.
        (mbox_append_message): Use stream_close() now its back.
        (mbox_append_message): unref the from filter.

        * camel-stream-mem.c: And here.

        * camel-stream-fs.[ch]: Here too.

        * camel-stream-filter.c: Likewise.  This is getting tedious.

        * camel-stream-buffer.c (stream_write): Fix a few little problems.
        (stream_close): Reimplmeent.
        (camel_stream_buffer_read_line): Slightly more efficient version,
        that also only allocates the right amount of memory for strings.

        * camel-seekable-substream.c: Likewise.

        * camel-seekable-stream.[ch]: Remove exceptions, fix formatting,
        changes for stream (re)fixes.  set_bounds returns an error.

        * camel-stream.[ch]: Remove exceptions.  Make flush and reset return
        an error code, repair all the screwed up formatting, and put back
        close.

        * camel-mime-part-utils.c
        (camel_mime_part_construct_content_from_parser): And here.

        * camel-mime-part.c (camel_mime_part_set_content): And this too.
        (write_to_stream): Fixed for stream changes.

        * camel.h: Fixed.

        * providers/vee/camel-vee-folder.c (vee_search_by_expression):
        Implement.  Performs an intersection of the two searches.
        (camel_vee_folder_finalise): Unref search folders.
        (vee_append_message): Implement append.

remove message_number_capability and require uid capatibility.

* camel-folder.c: remove message_number_capability and require uid
capatibility.
(camel_folder_list_subfolders, camel_folder_get_uid_list,
camel_folder_get_subfolder_info, camel_folder_get_message_info):
removed
(camel_folder_get_subfolder_names,
camel_folder_free_subfolder_names): new subfolder interfaces.
(camel_folder_get_uids, camel_folder_free_uids): new uid
interfaces
(camel_folder_get_summary, camel_folder_free_summary): new summary
interfaces

* providers/mbox/camel-mbox-folder.c,
* providers/nntp/camel-nntp-folder.c:
* providers/vee/camel-vee-folder.c: Update for changes

* providers/pop3/camel-pop3-folder.c: Implement get_uids, update
for other changes.

add urls file

Guess!

2000-05-18  NotZed  <NotZed@HelixCode.com>

        * providers/vee/camel-vee-folder.c: Guess!

        * camel-folder-search.c (search_user_flag): Implement user_flag
        search term.

        * camel-folder-search.h: Added user_flag search capability
        (user-flag "blah")

        * providers/mbox/camel-mbox-folder.c (mbox_init): Set USER flag in
        permanent flags for the folder.

Remove unused async open/close and copy_message_to functions. Rename

* camel-folder.c: Remove unused async open/close and
copy_message_to functions.
Rename functions without initial _. Fix glib preconditions and
gtk-doc comments.

remove get/set_output_stream operations. They're redundant with

* camel-data-wrapper.c: remove get/set_output_stream operations.
They're redundant with write_to_stream, and CamelMimePart and
CamelMimeMessage only implement the latter, meaning that trying to
get_output_stream on a CamelMimeMessage that was built from pieces
rather than being parsed from a stream doesn't work. Anything that
uses get_output_stream can be rewritten to use write_to_stream, so
we'll standardize on that.
(camel_data_wrapper_new): remove this: CamelDataWrapper is
supposed to be an abstract class.
(write_to_stream): remove default implementation. (Moved to
CamelSimpleDataWrapper)

* camel-simple-data-wrapper.c: resurrect, although it's not really
the same thing it was before. A simple data wrapper, which is
backed by a CamelStream.

* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Use
construct_from_stream rather than set_output_stream.
(camel_mime_part_construct_content_from_parser): Change
camel_data_wrapper_new to camel_simple_data_wrapper_new.

* camel-mime-part.c (camel_mime_part_set_content): Change
camel_data_wrapper_new to camel_simple_data_wrapper_new.

Quick fix to get it to compile. I hope I don't get into trouble.

* camel-folder-summary.c: (message_info_load):
Quick fix to get it to compile. I hope I don't get into trouble.

Don't include the no-longer-distributed possibly-to-be-removed headers.

* camel.h: Don't include the no-longer-distributed
possibly-to-be-removed headers.

fix an off-by-one error in address parsing (smtp_data): use

* providers/smtp/camel-smtp-transport.c
(smtp_get_email_addr_from_text): fix an off-by-one error in
address parsing
(smtp_data): use camel_data_wrapper_get_output_stream rather than
data_wrapper->output_stream

All this basically to support user flags in the summary. They are not yet

All this basically to support user flags in the summary.  They
are not yet saved to the message headers (complicates things a bit).

2000-05-17  NotZed  <NotZed@HelixCode.com>

        * providers/mbox/camel-mbox-folder.c (message_changed): Snoop
        changes to user flags on the message into the summary as well.

        * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_init):
        Changed version init to include the parent class version info
        (i.e. add it not overwrite it).

        * camel-folder-summary.c (message_info_new): Initialise user_flags
        to empty.
        (message_info_load): And load user flags.
        (message_info_save): And save user flags.
        (message_info_free): And free them.
        (CAMEL_FOLDER_SUMMARY_VERSION): Bumped file revision.

        * camel-folder-summary.h: Added user-flags to summary.

        * camel-mime-message.c (camel_mime_message_set_user_flag): Dont
        use a hashtable for user flags.
        (camel_mime_message_get_user_flag): And changed here too.
        (camel_flag_get): New interface to get a flag from a flag
        list.  Flag lists are easier to work with than hash tables, and
        save memory too.
        (camel_flag_set): And set.
        (camel_flag_list_free): And free.
        (free_key_only): Discard.
        (finalize): Remove the flag list.

error checking on gethostbyaddr() in providers/smtp/camel-smtp-transport.c

Implement.

2000-05-16  NotZed  <NotZed@HelixCode.com>

        * providers/mbox/camel-mbox-folder.c (mbox_delete_message_by_uid):
        Implement.

2000-05-12  NotZed  <NotZed@HelixCode.com>

        * camel-movemail.c (camel_movemail): Open the destination with
        O_APPEND, so we dont blow away a partially transferred mbox.
        (camel_movemail): Loop if we get errno=INTR, and not fail.

get things working with new camel summary stuff.

* providers/nntp/camel-nntp-folder.c:
* providers/nntp/camel-nntp-folder.h:
* providers/nntp/camel-nntp-provider.c:
* providers/nntp/camel-nntp-store.c:
* providers/nntp/camel-nntp-utils.c:
* providers/nntp/camel-nntp-utils.h:
get things working with new camel summary stuff.

* providers/nntp/camel-nntp-summary.c:
* providers/nntp/camel-nntp-summary.h:
removed files since camel-folder-summary does all we need.

o Added some preliminary ESMTP AUTH support

Mon May 15 17:19:31 EDT 2000  Jeffrey Stedfast  <fejj@stampede.org>

  o Added some preliminary ESMTP AUTH support

Remove camel_folder_get_summary, which no longer exists.

* camel-folder.h: Remove camel_folder_get_summary, which no longer
exists.

remove some cruft that we're not currently using.

* Makefile.am: remove some cruft that we're not currently using.

Change to match prototype (size_t vs unsigned int) so it works on 64-bit

* camel-stream-mem.c (camel_stream_mem_new_with_buffer): Change
to match prototype (size_t vs unsigned int) so it works on 64-bit
machines. Noted by msw.

now it deff compiles

>  * providers/mbox/camel-mbox-folder.c (message_changed): Indicate
>  the summary changed also.
>

>  (camel_mbox_summary_update): Also save summary when done.
>  (camel_mbox_summary_expunge): Unindex items when deleting them.
>  (camel_mbox_summary_expunge): Save the index as well as the
>  summary.

>  (camel_folder_summary_touch): New function, indicate the summary
>  info changed.
>  (camel_folder_summary_remove): Dirty here.

camel-smtp-transport.c will now compile :)

providers/smtp/camel-smtp-transport.c: updated smtp_helo to more closely comply with RFC 821 standards

Big bunch o memleaks fixed.

2000-05-11  NotZed  <NotZed@HelixCode.com>

        * camel-mime-part.c (write_to_stream): Unref the filter after
        adding it to the filtering stream.

        * providers/mbox/camel-mbox-summary.c
        (camel_mbox_summary_finalise): Free the folder path.

        * camel-folder-summary.c (camel_folder_summary_finalise): Free the
        summary path.

        * camel-internet-address.c (internet_decode): Free multiple entry
        addresses properly.

        * camel-mime-utils.c (header_decode_mailbox): Plugged another
        memleak, free text after converting it.
        (header_decode_addrspec): More leaks plugged.

        * camel-mime-message.c (finalize): Free message_uid.
        (finalize): Free the recipients hashtable.

Free summary items and charset filters.

2000-05-11    <notzed@helixcode.com>

        * camel-folder-summary.c (camel_folder_summary_finalise): Free
        summary items and charset filters.

2000-05-10    <notzed@helixcode.com>

        * camel-folder-summary.c (camel_folder_summary_finalise): Don't
        free stuff in p, after we've free'd p.

        * providers/mbox/camel-mbox-folder.c (mbox_append_message): Unref
        the stream we created for appending.

fixed camel_smtp_transport_class_init(): now initializes service_class

fix a stupid typo. Thank you, C.

* camel-multipart.c (write_to_stream): fix a stupid typo. Thank
you, C.

* camel-mime-part.c (write_to_stream): don't ref the stream before
wrapper a filter around it, since nothing will ever unref it.

Removed dist-hook section.

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am: Removed dist-hook section.

* configure.in: Set the version number.  Added a check for gnome
window icons.  Removed a bunch of unused Makefiles.

* tools/Makefile.am: Created a proper EXTRA_DIST section.

* widgets/e-text/Makefile.am: Added
e-text-event-processor-types.h.

From addressbook/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* backend/ebook/Makefile.am: Added e-book-types.h, e-card-pairs.h,
e-card-types.h.

* backend/pas/Makefile.am: Added pas-backend-ldap.h.

* contact-editor/Makefile.am: Added a proper EXTRA_DIST section.
Removed some old defines.

* ename/Makefile.am: Added e-name-western-tables.h.

* gui/component/Makefile.am: Added e-ldap-server-dialog.h.  Added
a proper EXTRA_DIST section.

* gui/minicard/e-reflow.c: Added a missed cast.

* printing/Makefile.am: Added a proper EXTRA_DIST section.

From calendar/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* gui/Makefile.am: Added main.h.  Combined the two EXTRA_DIST
sections.

From camel/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am: Added camel-types.h, camel-folder-pt-proxy.h, and
camel-thread-proxy.h.

From default_user/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am, local/Calendar/Makefile.am,
local/Contacts/Makefile.am, local/Directories/Makefile.am,
local/Directories/subfolders/Bigfoot/Makefile.am,
local/Directories/subfolders/Netcenter/Makefile.am,
local/Drafts/Makefile.am, local/Inbox/Makefile.am,
local/Outbox/Makefile.am, local/Trash/Makefile.am: Created a
proper EXTRA_DIST section.

From filter/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* filter-arg.h: Changed tree.h to gnome-xml/tree.h.

* Makefile.am: Added filter-arg-types.h, filter-arg.h,
filter-xml.h, filter-format.h, filter-druid.h, filter-editor.h.

From libical/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* configure.in: Reorder Makefiles so that it will build.

From mail/ChangeLog:

2000-05-09  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am: Removed folder-browser-factory.h since it doesn't
exist.  Added mail-display.h, mail-types.h, pixmaps.h.

From widgets/e-table/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am: Added e-table-col-dnd.h and table-test.h.

From wombat/ChangeLog:

2000-05-10  Christopher James Lahey  <clahey@helixcode.com>

* Makefile.am: Added an include for the pcs directory.

Bleah. Can't fsync a pipe. As a quick kludge, just don't stream_flush it.

* providers/sendmail/camel-sendmail-transport.c (_send_internal):
Bleah. Can't fsync a pipe. As a quick kludge, just don't
stream_flush it. The right fix will require bringing back
stream_close though.

o Undid changes to camel-internet-address.[c,h] o Fixed

Tue May  9 09:32:33 EDT 2000  Jeffrey Stedfast  <fejj@stampede.org>
  o Undid changes to camel-internet-address.[c,h]
  o Fixed providers/smtp/camel-smtp-transport.c _send to use camel_internet_address_get()
  o formatting changes to providers/smtp/camel-smtp-transport.c

o Moved struct_address from camel-internet-address.c to

Tue May  9 09:03:18 EDT 2000  Jeffrey Stedfast  <fejj@stampede.org>
  o Moved struct_address from camel-internet-address.c to camel-internet-address.h (so it could be used in providers/smtp/camel-smtp-transport.h)
  o providers/smtp/camel-smtp-transport.c _send should now work like it was meant to

CVS

one more refcounting fix I missed before.

* providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid):
one more refcounting fix I missed before.

o updated to use CamelException (as needed by new camel-stream.c) o no

Mon May  8 22:12:55 EDT 2000  Jeffrey Stedfast  <fejj@stampede.org>
  o updated to use CamelException (as needed by new camel-stream.c)
  o no longer frees memory it shouldn't touch

Use CamelException to signal failure. (camel_stream_write_strings):

* camel-stream.c (camel_stream_read, camel_stream_write,
camel_stream_flush, camel_stream_reset, camel_stream_printf,
camel_stream_write_to_stream): Use CamelException to signal
failure.
(camel_stream_write_strings): Remove. camel_stream_printf is more
useful in most of the places that used this.
(camel_stream_write_string): Change from macro to function to
prevent problems with double-evaluation.

* camel-seekable-stream.c (camel_seekable_stream_seek,
camel_seekable_stream_set_bounds): Use CamelException.
(reset): Update.

* camel-seekable-substream.c, camel-stream-buffer.c,
camel-stream-filter.c, camel-stream-fs.c, camel-stream-mem.c:
Update.

* camel-stream-fs.c: Remove the virtual init functions and move
the code into the creator functions. Add CamelExceptions to
creation functions that could fail.

* camel-data-wrapper.c (camel_data_wrapper_write_to_stream): Use
CamelException.
* camel-mime-message.c, camel-mime-part.c, camel-multipart.c
(write_to_stream): Update.

* camel-mime-parser.c: add an exception to the mime parser private
data and pass that to stream functions as needed.

* gmime-content-field.c, md5-utils.c: Update (badly) for stream
changes.

* camel-exception.h (camel_exception_is_set): convenience macro.

* providers/Makefile.am: disable SMTP for now

* providers/mbox/camel-mbox-folder.c (mbox_append_message): Pass
CamelException to the functions that now need it. Check the
exception after calling camel_stream_flush, and fail if it fails.
(mbox_get_message_by_uid): More updates.

* providers/pop/camel-pop3-folder.c,
providers/pop/camel-pop3-store.c,
providers/sendmail/camel-sendmail/transport.c: Update.

Format From and Reply-To to at least a decoded string. Should probably

2000-05-08  NotZed  <NotZed@HelixCode.com>

        * camel-mime-message.c (process_header): Format From and Reply-To
        to at least a decoded string.  Should probably store them as an
        camelinternetaddress.

blah

Merged NEW_SUMMARY branch back to trunk, and resolved conflicts.

2000-05-08  NotZed  <NotZed@HelixCode.com>

* Merged NEW_SUMMARY branch back to trunk, and resolved conflicts.

* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_update):
Return status.

* camel-stream-filter.c (do_close): We NEED a stream close.

Renamed from camel_mbox_summary_expunge. Takes a gboolean saying whether

* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_sync):
Renamed from camel_mbox_summary_expunge. Takes a gboolean saying
whether to expunge or just sync the mbox file. Change some
g_errors to g_warning so we don't abort. Make the quick
X-Evolution updating code lseek around correctly. Update the
mbox mtime in the summary file even in the quick case.

* providers/mbox/camel-mbox-summary.h: make
CAMEL_MESSAGE_FOLDER_NOXEV not conflict with
CAMEL_MESSAGE_FOLDER_FLAGGED defined in camel-mime-message.h

* providers/mbox/camel-mbox-folder.c (mbox_close): call
camel_mbox_summary_sync to save flag state if not expunging.
(mbox_expunge): Update for camel_mbox_summary_expunge rename.

Merged NEW_SUMMARY branch back to trunk, and resolved conflicts.

2000-05-08  NotZed  <NotZed@HelixCode.com>

* Merged NEW_SUMMARY branch back to trunk, and resolved conflicts.

* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_update):
Return status.

* camel-stream-filter.c (do_close): We NEED a stream close.

Make camel not leak like a sieve.

* camel-object.c: New subclass of GtkObject which is now the base
of the Camel object hierarchy. Currently the only difference
between CamelObject and GtkObject is that CamelObjects don't start
out floating.

* *.h: Move a bunch of typedefs to camel-types.h. Standardize on
using <camel/foo.h> in header files rather than <foo.h>, "foo.h",
or "camel/foo.h". Remove some unneeded includes.

* camel-address.c, camel-data-wrapper.c, camel-folder-search.c,
camel-folder-summary.c, camel-folder.c, camel-mime-filter.c,
camel-mime-parser.c, camel-service.c, camel-session.c,
camel-stream.c: These are now subclasses of CamelObject.

* camel-data-wrapper.c (set_output_stream):
* camel-medium.c (set_content_object):
* camel-seekable-substream.c
(init_with_seekable_stream_and_bounds):
* providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid):
remove gtk_object_sink calls.

* camel-stream-buffer.c (init_vbuf):
* camel-stream-filter.c (camel_stream_filter_new_with_stream):
ref the original stream.

* camel-folder-summary.c (camel_folder_summary_finalise): unref
the filters when finalizing.

* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser,
camel_mime_part_construct_content_from_parser):
* camel-mime-part.c (camel_mime_part_set_content): Unref objects
that are created only to be handed off to other objects. If
they're going to be needed later, they will have been additionally
ref'ed by the object that needs them.

* providers/pop3/camel-pop3-folder.c (get_message_by_number):
unref the message stream after creating the data from it.

* camel-stream.c, camel-stream-buffer.c, camel-stream-filter.c,
camel-stream-fs.c, camel-stream-mem.c: Remove camel_stream_close,
since its semantics are dubious (what happens when you close a
stream other people still have references on?).

* providers/nntp/camel-nntp-store.c:
* providers/smtp/camel-smtp-transport.c:
* providers/pop3/camel-pop3-store.c:
replace camel_stream_close calls with gtk_object_unref.

* providers/mbox/camel-mbox-folder.c:
* providers/nntp/camel-nntp-folder.c:
* providers/sendmail/camel-sendmail-transport.c:
replace camel_stream_close with camel_stream_flush +
gtk_object_unref