Wes Haggard [Wed, 25 Apr 2018 00:05:45 +0000 (17:05 -0700)]
Merge pull request #17747 from weshaggard/RemoveAlpineBuild
Remove Alpine 3.6 builds
Sergey Andreenko [Tue, 24 Apr 2018 22:42:27 +0000 (15:42 -0700)]
Delete unused tests\arm64\fails.testlist (#17745)
* Reenable fixed arm64 tests
* delete the unused file
Carol Eidt [Tue, 24 Apr 2018 21:22:42 +0000 (14:22 -0700)]
Merge pull request #17697 from mikedn/vec-hnd
Initialize Compiler::Vector128/256ULongHandle in compInit
Jarret Shook [Tue, 24 Apr 2018 20:51:06 +0000 (13:51 -0700)]
Merge pull request #17725 from dotnetrt/FixNixTestBuild
Fix unix test build by removing unnecessary 'managed_test_build' semafore file
Viktor Hofer [Tue, 24 Apr 2018 07:49:16 +0000 (09:49 +0200)]
Move Hashtable & friends to shared parition (#17316)
* Move Hashtable & friends to shared parition
* Move HashHelper serialization logic into its own file
* Remove unchecked keyword in Hashtable
Jan Kotas [Tue, 24 Apr 2018 04:42:24 +0000 (21:42 -0700)]
Delete unused variables from CMakeLists.txt (#17743)
Steve MacLean [Tue, 24 Apr 2018 01:39:24 +0000 (21:39 -0400)]
GenericPInvokeCalli shift left then or 1 (#17734)
When _WIN64 is defined vm relies on the secret arg being
shifted left and orred with #1.
Revert part of changes from #17659 to fix dotnet/corefx#29266
Fix arm64 to match amd64
Simplify dllimport.cpp
Bruce Forstall [Tue, 24 Apr 2018 00:53:41 +0000 (17:53 -0700)]
Merge pull request #17746 from BruceForstall/FixUbuntuArmCorefxCronJobs
Fix Ubuntu arm corefx triggers: no cron trigger on build job
Wes Haggard [Tue, 24 Apr 2018 00:50:28 +0000 (17:50 -0700)]
Remove Alpine 3.6 builds
The alpine 3.6 builds have been replaced with the more generic
linux-musl builds so removing them.
Bruce Forstall [Tue, 24 Apr 2018 00:33:06 +0000 (17:33 -0700)]
Fix Ubuntu arm corefx triggers: no cron trigger on build job
Bruce Forstall [Mon, 23 Apr 2018 23:50:00 +0000 (16:50 -0700)]
Merge pull request #17742 from BruceForstall/FixUbuntuArmCorefxTestExclusions
Fix arm corefx test exclusions
Bruce Forstall [Mon, 23 Apr 2018 23:22:51 +0000 (16:22 -0700)]
Fix arm corefx test exclusions
1. Enable using the test exclusion file for Ubuntu arm32.
2. Update the Ubuntu and Windows arm32 exclusion files based on
current GitHub issues.
Bruce Forstall [Mon, 23 Apr 2018 23:09:46 +0000 (16:09 -0700)]
Merge pull request #17729 from BruceForstall/EnableArm32UbuntuCorefxTesting
Enable Ubuntu arm32 corefx testing
kasper3 [Mon, 23 Apr 2018 20:47:36 +0000 (23:47 +0300)]
Set -march=armv7-a for Alpine Linux ARM32 (#17730)
* Set -march=armv7-a for Alpine Linux ARM32
* Remove armv7-linux-gnueabi[hf]
* Cast RLIM_INFINITY to size_t
Atsushi Kanamori [Mon, 23 Apr 2018 20:42:24 +0000 (13:42 -0700)]
Enable Invoke and GetValue for ref-returning members (#17732)
* Reapply https://github.com/dotnet/coreclr/pull/17639
* tryagain-wip 4/23/2018 7:27:37 AM - Fix Invoke of enum-returning methods
* Assert for refbufargs implying valuetype
* Catch ref to void in managed layer
dotnet-maestro-bot [Mon, 23 Apr 2018 20:18:14 +0000 (15:18 -0500)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02723-01, preview1-26423-05, preview3-26423-04, master-
20180423-0039, respectively (#17683)
Bruce Forstall [Sat, 21 Apr 2018 03:55:17 +0000 (20:55 -0700)]
Enable Ubuntu arm32 corefx testing
Jan Vorlicek [Sun, 22 Apr 2018 01:53:08 +0000 (18:53 -0700)]
Fix FakePromote assert (#17724)
This assert was firing when there was a struct with explicit layout and
two byref fields overlapping each other. The assert was checking that
the respective location on the stack was not reported yet.
To fix that, I have changed the assert to fire only if the already
reported kind of reference was different from the current one. That
enables overlapping of two byref fields or two ref fields, but not a
byref and ref fields.
Jacek Blaszczynski [Sat, 21 Apr 2018 22:18:44 +0000 (00:18 +0200)]
Fix unix test build by removing unnecessary 'managed_test_build' semafore file
Fixes #17503
The error is caused by both:
1. Unnecessary usage of 'managed_test_build' semaphore file which is incorrectly
set after /t:BatchRestorePackages build target and prevents managed test build
which is invoked after semaphore alredy exists
2. Masked by the above error is a wrong condition in dirs.proj non-windows test build
which was introduced by PR #17161 and which prevented unix build due to missing
#17161 group build port to unix
Jan Kotas [Sat, 21 Apr 2018 20:18:52 +0000 (13:18 -0700)]
Use volatile load to read brick table entries (#17717)
Fixes #17716
Tarek Mahmoud Sayed [Sat, 21 Apr 2018 06:05:27 +0000 (23:05 -0700)]
Fix getting the Absolute path while looking up the TZ files (#17711)
Sung Yoon Whang [Sat, 21 Apr 2018 06:05:00 +0000 (23:05 -0700)]
Disable GC Coop mode switching during fatal error handling during GC exception (#17710)
Carol Eidt [Sat, 21 Apr 2018 04:10:17 +0000 (21:10 -0700)]
Merge pull request #17673 from CarolEidt/Fix17634
Treat EDI as killed by MaskMove
Vitek Karas [Sat, 21 Apr 2018 03:22:13 +0000 (20:22 -0700)]
Add better coverage for Marshal.GetDelegateForFunctionPointer (#15339)
Also fixes the test Main to correctly collect result codes from all 3 subtests.
dotnet bot [Sat, 21 Apr 2018 00:56:35 +0000 (17:56 -0700)]
Preserve pinned flag in {ReadOnly}Memory<T>.Slice (dotnet/corefx#29246) (#17712)
* Preserve pinned flag in {ReadOnly}Memory<T>.Slice
* Address PR feedback.
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Carol Eidt [Thu, 19 Apr 2018 17:14:23 +0000 (10:14 -0700)]
Treat EDI as killed by MaskMove
It should really only be a fixed reference, not a kill, but if the reference is changed by `LinearScan::resolveConflictingDefAndUse()` it can fail to cause the value in EDI to be killed.
Fix #17634
dotnet bot [Fri, 20 Apr 2018 23:13:31 +0000 (16:13 -0700)]
Update xml comment for {ReadOnly}Memory.Pin method (dotnet/corefx#29137) (#17709)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sung Yoon Whang [Fri, 20 Apr 2018 22:30:56 +0000 (15:30 -0700)]
Fix GC tests that contain GC.Collect() used in wrong scope (#17680)
* Fix GC tests that contain GC.Collect() used in wrong scope
* Fix GCLarge
* fix typos/build errors
* More test failures...
* more ci failure fix
* Fix all the build errors
* Fix test failure
Bruce Forstall [Fri, 20 Apr 2018 19:09:58 +0000 (12:09 -0700)]
Merge pull request #17700 from BruceForstall/AddAditya
Add adityamandaleeka to arm64 users
Brian Sullivan [Fri, 20 Apr 2018 18:37:07 +0000 (11:37 -0700)]
Merge pull request #17688 from briansull/avx_config
Fix for Retail/Checked Asm diffs
Bruce Forstall [Fri, 20 Apr 2018 18:18:20 +0000 (11:18 -0700)]
Merge pull request #17699 from BruceForstall/NoVerboseBuild
Stop building Linux with "verbose"
Bruce Forstall [Fri, 20 Apr 2018 18:17:38 +0000 (11:17 -0700)]
Add adityamandaleeka to arm64 users
Bruce Forstall [Fri, 20 Apr 2018 16:45:36 +0000 (09:45 -0700)]
Stop building Linux with "verbose"
Using "verbose" creates an extraordinary amount of output,
obscuring interesting output. I don't know of a compelling
reason to continue using "verbose", so stop doing so.
Mike Danes [Fri, 20 Apr 2018 15:18:38 +0000 (18:18 +0300)]
Initialize Compiler::Vector128/256ULongHandle in compInit
Koundinya Veluri [Fri, 20 Apr 2018 02:47:52 +0000 (19:47 -0700)]
Fix nested spin locks in thread pool etw firing (#17677)
`UnManagedPerAppDomainTPCount::QueueUnmanagedWorkRequest` fires an ETW event inside a spin lock and a nested spin lock is taken here:
```
SpinLock::GetLock + 0x8E (0x719da71d)
EventPipeBufferManager::AllocateBufferForThread + 0x7B (0x71afa92e)
EventPipeBufferManager::WriteEvent + 0x250 (0x71afbe0a)
EventPipe::WriteEventInternal + 0x125 (0x71951c93)
EventPipe::WriteEvent + 0x91 (0x71951714)
EventPipeWriteEventThreadPoolEnqueue + 0x9E (0x71d468a6)
FireEtwThreadPoolEnqueue + 0xF (0x71b7a04b)
UnManagedPerAppDomainTPCount::QueueUnmanagedWorkRequest + 0x21D (0x71b7a597)
```
Nesting spin locks is not allowed, moved the ETW firing outside the lock.
Brian Sullivan [Fri, 20 Apr 2018 00:03:27 +0000 (17:03 -0700)]
Check for retail config for EnableAVX
Disable AVX2 when AVX is disabled
Carol Eidt [Thu, 19 Apr 2018 23:11:57 +0000 (16:11 -0700)]
Merge pull request #15737 from mikedn/cast-narrow-store
Skip commas when trying to remove some narrowing casts
Atsushi Kanamori [Thu, 19 Apr 2018 19:23:43 +0000 (12:23 -0700)]
Rollback https://github.com/dotnet/coreclr/pull/17639 (#17671)
Andy Ayers [Thu, 19 Apr 2018 17:17:11 +0000 (10:17 -0700)]
GCStress: try to reduce races and tolerate races better (#17330)
This change addresses races that cause spurious failures in when running
GC stress on multithreaded applications.
* Instruction update race
Threads that hit a gc cover interrupt where gc is not safe can race to
overrwrite the interrupt instruction and change it back to the original
instruction.
This can cause confusion when handling stress exceptions as the exception code
raised by the kernel may be determined by disassembling the instruction that
caused the fault, and this instruction may now change between the time the
fault is raised and the instruction is disassembled. When this happens the
kernel may report an ACCESS_VIOLATION where there was actually an attempt to
execute a priveledged instruction.
x86 already had a tolerance mechanism here where when gc stress was active
and the exception status was ACCESS_VIOLATION the faulting instruction would
be retried to see if it faults the same way again. In this change we extend
this to tolerance to cover x64 and also enable it regardless of the gc mode.
We use the exception information to further screen as these spurious AVs look
like reads from address 0xFF..FF.
* Instrumentation vs execution race
The second race happens when one thread is jitting a method and another is
about to call the method. The first thread finishes jitting and publishes the
method code, then starts instrumenting the method for gc coverage. While this
instrumentation is ongoing, the second thread then calls the method and hits
a gc interrupt instruction. The code that recognizes the fault as a gc coverage
interrupt gets confused as the instrumentation is not yet complete -- in
particular the m_GcCover member of the MethodDesc is not yet set. So the second
thread triggers an assert.
The fix for this is to instrument for GcCoverage before publishing the code.
Since multiple threads can be jitting a method concurrently the instrument and
public steps are done under a lock to ensure that the instrumentation and code
are consistent (come from the same thread).
With this lock in place we have removed the secondary locking done in
SetupGcCoverage as it is no longer needed; only one thread can be instrumenting
a given jitted method for GcCoverage.
However we retain a bailout` clause that first looks to see if m_GcCover is
set and if so skips instrumentation, as there are prejit and rejit cases where we
will retry instrumentation.
* Instruction cache flushes
In some cases when replacing the interrupt instruction with the original the
instruction cache was either not flushed or not flushed with sufficient length.
This possibly leads to an increased frequency of the above races.
No impact expected for non-gc stress scenarios, though some of the code changes
are in common code paths.
Addresses the spurious GC stress failures seen in #17027 and #17610.
Marco Rossignoli [Thu, 19 Apr 2018 16:54:09 +0000 (18:54 +0200)]
add field Name to exception (#17668)
dotnet-maestro-bot [Thu, 19 Apr 2018 16:49:03 +0000 (11:49 -0500)]
Update CoreClr, CoreFx, PgoData to preview1-26419-06, preview3-26419-05, master-
20180419-0038, respectively (#17667)
Steve MacLean [Thu, 19 Apr 2018 16:22:10 +0000 (12:22 -0400)]
[Arm64/Linux] Fix GenericPInvokeCalliHelper (#17659)
dotnet-maestro-bot [Thu, 19 Apr 2018 07:53:00 +0000 (02:53 -0500)]
Update BuildTools, CoreClr, CoreFx to preview1-02719-02, preview1-26419-02, preview3-26419-01, respectively (#17662)
Sung Yoon Whang [Thu, 19 Apr 2018 04:46:58 +0000 (21:46 -0700)]
Fix GC leakwheel scenario test (#17656)
* Fix GC leakwheel scenario test
* Should be passing for most cases
Jan Kotas [Thu, 19 Apr 2018 03:02:04 +0000 (20:02 -0700)]
Tweak order of interface declarations on string (#17660)
Fixes https://github.com/dotnet/corefx/issues/29158
Tarek Mahmoud Sayed [Thu, 19 Apr 2018 00:05:44 +0000 (17:05 -0700)]
Fix reading Time zone rules using Julian days (#17635)
* Fix reading Time zone rules using Julian days
* Order the condition correctly
* Start searching from month 1 and not 0
* Exclude n Julian format
* fix typo
* Adding the suggested assert
Wes Haggard [Wed, 18 Apr 2018 23:48:49 +0000 (16:48 -0700)]
Merge pull request #17658 from CarolEidt/UnixDefines2
Remove incorrect UNIX_AMD64_ABI define
dotnet-maestro-bot [Wed, 18 Apr 2018 22:36:33 +0000 (17:36 -0500)]
Update BuildTools, CoreClr, CoreFx to preview3-02718-02, preview1-26418-02, preview3-26418-02, respectively (#17638)
Jan Kotas [Wed, 18 Apr 2018 22:35:48 +0000 (15:35 -0700)]
Delete RuntimeMethodHandle.GetSecurityFlag (#17643)
CAS leftover
Carol Eidt [Wed, 18 Apr 2018 21:37:45 +0000 (14:37 -0700)]
Remove incorrect UNIX_AMD64_ABI define
Jan Vorlicek [Wed, 18 Apr 2018 21:15:16 +0000 (14:15 -0700)]
Fix ephemeral limits checks in write barrier for ARM64 (#17641)
The code was incorrectly using signed conditions, which doesn't work for
server GC where the high ephemeral limit is 0xffffffffffffffff and so it
was checking if the address is less than -1, which is never the case. So
the card table was never updated.
Atsushi Kanamori [Wed, 18 Apr 2018 20:56:42 +0000 (13:56 -0700)]
Enable Invoke and GetValue for ref-returning members (#17639)
* Enable Invoke and GetValue for ref-returning members
https://github.com/dotnet/corefx/issues/15960
Returned magic object is the object pointed to by
the ref. If the ref is null, NullReferenceException.
* Fix error message
* Found way to reuse InvokeUtil::CreateObject
* Remove comment, BYREF case.
Bruce Forstall [Wed, 18 Apr 2018 20:50:58 +0000 (13:50 -0700)]
Merge pull request #17624 from BruceForstall/DisableHangingCoreFxTest
[arm32] Disable corefx Microsoft.Win32.SystemEvents.Tests
Bruce Forstall [Wed, 18 Apr 2018 20:16:04 +0000 (13:16 -0700)]
Merge pull request #17652 from sdmaclea/PR-ARM64-ENABLE-CI-CROSSCOMPONENT-BUILD
[Arm64/Linux] Enable crosscomponent build in CI
Bruce Forstall [Wed, 18 Apr 2018 19:50:08 +0000 (12:50 -0700)]
Merge pull request #17648 from dotnet/dev/unix_test_workflow
Disallow Ubuntu arm32 non-PR jobs in non-master branches
Steve MacLean [Wed, 18 Apr 2018 19:34:38 +0000 (15:34 -0400)]
[Arm64/Linux] Enable crosscomponent build in CI
Bruce Forstall [Wed, 18 Apr 2018 18:40:15 +0000 (11:40 -0700)]
Merge pull request #17636 from BruceForstall/NoUnixTextWorkflowNonPRJobs
Disallow Ubuntu arm32 non-PR jobs in non-master branches
Wes Haggard [Wed, 18 Apr 2018 17:19:36 +0000 (10:19 -0700)]
Fix OutputRID for linux-musl official build
Need to include the `-x64` in the output rid.
Carol Eidt [Wed, 18 Apr 2018 16:28:10 +0000 (09:28 -0700)]
Merge pull request #16962 from CarolEidt/UnixDefines
Unix/x64 ABI cleanup
dotnet-maestro-bot [Wed, 18 Apr 2018 11:54:36 +0000 (06:54 -0500)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview3-02717-01, preview1-26418-01, preview3-26418-01, master-
20180418-0040, respectively (#17621)
Sergey Andreenko [Wed, 18 Apr 2018 07:23:59 +0000 (00:23 -0700)]
disable DevDiv_255294 in stress modes. (#17618)
Sergey Andreenko [Wed, 18 Apr 2018 06:25:57 +0000 (23:25 -0700)]
fix build.cmd generateLayout (#17614)
Bruce Forstall [Wed, 18 Apr 2018 05:38:12 +0000 (22:38 -0700)]
Disallow Ubuntu arm32 non-PR jobs in non-master branches
Chris Sienkiewicz [Wed, 18 Apr 2018 03:19:29 +0000 (20:19 -0700)]
Ensure thumb bit is set when searching for debugger jit info on ARM (#17617)
* Ensure thumb bit is set when searching for debugger jit info on ARM
* Make GetCodeStartAddress return correct PCODE, rather than fixing it at the callee site
* Fix type in daccess.h
* Use PINSTRToPCODE rather than manually adding the thumb bit
Bruce Forstall [Wed, 18 Apr 2018 01:55:27 +0000 (18:55 -0700)]
Merge pull request #17633 from BruceForstall/AdjustArmJobScheduling
Adjust non-PR triggers
Koundinya Veluri [Wed, 18 Apr 2018 01:39:25 +0000 (18:39 -0700)]
Clean up FlushInstructionCache for precodes and interlocked target change operations (#17602)
Wes Haggard [Wed, 18 Apr 2018 00:09:55 +0000 (17:09 -0700)]
Merge pull request #17623 from weshaggard/wesh/addlinuxmusl
Add linux-musl build leg
Jan Kotas [Wed, 18 Apr 2018 00:06:32 +0000 (17:06 -0700)]
Handle getTailCallCopyArgsThunk returning NULL in the JIT (#17592)
This saves the JIT from hardcoding the logic on where getTailCallCopyArgsThunk is implemented
Bruce Forstall [Wed, 18 Apr 2018 00:05:02 +0000 (17:05 -0700)]
Adjust non-PR triggers
1. Enable weekly Ubuntu arm32 GCStress jobs.
2. Fix bugs where both flow and non-flow jobs were being triggered for some configurations.
3. Convert Windows ARM push jobs to daily jobs to conserve limited hardware.
4. Convert Windows ARM64 every-four-hour jobs to daily jobs to conserve limited hardware.
5. Convert Windows ARM64 R2R baseline job from daily to weekly to conserve limited hardware.
6. For altjit jobs, only do push jobs for Checked builds; there's no need for more than that.
7. Add Windows and Ubuntu ARM R2R weekly jobs.
8. Add Windows ARM and ARM64, and Ubuntu ARM, weekly R2R JIT stress jobs.
Fixes #17572, #17241.
Carol Eidt [Thu, 15 Mar 2018 15:21:25 +0000 (08:21 -0700)]
Unix/x64 ABI cleanup
Eliminate `FEATURE_UNIX_AMD64_STRUCT_PASSING` and replace it with `UNIX_AMD64_ABI` when used alone. Both are currently defined; it is highly unlikely the latter will work alone; and it significantly clutters up the code, especially the JIT.
Also, fix the altjit support (now `UNIX_AMD64_ABI_ITF`) to *not* call `ClassifyEightBytes` if the struct is too large. Otherwise it asserts.
Bruce Forstall [Tue, 17 Apr 2018 23:04:32 +0000 (16:04 -0700)]
Merge pull request #17620 from BruceForstall/FixCorefxUnzipQuoting
Fix minor issue with missing end quotes on command line
Bruce Forstall [Tue, 17 Apr 2018 22:59:09 +0000 (15:59 -0700)]
Disable Microsoft.Win32.SystemEvents.Tests
Tracking bug: https://github.com/dotnet/corefx/issues/29166
mikedn [Tue, 17 Apr 2018 21:52:37 +0000 (00:52 +0300)]
Improve SSA dominator tree memory usage (#15006)
There is no need to store the dominator tree children in a hashtable, a vector is sufficient. Given the way the tree is constructed duplicates cannot be added.
Bruce Forstall [Tue, 17 Apr 2018 21:34:08 +0000 (14:34 -0700)]
Fix minor issue with missing end quotes on command line
dotnet-maestro-bot [Tue, 17 Apr 2018 20:41:48 +0000 (15:41 -0500)]
Update CoreClr, CoreFx to preview1-26417-05, preview3-26417-03, respectively (#17607)
Wes Haggard [Tue, 17 Apr 2018 20:06:33 +0000 (13:06 -0700)]
Add linux-musl build leg
mikedn [Tue, 17 Apr 2018 17:58:51 +0000 (20:58 +0300)]
Convert native StringBuilder methods to managed (#17472)
Sergey Andreenko [Tue, 17 Apr 2018 16:43:59 +0000 (09:43 -0700)]
Fix GC tests. (#17594)
* Fix dlbigleak
* cleanup dlstack
* Fix doublinknoleak
* Fix doublinkstay
* Fix dlcollect
* Fix doublinkgen
* Fix dlbigleakthd
Szabolcs Dézsi [Tue, 17 Apr 2018 16:08:53 +0000 (12:08 -0400)]
Adding failing string to Boolean and TimeSpan parse failure exceptions (#15661)
* Adding failing string to Boolean and TimeSpan parse failure exceptions
* Avoid boxing char when using TryParse
* Removing unnecessary nameof expression
* Applying review feedback to remove ParseFailureKind from TimeSpanParse
* Added helper methods for TimeSpan parsing
Steve MacLean [Tue, 17 Apr 2018 15:42:13 +0000 (11:42 -0400)]
Fix line endings (#17606)
Carol Eidt [Tue, 17 Apr 2018 14:32:58 +0000 (07:32 -0700)]
Merge pull request #17560 from fiigii/fixcvt
Fix extra register-dependency on mem-form of vcvtsd/s2ss
Avi Avni [Tue, 17 Apr 2018 14:14:34 +0000 (17:14 +0300)]
Enable generic attributes (#9189)
dotnet-maestro-bot [Tue, 17 Apr 2018 13:46:14 +0000 (08:46 -0500)]
Update CoreClr, CoreFx, PgoData to preview3-26417-01, preview3-26417-01, master-
20180417-0048, respectively (#17601)
Russ Keldorph [Tue, 17 Apr 2018 13:45:17 +0000 (06:45 -0700)]
Merge pull request #17575 from debayang/simd_crossgen
[Arm64] Disable SIMD in crossgen (added as part of #14633)
Luqun Lou [Tue, 17 Apr 2018 05:10:29 +0000 (22:10 -0700)]
Enable support DllImport a native assembly whose name contains '.' (#17505)
Petr Bred [Tue, 17 Apr 2018 01:14:21 +0000 (04:14 +0300)]
[X86] Fix cross toolchain library paths (#17513)
- fix internal tests building
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Koundinya Veluri [Tue, 17 Apr 2018 01:13:50 +0000 (18:13 -0700)]
[Arm64] Add memory barrier after interlocked operations (#17595)
Fixes https://github.com/dotnet/coreclr/issues/17591
Russ Keldorph [Tue, 17 Apr 2018 01:12:47 +0000 (18:12 -0700)]
Move master to 2.2-preview1 (#17589)
mikedn [Tue, 17 Apr 2018 01:09:32 +0000 (04:09 +0300)]
Update memory histogram buckets (#15206)
Use values that are more likely to match CPU cache sizes (e.g. L1 = 32K and L2 = 256K)
Ben Adams [Tue, 17 Apr 2018 01:02:38 +0000 (02:02 +0100)]
Dict: Use Ref Local Reassignment (C# 7.3) (#17483)
* Dict: Use Ref Local Reassignment (C# 7.3)
* Use lang version latest rather than 7.3
Bruce Forstall [Tue, 17 Apr 2018 00:45:56 +0000 (17:45 -0700)]
Merge pull request #17402 from sdmaclea/PR-ARM64-COREFX-EXCLUSIONS
[Arm64] Add corefx_test_exclusions.txt
dotnet bot [Mon, 16 Apr 2018 21:47:39 +0000 (14:47 -0700)]
Update xml comment for {ReadOnly}Memory.Pin method (dotnet/corefx#29137) (#17593)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Bruce Forstall [Mon, 16 Apr 2018 20:20:35 +0000 (13:20 -0700)]
Merge pull request #17590 from BruceForstall/CleanupUbunuArmBuildMachine
Clean up Ubuntu arm build machines
Phil Garcia [Mon, 16 Apr 2018 20:11:53 +0000 (13:11 -0700)]
Changed SpinLock::CompareExchange method declaration to static (#17579)
dotnet-maestro-bot [Mon, 16 Apr 2018 19:32:52 +0000 (14:32 -0500)]
Update CoreClr, CoreFx, PgoData to preview3-26416-06, preview3-26416-06, master-
20180416-0039, respectively (#17580)
Igor Kulaychuk [Mon, 16 Apr 2018 18:14:38 +0000 (21:14 +0300)]
[x86/Linux] Fix ICorDebug frames API (#17436)
Konstantin Baladurin [Mon, 16 Apr 2018 18:11:41 +0000 (21:11 +0300)]
[x86/Linux] Fix marshalling struct with 64-bit types (#17455)
* [x86/Linux] Fix marshalling struct with 64-bit types
The System V ABI for i386 defines 4-byte alignment for 64-bit types.
* [Linux/x86] Fix marshalling tests in the case of System V i386 ABI
Bruce Forstall [Mon, 16 Apr 2018 18:09:06 +0000 (11:09 -0700)]
Clean up Ubuntu arm build machines
elyoh [Mon, 16 Apr 2018 18:05:11 +0000 (19:05 +0100)]
Update KoreanLunisolarCalendar.cs (#17542)
* Update KoreanLunisolarCalendar.cs
Corrects two issues with the conversion table for Gregorian to Korean lunisolar dates.
Issue 1: tables use Julian month/day instead of Gregorian month/day for entries prior to 1583.
Lmon and Lday have been converted from Julian month and day to Gregorian month and day for years prior to 1583.
This also required a new value for MIN_GREGORIAN_DAY (now 19) so the minimum date now supported by this class is 19 Feb 0918 Gregorian.
Issue 2: data discrepancy in years 1586, 1587, 1648, 1659, 1692, 1753 and 1754.
Table entries for 1586, 1587, 1648, 1659, 1692, 1753 and 1754 have been corrected to match Korea Astronomy and Space Science In-
stitute (KASI) data. Specifically:
•for years 1587, 1648, and 1754, the first day of year has been corrected
•for years 1586, 1587, 1659, 1692, 1753, and 1754, the lengths of each month have been corrected
Notes
A minor formatting change to the table has been made. The DaysPerMonth flag has been converted to use the binary literal to ensure that changes can be made and verified easily.
See: https://github.com/dotnet/coreclr/issues/17510 for full discussion of changes.
* Update KoreanLunisolarCalendar.cs
Added comment on sources of table data.
dotnet-maestro-bot [Mon, 16 Apr 2018 06:43:04 +0000 (01:43 -0500)]
Update CoreClr, CoreFx, PgoData to preview3-26416-01, preview3-26416-01, master-
20180415-0051, respectively (#17540)