Marcel Hollerbach [Tue, 10 Oct 2017 19:23:42 +0000 (21:23 +0200)]
elm_widget: also eval all children when we are visible
Marcel Hollerbach [Tue, 10 Oct 2017 17:52:18 +0000 (19:52 +0200)]
Merge branch 'devs/bu5hm4n/remove-old-focus-api'
This removes the old focus api from elm_widget.
This sadly brings a few breaks with it that will be fixed in the next
few weeks.
There is currently no item-content focus in gengrid, genlist, list.
custom focus chains are not supported right now, calling the api of it
will result in NOPs.
Inline windows are currently also not getting focus, even though they
should.
Marcel Hollerbach [Wed, 27 Sep 2017 19:20:51 +0000 (21:20 +0200)]
elm_widget: remove apis we dont need anymore
Marcel Hollerbach [Tue, 10 Oct 2017 13:20:13 +0000 (15:20 +0200)]
elm_main: port to new focus api
Marcel Hollerbach [Wed, 16 Aug 2017 13:56:57 +0000 (15:56 +0200)]
elm: move the focus direction definition to general
and remove the old definition
Marcel Hollerbach [Mon, 25 Sep 2017 16:00:06 +0000 (18:00 +0200)]
elm_code: remove those parts
they are not anymore needed, before they existed for keeping the focus
in the window, even if the keystrokes should be focus movements. This is
already working without this.
Marcel Hollerbach [Tue, 26 Sep 2017 23:07:20 +0000 (01:07 +0200)]
efl_ui_win: port to new focus api!
Marcel Hollerbach [Wed, 27 Sep 2017 15:28:41 +0000 (17:28 +0200)]
elm_access: Port to the new focus api
Marcel Hollerbach [Tue, 10 Oct 2017 10:07:21 +0000 (12:07 +0200)]
elm_gengrid: disable the code for now
it will return later
Marcel Hollerbach [Tue, 26 Sep 2017 23:26:33 +0000 (01:26 +0200)]
elm_genlist: for now disable this code
it will return later
Marcel Hollerbach [Tue, 26 Sep 2017 23:35:53 +0000 (01:35 +0200)]
elm_list: for now disable the code
it will return later
Marcel Hollerbach [Mon, 25 Sep 2017 16:01:04 +0000 (18:01 +0200)]
elm_colorselector: migrate to composition!
Marcel Hollerbach [Tue, 26 Sep 2017 23:46:00 +0000 (01:46 +0200)]
elm_spinner: migrate to composition!
Marcel Hollerbach [Mon, 2 Oct 2017 20:52:48 +0000 (22:52 +0200)]
elm_panel: make it a layer
Marcel Hollerbach [Mon, 2 Oct 2017 20:47:53 +0000 (22:47 +0200)]
elm_ui_focus_layer: add configurable behaviour
the layer can now be configured if it should be automatically enabled at
visibility and if the focus should cycle in the layer or not.
Marcel Hollerbach [Tue, 26 Sep 2017 23:37:36 +0000 (01:37 +0200)]
elm_notify: remove old api!
Marcel Hollerbach [Sat, 30 Sep 2017 18:01:18 +0000 (20:01 +0200)]
elm_segment_control: migrate to composition!
Yes! We now have a widget where the we can focus items ... but nothing
more ... ?!
Marcel Hollerbach [Fri, 29 Sep 2017 21:53:23 +0000 (23:53 +0200)]
elm_calendar: migrate to composition!
Marcel Hollerbach [Fri, 29 Sep 2017 20:45:30 +0000 (22:45 +0200)]
elm_clock: convert to composition!
Marcel Hollerbach [Fri, 29 Sep 2017 20:43:37 +0000 (22:43 +0200)]
introduce efl_ui_focus_composition!
It does what the class description tells
Marcel Hollerbach [Fri, 29 Sep 2017 16:56:26 +0000 (18:56 +0200)]
efl_ui_focus_manager_calc: delete items if they are deleted
Marcel Hollerbach [Thu, 28 Sep 2017 09:33:13 +0000 (11:33 +0200)]
elm_widget: use the user_manager for setting focus
Marcel Hollerbach [Mon, 28 Aug 2017 08:20:14 +0000 (10:20 +0200)]
efl_ui_Focus_manager_root_focus: add focus rectangle
the focus rectangle is basically just a normal efl.canvas.rectangle, but
with the focus interface implemented.
This fixes alot of errors which gets called when the root_focus manager
is used, with the submanager as mixin.
Marcel Hollerbach [Thu, 24 Aug 2017 18:03:04 +0000 (20:03 +0200)]
efl_ui_focus_manager_root_focus: correctly call state eval
when a new item is registered we should eval state to unregister the
rect
Marcel Hollerbach [Thu, 28 Sep 2017 09:00:10 +0000 (11:00 +0200)]
efl_ui_focus_manager_root_focus: only register if we really need to
Marcel Hollerbach [Mon, 25 Sep 2017 16:07:54 +0000 (18:07 +0200)]
elm: introduce efl_ui_focus_layer
what it does is described in the mixin
this commit refactors inwin hover popup ctxpopup to use that behaviour.
Since it should do exactly that.
Marcel Hollerbach [Wed, 27 Sep 2017 19:11:40 +0000 (21:11 +0200)]
elm_conform: use legacy elm_object api!
Marcel Hollerbach [Wed, 27 Sep 2017 15:45:28 +0000 (17:45 +0200)]
elm_dayselector: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:46:57 +0000 (01:46 +0200)]
elm_toolbar: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:44:48 +0000 (01:44 +0200)]
elm_slideshow: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:44:20 +0000 (01:44 +0200)]
elm_seperator: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:42:20 +0000 (01:42 +0200)]
elm_scroller: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:40:30 +0000 (01:40 +0200)]
elm_prefs: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:35:23 +0000 (01:35 +0200)]
elm_label: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:34:57 +0000 (01:34 +0200)]
elm_diskselector: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:31:18 +0000 (01:31 +0200)]
elm_inwin: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:29:41 +0000 (01:29 +0200)]
elm_index: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:28:16 +0000 (01:28 +0200)]
elm_hover: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:23:58 +0000 (01:23 +0200)]
elm_flipselector: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:22:41 +0000 (01:22 +0200)]
elm_fileselector_entry: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:21:06 +0000 (01:21 +0200)]
elm_fileselector: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:19:20 +0000 (01:19 +0200)]
elm_entry: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:13:09 +0000 (01:13 +0200)]
elm_bubble: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:09:48 +0000 (01:09 +0200)]
elm_actionslider: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:05:17 +0000 (01:05 +0200)]
efl_ui_video: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:03:59 +0000 (01:03 +0200)]
efl_ui_text: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:03:07 +0000 (01:03 +0200)]
efl_ui_slider: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:02:18 +0000 (01:02 +0200)]
efl_ui_progressbar: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:00:33 +0000 (01:00 +0200)]
efl_ui_panes: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 22:58:58 +0000 (00:58 +0200)]
efl_ui_layout: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 16:10:47 +0000 (18:10 +0200)]
elm_naviframe: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 16:03:12 +0000 (18:03 +0200)]
elm_multibuttonentry: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 15:56:00 +0000 (17:56 +0200)]
efl_ui_frame: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 15:54:12 +0000 (17:54 +0200)]
efl_ui_flip: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 15:52:46 +0000 (17:52 +0200)]
efl_ui_clock: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 15:50:55 +0000 (17:50 +0200)]
efl_ui_button: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:46:26 +0000 (01:46 +0200)]
elm_table: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:27:12 +0000 (01:27 +0200)]
elm_grid: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 16:05:23 +0000 (18:05 +0200)]
efl_ui_grid: remove old api!
Marcel Hollerbach [Tue, 26 Sep 2017 23:10:47 +0000 (01:10 +0200)]
elm_box: remove old api!
Marcel Hollerbach [Mon, 25 Sep 2017 15:44:08 +0000 (17:44 +0200)]
efl_ui_box: remove old api!
Marcel Hollerbach [Tue, 10 Oct 2017 09:15:33 +0000 (11:15 +0200)]
elm_toolbar: we need to register the items in the submanager
Jean-Philippe Andre [Tue, 10 Oct 2017 10:30:38 +0000 (19:30 +0900)]
focus: Avoid infinite loop in window
I kept the safety error message for easier debugging.
Test scenario:
elementary_test -to "Window Inline"
Click on an entry. Press Shift+Tab.
Ping @bu5hm4n
Jean-Philippe Andre [Tue, 10 Oct 2017 09:53:43 +0000 (18:53 +0900)]
widget: Make focus_mouse_up_handle internal
I don't think this belongs to the public EO API.
Ref T5363
Jean-Philippe Andre [Tue, 10 Oct 2017 05:15:21 +0000 (14:15 +0900)]
combobox: Mark as legacy only if legacy API is used
See
bc2fe6bb778b559e6c88f836d8cbdfb631b193b4
Jean-Philippe Andre [Thu, 28 Sep 2017 09:03:33 +0000 (18:03 +0900)]
evas: Override del() for evas objects
This makes EAPI evas_object_del() and EO API efl_del() work the same on
evas objects, i.e. a del() implies an immediate call to hide() and mark
the object as "delete_me".
If the refcount remains > 0 the object won't be actually deleted, thus
EFL_EVENT_DEL won't be triggered. I think it would probably be a good
idea to have a new event "del,request", to signal reference owners that
this object "wants" to die.
Ping @raster @zmike
Thiep Ha [Tue, 10 Oct 2017 04:19:03 +0000 (13:19 +0900)]
ector: remove unused value
The stored value of v_last is overwritten in another place,
its stored valued is not used.
Cedric Bail [Tue, 10 Oct 2017 01:27:56 +0000 (18:27 -0700)]
eio: fix multiple open/close chain example.
Cedric Bail [Tue, 10 Oct 2017 00:44:33 +0000 (17:44 -0700)]
eio: update example for openning and closing file asynchronously using a chain.
Subodh Kumar [Mon, 9 Oct 2017 23:41:19 +0000 (16:41 -0700)]
evas: there is no effect of variable assignment while clean up.
Summary:
There is no effect of assingning a variable while clean up.
@fix
Reviewers: raster, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5272
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:40:11 +0000 (16:40 -0700)]
ephysic: comparing with same statement.
Summary:
There is no effect of comparing with same expression.
@fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5271
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:38:25 +0000 (16:38 -0700)]
emile: comparing less than zero with unsigned interger.
Summary:
Unsigned integer should not be compared to less than zero.
@fix
Reviewers: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5270
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:37:47 +0000 (16:37 -0700)]
eina: comparing less than zero with unsigned long int
Summary:
Unsigned integer should not be compared to less than zero
@fix
Test Plan: NA
Reviewers: cedric
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5269
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Subodh Kumar [Mon, 9 Oct 2017 23:36:54 +0000 (16:36 -0700)]
eina: same expression on both statement.
Summary:
Comparing with same expression is avoided.
@fix
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5268
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Marcel Hollerbach [Mon, 9 Oct 2017 11:12:06 +0000 (13:12 +0200)]
efl_ui_focus_manager_calc: we dont need the explicit root handling,
that is done later in line 1205
Marcel Hollerbach [Mon, 9 Oct 2017 11:06:47 +0000 (13:06 +0200)]
efl_ui_focus_manager_calc: focus a child if a logical is focused
If you call focus_set(m, o) where o is a logical child, then the focus
will go to any none logical child of o, or if there is nothing in the
children of o, then the focus will remain on the now focused element.
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 10:26:10 +0000 (19:26 +0900)]
Revert "edje: moved from edje_multisense.c to Ecore_Audio.h for select the type of render."
This reverts commit
c1c424a4075a85375c83f4c137b74c9919c5fc57.
revert edje multisense changes to match ecore audio revert
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 10:09:53 +0000 (19:09 +0900)]
Revert "ecore_audio: a minimal template for playing sound on WINDOWS is added"
This reverts commit
7a98f617e94ef42787e06e685a8d5e7be34fff21.
this commit breaks compiling things against efl badly. i'm on holiday
and haver only a mini screen and keyboard wwith me so any serious wok
in hunting these issues isn't going to be fun or easy. as this causes
bad build brreaks this is worth a revert IMHO. please re-submit wwhen
you've tested against efl by building things against it. also our
public headers just should not have such ifdefs/if's that change api
presented based on how efl is cnfigured. we expose the same api and
macros and types regardless of internal config.
Carsten Haitzler (Rasterman) [Sat, 7 Oct 2017 09:24:29 +0000 (18:24 +0900)]
emotion gst1 - handle null imagwe data returrn and dont crash
fix crash i spotted thanks to getting img obbj data returning null.
@fix
Subodh Kumar [Fri, 6 Oct 2017 16:53:15 +0000 (09:53 -0700)]
efreet: unsigned int cannot be compared to less than zero.
Summary:
Wrong camparision with less than zero for unsigned integer.
@fix
Test Plan: NA
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5262
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:52:41 +0000 (09:52 -0700)]
evas: there is no effect of variable assignment outside the function.
Summary:
Variable assigned is not used anywhere else, making it unused.
@fix
Test Plan: Na
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5263
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:51:13 +0000 (09:51 -0700)]
eet: wrong comparision to less than zero with unsigned integer.
Summary:
Unsigned interger should not be compared to less than zero.
@fix
Test Plan: Na
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5264
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Fri, 6 Oct 2017 16:50:20 +0000 (09:50 -0700)]
elementary: passing NULL to variadic funtion can be undefined.
Summary:
Passing NULL to variadic funtion may lead to undefined behaviour.
@fix
Test Plan: NA
Reviewers: lukasz.stanislawski
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5265
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Godly T.Alias [Fri, 6 Oct 2017 16:48:28 +0000 (09:48 -0700)]
evas: fix for sscanf use with save flags input.
Summary:
As 'flags' can be supplied by application, in case application is supplying
a big string(error case), it can cause crash in some version of glibc.
Setting maximum possible input (0x64) length as width specifier
Fix for static code analyzer warnings
- scanf without field width limits can crash with huge input data on some versions of libc
Signed-off-by: Godly T.Alias <godlytalias@yahoo.co.in>
Test Plan: Run SonarQube
Reviewers: cedric, raster, Princekrdubey, rajeshps
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5266
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Yeongjong Lee [Fri, 6 Oct 2017 16:46:21 +0000 (09:46 -0700)]
elementary: fix unintentional visibility of elm_hover in combobox constructor
Summary:
since
fd9cf1d3b628f70d66ec85a4f2433c675d9ad243, All Eo canvas objects remain
visible by default.
but elm_hover doesn't want to be shown in combobox constructor.
showing elm_hover in constructor occurs unexpected behavior.
this fixes that bug.
Test Plan:
1. elementary_test - Combobox
2. Click the combobox to Expand the list.
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5267
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 5 Oct 2017 23:24:47 +0000 (16:24 -0700)]
efl: properly initialize Eina_File.
CID 1381605.
Cedric BAIL [Thu, 5 Oct 2017 23:23:50 +0000 (16:23 -0700)]
build: fix make examples on Windows
Summary: We should define the windows version before including evil.
Test Plan: Run make examples on windows newer than XP.
Reviewers: vtorri
Subscribers: jenkins, cedric, jpeg
Tags: #efl, #windows
Differential Revision: https://phab.enlightenment.org/D5261
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 5 Oct 2017 23:02:47 +0000 (16:02 -0700)]
evas: make sure we always open the file and look at its header before trying to load data.
Cedric BAIL [Thu, 5 Oct 2017 21:21:23 +0000 (14:21 -0700)]
eio: migrate example to use Eina_Future.
Cedric BAIL [Thu, 5 Oct 2017 18:36:23 +0000 (11:36 -0700)]
evas: remove evas_canvas3d_texture_file_set and efl_file_set instead.
Cedric BAIL [Thu, 5 Oct 2017 16:42:36 +0000 (09:42 -0700)]
evas: remove unused function evas_cache_image_request.
Cedric BAIL [Thu, 5 Oct 2017 16:41:41 +0000 (09:41 -0700)]
evas: remove unused function evas_cache_engine_image_request.
Cedric BAIL [Thu, 5 Oct 2017 16:37:07 +0000 (09:37 -0700)]
evas: remove unused function evas_common_load_image_from_file.
Cedric BAIL [Thu, 5 Oct 2017 16:36:45 +0000 (09:36 -0700)]
evas: remove unused fonction evas_gl_common_image_load.
Cedric BAIL [Thu, 5 Oct 2017 16:28:13 +0000 (09:28 -0700)]
eina: continue to check for magic.
Chris Michael [Thu, 5 Oct 2017 13:54:03 +0000 (09:54 -0400)]
evas-gl-image: Fix dereference after null check
Coverity reports passing a null pointer 'im->gc' to
evas_gl_common_context_flush which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to context_flush
Fixes CID1374273
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 5 Oct 2017 13:51:00 +0000 (09:51 -0400)]
evas-gl-common: Fix dereference after null check
Coverity reports that there may be a null pointer dereference here so
check that 'error' exists before trying to set it.
Fixes CID1374272
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 5 Oct 2017 13:46:18 +0000 (09:46 -0400)]
eolian-bin: Free previously allocated eina_strbuf
Coverity reports that the eina_strbuf 'param_call' leaks when it goes
out of scope here, so fix the leak by freeing the strbuf
Fixes CID1381502
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Cedric Bail [Thu, 5 Oct 2017 04:48:26 +0000 (21:48 -0700)]
evas: remove image_load from the engine.
Cedric Bail [Thu, 5 Oct 2017 04:32:22 +0000 (21:32 -0700)]
evas: remove use of engine image_load from Evas.Canvas3D.Texture.