platform/core/csapi/tizenfx.git
3 years ago[NUI] Fix build warning CA2213
Bowon Ryu [Wed, 16 Dec 2020 06:12:03 +0000 (15:12 +0900)]
[NUI] Fix build warning CA2213

CA2213: Disposable fields should be disposed

Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[NUI] Fix build warning CA1820
Bowon Ryu [Wed, 16 Dec 2020 05:36:27 +0000 (14:36 +0900)]
[NUI] Fix build warning CA1820

CA1820: Test for empty strings using string length

Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[NUI] Fix build warning CA1308
seungho [Thu, 10 Dec 2020 03:21:17 +0000 (12:21 +0900)]
[NUI] Fix build warning CA1308

 - CA1308: Normalize strings to uppercase

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] suppress CA1710 code analysis violation for deprecased APIs
Yeongjong Lee [Tue, 15 Dec 2020 03:22:02 +0000 (12:22 +0900)]
[NUI] suppress CA1710 code analysis violation for deprecased APIs

3 years ago[NUI] Fix the issue that the TrackColor fails to take effect.
guowei.wang [Tue, 15 Dec 2020 06:14:11 +0000 (14:14 +0800)]
[NUI] Fix the issue that the TrackColor fails to take effect.

3 years ago[NUI] Fix build warning & clean code [CA1051]
huiyu [Tue, 15 Dec 2020 07:05:55 +0000 (16:05 +0900)]
[NUI] Fix build warning & clean code [CA1051]

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1051
 - change private (swigCPtr)

Signed-off-by: huiyu <huiyu.eun@samsung.com>
3 years ago[NUI] Fix CA1066
Daekwang Ryu [Mon, 14 Dec 2020 05:23:05 +0000 (14:23 +0900)]
[NUI] Fix CA1066

CA1066:Implement IEquatable when overriding Equals

3 years ago[NUI] Fix CA2000 issues of UIComponents.
guowei.wang [Tue, 15 Dec 2020 07:45:06 +0000 (15:45 +0800)]
[NUI] Fix CA2000 issues of UIComponents.

3 years ago[NUI] Add AlertDialog class
Jaehyun Cho [Wed, 25 Nov 2020 05:29:45 +0000 (14:29 +0900)]
[NUI] Add AlertDialog class

AlertDialog is used to show a dialog with title, message and action
buttons.

Navigator provides static method ShowAlertDialog which pushes Page
containing AlertDialog.

3 years ago[NUI] Add Dialog class
Jaehyun Cho [Mon, 16 Nov 2020 08:34:51 +0000 (17:34 +0900)]
[NUI] Add Dialog class

Dialog is used to show a popup content with background scrim.

Navigator provides static method ShowDialog which pushes Page containing
Dialog.

3 years ago[NUI] Add left/right shadow effect for the scrollablebase.
huayong.xu [Thu, 19 Nov 2020 08:27:10 +0000 (16:27 +0800)]
[NUI] Add left/right shadow effect for the scrollablebase.

This patch is to implement left/right shadow effect for the
scrollablebase.

3 years ago[NUI] Fix svace issue for texture
zhouleonlei [Tue, 15 Dec 2020 05:25:36 +0000 (13:25 +0800)]
[NUI] Fix svace issue for texture

3 years ago[Log] Modify documentation about dlog priorities (#2421)
hyotaekshim [Thu, 17 Dec 2020 05:34:02 +0000 (14:34 +0900)]
[Log] Modify documentation about dlog priorities (#2421)

Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Co-authored-by: WonYoung Choi <wy80.choi@samsung.com>
3 years ago[NUI] Null check of Owner property of LayoutItem for Independent View. (#2416)
bshsqa [Wed, 16 Dec 2020 05:52:10 +0000 (14:52 +0900)]
[NUI] Null check of Owner property of LayoutItem for Independent View. (#2416)

- Current implementation, we didn't check whether the Owner Property is null or not in the Layout method.
 - This patch add null check of it to avoid null exception

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years ago[NUI] Version update (nui2205) (#2406)
dongsug-song [Tue, 15 Dec 2020 06:49:08 +0000 (15:49 +0900)]
[NUI] Version update (nui2205) (#2406)

- matched with dali2-2.0.5

3 years ago[NUI] Fix build warning CA1720
Sunghyun Kim [Thu, 10 Dec 2020 10:18:22 +0000 (19:18 +0900)]
[NUI] Fix build warning CA1720

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1720
CA1720: Identifiers should not contain type names

These warnings need to suppress.
because it is very common name and it's already published.
According to the document described about the rule, we can suppress warnings.

3 years ago[NUI] Delete warning messages
huiyu [Tue, 15 Dec 2020 04:45:11 +0000 (13:45 +0900)]
[NUI] Delete warning messages

Add SuppressMessage code to the API to be deleted.

Signed-off-by: huiyu <huiyu.eun@samsung.com>
3 years ago[NUI] Change "IsTapGestureFeedback" as "Feedback"
Dongsug Song [Tue, 15 Dec 2020 02:54:44 +0000 (11:54 +0900)]
[NUI] Change "IsTapGestureFeedback" as "Feedback"

3 years ago[NUI] Remove build warning - CA1055 (#2338)
huiyueun [Tue, 15 Dec 2020 03:23:05 +0000 (12:23 +0900)]
[NUI] Remove build warning - CA1055 (#2338)

CA1055: URI return values should not be strings
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1055

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: dongsug-song <35130733+dongsug-song@users.noreply.github.com>
3 years agoRevert "[NUI] Fix build warning[CA1000]"
huiyu [Tue, 15 Dec 2020 02:10:34 +0000 (11:10 +0900)]
Revert "[NUI] Fix build warning[CA1000]"

This reverts commit 4cef848feaaefe4abac0b5f7890b8402e37fbcf6.

3 years ago[NUI] Fix build warning CA1724 (#2394)
bshsqa [Tue, 15 Dec 2020 01:44:12 +0000 (10:44 +0900)]
[NUI] Fix build warning CA1724 (#2394)

- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1724
 - This warning requires to discuss to fix the name of the Class.

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] text: Add property for primary cursor (caret) position in TextField/TextEditor
ali198724 [Tue, 8 Dec 2020 08:46:51 +0000 (10:46 +0200)]
[NUI] text: Add property for primary cursor (caret) position in TextField/TextEditor

3 years ago[NUI] Fix build warning[CA1000]
huiyu [Mon, 14 Dec 2020 04:49:29 +0000 (13:49 +0900)]
[NUI] Fix build warning[CA1000]

Signed-off-by: huiyu <huiyu.eun@samsung.com>
3 years ago[NUI] Fix build warning[CA1064]
huiyu [Mon, 14 Dec 2020 03:30:18 +0000 (12:30 +0900)]
[NUI] Fix build warning[CA1064]

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1065

Signed-off-by: huiyu <huiyu.eun@samsung.com>
3 years ago[NUI] Fix build warning CS1064
Sunghyun Kim [Mon, 14 Dec 2020 07:27:40 +0000 (16:27 +0900)]
[NUI] Fix build warning CS1064

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1064
CA1064: Exceptions should be public

3 years ago[NUI] Add TabView and related classes
Jaeun Choi [Tue, 6 Oct 2020 02:33:12 +0000 (11:33 +0900)]
[NUI] Add TabView and related classes

TabView and its related classes, TabBar, TabContent, TabButton and
TabButtonGroup, are added.

TabView consists of TabBar and TabContent.

TabBar consists of a list of TabButton.
TabContent consists of a list of View.

TabView.AddTab() adds TabButton and View to TabBar and TabContent in
TabView.
TabView.RemoveTab() removes TabButton and View from TabBar and
TabContent in TabView.

3 years ago[NUI] Improve Theme load
Jiyun Yang [Mon, 7 Dec 2020 04:19:40 +0000 (13:19 +0900)]
[NUI] Improve Theme load

* Provide default theme in C#: Xaml file IO and parsing time reduced
* Provide on demand theme loading for packages: This enables to avoid unnecessary package load

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoChange SCROLL_FINAL_X to ScrollFinalX (#2382)
JoogabYun [Mon, 14 Dec 2020 07:09:41 +0000 (16:09 +0900)]
Change SCROLL_FINAL_X to ScrollFinalX (#2382)

3 years ago[NUI] Fix CA1710, change name with with the correct suffix
Yeongjong Lee [Thu, 3 Dec 2020 09:26:08 +0000 (18:26 +0900)]
[NUI] Fix CA1710, change name with with the correct suffix

3 years ago[NUI] Add RelativeLayout sample
Yeongjong Lee [Thu, 3 Dec 2020 08:29:30 +0000 (17:29 +0900)]
[NUI] Add RelativeLayout sample

3 years ago[NUI] introduce RelativeLayout
Yeongjong Lee [Wed, 21 Oct 2020 06:45:02 +0000 (15:45 +0900)]
[NUI] introduce RelativeLayout

RelativeLayout calculates the size and position of all the
children based on their relationship to each other.

Please see confluence pages for more details.

3 years ago[NUI] Modify SwitchSample and warnings
zhouleonlei [Fri, 11 Dec 2020 08:46:01 +0000 (16:46 +0800)]
[NUI] Modify SwitchSample and warnings

3 years ago[NUI] Modify 6.0 to 6.5
zhouleonlei [Fri, 11 Dec 2020 07:42:04 +0000 (15:42 +0800)]
[NUI] Modify 6.0 to 6.5

3 years ago[NUI] Add sound feedback for Control
zhouleonlei [Fri, 11 Dec 2020 07:31:03 +0000 (15:31 +0800)]
[NUI] Add sound feedback for Control

3 years ago[NUI] Fix CA2000 warning issues of Application / ImageView.
guowei.wang [Thu, 12 Nov 2020 10:10:53 +0000 (18:10 +0800)]
[NUI] Fix CA2000 warning issues of Application / ImageView.

3 years ago[NUI] Call show winodw on ApplicationInit
huiyu.eun [Fri, 11 Dec 2020 01:23:54 +0000 (10:23 +0900)]
[NUI] Call show winodw on ApplicationInit

- When preload application, the show is called before the appcore is created.
- Call the window show at OnInit and notify the app core

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Suppress CA1716, CA1052, CA1034 for deprecated APIs
Dongsug Song [Fri, 11 Dec 2020 01:17:08 +0000 (10:17 +0900)]
[NUI] Suppress CA1716, CA1052, CA1034 for deprecated APIs

- Since the detected classes will be deprecated, CA1716 warning message is suppressed.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1716
- This is conflict resolving patch for https://github.com/Samsung/TizenFX/pull/2374

3 years ago[NUI] use discard to ignore unused return value
Yeongjong Lee [Thu, 3 Dec 2020 09:48:44 +0000 (18:48 +0900)]
[NUI] use discard to ignore unused return value

Fixes CA1806

3 years ago[NUI] Fix build warning CS0109
Sunghyun Kim [Thu, 10 Dec 2020 09:10:49 +0000 (18:10 +0900)]
[NUI] Fix build warning CS0109

https://docs.microsoft.com/ko-kr/dotnet/csharp/misc/cs0109

3 years ago[NUI] Prevent unnecessary Layout call, make independent if it has true ExcludeLayouti...
seungho [Thu, 10 Dec 2020 08:53:13 +0000 (17:53 +0900)]
[NUI] Prevent unnecessary Layout call, make independent if it has true ExcludeLayouting and root.

 - Make changed flag in Layout method true when the layout is really changed.
 - If a layout has true value of ExcludeLayouting and it also a root layout, currently it couldn't handled as independent.
 - This patch adds to check ExcludeLayouting Property when it call Layout method.

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Remove DropDown class since it is moved to fhub-nui
Jiyun Yang [Thu, 10 Dec 2020 05:59:35 +0000 (14:59 +0900)]
[NUI] Remove DropDown class since it is moved to fhub-nui

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA1034 for obsolete classes
Jiyun Yang [Thu, 10 Dec 2020 05:44:31 +0000 (14:44 +0900)]
[NUI] Fix CA1034 for obsolete classes

[CA1034: Nested types should not be visible](https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1034)

Suppress warning messages for obsolete classes

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Change property name frome Url to Uri
seungho [Thu, 10 Dec 2020 05:21:24 +0000 (14:21 +0900)]
[NUI] Change property name frome Url to Uri

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Fix build warning CS0419
seungho [Thu, 10 Dec 2020 03:20:08 +0000 (12:20 +0900)]
[NUI] Fix build warning CS0419

 - Ambiguous reference in cref attribute: 'Method Name1'. Assuming 'Method Name2', but could have also matched other overloads including 'Method Name3'.

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Fix build warning CA2007
seungho [Thu, 10 Dec 2020 03:22:30 +0000 (12:22 +0900)]
[NUI] Fix build warning CA2007

 - CA2007: Do not directly await a Task
 - When an asynchronous method awaits a Task directly, continuation usually occurs in the same thread that created the task, depending on the async context. This behavior can be costly in terms of performance and can result in a deadlock on the UI thread. Consider calling Task.ConfigureAwait(Boolean) to signal your intention for continuation.

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Fix svace issues
zhouleonlei [Wed, 9 Dec 2020 06:01:58 +0000 (14:01 +0800)]
[NUI] Fix svace issues

3 years ago[NUI] Fix CA1052
Jiyun Yang [Wed, 9 Dec 2020 05:49:11 +0000 (14:49 +0900)]
[NUI] Fix CA1052

CA1052
Static holder types should be Static or NotInheritable.

This patch fixes classes that holds only static members to static or sealed.
If the class is obsolete, added suppress message attribute to hide warnings.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA1069
Jiyun Yang [Wed, 9 Dec 2020 04:55:55 +0000 (13:55 +0900)]
[NUI] Fix CA1069

CA1069
Enums should not have duplicate values.

This patch changed ProperRanges to struct from enum.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA2214
Jiyun Yang [Wed, 9 Dec 2020 03:55:07 +0000 (12:55 +0900)]
[NUI] Fix CA2214

CA2214
Do not call overridable methods in constructors.

* View.cs
  * In the current design, it is hard to remove virtual method call in View constructor.
  * So the patch moved method calling to the private method newly defined.
* ControlStyle.cs
* TextFieldStyle.cs
* ImageViewStyle.cs
* TextLabelStyle.cs
  * Removed unnecessary constructors.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Remove build warning - CA2241
Moonhee, Choi [Tue, 8 Dec 2020 10:24:05 +0000 (19:24 +0900)]
[NUI] Remove build warning - CA2241

3 years ago[NUI] Fix to restore setter of AnimatedImageView.ResourceUrl
Jaehyun Cho [Fri, 4 Dec 2020 04:38:27 +0000 (13:38 +0900)]
[NUI] Fix to restore setter of AnimatedImageView.ResourceUrl

The setter of AnimatedImageView.ResourceUrl was removed incorrectly by
PR #2232.
To fix the above issue, the setter of AnimatedImageView.ResourceUrl is
restored.

3 years ago[NUI] make Graphics.Backend internal
Yeongjong Lee [Thu, 3 Dec 2020 09:34:05 +0000 (18:34 +0900)]
[NUI] make Graphics.Backend internal

Fixes CA2211

3 years ago[NUI] remove "_" and refactoring naming to pascal case.
Joogab Yun [Thu, 10 Dec 2020 08:19:38 +0000 (17:19 +0900)]
[NUI] remove "_" and refactoring naming to pascal case.

3 years ago[NUI] Remove build warning - CA1825
Moonhee, Choi [Tue, 8 Dec 2020 09:27:03 +0000 (18:27 +0900)]
[NUI] Remove build warning - CA1825

3 years ago[NUI] Remove build warning - CA1041
Moonhee, Choi [Tue, 8 Dec 2020 08:57:54 +0000 (17:57 +0900)]
[NUI] Remove build warning - CA1041

3 years ago[NUI] fix exception when Theme.Resource is used in xaml file
Yeongjong Lee [Thu, 3 Dec 2020 05:50:45 +0000 (14:50 +0900)]
[NUI] fix exception when Theme.Resource is used in xaml file

Since local value `xamlFile` is set after `LoadFromXaml()`,
`xamlFile` is always null in `Reload()`.

To fix this exception, it sets `xamlFile` before `XamlLoader.Load()`.

3 years ago[NUI] Fix wrong AnimationState after VectorAnimatedImageView playing stoped
Dongsug Song [Wed, 2 Dec 2020 02:46:38 +0000 (11:46 +0900)]
[NUI] Fix wrong AnimationState after VectorAnimatedImageView playing stoped

3 years ago[NUI] separate layouting logic of the independent children
Yeongjong Lee [Thu, 19 Nov 2020 06:44:35 +0000 (15:44 +0900)]
[NUI] separate layouting logic of the independent children

This patch introduces `IterateLayoutChildren()` method that return
an enumerable collection of the child layouts that affected by parent
layout.

Independent children will be measured in `OnMeasureIndependentChildren()`.

By using `IterateLayoutChildren()`, we can remove the codes that check
whether child layout exclude from layout flow in `OnMeasure`. and api
users don't need to check `View.ExcludeLayouting` property in custom layouts.

3 years ago[NUI] fixed bug about set desired size
Joogab Yun [Wed, 18 Nov 2020 07:06:18 +0000 (16:06 +0900)]
[NUI] fixed bug about set desired size

3 years ago[NUI] Add RedrawInScalingDown in LottieAnimationView
Dongsug Song [Wed, 9 Dec 2020 04:56:31 +0000 (13:56 +0900)]
[NUI] Add RedrawInScalingDown in LottieAnimationView

3 years ago[NUI] Change clipping mode of ScrollableBase (#2354)
bshsqa [Wed, 9 Dec 2020 05:22:46 +0000 (14:22 +0900)]
[NUI] Change clipping mode of ScrollableBase (#2354)

- ClipChildren clipping mode uses stencil buffer.
 - But, scrollableBase is always pretended as rectangular shape so we can change it to ClipToBoundingBox that uses scissor.
 - Usually, Scissor is better than stencil buffer for the performance.

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years ago[NUI] Add Padding parameter for TextPageUtil (#2332)
JoogabYun [Tue, 8 Dec 2020 06:04:57 +0000 (15:04 +0900)]
[NUI] Add Padding parameter for TextPageUtil (#2332)

3 years ago[NUI] Modify NUI Seamless animation bug (#2334) (#2341)
huiyueun [Tue, 8 Dec 2020 03:35:36 +0000 (12:35 +0900)]
[NUI] Modify NUI Seamless animation bug (#2334) (#2341)

* [NUI] Modify NUI Seamless animation bug

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
* [NUI] Modify build warning of seamless

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
* Update DefaultFrameBroker.cs

* Update TransitionAnimations.cs

* Update DefaultFrameBroker.cs

* Update SeamlessBackward.cs

* Update SeamlessForward.cs

* Update TransitionOptions.cs

* Update NUIBrokerSample.cs

* Update DefaultFrameBroker.cs

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Use weak reference for theme changed event
Jiyun Yang [Fri, 20 Nov 2020 08:39:04 +0000 (17:39 +0900)]
[NUI] Use weak reference for theme changed event

Previous theme changed event was holding reference of the view for the theme manager's lifetime
unless the view is disposed by calling Dispose() explicitly.
Since the theme manager is a static class, so there might be a change that the view can't get free by GC.
To solve this problem, this patch apply a weak event that uses weak reference for the handler
so that the views are no longer be caught by theme manager.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Introduce CornerRadiusPolicy to View
Jiyun Yang [Mon, 9 Nov 2020 11:50:02 +0000 (20:50 +0900)]
[NUI] Introduce CornerRadiusPolicy to View

The CornerRadiusPolicy indicates whether the CornerRadius value is relative or absolute.
The default policy is absolute, which means the CornerRadius is an absolute float length.
If the policy is relative, the CornerRadius can have percentage value between 0.0f to 1.0f,
that is relative to the smaller of view's width and height.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Add Url property to convert image buffer to URL for ImageView (#2286)
bshsqa [Mon, 7 Dec 2020 06:59:19 +0000 (15:59 +0900)]
[NUI] Add Url property to convert image buffer to URL for ImageView (#2286)

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years ago[NUI] Modify popup dismiss bug (#2336)
huiyueun [Mon, 7 Dec 2020 05:50:14 +0000 (14:50 +0900)]
[NUI] Modify popup dismiss bug (#2336)

when dismiss popup, the shadow does not disappear.
-An error occurs after changing the parent to GetParent ().
-layer of converting View is null.

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Fix CA2000 warning issues of Camera / ItemView / Animatable / Animation / Anima...
guowei.wang [Wed, 18 Nov 2020 10:29:40 +0000 (18:29 +0800)]
[NUI] Fix CA2000 warning issues of Camera / ItemView / Animatable / Animation / AnimationImageView.

3 years ago[NUI] Let scroll again when displacement for OutOfBound effect become 0
seungho [Thu, 3 Dec 2020 06:59:45 +0000 (15:59 +0900)]
[NUI] Let scroll again when displacement for OutOfBound effect become 0

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Fix not to get framework path via StyleManager
Jiyun Yang [Thu, 3 Dec 2020 07:31:21 +0000 (16:31 +0900)]
[NUI] Fix not to get framework path via StyleManager

StyleManager uses dali singleton service which is not initialized in PreLoad().
Previously in Preload(), ThemeManager got framework resource path via static constant in StyleManager,
which leaded to initialize StyleManager instance that is not valid in PreLoad().

So this patch moved framework resource path constant to the constant file.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix a build warning CA1827 (#2314)
Seoyeon2Kim [Thu, 3 Dec 2020 05:49:53 +0000 (14:49 +0900)]
[NUI] Fix a build warning CA1827 (#2314)

- Changed to use `Count()` method once for a local variable.
 Then, we do not have to be worried about CA1827.
- To fix the build warning, it could replace `Count()` method with `Any()` method
 https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1827
- But, to improve performance as a review, use `Count()` itself.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI-Text] Add more scroll functinality to texteditor
ali198724 [Thu, 5 Nov 2020 18:40:21 +0000 (20:40 +0200)]
[NUI-Text] Add more scroll functinality to texteditor

1- add Horizontal_Scroll_position property (float)
2- add VerticalScrollPosition property (float)
3- add ScrollBy function (take Vector2)

3 years ago[NUI] Add Window extension method GetDefaultNavigator
Jaehyun Cho [Fri, 20 Nov 2020 02:53:16 +0000 (11:53 +0900)]
[NUI] Add Window extension method GetDefaultNavigator

To provide default navigator of window, Window extension method
GetDefaultNavigator is added.

3 years ago[NUI] fix CA1801 build warnings from auto-generated codes by SWIG
Youngbok Shin [Wed, 2 Dec 2020 08:06:19 +0000 (17:06 +0900)]
[NUI] fix CA1801 build warnings from auto-generated codes by SWIG

The 'futureUse' parameter is never being used through the whole code.
It removes 'futureUse' parameter from functions.

3 years ago[NUI] Fix build warnings related to XAML (#2287)
Seoyeon2Kim [Wed, 2 Dec 2020 04:28:06 +0000 (13:28 +0900)]
[NUI] Fix build warnings related to XAML (#2287)

- Need to avoid assigning a property to itself
 https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2245
- Not to use broken cryptographic algorithm : MD5 -> SHA256
 https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5351

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI]Revert temporary patch that fix DA build error (#2284)
YeongJong Lee [Tue, 1 Dec 2020 09:17:28 +0000 (18:17 +0900)]
[NUI]Revert temporary patch that fix DA build error (#2284)

* [NUI] Revert temporary patch that fix DA build error

This reverts commit 44c1dfe00c765eb794e5d85a19d7b2518e9e6444 and
commit ef7737bd45966655c0b557dd8d091291fdb7cb5c.

3 years ago[NUI] Refactoring FrameUpdateCallback
seungho [Wed, 4 Nov 2020 07:06:28 +0000 (16:06 +0900)]
[NUI] Refactoring FrameUpdateCallback

 - Remove FrameCallback.cs and Interop.FrameCallback.cs
 - Rename FrameCallbackInterface to FrameUpdateCallbackInterface

Signed-off-by: seungho <seungho@seungho.tn.corp.samsungelectronics.net>
3 years ago[NUI] Fix not to use setter of AnimatedImageView.URLs (#2303)
Jaehyun Cho [Fri, 27 Nov 2020 07:35:49 +0000 (16:35 +0900)]
[NUI] Fix not to use setter of AnimatedImageView.URLs (#2303)

The setter of AnimatedImageView.URLs was removed to resolve CA2227.
Therefore, the setter of AnimatedImageView.URLs in sample code is also
removed.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
3 years ago[NUI] Add ControlStateTypeConverter for xaml (#2185)
YeongJong Lee [Fri, 27 Nov 2020 05:09:53 +0000 (14:09 +0900)]
[NUI] Add ControlStateTypeConverter for xaml (#2185)

Custom ConstrolState is now available in xaml.

 ### Sample
XamlPage.xaml
```xaml
<View x:Class="NUIXamlTemplate1.XamlPage"
      xmlns="http://tizen.org/Tizen.NUI/2018/XAML"
      xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
      xmlns:c="clr-namespace:Tizen.NUI.Components;assembly=Tizen.NUI.Components"
      xmlns:local="clr-namespace:NUIXamlTemplate1">
    <local:MyButton x:Name="MyButton">
        <x:Arguments>
            <c:ButtonStyle Size="100, 100">
                <c:ButtonStyle.BackgroundColor>
                    <Selector x:TypeArguments="Color" Normal="1, 1, 0, 1" Pressed="0.77, 0.88, 1, 1" Disabled="0.88, 0.88, 0.88, 1">
                        <SelectorItem x:TypeArguments="Color" State="MyState" Value="0,0,1,1" />
                        <SelectorItem x:TypeArguments="Color" State="MyState,Focused" Value="0,1,1,1" />
                    </Selector>
                </c:ButtonStyle.BackgroundColor>
            </c:ButtonStyle>
        </x:Arguments>
    </local:MyButton>
</View>
```

MyButton.cs
```cs
public class MyButton : Button
{
    public MyButton(ButtonStyle buttonStyle) : base(buttonStyle) {}
    public void SetControlState(ControlState s) => ControlState = s;
}
```
Main.cs
```cs
protected override void OnCreate()
{
    base.OnCreate();
    Window.Instance.BackgroundColor = new Color(227 / 255f, 255 / 255f, 227 / 255f, 1.0f);
    Window.Instance.KeyEvent += OnKeyEvent;

    View root = new View();
    root.WidthSpecification = LayoutParamPolicies.MatchParent;
    root.HeightSpecification = LayoutParamPolicies.MatchParent;
    root.Layout = new AbsoluteLayout();
    Window.Instance.GetDefaultLayer().Add(root);

    XamlPage xamlPage = new XamlPage();
    root.Add(xamlPage);

    ControlState MyState = ControlState.Create("MyState");

    Button button = new Button() { Position2D = new Position2D(100, 100) };
    bool flag = false;
    button.Clicked += (object sender, ClickedEventArgs e) =>
    {
        if (!flag)
        {
            xamlPage.MyButton.SetControlState(MyState);
            flag = true;
        }
        else
        {
            xamlPage.MyButton.SetControlState(ControlState.Focused + MyState);
            flag = false;
        }
    };
    root.Add(button);
}
```

3 years ago[NUI] Support Blend Equaiton
seungho [Mon, 9 Nov 2020 09:09:28 +0000 (18:09 +0900)]
[NUI] Support Blend Equaiton

Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[NUI] Remove [Obsolete()] attribute
dongsug.song [Wed, 11 Nov 2020 06:34:11 +0000 (15:34 +0900)]
[NUI] Remove [Obsolete()] attribute

3 years agoUpdate sample of ScrollableBase OutOfBound event handler.
huayong.xu [Fri, 27 Nov 2020 02:27:55 +0000 (10:27 +0800)]
Update sample of ScrollableBase OutOfBound event handler.

3 years ago[NUI] Add direction & displacement into ScrollOutOfBound event.
huayong.xu [Thu, 26 Nov 2020 11:20:26 +0000 (19:20 +0800)]
[NUI] Add direction & displacement into ScrollOutOfBound event.

This patch is to trigger ScrollOutOfBound event as pan gesture state,
and provide more information in ScrollOutOfBound event.

3 years ago[NUI] Delete unnecessary log (#2299)
huiyueun [Fri, 27 Nov 2020 02:56:08 +0000 (11:56 +0900)]
[NUI] Delete unnecessary log (#2299)

- Delete the log commented
- Displays only one log when the value is invalid of color.
- View.Parent is deprecated, modify to use View.GetParent()

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Add AttributeUsageAttribute for ScriptableProperty(CA1018)
Yeongjong Lee [Thu, 29 Oct 2020 06:31:34 +0000 (15:31 +0900)]
[NUI] Add AttributeUsageAttribute for ScriptableProperty(CA1018)

3 years ago[NUI] Fix Svace issues
zhouleonlei [Thu, 26 Nov 2020 08:17:24 +0000 (16:17 +0800)]
[NUI] Fix Svace issues

3 years ago[NUI] Adjust ScrollingEventThreshold to cover larger sized ContentContainer. (#2249)
bshsqa [Fri, 27 Nov 2020 01:27:58 +0000 (10:27 +0900)]
[NUI] Adjust ScrollingEventThreshold to cover larger sized ContentContainer. (#2249)

- Current default value is 0.00001f and it is too small to track large scale scrolling range.
- This patch updates it to reasonable size and adds guide comment.

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years agoRevert "Modify color"
huiyu.eun [Thu, 26 Nov 2020 07:49:42 +0000 (16:49 +0900)]
Revert "Modify color"

This reverts commit 1dd79a38cfae129f7b670d80e386f95f45bbf9d0.

3 years ago[NUI] Modify comment
huiyu.eun [Thu, 26 Nov 2020 07:49:17 +0000 (16:49 +0900)]
[NUI] Modify comment

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years agoModify color
huiyu.eun [Wed, 25 Nov 2020 08:46:01 +0000 (17:46 +0900)]
Modify color

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Change setter of property
huiyu.eun [Tue, 24 Nov 2020 02:12:18 +0000 (11:12 +0900)]
[NUI] Change setter of property

- Setter is deprecated in API8.(Size/Scale/Color/Position)
- An unnecessary log comes out and causes performance degradation.

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years agoFix a security warning of FOTA script (#2302)
WonYoung Choi [Fri, 27 Nov 2020 06:47:07 +0000 (15:47 +0900)]
Fix a security warning of FOTA script (#2302)

3 years ago[NUI] Fix StyleCop warning CA2227 (#2232)
Jaehyun Cho [Thu, 26 Nov 2020 02:46:29 +0000 (11:46 +0900)]
[NUI] Fix StyleCop warning CA2227 (#2232)

To fix CA2227(Collection properties should be read only), the setters of
the collection properties are removed.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
3 years ago[NUI] Load default theme in preload
Jiyun Yang [Tue, 24 Nov 2020 03:11:31 +0000 (12:11 +0900)]
[NUI] Load default theme in preload

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] remove unused Xamarin style classes (#2184)
YeongJong Lee [Tue, 24 Nov 2020 08:54:49 +0000 (17:54 +0900)]
[NUI] remove unused Xamarin style classes (#2184)

NUI uses `Tizen.NUI.BaseComponents.ViewStyle` instead of
`Tizen.NUI.Binding.Style` which is copied from xamarin.

3 years ago[NUI] Fix StyleCop warning CA1823 (#2222)
Jaehyun Cho [Tue, 24 Nov 2020 07:56:48 +0000 (16:56 +0900)]
[NUI] Fix StyleCop warning CA1823 (#2222)

To fix CA1823(Avoid unused private fields), the unused private fields
are removed.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
3 years ago[NUI] respect flex child margin changes (#2271)
YeongJong Lee [Mon, 23 Nov 2020 11:20:22 +0000 (20:20 +0900)]
[NUI] respect flex child margin changes (#2271)

The flex child margin is only set when a flex child is added to flexlayout,
so margin changes after `View.Add` are ignored.

To respect child margin changes, This patch add code to set flex margin in
`OnMeasure`.

3 years agoRevert refactoring naming (#2274)
JoogabYun [Mon, 23 Nov 2020 08:10:38 +0000 (17:10 +0900)]
Revert refactoring naming (#2274)

* Revert "[NUI] remove "_" and refactoring naming to pascal case. (#2244)"

This reverts commit b0942517f09bb292216797a0a890121619384a21.

* Revert "[NUI] fixed build warning CA1707 (#2241)"

This reverts commit 88d78644dada8a24e14cdf2b5b724537e3ef9952.

* Revert "[NUI] fixed build warning CA1707 (#2239)"

This reverts commit be21b7e43c56b92fa64d4f0a4522f2369c3fb35d.

3 years ago[NUI] Fix build warning CA1062 (#2234)
Seoyeon2Kim [Mon, 23 Nov 2020 06:23:03 +0000 (15:23 +0900)]
[NUI] Fix build warning CA1062 (#2234)

* [NUI] Fix build warning CA1062

- Need to verify whether the argument is null
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1062

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
* [NUI] Add exception handling tag

- The <exception> tag lets you specify which exceptions can be thrown.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI] remove unnecessary code that flex margin is assigned to flexlayout (#2272)
YeongJong Lee [Mon, 23 Nov 2020 05:50:07 +0000 (14:50 +0900)]
[NUI] remove unnecessary code that flex margin is assigned to flexlayout (#2272)

Sicne the margin of FlexLayout will be handled by the parent layout,
we don't need to re-assign margin in `OnMeasure`.