Mike Blumenkrantz [Tue, 19 Jun 2018 18:35:49 +0000 (14:35 -0400)]
tests: ensure class constructor is called in eo_domain test
failing to call this prior to the thread invocation would result in a CRI
from class initialization in a thread
ref T7003
Differential Revision: https://phab.enlightenment.org/D6333
Marcel Hollerbach [Mon, 25 Jun 2018 15:00:59 +0000 (11:00 -0400)]
eo: get back the eo test suite
Summary: I accidently broke the test suite, due to missing rebuilds.
Reviewers: zmike, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6421
Marcel Hollerbach [Mon, 25 Jun 2018 10:57:08 +0000 (06:57 -0400)]
elm_web: convert the enum fields correctly, as previously done
Summary:
ensure that everything stays in the allowed and previously used ranges.
The enums that are passed here are not equivalent.
Depends on D6383
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6384
Marcel Hollerbach [Mon, 25 Jun 2018 10:56:42 +0000 (06:56 -0400)]
elm_map: convert enums correctly
Summary:
ensure that everything stays in the allowed and previously used ranges.
The enums that are passed here are not equivalent.
Depends on D6382
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6383
Marcel Hollerbach [Mon, 25 Jun 2018 10:56:09 +0000 (06:56 -0400)]
efl_ui_layout_object: fix warnings
Summary:
ensure that the signal is correctly composed.
For the case that the eina value is carrying a error, then we just error
out.
Depends on D6378
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6379
Bowon Ryu [Mon, 25 Jun 2018 10:55:57 +0000 (06:55 -0400)]
elm_slider: add null check to avoid seg fault.
Summary: a segmentation fault occurs once the argument is not valid.
Test Plan: N/A
Reviewers: eagleeye, devilhorns, zmike
Reviewed By: eagleeye, zmike
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6362
Marcel Hollerbach [Mon, 25 Jun 2018 10:50:31 +0000 (06:50 -0400)]
eo: lower from CRI to ERR
Summary:
unreffing too often is not good. However, its definitly not a critical
error. Most of the wikipedia articles (*) that are speaking about ciritcal or
fatal errors are highlighting that no reasonable recovery can be done.
In our case a recovery is not even needed, due to our pointer safety we
dont need to recover anything since the refcounting safed us from doing
something stupid.
ref T6987.
Depends on D6384
Reviewers: zmike, segfaultxavi, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6987
Differential Revision: https://phab.enlightenment.org/D6385
Hermet Park [Mon, 25 Jun 2018 10:49:49 +0000 (06:49 -0400)]
evas canvas: add exceptional case.
Summary:
parent_container should have eina_false as given null parent
in order to avoid call vg_node_changed() for parent.
Reviewers: #committers, devilhorns, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6387
Jean-Philippe Andre [Thu, 21 Jun 2018 22:51:43 +0000 (18:51 -0400)]
elm_scroll: Avoid calls to non-existing part
In case of Bryce's style, there are no scroll bars.
this avoids errors for non-existent objects
ref T7030
Signed-off-by: Mike Blumenkrantz <zmike@samsung.com>
Differential Revision: https://phab.enlightenment.org/D6317
YeongJong Lee [Mon, 25 Jun 2018 07:15:56 +0000 (16:15 +0900)]
ecore_wl2: Take a library reference on tbmsurface create
We need to call ecore_wl2_init in tbmbuf_surface_create because of this commit
0d27985677897363f148c92042ef3d3917796981
reproduction:
1. Call elm_init(0, NULL);
2. Call elm_shutdown();
3. Check that there is no CRI error message
[CRI<14619>:eina_log lib/ecore_wl2/ecore_wl2.c:238 ecore_wl2_shutdown() unknown log domain -1, original message was: ERR: 'Ecore_Wl2 shutdown called without Ecore_Wl2 Init']
or
1. In efl-test-suite, execute utc_elm_bg_add
2. Check that there is no CRI error message
Change-Id: If8ec5795109e7a87bb893bd1633ec454873b3de7
Derek Foreman [Tue, 8 May 2018 18:26:42 +0000 (13:26 -0500)]
ecore_wl2: Remove ecore_wl2_input_grab/ungrab
Summary:
These should never be called, so they shouldn't be API.
This kind of internal state fiddling should happen implicitly in the
API that need it.
@beta_break
Depends on D6126
Reviewers: zmike, cedric
Reviewed By: zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6127
Change-Id: Ifd4de43a241cfb27bf85bce8bbb0a7199565ec4b
Derek Foreman [Tue, 8 May 2018 18:26:25 +0000 (13:26 -0500)]
ee_wayland: clean up warnings
Summary:
Pretty sure these are my fault.
Depends on D6122
Reviewers: zmike, cedric
Reviewed By: zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6123
Change-Id: Iaeff36cfc00f72bc0e7a169e8c77726551a635ab
Derek Foreman [Tue, 8 May 2018 18:26:22 +0000 (13:26 -0500)]
ee_wayland: remove edges flag
Summary:
Nothing needs this anymore.
Depends on D6121
Reviewers: zmike, cedric
Reviewed By: zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6122
Change-Id: I2db879c52a27a6ecd9ad1924c47ed91232447c14
Derek Foreman [Tue, 8 May 2018 18:26:12 +0000 (13:26 -0500)]
ee_wayland_egl: Remove some amazing weirdness
Summary:
I don't even know what to put here, but I'll try.
wl_egl_window_resize()'s final two parameters indicate new attachment
points for a buffer relative to the previous top left corner. When the
compositor is resizing a window it already handles the corner placement.
Fortunately, compositors seem to ignore the new attach co-ords during
resize, so this code hasn't broken anything. It's just a complicated
NOP.
The new attachment points are intended for use in spontaneous resize,
not drag resize, but the only time these functions are called is for
drag resize.
Depends on D6119
Reviewers: zmike, cedric
Reviewed By: zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6120
Change-Id: I00722662988871502b8ee41d98ec0951b3e72451
Derek Foreman [Tue, 24 Apr 2018 20:44:09 +0000 (15:44 -0500)]
ee_wayland: Remove pointless ack_configure
If we don't ack_configure here, it'll just automatically happen in
ecore_wl2_commit() next time we render anyway.
If we do ack_configure here, we can totally screw up E's internal window
handling.
Removing it seems like a win.
Change-Id: I58b1e0a17919a7c5a3561b0db59ae2d9e4fe1384
Derek Foreman [Mon, 12 Feb 2018 20:59:09 +0000 (14:59 -0600)]
ecore_wl2: Don't do anything but update alpha in alpha_set
This is now done in ecore_evas where it should be. alpha_set now does
only what its name claims it does - sets whether a surface has an alpha
channel or not.
Change-Id: I8c6dc82404e417318d1c41e9f3d466e14cb951a7
Derek Foreman [Mon, 12 Feb 2018 20:58:01 +0000 (14:58 -0600)]
ecore_evas_wayland: Handle region updates and alpha setting in engine
Instead of having elm handle all this stuff, handle it in ee. This fixes
a loooong standing bug where we would always use an alpha enabled surface
because CSD needs shadows - even if we aren't drawing CSD.
Change-Id: Ifdbba2fe672f26ef84c54abd07fa5179c15267f0
YeongJong Lee [Mon, 25 Jun 2018 01:48:14 +0000 (10:48 +0900)]
elm_focus: fix comment range in focus_next_object_set
We can set next parameter to NULL.
reported by utc_elm_object_focus_next_object_get in efl-test-suite
@tizen_fix
Change-Id: I09c56cbb5ea1dac6eeaf572f7beb4d1671e25303
Derek Foreman [Tue, 13 Feb 2018 21:04:17 +0000 (15:04 -0600)]
wayland_egl: Fix color depth when not using alpha
Since we don't actually set the color depth at all we can end up with
an RGB565 buffer. We don't ask for depths because apparently the N900
had a problem with this under X.
I'm not aware of any efforts to bring wayland to the N900, so let's do
this normally.
Change-Id: I3c0651efe5623233f39c7d927cbce67a44fcd854
Derek Foreman [Thu, 12 Apr 2018 18:44:10 +0000 (13:44 -0500)]
ee_wayland: Stop using manual_render_set
Now we use draw_block instead, so we don't accidentally stomp on other
code's usage of manual_render_set
fix T6834
Change-Id: I073dc71d56fa56e4ab2390503a66f820a6bcfa8c
Marcel Hollerbach [Mon, 25 Jun 2018 06:02:55 +0000 (15:02 +0900)]
efl_ui_focus_graph: remove unused functions
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6378
Marcel Hollerbach [Mon, 25 Jun 2018 05:55:13 +0000 (14:55 +0900)]
eina_stringshare: cast in order to fix a warning
Summary:
casting here is safe, as before we check and return on size < 1.
Depends on D6379
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6380
Marcel Hollerbach [Mon, 25 Jun 2018 05:26:43 +0000 (14:26 +0900)]
efl_gfx_path: remove unsued function.
Summary:
the function can be regained by reverting this.
Depends on D6381
Reviewers: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6382
Marcel Hollerbach [Mon, 25 Jun 2018 05:25:52 +0000 (14:25 +0900)]
efl_gfx_path: make counters unsigned
Summary:
we are comparing to unsigned number, and the number are moving strongly
from 0 up.
Depends on D6380
Reviewers: devilhorns
Subscribers: Hermet, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6381
Mike Blumenkrantz [Mon, 25 Jun 2018 04:48:15 +0000 (13:48 +0900)]
evas_vg_node: do not propagate node changed callbacks for invalidated objects
Summary: this callback is triggered on the parent object. invalidated objects have no parent.
Reviewers: bu5hm4n, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6335
Carsten Haitzler (Rasterman) [Sun, 24 Jun 2018 02:56:52 +0000 (11:56 +0900)]
elm focus - fix focus composition prepare to not seg by unsafe list mods
efl_ui_focus_composition_prepare() methods in 2 widgets were modifying
the list (removing items) as they walked, using unsafe walking macros.
fix - use the safe variants.
Carsten Haitzler (Rasterman) [Sat, 23 Jun 2018 14:57:00 +0000 (23:57 +0900)]
elm win - fix resizing on show. rage was broken last week. this fixes it
rage window with no file passed ended up like 10x40 ... which is
wrong. it wasn't. rage code explicitly resizes the window before show
and this wsas being overriden. tested rage, terminology, em test in
both x and wl. all still work (for me) post commit.
Thierry HUCHARD [Fri, 22 Jun 2018 21:41:29 +0000 (17:41 -0400)]
ecore/main: fix build with --enable-g-main-loop
this resolves compiler errors with this option which resulted from refactoring
fix T7011
Mike Blumenkrantz [Fri, 22 Jun 2018 18:18:59 +0000 (14:18 -0400)]
ecore/glib: add #ifdef guards for newly added includes
these headers are not available on all platforms (e.g., windows) and so
the corresponding #ifdef checks must be used in order to correctly include
them
ref
1adb73cef82c45f2cc8766f43ffb88288e7e8a65
ref T5725
fix T7063
Differential Revision: https://phab.enlightenment.org/D6369
Mike Blumenkrantz [Fri, 22 Jun 2018 18:18:43 +0000 (14:18 -0400)]
evas/cpu: rework SIGILL code for non-x86 (and fix windows build)
Summary:
the previous patch which improved this code for x86 archs broke compiling
for non-x86 and, coincidentally, for windows builds on x86 due to some
unusual #ifdef blocks
this attempts to restore handling on non-x86 and adds additional #ifdefs for
functions which did not build on windows due to removed code
ref
6b1ab3cd9c7e19908690e9e913df7504cc8ae7c8
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7062
Differential Revision: https://phab.enlightenment.org/D6368
Lauro Moura [Fri, 22 Jun 2018 16:43:47 +0000 (12:43 -0400)]
tests: Use EFL_START/END_TEST in cxx tests
Summary: Will enable timing info in these tests.
Test Plan: run make check
Reviewers: zmike, felipealmeida, devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6359
Alastair Poole [Fri, 22 Jun 2018 16:41:05 +0000 (12:41 -0400)]
ecore_cocoa: explicity allocate for keyname and key
Summary:
Allocate memory for keyname and key. Also refactor
unnecessary calloc and free.
Reviewers: #committers, zmike, devilhorns
Reviewed By: zmike
Subscribers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6366
Daniel Hirt [Fri, 22 Jun 2018 09:46:40 +0000 (12:46 +0300)]
Edje: recalc edje before fetching the real part
Summary:
There are many calls to `_edje_real_part_recursive_get`. Though, it is
not guaranteed that the Edje object had instantiated all of the real
parts.
This change makes edje to always recalc before retrieving the real part.
The D6364 patch raised a good point, but presented a local fix, where
it seems that a global fix such as this is needed, instead.
The local fix is removed in favor of this. Test suite still passes.
ref T7057
@fix
Test Plan: See T7057
Reviewers: devilhorns
Subscribers: cedric, zmike, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6365
Derek Foreman [Fri, 22 Jun 2018 13:38:03 +0000 (09:38 -0400)]
genlist: Don't search for an item we know we won't find
Summary:
We track list presence already, so we can just do a boolean test instead
of an O(n) lookup.
Depends on D6349
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6350
Youngbok Shin [Fri, 22 Jun 2018 09:15:11 +0000 (12:15 +0300)]
edje: fix text set/get issue without edje calculation
Summary:
Some changes broke really basical function behavior of text.
I couldn't get text from an edje object which I just set to the given edje object.
In the past code, edje called recalc function before trying to get text.
So, this patch bring that code to fix this issue.
@fix
Test Plan: Included. Run "make check"
Reviewers: herdsman, raster, cedric, woohyun, devilhorns
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6364
Derek Foreman [Thu, 21 Jun 2018 17:39:15 +0000 (12:39 -0500)]
efl_ui_focus_manager: track list presence
By keeping track of whether a node is on the dirty list or not we can
save ourself list walks trying to remove items that aren't present.
Differential Revision: https://phab.enlightenment.org/D6349
Signed-off-by: Derek Foreman <derekf@osg.samsung.com>
Alastair Poole [Fri, 22 Jun 2018 08:11:32 +0000 (09:11 +0100)]
efl_ui_widget: silence warnings with clang.
Clang doesn't like dangling else.
Alastair Poole [Fri, 22 Jun 2018 06:16:50 +0000 (07:16 +0100)]
efreet: silent deprecated API build warnings.
Silent warnings on EFL build. Warn on API "mis-use".
Carsten Haitzler (Rasterman) [Fri, 22 Jun 2018 00:29:21 +0000 (09:29 +0900)]
Revert "Revert "eina debug - fix segv if an app is compiled with -pg for profiling""
This reverts commit
0d91088d0fe00ab64e1e852551e850d403e9db37.
It also includes a workaround for OSX where RT signals aren't
supported due to kernel age (too old a fork of freebsd). fixes D6310
and T7029
Lauro Moura [Thu, 21 Jun 2018 22:36:35 +0000 (18:36 -0400)]
eldbux-cxx: Remove test accessing system bus.
Summary: Tests should use session bus only.
Reviewers: zmike, felipealmeida, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6351
Mike Blumenkrantz [Thu, 21 Jun 2018 21:44:34 +0000 (17:44 -0400)]
eina_debug_bt: add ifdef for windows build
Summary: ref D7028
Reviewers: vtorri, devilhorns
Reviewed By: vtorri
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6348
Derek Foreman [Thu, 12 Apr 2018 18:42:12 +0000 (13:42 -0500)]
ecore_evas: Make draw_block block drawing
This was only used in the X custom render function, now it's meaningful
everywhere. (Nothing that uses this code path currently sets it)
ref T6834
Change-Id: Icff5151235ea160931fe75e2ed7a75146c50dc81
Derek Foreman [Thu, 12 Apr 2018 18:39:29 +0000 (13:39 -0500)]
ee_x: Rename draw_ok to draw_block and invert logic
I want to use this in other engines, but no other engine initializes this
properly, so draw_ok would be EINA_FALSE everywhere. This way draw_block
is EINA_FALSE after calloc in all engines that don't know about it.
ref T6834
Change-Id: I0c499ebc940b05e436941cb2b7d7bce6d0d35ac5
Derek Foreman [Thu, 12 Apr 2018 18:33:53 +0000 (13:33 -0500)]
efl_ui_win: Always show the wayland pointer
It's hidden by the compositor as required, so this just makes life much
more complicated in other code.
ref T6834
Change-Id: Ib40f9fd189edea084acdf99b18436adc5ce2f3e5
Derek Foreman [Thu, 12 Apr 2018 18:40:24 +0000 (13:40 -0500)]
ee_wayland: Remove use of draw_ok
This appears vestigial, as the evas render path we use has no custom
draw_ok handling, so nothing ever reads this variable.
ref T6834
Change-Id: I8c8aef946e4cc6a7d097b1ad954777beae274e02
Derek Foreman [Thu, 12 Apr 2018 18:27:17 +0000 (13:27 -0500)]
ee_cocoa: Remove draw_ok sets
draw_ok isn't currently used by anything but the X custom render function,
so it's doing absolutely nothing here.
ref T6834
Change-Id: Ibc68e65d147ce2b255683b5aac3342e4e583a7a3
Derek Foreman [Thu, 8 Mar 2018 19:46:42 +0000 (13:46 -0600)]
gl_common: Make extension string checks more robust
strstr() can give false positives if the extension name is a subset of
a string in the extension list, for example EGL_EXT_image_dma_buf_import
would match EGL_EXT_image_dma_buf_import_modifiers.
I've opted for a mildly badgered copy of epoxy's test, which should be
robust in the face of subsets.
Change-Id: Ie2b0a4045795c9b11d5b526ce135bfb7ed7ee218
Derek Foreman [Thu, 8 Mar 2018 19:33:32 +0000 (13:33 -0600)]
gl_common: Replace strstr() for extension checks with a helper function
The helper incorporates NULL checks, and we love those, so it's better.
Change-Id: I9fb9b17f7f325fe58a563138acb4de14857500c6
Mike Blumenkrantz [Fri, 23 Feb 2018 19:17:54 +0000 (14:17 -0500)]
elm_win: disable handling of auto_norender_withdrawn for fake wins
these wins are not to be trifled with.
fix T6377
Daniel Hirt [Fri, 22 Jun 2018 09:46:40 +0000 (12:46 +0300)]
Edje: recalc edje before fetching the real part
Summary:
There are many calls to `_edje_real_part_recursive_get`. Though, it is
not guaranteed that the Edje object had instantiated all of the real
parts.
This change makes edje to always recalc before retrieving the real part.
The D6364 patch raised a good point, but presented a local fix, where
it seems that a global fix such as this is needed, instead.
The local fix is removed in favor of this. Test suite still passes.
ref T7057
@fix
Test Plan: See T7057
Reviewers: devilhorns
Subscribers: cedric, zmike, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6365
Change-Id: I7defe4441a87a485070082903153d0f34767bcf5
Youngbok Shin [Fri, 22 Jun 2018 09:15:11 +0000 (12:15 +0300)]
edje: fix text set/get issue without edje calculation
Summary:
Some changes broke really basical function behavior of text.
I couldn't get text from an edje object which I just set to the given edje object.
In the past code, edje called recalc function before trying to get text.
So, this patch bring that code to fix this issue.
@fix
Test Plan: Included. Run "make check"
Reviewers: herdsman, raster, cedric, woohyun, devilhorns
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6364
Change-Id: I51af5389755d5f2f6dfb66ddf55e097c2a239e38
Wonki Kim [Thu, 21 Jun 2018 07:16:10 +0000 (16:16 +0900)]
Revert "efl_ui_win: add missing wayland interface for setting role of winodw"
This reverts commit
a8ebaee4149c91b7d8f5473d5a5f463b1ac39c90.
Change-Id: Iebe9c4078d8e71d88f9649067098cbcafdcde2c1
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Xavi Artigas [Thu, 21 Jun 2018 11:10:56 +0000 (13:10 +0200)]
eo_debug: Fix segfault when parsing EO_LIFECYCLE_DEBUG envvar
Summary:
The 'if' block should only be executed when the string contains the colon and
something else behind, but sscanf cannot be used in this case.
If the string contained no colon, the following line with strchr(s, ':')
returns NULL and everything explodes.
Test Plan: eo_debug -l now works for me without segfaulting.
Reviewers: bu5hm4n, zmike, devilhorns, q66
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6347
Chris Michael [Thu, 21 Jun 2018 14:14:18 +0000 (10:14 -0400)]
efl: Bump required libinput version for Elput
Since commit 7a7abb, LIBINPUT_EVENT_SWITCH_TOGGLE was introduced to
Elput, however this enum did not get released into libinput until 1.7
so we need to require updated libinput now in our configure.ac
@fix
Alastair Poole [Thu, 21 Jun 2018 13:58:25 +0000 (14:58 +0100)]
ecore_cocoa_cnp: Check for nil object before adding.
This is fixing a segfault. More work needs to be done in
efl_selection_manager.c. Current status is broken.
Alastair Poole [Thu, 21 Jun 2018 12:34:20 +0000 (13:34 +0100)]
ecore_cocoa: fix ECORE_EVENT_KEY_DOWN/UP on MacOS.
Fixing issue with modifier keys on MacOS. These events were missing
window information. Tested with Fyne.io. Window ID and keyname
are valid. See: http://bogosys.org/images/fyne_OSX.png. Thanks
zmike for initial investigation.
@fix T6944
Daniel Kolesa [Thu, 21 Jun 2018 12:09:59 +0000 (14:09 +0200)]
efl: include sys/types.h where ssize_t is used
This include is necessary according to POSIX. Without it, build
fails on certain platforms (QNX). It may already be included
implicitly in some of those files, but declare intent.
Fixes T6667.
Hermet Park [Thu, 21 Jun 2018 10:15:47 +0000 (19:15 +0900)]
Revert "edje: code refactoring for readibility."
This reverts commit
7fb47fc064b8f429242b4d5cdf57071475087821.
subsequential revert for previous one.
90a89d1ab2b5d23b29ad0f2680b77b5ba7f56b42.
Hermet Park [Thu, 21 Jun 2018 10:12:53 +0000 (19:12 +0900)]
Revert "edje: fix a regression error by
7fb47fc064b8f429242b4d5cdf57071475087821."
This reverts commit
475c93fd7599badad0c073e5eb025b92481b53ec.
long time after touch,
forgot that eet data has key-data pairing structure.
this change would break theme compatibility.
Thanks bu5hm4n for pointing out this.
Alastair Poole [Thu, 21 Jun 2018 09:22:08 +0000 (10:22 +0100)]
ecore_con: do proper version test for TLS_method.
Marcel Hollerbach [Thu, 21 Jun 2018 05:53:36 +0000 (14:53 +0900)]
efl_ui_navigation_bar: less warnings
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6344
Marcel Hollerbach [Thu, 21 Jun 2018 05:52:29 +0000 (14:52 +0900)]
efl_ui_focus_manager_calc: fix warnings
Summary: its a false positive...
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6342
SangHyeon Lee [Thu, 21 Jun 2018 05:09:06 +0000 (14:09 +0900)]
elm_gengrid : fix gengrid cached items disapearing issue by wrong reference counting
gengrid item view is managed by cache while scrolling,
but efl_wref_add/del and VIEW_ADD is not paired well.
this commit is fixing the issue of item dispearing when it scrolls.
Change-Id: I28c08f12bbb0d2a098bcceea107c6a0993c220d7
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Marcel Hollerbach [Thu, 21 Jun 2018 03:56:07 +0000 (12:56 +0900)]
efl_ui_widget_focus_manager: less warnings
Summary: fix T7050
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T7050
Differential Revision: https://phab.enlightenment.org/D6341
SangHyeon Lee [Thu, 21 Jun 2018 05:13:21 +0000 (14:13 +0900)]
elm_gengrid : fix gengrid cached items disapearing issue by wrong reference counting
this patch is porting from upstream.
Change-Id: Iee1af82ca1a121433015f2b84abdd43ce9e25337
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Gwanglim Lee [Tue, 19 Jun 2018 13:26:11 +0000 (22:26 +0900)]
efl_ui_win: add missing wayland interface for setting role of winodw
@tizen_fix
Change-Id: I359bc4589260ffaabfae5b75e18e499c1dd2d282
Mike Blumenkrantz [Wed, 20 Jun 2018 16:33:01 +0000 (11:33 -0500)]
elm_colorselector: fix improperly named API theme parts
Summary:
API parts require namespacing, these parts have been namespaced with
compatibility code added to handle legacy naming
Reviewers: cedric, Hermet, devilhorns, stephenmhouston
Subscribers: segfaultxavi, Hermet, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6213
Daniel Hirt [Wed, 20 Jun 2018 16:24:05 +0000 (19:24 +0300)]
Edje load: add safecheck for TEXTBLOCK-specific code path
There is a specific TEXTBLOCK part code path that shouldn't be taken
for other parts.
@fixes T6279
Marcel Hollerbach [Wed, 20 Jun 2018 16:24:06 +0000 (12:24 -0400)]
elm: refactor do not call efl_data_scope_get on a object without data
Summary:
A call to efl_data_Scope_get is actually quite dangerous,
efl_data_scope_get will return a pointer to a 0 sized segment in memory,
this is happening based on how the class data is organized. So in theory
you could use this pointer and accidently write to it. This resolves
this issue.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6337
Alastair Poole [Wed, 20 Jun 2018 14:24:02 +0000 (15:24 +0100)]
ecore_con: FreeBSD 11.2 not providing TLS generic methods.
On some systems the TLS_client/server_method() is not available.
Using fallback. In time as openssl changes propagate this really
shouldn't be necessary.
Alastair Poole [Wed, 20 Jun 2018 13:11:52 +0000 (14:11 +0100)]
Patch for T6342
Summary: Deprecate SSLv3.
Reviewers: zmike, raster, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6334
Shinwoo Kim [Tue, 19 Jun 2018 06:55:37 +0000 (15:55 +0900)]
ecore_wl2_display: remove infinite loop possibility
The wl_display_dispatch_pending returns -1 on failure.
This could make infinite loop in _ecore_wl_cb_pre_handle_data.
Change-Id: I1730e6007fd08db308be4412f0a8c9f51d7f3726
Bowon Ryu [Mon, 18 Jun 2018 11:29:57 +0000 (20:29 +0900)]
elm_toolbar: fix icon sizing issue
icon size * scale - this causes the issue.
this is not wrong,
but Tizen UX did not consider scale to icon size.
so, this is removed for compatibility.
@tizen_fix
Change-Id: Ib71ec1998767988bc7ad39299c3282132f8a0fd5
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Mike Blumenkrantz [Tue, 19 Jun 2018 18:08:08 +0000 (14:08 -0400)]
tests: remove eldbus special casing from checks to enable parallel test runs
Summary:
now that eldbus tests can safely run in parallel there is no reason to
prevent them from doing so
fix T6848
Depends on D6204
Reviewers: stefan_schmidt, cedric, ManMower, devilhorns
Reviewed By: cedric, ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6205
Mike Blumenkrantz [Tue, 19 Jun 2018 18:08:20 +0000 (14:08 -0400)]
tests: use unique dbus bus names for each eldbus test case fixture
Summary:
dbus bus names are unique and cannot be acquired by multiple connections
simultaneously; by making this per-file unique, this part of the test can
run in parallel without bus collisions
ref T6848
Depends on D6201
Reviewers: stefan_schmidt, cedric, bu5hm4n, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: ManMower, cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6202
Mike Blumenkrantz [Tue, 19 Jun 2018 18:04:45 +0000 (14:04 -0400)]
eina_debug_bt: only enable SIGPROF handler when profiling is enabled
Summary:
if profiling is not enabled then reaching this signal handler will always
result in a crash
moreover, the signal handler has no functional value if profiling is not active,
so do not add it until that point
fix T7028
@fix
Depends on D6311
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7028
Differential Revision: https://phab.enlightenment.org/D6312
Mike Blumenkrantz [Tue, 19 Jun 2018 18:04:40 +0000 (14:04 -0400)]
tests: add test for eina_debug signal handling
Summary:
currently this crashes, so add a simple test to ensure that it works
eventually
ref T7028
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7028
Differential Revision: https://phab.enlightenment.org/D6311
Mike Blumenkrantz [Tue, 19 Jun 2018 17:54:16 +0000 (13:54 -0400)]
ecore: call eina_debug_fork_reset() in fork reset function
Summary:
ensure that this occurs as expected when forks happen
note that this is already being actively tested in the elm unit tests
Depends on D6307
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6308
Mike Blumenkrantz [Fri, 15 Jun 2018 20:56:06 +0000 (16:56 -0400)]
eina_debug: add function to reset debug subsystem after fork
fork() kills this entire subsystem and leaves its internals
in an inactive but allocated state, so it's necessary to explicitly restart
everything in order to guarantee behavior
@feature
Differential Revision: https://phab.enlightenment.org/D6307
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6306
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug_cpu: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6305
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug_timer: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6304
Mike Blumenkrantz [Fri, 15 Jun 2018 20:43:39 +0000 (16:43 -0400)]
eina: prevent threads subcomponent from being shutdown while eina is active
this basically breaks all thread usage if it happens, so ensure that the
threads infrastructure stays active for as long as eina is active
@fix
Differential Revision: https://phab.enlightenment.org/D6303
Mike Blumenkrantz [Fri, 15 Jun 2018 20:42:29 +0000 (16:42 -0400)]
eina: call eina_threads_init from eina_debug_init
eina is guaranteed to crash in any process without this call now that
eina_debug exists and requires threads
@fix
Differential Revision: https://phab.enlightenment.org/D6302
Mike Blumenkrantz [Fri, 15 Jun 2018 20:40:23 +0000 (16:40 -0400)]
eina: don't init subcomponents inside eina_debug
this should be done in a single location to avoid dependency conflicts
and make the code easier to read
Differential Revision: https://phab.enlightenment.org/D6301
Mike Blumenkrantz [Tue, 19 Jun 2018 17:42:16 +0000 (13:42 -0400)]
eo: CRI when class constructor or destructor is called from thread
Summary:
calling the constructor and deconstructor from different threads
causes issues with mempool deallocation, so ensure that the class is
always initialized in the main thread for safety, e.g., call the
SOME_NAMED_CLASS macro during init to instantiate the class
fix T7003
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7003
Differential Revision: https://phab.enlightenment.org/D6332
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:44 +0000 (13:41 -0400)]
elm_list: return from sizing_eval immediately if called during constructor
Summary:
this is both invalid and useless, so return immediately before spending cpu
time and generating error messages
fix T7035
Depends on D6324
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7035
Differential Revision: https://phab.enlightenment.org/D6325
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:16 +0000 (13:41 -0400)]
elm_colorselector: avoid calling functions with null objects
Summary:
a number of calls during construction resulted in null object errors here
fix T7036
Depends on D6323
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7036
Differential Revision: https://phab.enlightenment.org/D6324
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:02 +0000 (13:41 -0400)]
elm_colorselector: avoid passing null to efl functions
Summary:
this check already existed in the function but was not applied to the
entire function
ref T7030
Depends on D6322
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6323
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:52 +0000 (13:40 -0400)]
evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
Summary:
this requires the parent of the deleted object to be reachable, so use the
invalidate callback as this is the last point during which it's possible to
retrieve a parent object
ref T7030
Depends on D6320
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6321
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:43 +0000 (13:40 -0400)]
efl_ui_win: check frame_obj existence before operating on it in pre_render
Summary:
this object will not exist for fake win objects, e.g., in enlightenment
fix T7033
Depends on D6319
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7033
Differential Revision: https://phab.enlightenment.org/D6320
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:27 +0000 (13:40 -0400)]
efl_ui_win: do not attempt to focus a null object on focus-in
Summary:
ref T7033
Depends on D6318
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7033
Differential Revision: https://phab.enlightenment.org/D6319
Marcel Hollerbach [Tue, 19 Jun 2018 17:36:04 +0000 (13:36 -0400)]
eo: make the debug build print leaked errors
Summary: Depends on D6328
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6329
Marcel Hollerbach [Tue, 19 Jun 2018 17:35:53 +0000 (13:35 -0400)]
eo: get rid of eo_id
Summary:
build with this disabled is just not working as the thread model of eo
falls apart. The threadmodel is required to have eo_id, as it decoded
the thread information in the eo_id, which is not working without eo_id.
This also fixes the testcases that have never been executed due to the
fact of the missing HAVE_EO_ID
fix T6610
Depends on D6327
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6610
Differential Revision: https://phab.enlightenment.org/D6328
Marcel Hollerbach [Tue, 19 Jun 2018 17:35:38 +0000 (13:35 -0400)]
eo: only call efl_parent_set when parent_id is available
Summary:
this is no functinal change, we safe the calling to efl_parent_set.
Nothing else, the base implementation is initializated with NULL as
parent, and efl_parent_set with NULL would have returned in the first
few lines.
fix T7032
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7032
Differential Revision: https://phab.enlightenment.org/D6327
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:30 +0000 (13:33 -0400)]
tests: set monitoring interval for eio tests to 0.05s
Summary:
cpu usage is not an issue during test runs, we want the tests to finish
as fast as possible in all cases regardless of the cost. this resolves
the last remaining issue with eio tests where sometimes the fallback
monitor would trigger and the test suite would hang for 60+ seconds
fix T6915
Depends on D6248
Reviewers: stefan_schmidt, bu5hm4n, ManMower, devilhorns
Reviewed By: bu5hm4n, ManMower
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl
Maniphest Tasks: T6915
Differential Revision: https://phab.enlightenment.org/D6249
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:19 +0000 (13:33 -0400)]
tests: use fixtures for eio tests
Summary:
remove a lot of duplicated code and make this test suite read more like
all the other suites
fix T6813
Depends on D6247
Reviewers: stefan_schmidt, bu5hm4n, ManMower, devilhorns
Reviewed By: bu5hm4n, ManMower
Subscribers: Hermet, bu5hm4n, cedric, #committers
Tags: #efl
Maniphest Tasks: T6813
Differential Revision: https://phab.enlightenment.org/D6248
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:14 +0000 (13:33 -0400)]
eio: add method for setting the global file polling rate for fallback monitors
Summary:
the default value for the fallback poll monitor timer interval is 60.0 seconds,
which is not useful for all cases, such as CI, where we don't care about cpu
usage and just want things to process as fast as possible at all times
this enables setting the interval to any value, ensuring that any existing
timers are modified to use that value immediately
@feature
Reviewers: stefan_schmidt, bu5hm4n, raster, devilhorns, ManMower
Reviewed By: bu5hm4n, ManMower
Subscribers: ManMower, raster, bu5hm4n, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6247
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:44 +0000 (13:30 -0400)]
eina_threadqueue: add locking for variable used between threads
Summary:
the 'first' member of this struct is used simultaneously across
threads and can have conflicting read/write operations occurring at this
time
as int operations are not guaranteed to be atomic, ensure that we are
using atomic operations or locking as necessary
@fix
Depends on D6299
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6300
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:36 +0000 (13:30 -0400)]
eina_threadqueue: simplify/unify some locking code
Summary:
this moves lock calls outside #ifdef blocks to make the code more
readable
no functional changes
Depends on D6298
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6299