platform/upstream/xamarin-forms.git
7 years agoFix Label.LineBreakMode
Kangho Hur [Fri, 6 Jan 2017 02:01:27 +0000 (11:01 +0900)]
Fix Label.LineBreakMode

TASK=TCAPI-2182

- Head/Middle/TailTruncation are working fine.

Change-Id: I9f3b2381d22c3c50063a668fcc3569fdc7e2f751

7 years agoApply %dotnet rpm macros
WonYoung Choi [Fri, 6 Jan 2017 01:09:00 +0000 (10:09 +0900)]
Apply %dotnet rpm macros

Change-Id: Ib9cf095ef710a65e6f5e219e83d0adab830edf8f

7 years agoTizen Extension for ProgressBar
SungHyun Min [Mon, 12 Dec 2016 03:02:40 +0000 (12:02 +0900)]
Tizen Extension for ProgressBar

 - Add Set/GetPendingMode methods
 - Add Set/GetPulsingStatus methods

Change-Id: Id59b4b2a848035e3a6f414572c2e411c0fd98767
Signed-off-by: SungHyun Min <shyun.min@samsung.com>
7 years agoUpdate version to 2.3.3.175-b02
Kangho Hur [Thu, 5 Jan 2017 06:14:10 +0000 (15:14 +0900)]
Update version to 2.3.3.175-b02

Change-Id: I47c4305606b19d43505d1307e3afd21b99a72cd2

7 years ago[PickerRenderer] Remove unnecessary listener
Pawel Andruszkiewicz [Tue, 3 Jan 2017 13:58:12 +0000 (14:58 +0100)]
[PickerRenderer] Remove unnecessary listener

Change-Id: I4c146c9e7594c48f3310588035427a622ef2460f
Signed-off-by: Pawel Andruszkiewicz <p.andruszkie@samsung.com>
7 years agoSupport Density Independent Pixel on FontSize
Seungkeun Lee [Wed, 4 Jan 2017 05:01:48 +0000 (14:01 +0900)]
Support Density Independent Pixel on FontSize

 - FontSize on Span was use DP unit

Change-Id: I1a0a50dbeae3ede0c61a67f60f7238631684537d

7 years agoImplement Reusable ViewCell
Seungkeun Lee [Wed, 21 Dec 2016 00:55:45 +0000 (09:55 +0900)]
Implement Reusable ViewCell

 - Reusable feature was applied when HasUneventRows is false and the ItemTemplate is not created from the DataTEmplateSelector
 - It means all items has same looks

Change-Id: Iadc1262ff4dcf001b1c767fb479851efa6632c44

7 years agoFixed NavigationPage.BarBackgroundColor Property
chungryeol lim [Mon, 19 Dec 2016 04:22:27 +0000 (13:22 +0900)]
Fixed NavigationPage.BarBackgroundColor Property

- Apply whole area "BarBackgroundColor"
- Property values for page push & pop

Signed-off-by: chungryeol lim <cdark.lim@samsung.com>
Change-Id: I8082be5d57cbea2b3a5b9a1cc533429d080b50c6

7 years agoInitialize DeviceInfo with system information
Pawel Andruszkiewicz [Tue, 3 Jan 2017 08:46:09 +0000 (09:46 +0100)]
Initialize DeviceInfo with system information

Change-Id: Ia70b9ffec0f54b3d0440e448dfae41bc22c546c1
Signed-off-by: Pawel Andruszkiewicz <p.andruszkie@samsung.com>
7 years agoChange platform class access modifier
chungryeol lim [Mon, 2 Jan 2017 08:02:13 +0000 (17:02 +0900)]
Change platform class access modifier

- Requires GetRenderer in custom renderer implementation.
- Other platforms (iOS, Android, UWP) are also open to the public.

Change-Id: I9beb45b63b91ee11b910fe486ec99e124c8ac793
Signed-off-by: chungryeol lim <cdark.lim@samsung.com>
7 years agoIgnore TableView.SectionTitle if title is not set
Kangho Hur [Thu, 29 Dec 2016 00:42:37 +0000 (09:42 +0900)]
Ignore TableView.SectionTitle if title is not set

Change-Id: If62b127517d7ca3be8cd979ec2ec7a875a91658e

7 years agoRemove ColorExtensions.ToNative() debug message
Kangho Hur [Thu, 29 Dec 2016 00:33:08 +0000 (09:33 +0900)]
Remove ColorExtensions.ToNative() debug message

Change-Id: I2d9b834a6bef518b7898bcc570cff67a929e0c60

7 years agoApply initial value of Cell.IsEnabled
Seungkeun Lee [Tue, 27 Dec 2016 00:50:52 +0000 (09:50 +0900)]
Apply initial value of Cell.IsEnabled

 - Cell.IsEnabled was false when listview was created, this value was not applied to listview

Change-Id: I1ddc23c440189c5bcca762194b9c91c80bc1c8a6

7 years agoimplement ExpressionSearch for RelativeLayout.FromExpression
chungryeol lim [Mon, 26 Dec 2016 09:50:44 +0000 (18:50 +0900)]
implement ExpressionSearch for RelativeLayout.FromExpression

Change-Id: Id2fdeea22736d08844d8552015dbb895ae2fa28a
Signed-off-by: chungryeol lim <cdark.lim@samsung.com>
7 years agoFix Scrolling to Specific Element in ScrollView
jh5.cho [Mon, 26 Dec 2016 08:06:19 +0000 (17:06 +0900)]
Fix Scrolling to Specific Element in ScrollView

    - Add the calculation code for getting coordination of given Element
      : ScrollToAsync() which has Element parameter did not work.
        It always scroll to (0,0) because there were no calculation code for Element.

TASK=TCAPI-2174

Change-Id: I6f3fbdbd060b1c74bc89c25e7e46d99cf10fbf51

7 years agoFix TabbedPageRenderer's toolbar height
Kangho Hur [Mon, 26 Dec 2016 00:17:33 +0000 (09:17 +0900)]
Fix TabbedPageRenderer's toolbar height

- Applying the ElmSharp.Toolbar bug patch . We don't need to calculate the ratio of toolbar height anymore.

Change-Id: Ib286297e3123e1cf344a01f06b8472341ca12598

7 years agoHomogenous mode should be set to false if grouping is enabled
Pawel Andruszkiewicz [Wed, 21 Dec 2016 07:28:05 +0000 (08:28 +0100)]
Homogenous mode should be set to false if grouping is enabled

Change-Id: I01327d4c0be6847445c4711d5c4cb6f60f3ba6a9
Signed-off-by: Pawel Andruszkiewicz <p.andruszkie@samsung.com>
7 years agoUnregister ScrollRequestHandler when the renderer is being destroyed
JongHeon Choi [Tue, 20 Dec 2016 08:16:41 +0000 (17:16 +0900)]
Unregister ScrollRequestHandler when the renderer is being destroyed

Change-Id: Iae05a147f16932b27bb08ac3d3bdf016040af5c6

7 years agoChange Text HorizontalTextAlignment of TitleBar to Center
Seungkeun Lee [Wed, 21 Dec 2016 04:53:55 +0000 (13:53 +0900)]
Change Text HorizontalTextAlignment of TitleBar to Center

 - Left alignmented text was side effect of Span
 - In Tizen, it was originally center alignment

Change-Id: I6daebf987d614731bfa35ec1f0cc52398550c140

7 years agoRefactoring EntryCell SwitchCell renderer with Reusable feature
Seungkeun Lee [Mon, 19 Dec 2016 06:08:48 +0000 (15:08 +0900)]
Refactoring EntryCell SwitchCell renderer with Reusable feature

 - Use Xamarin.Forms element to make Cell contents
 - Replace OnCellPropertyChanged code with binding feature
 - Implement Reusable cell feature

 - It need updated ElmSharp, beta-002 on nuget.org will be not working
 - Reusable feature of ElmSharp was submited with submit/tizen/20161214.052838 tag

Change-Id: I6d26259cae0da59c1476f5c5698d803ee3c5519f

7 years agoRemove horizontalPadding for Label to measure its width correctly
Kangho Hur [Mon, 19 Dec 2016 05:10:29 +0000 (14:10 +0900)]
Remove horizontalPadding for Label to measure its width correctly

Change-Id: I6b09e9dbb1996eef4751b13973145df72602fb2e

7 years agoFix TextCell text color bug
Seungkeun Lee [Mon, 19 Dec 2016 00:18:31 +0000 (09:18 +0900)]
Fix TextCell text color bug

 - Remove predefined default color in CellRenderers
 - handle Color.Default in Span

Change-Id: I901f93c4b9d929b9d3e646ae29a5a3fb81237152

7 years agoAdd Tizen backend renderer
Kangho Hur [Fri, 16 Dec 2016 02:00:07 +0000 (11:00 +0900)]
Add Tizen backend renderer

- Xamarin.Forms.Platform.Tizen has been added
- Xamarin.Forms.Maps.Tizen has been added
- RPM build spec has been added

Change-Id: I0021e0f040d97345affc87512ee0f6ce437f4e6d

7 years ago[Core] Added RootPage to NavigationPage (#464)
adrianknight89 [Thu, 2 Feb 2017 15:35:23 +0000 (09:35 -0600)]
[Core] Added RootPage to NavigationPage (#464)

* d

* removed whitespace

* Using ArgumentNullException

* changes

7 years ago[All] Basic Accessibility Support (#713)
Samantha Houts [Tue, 31 Jan 2017 19:49:15 +0000 (11:49 -0800)]
[All] Basic Accessibility Support (#713)

* [Core] Add accessibility properties

* [Controls] Add accessibility gallery

* [iOS] Implement accessibility properties

* [Android] Implement accessibilty properties

* [Win] Implement accessibility properties

* [Win] Select ListView item on selected for a11y

* Update docs

* TODO: macOS accessibility

* [iOS] Fix failing UI Tests

7 years agoMake WinRT/UWP platform classes more maintainable (#652)
E.Z. Hart [Sat, 28 Jan 2017 00:14:21 +0000 (17:14 -0700)]
Make WinRT/UWP platform classes more maintainable (#652)

* Split Platform.cs into partial classes

* Split the NavigationPageRenderer into partial classes for easier maintenance

* Simplify GetCommandBarAsync, remove unneeded comments

* Correct broken GetCommandBarAsync method

* Fix OSX build

7 years agoMacOS (#650)
Rui Marinho [Thu, 26 Jan 2017 15:33:15 +0000 (15:33 +0000)]
MacOS (#650)

* [MacOS] Add SwitchRenderer

* [MacOS] Add TimePickerRenderer

* [MacOS] Cleanup TimePcikerRender

* [MacOS] Add WebViewRenderer

* [MacOS] Add Javascript evaluate to webview

* [MacOS] Fix build error on WebViewRenderer

* [MacOS] Add Base and TextCell renderers

* [MacOS] Start on ListViewRenderer

* [MacOS] Cleanup

* [MacOS] Vertical center text on default NSTextField

* [MacOS] Center NSTextField vertically

* [MacOS] Add ImageCellRenderer

* [MacOS] Add SwitchCellRenderer

* [MacOS] Add SwitchCellRenderer

* [iOS] Allow to set background color on other CellRenderers

* [MacOS] Fix selection mode on ListView

* [MacOS] Set background on Entry of entry cell

* [MacOS] Fix casting bug on CellRenderer

* [MacOS] Other fix on CellRenderer background

* [MacOS] Add ViewCellRenderer

* [MacOS] Fixes and cleanup on cells

* [MacOS] Add NSScrollView so NSTableView can scroll

* [MacOS] Add HeaderView to ListView

* [MacOS] Cleanup

* [Controls] Add Header support to ListView

* [MacOS] NSView reuse on NSTableView

* [MacOS] Some fix on layour order

* [MacOS] Add CarouselPageRenderer

* [MacOS] Implement EventTracker on PageRenderer

* [MacOS] Cleanup CarouselPageRenderer

* [MacOS] Add MasterDetailPage renderer

* [MacOS] MDP renderer don't allow drag of splitter

* [MacOS] Add TabbedPage renderer

* [MacOS] Initial sketch of NavigationPageRenderer

* [MacOS] Send disappearing of CurrentPage on Dispose on NavigationPageRenderer

* [MacOS] Add Gallery page for Mac

* [MacOS] Add MacOSExpressionSearch

* [MacOS] Fix ColorExtension

* [MacOS] Fix MDP renderer layout

* [MacOS] Implement native selection on ListViewRenderer

* [MacOS] Deselect a item on NSTableView

* [MacOS] Remove previous SplitViewItems

* [MacOS] Fix navigationpage height

* [MacOS] Add toolbar for NavigationPageRenderer

* [MacOS] Don't remove selection for now (crashing)

* [MacOS] Refactor page and back button title on NavigationPageRenderer

* [MacOS] Fix bug when native navigate back

* [MacOS] Hide layer when transition

* [MacOS] ListviewRenderer fix BbackgroundColor

* [MacOS] Fix background on ScrollViewRenderer

* [MacOS] Fix header measure on ListViewRenderer

* [MacOS] Add Mac twitter demo

* [Controls] Spaces for easy reading

* [MacOS] More xaml cleanup

* [Core] Add Mac as aTargetPlatform

* [MacOS] Add alerts and actionsheets

* [MacOS] Add GestureRecognizers

* [MacOS] Fix Layout issues when adding children, enable transformations

* [MacOS] Fix title on tab item, move to tabbed navigation based on segmented control

* [MacOS] Hide toolbar when not needed, this allows to work with tabbed page, cleanup

* [MacOS] Add NativeBindings and NativeViewWrapper

* [MacOS] Fix AssemblyInfo

* [MacOS] FIX NRE on SetBackgroundColor BoxView

* [MacOS] Fix NavigationPageRenderer

* [MacOS] Fix build

* [MacOS] Also update page when it resizes

* [MacOS] Add LayoutRenderer for handle items position when the bounds change.

* [MacOS] Refactor/Cleanup

* [MacOS] Add toolbar items support to NavigationPage

* [MacOS] Resize images for TabViewITems

* [MacOS] Fix TabbedPage resize issues , allow users to override some features when creating TVI

* [MacOS] Fix hide/show Navigation toolbar

* [MacOS] Redo CarouselPageRenderer with NSPageController

* [MacOS] Add support for Modal pages

* [MacOS] Refactor navigation from platform

* [Nuget] Add nuget for MacOS

* [Nuget]Fix nuspec

* [Nuget] Add variables for CI

* [Controls] Remove MainMenu from MacOS

* [MacOS] Add TableView renderer (no headers yet)

* [MacOS] Refactoring, marking extensions as internal

* [MacOS] Add group headers for TableViewRenderer

* [MacOS] Workaround for updates on listview collection

* [MacOS] Handle updates of rows in the ListViewRenderer properly

* [MacOS] Fix navigation animation

* Fix navigation header issues with modal pages

* [MacOS] Fix MDP issues with resizing

* [MacOS] Fix general dispose

* [MacOS] Add a ViewControllerWrapper for NSSplitView

* [MacOS] MDP renderer fix animation

* [MacOS] Fix ListView selection bug

* [MacOS] Fix rendering MDP Layout inside wrappers

* [MacOS] Re write the MainToolbar handler

* [MacOS] Don't use Sierra new extensions so we can run in stable channel

* [MacOS] Another way to hide the toolbar (smarter i think)

* [MacOS] Fix MDP bug and remove debug color

* [Controls] Add HanselForms sample

* [MacOS] Fix NRE WebviewRenderer

* [MacOS] Fix uneven rows on ListView renderer

* [MacOS] Fix NRE on load (can+t find the reason this happens)

* [MacOS] Fix uneven rows

* [MacOS] Fix header sizing on ListViewRenderer

* [Controls] More stuff on HanselForms

* [MacOS] Remove warning from ListViewRenderer

* [MacOS] Fix PageRenderer bug double init

* [MacOS] Don't calculate height if RowHeight is provided

* [Controls] More Hanselforms stuff

* [MacOS] Once again a new implementation for the NavigationBar, this time using a custom view to support BackgroundColor

* [MacOS] Fix build

* [MacOS] Refactoring AwesomeBar related controls

* Fix build

* [MacOS] NavigationBar update background and t test colors

* [MacOS] Fix when we remove navigation so it works when the NavigationRenderer wasn't removed from the parent controller like in a TabbedPage

* [MacOS] Add support for ListView  grouping

* [MacOS] Fix image extension method.

* [MacOS] Add base Maps project

* [MacOS] Export MapRenderer

* [MacOS] Add pin click and geocoderbacked for Maps

* [MacOS] Add extra binding project for API not in stable.

* [MacOS] Add MacOS Maps lib

* [MacOS]Fix build on alpha

* [MacOS] Remove MacOS Maps extra binding

* [UITest] Basic macOS setup

* [UITest] Add MacOSApp wrapper implementation

* [MacOS] Set AutomationID

* [UITests] Add ActionSheetUITests to MacOS UITest

* [MacOS] Fix bug on Picker

* [UITests] Link basic uitest basefixture and related files

* [MacOS] Fix pickers reuse

* [UItests] Fix MacOS app path

* [UITest] Ignore UItest for appearing on macOS for now

* [UITest] Update macOS for 2.0.3

* [UITest] Refactor EnterText MacOS app

* [UITest]Fix ViewQuery on MacOS

* [UITest]Fix IsEnabled UItest on macOS

* [UITest] Implement Enter, mark some tests inconclusive fix others

* [MacOS] Implement Entry Completed event

* [UITests] Fix UITest for IsVisible, ignore ToolbarItem test for now

* [UITests] Fix ISVisible again add extra category

* [Controls] Cleanup macOS gallery

* [MacOS] Fix Assembly info

* [Docs] Fix docs

* Fix build

* [Nuget] Fix nuspec

* [Controls] Link files on MacOS

* [Core] Update Forms stack before firing a event saying page was removed, possible breaking change

* [MacOS] Implement RemovePage on NavigationPAgeRenderer

* [UItest] Ignore some , implement back on MacOS UITest app

* [MacOS] Add default back button name (needs to be translated)

* [MacOS] Fix dispose

* [UITest] Make 29257 work on MacOS

* [MacOS] Rename stuff

* [MacOS] More renaming and cleanup

* [MacOS] Share implementations for iOS

* [MacOS] Reuse more IOS extensions

* [MacOS] Reuse FontExtensions

* [MacOS] Share NativeViewWrapper related stuff

* [MAcOS] Share event args and ExportRenderer

* [MacOS] Share platform effect

* [MacOS] Fix build

* [Docs]Fixing docs

* [MacOS] Fix ViewCell reuse

* [Core] Support ListView CachingStrategy on MacOS

* [MacOS] Fix issues with TextCell and ImageCell (we can’t set null to a NSControl value)

* [MacOS] Fix MDP child sizing bug
[UITest] Query marked by id and text

* [MacOS] Comment test related with context actions

* [MacOS] Implement missing stuff on ticker

* [MacOS] Make sure VisualElemenTracker calls the ticker update

* [UITests]Ignore context actions and not possible to test

* [MacOS] Fix Grouping bug on Listview

* [MacOS] Fix selection on Listview when using grouping

* [MacOS] Update navbar when page is popped

* [MacOS] Cleanup NavigationBar

* [Controls] More info on exceptions

* [MacOS] Fix bug animation pop modal

* [MacOS] Bring back BackgroundColor of NavigationBar

* [MacOS] Fix UITest animation delay

* [MacOS] Treat warnings as errors

* [MacOS] Center title on toolbar

* [Core] Add Platform configuration specific for MacOS

* [MacOS] Implement TabbedPage platform specific to handle TabItems on NavigationPage bar

* [MacOS] Fix warning

* [MacOS] Fix bug on SearchBar color

* [MacOS]Fix build

* [MacOS] remove extra dll from maps

* [Docs] Update docs

* [MacOS]Cleanup and refactoring

* Revert "[MacOS] remove extra dll from maps"

This reverts commit 73b948937001fea3f28449a963d0b94943e07aa0.

* [MacOS] Fix wrong refactoring

* [MacOS] Remove gallery and uitest project

* [MacOS] dix formatting

* [MacOS] Remove extra stuff

* Merge branch 'master' into macOS-gallery

* [MacOS] Fix rebase

* [MacOS] Fix TargetPlatform

* fix docs

* [MacOS] Fix bug on TabbedPageRenderer no title

* [MacOS] Remove FormsNSView

* [MacOS] Cleanup on dispose on MDP renderer

* [MacOS] Update current page when source changes

* [MacOS] More cleanup

* [MacOS] Make sure we show the previous page when popping a Modal

* [MacOS] Fix issue with sizing the Header and visibility, remove for now header renderer reuse

* [MacOS] Clean CustomNSTableView

* [MacOS] Share LabelRenderer with iOS

* [MacOS] Share ResourcesProvider with iOS

* [MAcoS] Share VisualElementPackager with iOS

* [MacOS] Share ViewRenderer with iOS

* [MacOS] Merge with VisualElementTracker from iOS

* [MacOS] Merge with EventTracker from iOS

* [MacOS] Merge with VisualElementRenderer of iOS

* [MacOS] Make sure we always have a layer

* [MacOS] Fix Tracker merge with iOS version

* [MacOS] Fix bug with tabbed page on modal without navigation

* [Core] Rever change on core

* [MacOS] Clear renderers before setting them MDP

* [MacOS] Update tabbedPage ContainerArea

* [MacOS] Fix ListViewRenderer

* [MacOS] Make sure we don’t pass null to TextField string value

* [MacOS] Support for multiple clicks in same selected item on NSTableView

* [MacOS] Support Focus on EntryRenderer

* [MacOS] Fix index bug on TablevIewDataSource

* [MacOS] Fix SelectedItem TableViewDataSource

* [Nuget] Add Mac to Maps nuspec

* [Nuget]Fix path

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705)

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer

* Coding Style

* Coding Style

* [MacOS] Fix previous merge with master

* [MacOS] Possible simple fix for click on views overlapping

* [MacOS] Rename to IsOnViewCell

* [MacOS] Cleanup, Address feedback from Samantha’s review

7 years ago[Xaml[C]] Do not instantiate DataTemplate Content at parsing time (#683)
Stephane Delcroix [Wed, 25 Jan 2017 13:47:27 +0000 (14:47 +0100)]
[Xaml[C]] Do not instantiate DataTemplate Content at parsing time (#683)

* [Xaml] rename VisitChildrenFirst

* [Xaml] rework SkipChildren in XamlNode

* [Xaml] fix 45179

* fix

7 years agoFix build
Rui Marinho [Wed, 22 Mar 2017 17:18:57 +0000 (17:18 +0000)]
Fix build

7 years agoFix build
Rui Marinho [Tue, 14 Mar 2017 19:20:25 +0000 (19:20 +0000)]
Fix build

7 years agoFix build
Rui Marinho [Fri, 10 Mar 2017 15:05:46 +0000 (15:05 +0000)]
Fix build

7 years agoFix build
Rui Marinho [Thu, 9 Mar 2017 19:19:44 +0000 (19:19 +0000)]
Fix build

7 years ago[UWP] Fixes for usage of XF with .net native toolchain (#1024)
Rui Marinho [Wed, 28 Jun 2017 20:25:23 +0000 (21:25 +0100)]
[UWP] Fixes for usage of XF with .net native toolchain (#1024)

* [UWP]Add required info for .net native when using AccessibilityView on UWP

* [UWP] Add reference to xaml assembly

* [UWP] Change rd.xml to be a embeded resource

* [UWP] Move code to the right place

* [UW]Only specify namespace we need

7 years ago[UWP] Make sure to update HitTestVisible when IsEnable changes (#1015)
Rui Marinho [Mon, 26 Jun 2017 18:13:37 +0000 (19:13 +0100)]
[UWP] Make sure to update HitTestVisible when IsEnable changes (#1015)

7 years ago[Android] Dispose check before setting properties on Button (#1013)
Samantha Houts [Mon, 26 Jun 2017 18:11:53 +0000 (11:11 -0700)]
[Android] Dispose check before setting properties on Button (#1013)

7 years agoAdd missing member variable to FormsApplicationActivity
E.Z. Hart [Mon, 26 Jun 2017 17:17:25 +0000 (11:17 -0600)]
Add missing member variable to FormsApplicationActivity

7 years agoFix NRE when background color of button set in FormsApplicationActivity (#1010)
E.Z. Hart [Sat, 24 Jun 2017 00:29:38 +0000 (18:29 -0600)]
Fix NRE when background color of button set in FormsApplicationActivity (#1010)

7 years agoFix border on android buttons (#941)
Rui Marinho [Thu, 1 Jun 2017 10:27:12 +0000 (11:27 +0100)]
Fix border on android buttons  (#941)

* [Android] Add a button background tracker to handle background and border properties and be shared between button renderers

* [Android]Fix border radius dependency

* [Android] Make sure we always create or updated the background button tracker

7 years ago[iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (...
Samantha Houts [Fri, 23 Jun 2017 10:37:00 +0000 (03:37 -0700)]
[iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (#994)

* Add repro for 56896

* [iOS] Cached defined row heights for estimation

* [iOS] Null check source

7 years agoSet the Id field for Android Views created by Forms #1004
E.Z. Hart [Thu, 22 Jun 2017 22:33:03 +0000 (16:33 -0600)]
Set the Id field for Android Views created by Forms #1004

7 years agoFix build
Rui Marinho [Thu, 22 Jun 2017 19:12:59 +0000 (20:12 +0100)]
Fix build

7 years agoFix possible crash on API 21+ at launch when using Holo theme and FormsApplicationAct...
Jimmy Garrido [Thu, 22 Jun 2017 18:49:39 +0000 (11:49 -0700)]
Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (#961)

* Fix possible crash on API 21+ at launch

* Do not use an explicit cast

* Do not use C# 7 pattern matching

7 years ago[Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (#915)
Samantha Houts [Thu, 22 Jun 2017 18:19:26 +0000 (11:19 -0700)]
[Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (#915)

* [Android] Concatenate Name/HelpText better

Also remove some parameters that were added to workaround an issue that
no longer exists.

* Add repro

* Listen to Stephane

he's usually right

* oops, didn't save

7 years agoRemove debug outputs (#1008)
Paul DiPietro [Thu, 22 Jun 2017 17:52:38 +0000 (12:52 -0500)]
Remove debug outputs (#1008)

7 years agoAdd check for instance of UITableView (#885)
Matthias [Thu, 27 Apr 2017 14:42:12 +0000 (16:42 +0200)]
Add check for instance of UITableView (#885)

7 years ago[XamlC] fix release builds of Xaml Unit Tests
Stephane Delcroix [Wed, 17 May 2017 11:20:22 +0000 (13:20 +0200)]
[XamlC] fix release builds of Xaml Unit Tests

7 years agoDispose check on ButtonRenderer (#975)
bentmar [Mon, 12 Jun 2017 09:22:32 +0000 (11:22 +0200)]
Dispose check on ButtonRenderer (#975)

Check if buttonrenderer is disposed when making changes

7 years ago[previewer] make sure we do not crash even if the previewer doesn't s… (#946)
Stephane Delcroix [Thu, 1 Jun 2017 07:12:00 +0000 (09:12 +0200)]
[previewer] make sure we do not crash even if the previewer doesn't s… (#946)

* [previewer] make sure we do not crash even if the previewer doesn't sets the flag

* make the tests pass

7 years ago[XamlC] fix build
Stephane Delcroix [Tue, 16 May 2017 19:12:20 +0000 (21:12 +0200)]
[XamlC] fix build

7 years agoRemove VisualElement finalizer (#918)
E.Z. Hart [Tue, 16 May 2017 17:27:41 +0000 (11:27 -0600)]
Remove VisualElement finalizer (#918)

* [Controls] Add repo for bugzilla 55365

* Remove finalizer from VisualElement

* Remove unused using directive

* Removing test for 44074

* Update docs

7 years ago[XamlC] process symbols if DebugType is set (#925)
Stephane Delcroix [Tue, 16 May 2017 17:07:31 +0000 (19:07 +0200)]
[XamlC] process symbols if DebugType is set (#925)

7 years ago[C] fix BP declaring Types for A11y (#913)
Stephane Delcroix [Wed, 10 May 2017 18:07:37 +0000 (20:07 +0200)]
[C] fix BP declaring Types for A11y (#913)

7 years ago[All] Rename Accessibility -> AutomationProperties (#912)
Samantha Houts [Wed, 10 May 2017 17:20:57 +0000 (10:20 -0700)]
[All] Rename Accessibility -> AutomationProperties (#912)

* [All] Renamed Accessibility -> AutomationProperties

* Update docs

* Restore doc summaries

* Revert unintended csproj changes

7 years agoFix build
Rui Marinho [Wed, 10 May 2017 15:05:27 +0000 (16:05 +0100)]
Fix build

7 years ago[Core] Accessibility works with XamlC (#911)
Samantha Houts [Wed, 10 May 2017 06:50:20 +0000 (23:50 -0700)]
[Core] Accessibility works with XamlC (#911)

* Add unit tests for a11y XAML parsing

* [Core] Add Get/Set methods for XamlC

* Update docs

* Fix rogue blank line

7 years agoFix bugzilla55542 (#898)
Rui Marinho [Thu, 4 May 2017 14:27:30 +0000 (15:27 +0100)]
Fix bugzilla55542 (#898)

* [Controls] Add repo for bugzilla 55542

* [Core] Fix caching null renderer for ViewCell view

7 years ago[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602...
Koen Hendriks [Thu, 4 May 2017 14:08:30 +0000 (16:08 +0200)]
[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)

* [Android] Add null check before creating and drawing canvas bugzilla 55559 & bugzilla 45602.

* [Android] REFACTOR Add null check before creating and drawing canvas bugzilla 55559 & 45602 #899

7 years agoGive layouts a chance to handle touch events after passing though immediate children...
E.Z. Hart [Thu, 4 May 2017 09:51:01 +0000 (03:51 -0600)]
Give layouts a chance to handle touch events after passing though immediate children (#902)

* Repro for Bugzilla 55912

* Automate test

* Give the layout a chance to actually handle gestures before bubbling up

7 years agoAdd disposed check on FastRenderer.VisualElemen... (#888)
bentmar [Fri, 28 Apr 2017 09:27:15 +0000 (11:27 +0200)]
Add disposed check on FastRenderer.VisualElemen... (#888)

7 years ago[Android] Add disposed check on FastRenderers.LabelRenderer (#886)
bentmar [Fri, 28 Apr 2017 09:15:09 +0000 (11:15 +0200)]
[Android] Add disposed check on FastRenderers.LabelRenderer (#886)

* add disposed check on FastLabelRenderer

Description of Change

Check is the Label is dispodes on GetDesiredSize() on fast LabelRenderer

Bugs Fixed

System.ObjectDisposedException: Cannot access a disposed object.

API Changes

None

Behavioral Changes

None

* Update LabelRenderer.cs

7 years agoadd disposed check on FastRenderers.FrameRenderer (#887)
bentmar [Fri, 28 Apr 2017 09:14:42 +0000 (11:14 +0200)]
add disposed check on FastRenderers.FrameRenderer (#887)

7 years ago[iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
Samantha Houts [Tue, 2 May 2017 23:18:05 +0000 (16:18 -0700)]
[iOS] Null Element before disposing trial renderers in uneven ListViews (#894)

* Add repro for 55745

* [iOS] Null Element before disposing trial renderers

7 years ago[Xaml] move ValueConverterProvider to Core (#890)
Stephane Delcroix [Fri, 28 Apr 2017 19:11:38 +0000 (21:11 +0200)]
[Xaml] move ValueConverterProvider to Core (#890)

* [Xaml] move ValueConverterProvider to Core

* [docs] fix docs

7 years ago[XamlC] support valueTypes x:Arrays (#875)
Stephane Delcroix [Thu, 27 Apr 2017 09:17:27 +0000 (11:17 +0200)]
[XamlC] support valueTypes x:Arrays (#875)

7 years agoMerge master
Jason Smith [Wed, 26 Apr 2017 17:11:46 +0000 (10:11 -0700)]
Merge master

7 years agoAdd netstandard group to nuspec (#884)
Samantha Houts [Tue, 25 Apr 2017 21:43:51 +0000 (14:43 -0700)]
Add netstandard group to nuspec (#884)

7 years agoBetter error handling for image loading errors on iOS/Android (#849)
E.Z. Hart [Tue, 25 Apr 2017 18:16:25 +0000 (12:16 -0600)]
Better error handling for image loading errors on iOS/Android (#849)

* First run at removing async void image update methods

Consistent error logging and IsLoading on Android,iOS,UWP

Move error logging into image handlers for better messages

Add demo of custom ImageRenderer error handling

Update docs

Make the test smaller so the results don't get pushed offscreen

Fix namespace error

* Update error handling for fast image renderer

* Update 37625 test to use image we control

* Add java disposed check to avoid ObjectDisposedException in async operations

* Add disposed checks to legacy renderer; null check element before SetIsLoading

* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check

* Check for disposal after async handlers in iOS

* Add disposal checks after async methods in Windows

* Reset linker settings on project; reduce redundant casts in ImageViewExtensions

7 years ago[XamlC] Check param type in op_Implicit (#876)
Stephane Delcroix [Tue, 25 Apr 2017 18:15:36 +0000 (20:15 +0200)]
[XamlC] Check param type in op_Implicit (#876)

7 years ago[iOS] Prevent NRE in ListView OnItemSelected (#883)
Samantha Houts [Tue, 25 Apr 2017 18:14:16 +0000 (11:14 -0700)]
[iOS] Prevent NRE in ListView OnItemSelected (#883)

* Add repro

* [iOS] Prevent NRE in ListView

* [Android] Prevent NRE in ListView

Not observed, but adding defensive check just in case

7 years ago[Xaml] OnPlatform.Default value (#873)
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)

* [Xaml] OnPlatform.Default value

* docs

7 years ago[Xaml] OnPlatform.Default value (#873)
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)

* [Xaml] OnPlatform.Default value

* docs

7 years ago[XamlC] support nested types type declarations (#872)
Stephane Delcroix [Thu, 20 Apr 2017 19:06:00 +0000 (21:06 +0200)]
[XamlC] support nested types type declarations (#872)

7 years ago[XamlC] allow namespaces in {x:Type} markups (#867)
Stephane Delcroix [Thu, 20 Apr 2017 18:53:13 +0000 (20:53 +0200)]
[XamlC] allow namespaces in {x:Type} markups (#867)

* [XamlC] allow namespaces in {x:Type} markups

* missing test

7 years agoMake OnElementPropertyChanged virtual on fast renderers (#870)
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)

7 years agocalling API not available in all versions (#877)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)

7 years agocalling API not available in all versions (#877)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)

7 years ago[Xaml][test] Passing test for Bz55343
Stephane Delcroix [Wed, 19 Apr 2017 08:37:01 +0000 (10:37 +0200)]
[Xaml][test] Passing test for Bz55343

7 years ago(Passing) test for 54977
Stephane Delcroix [Tue, 18 Apr 2017 12:47:35 +0000 (14:47 +0200)]
(Passing) test for 54977

7 years agoMake OnElementPropertyChanged virtual on fast renderers (#870)
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)

7 years agoREADME: add macOS to list of supported platforms (#871)
Andres G. Aragoneses [Tue, 18 Apr 2017 09:27:10 +0000 (17:27 +0800)]
README: add macOS to list of supported platforms (#871)

Support was added in https://github.com/xamarin/Xamarin.Forms/pull/650
(https://github.com/xamarin/Xamarin.Forms/commit/52fc04724fc163c68c54cf33a5931871f8c1ee8e)

7 years agoUpdate ListProxyTest.WeakToWeak so it works in Release mode (#866)
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)

* Update ListProxyTest.WeakToWeak so it works in Release mode

* Disable CS0414 for test

7 years agoVerify FragmentContainer created when queueing fragment transaction (Android) (#865)
E.Z. Hart [Thu, 13 Apr 2017 15:11:50 +0000 (09:11 -0600)]
Verify FragmentContainer created when queueing fragment transaction (Android) (#865)

* Add check for disposed MasterDetailContainer when queueing fragment transaction

* Fix various ObjectDisposedExceptions when setting main page

* Add check for legacy renderers when querying control properties

7 years agoUpdate ListProxyTest.WeakToWeak so it works in Release mode (#866)
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)

* Update ListProxyTest.WeakToWeak so it works in Release mode

* Disable CS0414 for test

7 years ago[Test]Ignore Weak reference test, failing only on release
Rui Marinho [Wed, 12 Apr 2017 18:04:55 +0000 (19:04 +0100)]
[Test]Ignore Weak reference test, failing only on release

7 years ago[UITest]Fix release build
Rui Marinho [Wed, 12 Apr 2017 16:10:18 +0000 (17:10 +0100)]
[UITest]Fix release build

7 years agoResource Manager fix for F# File Resources (Bugzilla 53515) (#825)
Rob Lyndon [Wed, 12 Apr 2017 10:57:13 +0000 (11:57 +0100)]
Resource Manager fix for F# File Resources (Bugzilla 53515) (#825)

* Resource Manager fix for F# File Resources (Bugzilla 53515)

* Changed spaces to tabs and changed the argument name in the ResourceManager.GetId() function.

* Improved the type checking in GetId().

7 years agoMap renderer extensibility (#844)
jcmanke [Tue, 11 Apr 2017 22:52:04 +0000 (17:52 -0500)]
Map renderer extensibility (#844)

* Added extensibility features to Maps

Android MapRenderer:
- Moved map initialization to protected virtual method OnMapReady, called by explicit implementation of IOnMapReady
-  Added protected virtual method CreateMarker for customization of pins

iOS MapRenderer:
- Added protected virtual method CreateAnnotation for customization of pins

Pin:
- Unsealed the Pin class
- Made Label a bindable property

* [Docs] Update docs

7 years agoMarking exposed plumbing internal only in the docs. (#863)
Mike Norman [Tue, 11 Apr 2017 22:51:14 +0000 (17:51 -0500)]
Marking exposed plumbing internal only in the docs. (#863)

* Marking exposed plumbing internal only in the docs.

* Update docs

7 years ago[C] Lookup in RD also lookup in merged RDs (#861)
Stephane Delcroix [Tue, 11 Apr 2017 18:09:06 +0000 (20:09 +0200)]
[C] Lookup in RD also lookup in merged RDs (#861)

7 years agoImplicit impl of controller ifaces (#807)
kingces95 [Tue, 11 Apr 2017 18:02:06 +0000 (14:02 -0400)]
Implicit impl of controller ifaces (#807)

* Simplify ICtrl callsites

* Rebase fix

7 years agoClean up NavigationBar code in Platform (#753)
Jimmy Garrido [Tue, 11 Apr 2017 09:48:41 +0000 (02:48 -0700)]
Clean up NavigationBar code in Platform (#753)

7 years agoSpell correction of FromattedString (#864)
Anders Rasmussen [Tue, 11 Apr 2017 09:03:07 +0000 (11:03 +0200)]
Spell correction of FromattedString (#864)

7 years agoDo not emit implict_op if from/to are same type (#862)
kingces95 [Mon, 10 Apr 2017 06:48:54 +0000 (02:48 -0400)]
Do not emit implict_op if from/to are same type (#862)

7 years ago[Xaml] Set the TargetProperty on ServiceProvider (#847)
Stephane Delcroix [Fri, 7 Apr 2017 07:48:17 +0000 (09:48 +0200)]
[Xaml] Set the TargetProperty on ServiceProvider (#847)

7 years ago[Internal] Normalize Obsolete attributes (#860)
Samantha Houts [Fri, 7 Apr 2017 07:47:33 +0000 (00:47 -0700)]
[Internal] Normalize Obsolete attributes (#860)

* [All] Normalize Obsolete attributes.

Make sure we include the version in which the member was deprecated and
consistent instructions for working around the deprecation, if
applicable.

* Update docs

7 years agoFix 52962; Cont refresh even when pullToRefresh is disabled (#810)
kingces95 [Thu, 6 Apr 2017 21:47:12 +0000 (17:47 -0400)]
Fix 52962; Cont refresh even when pullToRefresh is disabled (#810)

7 years agoMore Xaml generic support (#857)
Stephane Delcroix [Thu, 6 Apr 2017 21:37:59 +0000 (23:37 +0200)]
More Xaml generic support (#857)

* [XamlG] allow x:Name on nested generic types

* [Xaml*] fail on undeclared xmlns

* [XamlC] allow x:Arguments on generic ctors

7 years ago[Xaml[C]] supports 'using:' xmlns declarations (#851)
Stephane Delcroix [Thu, 6 Apr 2017 21:22:50 +0000 (23:22 +0200)]
[Xaml[C]] supports 'using:' xmlns declarations (#851)

7 years agoFix 54334 (#855)
Stephane Delcroix [Thu, 6 Apr 2017 21:13:49 +0000 (23:13 +0200)]
Fix 54334 (#855)

* [C] unset the FromStyle flag on manual setting

* [C] Do not reset overriden values to default

* complete the fix

7 years agoOnResume assumed that _application had been set (#859)
App Bureauet [Thu, 6 Apr 2017 21:11:05 +0000 (23:11 +0200)]
OnResume assumed that _application had been set (#859)

When OnResume is called it should not expect the _application to be set already.
I have an app where I use one activity for showing a splash screen and then it starts an intent to show the main activity containing the application.
This used to work before 2.3.4.224.