Travis Reitter [Tue, 27 Sep 2011 00:57:32 +0000 (17:57 -0700)]
Post-release version bump.
Travis Reitter [Tue, 27 Sep 2011 00:16:50 +0000 (17:16 -0700)]
Release version 0.6.3.2
Travis Reitter [Mon, 26 Sep 2011 23:23:51 +0000 (16:23 -0700)]
Require Tracker 0.12
Closes: bgo#660051 - require tracker 0.12
Travis Reitter [Mon, 26 Sep 2011 22:07:05 +0000 (15:07 -0700)]
Don't assume that "CONNECTED" Tp.Accounts have valid Tp.Connections
There's an in-between state where the Tp.Account is "CONNECTED" but hasn't
finished preparing its Tp.Connection (and thus, it's null).
Closes: bgo#659041 — tpf-persona-store.vala: try to connect to a NULL object
Philip Withnall [Mon, 26 Sep 2011 22:36:39 +0000 (15:36 -0700)]
Ensure we prepare all TpAccounts before trying to use them.
Helps: bgo#659041 - tpf-persona-store.vala: try to connect to a NULL object
Travis Reitter [Mon, 26 Sep 2011 22:44:47 +0000 (15:44 -0700)]
More-tightly scope variable in EDS backend.
Travis Reitter [Mon, 26 Sep 2011 16:44:39 +0000 (09:44 -0700)]
Actually fall back to eds:system in case there's no default address book.
Closes: bgo#660140 - contacts_contact_find_persona_from_store: assertion `store
!= NULL' failed
Christian Kirbach [Sat, 24 Sep 2011 09:03:36 +0000 (11:03 +0200)]
[l10n] Updated German translation
Travis Reitter [Fri, 23 Sep 2011 22:55:39 +0000 (15:55 -0700)]
Trivial NEWS fix.
Travis Reitter [Fri, 23 Sep 2011 22:54:52 +0000 (15:54 -0700)]
Note in the NEWS that we fixed bgo#659732 before the 0.6.3.1 release.
Travis Reitter [Fri, 23 Sep 2011 20:19:14 +0000 (13:19 -0700)]
Post-release version bump.
Travis Reitter [Thu, 22 Sep 2011 16:45:05 +0000 (09:45 -0700)]
Release version 0.6.3.1
Travis Reitter [Fri, 23 Sep 2011 01:26:06 +0000 (18:26 -0700)]
Make sure we source GConf files installed next to us.
Travis Reitter [Fri, 23 Sep 2011 00:00:41 +0000 (17:00 -0700)]
Deal with lingering callbacks in the eds/set-avatar test.
These can be called after we've set this._main_loop = null,
so if we don't check it first, we'll hit warnings (which get
treated as errors).
This isn't an ideal solution, but there doesn't seem to be a
great way to avoid the handlers from firing after we no
longer care (we need something like thaw/freeze_notify(),
except for general signals, not just notify).
Travis Reitter [Thu, 22 Sep 2011 17:37:37 +0000 (10:37 -0700)]
Serialize checks for completion in EDS test.
We were interleaving checks which resulted in inconsistent behavior.
Travis Reitter [Thu, 22 Sep 2011 17:30:15 +0000 (10:30 -0700)]
Exit EDS test early in case multiple signal emissions are in-flight.
This fixes a race between the mainloop being nullified and a dependent
signal handler calling quit() again (no idea how the signals were
getting issued and handled after the initial quit() though).
Raul Gutierrez Segales [Wed, 21 Sep 2011 22:05:42 +0000 (23:05 +0100)]
eds: split up link-personas test and cut relative URI dependency
Though some code might be duplicated, it's healthy to split tests
into different executables to assure our clean-up code (wiping out
GConf entries, shutting down our own session Bus, etc) runs between
tests.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 21:07:27 +0000 (22:07 +0100)]
eds: rework tests so that they don't depend on relative URIs
Previously, tests were build around the assumption that each
Edsf.PersonaStore had an id == ESource.relative_uri. That
stopped being true (because you'll get swallowed by a black
hole in pwithnall's garden if you use relative URIs).
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 15:24:30 +0000 (16:24 +0100)]
e-d-s: use UID instead of relative URI to track ESources
Some e-d-s backends (i.e.: the Exchange one) might not have
a relative URI so we can't rely on it as an address book
identifier. So from now on we use the ESource's UID.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 20:35:20 +0000 (21:35 +0100)]
tpf: no need to use a lambda since callback exists
Raul Gutierrez Segales [Wed, 21 Sep 2011 19:25:54 +0000 (20:25 +0100)]
tpf: don't unprepare the backend if it isn't prepared
Travis Reitter [Wed, 21 Sep 2011 18:09:21 +0000 (11:09 -0700)]
Clean up variables in Tpf test to match Edsf test.
Travis Reitter [Wed, 21 Sep 2011 18:07:37 +0000 (11:07 -0700)]
Check for expected-missing capabilities in PersonaStore tests.
Travis Reitter [Wed, 21 Sep 2011 16:49:02 +0000 (09:49 -0700)]
Use PersonaStore.always_writeable_properties.
This removes references to the deprecated
PersonaStore.can_alias_personas and PersonaStore.can_group_personas
Closes: bgo#659737 - tests fail due to usage of deprecated methods
Colin Walters [Wed, 21 Sep 2011 16:13:31 +0000 (12:13 -0400)]
build: Fix regular expression to extract dlname
The regex writer unintentially made a character range in ".-+".
This was always wrong, but it actively fails when LANG=C.
Closes: bgo#658002 - defective typelib
Raul Gutierrez Segales [Mon, 19 Sep 2011 11:38:08 +0000 (12:38 +0100)]
Deprecate PersonaStore.can-[alias|group]-personas
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658332
Matej Urbančič [Tue, 20 Sep 2011 11:17:07 +0000 (13:17 +0200)]
Updated Slovenian translation
Matej Urbančič [Tue, 20 Sep 2011 11:07:06 +0000 (13:07 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 19 Sep 2011 14:14:53 +0000 (16:14 +0200)]
Updated Slovenian translation
Raul Gutierrez Segales [Mon, 19 Sep 2011 11:09:24 +0000 (12:09 +0100)]
Update NEWS file for next release
Philip Withnall [Sun, 18 Sep 2011 18:32:44 +0000 (19:32 +0100)]
build: Post-release version bump
Philip Withnall [Sun, 18 Sep 2011 18:30:23 +0000 (19:30 +0100)]
build: Release version 0.6.3
Philip Withnall [Sun, 18 Sep 2011 18:01:31 +0000 (19:01 +0100)]
url-details: s/HOMEPAGE/HOME_PAGE/
Quick, before this gets released and frozen!
Philip Withnall [Sun, 18 Sep 2011 17:24:50 +0000 (18:24 +0100)]
eds: Fix potential false matches in _is_in_source_list()
It's possible for the relative URIs of two ESources to be equal (though it's
unlikely). Consequently, we need to compare by UID as well.
Philip Withnall [Fri, 16 Sep 2011 22:34:39 +0000 (23:34 +0100)]
Bug 653623 — Would like a set of standard "type" parameters for UrlDetails
Add some consts for TYPE and some common values for it for UrlFieldDetails.
Closes: bgo#653623
Philip Withnall [Sun, 18 Sep 2011 15:56:23 +0000 (16:56 +0100)]
individual: Prefer set properties over unset ones
I can't believe I didn't notice/think of this when I first wrote this code.
I think my licence to write software should be revoked.
Philip Withnall [Sun, 18 Sep 2011 13:09:12 +0000 (14:09 +0100)]
Update British English translation
Philip Withnall [Sat, 17 Sep 2011 21:16:07 +0000 (22:16 +0100)]
Bug 657738 — Favorite people are not always displayed
Ensure the TpLogger connection in Tpf.PersonaStore is always prepared before
we first attempt to use favourite contact data.
This should fix the situation where IM connections are already prepared before
folks is prepared (i.e. _connection_ready_cb() is called as soon as the
Tpf.PersonaStore is prepared).
Closes: bgo#657738
Marek Černocký [Sat, 17 Sep 2011 20:20:58 +0000 (22:20 +0200)]
Updated Czech translation
Piotr Drąg [Sat, 17 Sep 2011 19:58:43 +0000 (21:58 +0200)]
Updated Polish translation
Philip Withnall [Sat, 17 Sep 2011 11:40:22 +0000 (12:40 +0100)]
i18n: Remove untranslatable identifiers from translatable strings
Also remove some trailing newline characters which don't need translating.
Philip Withnall [Sat, 17 Sep 2011 11:31:40 +0000 (12:31 +0100)]
i18n: Fix a few en_GB-isms in C locale strings
Philip Withnall [Sat, 17 Sep 2011 11:27:10 +0000 (12:27 +0100)]
Bug 658161 — Consistently use “contact” in translatable strings
Use “contact” and “Telepathy contact” where appropriate instead of “persona”,
to try and reduce the amount of technical vocabulary in the translatable
strings.
Closes: bgo#658161
Philip Withnall [Sat, 17 Sep 2011 19:36:43 +0000 (20:36 +0100)]
Bug 646847 — Rename _update () in Trf.Persona
…or just remove it entirely, since it was only called from one place.
Closes: bgo#646847
Philip Withnall [Sat, 17 Sep 2011 18:19:43 +0000 (19:19 +0100)]
eds: Add gender as an always-writeable property
This is because it uses a custom vCard attribute, so no EDS backend actually
says it's supported. We assume that the backends will save these custom
vCard attributes safely.
Philip Withnall [Sat, 17 Sep 2011 17:58:40 +0000 (18:58 +0100)]
Bug 658328 — Return PropertyError.NOT_WRITEABLE from Persona property setters
Only the EDS backend was affected, and it's not been changed to check whether
properties are writeable before attempting to set them.
Closes: bgo#658328
Philip Withnall [Sat, 17 Sep 2011 17:37:22 +0000 (18:37 +0100)]
eds: Remove duplicate change checks from Edsf.Persona.change_avatar()
Helps: bgo#658328
Philip Withnall [Sat, 17 Sep 2011 16:24:30 +0000 (17:24 +0100)]
Bug 658531 — Sometimes avatar caching doesn't work
Work around bug #659324 (in GIO) to ensure that we never close the same FD
more than once when storing avatars to the cache.
Closes: bgo#658531
Philip Withnall [Sat, 17 Sep 2011 16:23:19 +0000 (17:23 +0100)]
eds: Re-use a GTimeZone instance for converting birthday timezones
Every time a GTimeZone is created, /etc/localtime is opened. Reduce this
overhead by sharing a single GTimeZone instance between all Edsf.Personas
for all time.
This makes our strace a little tidier.
Matej Urbančič [Sat, 17 Sep 2011 15:29:32 +0000 (17:29 +0200)]
Updated Slovenian translation
Philip Withnall [Sat, 17 Sep 2011 11:06:15 +0000 (12:06 +0100)]
Update British English translation
Marek Černocký [Fri, 16 Sep 2011 22:07:53 +0000 (00:07 +0200)]
Updated Czech translation
Philip Withnall [Fri, 16 Sep 2011 20:56:07 +0000 (21:56 +0100)]
abstract-field-details: Minor documentation fix
Raul Gutierrez Segales [Thu, 1 Sep 2011 18:29:06 +0000 (19:29 +0100)]
e-d-s: test case for changing primary store
Raul Gutierrez Segales [Thu, 1 Sep 2011 18:31:28 +0000 (19:31 +0100)]
e-d-s: allow setting default address books in tests
Raul Gutierrez Segales [Thu, 15 Sep 2011 14:38:11 +0000 (15:38 +0100)]
e-d-s: notify when an address book is configured as default
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657141
Raul Gutierrez Segales [Thu, 15 Sep 2011 14:33:58 +0000 (15:33 +0100)]
core: add Folks.PersonaStore.user-set-default property
With this property we can tell if a Store (i.e.: an e-d-s address
book) has been marked by the user as his default store (either from
Evo or from GOA, etc).
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657141
Raul Gutierrez Segales [Thu, 15 Sep 2011 13:43:36 +0000 (14:43 +0100)]
IndividualAggregator: improve naming for primary store related methods
Renamed _set_primary_store () to _configure_primary_store () and refactor
the code that actually sets the primary store into _set_primary_store ().
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657141
Raul Gutierrez Segales [Wed, 14 Sep 2011 19:48:47 +0000 (20:48 +0100)]
Let each PersonaStore manage its trust-level
Previously, the IndividualAggregator was in charge of
downgrading and upgrading the trust-level of each
PersonaStore. From now on, we let each Store manage its
trust-level since it's the natural way to do it.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=659075
Philip Withnall [Thu, 15 Sep 2011 21:09:36 +0000 (22:09 +0100)]
Bug 659128 — If a persona store goes away we don't remove its personas
Handle removal of the address books backing Edsf.PersonaStores by notifying
of the removal of all the personas in the store, then emitting
PersonaStore.removed.
Test included.
Closes: bgo#659128
Philip Withnall [Wed, 14 Sep 2011 21:26:04 +0000 (22:26 +0100)]
individual: Prefer data from personas with writeable properties
As an addition to the fix for bgo#657783, if two personas come from stores
which have equal is-primary-store values, we now prefer the persona which
lists the given property as writeable. If both personas list (or don't list)
the property as writeable, we fall back to the given ordering function as
before.
Closes: bgo#657783
Raul Gutierrez Segales [Fri, 16 Sep 2011 13:59:09 +0000 (14:59 +0100)]
tracker: configure primary store for tests via env var
No need for GConf to set up primary store for tests, doing it
via en env var is good enough.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=647909
Raul Gutierrez Segales [Fri, 16 Sep 2011 13:30:12 +0000 (14:30 +0100)]
e-d-s: configure primary store for link-personas test via env var
For tests, it's much simpler to do it via an env variable than via
GConf and we avoid ourselves a dependency.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=647909
Piotr Drąg [Thu, 15 Sep 2011 18:13:51 +0000 (20:13 +0200)]
Updated Polish translation
Raul Gutierrez Segales [Thu, 15 Sep 2011 13:04:13 +0000 (14:04 +0100)]
Folks.Individual: don't use is-writeable in change_avatar
This is a follow-up for commit
96539acd, using PersonaStore.is_writeable
is deprecated in favour of checking Persona.writeable_properties
Philip Withnall [Wed, 14 Sep 2011 22:54:25 +0000 (23:54 +0100)]
build: Clean the .typelib file in clean rather than maintainer-clean
It's built by `make` not the maintainer, so according to
http://www.gnu.org/software/hello/manual/automake/Clean.html it should be
cleaned by `make clean`.
Also remove it from BUILT_SOURCES, since it doesn't belong there.
Travis Reitter [Wed, 14 Sep 2011 22:34:23 +0000 (15:34 -0700)]
Don't distribute the typelib file.
Typelib files are architecture-specific, so they shouldn't be distributed.
Closes: bgo#659095 - Don't distribute typelib file
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:48:17 +0000 (17:48 +0100)]
Folks.Individual: use is-primary-store instead of is-writeable
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:35:07 +0000 (17:35 +0100)]
IndividualAggregator: s/writeable_store/primary_store/g
Renamed _writeable_store to _primary_store to augument clarity.
Also, stop listening and setting is-writeable properties and
work with is-primary-store properties.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324
Raul Gutierrez Segales [Tue, 13 Sep 2011 16:33:44 +0000 (17:33 +0100)]
Folks.PersonaStore: add is-primary-store and deprecate is-writeable
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:12:56 +0000 (18:12 +0100)]
core: use always-writeable instead of is-writeable
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=658324
Raul Gutierrez Segales [Thu, 8 Sep 2011 16:21:10 +0000 (17:21 +0100)]
core: deprecate FOLKS_WRITEABLE_STORE for FOLKS_PRIMARY_STORE
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658323
Raul Gutierrez Segales [Wed, 14 Sep 2011 19:50:40 +0000 (20:50 +0100)]
e-d-s: always open address books (regardless of it existing or not)
This helps Gnome Contacts which needs to make sure that at least
the system address book exists.
Philip Withnall [Mon, 22 Aug 2011 22:54:08 +0000 (23:54 +0100)]
Bug 657065 — Cache keeps around contacts from disabled accounts
Add some extra conditions on loading and storing the Tpf.PersonaStore cache,
so as to prevent loading it when the account is disabled or invalid, and to
prevent storing it unnecessarily.
This also adds some extra debug output to Tpf.PersonaStore's caching methods.
Closes: bgo#657065
Philip Withnall [Wed, 14 Sep 2011 17:34:57 +0000 (18:34 +0100)]
Bug 658002 — defective typelib
Pass the libtool dlname for libfolks.so to g-ir-compiler rather than
libfolks.la.
Closes: bgo#658002
Matej Urbančič [Wed, 14 Sep 2011 13:41:20 +0000 (15:41 +0200)]
Updated Slovenian translation
Rodrigo Moya [Tue, 13 Sep 2011 10:17:37 +0000 (12:17 +0200)]
Remove extra definition of BACKEND_EDS
Raul Gutierrez Segales [Tue, 13 Sep 2011 13:51:48 +0000 (14:51 +0100)]
e-d-s: add test for auto linking via emails and IM addresses
Raul Gutierrez Segales [Tue, 13 Sep 2011 11:44:08 +0000 (12:44 +0100)]
e-d-s: assume certain e-mail addresseses are IM IDs too
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657142
Philip Withnall [Tue, 13 Sep 2011 21:03:02 +0000 (22:03 +0100)]
avatar-cache: Add some more debug output
Piotr Drąg [Tue, 13 Sep 2011 19:22:52 +0000 (21:22 +0200)]
Updated Polish translation
Philip Withnall [Fri, 12 Aug 2011 10:18:16 +0000 (12:18 +0200)]
Bug 633781 — Allow to set avatar on individuals
Make Individual.avatar writeable and write new avatars back to the personas
from writeable persona stores in an individual.
Closes: bgo#633781
Raul Gutierrez Segales [Tue, 13 Sep 2011 09:26:37 +0000 (10:26 +0100)]
build: use AM_MAINTAINER_MODE([enable]) instead of AM_MAINTAINER_MODE
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658894
Philip Withnall [Mon, 12 Sep 2011 20:55:04 +0000 (21:55 +0100)]
Bug 658730 — ngettext (Plural forms) needed…
Use ngettext() instead of gettext() for a plural string.
Closes: bgo#658730
Philip Withnall [Tue, 13 Sep 2011 07:09:27 +0000 (08:09 +0100)]
Bug 658874 — Typo?
Fix a typo in a translatable string in the Tracker backend.
Closes: bgo#658874
Philip Withnall [Mon, 12 Sep 2011 22:31:06 +0000 (23:31 +0100)]
Bug 658331 — Ensure read-only PersonaStores have empty writeable-properties
Ensure that Edsf.PersonaStore.always-writeable-properties is empty for
EDS address books which are read-only. Similarly, ensure that
Edsf.Persona.writeable-properties is also empty for such address books (which
follows because it passes through the value of always-writeable-properties).
No other backends need modifying for this, since no others have a concept
of “read only” except libsocialweb, which already has empty
writeable-properties properties.
Closes: bgo#658331
Raul Gutierrez Segales [Tue, 13 Sep 2011 10:45:17 +0000 (11:45 +0100)]
e-d-s: only emit notifications if properties have changed
This is a follow-up for what was suggested in:
https://bugzilla.gnome.org/show_bug.cgi?id=658411
about dealing with updating properties and emitting notifications.
Philip Withnall [Mon, 12 Sep 2011 22:09:10 +0000 (23:09 +0100)]
Bug 658631 — crash at empathy startup
In the case that a persona is removed and the individual containing that
persona is replaced by a different non-null individual which doesn't contain
that persona (because it's been removed), we need to set the persona's
individual pointer to null rather than the replacement individual.
This stops us tripping the assertion in the setter for Persona.individual.
Closes: bgo#658631
Philip Withnall [Mon, 12 Sep 2011 22:07:33 +0000 (23:07 +0100)]
individual-aggregator: Add some more debug output
It turns out to be really useful to see what's being emitted by
IndividualAggregator.individuals-changed-detailed.
Daniel Nylander [Mon, 12 Sep 2011 18:26:31 +0000 (20:26 +0200)]
Added Swedish translation
Marek Černocký [Sun, 11 Sep 2011 09:15:34 +0000 (11:15 +0200)]
Czech translation
Marek Černocký [Sun, 11 Sep 2011 09:15:15 +0000 (11:15 +0200)]
Added Czech language
Alexander Larsson [Fri, 9 Sep 2011 12:52:17 +0000 (14:52 +0200)]
e-d-s: Make sure consecutive property changes work
Don't send any notification due to property changes until we've
done updating an entire persona, otherwise code that listens to
such notifies will see the persona in an intermediate state, whic
can cause problems. For instance, if such a callback tries to
change a property it might not recieve change notification for it.
Alexander Larsson [Fri, 9 Sep 2011 08:25:37 +0000 (10:25 +0200)]
e-d-s: Make sure we clear old attributes when setting im_addresses
The previous code called e_contact_get_attributes() which returns
a copy of the attributes, and tried to remove it with
e_vcard_remove_attribute () which matches on pointer values, so
it always failed.
Piotr Drąg [Thu, 8 Sep 2011 20:26:56 +0000 (22:26 +0200)]
Added Polish translation
Raul Gutierrez Segales [Thu, 8 Sep 2011 18:21:21 +0000 (19:21 +0100)]
Post-release version bump
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:51:29 +0000 (18:51 +0100)]
Release version 0.6.2.1
Raul Gutierrez Segales [Thu, 8 Sep 2011 17:19:35 +0000 (18:19 +0100)]
IndividualAggregator: copy the list of stores before looping over it
Because a Backend's list of PersonaStores can change while we are
iterating it, we do a copy before starting.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658580
Raul Gutierrez Segales [Thu, 8 Sep 2011 09:53:15 +0000 (10:53 +0100)]
NEWS: add new section for next release
Raul Gutierrez Segales [Thu, 8 Sep 2011 09:53:00 +0000 (10:53 +0100)]
Post-release version bump