Steve Hay [Sun, 15 Sep 2013 18:04:04 +0000 (19:04 +0100)]
perldelta - Module upgrades
Steve Hay [Sun, 15 Sep 2013 17:44:56 +0000 (18:44 +0100)]
perldelta - A little copy-editing
Steve Hay [Sun, 15 Sep 2013 16:27:30 +0000 (17:27 +0100)]
perldelta - Restore
525553cafc, accidentally undone by
e7f2d65136
David Mitchell [Sun, 15 Sep 2013 11:02:05 +0000 (12:02 +0100)]
ExtUtils::ParseXS: bump version of related modules
9b2d7314c3d60 bumped $VERSION in ParseXS.pm from 3.22 to 3.23,
but left the other .pm files at .22. This stops ExtUtils::ParseXS from
loading, so bump all the other modules in this distribution too.
Father Chrysostomos [Sun, 15 Sep 2013 06:25:04 +0000 (23:25 -0700)]
perldelta for
429a25554/#28380,#114024
Father Chrysostomos [Sun, 15 Sep 2013 06:22:10 +0000 (23:22 -0700)]
perldelta for
b846c0c86e5
Father Chrysostomos [Sun, 15 Sep 2013 06:20:51 +0000 (23:20 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 06:19:11 +0000 (23:19 -0700)]
Increase $ExtUtils::ParseXS::VERSION to 3.23
There has been another change (
e15ca23a9) since the last CPAN
release. Would that cmp_version.t could catch this!
Father Chrysostomos [Sun, 15 Sep 2013 06:15:37 +0000 (23:15 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 06:14:51 +0000 (23:14 -0700)]
perldelta for
eaaaaa32882752
Father Chrysostomos [Sun, 15 Sep 2013 06:12:54 +0000 (23:12 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 06:10:03 +0000 (23:10 -0700)]
known_pod_issues: Add Devel::CallParser
Father Chrysostomos [Sun, 15 Sep 2013 06:06:52 +0000 (23:06 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 06:05:13 +0000 (23:05 -0700)]
perldelta: two more to-do items
Father Chrysostomos [Sun, 15 Sep 2013 06:02:23 +0000 (23:02 -0700)]
perldelta for
8c9d3376fbf
Father Chrysostomos [Sun, 15 Sep 2013 06:00:20 +0000 (23:00 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 05:57:48 +0000 (22:57 -0700)]
perldelta for 7601007
Father Chrysostomos [Sun, 15 Sep 2013 05:54:53 +0000 (22:54 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 05:53:11 +0000 (22:53 -0700)]
perldelta for
ffdb8b167e/#3643
Father Chrysostomos [Sun, 15 Sep 2013 05:50:48 +0000 (22:50 -0700)]
perldelta for
25502127/#115768
Father Chrysostomos [Sun, 15 Sep 2013 05:47:20 +0000 (22:47 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 04:55:49 +0000 (21:55 -0700)]
perldelta: A to-do item
Father Chrysostomos [Sun, 15 Sep 2013 02:41:50 +0000 (19:41 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 02:39:27 +0000 (19:39 -0700)]
perldelta for
25375124d/#119311
Father Chrysostomos [Sun, 15 Sep 2013 02:31:48 +0000 (19:31 -0700)]
perldelta: correct re description
Father Chrysostomos [Sun, 15 Sep 2013 02:36:18 +0000 (19:36 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 02:27:57 +0000 (19:27 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 02:25:18 +0000 (19:25 -0700)]
perldelta for regexps and 64-bit strings
Father Chrysostomos [Sun, 15 Sep 2013 02:22:45 +0000 (19:22 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 02:20:30 +0000 (19:20 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 02:19:34 +0000 (19:19 -0700)]
perldelta for
c70927a6ffc3ca
Father Chrysostomos [Sun, 15 Sep 2013 02:16:22 +0000 (19:16 -0700)]
perldelta for #119161
Father Chrysostomos [Sun, 15 Sep 2013 01:55:13 +0000 (18:55 -0700)]
perldelta for
bf1b738b6/#118931
Father Chrysostomos [Sun, 15 Sep 2013 01:54:55 +0000 (18:54 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 01:49:03 +0000 (18:49 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 01:46:29 +0000 (18:46 -0700)]
perldelta for
bbfdc870/#118691
Father Chrysostomos [Sun, 15 Sep 2013 01:34:22 +0000 (18:34 -0700)]
perldelta for
ce0d59fdd1c/#7503,#118753
Father Chrysostomos [Sun, 15 Sep 2013 01:29:55 +0000 (18:29 -0700)]
perldelta for
1b268608/#118753
Father Chrysostomos [Sun, 15 Sep 2013 00:36:56 +0000 (17:36 -0700)]
perldelta for
4f62cd62/#118693
Father Chrysostomos [Sun, 15 Sep 2013 00:34:56 +0000 (17:34 -0700)]
perldelta for 3a6ce63
Father Chrysostomos [Sun, 15 Sep 2013 00:34:39 +0000 (17:34 -0700)]
Father Chrysostomos [Sun, 15 Sep 2013 00:29:37 +0000 (17:29 -0700)]
perldelta: missing fullstop
Father Chrysostomos [Sun, 15 Sep 2013 00:27:50 +0000 (17:27 -0700)]
perl5200delta: Devel::NYTProf is fixed
5.06 works with bleadperl.
Father Chrysostomos [Sun, 15 Sep 2013 00:23:11 +0000 (17:23 -0700)]
Reduce false positives for @hsh{$s} and @ary[$s] warnings
This resolves tickets #28380 and #114024.
Commit
95a31aad5 did something similar to this for the new %hash{...}
syntax. This commit extends it to @ slices and combines the two
code paths.
The heuristics in toke.c can easily produce false positives. So the
op is flagged as being a candidate for the warning. Then when op.c
has the op tree available, it examines it to see whether the heuristic
may have been a false positive.
This avoids bugs with qw "foo bar baz" and sub calls triggering
the warning.
The source code is no longer available for the warning, so we recon-
struct it from the op tree, skipping the subscript if it is anything
other than a const op.
This means that @hash{$foo} comes out as @hash{...} and @hash{foo} as
@hash{"foo"}. It also meeans that @hash{"]"} is displayed correctly
instead of as @hash{"].
Commit
95a31aad5 also modified the heuristic for %hash{...} to exempt
qw altogether. But it did not exempt it if it was preceded by a tab.
So this commit rectifies that.
This commit also improves the false positive detection by exempting
any ops returning lists that can get past toke.c’s heuristic. I went
through the entire list of ops, but I may have missed some.
Also, @ slices on the lhs of = are exempt, as they change the context
and are hence actually useful.
Father Chrysostomos [Sat, 14 Sep 2013 18:14:42 +0000 (11:14 -0700)]
dump.c: Dump SLICEWARNING flag for kv[ah]slice, too
I accidentally omitted this in commit
95a31aad5.
Father Chrysostomos [Sat, 14 Sep 2013 01:25:02 +0000 (18:25 -0700)]
Move ‘Scalar value better written as’ tests from toke to op
I am about to move the warning itself from toke.c to op.c. Moving the
tests, too, makes them easier to find for future maintainters who see
it in op.c.
Father Chrysostomos [Fri, 13 Sep 2013 20:49:33 +0000 (13:49 -0700)]
op.c: Factor out common varname code
Steve Hay [Sat, 14 Sep 2013 12:46:21 +0000 (13:46 +0100)]
Upgrade Encode from version 2.54 to 2.55
Steve Hay [Fri, 13 Sep 2013 22:19:09 +0000 (23:19 +0100)]
Remove a __BORLANDC__ stowaway
Support for __BORLANDC__ was axed (actually, chainsawed) in
378eeda70c.
Steve Hay [Fri, 13 Sep 2013 21:57:59 +0000 (22:57 +0100)]
Fix the VC6 build on Windows following commit
3be8f09452
The VC6 compiler has slightly flaky support for __int64 and chokes on util.c
when using the 64-bit implementation of drand48, so switch it to the 32-bit
version instead.
Craig A. Berry [Fri, 13 Sep 2013 19:59:01 +0000 (14:59 -0500)]
fix O_CREAT without O_TRUNC in cpan/autodie/t/utf8_open.t
Awaiting upstream application as [CPAN RT#87237].
Father Chrysostomos [Fri, 13 Sep 2013 20:13:33 +0000 (13:13 -0700)]
Test kv slices in places that expect %{}
Father Chrysostomos [Fri, 13 Sep 2013 09:10:21 +0000 (02:10 -0700)]
op.c:leave_scope: use mg_free before sv_force_normal
This is part of ticket #119295.
Commit 7fa949d (5.19.3) allowed copy-on-write with compile-time con-
stants. That caused this to fail:
use Variable::OnDestruct:
{
my $h = "foo";
on_destruct $h, sub { warn defined $_[0] ? $_[0] : "undef" };
$x++; # prev statement must not be last in the block
}
It prints undef instead of foo.
It turns out this is much older:
use Variable::OnDestruct;
{
my $h = __PACKAGE__;
on_destruct $h, sub { warn defined $_[0] ? $_[0] : "undef" };
$x++; # prev statement must not be last in the block
}
This one prints undef starting with 5.17.3 (
a6d7a4ac1).
But even before that, this prints undef:
use Variable::OnDestruct;
{
my $h = \1;
on_destruct $h, sub { warn defined $_[0] ? $_[0] : "undef" };
$x++; # prev statement must not be last in the block
}
In all these cases, the scalar is getting undefined before free magic
triggers (Variable::OnDestruct uses free magic).
Usually when a scalar is freed, the magic is triggered before anything
else. When a lexical scalar is ‘freed’ on scope exit (cleared for
reuse on scope entry), the order is different. References, globs and
copy-on-write scalars become undefined (via sv_force_normal) before
magic is triggered.
There is no reason for the order to be different here, and it causes
unpredictable behaviour (you never know when you will or will not have
a cow). So change the order in scope exit to match regular freeing.
Nicholas Clark [Tue, 10 Sep 2013 08:32:24 +0000 (10:32 +0200)]
#ifdef DEBUGGING, not QDEBUGGING, in regcomp.c
Father Chrysostomos [Fri, 13 Sep 2013 08:25:55 +0000 (01:25 -0700)]
[Merge] Key/value hash and array slices
Father Chrysostomos [Fri, 13 Sep 2013 01:13:42 +0000 (18:13 -0700)]
Document the %hash{$scalar} warning
Father Chrysostomos [Thu, 12 Sep 2013 21:30:41 +0000 (14:30 -0700)]
Fewer false positives for %hash{$scalar} warning
Instead of warning in the lexer, flag the op and then warn in op.c,
when the op tree is available, so we don’t end up warning for actual
lists or for sub calls.
Also, only warn in scalar context, as in list context $hash{$scalar}
and %hash{$scalar} do different things.
In op.c we no longer have easy access to the source code, so recon-
struct the hash/array access based on the op tree. This means
%hash{foo} becomes %hash{"foo"}. We only reconstruct constant keys,
so %hash{++$x} becomes %hash{...}. This also corrects erroneous
dumps, like %hash{"} for %hash{"}"}.
Instead of triggering the warning solely based on the op tree, we
still keep the heuristic in toke.c, so that common workarounds for
that warning (e.g., {q<key>} and {("key")}) continue to work.
The heuristic in toke.c is tweaked to avoid warning for qw().
In a future commit I plan to extend this to the existing @array[0] and
@hash{key} warnings, to avoid false positives.
Father Chrysostomos [Sun, 8 Sep 2013 23:11:29 +0000 (16:11 -0700)]
pp.c: Allow 64-bit stack offsets in kv[ah]slice
Father Chrysostomos [Sun, 8 Sep 2013 22:50:46 +0000 (15:50 -0700)]
Improve new slice docs in perldata.pod
Father Chrysostomos [Sun, 8 Sep 2013 21:55:34 +0000 (14:55 -0700)]
perldata.pod: Capitalise =head3 consistently
Father Chrysostomos [Sun, 8 Sep 2013 21:54:40 +0000 (14:54 -0700)]
perldata.pod: consistent spaces after dots
Father Chrysostomos [Sun, 8 Sep 2013 21:51:27 +0000 (14:51 -0700)]
pp.c:pp_kvhslice: remove unused var
Father Chrysostomos [Sun, 8 Sep 2013 21:50:00 +0000 (14:50 -0700)]
Increase $B::Deparse::VERSION to 1.23
Father Chrysostomos [Sun, 8 Sep 2013 21:49:24 +0000 (14:49 -0700)]
Increase $Opcode::VERSION to 1.26
Father Chrysostomos [Sun, 8 Sep 2013 21:48:26 +0000 (14:48 -0700)]
Add new opcodes to Opcode.pm
Father Chrysostomos [Sun, 8 Sep 2013 21:38:24 +0000 (14:38 -0700)]
Sort MANIFEST
Father Chrysostomos [Sun, 8 Sep 2013 21:19:34 +0000 (14:19 -0700)]
Use diag_listed_as two suppress two diag.t failures
Father Chrysostomos [Sun, 8 Sep 2013 21:19:13 +0000 (14:19 -0700)]
Add two missing perldiag entries
Father Chrysostomos [Sun, 8 Sep 2013 21:09:23 +0000 (14:09 -0700)]
Hard-code op name in ck_exists|delete errors
The reason is manifold:
• ck_exists and ck_delete are each only ever called with one op type,
so we can hard-code the op, which takes less code.
• The messages in perldiag are more helpful if they include
the op name.
• Changing them in op.c too avoids the need for
diag_listed_as clutter.
(I know, two of these are not listed in perldiag yet. I’m get-
ting to that.)
Father Chrysostomos [Sun, 8 Sep 2013 20:53:23 +0000 (13:53 -0700)]
Suppress a warning in kvhslice.t
The bugginess of the ‘Scalar value better written as...’ warning
applies to %new{silce} syntax, too.
Ruslan Zakirov [Sun, 8 Sep 2013 18:13:06 +0000 (22:13 +0400)]
update manifest
Ruslan Zakirov [Sun, 8 Sep 2013 15:40:34 +0000 (19:40 +0400)]
short documentation for key/value hash/array slices
Ruslan Zakirov [Sat, 7 Sep 2013 17:41:45 +0000 (21:41 +0400)]
test index/value array slices
Ruslan Zakirov [Tue, 12 Mar 2013 13:00:48 +0000 (17:00 +0400)]
test key/value hash slices
Ruslan Zakirov [Sat, 2 Mar 2013 12:57:41 +0000 (16:57 +0400)]
index/value array slice operation
kvaslice operator that imlements %a[0,2,4] syntax which
result in list of index/value pairs. Implemented in
consistency with "key/value hash slice" operator.
Ruslan Zakirov [Sun, 24 Mar 2013 11:53:12 +0000 (15:53 +0400)]
scalar value %x{'a'} better written as $x{'a'}
Ruslan Zakirov [Wed, 27 Feb 2013 15:39:39 +0000 (19:39 +0400)]
key/value hash slice operation
kvhslice operator that implements %h{1,2,3,4} syntax which
returns list of key value pairs rather than just values
(regular slices).
Nicholas Clark [Wed, 11 Sep 2013 09:26:29 +0000 (11:26 +0200)]
Move BmUSEFUL to the IV slot from the NV slot, simplifying union _xnvu.
This change is made possible by commit
8922e4382e9c1488 (June 2013), which
eliminated BmPREVIOUS, which had been using the IV slot.
Father Chrysostomos [Fri, 13 Sep 2013 01:26:30 +0000 (18:26 -0700)]
Preserve undef identity in const ops
This fixes the one remaining issue in ticket #105906.
Under ithreads, the constants are transferred to the pad at compile
time. Since the pads are AVs, and since AVs used &PL_sv_undef to rep-
resent unused slots, &PL_sv_undef could not be stored in the pad, and
so was copied.
That meant the same constant would produce a different scalar at each
call site:
$ ./perl -Ilib -le 'BEGIN { $::{z} = \undef } for(z,z) { print \$_ }'
SCALAR(0x7fecb38062e0)
SCALAR(0x7fecb3806100)
Commit ce0d59f changed the way AVs work, so now we *can* store
&PL_sv_undef in an AV meaningfully, and there is no longer any need
for this copying hack.
Ricardo Signes [Fri, 13 Sep 2013 01:36:54 +0000 (21:36 -0400)]
convert mktables to parent.pm instead of base.pm
Tony Cook [Fri, 13 Sep 2013 01:51:45 +0000 (11:51 +1000)]
Tony Cook [Fri, 13 Sep 2013 01:34:16 +0000 (11:34 +1000)]
[perl #115928] use a consistent internal rand on all platforms
Tony Cook [Tue, 10 Sep 2013 00:09:43 +0000 (10:09 +1000)]
[perl #115928] we don't use drand48_r or random_r any longer
Removing this should mean that metaconfig will remove the units from
the built Configure
Tony Cook [Mon, 9 Sep 2013 04:06:35 +0000 (14:06 +1000)]
[perl #115928] Configure now selects our internal drand48()
Tony Cook [Thu, 29 Aug 2013 04:52:15 +0000 (14:52 +1000)]
revert config_h.SH changes, now handled by Configure
Tony Cook [Mon, 9 Sep 2013 04:44:57 +0000 (14:44 +1000)]
[perl #115928] a consistent (public) rand() implementation
Based on Yves's random branch work.
This version makes the new random number visible to external modules,
for example, List::Util's XS shuffle() implementation.
I've also added a 64-bit implementation when HAS_QUAD is true, this
should be significantly faster, even on 32-bit CPUs. This is intended to
produce exactly the same sequence as the original implementation.
The original version of this commit retained the "freebsd" name from
Yves's original work for the function and data structure names. I've
removed "freebsd" from most function names so the name isn't an issue
if we choose to replace the implementation,
Ricardo Signes [Mon, 9 Sep 2013 02:26:10 +0000 (22:26 -0400)]
perlreapi: use parent in example, not base
Ricardo Signes [Mon, 9 Sep 2013 02:07:03 +0000 (22:07 -0400)]
overload tests: use parent instead of base
Ricardo Signes [Mon, 9 Sep 2013 02:06:57 +0000 (22:06 -0400)]
XS-Typemap tests: use parent instead of base
Ricardo Signes [Mon, 9 Sep 2013 02:06:21 +0000 (22:06 -0400)]
B: use parent instead of base
Ricardo Signes [Mon, 9 Sep 2013 02:01:47 +0000 (22:01 -0400)]
Pod::Html: use parent instead of base
Ricardo Signes [Mon, 9 Sep 2013 02:01:19 +0000 (22:01 -0400)]
Hash::Util::FieldHash: use parent instead of base
Ricardo Signes [Mon, 9 Sep 2013 02:00:46 +0000 (22:00 -0400)]
FileCache: use parent instead of base
Matthew Horsfall [Thu, 12 Sep 2013 18:26:45 +0000 (14:26 -0400)]
Allow semi-colon on TYPEMAP: line to work without it on the closing delim.
This means:
TYPEMAP: <<FOO;
Something T_IV
FOO
will now work.
Steve Hay [Thu, 12 Sep 2013 21:10:56 +0000 (22:10 +0100)]
perldelta - IO and File::Find have been upgraded
Steve Hay [Thu, 12 Sep 2013 20:57:09 +0000 (21:57 +0100)]
Upgrade perlfaq from version 5.0150043 to 5.0150044
Slaven Rezic [Thu, 12 Sep 2013 12:04:27 +0000 (14:04 +0200)]
File::Find: diagnostics in case of a failed chdir
Father Chrysostomos [Thu, 12 Sep 2013 00:53:03 +0000 (17:53 -0700)]
perldiag: Rewrap an entry for better splain output
John P. Linderman [Thu, 12 Sep 2013 14:15:32 +0000 (16:15 +0200)]
Correct the citation for Peter McIlroy's sorting paper.
Also update John P. Linderman's e-mail address.
Nicholas Clark [Thu, 12 Sep 2013 14:22:51 +0000 (16:22 +0200)]
Update John P. Linderman's e-mail address in AUTHORS.